1790d0ae36
Bump parity-scale-codec to 3.3.0 ( #6666 )
2023-02-03 14:03:38 +00:00
caa5464c15
Add a CI check ensuring the code has license headers ( #6609 )
...
* Introduce a job scanning and ensuring there are licenses
* Showcase a red test
* Add missing licenses
* Cleanup
* Extend the check
* Add missing licenses
* CI trigger
2023-02-03 12:02:23 +00:00
59a8b59fe2
Bump lru from 0.8.1 to 0.9.0 ( #6538 )
...
Bumps [lru](https://github.com/jeromefroe/lru-rs ) from 0.8.1 to 0.9.0.
- [Release notes](https://github.com/jeromefroe/lru-rs/releases )
- [Changelog](https://github.com/jeromefroe/lru-rs/blob/master/CHANGELOG.md )
- [Commits](https://github.com/jeromefroe/lru-rs/compare/0.8.1...0.9.0 )
---
updated-dependencies:
- dependency-name: lru
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-01-22 22:40:49 +01:00
1a1bfd2af9
XCM v3 ( #4097 )
...
* cargo fmt
* Create benchmarks for XCM instructions introduced in v3 (#4564 )
* Create benchmarks for BurnAsset and ExpectAsset
* Add benchmarks for ExpectOrigin and ExpectError
* Add benchmarks for QueryPallet and ExpectPallet
* Add benchmarks for ReportTransactStatus and ClearTransactStatus
* cargo fmt
* Use AllPalletsWithSystem in mocks
* Update XCM generic benchmarks for westend
* Remove default impls for some XCM weight functions
* Fix compilation error
* Add weight_args helper attribute
* Remove manually written XcmWeightInfo
* Parse trailing comma
* Revert "Add weight_args helper attribute"
This reverts commit 3b7c47a6182e1b9227036c38b406d494c3fcf6fd.
* Fixes
* Fixes
* XCM v3: Introduce querier field into `QueryReponse` (#4732 )
* Introduce querier field into QueryReponse
* Convert &Option<MultiLocation> to Option<&MultiLocation>
&Option<T> is almost always never quite useful, most of the time it
still gets converted to an Option<&T> via `as_ref`, so we should simply
make functions that accept Option<&T> instead.
* Fix tests
* cargo fmt
* Fix benchmarks
* Appease spellchecker
* Fix test
* Fix tests
* Fix test
* Fix mock
* Fixes
* Fix tests
* Add test for response queriers
* Update xcm/pallet-xcm/src/lib.rs
* Test for non-existence of querier
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
* Fixes
* Fixes
* Add `starts_with` function to `MultiLocation` and `Junctions` (#4835 )
* add matches_prefix function to MultiLocation and Junctions
* rename matches_prefix to starts_with
* remove unnecessary main in doc comment
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Make use of starts_with in match_and_split
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
* XCM v3: Bridge infrastructure (#4681 )
* XCM bridge infrastructure
* Missing bit of cherry-pick
* Revamped XCM proc macros; new NetworkIds
* Fixes
* Formatting
* ExportMessage instruction and config type
* Add MessageExporter definitions
* Formatting
* Missing files
* Fixes
* Initial bridging config API
* Allow for two-stage XCM execution
* Update xcm/src/v3/mod.rs
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
* XCM crate building again
* Initial bridging primitive
* Docs
* Docs
* More work
* More work
* Merge branch 'gav-xcm-v3' into gav-xcm-v3-bridging
* Make build
* WithComputedOrigin and SovereignPaidRemoteExporter
* Remove TODOs
* Slim bridge API and tests.
* Fixes
* More work
* First bridge test passing
* Formatting
* Another test
* Next round of bridging tests
* Repot tests
* Cleanups
* Paid bridging
* Formatting
* Tests
* Spelling
* Formatting
* Fees and refactoring
* Fixes
* Formatting
* Refactor SendXcm to become two-phase
* Fix tests
* Refactoring of SendXcm and ExportXcm complete
* Formatting
* Rename CannotReachDestination -> NotApplicable
* Remove XCM v0
* Minor grumbles
* Formatting
* Formatting
* Fixes
* Fixes
* Cleanup XCM config
* Fee handling
* Fixes
* Formatting
* Fixes
* Bump
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
* Bump Substrate
* XCM v3: `ExchangeAsset` and Remote-locking (#4945 )
* Asset Exchange and Locks
* Make sure XCM typers impl MaxEncodedLen
* Basic implementation for locks
* Bump Substrate
* Missing files
* Use new API
* Introduce instruction
* Big refactor
* Docs
* Remove deprecated struct
* Remove deprecated struct
* Repot XCM builder tests
* ExchangeAsset test
* Exchange tests
* Locking tests
* Locking tests
* Fixes and tests
* Fixes
* Formatting
* Spelling
* Add simulator test for remote locking
* Fix tests
* Bump
* XCM v3: Support for non-fungibles (#4950 )
* NFT support and a test
* New files.
* Integration tests for sending NFTs
* Formatting
* Broken Cargo features
* Use 2021 edition
* Fixes
* Formatting
* Formatting
* Update xcm/xcm-builder/src/asset_conversion.rs
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
* Update xcm/xcm-builder/src/nonfungibles_adapter.rs
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
* Update xcm/xcm-executor/src/lib.rs
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
* Fixes
* Fixes
* Fixes
* Formatting
* Fixes
Co-authored-by: Bastian Köcher <info@kchr.de >
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
* XCM v3: Context & ID hash (#4756 )
* send_xcm returns message hash
* cargo fmt
* Create topic register and instructions
* Fix weights
* Use tabs
* Sketch out XcmContext
* Fix doc test
* Add the XCM context as a parameter to executor trait fns
* Fixes
* Add XcmContext parameter
* Revert adding context as an arg to SendXcm trait methods
* Revert adding context argument to ConvertOrigin trait methods
* cargo fmt
* Do not change the API of XcmExecutor::execute
* Fixes
* Fixes
* Fixes
* Fixes
* Remove convenience method
* Fixes
* Fixes
* cargo fmt
* Fixes
* Add benchmarks for XCM topic instructions
* cargo run --quiet --profile=production --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=pallet_xcm_benchmarks::generic --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --template=./xcm/pallet-xcm-benchmarks/template.hbs --output=./runtime/westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs
* Remove context argument on FilterAssetLocation
* Fixes
* Remove unused import
* Fixes
* Fixes
* Fixes
* Accept XCM hash parameter in ExecuteXcm trait methods
* cargo fmt
* Properly enable sp-io/std
* Fixes
* default-features = false
* Fixes
* Fixes
* Fixes
* Make XcmContext optional in withdraw_asset
* Fixes
* Fixes
* Fixes
* Modify tests to check for the correct XCM hash
* Small refactor
* cargo fmt
* Check for expected hash in xcm-builder unit tests
* Add doc comment for the optionality of the XCM context in withdraw_asset
* Update xcm/src/v3/traits.rs
* Update xcm/src/v3/traits.rs
* Store XcmContext and avoid rebuilding
* Use ref for XcmContext
* Formatting
* Fix incorrect hash CC @KiChjang
* Refactor and make clear fake hashes
* Fixes
* Fixes
* Fixes
* Fix broken hashing
* Docs
* Fixes
* Fixes
* Fixes
* Formatting
* Fixes
* Fixes
* Fixes
* Remove unknowable hash
* Formatting
* Use message hash for greater identifiability
* Formatting
* Fixes
* Formatting
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
Co-authored-by: Parity Bot <admin@parity.io >
* Fixes
* Fixes
* Fixes
* Fixes
* Formatting
* Fixes
* Formatting
* Fixes
* Fixes
* Formatting
* Formatting
* Remove horrible names
* Bump
* Remove InvertLocation trait (#5092 )
* Remove InvertLocation trait
* Remove unneeded functions
* Formatting
* Fixes
* Remove XCMv1 (#5094 )
* Remove XCMv1
* Remove XCMv1
* Formatting
* Fixes
* Fixes
* Formatting
* derive serialize/deserialize for xcm primitives (#5036 )
* derive serialize/deserialize for xcm primitives
* derive serialize/deserialize for xcm primitives
* update v3
* update v2
Co-authored-by: Gav Wood <gavin@parity.io >
* Update lock
* Fixes
* Add benchmarks for the ExchangeAsset instruction
* `AliasOrigin` instruction stub (#5122 )
* AliasOrigin instruction stub
* Fixes
* Fixes
* Update substrate
* Fixes
* Ensure same array length before using copy_from_slice
* Fixes
* Add benchmarks for the UniversalOrigin instruction
* Remove unused import
* Remove unused import
* Add benchmarks for SetFeesMode instruction
* Add benchmarks for asset (un)locking instructions
* Leave AliasOrigin unbenchmarked
* Fixes after merge
* cargo fmt
* Fixes
* Fixes
* Set TrustedReserves to None on both Kusama and Westend
* Remove extraneous reserve_asset_deposited benchmark
* Fix universal_origin benchmark
* cargo run --quiet --profile=production --features=runtime-benchmarks -- benchmark pallet --chain=westend-dev --steps=50 --repeat=20 --pallet=pallet_xcm_benchmarks::generic --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --template=./xcm/pallet-xcm-benchmarks/template.hbs --output=./runtime/westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs
* Don't rely on skipped benchmark functions
* Fixes
* cargo run --quiet --profile=production --features=runtime-benchmarks -- benchmark pallet --chain=kusama-dev --steps=50 --repeat=20 --pallet=pallet_xcm_benchmarks::generic --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --template=./xcm/pallet-xcm-benchmarks/template.hbs --output=./runtime/kusama/src/weights/xcm/pallet_xcm_benchmarks_generic.rs
* Fix unused variables
* Fixes
* Spelling
* Fixes
* Fix codec index of VersionedXcm
* Allows to customize how calls are dispatched from XCM (#5657 )
* CallDispatcher trait
* fmt
* unused import
* fix test-runtime
* remove JustDispatch type
* fix typo in test-runtime
* missing CallDispatcher
* more missing CallDispatcher
* Update comment `NoteAssetLocked` -> `NoteUnlockable`
* Fixes
* Fixes
* Adjust MultiAssets weights based on new wild card variants
* Fixes
* Fixes
* Fixes
* Fixes
* Fixes
* Some late fixes for XCMv3 (#5237 )
* Maximise chances that trapped assets can be reclaimed
* Do origin check as part of ExportMessage for security
* Formatting
* Fixes
* Cleanup export XCM APIs
* Formatting
* Update xcm/src/v3/junctions.rs
* UnpaidExecution instruction and associated barrier.
* Tighten barriers (ClearOrigin/QueryResponse)
* Allow only 1 ClearOrigin instruction in AllowTopLevelPaidExecutionFrom
* Bi-directional teleport accounting
* Revert other fix
* Build fixes]
* Tests build
* Benchmark fixes
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
* Update Substrate
* Re-export `pub` stuff from universal_exports.rs + removed unecessary clone (#6145 )
* Re-export `pub` stuff from universal_exports.rs
* Removed unnecessary clone
* Use 2D weights in XCM v3 (#6134 )
* Depend upon sp-core instead of sp-runtime
* Make sp-io a dev-dependency
* Use 2D weights in XCM v3
* cargo fmt
* Add XCM pallet migration to runtimes
* Use from_parts
* cargo fmt
* Fixes
* cargo fmt
* Remove XCMWeight import
* Fixes
* Fixes
* Fixes
* Fixes
* Use translate in migration
* Increase max upward message size in tests
* Fix doc test
* Remove most uses of from_ref_time
* cargo fmt
* Fixes
* Fixes
* Add extrinsic benchmarking to XCM pallet
* cargo fmt
* Fixes
* Use old syntax
* cargo fmt
* Fixes
* Remove hardcoded weights
* Add XCM pallet to benchmarks
* Use successful origin
* Fix weird type parameter compilation issue
* Fixes
* ".git/.scripts/bench-bot.sh" runtime westend-dev pallet_xcm
* ".git/.scripts/bench-bot.sh" runtime rococo-dev pallet_xcm
* ".git/.scripts/bench-bot.sh" runtime kusama-dev pallet_xcm
* ".git/.scripts/bench-bot.sh" runtime polkadot-dev pallet_xcm
* Use benchmarked XCM pallet weights
* Fixes
* Fixes
* Use override instead of skip
* Fixes
* Fixes
* Fixes
* Fixes
* ".git/.scripts/bench-bot.sh" runtime polkadot-dev pallet_xcm
* Fixes
* ".git/.scripts/bench-bot.sh" runtime polkadot-dev pallet_xcm
* ".git/.scripts/bench-bot.sh" runtime westend-dev pallet_xcm
Co-authored-by: command-bot <>
* Replace Weight::MAX with 100b weight units
* Add test to ensure all_gte in barriers is correct
* Update xcm/src/v3/junction.rs
Co-authored-by: asynchronous rob <rphmeier@gmail.com >
* Add more weight tests
* cargo fmt
* Create thread_local in XCM executor to limit recursion depth (#6304 )
* Create thread_local in XCM executor to limit recursion depth
* Add unit test for recursion limit
* Fix statefulness in tests
* Remove panic
* Use defer and environmental macro
* Fix the implementation
* Use nicer interface
* Change ThisNetwork to AnyNetwork
* Move recursion check up to top level
* cargo fmt
* Update comment
Co-authored-by: Bastian Köcher <info@kchr.de >
* Add upper limit on the number of overweight messages in the queue (#6298 )
* Add upper limit on the number of ovwerweight messages in the queue
* Add newline
* Introduce whitelist for Transact and limit UMP processing to 10 messages per block (#6280 )
* Add SafeCallFilter to XcmConfig
* Limit UMP to receive 10 messages every block
* Place 10 message limit on processing instead of receiving
* Always increment the message_processed count whenever a message is processed
* Add as_derivative to the Transact whitelist
* cargo fmt
* Fixes
* Update xcm/xcm-builder/src/universal_exports.rs
Co-authored-by: Branislav Kontur <bkontur@gmail.com >
* Fixes
* Fixes
* Remove topic register and instead use the topic field in XcmContext
* Derive some common traits for DispatchBlobError
* Fixes
* cargo fmt
* Fixes
* Fixes
* Fix comments
* Fixes
* Introduce WithOriginFilter and apply it as the CallDispatcher for runtimes
* Fixes
* Appease clippy and fixes
* Fixes
* Fix more clippy issues
* Fixes
* ".git/.scripts/bench-bot.sh" runtime polkadot-dev pallet_xcm
* ".git/.scripts/bench-bot.sh" runtime westend-dev pallet_xcm
* ".git/.scripts/bench-bot.sh" runtime westend-dev pallet_xcm
* Add benchmark function for ExportMessage
* Fix comment
* Add upper limit to DownwardMessageQueues size
* Add max size check for queue in can_queue_downward_message
* Fixes
* Make Transact runtime call configurable
* Return Weight::MAX when there is no successful send XCM origin
* Update substrate
* Fixes
* Fixes
* Remove ExportMessage benchmark
* Remove assertion on Transact instruction benchmark
* Make reachable destination configurable in XCM pallet benchmarks
* Fixes
* Fixes
* Remove cfg attribute in fuzzer
* Fixes
* Remove cfg attribute for XCM pallet in test runtime
* Fixes
* Use ReachableDest where possible
* Fixes
* Add benchmark for UnpaidExecution
* Update substrate
* Ensure benchmark functions pass filters
* Add runtime-benchmarks feature to fuzzer
* Ensure FixedRateOfFungible accounts for proof size weights
* cargo fmt
* Whitelist remark_with_event when runtime-benchmarks feature is enabled
* Use remark_with_event for Transact benchmarks
* Fix Cargo.lock
* Allow up to 3 DescendOrigin instructions before UnpaidExecution
* cargo fmt
* Edit code comment
* Check check_origin for unpaid execution privilege
* Fixes
* Small nits for xcm-v3 (#6408 )
* Add possibility to skip benchmark for export_message
* ".git/.scripts/bench-bot.sh" xcm westend-dev pallet_xcm_benchmarks::generic
* Revert
* ".git/.scripts/bench-bot.sh" xcm westend-dev pallet_xcm_benchmarks::generic
* Add HaulBlobError to `fn haul_blob`
* ".git/.scripts/bench-bot.sh" xcm westend-dev pallet_xcm_benchmarks::generic
Co-authored-by: command-bot <>
* Revert changes to UnpaidExecution
* Change AllowUnpaidExecutionFrom to be explicit
* Fix log text
* cargo fmt
* Add benchmarks for XCM pallet version migration (#6448 )
* Add benchmarks for XCM pallet version migration
* cargo fmt
* Fixes
* Fixes
* Fixes
* ".git/.scripts/bench-bot.sh" runtime westend-dev pallet_xcm
* ".git/.scripts/bench-bot.sh" runtime kusama-dev pallet_xcm
* ".git/.scripts/bench-bot.sh" runtime rococo-dev pallet_xcm
* ".git/.scripts/bench-bot.sh" runtime polkadot-dev pallet_xcm
* Fix benchmarks
* Fix benchmarks
* ".git/.scripts/bench-bot.sh" runtime westend-dev pallet_xcm
* ".git/.scripts/bench-bot.sh" runtime kusama-dev pallet_xcm
* ".git/.scripts/bench-bot.sh" runtime rococo-dev pallet_xcm
* ".git/.scripts/bench-bot.sh" runtime polkadot-dev pallet_xcm
Co-authored-by: command-bot <>
* Merge remote-tracking branch 'origin/master' into gav-xcm-v3
* Fixes
* Fix comments (#6470 )
* Specify Ethereum networks by their chain id (#6286 )
Co-authored-by: Squirrel <gilescope@gmail.com >
* Use for Kusama
* Use WithComputedOrigin for Polkadot, Rococo and Westend
* Update lock
* Fix warning
* Update xcm/pallet-xcm/src/tests.rs
Co-authored-by: Squirrel <gilescope@gmail.com >
* Update runtime/parachains/src/ump/migration.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update xcm/pallet-xcm/src/migration.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fixes
* cargo fmt
* Typo
* Update xcm/src/v3/mod.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Docs
* Docs
* Docs
* Docs
* Docs
* Update xcm/src/v3/multiasset.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add tests for MultiAssets::from_sorted_and_deduplicated
* Fail gracefully when same instance NFTs are detected during push
* Update Substrate to fix benchmarks
* Apply suggestions from code review
* Update runtime/kusama/src/xcm_config.rs
* Rename arguments
* Attempt to fix benchmark
* ".git/.scripts/commands/bench/bench.sh" runtime polkadot-dev runtime_parachains::ump
* Use actual weights for UMP pallet in Polkadot
* ".git/.scripts/commands/bench/bench.sh" runtime kusama-dev runtime_parachains::ump
* ".git/.scripts/commands/bench/bench.sh" runtime westend-dev runtime_parachains::ump
* ".git/.scripts/commands/bench/bench.sh" runtime rococo-dev runtime_parachains::ump
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
Co-authored-by: Alexander Popiak <alexander.popiak@parity.io >
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
Co-authored-by: Bastian Köcher <info@kchr.de >
Co-authored-by: Parity Bot <admin@parity.io >
Co-authored-by: stanly-johnson <stanlyjohnson@outlook.com >
Co-authored-by: nanocryk <6422796+nanocryk@users.noreply.github.com >
Co-authored-by: Branislav Kontur <bkontur@gmail.com >
Co-authored-by: asynchronous rob <rphmeier@gmail.com >
Co-authored-by: command-bot <>
Co-authored-by: Vincent Geddes <vincent.geddes@hey.com >
Co-authored-by: Squirrel <gilescope@gmail.com >
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com >
2023-01-17 07:04:34 +00:00
1cb1d03c08
Re-export current primitives in crate root ( #6487 )
...
* Re-export current primitives in crate root
* Add missing exports
* restart CI
2023-01-11 11:28:12 +00:00
3cf18f11ac
Minor fixes ( #6533 )
...
* Minor fixes
* Fix compile errors
2023-01-10 17:59:12 +00:00
cc650fe53d
Fix cycle dispute-coordinator <-> dispute-distribution ( #6489 )
...
* First iteration of message sender.
* dyn Fn variant (no cloning)
* Full implementation + Clone, without allocs on `Send`
* Further clarifications/cleanup.
* MessageSender -> NestingSender
* Doc update/clarification.
* dispute-coordinator: Send disputes on startup.
+ Some fixes, cleanup.
* Fix whitespace.
* Dispute distribution fixes, cleanup.
* Cargo.lock
* Fix spaces.
* More format fixes.
What is cargo fmt doing actually?
* More fmt fixes.
* Fix nesting sender.
* Fixes.
* Whitespace
* Enable logging.
* Guide update.
* Fmt fixes, typos.
* Remove unused function.
* Simplifications, doc fixes.
* Update roadmap/implementers-guide/src/node/disputes/dispute-coordinator.md
Co-authored-by: Marcin S. <marcin@bytedude.com >
* Fmt + doc example fix.
Co-authored-by: eskimor <eskimor@no-such-url.com >
Co-authored-by: Marcin S. <marcin@bytedude.com >
2023-01-10 12:04:05 +01:00
715e98268a
Use polkadot-node-metrics where possible ( #6484 )
...
See https://github.com/paritytech/polkadot/issues/6015 . (Doesn't close yet,
there might be more we can do.)
2023-01-06 15:01:23 +00:00
b5e44b7075
Adding some more logs ( #6455 )
...
* Adding some more logs
More logs are always better! Joke aside, these logs help to debug
certain issues.
* Apply suggestions from code review
2022-12-17 18:51:39 +01:00
3c1a28276d
Fix wrong rate limit + add a few logs. ( #6440 )
...
* Add trace log
* More tracing.
* Fix redundant rate limit.
* Add trace log.
* Improve logging.
Co-authored-by: eskimor <eskimor@no-such-url.com >
2022-12-15 09:47:06 +00:00
7f020eb527
approval-distribution: batched approval/assignment sending ( #6401 )
...
* Imple batched send
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Add batch tests
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* pub MAX_NOTIFICATION_SIZE
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* spell check
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* spellcheck ...
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Fix comment
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* o.O
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* 2 constants
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Ensure batch size is at least 1 element
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* feedback impl
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
2022-12-13 14:06:05 +02:00
c748250748
Make sure to preserve backing votes ( #6382 )
...
* Guide updates
* Consider more dead forks.
* Ensure backing votes don't get overridden.
* Fix spelling.
* Fix comments.
* Update node/primitives/src/lib.rs
Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io >
Co-authored-by: eskimor <eskimor@no-such-url.com >
Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io >
2022-12-07 17:14:13 +00:00
be403051dc
Set polkadot version in one place ( #6095 )
...
* rust 1.64 enables workspace properties
* add edition, repository and authors.
* of course, update the version in one place.
Co-authored-by: Andronik <write@reusable.software >
2022-12-05 11:36:16 +00:00
7341dbb20d
Add buckets on lower end of distribution to network bridge latency metrics ( #6359 )
...
* Add two more buckets on lower end of distribution
* add even smaller buckets
* cargo fmt
2022-12-02 18:28:24 +02:00
9ea14e66c8
Clippyfy ( #6341 )
...
* Add clippy config and remove .cargo from gitignore
* first fixes
* Clippyfied
* Add clippy CI job
* comment out rusty-cachier
* minor
* fix ci
* remove DAG from check-dependent-project
* add DAG to clippy
Co-authored-by: alvicsam <alvicsam@gmail.com >
2022-11-30 08:34:06 +00:00
b76086c617
sync versions with current release (0.9.33) ( #6363 )
...
* westend: update transaction version
* polkadot: update transaction version
* kusama: update transaction version
* Bump spec_version to 9330
* bump versions to 0.9.33
2022-11-30 10:32:20 +02:00
893a3ad784
Add more granularity to prometheus histogram buckets ( #6348 )
...
* Add buckets below 5ms
* Add more specific histogram buckets
* Add more specific buckets
* cargo fmt
2022-11-28 11:30:27 +00:00
53d9a50c06
Add support for outbound only configs on request/response protocols ( #6343 )
...
* Add option ot add outbound_only configurations
* Improve comment
2022-11-26 10:22:09 +01:00
7ba0847349
Rate limit improvements ( #6315 )
...
* We actually don't need to rate limit redundant requests.
Those redundant requests should not actually happen, but still.
* Add some logging.
* Also log message when the receiving side hit the rate limit.
* Update node/network/dispute-distribution/src/sender/mod.rs
Co-authored-by: Alexandru Vasile <60601340+lexnv@users.noreply.github.com >
Co-authored-by: eskimor <eskimor@no-such-url.com >
Co-authored-by: Alexandru Vasile <60601340+lexnv@users.noreply.github.com >
2022-11-23 16:43:30 +01:00
ccad411e46
Change best effort queue behaviour in dispute-coordinator ( #6275 )
...
* Change best effort queue behaviour in `dispute-coordinator`
Use the same type of queue (`BTreeMap<CandidateComparator,
ParticipationRequest>`) for best effort and priority in
`dispute-coordinator`.
Rework `CandidateComparator` to handle unavailable parent
block numbers.
Best effort queue will order disputes the same way as priority does - by
parent's block height. Disputes on candidates for which the parent's
block number can't be obtained will be treated with the lowest priority.
* Fix tests: Handle `ChainApiMessage::BlockNumber` in `handle_sync_queries`
* Some tests are deadlocking on sending messages via overseer so change `SingleItemSink`to `mpsc::Sender` with a buffer of 1
* Fix a race in test after adding a buffered queue for overseer messages
* Fix the rest of the tests
* Guide update - best-effort queue
* Guide update: clarification about spam votes
* Fix tests in `availability-distribution`
* Update comments
* Add `make_buffered_subsystem_context` in `subsystem-test-helpers`
* Code review feedback
* Code review feedback
* Code review feedback
* Don't add best effort candidate if it is already in priority queue
* Remove an old comment
* Fix insert in best_effort
2022-11-17 15:41:19 +00:00
ad41e56e6e
Dedup subsystem name ( #6305 )
...
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
2022-11-17 12:59:07 +00:00
a0f4287dd9
Provisioner should ignore unconfirmed disputes ( #6294 )
...
* Fix typos
* Filter unconfirmed disputes in provisioner - random_selection
* Rework dispute coordinator to return `DisputeStatus` with
`ActiveDisputes` message.
* Rework the random_selection implementation of `select_disptues` in
`provisioner` to return only confirmed disputes.
* Filter unconfirmed disputes in provisioner - prioritized_selection
* Add test for unconfirmed disputes handling
* Fix `dispute-distribution` tests
2022-11-16 14:39:05 +00:00
d53513ff66
Fixes "for loop over an Option" warnings ( #6291 )
...
Was seeing these warnings when running `cargo check --all`:
```
warning: for loop over an `Option`. This is more readably written as an `if let` statement
--> node/core/approval-voting/src/lib.rs:1147:21
|
1147 | for activated in update.activated {
| ^^^^^^^^^^^^^^^^
|
= note: `#[warn(for_loops_over_fallibles)]` on by default
help: to check pattern in a loop use `while let`
|
1147 | while let Some(activated) = update.activated {
| ~~~~~~~~~~~~~~~ ~~~
help: consider using `if let` to clear intent
|
1147 | if let Some(activated) = update.activated {
| ~~~~~~~~~~~~ ~~~
```
My guess is that `activated` used to be a SmallVec or similar, as is
`deactivated`. It was changed to an `Option`, the `for` still compiled (it's
technically correct, just weird), and the compiler didn't catch it until now.
2022-11-15 09:58:26 -05:00
8eb1f4617f
Use a more typesafe approach for managing indexed data ( #6150 )
...
* Fix for issue #2403
* Nightly fmt
* Quick documentation fixes
* Default Implementation
* iter() function integrated
* Implemented iter functionalities
* Fmt
* small change
* updates node-network
* updates in dispute-coordinator
* Updates
* benchmarking fix
* minor fix
* test fixes in runtime api
* Update primitives/src/v2/mod.rs
Co-authored-by: Andronik <write@reusable.software >
* Update primitives/src/v2/mod.rs
Co-authored-by: Andronik <write@reusable.software >
* Update primitives/src/v2/mod.rs
Co-authored-by: Andronik <write@reusable.software >
* Update primitives/src/v2/mod.rs
Co-authored-by: Andronik <write@reusable.software >
* Update primitives/src/v2/mod.rs
Co-authored-by: Andronik <write@reusable.software >
* Removal of [index], shorting of FromIterator, Renaming of GroupValidators to ValidatorGroups
* Removal of ops import
* documentation fixes for spell check
* implementation of generic type
* Refactoring
* Test and documentation fixes
* minor test fix
* minor test fix
* minor test fix
* Update node/network/statement-distribution/src/lib.rs
Co-authored-by: Andronik <write@reusable.software >
* Update primitives/src/v2/mod.rs
Co-authored-by: Andronik <write@reusable.software >
* Update primitives/src/v2/mod.rs
Co-authored-by: Andronik <write@reusable.software >
* removed IterMut
* Update node/core/dispute-coordinator/src/import.rs
Co-authored-by: Andronik <write@reusable.software >
* Update node/core/dispute-coordinator/src/initialized.rs
Co-authored-by: Andronik <write@reusable.software >
* Update primitives/src/v2/mod.rs
Co-authored-by: Andronik <write@reusable.software >
* fmt
* IterMut
* documentation update
Co-authored-by: Andronik <write@reusable.software >
* minor adjustments and new TypeIndex trait
* spelling fix
* TypeIndex fix
Co-authored-by: Andronik <write@reusable.software >
2022-10-22 08:39:11 +00:00
f8cc39a761
sync versions with current release (0.9.31) ( #6176 )
...
* Bump spec_version to 9310
* bump transaction_version (0.9.31) (#6171 )
* Bump transaction_version for polkadot
* Bump transaction_version for kusama
* Bump transaction_version for rococo
* Bump transaction_version for westend
* Bump transaction_version for polkadot
* Bump transaction_version for kusama
* Bump transaction_version for rococo
* Bump transaction_version for westend
* Bump crate versions (0.9.31)
2022-10-22 00:08:53 -04:00
befaec4cee
availability-recovery: use IfDisconnected::TryConnect for chunks ( #6081 )
...
* availability-recovery: use `IfDisconnected::TryConnect` for chunks
* fix tests
2022-10-18 13:15:49 +00:00
a7780e0797
refactor grid topology to expose more info to subsystems ( #6140 )
...
* refactor grid topology to expose more info to subsystems
* fix grid_topology test
* fix overseer test
* Update node/network/protocol/src/grid_topology.rs
Co-authored-by: Vsevolod Stakhov <vsevolod.stakhov@parity.io >
* Update node/network/protocol/src/grid_topology.rs
Co-authored-by: Andronik <write@reusable.software >
* Update node/network/protocol/src/grid_topology.rs
Co-authored-by: Andronik <write@reusable.software >
* fix bug in populating topology
* fmt
Co-authored-by: Vsevolod Stakhov <vsevolod.stakhov@parity.io >
Co-authored-by: Andronik <write@reusable.software >
2022-10-12 23:30:12 +00:00
4819d12711
Companion for paritytech/substrate#12441 ( #6117 )
...
* Companion for paritytech/substrate#12441
* update lockfile for {"substrate"}
Co-authored-by: parity-processbot <>
2022-10-10 11:13:59 +00:00
e4361b6d80
Fix flaky test ( #6131 )
...
* Split test + decrease test timeout
* fmt
* spellcheck
2022-10-10 08:06:44 +02:00
b13e07bc47
Buffered connection management for collator-protocol ( #6022 )
...
* Extract metrics into a separate module
* Introduce validators buffer
* Integrate buffer into the subsystem
* Only reconnect on new advertisements
* Test
* comma
* doc comment
* Make capacity buffer compile time non-zero
* Add doc comments
* nits
* remove derives
* review
* better naming
* check timeout
* Extract interval stream into lib
* Ensure collator disconnects after timeout
* spellcheck
* rename buf
* Remove double interval
* Add a log on timeout
* Cleanup buffer on timeout
2022-10-05 09:48:50 +02:00
938bc96a2c
Batch vote import in dispute-distribution ( #5894 )
...
* Start work on batching in dispute-distribution.
* Guide work.
* More guide changes. Still very much WIP.
* Finish guide changes.
* Clarification
* Adjust argument about slashing.
* WIP: Add constants to receiver.
* Maintain order of disputes.
* dispute-distribuion sender Rate limit.
* Cleanup
* WIP: dispute-distribution receiver.
- [ ] Rate limiting
- [ ] Batching
* WIP: Batching.
* fmt
* Update `PeerQueues` to maintain more invariants.
* WIP: Batching.
* Small cleanup
* Batching logic.
* Some integration work.
* Finish.
Missing: Tests
* Typo.
* Docs.
* Report missing metric.
* Doc pass.
* Tests for waiting_queue.
* Speed up some crypto by 10x.
* Fix redundant import.
* Add some tracing.
* Better sender rate limit
* Some tests.
* Tests
* Add logging to rate limiter
* Update roadmap/implementers-guide/src/node/disputes/dispute-distribution.md
Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io >
* Update roadmap/implementers-guide/src/node/disputes/dispute-distribution.md
Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io >
* Update node/network/dispute-distribution/src/receiver/mod.rs
Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io >
* Review feedback.
* Also log peer in log messages.
* Fix indentation.
* waker -> timer
* Guide improvement.
* Remove obsolete comment.
* waker -> timer
* Fix spell complaints.
* Fix Cargo.lock
Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io >
2022-10-04 18:02:05 +02:00
a64cc4a860
Bump lru from 0.7.8 to 0.8.0 ( #6060 )
...
* Bump lru from 0.7.8 to 0.8.0
Bumps [lru](https://github.com/jeromefroe/lru-rs ) from 0.7.8 to 0.8.0.
- [Release notes](https://github.com/jeromefroe/lru-rs/releases )
- [Changelog](https://github.com/jeromefroe/lru-rs/blob/master/CHANGELOG.md )
- [Commits](https://github.com/jeromefroe/lru-rs/compare/0.7.8...0.8.0 )
---
updated-dependencies:
- dependency-name: lru
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
* Change `LruCache` paramerter to `NonZeroUsize`
* Change type of `session_cache_lru_size` to `NonZeroUsize`
* Add expects instead of unwrap
Co-authored-by: Bastian Köcher <info@kchr.de >
* Use match to get rid of expects
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sebastian Kunert <skunert49@gmail.com >
Co-authored-by: Bastian Köcher <info@kchr.de >
2022-10-04 11:28:21 +00:00
372e6a95f3
add para_id to fetch_pov logging ( #6084 )
...
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
2022-09-30 11:56:45 +03:00
548b4c6c71
Validate chunks from disk in availability-recovery ( #6078 )
...
* Don't use corrupted chunks from disk.
Otherwise we would be going to dispute the candidate and get slashed.
* Add tests
2022-09-29 14:16:12 +02:00
2a9800f20a
Companion for paritytech/substrate#12264 ( #5973 )
...
* Companion for paritytech/substrate#12198
* Use `ProtocolName` from sc-network-common
* Update node service
* Revert Cargo.lock changes
* Fix node service test
* cargo-fmt
* disable cancel-pipeline-test-linux-stable to check companion
* update lockfile for {"substrate"}
Co-authored-by: alvicsam <alvicsam@gmail.com >
Co-authored-by: parity-processbot <>
2022-09-26 13:15:41 +00:00
6ae9720c36
Improved dispute votes import in provisioner ( #5567 )
...
* Add `DisputeState` to `DisputeCoordinatorMessage::RecentDisputes`
The new signature of the message is:
```
RecentDisputes(oneshot::Sender<Vec<(SessionIndex, CandidateHash, DisputeStatus)>>),
```
As part of the change also add `DispiteStatus` to
`polkadot_node_primitives`.
* Move dummy_signature() in primitives/test-helpers
* Enable staging runtime api on Rococo
* Implementation
* Move disputes to separate module
* Vote prioritisation
* Duplicates handling
* Double vote handling
* Unit tests
* Logs and metrics
* Code review feedback
* Fix ACTIVE/INACTIVE separation and update partition names
* Add `fn dispute_is_inactive` to node primitives and refactor `fn get_active_with_status()` logic
* Keep the 'old' logic if the staging api is not enabled
* Fix some comments in tests
* Add warning message if there are any inactive_unknown_onchain disputes
* Add file headers and remove `use super::*;` usage outside tests
* Adding doc comments
* Fix test methods names
* Fix staging api usage
* Fix `get_disputes` runtime function implementation
* Fix compilation error
* Fix arithmetic operations in tests
* Use smaller test data
* Rename `RuntimeApiRequest::StagingDisputes` to `RuntimeApiRequest::Disputes`
* Remove `staging-client` feature flag
* fmt
* Remove `vstaging` feature flag
* Some comments regarding the staging api
* Rename dispute selection modules in provisioner
with_staging_api -> prioritized_selection
without_staging_api -> random_selection
* Comments for staging api
* Comments
* Additional logging
* Code review feedback
process_selected_disputes -> into_multi_dispute_statement_set
typo
In trait VoteType: vote_value -> is_valid
* Code review feedback
* Fix metrics
* get_disputes -> disputes
* Get time only once during partitioning
* Fix partitioning
* Comments
* Reduce the number of hardcoded api versions
* Code review feedback
* Unused import
* Comments
* More precise log messages
* Code review feedback
* Code review feedback
* Code review feedback - remove `trait VoteType`
* Code review feedback
* Trace log for DisputeCoordinatorMessage::QueryCandidateVotes counter in vote_selection
2022-09-19 23:06:09 +03:00
bbb713521e
gossip-support: disconnect when we're no longer in other's reserved set ( #6024 )
...
* gossip-support: disconnect when we're no longer in the reserved set
* fmt
2022-09-19 19:26:41 +00:00
1acc3fa150
Sync versions with current release (v0.9.29) ( #5982 )
...
* Bump transaction_version for westend
* Bump transaction_version for rococo
* Bump transaction_version for kusama
* Bump transaction_version for polkadot
* Bump spec_version to 9290
* Bump crate versions
2022-09-09 11:24:06 +00:00
b3480bd51f
Use custom type for ProtocolName ( #5963 )
...
* Use new ProtocolName in peer_set.rs
* Use new ProtocolName for request-response protocols
* Use new ProtocolName in polkadot-network-bridge
* Import and conversion fixes
* Use ProtocolName re-exported in sc_network
* update lockfile for {"substrate"}
Co-authored-by: parity-processbot <>
2022-09-04 00:02:01 +02:00
13ea167bd7
Change validation & collation protocol names to include genesis hash & fork id ( #5876 )
2022-08-30 19:50:22 +03:00
fc97080cb2
version bumps (0.9.28) ( #5933 )
...
* Bump crate versions
* Bump spec_version to 9280 for kusama
* Bump spec_version to 9280 for polkadot
* Bump spec_version to 9280 for rococo
* Bump spec_version to 9280 for westend
* update Cargo.lock
Co-authored-by: parity-processbot <>
2022-08-29 18:01:58 +02:00
979483fd80
Fix wrong logic. ( #5931 )
2022-08-25 16:32:31 +02:00
427e7c1ab3
Bump async-trait from 0.1.56 to 0.1.57 ( #5919 )
...
Bumps [async-trait](https://github.com/dtolnay/async-trait ) from 0.1.56 to 0.1.57.
- [Release notes](https://github.com/dtolnay/async-trait/releases )
- [Commits](https://github.com/dtolnay/async-trait/compare/0.1.56...0.1.57 )
---
updated-dependencies:
- dependency-name: async-trait
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-08-24 21:13:45 +00:00
1f1d979dcc
Bump indexmap from 1.9.0 to 1.9.1 ( #5918 )
...
Bumps [indexmap](https://github.com/bluss/indexmap ) from 1.9.0 to 1.9.1.
- [Release notes](https://github.com/bluss/indexmap/releases )
- [Changelog](https://github.com/bluss/indexmap/blob/master/RELEASES.md )
- [Commits](https://github.com/bluss/indexmap/compare/1.9.0...1.9.1 )
---
updated-dependencies:
- dependency-name: indexmap
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-08-23 14:03:11 +02:00
872c87e8e6
Companion to Substrate PR 12006 ( #5913 )
...
* Fix import to make it compatible with https://github.com/paritytech/substrate/pull/12006
* update lockfile for {"substrate"}
Co-authored-by: parity-processbot <>
2022-08-22 16:45:54 +00:00
ca6297c853
Reduce dispute coordinator load ( #5785 )
...
* Don't import backing statements directly
into the dispute coordinator. This also gets rid of a redundant
signature check. Both should have some impact on backing performance.
In general this PR should make us scale better in the number of parachains.
Reasoning (aka why this is fine):
For the signature check: As mentioned, it is a redundant check. The
signature has already been checked at this point. This is even made
obvious by the used types. The smart constructor is not perfect as
discussed [here](https://github.com/paritytech/polkadot/issues/3455 ),
but is still a reasonable security.
For not importing to the dispute-coordinator: This should be good as the
dispute coordinator does scrape backing votes from chain. This suffices
in practice as a super majority of validators must have seen a backing
fork in order for a candidate to get included and only included
candidates pose a threat to our system. The import from chain is
preferable over direct import of backing votes for two reasons:
1. The import is batched, greatly improving import performance. All
backing votes for a candidate are imported with a single import.
And indeed we were able to see in metrics that importing votes
from chain is fast.
2. We do less work in general as not every candidate for which
statements are gossiped might actually make it on a chain. The
dispute coordinator as with the current implementation would still
import and keep those votes around for six sessions.
While redundancy is good for reliability in the event of bugs, this also
comes at a non negligible cost. The dispute-coordinator right now is the
subsystem with the highest load, despite the fact that it should not be
doing much during mormal operation and it is only getting worse
with more parachains as the load is a direct function of the number of statements.
We'll see on Versi how much of a performance improvement this PR
* Get rid of dead code.
* Dont send approval vote
* Make it pass CI
* Bring back tests for fixing them later.
* Explicit signature check.
* Resurrect approval-voting tests (not fixed yet)
* Send out approval votes in dispute-distribution.
Use BTreeMap for ordered dispute votes.
* Bring back an important warning.
* Fix approval voting tests.
* Don't send out dispute message on import + test
+ Some cleanup.
* Guide changes.
Note that the introduced complexity is actually redundant.
* WIP: guide changes.
* Finish guide changes about dispute-coordinator
conceputally. Requires more proof read still.
Also removed obsolete implementation details, where the code is better
suited as the source of truth.
* Finish guide changes for now.
* Remove own approval vote import logic.
* Implement logic for retrieving approval-votes
into approval-voting and approval-distribution subsystems.
* Update roadmap/implementers-guide/src/node/disputes/dispute-coordinator.md
Co-authored-by: asynchronous rob <rphmeier@gmail.com >
* Review feedback.
In particular: Add note about disputes of non included candidates.
* Incorporate Review Remarks
* Get rid of superfluous space.
* Tidy up import logic a bit.
Logical vote import is now separated, making the code more readable and
maintainable.
Also: Accept import if there is at least one invalid signer that has not
exceeded its spam slots, instead of requiring all of them to not exceed
their limits. This is more correct and a preparation for vote batching.
* We don't need/have empty imports.
* Fix tests and bugs.
* Remove error prone redundancy.
* Import approval votes on dispute initiated/concluded.
* Add test for approval vote import.
* Make guide checker happy (hopefully)
* Another sanity check + better logs.
* Reasoning about boundedness.
* Use `CandidateIndex` as opposed to `CoreIndex`.
* Remove redundant import.
* Review remarks.
* Add metric for calls to request signatures
* More review remarks.
* Add metric on imported approval votes.
* Include candidate hash in logs.
* More trace log
* Break cycle.
* Add some tracing.
* Cleanup allowed messages.
* fmt
* Tracing + timeout for get inherent data.
* Better error.
* Break cycle in all places.
* Clarified comment some more.
* Typo.
* Break cycle approval-distribution - approval-voting.
Co-authored-by: asynchronous rob <rphmeier@gmail.com >
2022-08-16 08:16:30 +02:00
4def0da0dc
Change request-response protocol names to include genesis hash & fork id ( #5870 )
2022-08-12 15:07:13 +03:00
f1dce2f548
Trivial networking changes for Substrate PR #11940 ( #5841 )
...
* Trivial networking changes for Substrate PR https://github.com/paritytech/substrate/pull/11940
* update lockfile for {"substrate"}
Co-authored-by: parity-processbot <>
2022-08-09 19:37:31 +00:00
43107b5391
Update RequestResponseConfig interface to match substrate ( #5849 )
...
* Update RequestResponseConfig interface
* minor: Bump CI
* update lockfile for {"substrate"}
* update lockfile for {"substrate"}
Co-authored-by: parity-processbot <>
2022-08-05 10:37:19 +00:00
85dabbd850
Backport crate version bumps to 0.9.27 ( #5826 )
...
* Bump crate versions
* Update cargo.lock
2022-07-28 10:03:27 +00:00
Keith Yeung