Commit Graph

50 Commits

Author SHA1 Message Date
Oliver Tale-Yazdi 342d720573 Use same fmt and clippy configs as in Substrate (#7611)
* Use same rustfmt.toml as Substrate

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* format format file

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Format with new config

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Add Substrate Clippy config

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Print Clippy version in CI

Otherwise its difficult to reproduce locally.

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Make fmt happy

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Update node/core/pvf/src/error.rs

Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io>

* Update node/core/pvf/src/error.rs

Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io>

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io>
2023-08-14 14:29:29 +00:00
Chevdor 693a29da1a Publish RC container images (#7556)
* WIP

* Add missing checkout

* Add debuggin

* Fix VAR name

* Bug fix

* Rework jobs

* Revert "Rework jobs"

This reverts commit 2bfa79fd3ae633c17403b838f9a5025f0f7fc3f3.

* Add cache

* Add temp default for testing

* Add missing checkout

* Fix patch

* Comment out the GPG check for now

* Rename polkadot_injected_release into a more appropriate polkadot_injected_debian

* Refactoring / renaming

* Introduce a generic image for binary injection

* Flag files to be deleted and changes to be done

* WIP

* Fix multi binaries images

* Add test build scripts

* Remove old file, add polkadot build-injected script

* Fix doc

* Fix tagging

* Add build of the injected container

* Fix for docker

* Remove the need for TTY

* Handling container publishing

* Fix owner and registry

* Fix vars

* Fix repo

* Fix var naming

* Fix case when there is no tag

* Fix case with no tag

* Handle error

* Fix spacings

* Fix tags

* Remove unnecessary grep that may fail

* Add final check

* Clean up and introduce GPG check

* Add doc

* Add doc

* Update doc/docker.md

Co-authored-by: Mira Ressel <mira@parity.io>

* type

Co-authored-by: Mira Ressel <mira@parity.io>

* Fix used VAR

* Improve doc

* ci: Update .build-push-image jobs to use the new build-injected.sh

* ci: fix path to build-injected.sh script

* Rename the release artifacts folder to prevent confusion due to a similar folder in the gitlab CI

* ci: check out polkadot repo in .build-push-image

This seems far cleaner than copying the entire scripts/ folder into our
job artifacts.

* feat(build-injected.sh): make PROJECT_ROOT configurable

This lets us avoid a dependency on git in our CI image.

* ci: build injected images with buildah

* ci: pass full image names to zombienet

* Add missing ignore

---------

Co-authored-by: Mira Ressel <mira@parity.io>
2023-08-11 15:28:39 +02:00
Marcin S 85b06f18b9 98.6% OF DEVELOPERS CANNOT REVIEW THIS PR! [read more...] (#7337)
* [WIP] PVF: Split out worker binaries

* Address compilation problems and re-design a bit

* Reorganize once more, fix tests

* Reformat with new nightly to make `cargo fmt` test happy

* Address `clippy` warnings

* Add temporary trace to debug zombienet tests

* Fix zombienet node upgrade test

* Fix malus and its CI

* Fix building worker binaries with malus

* More fixes for malus

* Remove unneeded cli subcommands

* Support placing auxiliary binaries to `/usr/libexec`

* Fix spelling

* Spelling

Co-authored-by: Marcin S. <marcin@realemail.net>

* Implement review comments (mostly nits)

* Fix worker node version flag

* Rework getting the worker paths

* Address a couple of review comments

* Minor restructuring

* Fix CI error

* Add tests for worker binaries detection

* Improve tests; try to fix CI

* Move workers module into separate file

* Try to fix failing test and workers not printing latest version

- Tests were not finding the worker binaries
- Workers were not being rebuilt when the version changed
- Made some errors easier to read

* Make a bunch of fixes

* Rebuild nodes on version change

* Fix more issues

* Fix tests

* Pass node version from node into dependencies to avoid recompiles

- [X] get version in CLI
- [X] pass it in to service
- [X] pass version along to PVF
- [X] remove rerun from service
- [X] add rerun to CLI

- [X] don’t rerun pvf/worker’s (these should be built by nodes which have rerun enabled)

* Some more improvements for smoother tests

- [X] Fix tests
- [X] Make puppet workers pass None for version and remove rerun
- [X] Make test collators self-contained

* Add back rerun to PVF workers

* Move worker binaries into files in cli crate

As a final optimization I've separated out each worker binary from its own crate
into the CLI crate. Before, the worker bin shared a crate with the worker lib,
so when the binaries got recompiled so did the libs and everything transitively
depending on the libs. This commit fixes this regression that was causing
recompiles after every commit.

* Fix bug (was passing worker version for node version)

* Move workers out of cli into root src/bin/ dir

- [X] Pass in node version from top-level (polkadot)
- [X] Add build.rs with rerun-git-head to root dir

* Add some sanity checks for workers to dockerfiles

* Update malus

  + [X] Make it self-contained
  + [X] Undo multiple binary changes

* Try to fix clippy errors

* Address `cargo run` issue

- [X] Add default-run for polkadot
- [X] Add note about installation to error

* Update readme (installation instructions)

* Allow disabling external workers for local/testing setups

  + [X] cli flag to enable single-binary mode
  + [X] Add message to error

* Revert unnecessary Cargo.lock changes

* Remove unnecessary build scripts from collators

* Add back missing malus commands (should fix failing ZN job)

* Some minor fixes

* Update Cargo.lock

* Fix some build errors

* Undo self-contained binaries; cli flag to disable version check

  + [X] Remove --dont-run-external-workers
  + [X] Add --disable-worker-version-check
  + [X] Remove PVF subcommands
  + [X] Redo malus changes

* Try to fix failing job and add some docs for local tests

---------

Co-authored-by: Dmitry Sinyavin <dmitry.sinyavin@parity.io>
Co-authored-by: s0me0ne-unkn0wn <48632512+s0me0ne-unkn0wn@users.noreply.github.com>
Co-authored-by: parity-processbot <>
2023-07-31 13:35:42 +00:00
Sergejs Kostjucenko 9354598e4a Fix publish dockerhub description ci jobs (#7558)
* fix var names in ci

* fix formatting
2023-07-28 14:50:46 +01:00
Sergejs Kostjucenko 11af1cea68 Fix ci syntax (#7553)
* fix ci syntax

* change to trigger ci
2023-07-28 11:24:42 +03:00
Sergejs Kostjucenko 05eed8a7d4 fix description filename (#7552) 2023-07-27 22:04:17 +03:00
Sergejs Kostjucenko ed0bedc6cf Publish docker image description (#7551)
* Add CI job to publish Docker images description to dockerhub

* add destination dockerhub repo
2023-07-27 17:49:33 +03:00
Andrei Sandu 57169b22b9 ParachainsInherent: apply weight limit only in ProvideInherent (#7530)
* move filtering and panic in enter

Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>

* typo

Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>

* more typo

Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>

* review feedback

Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>

* 🤦🤦🤦 Test only `polkadot-runtime-parachains`

Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>

---------

Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
2023-07-25 09:00:44 +00:00
Liam Aharon f79b75c6c2 ci: always run runtime migration checks (#7422)
* add rococo test and run ci every pr

* remove debug logging from ci output

* fix run command

* Update scripts/ci/gitlab/pipeline/check.yml

Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>

* make --checks explicit

* fix checks

* kick ci

* kick ci

* kick ci

* kick ci

---------

Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>
2023-07-24 15:10:55 +00:00
Vladimir Istyufeev ad58e59a5e Disable spellcheck CI job (#7512)
* Disable `spellcheck` CI job

* Mention explicitly when the job was disabled
2023-07-18 19:56:39 +00:00
Bastian Köcher 0ff60f7da1 Companion for removal of execution strategies (#7443)
* Companion for removal of execution strategies

https://github.com/paritytech/substrate/pull/14387

* Fix some tests

* 🤦

* Adapt to latest changes

* Start supporting the offchain transaction pool

* Fix tests

* FMT

* Remove patches

* Update Substrate

* update lockfile for {"substrate"}

* Fix parachain upgrade smoke test

* Fix test

* Rewrite all tests to use `MockSubstemClient`

---------

Co-authored-by: parity-processbot <>
2023-07-11 21:55:43 +00:00
s0me0ne-unkn0wn c1f865813b Run timeout-based tests only in CI (#7390)
* Introduce `ci-only-tests` feature

* Add comment
2023-07-06 08:39:10 +00:00
Mira Ressel ed227b9bbe ci: add new test-linux-oldkernel-stable job (#7371)
closes paritytech/ci_cd#811
2023-06-15 10:30:37 +02:00
s0me0ne-unkn0wn 21897336d7 Hotfix for #7360 (#7365)
* CI job hotfix
* Instruct `cargo` to build all the binaries
2023-06-14 14:43:32 +02:00
s0me0ne-unkn0wn ce76f6d373 Patch CI for split out worker binaries (#7360) 2023-06-14 09:55:41 +00:00
ordian 01a19b45e3 dispute-coordinator: past session dispute slashing (#6811)
* runtime/vstaging: unapplied_slashes runtime API

* runtime/vstaging: key_ownership_proof runtime API

* runtime/ParachainHost: submit_report_dispute_lost

* fix key_ownership_proof API

* runtime: submit_report_dispute_lost runtime API

* nits

* Update node/subsystem-types/src/messages.rs

Co-authored-by: Marcin S. <marcin@bytedude.com>

* revert unrelated fmt changes

* dispute-coordinator: past session dispute slashing

* encapsule runtime api call for submitting report

* prettify: extract into a function

* do not exit on runtime api error

* fix tests

* try initial zombienet test

* try something

* fix a typo

* try cumulus-based collator

* fix clippy

* build polkadot-debug images with fast-runtime enabled

* wip

* runtime/inclusion: fix availability_threshold

* fix wip

* fix wip II

* revert native provider

* propagate tx submission error

* DEBUG: sync=trace

* print key ownership proof len

* panic repro

* log validator index in panic message

* post merge fixes

* replace debug assertion with a log

* fix compilation

* Let's log the dispatch info in validate block.

* fix double encoding

* Revert "Let's log the dispatch info in validate block."

This reverts commit a70fbc51b464d7f4355dbada5e16cd83cf71eab4.

* Revert "Let's log the dispatch info in validate block."

This reverts commit a70fbc51b464d7f4355dbada5e16cd83cf71eab4.

* fix compilation

* update to latest zombienet and fix test

* lower finality lag to 11

* bump zombienet again

* add a workaround, but still does not work

* Update .gitlab-ci.yml

bump zombienet.

* add a comment and search logs on all nodes

---------

Co-authored-by: Marcin S. <marcin@bytedude.com>
Co-authored-by: Bastian Köcher <info@kchr.de>
Co-authored-by: Javier Viola <javier@parity.io>
2023-06-05 18:21:42 +02:00
Javier Viola 0e5974f55b bump zombienet version. (#7180)
* bump zombienet version

* enable upgrade node test

* changes to fix test

* typo in pipeline
2023-05-07 21:23:36 +02:00
Niklas Adolfsson dcbf8b70f7 companion for #13384 (#6987)
* companion for #13384

* adjust parsing RPC address from process output

* update rpc cli

* update lockfile for {"substrate"}

* bump zombienet v1.3.48

* bump zombienet version

* allow zombienet-tests-misc-upgrade-node to fail

* add comment and issue link to allowed_failure

* grumbles: disable failed job

* disabled the correct test

---------

Co-authored-by: parity-processbot <>
Co-authored-by: Javier Viola <javier@parity.io>
2023-05-04 11:48:08 +02:00
Liam Aharon 1fbf37f991 ci: update check-runtime-migration fixme issues (#7141)
* update configs for check-runtime-migration tasks

* update fixme issues

* fix indentation
2023-04-28 00:59:04 +10:00
gupnik d8723a080c Offences Migration v1: Removes ReportsByKindIndex (#7114)
* Companion for substrate

* Adds kusama migration

* update lockfile for {"substrate"}

* Temp allow try-runtime to fail

... until https://github.com/paritytech/substrate/issues/14006 is done.

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: parity-processbot <>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
2023-04-26 04:08:08 +00:00
Oliver Tale-Yazdi f0c507362d Fix try-runtime CI (#7078)
* Fix try-runtime CI

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Actually fix it

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
2023-04-14 10:36:34 +00:00
Mira Ressel d3f81f12b0 Invoke cargo build commands with --locked (#7057) 2023-04-12 12:05:40 +02:00
Mira Ressel 32c9e99919 use stable rust toolchain in ci
cargo-fmt stays on the nightly pipeline; our fmt config uses a heap of
unstable features.
2023-04-11 17:02:52 +02:00
Mira Ressel 2c9242fb81 timestamp ci job logs (#6890) 2023-03-15 18:19:12 +00:00
Mira Ressel f019376cb1 Automatically format ci pipeline specs with prettier (#6783) 2023-02-27 15:34:54 +04:00
Oleg Plakida 5e7ade9037 Revert back to bare metal runners for weights generation (#6762)
* Revert back to bare metal runners for weights generation

* new old weights

---------

Co-authored-by: alvicsam <alvicsam@gmail.com>
2023-02-23 11:50:43 +01:00
JP de952045d5 Fix update-node-template script (#6679)
* fix the branch name

* fix usage of $TEMPLATE_SOURCE
2023-02-08 12:51:04 +00:00
Oliver Tale-Yazdi ac67b0aa67 Enable try-runtime flag in CI (#6587)
* Env gate tests

The CI should check that it compiles, but not run it.

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Enable try-runtime feature in CI

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Fix test

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
2023-01-26 16:36:40 +00:00
Alexander Samusev 0119a6dae1 New runners for weights and new weights (#6508)
* [DO NOT MERGE] test new vm runner for weights 2

* add image

* fix merge conflict

* apply weights

* new weights

Co-authored-by: parity-processbot <>
2023-01-24 16:35:26 +01:00
Vladimir Istyufeev 2952ad6f44 CI: Code mark to request a pipeline failure (#6562) 2023-01-16 22:56:18 +04:00
JP 5171883ecf handle substrate-node-template and substrate-parachain-template (#6541) 2023-01-11 12:34:04 +00:00
Mara Robin B 22f2b2bdba ci: mark update-weights non-interruptible (#6539) 2023-01-11 10:08:55 +00:00
JP 81d4e5c85d Trigger update-node-template when a final release tag is created (#6522)
* trigger update-node-template when final release tag is created

ref https://github.com/paritytech/release-engineering/issues/142

* fix comment

* Update scripts/ci/gitlab/pipeline/publish.yml

Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>

* fix regular expression

Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>
2023-01-11 09:03:07 +00:00
Alexander Samusev 046362bb00 [ci] Remove check-transaction-versions job (#6509)
Co-authored-by: parity-processbot <>
2023-01-06 10:59:45 +01:00
Oliver Tale-Yazdi b6420cf6ec Fix runtime-migration label detection (#6469)
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
2022-12-22 14:21:16 +01:00
Alexander Samusev 87f9e4e140 [ci] New try-runtime command (#6445)
* [ci] New try-runtime command

* restart pipeline

* build features

* fix --features flag

* rm --execution flag

* remove --no-spec-check-panic flag

* change target dir

* debug ccargo target dir

* return target

* try different location for runtime wasm

* build only the runtime crate

* check all generated .wasm files

* adjust paths again

* remove debug command

Co-authored-by: joao-paulo-parity <joao-paulo@parity.io>
2022-12-20 17:08:19 +01:00
Alexander Samusev 193c8de9db [ci] add job switcher (#6433)
* [ci] add job switcher

* add before_script to docker and k8s runners

* upd runners

* sccache :(
2022-12-14 13:49:56 +01:00
Alexander Samusev da0b0224c5 [ci] fix check-transaction-versions (#6425)
* [ci] fix check-transaction-versions

* allow fail the job
2022-12-13 11:22:32 +01:00
Alexander Samusev 896d1c2c3b [ci] Adjust check-runtime-migration job (#6107)
* [WIP][ci] Add node to check-runtime-migration job

* add image

* remove sscache from before_script

* add nodes

* restart pipeline

* restart pipeline2

* disable other jobs

* debug

* remove debug

* add ports

* restart pipeline

* restart pipeline

* restart pipeline

* try kusama first

* run polkadot 1st

* disable some jobs

* try command from command bot

* cargo run

* test passing variables

* run without condition

* adjust kusama and westend

* fix

* return jobs

* fix small nits

* split check-runtime-migration

Co-authored-by: parity-processbot <>
2022-12-08 13:26:18 +01:00
alexgparity 9ea14e66c8 Clippyfy (#6341)
* Add clippy config and remove .cargo from gitignore

* first fixes

* Clippyfied

* Add clippy CI job

* comment out rusty-cachier

* minor

* fix ci

* remove DAG from check-dependent-project

* add DAG to clippy

Co-authored-by: alvicsam <alvicsam@gmail.com>
2022-11-30 08:34:06 +00:00
Alexander Samusev b108fd854b [ci] fix implementer guide job (#6357)
* [DNM] debug implementer guide job

* remove git depth

* change git strategy

* add git depth

* try k8s runner

* fix k8s template

* test job

* fix test

* fix

* return pipeline back

* enable disabled deploy-parity-testnet
2022-11-28 16:31:49 +01:00
Alexander Samusev bc25c41aaf [ci] fix build-implementers-guide (#6335)
* [ci] fix build-implementers-guide

* fix user
2022-11-24 10:06:07 +01:00
Alexander Samusev d19484e972 [ci] fix build implementers guide (#6306)
* [ci] fix build implementers guide

* add comment

* rm git fetch from publish-docs
2022-11-17 16:42:46 +01:00
Marcin S 6cc91f9187 Add a last change footer to the implementers guide (#6216)
* Add a `last change` footer to the implementers guide

Some of the newcomers were noticing outdated pages in the implementer's guide.
This idea came up as a heuristic for how up-to-date an individual page is.

* Update `build-implementers-guide` CI job
2022-11-08 13:06:02 +00:00
Javier Viola d02d58de40 fix upgrade node test, use latest as base image (#6215) 2022-10-31 16:17:06 +00:00
Javier Viola 0373ad0a34 bump zombienet version (#6142)
* bump version

* make test required

* change zombienet version

* change zombienet version

* bump version and typo

* typo and add within
2022-10-13 15:17:50 +00:00
Andronik a4e33b13ac ci/guide: install mdbook-graphviz (#6119)
* ci/guide: install mdbook-graphviz

* install graphviz in build-implementers-guide

* Update scripts/ci/gitlab/pipeline/build.yml

Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>
2022-10-10 09:41:04 +00:00
Serban Iorga 5458406927 Companion for pallet-mmr: generate historical proofs (#6061)
* BEEFY: generate historical proofs

Signed-off-by: Serban Iorga <serban@parity.io>

* cargo update -p sp-io

* Properly set max proof size for runtimes

* Properly set max proof size for mocks

* cargo fmt

* Set appropriate UMP service total proof size weight

* Disable zombienet-tests-parachains-disputes CI

* Add comment explaining weight math

* Use MAX_POV_SIZE for max proof size

* Cast to u64

* Remove comment

Signed-off-by: Serban Iorga <serban@parity.io>
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
2022-10-02 10:42:24 +01:00
Nikos Kontakis 39e55ffd0a Rename zombienet extension (#6073)
* Rename extension files and respective entries from '.feature' to '.zndsl'

* Rename zombienet extension for 0001-dispute-valid-block test
2022-09-29 07:22:15 +00:00
Alexander Samusev fc8d1765ef [ci] Split gitlab-ci config to separate files (#6031)
* [WIP][ci] Split gitlab-ci config to separate files

* add stage

* move short benches

* rename stage short_benchmark

* include short-benchmarks

* add check

* add test stage

* quickfix check-no-default-features

* add build stage

* add weights and publish

* rename stage

* rename stage

* fix publish miner image

* fix publish miner image

* add dag

* fix image

* start build-short-benchmark with the pipeline

* some more DAGs

* empty line to short-benchmarks

* add change from master

Co-authored-by: parity-processbot <>
2022-09-26 10:50:25 +02:00