* staking admin can set min commission
* ".git/.scripts/bench-bot.sh" pallet dev pallet_staking
* fmt
* fix for pr comments
Co-authored-by: command-bot <>
* bounding election provider with kian
* multi phase implement bounded election provider
* election provider blanket implementation
* staking compiles
* fix test for election provider support
* fmt
* fixing epmp tests, does not compile yet
* fix epmp tests
* fix staking tests
* fmt
* fix runtime tests
* fmt
* remove outdated wip tags
* add enum error
* sort and truncate supports
* comment
* error when unsupported number of election winners
* compiling wip after kian's suggestions
* fix TODOs
* remove,fix tags
* ensure validator count does not exceed maxwinners
* clean up
* some more clean up and todos
* handle too many winners
* rename parameter for mock
* todo
* add sort and truncate rule if there are too many winners
* fmt
* fail, not swallow emergency result bound not met
* remove too many winners resolution as it can be guaranteed to be bounded
* fix benchmark
* give MaxWinners more contextual name
* make ready solution generic over T
* kian feedback
* fix stuff
* Kian's way of solvign this
* comment fix
* fix compile
* remove use of BoundedExecution
* fmt
* comment out failing integrity test
* cap validator count increment to max winners
* dont panic
* add test for bad data provider
* Update frame/staking/src/pallet/impls.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
* fix namespace conflict and add test for onchain max winners less than desired targets
* defensive unwrap
* early convert to bounded vec
* fix syntax
* fmt
* fix doc
* fix rustdoc
* fmt
* fix maxwinner count for benchmarking
* add instant election for noelection
* fmt
* fix compile
* pr feedbacks
* always error at validator count exceeding max winners
* add useful error message
* pr comments
* import fix
* add checked_desired_targets
* fmt
* fmt
* fix rust doc
Co-authored-by: parity-processbot <>
Co-authored-by: kianenigma <kian@parity.io>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
* replace pallet level unboundedness to individual storage items
* bound structs
* bounding history depth
* defensive error
* use the era history depth from config
* clean up history depth from storage in v11
* keep the name HistoryDepth for the new configuration value
* use u32 for history depth in node runtime
* improve doc comments
* add HistoryDepth to mock runtimes with pallet-staking
* rustfmt
* refactor and doc improve
* apply re-benchmarked weight for staking
* pr feedback improvements
* test for claimed rewards following the expected bounds
* refactor test to calculate first and last reward era programmatically
* verify previous eras cannot be claimed
* add migration v12
* ".git/.scripts/bench-bot.sh" pallet dev pallet_staking
* fix compiler error
* corrupting history depth does not lead to catastrophic issue
* fix new line
* remove unused import
* fmt
* add test to document scenario where history depth is reduced without migration
* fmt
* Update frame/staking/src/lib.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
* Update frame/staking/src/migrations.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
* doc for all storage items bounded by HistoryDepth
* Update frame/staking/src/pallet/mod.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
* Update frame/staking/src/tests.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
* pr feedback fixes
* Update frame/staking/src/tests.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
* remove extra checks
* fix merge
* fmt
Co-authored-by: command-bot <>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Co-authored-by: kianenigma <kian@parity.io>
* BREAKING: Rename Origin
* more renaming
* a bit more renaming
* fix
* more fixing
* fix in frame_support
* even more fixes
* fix
* small fix
* ...
* update .stderr
* docs
* update docs
* update docs
* docs
* only check std
* add default-features=false
* Revert "add default-features=false"
This reverts commit bc9453757a1df670f418a2d57ee4ce203425ab1b.
* missing features only to non-optional
* staking: Proportional ledger slashing
* Some comment cleanup
* Update frame/staking/src/pallet/mod.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
* Fix benchmarks
* FMT
* Try fill in all staking configs
* round of feedback and imp from kian
* demonstrate per_thing usage
* Update some tests
* FMT
* Test that era offset works correctly
* Update mocks
* Remove unnescary docs
* Remove unlock_era
* Update frame/staking/src/lib.rs
* Adjust tests to account for only remove when < ED
* Remove stale TODOs
* Remove dupe test
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Co-authored-by: kianenigma <kian@parity.io>
* Allow `pallet-election-provider` to accept smaller
solutions, issue #9478
* Fixing a typo
* Adding some more tests
Removing a seemingly outdated comment
* making it a URL
* Updating test name as per suggestion
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
* Updating documentation to be more explicit
And to follow the general guidelines
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
* Fixing formatting
* `Fallback` now of type `InstantElectionProvider`
Some cleanups
* Allow `pallet-election-provider` to accept smaller
solutions, issue #9478
* Fixing a typo
* Adding some more tests
Removing a seemingly outdated comment
* making it a URL
* Updating test name as per suggestion
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
* Updating documentation to be more explicit
And to follow the general guidelines
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
* Fixing formatting
* `Fallback` now of type `InstantElectionProvider`
Some cleanups
* Merging types into one type with generics
* Removing `ConstUSize` and use `ConstU32`
* cleaning up the code
* deprecating `OnChainSequentialPhragmen`
Renaming it to `UnboundedSequentialPhragmen` which should only be used
at genesis and for testing.
Use preferrably `BoundedOnChainSequentialPhragmen`
* Amending docs
* Adding some explicit imports
* Implementing generic `BoundedOnchainExecution`
Removing the deprecated `OnChainSequentialPhragmen`
* Use the right Balancing strategy
* Refactoring `onchain::Config`
Creating `onchain::ExecutionConfig`
* Merge master
* fmt
* Name cleanups after review suggestions
* cosmetics
* renaming `instant_elect` to `elect_with_bounds`
Other corresponding changes as per @kianenigma feedback
* `BoundedOnchainExecution` -> `BoundedExecution`
And `UnboundedOnchainExecution` -> `UnboundedExecution`
* feedback from kian
* fmt + unneeded import
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Co-authored-by: kianenigma <kian@parity.io>
* Upgraded dependencies
* Adapting code to scale v3
* Empty commit to trigger CI
* Triggering CI
* Fixing UI test
* Remove superfluous dev-dep added by #9228
* Cryout for CI
* Use proper bounded vector type for nominations
* add docs and tweak chill_other for cleanup purposes
* Fix the build
* remove TODO
* add a bit more doc
* even more docs
gushc
* Update frame/staking/src/pallet/mod.rs
Co-authored-by: Zeke Mostov <z.mostov@gmail.com>
* Update frame/staking/src/pallet/mod.rs
Co-authored-by: Zeke Mostov <z.mostov@gmail.com>
* Fix the nasty bug
* also bound the Snapshot type
* fix doc test
* document bounded_vec
* self-review
* remove unused
* Fix build
* frame-support: repetition overload for bounded_vec
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* fix
* remove the need to allocate into unbounded voters etc etc
* Don't expect
* unbreal the build again
* handle macro a bit better
Co-authored-by: Zeke Mostov <z.mostov@gmail.com>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Introduce `SecretUri`
* `inspect-key`: Adds support for `expect-public`
`expect-public` can be used to check that a given secret uri corresponds to the given public key.
This is mainly useful when the secret uri is protected by a password and a new derived account
should be generated. With `--expect-public` the user can pass the public key/account-id of the
"base" secret uri aka the one without any derivation to ensure the correct password was inserted.
* Fixes
* 🤦
* Apply suggestions from code review
Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com>
* Review feedback
* FMT
* Bump the versions
Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com>
* Generate one #[test] fn per bench case.
* Update benchmark macro syntax in frame pallets.
* Explain new benchmark macro syntax in example pallet.
* support with and without a semicolon
* update pallets to use individual tests
* migrate staking too
* migrate more pallets
* fix up democracy and use individual tests
* Fix comment
* Put println message in panic
* Remove `another_set_dummy` from doc
`another_set_dummy` is not present in the benchmarking.rs (anymore).
* Update doc for benchmarks macro
* Update doc for impl_benchmark_test_suite macro
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
* remove extra whitespace
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
* only emit rebag event on success
* add doc explaining the term voter
* revamp/simplify rebag test
* ensure genesis accounts are placed into the correct nodes/bags
* bond_extra implicitly rebags
* types at top; doc public type
* start sketching out adjustable thresholds
* add integrity test for voter bag threshold requirements
* get rid of BagIdx
This reorganizes bag storage such that bags are always referred to
by their upper threshold. This in turn means that adding and removing
bags is cheaper; you only need to migrate certain voters, not all of them.
* implement migration logic for when the threshold list changes
* start sketching out threshold proc macros
* further refine macro signatures
* WIP: implement make_ratio macro
* start rethinking the process of producing threshold lists
The macro approach seems to be a non-starter; that only really works
if we're throwing around numeric literals everywhere, and that's just
not nice in this case.
Instead, let's write helper functions and make it really easy to
generate the tables in separate, permanent files, which humans
can then edit.
* write helper functions to emit voter bags module
* WIP: demo generating voter bags for a realistic runtime
This isn't yet done, becuase it seems to take a Very Long Time to run,
and it really shouldn't. Need to look into that.
Still, it's a lot closer than it was this morning.
* rm unnecessary arg_enum
* fix voter bags math
Turns out that when you're working in exponential space, you need
to divide, not subtract, in order to keep the math working properly.
Also neaten up the output a little bit to make it easier to read.
* add computed voter bags thresholds to node
* fixup some docs
* iter from large bags to small, fulfuilling the contract
* make tests compile
* add VoterBagThresholds to some configs
* ensure that iteration covers all voters even with implied final bag
* use sp_std::boxed::Box;
* fix unused import
* add some more voter bags tests
* file_header.txt
* integrity test to ensure min bag exceeds existential weight
* add more debug assertions about node list length
* rm unused imports
* Kian enters
* Update frame/election-provider-support/src/onchain.rs
Co-authored-by: Zeke Mostov <32168567+emostov@users.noreply.github.com>
* Suggestions for #9081 (Store voters in unsorted bags) (#9328)
* Add some debug asserts to node::get and remove_node
* Improve the debug asserts in remove_node
* improve debug asserts
* Space
* Remove bad assertions
* Tests: WIP take_works
* Take test
* Doc comment
* Apply suggestions from code review
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
* Test storage is cleaned up;
* formatting
* Switch to simpler thresholds
* Update the storage cleanup test
* Remove hardcoded values from benchmark to make it more robust
* Fix tests to acces bags properly
* Sanity check WIP; tests failing
* Update sanity checks to be more correct
* Improve storage cleanup tests
* WIP remote_ext_tests
* Some notes on next steps
* Remove some stuff that was for remote-ext tests
* Some more cleanup to reduce diff
* More :clean:
* Mo cleanin
* small fix
* A lot of changes from kian
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Co-authored-by: kianenigma <kian@parity.io>
* merge fallout
* Run cargo +nightly fmt
* Fix a bunch of stuff, remove not needed runtime arg of make-bags
* add logs
* Glue the new staking bags to the election snapshot (#9415)
* Glue the new staking bags to the election snapshot
* add CheckedRem (#9412)
* add CheckedRem
* fix
* Run fmt
* Test comment
Co-authored-by: Xiliang Chen <xlchen1291@gmail.com>
Co-authored-by: emostov <32168567+emostov@users.noreply.github.com>
* Update node runtime with VoterSnapshotPerBlock
* Unit test for pallet-staking unsorted bags feature (targets #9081) (#9422)
* impl notional_bag_for_works
* Add tests: insert_as_works & insert_works
* Impl test: remove_works
* Trivial cleaning
* Add test: update_position_for_works
* Write out edge case; probably can delete later
* Add test: bags::get_works
* Add test: remove_node_happy_path_works
* Add test: remove_node_bad_paths_documented
* WIP: voting_data_works
* done
* Improve test voting_data_works
* Add comment
* Fill out test basic_setup_works
* Update: iteration_is_semi_sorted
* Improve remove_works
* Update update_position_for_works; create set_ledger_and_free_balance
* Improve get_works
* Improve storage clean up checks in remove test
* Test: impl rebag_works + insert_and_remove_works
* forgot file - Test: impl rebag_works + insert_and_remove_works
* Small tweak
* Update voter_bags test to reflect unused bags are removed
* Unbond & Rebond: do_rebag
* Prevent infinite loops with duplicate tail insert
* Check iter.count on voter list in pre-migrate
* undo strang fmt comment stuff
* Add in todo
Co-authored-by: kianenigma <kian@parity.io>
* Try prepare for master merge
* Reduce diff
* Add comment for test to add
* Add in code TODO for update_position efficiency updates
* Initial impl compiles
* impl StakingVoterListStub
* Sample impl<T: Config> VoterListProvider<T> for VoterList<T>
* impl VoterListProvider for voter-bags
* WIP integrate pallet-voter-bags to staking mock
* the trait `pallet_staking::pallet::pallet::Config` is not implemented for `mock::Test`
* random
* pushing my stuff
* Mock working
* WIP voter list tests
* Add bag insert, remove tests
* Add test for bag insert and remove
* Add remaining tests for VoterList
* Add tests for node
* Add rebag works
* Add rebag extrinsic tests
* Rename to bags-list and name the list .. list!
* Rename VoterBagThresholds => BagThresholds
* Add test count_works
* Test on_update_works
* test sanity check
* a round of test fixes
* push a lot of changes
* my last changes
* all bags-list test work; fmt
* Beautify some tests
* Doc comment for bags-list
* Add insert warnings
* Setup initial benchmark
* Wire up WeightInfo
* is_terminal wip; everything broken!
* Is terminal working
* add TODOs for remove_node
* clean up remoe_node
* Fix all staking tests
* retire VoterBagFor
* commit
* bring in stashed changes
* save
* bench pipeline works now, but I can't run stuff
* sabe
* benchmarks now run, but we have a failure
* WIP: Wire up make_bags
* bags-thresholds compiles
* Fix most build issues
* This will fix all the tests
* move bag thresholds to bags-list
* Move bag-thresholds bin to within pallet-bags
* Remove some unnescary TODOs
* Impl tets wrong_rebag_is_noop
* assert remove is a noop with bad data
* Assert integrity test panics
* Return an error when inserting duplicates
* Update to handle error in staking pallet when inserting to list
* Test contains and on_insert error
* Test re-nominate does not mess up list or count
* Everything builds and works, only the benchmark...
* fuck yeah benchmarks
* more cleanup, more hardening.
* use the bags list again
* fix benhc
* Some questions and changs for List::migration
* Fix migration removed_bags and new_bags usage
* Some trivial aesthetic changes
* Some more trivial changes
* tiny changes/
* mega rename
* fix all tests and ci build
* nit
* Test and fix migration
* nit
* fmt
* cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/staking/src/weights.rs --template=./.maintain/frame-weight-template.hbs
* fmt
* remove unused
* make a few things pub
* make node also pub.. for remote-ext test
* Fix all tests again
* Force bag changes in relevant benchmarks (targets #9507) (#9529)
* force rebag for unbond, rebond, and bond_extra
* nit
* Improve utils
* fmt
* nits
* Move generate_bags to its own pallet
* Get runtime-benchmarks feature setup with prepare_on_update_benchmark
* Withdraw unbonded kill working
* Nominate bench working
* some cleanup
* WIP
* update to check head pre & post conditions
* Add some post condition verification stuff for on_remove
* Update nominate
* fmt
* Improvements
* Fix build
* fix build with polkadot companion
* Update frame/bags-list/src/list/tests.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
* move generate-bag from frame to utils
* wip
* refactor WIP
* WIP save
* Refactor working
* some variable renaming
* WIP: prepare to remove head checks
* Finish MvP refactor
* Some cleanup
* Soem more cleanup
* save
* fix a lot of stuff
* Update client/db/src/bench.rs
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
* Apply suggestions from code review
* Apply suggestions from code review
* Fix some issues that came from trying to merge comments on github
* some small changes
* simplify it
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Co-authored-by: kianenigma <kian@parity.io>
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
* Build works
* Apply suggestions from code review
Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
* Apply suggestions from code review
Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
* Remove commented out debug assert
* Remove some unused deps and some unused benchmarking stuff
* Fix stakings ElectionDataProvider clear
* cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_bags_list --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/bags-list/src/weights.rs --template=./.maintain/frame-weight-template.hbs
* cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_bags_list --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/bags-list/src/weights.rs --template=./.maintain/frame-weight-template.hbs
* cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_bags_list --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/bags-list/src/weights.rs --template=./.maintain/frame-weight-template.hbs
* cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_bags_list --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/bags-list/src/weights.rs --template=./.maintain/frame-weight-template.hbs
* Improving staking pallet-bags-list migration
* fix build and some comments;
* comment
* Reduce visibility in bags list components
* make node.bag_upper only accesible to benchmarks
* Address some feedback; comments updates
* use nominator map comment
* fix vec capacity debug assert
* Apply suggestions from code review
Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
* clarify VoterSnapshotPerBlock
* Reduce diff on create_validators by wrapping with_seed
* Some small improvements to staking benches
* Soem comment updates
* fix vec capacity debug assert ... for real this time
* Reduce ListBags viz
* cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/staking/src/weights.rs --template=./.maintain/frame-weight-template.hbs
* cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/staking/src/weights.rs --template=./.maintain/frame-weight-template.hbs
* Remove supports_eq_unordered & Support eq_unordered
* Update utils/frame/generate-bags/src/lib.rs
Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
* Make total-issuance & minimium-balance CLI args; Dont use emptry ext
* Improve docs for generate bags CLI args
* Apply suggestions from code review
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
* Apply suggestions from code review
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
* Don't use default bags weight in node runtime
* Feature gating sanity_check not working
* Feature gate sanity check by creating duplicate fns
* Fix line wrapping
* Document VoteWeightProvider
* Make bags ext-builder not a module
* Apply suggestions from code review
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
* use pallet_bags_list instead of crate in mock
* Make get_bags test helper fn live in List
* use remove_from_storage_unchecked for node removal
* Remove count of ids removed in remove_many
* Add node sanity check, improve list sanity check
* Do a list sanity check after on_update
* List::migrate: clean up debug assert, exit early when no change in thresholds
* Improve public doc comments for pallet_bags_list::list::List
* Improve public doc comments for pallet_bags_list::list::List
* Update generate bags docs
* Fix grammar in bags-list benchmark
* Add benchmark case for `rebag` extrinsic
* Add count parameter to List::clear; WIP adding MaxEncodedLen to list'
* MaxEncodeLen + generate_storage_info not working for Bag or Node
* Get MaxEncodeLen derive to work
* Try to correctly feature gate SortedListProvider::clear
* Use u32::MAX, not u32::max_value
* Get up to nominators_quota noms
* SortedListProvider::clear takes an Option
* Eplicitly ignore SortedListProvider return value
* Fix doc comment
* Update node-runtime voter snapshot per block
* Add test get_max_len_voters_even_if_some_nominators_are_slashed
* Add test only_iterates_max_2_times_nominators_quota
* Fix generate bags cargo.toml
* use sp_std vec
* Remove v8 migration hooks from pallet-staking
* Update npos trait
* Try respect line width
* cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_bags_list --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/bags-list/src/weights.rs --template=./.maintain/frame-weight-template.hbs
* Update frame/bags-list/src/benchmarks.rs
* Unwrap try-runtime error; remove sortedlistprovider pre upgrade len check
* trigger ci
* restore
* trigger ci
* restore
* trigger ci
* revert
* trigger ci
* revert
Co-authored-by: Peter Goodspeed-Niklaus <coriolinus@users.noreply.github.com>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Co-authored-by: Peter Goodspeed-Niklaus <peter.r.goodspeedniklaus@gmail.com>
Co-authored-by: kianenigma <kian@parity.io>
Co-authored-by: Xiliang Chen <xlchen1291@gmail.com>
Co-authored-by: Parity Benchmarking Bot <admin@parity.io>
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
Remove unneeded dependencies and dev-dependencies.
Made self_destruct test not dependent on wasm bin size.
Updated code related to deprecated warning on tracing-subscriber `scope()`
( See https://github.com/tokio-rs/tracing/issues/1429 )
* Run cargo fmt on the whole code base
* Second run
* Add CI check
* Fix compilation
* More unnecessary braces
* Handle weights
* Use --all
* Use correct attributes...
* Fix UI tests
* AHHHHHHHHH
* 🤦
* Docs
* Fix compilation
* 🤷
* Please stop
* 🤦 x 2
* More
* make rustfmt.toml consistent with polkadot
Co-authored-by: André Silva <andrerfosilva@gmail.com>
* mark template and utils as non-publish
* switch to development version for testing
* activate unleash check
* maybe if I disable all rules...
* Fix isolated compilation of `max-encoded-len-derive` with `syn`
error[E0369]: binary operation `==` cannot be applied to type `syn::Path`
--> src/lib.rs:88:29
|
88 | .filter(|attr| attr.path == parse_quote!(max_encoded_len_crate))
| --------- ^^ ----------------------------------- _
| |
| syn::Path
error: aborting due to previous error
For more information about this error, try `rustc --explain E0369`.
Error: could not compile `max-encoded-len-derive`
* WIP: bump changes crates since v3 tag to next breaking
cargo unleash version bump-breaking --changed-since v3.0.0
cargo unleash version set-pre dev --changed-since v3.0.0
FIXME: Don't modify crates that are not yet released, e.g.
`max-encoded-len-derive`
* Update lockfile
* WIP: Bump sp-transaction-pool as well
* WIP: Bump sp-offchain as well
* WIP: Bump frame-system-rpc-runtime-api as well
* WIP: Bump sp-authority-discovery as well
* Manually deactivate dev-deps before `cargo unleash check`
Otherwise we run into `Cycle detected` error.
* Bump sp-consensus-slots
* Add missing Cargo.lock change
* Bump sp-consensus-vrf as well
* Bump sp-keyring as well
* Bump sp-consensus-pow as well
* Try to speed up the `unleash-check` job
Previously, the job took 106 minutes - let's see if explicitly
specifying a `CARGO_TARGET_DIR` will help
* fixup: Ensure the temp target dir exists for unleash check
* Bump pallet-transaction-payment-rpc-runtime-api as well
Needed for Polkadot
* Bump pallet-transaction-payment-rpc as well
Needed for Polkadot
* Try updating crates after patching in the Polkadot CI job
* Use another approach to update patched Substrate crates
* Try to update all sp-core versions in Polkadot CI job
* Simplify sp-core version checking
* Apply another shellcheck lint
* Just do the simplest thing I guess
* Welp don't do --offline then
* Clean up `unleash-check` job triggers
Co-authored-by: Denis Pisarev <denis.pisarev@parity.io>
* Fix a note in unleash-check cache step
* Add a note about temporary optimization in cargo-unleash
* Pin a newer version of cargo-unleash
Co-authored-by: Igor Matuszewski <xanewok@gmail.com>
Co-authored-by: Denis Pisarev <denis.pisarev@parity.io>
Ankan