be8e626806
Set clippy lints in workspace (requires rust 1.74) ( #2390 )
...
We currently use a bit of a hack in `.cargo/config` to make sure that
clippy isn't too annoying by specifying the list of lints.
There is now a stable way to define lints for a workspace. The only down
side is that every crate seems to have to opt into this so there's a
*few* files modified in this PR.
Dependencies:
- [x] PR that upgrades CI to use rust 1.74 is merged.
---------
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
Co-authored-by: Branislav Kontur <bkontur@gmail.com >
Co-authored-by: Liam Aharon <liam.aharon@hotmail.com >
2023-12-13 15:11:07 +01:00
4a293bc5a2
Enforce consistent and correct toml formatting ( #2518 )
...
Using taplo, fixes all our broken and inconsistent toml formatting and
adds CI to keep them tidy.
If people want we can customise the format rules as described here
https://taplo.tamasfe.dev/configuration/formatter-options.html
@ggwpez, I suggest zepter is used only for checking features are
propagated, and leave formatting for taplo to avoid duplicate work and
conflicts.
TODO
- [x] Use `exclude = [...]` syntax in taplo file to ignore zombienet
tests instead of deleting the dir
---------
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: Bastian Köcher <git@kchr.de >
2023-12-01 07:38:02 +00:00
eaf1bc5633
Introduce Polkadot-Sdk developer_hub ( #2102 )
...
This PR introduces the new crate `developer_hub` into the polkadot-sdk
repo. The vision for the developer-hub crate is detailed in [this
document](https://docs.google.com/document/d/1XLLkFNE8v8HLvZpI2rzsa8N2IN1FcKntc8q-Sc4xBAk/edit?usp=sharing ).
<img width="1128" alt="Screenshot 2023-11-02 at 10 45 48"
src="https://github.com/paritytech/polkadot-sdk/assets/5588131/1e12b60f-fef5-42c4-8503-a3ba234077c3 ">
Other than adding the new crate, it also does the following:
* Remove the `substrate` crate, as there is now a unique umbrella crate
for multiple things in `developer_hub::polkadot_sdk`.
* (backport candidate) A minor change to `frame-support` macros that
allows `T::RuntimeOrigin` to also be acceptable as the origin type.
* (backport candidate) A minor change to `frame-system` that allows us
to deposit events at genesis because now the real genesis config is
generated via wasm, and we can safely assume `cfg!(feature = "std")`
means only testing. related to #62 .
* (backport candidate) Introduces a small `read_events_for_pallet` to
`frame_system` for easier event reading in tests.
* From https://github.com/paritytech/polkadot-sdk-docs/issues/31 , it
takes action on improving the `pallet::call` docs.
* From https://github.com/paritytech/polkadot-sdk-docs/issues/31 , it
takes action on improving the `UncheckedExtrinsic` docs.
## Way Forward
First, a version of this is deployed temporarily
[here](https://blog.kianenigma.nl/polkadot-sdk/developer_hub/index.html ).
I will keep it up to date on a daily basis.
### This Pull Request
I see two ways forward:
1. We acknowledge that everything in `developer-hub` is going to be WIP,
and merge this asap. We should not yet use links to this crate anywhere.
2. We make this be the feature branch, make PRs against this, and either
gradually backport it, or only merge to master once it is done.
I am personally in favor of option 1. If we stick to option 2, we need a
better way to deploy a staging version of this to gh-pages.
### Issue Tracking
The main issues related to the future of `developer_hub` are:
- https://github.com/paritytech/polkadot-sdk-docs/issues/31
- https://github.com/paritytech/polkadot-sdk-docs/issues/4
- https://github.com/paritytech/polkadot-sdk-docs/issues/26
- https://github.com/paritytech/polkadot-sdk-docs/issues/32
- https://github.com/paritytech/polkadot-sdk-docs/issues/36
### After This Pull Request
- [ ] create a redirect for
https://paritytech.github.io/polkadot-sdk/master/substrate/
- [x] analytics
- [ ] link checker
- [ ] the matter of publishing, and how all of these relative links for
when we do, that is still an open question. There is section on this in
the landing page.
- [ ] updated https://paritytech.github.io/
---------
Co-authored-by: Liam Aharon <liam.aharon@hotmail.com >
Co-authored-by: Juan Girini <juangirini@gmail.com >
Co-authored-by: bader y <ibnbassem@gmail.com >
Co-authored-by: Sebastian Kunert <skunert49@gmail.com >
Co-authored-by: James Wilson <james@jsdw.me >
Co-authored-by: Michal Kucharczyk <1728078+michalkucharczyk@users.noreply.github.com >
2023-11-30 12:15:46 +01:00
cd8741c8b5
Moves all test runtimes to use derive_impl ( #2409 )
...
Step in https://github.com/paritytech/polkadot-sdk/issues/171
This PR adds `derive_impl` on all `frame_system` config impls for mock
runtimes. The overridden configs are maintained as of now to ensure
minimal changes.
---------
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
2023-11-28 14:13:57 +01:00
c66ae375e6
[FRAME] Short-circuit fungible self transfer ( #2118 )
...
Changes:
- Change the fungible(s) logic to treat a self-transfer as No-OP (as
long as all pre-checks pass).
Note that the self-transfer case will not emit an event since no state
was changed.
---------
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
2023-11-01 22:11:28 +01:00
0aeab38138
Stop Balances pallet erroneously double incrementing and decrementing consumers ( #1976 )
...
Closes https://github.com/paritytech/polkadot-sdk/issues/1970
Follow up issue to tackle, once the erroneous double
incrementing/decrementing has stopped:
https://github.com/paritytech/polkadot-sdk/issues/2037
2023-10-30 19:48:30 +11:00
35eb133baa
Ensure correct variant count in Runtime[Hold/Freeze]Reason ( #1900 )
...
closes https://github.com/paritytech/polkadot-sdk/issues/1882
## Breaking Changes
This PR introduces a new item to `pallet_balances::Config`:
```diff
trait Config {
++ type RuntimeFreezeReasons;
}
```
This value is only used to check it against `type MaxFreeze`. A similar
check has been added for `MaxHolds` against `RuntimeHoldReasons`, which
is already given to `pallet_balances`.
In all contexts, you should pass the real `RuntimeFreezeReasons`
generated by `construct_runtime` to `type RuntimeFreezeReasons`. Passing
`()` would also work, but it would imply that the runtime uses no
freezes at all.
---------
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
2023-10-24 12:01:04 +02:00
f3bf5c1acd
xcm: Change TypeInfo::path to not include staging (#1948 )
...
The `xcm` crate was renamed to `staging-xcm` to be able to publish it to
crates.io as someone as squatted `xcm`. The problem with this rename is
that the `TypeInfo` includes the crate name which ultimately lands in
the metadata. The metadata is consumed by downstream users like
`polkadot-js` or people building on top of `polkadot-js`. These people
are using the entire `path` to find the type in the type registry. Thus,
their code would break as the type path would now be [`staging_xcm`,
`VersionedXcm`] instead of [`xcm`, `VersionedXcm`]. This pull request
fixes this by renaming the path segment `staging_xcm` to `xcm`.
This requires: https://github.com/paritytech/scale-info/pull/197
---------
Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com >
2023-10-20 11:21:19 +02:00
d9e266f432
nit: use traits::tokens::fungible => use traits::fungible ( #1753 )
...
Slightly less verbose use of fungible(s).
---------
Co-authored-by: Liam Aharon <liam.aharon@hotmail.com >
2023-10-17 11:55:59 +02:00
fcc1bb414b
Allow Locks/Holds/Reserves/Freezes by default when using pallet_balances TestDefaultConfig ( #1880 )
...
Allow Locks/Holds/Reserves/Freezes by default when using
`pallet_balances` `TestDefaultConfig`.
2023-10-17 08:06:03 +11:00
c422e3f577
extract amount method for fungible/s Imbalance (#1847 )
...
Introduces an `extract` amount method for `fungible/s` `Imbalance`.
2023-10-16 17:16:59 +02:00
6b27dad359
Adds instance support for composite enums ( #1857 )
...
Fixes https://github.com/paritytech/polkadot-sdk/issues/1839
Currently, `composite_enum`s do not support pallet instances. This PR
allows the following:
```rust
#[pallet::composite_enum]
pub enum HoldReason<I: 'static = ()> {
SomeHoldReason
}
```
### Todo
- [x] UI Test
2023-10-13 07:48:51 +02:00
2ed66a0960
migrate alliance, fast-unstake and bags list to use derive-impl ( #1636 )
...
Moving a few pallets to the latest and greatest `derive_impl` to give it
a try.
Part of #171
---------
Co-authored-by: Adrian Catangiu <adrian@parity.io >
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
2023-10-01 16:16:14 +02:00
d787269cdf
FRAME: Revamp Preimage pallet to use Consideration ( #1363 )
...
Make Preimage pallet use Consideration instead of handling deposits
directly.
Other half of paritytech/substrate#13666.
Depends/based on #1361 .
Script for the lazy migration that should be run manually once:
[migrate-preimage-lazy.py](https://github.com/ggwpez/substrate-scripts/blob/master/migrate-preimage-lazy.py ).
## TODO
- [x] Migration code.
---------
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: command-bot <>
Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com >
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
2023-09-17 12:19:18 +01:00
68ab943c65
Remove deprecated pallet_balances's set_balance_deprecated and transfer dispatchables ( #1226 )
...
* remove deprecated dispatchables
* update test
* update tests
* update tests
* add prdocs
* add prdoc
* Update docs/prdoc/pr_1226.prdoc
Co-authored-by: Chevdor <chevdor@users.noreply.github.com >
* move prdoc file
---------
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
Co-authored-by: Chevdor <chevdor@users.noreply.github.com >
2023-09-06 16:06:47 +03:00
a30092ab42
Markdown linter ( #1309 )
...
* Add markdown linting
- add linter default rules
- adapt rules to current code
- fix the code for linting to pass
- add CI check
fix #1243
* Fix markdown for Substrate
* Fix tooling install
* Fix workflow
* Add documentation
* Remove trailing spaces
* Update .github/.markdownlint.yaml
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix mangled markdown/lists
* Fix captalization issues on known words
2023-09-04 12:02:32 +03:00
bfb241d7f3
Add missing licenses and tune the scanning workflow ( #1288 )
...
* Add missing Cumulus licenses
* Typo
* Add missing Substrate licenses
* Single job checking the sub-repos in steps
* Remove dates
* Remove dates
* Add missing (C)
* Update FRAME UI tests
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update more UI tests
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
---------
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
2023-08-30 15:45:49 +03:00
dcda0e50f5
Fix build profiles ( #1229 )
...
* Fix build profiles
Closes https://github.com/paritytech/polkadot-sdk/issues/1155
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Manually set version to 1.0.0
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Use workspace repo
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* 'Authors and Edition from workspace
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
---------
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
2023-08-29 13:39:41 +02:00
f441a5fc93
Diener workspacify
...
Signed-off-by: alvicsam <alvicsam@gmail.com >
2023-08-25 11:05:17 +02:00
83ae018087
Adds ability to provide defaults for types provided by construct_runtime ( #14682 )
...
* Adds ability to use defaults for verbatim types
* Adds RuntimeOrigin and PalletInfo in DefaultConfig
* Adds RuntimeEvent in DefaultConfig
* Adds RuntimeEvent in DefaultConfig
* Minor fix
* Minor fix
* Everything in frame_system can now have a default
* Adds docs
* Adds UI Test for no_bounds
* Updates docs
* Adds UI tests for verbatim
* Minor update
* Minor updates
* Minor updates
* Addresses review comments
* Fixes test
* Update frame/support/procedural/src/derive_impl.rs
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
* Minor fix
* Minor
* Fixes build
* Uses runtime_type
* Fixes comment
* Fixes comment
* Fixes test
* Uses no_aggregated_types as an option in derive_impl
* Uses specific imports
* Fmt
* Updates doc
* Update frame/support/procedural/src/derive_impl.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* Update frame/support/procedural/src/derive_impl.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* Addresses review comment
* Addresses review comment
* fmt
* Renames test files
* Adds docs using docify
* Fixes test
* Fixes UI tests
---------
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
Co-authored-by: Bastian Köcher <git@kchr.de >
2023-08-25 07:52:22 +00:00
8b9455465b
Format and Sort features in Cargo.toml files ( #14803 )
...
* CI: Add feature sorting check
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Sort all features
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add some mistakes
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Revert "Add some mistakes"
This reverts commit b2b1099f979f6decb22d09b46689c1554bb72e81.
* CI job naming
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add oneliner formatting
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Explain tool
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Use latest version
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Better erorr message
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Format after master merge
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Use --check option
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Messed up the merge commit...
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
---------
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
2023-08-23 14:21:52 +00:00
878c562cd4
Restructure frame_support macro related exports ( #14745 )
...
* make reexports private
* make reexports private 2
* make reexports private for runtime-benchmarking
* make reexports private for try-runtime
* fix for try-runtime
* make reexports private for tests
* fmt
* make reexports private for tests
* make reexports private for experimental
* fix beefy
* fix ui test
* fix ui test
* fix benches
* ".git/.scripts/commands/fmt/fmt.sh"
* fix contracts use
* wip
* wip
* do not reexport sp_api::metadata_ir
* fix CI checks
* fix support tests
* ".git/.scripts/commands/fmt/fmt.sh"
* Update frame/support/src/lib.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* import codec directly
* fmt
* fix node-cli tests
---------
Co-authored-by: command-bot <>
Co-authored-by: Bastian Köcher <git@kchr.de >
2023-08-23 12:30:12 +00:00
43cd1ae37a
add frame_system::DefaultConfig to individual pallet DefaultConfigs ( #14453 )
...
* add frame_system::DefaultConfig to individual pallet DefaultConfigs
* Fixes tests
* Minor fix
* ".git/.scripts/commands/fmt/fmt.sh"
* Adds UI Tests
---------
Co-authored-by: Nikhil Gupta <17176722+gupnik@users.noreply.github.com >
Co-authored-by: command-bot <>
2023-08-14 10:53:54 +00:00
77321288c3
Fix Substrate features ( #14660 )
...
* Fix std, runtime-benchmarks and try-runtime features
zepter lint propagate-feature --feature try-runtime --left-side-feature-missing=ignore --workspace --fix --feature-enables-dep="try-runtime:frame-try-runtime"
zepter lint propagate-feature --feature runtime-benchmarks --left-side-feature-missing=ignore --workspace --fix --feature-enables-dep="runtime-benchmarks:frame-benchmarking"
zepter lint propagate-feature --feature std --left-side-feature-missing=ignore --workspace --fix
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add propagate feature CI check
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Test CI by adding an error
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Use --locked
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add help msg
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Revert "Test CI by adding an error"
This reverts commit cf4ff6cc0632269b0a109e547686e5e3314b02de.
* Test CI by adding an error
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* No newline in help msg
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Revert "Test CI by adding an error"
This reverts commit 5daa06ada8e01f5bebafb9d1c76804dd79bc1006.
* Test CI by adding an error
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Revert "Test CI by adding an error"
This reverts commit ca15de5729507a564f140a10ec2e87b19516ec4c.
* Fix msg
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Revert back to master
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Re-do with Zepter v0.7.4
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update Zepter to 0.7.4
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Disable rococo try-runtime check
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Apply suggestions from code review
Co-authored-by: Bastian Köcher <git@kchr.de >
* More review fixes
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
---------
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: Bastian Köcher <git@kchr.de >
2023-08-01 20:25:59 +00:00
70694b903a
change $location from tt* to ty and remove unnecessary cb_* versions ( #14571 )
...
* change $location from tt* to ty and remove unnecessary cb_* versions
* fmt
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_balances
---------
Co-authored-by: Liam Aharon <liam.aharon@hotmail.com >
Co-authored-by: parity-processbot <>
2023-07-14 12:43:24 +00:00
6a29a70a92
Replace system config Index for Nonce ( #14290 )
...
* replace Index by Nonce
* replace Index by Nonce
* replace Index by Nonce
* replace Index by Nonce
* replace Index by Nonce
* wip
* remove index in lieu of nonce
* wip
* remove accountnonce in lieu of nonce
* add minor improvement
* rebase and merge conflicts
2023-07-14 06:56:48 +00:00
5e7b27e98c
Moves Block to frame_system instead of construct_runtime and removes Header and BlockNumber ( #14437 )
...
* Initial setup
* Adds node block
* Uses UncheckedExtrinsic and removes Where section
* Updates frame_system to use Block
* Adds deprecation warning
* Fixes pallet-timestamp
* Removes Header and BlockNumber
* Addresses review comments
* Addresses review comments
* Adds comment about compiler bug
* Removes where clause
* Refactors code
* Fixes errors in cargo check
* Fixes errors in cargo check
* Fixes warnings in cargo check
* Formatting
* Fixes construct_runtime tests
* Uses import instead of full path for BlockNumber
* Uses import instead of full path for Header
* Formatting
* Fixes construct_runtime tests
* Fixes imports in benchmarks
* Formatting
* Fixes construct_runtime tests
* Formatting
* Minor updates
* Fixes construct_runtime ui tests
* Fixes construct_runtime ui tests with 1.70
* Fixes docs
* Fixes docs
* Adds u128 mock block type
* Fixes split example
* fixes for cumulus
* ".git/.scripts/commands/fmt/fmt.sh"
* Updates new tests
* Fixes fully-qualified path in few places
* Formatting
* Update frame/examples/default-config/src/lib.rs
Co-authored-by: Juan <juangirini@gmail.com >
* Update frame/support/procedural/src/construct_runtime/mod.rs
Co-authored-by: Juan <juangirini@gmail.com >
* ".git/.scripts/commands/fmt/fmt.sh"
* Addresses some review comments
* Fixes build
* ".git/.scripts/commands/fmt/fmt.sh"
* Update frame/democracy/src/lib.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update frame/democracy/src/lib.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update frame/support/procedural/src/construct_runtime/mod.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update frame/support/procedural/src/construct_runtime/mod.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Addresses review comments
* Updates trait bounds
* Minor fix
* ".git/.scripts/commands/fmt/fmt.sh"
* Removes unnecessary bound
* ".git/.scripts/commands/fmt/fmt.sh"
* Updates test
* Fixes build
* Adds a bound for header
* ".git/.scripts/commands/fmt/fmt.sh"
* Removes where block
* Minor fix
* Minor fix
* Fixes tests
* ".git/.scripts/commands/update-ui/update-ui.sh" 1.70
* Updates test
* Update primitives/runtime/src/traits.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* Update primitives/runtime/src/traits.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* Updates doc
* Updates doc
---------
Co-authored-by: command-bot <>
Co-authored-by: Juan <juangirini@gmail.com >
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: Bastian Köcher <git@kchr.de >
2023-07-13 12:01:34 +00:00
87d41d0a89
GenesisBuild<T,I> deprecated. BuildGenesisConfig added. (#14306 )
...
* frame::support: GenesisConfig types for Runtime enabled
* frame::support: macro generating GenesisBuild::build for RuntimeGenesisConfig
* frame: ambiguity BuildStorage vs GenesisBuild fixed
* fix
* RuntimeGenesisBuild added
* Revert "frame: ambiguity BuildStorage vs GenesisBuild fixed"
This reverts commit 950f3d019d0e21c55a739c44cc19cdabd3ff0293.
* Revert "fix"
This reverts commit a2f76dd24e9a16cf9230d45825ed28787211118b.
* Revert "RuntimeGenesisBuild added"
This reverts commit 3c131b618138ced29c01ab8d15d8c6410c9e128b.
* Revert "Revert "frame: ambiguity BuildStorage vs GenesisBuild fixed""
This reverts commit 2b1ecd467231eddec69f8d328039ba48a380da3d.
* Revert "Revert "fix""
This reverts commit fd7fa629adf579d83e30e6ae9fd162637fc45e30.
* Code review suggestions
* frame: BuildGenesisConfig added, BuildGenesis deprecated
* frame: some pallets updated with BuildGenesisConfig
* constuct_runtime: support for BuildGenesisConfig
* frame::support: genesis_build macro supports BuildGenesisConfig
* frame: BuildGenesisConfig added, BuildGenesis deprecated
* Cargo.lock update
* test-runtime: fixes
* Revert "fix"
This reverts commit a2f76dd24e9a16cf9230d45825ed28787211118b.
* Revert "frame: ambiguity BuildStorage vs GenesisBuild fixed"
This reverts commit 950f3d019d0e21c55a739c44cc19cdabd3ff0293.
* self review
* doc fixed
* ui tests fixed
* fmt
* tests fixed
* genesis_build macrto fixed for non-generic GenesisConfig
* BuildGenesisConfig constraints added
* warning fixed
* some duplication removed
* fmt
* fix
* doc tests fix
* doc fix
* cleanup: remove BuildModuleGenesisStorage
* self review comments
* fix
* Update frame/treasury/src/tests.rs
Co-authored-by: Sebastian Kunert <skunert49@gmail.com >
* Update frame/support/src/traits/hooks.rs
Co-authored-by: Sebastian Kunert <skunert49@gmail.com >
* doc fix: GenesisBuild exposed
* ".git/.scripts/commands/fmt/fmt.sh"
* frame: more serde(skip) + cleanup
* Update frame/support/src/traits/hooks.rs
Co-authored-by: Davide Galassi <davxy@datawok.net >
* frame: phantom fields moved to the end of structs
* chain-spec: Default::default cleanup
* test-runtime: phantom at the end
* merge master fixes
* fix
* fix
* fix
* fix
* fix (facepalm)
* Update frame/support/procedural/src/pallet/expand/genesis_build.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* fmt
* fix
* fix
---------
Co-authored-by: parity-processbot <>
Co-authored-by: Sebastian Kunert <skunert49@gmail.com >
Co-authored-by: Davide Galassi <davxy@datawok.net >
Co-authored-by: Bastian Köcher <git@kchr.de >
2023-07-12 10:22:12 +00:00
49150ee583
quick updates ( #14557 )
2023-07-12 08:59:01 +00:00
53244d64bd
Fix spellcheck for benchmarking comments ( #14535 )
...
* Benchmarking spellcheck fix
Put everything that could cause spellcheck issues into backticks.
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Also in templates
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet-balances
---------
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: command-bot <>
2023-07-07 15:33:17 +00:00
9d1741eb3c
Bump parity-scale-codec to 3.6.1 ( #14428 )
2023-06-21 11:37:11 +00:00
0aa79f87ca
".git/.scripts/commands/bench-vm/bench-vm.sh" all ( #13933 )
...
Co-authored-by: command-bot <>
2023-06-19 14:31:20 +01:00
e9bb5e737a
Expose ExtraFlags struct ( #14376 )
2023-06-14 16:44:47 +00:00
50d5b94225
add test locking removed when amount is zero ( #14284 )
...
* add test locking removed when amount is zero
* add test set lock with withdraw reasons empty removes lock
* fix test set lock with withdraw reasons
2023-06-02 12:07:05 +00:00
3da9449067
Bump sp-crates from latest crates.io version + release ( #14265 )
...
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io >
2023-05-31 12:11:01 +00:00
98a0550ea2
Release: Bump SP crates to release on crates.io ( #14237 )
...
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io >
2023-05-29 10:40:59 +00:00
05da6d8e84
HoldReason: Improve usage ( #13869 )
...
* HoldReason: Improve usage
`HoldReason` was switched recently to use the `composite_enum` attribute that will merge the enums
from all pallets in the runtime to `RuntimeHoldReason`. `pallet-nis` was still requiring that the
variant was passed as constant to call `hold`. The proper implementation is to use the `HoldReason`
from inside the pallet directly when calling `hold`. This is done by adding a `RuntimeHoldReason` as
type to the `Config` trait and requiring that `Currency` is using the same reason. Besides that the
pr changes the name `HoldIdentifier` in `pallet_balances::Config` to `RuntimeHoldReason`.
* Update frame/nis/src/lib.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Review comment
* Fixes
---------
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
2023-05-24 21:59:34 +00:00
06865d4c08
Actually respect locks of zero ( #14144 )
...
* Actually thaw when locking zero.
* Fixes
* Just remove the lock if semantically viable
---------
Co-authored-by: parity-processbot <>
2023-05-23 08:47:08 +00:00
613420a035
frame: Enable GenesisConfig in no_std ( #14108 )
...
* frame: Default for GenesisConfig in no_std
`Default` for `GenesisConfig` will be required for no_std in no native
runtime world. It must be possible to instantiate default GenesisConfig
for pallets and runtime.
* ".git/.scripts/commands/fmt/fmt.sh"
* hash69 in no_std reverted
* derive(DefaultNoBound) for GenesisConfig used when possible
* treasury: derive(Default)
* Cargo.lock update
* genesis_config: compiler error improved
When std feature is not enabled for pallet, the GenesisConfig will be
defined, but serde::{Serialize,Deserialize} traits will not be
implemented.
The compiler error indicates the reason of latter errors.
This is temporary and serde traits will be enabled with together with
`serde` support in frame.
---------
Co-authored-by: command-bot <>
2023-05-20 07:34:23 +00:00
99b05fd918
chore: move whitelist test to better place and add missing Inactive Issuance ( #14130 )
...
* chore: move whitelist test to better palace and add missing `Inactive Issuance`
* remove duplicated
---------
Co-authored-by: parity-processbot <>
2023-05-17 22:26:33 +00:00
9c53fd7299
fungible conformance tests: Inspect and Mutate ( #13852 )
...
* typo
* - create test files for each fungile trait
- begin implementing tests for the Inspect trait
* wrap inspect tests in a macro
* first run of mutate tests
* move test implementation out of ballances
* make tests more generic
* transfer tests
* combine inspect and mutate tests
* set balance failing tests
* can_deposit tests
* can_withdraw tests
* test reducible_balance
* remove balanced stub
* revert set_balance return val fix
* typo
* macro and dust trap tests
* disable test when it doesn't make sense
* remove debug comment
* reduce macro boilerplate
* improved var naming
* improve variable naming
* remove redundant comment
* remove placeholder tests
* remove placeholder tests
* simplify macro
* Update frame/balances/src/tests/fungible_conformance_tests.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* use Balance from T
* fix copyright
* add test doc comments
* improve test naming
* clippy
* fix rustdoc errors
* fix rustdoc
* improve macro
* improve variable naming
* remove redundant comment
* use path
---------
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
2023-05-05 02:21:40 +10:00
b5201fa0ec
FRAME: inherited call weight syntax ( #13932 )
...
* First approach on pallet::call_weight
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Use attr on pallet::call instead
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Ui tests
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Rename to weight(prefix = ...))
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Simplify to #[pallet::call(weight(T))]
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add stray token error
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Cleanup
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Migrate remaining pallets
Using script from https://github.com/ggwpez/substrate-scripts/blob/e1b5ea5b5b4018867f3e869fce6f448b4ba9d71f/frame-code-migration/src/call_weight.rs
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Try to add some docs
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Revert "Migrate remaining pallets"
Lets do this as a follow-up, I dont want to bloat this small MR.
This reverts commit 331d4b42d72de1dacaed714d69166fa1bc9c92dd.
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Renames
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Review fixes
Co-authored-by: Sam Johnson <sam@durosoft.com >
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Test weights
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update UI tests
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update frame/support/procedural/src/pallet/parse/mod.rs
Co-authored-by: Muharem Ismailov <ismailov.m.h@gmail.com >
* Remove old code
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update docs
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
---------
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: parity-processbot <>
Co-authored-by: Muharem Ismailov <ismailov.m.h@gmail.com >
2023-04-27 14:08:08 +00:00
781ea7cbdc
Various minor fixes ( #13945 )
...
* Fix: Incorrect implementation of can_reserve check
* Fix: Incorrect migration of consumer counting for existing accounts with frozen amounts
* Fix: Inconsistent implementation between assets can_deposit and new_account
* Fixes
* Fixes
* Another fix
* Update tests.rs
* Update fungible_tests.rs
* Use `can_accrue_consumers` in the body of `can_inc_consumer`
---------
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: parity-processbot <>
2023-04-26 14:26:07 +00:00
4411e8cec2
Add Freeze/Thaw events and tests ( #13779 )
...
* Add Freeze/Thaw events and tests
* Remove duplicate docstring
* Correct spelling error
* Cargo fmt
* Use proper punctuation in docstring
Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com >
---------
Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com >
Co-authored-by: parity-processbot <>
2023-04-21 12:06:26 +02:00
eb17581e3c
balances impl_currency WithdrawReasons note (#13964 )
...
* add withdrawreason note
* improve comment
* Update frame/balances/src/impl_currency.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* cargo fmt +nightly
---------
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
2023-04-21 18:46:54 +10:00
d23a251ee9
Balances: repatriate_reserved should respect freezes ( #13885 )
...
* repatriate_reserved should respect freezes
* Docs
* Fix and clean
* Formatting
* Update frame/balances/src/types.rs
Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com >
* Fix
* Simplify
* Fixes
* Fixes
---------
Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com >
2023-04-17 19:13:55 +01:00
ebfe00d590
Fixes PoV over-estimation ( #13766 )
...
* Align log
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Use max instead of sum
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Make comment ordering deterministic
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Dont add Pov overhead when all is ignored
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update test pallet weights
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Re-run weights on bm2
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix test
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Actually use new weights
Fucked up the merge for this file...
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update contract weights
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
---------
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
2023-04-13 13:11:58 +00:00
376a288fb6
[Deps] Bump scale-info to match cumulus and polkadot ( #13873 )
...
* [Deps] Bump scale-info to match cumulus and polkadot
* fix Cargo.lock
* fix identity
* more fixes
* fix
* fixes
* more fixes
2023-04-12 14:14:06 +02:00
83b6336251
Force incrementing of consumers ( #13878 )
2023-04-11 17:12:08 +00:00
d997103476
FRAME: Minor fix for failsafe. ( #13741 )
...
* max instead of min
* Remove debug stuff
* remove debug code
* warn log on no provider ref
* format string for log
---------
Co-authored-by: muharem <ismailov.m.h@gmail.com >
2023-04-01 23:59:37 +02:00
Squirrel