be8e626806
Set clippy lints in workspace (requires rust 1.74) ( #2390 )
...
We currently use a bit of a hack in `.cargo/config` to make sure that
clippy isn't too annoying by specifying the list of lints.
There is now a stable way to define lints for a workspace. The only down
side is that every crate seems to have to opt into this so there's a
*few* files modified in this PR.
Dependencies:
- [x] PR that upgrades CI to use rust 1.74 is merged.
---------
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
Co-authored-by: Branislav Kontur <bkontur@gmail.com >
Co-authored-by: Liam Aharon <liam.aharon@hotmail.com >
2023-12-13 15:11:07 +01:00
1bdfb29587
[NTFs] Emit CollectionMaxSupplySet on collection create ( #2626 )
...
Closes #2293
if the max_supply is set during the collection creation, we emit the
`CollectionMaxSupplySet` event
2023-12-08 12:26:13 +02:00
4a293bc5a2
Enforce consistent and correct toml formatting ( #2518 )
...
Using taplo, fixes all our broken and inconsistent toml formatting and
adds CI to keep them tidy.
If people want we can customise the format rules as described here
https://taplo.tamasfe.dev/configuration/formatter-options.html
@ggwpez, I suggest zepter is used only for checking features are
propagated, and leave formatting for taplo to avoid duplicate work and
conflicts.
TODO
- [x] Use `exclude = [...]` syntax in taplo file to ignore zombienet
tests instead of deleting the dir
---------
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: Bastian Köcher <git@kchr.de >
2023-12-01 07:38:02 +00:00
cd8741c8b5
Moves all test runtimes to use derive_impl ( #2409 )
...
Step in https://github.com/paritytech/polkadot-sdk/issues/171
This PR adds `derive_impl` on all `frame_system` config impls for mock
runtimes. The overridden configs are maintained as of now to ensure
minimal changes.
---------
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
2023-11-28 14:13:57 +01:00
21f1811c66
sp-api: Move macro related re-exports to __private ( #2446 )
...
This moves the macro related re-exports to `__private` to make it more
obvious for downstream users that they are using an internal api.
---------
Co-authored-by: command-bot <>
2023-11-23 14:52:46 +01:00
0bcebac4fc
Expose collection attributes from Inspect trait ( #1914 )
...
# Description
- What does this PR do?
While working with `pallet_nfts` through `nonfungibles_v2` traits
`Inspect, Mutate`, I found out that once you have set the collection
attribute with `<Nfts as Mutate>::set_collection_attribute()`, it's not
possible to read it with `<Nfts as Inspect>::collection_attribute()`
since they use different `namespace` values. When setting the attribute,
`AttributeNamespace::Pallet` is used, while
`AttributeNamespace::CollectionOwner` is used when reading.
more context:
https://github.com/freeverseio/laos/issues/7#issuecomment-1766137370
This PR makes `item` an optional parameter in
`Inspect::system_attribute()`, to be able to read collection attributes.
- Why are these changes needed?
To be able to read collection level attributes when reading attributes
of the collection. It will be possible to read collection attributes by
passing `None` for `item`
- How were these changes implemented and what do they affect?
`NftsApi` is also affected and `NftsApi::system_attribute()` now accepts
optional `item` parameter.
## Breaking change
Because of the change in the `NftsApi::system_attribute()` method's
`item` param, parachains who integrated the `NftsApi` need to update
their API code and frontend integrations accordingly. AssetHubs are
unaffected since the NftsApi wasn't released on those parachains yet.
2023-10-26 09:52:12 +00:00
4a44356773
Improve features dev-ex ( #1831 )
...
Adds a config file that allows to run `zepter` without any arguments in
the workspace to address all issues.
A secondary workflow for the CI is provided as `zepter run check`. Both
the formatting and linting are now in one check for efficiancy.
The latest version also detects some more things that `featalign` was
already showing.
Error message [in the
CI](https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3916205 )
now looks like this:
```pre
...
crate 'test-parachains' (/Users/vados/Documents/work/polkadot-sdk/polkadot/parachain/test-parachains/Cargo.toml)
feature 'std'
must propagate to:
parity-scale-codec
Found 55 issues (run with --fix to fix).
Error: Command 'lint propagate-feature' failed with exit code 1
Polkadot-SDK uses the Zepter CLI to detect abnormalities in the feature configuration.
It looks like one more more checks failed; please check the console output. You can try to automatically address them by running `zepter`.
Otherwise please ask directly in the Merge Request, GitHub Discussions or on Matrix Chat, thank you.
For more information, see:
- https://github.com/paritytech/polkadot-sdk/issues/1831
- https://github.com/ggwpez/zepter
```
TODO:
- [x] Check that CI fails correctly
---------
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
2023-10-24 17:59:38 +02:00
35eb133baa
Ensure correct variant count in Runtime[Hold/Freeze]Reason ( #1900 )
...
closes https://github.com/paritytech/polkadot-sdk/issues/1882
## Breaking Changes
This PR introduces a new item to `pallet_balances::Config`:
```diff
trait Config {
++ type RuntimeFreezeReasons;
}
```
This value is only used to check it against `type MaxFreeze`. A similar
check has been added for `MaxHolds` against `RuntimeHoldReasons`, which
is already given to `pallet_balances`.
In all contexts, you should pass the real `RuntimeFreezeReasons`
generated by `construct_runtime` to `type RuntimeFreezeReasons`. Passing
`()` would also work, but it would imply that the runtime uses no
freezes at all.
---------
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
2023-10-24 12:01:04 +02:00
f3bf5c1acd
xcm: Change TypeInfo::path to not include staging (#1948 )
...
The `xcm` crate was renamed to `staging-xcm` to be able to publish it to
crates.io as someone as squatted `xcm`. The problem with this rename is
that the `TypeInfo` includes the crate name which ultimately lands in
the metadata. The metadata is consumed by downstream users like
`polkadot-js` or people building on top of `polkadot-js`. These people
are using the entire `path` to find the type in the type registry. Thus,
their code would break as the type path would now be [`staging_xcm`,
`VersionedXcm`] instead of [`xcm`, `VersionedXcm`]. This pull request
fixes this by renaming the path segment `staging_xcm` to `xcm`.
This requires: https://github.com/paritytech/scale-info/pull/197
---------
Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com >
2023-10-20 11:21:19 +02:00
3aaf62add4
Trading trait and deal with metadata in Mutate trait for nonfungibles_v2 ( #1561 )
...
I have added some Traits that are missing and are useful for dealing
with non-fungible tokens on other pallets and their implementations for
NFTs pallet.
- In the Mutate trait, added methods for dealing with the metadata:
`set_metadata`, `set_collection_metadata`, `clear_metadata` and
`clear_collection_metadata`.
The motivation of adding this methods coming from a StackExchange
question asking for it: [Setting metadata of an item of the Nfts pallet
in a custom
pallet](https://substrate.stackexchange.com/questions/9974/setting-metadata-of-an-item-of-the-nfts-pallet-in-a-custom-pallet )
- A Trait for trading non-fungible items. The methods in that Trait are
`buy_item`, `set_price` and `item_price`
An example of where this Trait can be useful is a pallet that deals with
[NFT
Royalties](https://forum.polkadot.network/t/nfts-royalty-pallet/3766 )
and needs to perform this actions.
---------
Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com >
2023-10-18 13:33:29 +03:00
447e753323
ci: bump ci image to rust 1.73.0 ( #1830 )
...
Co-authored-by: command-bot <>
2023-10-11 19:49:59 +02:00
db3fd68726
Init System Parachain storage versions and add migration check jobs to CI ( #1344 )
...
Makes SPs first class citizens along with the relay chains in the
context of our CI runtime upgrade checks.
## Code changes
- Sets missing current storage version in `uniques` pallet
- Adds multisig V1 migration to run where it was missing
- Removes executed migration whos pre/post hooks were failing from
collectives runtime
- Initializes storage versions for SP pallets added after genesis
- Originally I was going to wait for
https://github.com/paritytech/polkadot-sdk/pull/1297 to be merged so
this wouldn't need to be done manually, but it doesn't seem like it'll
be merged any time soon so I've decided to set them manually to unblock
this
## CI changes
- Removed dependency of `westend` runtime upgrades being complete prior
to other ones running. I assume it is supposed to cache the
`try-runtime` build for a performance benefit, but it seems it wasn't
working. Maybe someone from the CI team can look into this or explain
why it needs to be there?
- Adds check-runtime-migration jobs for Parity asset-hubs, bridge-hubs
and contract chains
- Updated VARIABLES to accomodate the `kusama-runtime` package being
renamed to `staging-kusama-runtime` in
https://github.com/paritytech/polkadot-sdk/pull/1241
- Added `EXTRA_ARGS` variable to `check-runtime-migration`, and set
`--no-weight-warnings` to the relay chain runtime upgrade checks (relay
chains don't have weight restrictions).
2023-10-03 02:11:56 +11:00
a30092ab42
Markdown linter ( #1309 )
...
* Add markdown linting
- add linter default rules
- adapt rules to current code
- fix the code for linting to pass
- add CI check
fix #1243
* Fix markdown for Substrate
* Fix tooling install
* Fix workflow
* Add documentation
* Remove trailing spaces
* Update .github/.markdownlint.yaml
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix mangled markdown/lists
* Fix captalization issues on known words
2023-09-04 12:02:32 +03:00
bdbe982970
Restructure dispatch macro related exports ( #1162 )
...
* restructure dispatch macro related exports
* moved Dispatchable to lib.rs
* fix .gitignore final newline
* ".git/.scripts/commands/fmt/fmt.sh"
* fix rustdocs
* wip
---------
Co-authored-by: Liam Aharon <liam.aharon@hotmail.com >
Co-authored-by: command-bot <>
Co-authored-by: ordian <write@reusable.software >
2023-08-31 14:08:44 +03:00
bfb241d7f3
Add missing licenses and tune the scanning workflow ( #1288 )
...
* Add missing Cumulus licenses
* Typo
* Add missing Substrate licenses
* Single job checking the sub-repos in steps
* Remove dates
* Remove dates
* Add missing (C)
* Update FRAME UI tests
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update more UI tests
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
---------
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
2023-08-30 15:45:49 +03:00
dcda0e50f5
Fix build profiles ( #1229 )
...
* Fix build profiles
Closes https://github.com/paritytech/polkadot-sdk/issues/1155
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Manually set version to 1.0.0
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Use workspace repo
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* 'Authors and Edition from workspace
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
---------
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
2023-08-29 13:39:41 +02:00
f441a5fc93
Diener workspacify
...
Signed-off-by: alvicsam <alvicsam@gmail.com >
2023-08-25 11:05:17 +02:00
8b9455465b
Format and Sort features in Cargo.toml files ( #14803 )
...
* CI: Add feature sorting check
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Sort all features
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add some mistakes
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Revert "Add some mistakes"
This reverts commit b2b1099f979f6decb22d09b46689c1554bb72e81.
* CI job naming
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add oneliner formatting
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Explain tool
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Use latest version
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Better erorr message
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Format after master merge
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Use --check option
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Messed up the merge commit...
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
---------
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
2023-08-23 14:21:52 +00:00
878c562cd4
Restructure frame_support macro related exports ( #14745 )
...
* make reexports private
* make reexports private 2
* make reexports private for runtime-benchmarking
* make reexports private for try-runtime
* fix for try-runtime
* make reexports private for tests
* fmt
* make reexports private for tests
* make reexports private for experimental
* fix beefy
* fix ui test
* fix ui test
* fix benches
* ".git/.scripts/commands/fmt/fmt.sh"
* fix contracts use
* wip
* wip
* do not reexport sp_api::metadata_ir
* fix CI checks
* fix support tests
* ".git/.scripts/commands/fmt/fmt.sh"
* Update frame/support/src/lib.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* import codec directly
* fmt
* fix node-cli tests
---------
Co-authored-by: command-bot <>
Co-authored-by: Bastian Köcher <git@kchr.de >
2023-08-23 12:30:12 +00:00
6ce530db17
Make owned_item in MintWitness optional ( #14800 )
...
Co-authored-by: parity-processbot <>
2023-08-21 21:03:38 +00:00
ddb68d7b01
[fix lint warnings: NFTs pallet] fix clippy::missing_docs_in_private_items warnings ( #14610 )
...
* add docs for impl_codec_bitflags
* add missing docs for type aliases
* add docs to transfer module
* add docs for settings module
* add docs to roles module
* add docs to metadata module
* add docs to migration module
* add missing docs to feature library
* methods not functions
* add docs to lock module
* add docs to attributes module
* add docs to create_delete_item module
* add docs for create_delete_collection module
* add docs to buy_sell module
* add missing doc for buy_sell module
* add docs to atomic_swap module
* add docs to atomic_swap module
* add docs for approvals module
* run cargo fmt
* Fix issues with multi-line comments
* Apply suggestions from code review
Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com >
* update from review
* fmt
* update from review
* remove bitflag example
* ".git/.scripts/commands/fmt/fmt.sh"
* Apply suggestions from code review
Co-authored-by: Squirrel <gilescope@gmail.com >
* add note about pallet features
---------
Co-authored-by: Jegor Sidorenko <jegor@parity.io >
Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com >
Co-authored-by: parity-processbot <>
Co-authored-by: Squirrel <gilescope@gmail.com >
2023-08-16 09:54:03 +00:00
0146cb2ffe
[fix lint warnings: NFTs pallet] fix clippy::missing_errors_doc lint warnings ( #14648 )
...
* fix missing errors doc warnings
* cargo +nightly fmt
* Update frame/nfts/src/features/create_delete_item.rs
* Update frame/nfts/src/features/create_delete_item.rs
* Update frame/nfts/src/features/transfer.rs
* Update frame/nfts/src/features/create_delete_collection.rs
* add intra doc linking for errors
* fmt
* Apply suggestions from code review
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
---------
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
2023-08-15 10:00:54 +00:00
77321288c3
Fix Substrate features ( #14660 )
...
* Fix std, runtime-benchmarks and try-runtime features
zepter lint propagate-feature --feature try-runtime --left-side-feature-missing=ignore --workspace --fix --feature-enables-dep="try-runtime:frame-try-runtime"
zepter lint propagate-feature --feature runtime-benchmarks --left-side-feature-missing=ignore --workspace --fix --feature-enables-dep="runtime-benchmarks:frame-benchmarking"
zepter lint propagate-feature --feature std --left-side-feature-missing=ignore --workspace --fix
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add propagate feature CI check
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Test CI by adding an error
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Use --locked
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add help msg
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Revert "Test CI by adding an error"
This reverts commit cf4ff6cc0632269b0a109e547686e5e3314b02de.
* Test CI by adding an error
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* No newline in help msg
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Revert "Test CI by adding an error"
This reverts commit 5daa06ada8e01f5bebafb9d1c76804dd79bc1006.
* Test CI by adding an error
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Revert "Test CI by adding an error"
This reverts commit ca15de5729507a564f140a10ec2e87b19516ec4c.
* Fix msg
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Revert back to master
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Re-do with Zepter v0.7.4
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update Zepter to 0.7.4
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Disable rococo try-runtime check
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Apply suggestions from code review
Co-authored-by: Bastian Köcher <git@kchr.de >
* More review fixes
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
---------
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: Bastian Köcher <git@kchr.de >
2023-08-01 20:25:59 +00:00
ae018a01a4
changes to nfts pallet for xcm integration ( #14395 )
...
* Use Incrementable from frame_support::traits
* Chore
* make incremental fallible and new nfts function for custom collection ids
* fmt
* fix benchmark tests nfts
* add test
* fmt
* add safety comment to CollectionId
* fmt
* add comments to Incrementable
* line wrapping
* rewrap comments
* address feedback
* fmt
* change unwrap for expect
---------
Co-authored-by: Jegor Sidorenko <jegor@parity.io >
Co-authored-by: parity-processbot <>
2023-07-25 08:02:39 +00:00
6a29a70a92
Replace system config Index for Nonce ( #14290 )
...
* replace Index by Nonce
* replace Index by Nonce
* replace Index by Nonce
* replace Index by Nonce
* replace Index by Nonce
* wip
* remove index in lieu of nonce
* wip
* remove accountnonce in lieu of nonce
* add minor improvement
* rebase and merge conflicts
2023-07-14 06:56:48 +00:00
5e7b27e98c
Moves Block to frame_system instead of construct_runtime and removes Header and BlockNumber ( #14437 )
...
* Initial setup
* Adds node block
* Uses UncheckedExtrinsic and removes Where section
* Updates frame_system to use Block
* Adds deprecation warning
* Fixes pallet-timestamp
* Removes Header and BlockNumber
* Addresses review comments
* Addresses review comments
* Adds comment about compiler bug
* Removes where clause
* Refactors code
* Fixes errors in cargo check
* Fixes errors in cargo check
* Fixes warnings in cargo check
* Formatting
* Fixes construct_runtime tests
* Uses import instead of full path for BlockNumber
* Uses import instead of full path for Header
* Formatting
* Fixes construct_runtime tests
* Fixes imports in benchmarks
* Formatting
* Fixes construct_runtime tests
* Formatting
* Minor updates
* Fixes construct_runtime ui tests
* Fixes construct_runtime ui tests with 1.70
* Fixes docs
* Fixes docs
* Adds u128 mock block type
* Fixes split example
* fixes for cumulus
* ".git/.scripts/commands/fmt/fmt.sh"
* Updates new tests
* Fixes fully-qualified path in few places
* Formatting
* Update frame/examples/default-config/src/lib.rs
Co-authored-by: Juan <juangirini@gmail.com >
* Update frame/support/procedural/src/construct_runtime/mod.rs
Co-authored-by: Juan <juangirini@gmail.com >
* ".git/.scripts/commands/fmt/fmt.sh"
* Addresses some review comments
* Fixes build
* ".git/.scripts/commands/fmt/fmt.sh"
* Update frame/democracy/src/lib.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update frame/democracy/src/lib.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update frame/support/procedural/src/construct_runtime/mod.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update frame/support/procedural/src/construct_runtime/mod.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Addresses review comments
* Updates trait bounds
* Minor fix
* ".git/.scripts/commands/fmt/fmt.sh"
* Removes unnecessary bound
* ".git/.scripts/commands/fmt/fmt.sh"
* Updates test
* Fixes build
* Adds a bound for header
* ".git/.scripts/commands/fmt/fmt.sh"
* Removes where block
* Minor fix
* Minor fix
* Fixes tests
* ".git/.scripts/commands/update-ui/update-ui.sh" 1.70
* Updates test
* Update primitives/runtime/src/traits.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* Update primitives/runtime/src/traits.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* Updates doc
* Updates doc
---------
Co-authored-by: command-bot <>
Co-authored-by: Juan <juangirini@gmail.com >
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: Bastian Köcher <git@kchr.de >
2023-07-13 12:01:34 +00:00
87d41d0a89
GenesisBuild<T,I> deprecated. BuildGenesisConfig added. (#14306 )
...
* frame::support: GenesisConfig types for Runtime enabled
* frame::support: macro generating GenesisBuild::build for RuntimeGenesisConfig
* frame: ambiguity BuildStorage vs GenesisBuild fixed
* fix
* RuntimeGenesisBuild added
* Revert "frame: ambiguity BuildStorage vs GenesisBuild fixed"
This reverts commit 950f3d019d0e21c55a739c44cc19cdabd3ff0293.
* Revert "fix"
This reverts commit a2f76dd24e9a16cf9230d45825ed28787211118b.
* Revert "RuntimeGenesisBuild added"
This reverts commit 3c131b618138ced29c01ab8d15d8c6410c9e128b.
* Revert "Revert "frame: ambiguity BuildStorage vs GenesisBuild fixed""
This reverts commit 2b1ecd467231eddec69f8d328039ba48a380da3d.
* Revert "Revert "fix""
This reverts commit fd7fa629adf579d83e30e6ae9fd162637fc45e30.
* Code review suggestions
* frame: BuildGenesisConfig added, BuildGenesis deprecated
* frame: some pallets updated with BuildGenesisConfig
* constuct_runtime: support for BuildGenesisConfig
* frame::support: genesis_build macro supports BuildGenesisConfig
* frame: BuildGenesisConfig added, BuildGenesis deprecated
* Cargo.lock update
* test-runtime: fixes
* Revert "fix"
This reverts commit a2f76dd24e9a16cf9230d45825ed28787211118b.
* Revert "frame: ambiguity BuildStorage vs GenesisBuild fixed"
This reverts commit 950f3d019d0e21c55a739c44cc19cdabd3ff0293.
* self review
* doc fixed
* ui tests fixed
* fmt
* tests fixed
* genesis_build macrto fixed for non-generic GenesisConfig
* BuildGenesisConfig constraints added
* warning fixed
* some duplication removed
* fmt
* fix
* doc tests fix
* doc fix
* cleanup: remove BuildModuleGenesisStorage
* self review comments
* fix
* Update frame/treasury/src/tests.rs
Co-authored-by: Sebastian Kunert <skunert49@gmail.com >
* Update frame/support/src/traits/hooks.rs
Co-authored-by: Sebastian Kunert <skunert49@gmail.com >
* doc fix: GenesisBuild exposed
* ".git/.scripts/commands/fmt/fmt.sh"
* frame: more serde(skip) + cleanup
* Update frame/support/src/traits/hooks.rs
Co-authored-by: Davide Galassi <davxy@datawok.net >
* frame: phantom fields moved to the end of structs
* chain-spec: Default::default cleanup
* test-runtime: phantom at the end
* merge master fixes
* fix
* fix
* fix
* fix
* fix (facepalm)
* Update frame/support/procedural/src/pallet/expand/genesis_build.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* fmt
* fix
* fix
---------
Co-authored-by: parity-processbot <>
Co-authored-by: Sebastian Kunert <skunert49@gmail.com >
Co-authored-by: Davide Galassi <davxy@datawok.net >
Co-authored-by: Bastian Köcher <git@kchr.de >
2023-07-12 10:22:12 +00:00
5eb816d7a6
Removal of execution strategies ( #14387 )
...
* Start
* More work!
* Moar
* More changes
* More fixes
* More worrk
* More fixes
* More fixes to make it compile
* Adds `NoOffchainStorage`
* Pass the extensions
* Small basti making small progress
* Fix merge errors and remove `ExecutionContext`
* Move registration of `ReadRuntimeVersionExt` to `ExecutionExtension`
Instead of registering `ReadRuntimeVersionExt` in `sp-state-machine` it is moved to
`ExecutionExtension` which provides the default extensions.
* Fix compilation
* Register the global extensions inside runtime api instance
* Fixes
* Fix `generate_initial_session_keys` by passing the keystore extension
* Fix the grandpa tests
* Fix more tests
* Fix more tests
* Don't set any heap pages if there isn't an override
* Fix small fallout
* FMT
* Fix tests
* More tests
* Offchain worker custom extensions
* More fixes
* Make offchain tx pool creation reusable
Introduces an `OffchainTransactionPoolFactory` for creating offchain transactions pools that can be
registered in the runtime externalities context. This factory will be required for a later pr to
make the creation of offchain transaction pools easier.
* Fixes
* Fixes
* Set offchain transaction pool in BABE before using it in the runtime
* Add the `offchain_tx_pool` to Grandpa as well
* Fix the nodes
* Print some error when using the old warnings
* Fix merge issues
* Fix compilation
* Rename `babe_link`
* Rename to `offchain_tx_pool_factory`
* Cleanup
* FMT
* Fix benchmark name
* Fix `try-runtime`
* Remove `--execution` CLI args
* Make clippy happy
* Forward bls functions
* Fix docs
* Update UI tests
* Update client/api/src/execution_extensions.rs
Co-authored-by: Michal Kucharczyk <1728078+michalkucharczyk@users.noreply.github.com >
* Apply suggestions from code review
Co-authored-by: Koute <koute@users.noreply.github.com >
* Update client/cli/src/params/import_params.rs
Co-authored-by: Koute <koute@users.noreply.github.com >
* Update client/api/src/execution_extensions.rs
Co-authored-by: Koute <koute@users.noreply.github.com >
* Pass the offchain storage to the MMR RPC
* Update client/api/src/execution_extensions.rs
Co-authored-by: Sebastian Kunert <skunert49@gmail.com >
* Review comments
* Fixes
---------
Co-authored-by: Michal Kucharczyk <1728078+michalkucharczyk@users.noreply.github.com >
Co-authored-by: Koute <koute@users.noreply.github.com >
Co-authored-by: Sebastian Kunert <skunert49@gmail.com >
2023-07-11 14:21:38 +00:00
f5776f6897
Improve NFT locking ( #14510 )
...
* Update docs
* Prevent locking of the same NFT twice
* Validate item is not locked on burn
* Cover with tests
* chore
2023-07-05 09:17:08 +00:00
4abb6025e3
inspect role for nonfungibles_v2 ( #14341 )
...
* inspect role
* Update frame/nfts/src/impl_nonfungibles.rs
Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com >
* Update frame/support/src/traits/tokens/nonfungibles_v2.rs
Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com >
* Update as suggested
* Update frame/nfts/src/impl_nonfungibles.rs
Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com >
* Update frame/nfts/src/impl_nonfungibles.rs
Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com >
* Update frame/nfts/src/impl_nonfungibles.rs
Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com >
---------
Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com >
2023-06-22 12:07:23 +00:00
321a52bb27
Remove clippy workaround ( #14424 )
2023-06-21 12:06:09 +00:00
9d1741eb3c
Bump parity-scale-codec to 3.6.1 ( #14428 )
2023-06-21 11:37:11 +00:00
0aa79f87ca
".git/.scripts/commands/bench-vm/bench-vm.sh" all ( #13933 )
...
Co-authored-by: command-bot <>
2023-06-19 14:31:20 +01:00
d767d748d3
Use Incrementable from frame_support::traits ( #14367 )
...
* Use Incrementable from frame_support::traits
* Chore
2023-06-13 13:46:19 +00:00
3da9449067
Bump sp-crates from latest crates.io version + release ( #14265 )
...
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io >
2023-05-31 12:11:01 +00:00
50cf22b0bb
[NFTs] Add mint price to the witness object on mint and confirm it ( #14257 )
...
* Add mint price to the witness object on mint and confirm it
* Chore
* Put the new error to the bottom
* Update frame/nfts/src/lib.rs
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
---------
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
2023-05-29 16:59:43 +00:00
cb533ffa98
[NFTs] Add minting price to the pre-signed mint object ( #14242 )
...
* Add minting price to the pre-signed mint object
* Box the param
2023-05-29 11:00:00 +00:00
98a0550ea2
Release: Bump SP crates to release on crates.io ( #14237 )
...
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io >
2023-05-29 10:40:59 +00:00
05da6d8e84
HoldReason: Improve usage ( #13869 )
...
* HoldReason: Improve usage
`HoldReason` was switched recently to use the `composite_enum` attribute that will merge the enums
from all pallets in the runtime to `RuntimeHoldReason`. `pallet-nis` was still requiring that the
variant was passed as constant to call `hold`. The proper implementation is to use the `HoldReason`
from inside the pallet directly when calling `hold`. This is done by adding a `RuntimeHoldReason` as
type to the `Config` trait and requiring that `Currency` is using the same reason. Besides that the
pr changes the name `HoldIdentifier` in `pallet_balances::Config` to `RuntimeHoldReason`.
* Update frame/nis/src/lib.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Review comment
* Fixes
---------
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
2023-05-24 21:59:34 +00:00
41dbed0b90
NFTs fractionalization ( #12565 )
...
* Copy Uniques into Nfts
* Connect new pallet
* Update weights
* Nfts: Multiple approvals (#12178 )
* multiple approvals
* clear
* tests & clean up
* fix in logic & fmt
* fix benchmarks
* deadline
* test deadline
* current_block + deadline
* update ApprovedTransfer event
* benchmark
* docs
* Update frame/nfts/src/lib.rs
Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com >
* fmt fix
* Update frame/nfts/src/lib.rs
Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com >
* update tests
* anyone can cancel
* Update frame/nfts/src/tests.rs
Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com >
* fmt
* fix logic
* unnecessary line
* ".git/.scripts/bench-bot.sh" pallet dev pallet_nfts
* Update frame/nfts/src/lib.rs
* Update lib.rs
* fmt
* Update frame/nfts/src/lib.rs
Co-authored-by: Squirrel <gilescope@gmail.com >
* Update frame/nfts/src/lib.rs
Co-authored-by: Squirrel <gilescope@gmail.com >
* fmt
* Update frame/nfts/src/lib.rs
Co-authored-by: Squirrel <gilescope@gmail.com >
* suggestion
* new line
* ".git/.scripts/bench-bot.sh" pallet dev pallet_nfts
Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com >
Co-authored-by: command-bot <>
Co-authored-by: Squirrel <gilescope@gmail.com >
* Fixes
* cargo fmt
* Fixes
* Fixes
* Fix CI
* Nfts: Fix Auto-Increment (#12223 )
* commit
* passing benchmarks
* clean up
* sync
* runtime implementation
* fix
* fmt
* fix benchmark
* cfg
* remove try-increment-id
* remove unused error
* impl Incrementable for unsigned types
* clean up
* fix in tests
* not needed anymore
* Use OptionQuery
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
* Rename Origin to RuntimeOrigin
* [Uniques V2] Tips (#12168 )
* Allow to add tips when buying an NFT
* Chore
* Rework tips feature
* Add weights + benchmarks
* Convert tuple to struct
* Fix benchmark
* ".git/.scripts/bench-bot.sh" pallet dev pallet_nfts
* Update frame/nfts/src/benchmarking.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix benchmarks
* Revert the bounded_vec![] approach
* ".git/.scripts/bench-bot.sh" pallet dev pallet_nfts
Co-authored-by: command-bot <>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* [Uniques V2] Atomic NFTs swap (#12285 )
* Atomic NFTs swap
* Fmt
* Fix benchmark
* Rename swap -> atomic_swap
* Update target balance
* Rollback
* Fix
* ".git/.scripts/bench-bot.sh" pallet dev pallet_nfts
* Make desired item optional
* Apply suggestions
* Update frame/nfts/src/features/atomic_swap.rs
Co-authored-by: Squirrel <gilescope@gmail.com >
* Rename fields
* Optimisation
* Add a comment
* deadline -> maybe_deadline
* Add docs
* Change comments
* Add price direction field
* ".git/.scripts/bench-bot.sh" pallet dev pallet_nfts
* Wrap price and direction
* Fix benchmarks
* Use ensure! instead of if {}
* Make duration param mandatory and limit it to MaxDeadlineDuration
* Make the code safer
* Fix clippy
* Chore
* Remove unused vars
* try
* try 2
* try 3
Co-authored-by: command-bot <>
Co-authored-by: Squirrel <gilescope@gmail.com >
* [Uniques V2] Feature flags (#12367 )
* Basics
* WIP: change the data format
* Refactor
* Remove redundant new() method
* Rename settings
* Enable tests
* Chore
* Change params order
* Delete the config on collection removal
* Chore
* Remove redundant system features
* Rename force_item_status to force_collection_status
* Update node runtime
* Chore
* Remove thaw_collection
* Chore
* Connect collection.is_frozen to config
* Allow to lock the collection in a new way
* Move free_holding into settings
* Connect collection's metadata locker to feature flags
* DRY
* Chore
* Connect pallet level feature flags
* Prepare tests for the new changes
* Implement Item settings
* Allow to lock the metadata or attributes of an item
* Common -> Settings
* Extract settings related code to a separate file
* Move feature flag checks inside the do_* methods
* Split settings.rs into parts
* Extract repeated code into macro
* Extract macros into their own file
* Chore
* Fix traits
* Fix traits
* Test SystemFeatures
* Fix benchmarks
* Add missing benchmark
* Fix node/runtime/lib.rs
* ".git/.scripts/bench-bot.sh" pallet dev pallet_nfts
* Keep item's config on burn if it's not empty
* Fix the merge artifacts
* Fmt
* Add SystemFeature::NoSwaps check
* Rename SystemFeatures to PalletFeatures
* Rename errors
* Add docs
* Change error message
* Rework pallet features
* Move macros
* Change comments
* Fmt
* Refactor Incrementable
* Use pub(crate) for do_* functions
* Update comments
* Refactor freeze and lock functions
* Rework Collection config and Item confg api
* Chore
* Make clippy happy
* Chore
* Update comment
* RequiredDeposit => DepositRequired
* Address comments
Co-authored-by: command-bot <>
* [Uniques V2] Refactor roles (#12437 )
* Basics
* WIP: change the data format
* Refactor
* Remove redundant new() method
* Rename settings
* Enable tests
* Chore
* Change params order
* Delete the config on collection removal
* Chore
* Remove redundant system features
* Rename force_item_status to force_collection_status
* Update node runtime
* Chore
* Remove thaw_collection
* Chore
* Connect collection.is_frozen to config
* Allow to lock the collection in a new way
* Move free_holding into settings
* Connect collection's metadata locker to feature flags
* DRY
* Chore
* Connect pallet level feature flags
* Prepare tests for the new changes
* Implement Item settings
* Allow to lock the metadata or attributes of an item
* Common -> Settings
* Extract settings related code to a separate file
* Move feature flag checks inside the do_* methods
* Split settings.rs into parts
* Extract repeated code into macro
* Extract macros into their own file
* Chore
* Fix traits
* Fix traits
* Test SystemFeatures
* Fix benchmarks
* Add missing benchmark
* Fix node/runtime/lib.rs
* ".git/.scripts/bench-bot.sh" pallet dev pallet_nfts
* Keep item's config on burn if it's not empty
* Fix the merge artifacts
* Fmt
* Add SystemFeature::NoSwaps check
* Refactor roles structure
* Rename SystemFeatures to PalletFeatures
* Rename errors
* Add docs
* Change error message
* Rework pallet features
* Move macros
* Change comments
* Fmt
* Refactor Incrementable
* Use pub(crate) for do_* functions
* Update comments
* Refactor freeze and lock functions
* Rework Collection config and Item confg api
* Chore
* Make clippy happy
* Chore
* Fix artifacts
* Address comments
* Further refactoring
* Add comments
* Add tests for group_roles_by_account()
* Update frame/nfts/src/impl_nonfungibles.rs
* Add test
* Replace Itertools group_by with a custom implementation
* ItemsNotTransferable => ItemsNonTransferable
* Update frame/nfts/src/features/roles.rs
Co-authored-by: Muharem Ismailov <ismailov.m.h@gmail.com >
* Address PR comments
* Add missed comment
Co-authored-by: command-bot <>
Co-authored-by: Muharem Ismailov <ismailov.m.h@gmail.com >
* Fix copy
* Remove storage_prefix
* Remove transactional
* Initial commit SFT pallet.
* Update comment
* [Uniques V2] Minting options (#12483 )
* Basics
* WIP: change the data format
* Refactor
* Remove redundant new() method
* Rename settings
* Enable tests
* Chore
* Change params order
* Delete the config on collection removal
* Chore
* Remove redundant system features
* Rename force_item_status to force_collection_status
* Update node runtime
* Chore
* Remove thaw_collection
* Chore
* Connect collection.is_frozen to config
* Allow to lock the collection in a new way
* Move free_holding into settings
* Connect collection's metadata locker to feature flags
* DRY
* Chore
* Connect pallet level feature flags
* Prepare tests for the new changes
* Implement Item settings
* Allow to lock the metadata or attributes of an item
* Common -> Settings
* Extract settings related code to a separate file
* Move feature flag checks inside the do_* methods
* Split settings.rs into parts
* Extract repeated code into macro
* Extract macros into their own file
* Chore
* Fix traits
* Fix traits
* Test SystemFeatures
* Fix benchmarks
* Add missing benchmark
* Fix node/runtime/lib.rs
* ".git/.scripts/bench-bot.sh" pallet dev pallet_nfts
* Keep item's config on burn if it's not empty
* Fix the merge artifacts
* Fmt
* Add SystemFeature::NoSwaps check
* Rename SystemFeatures to PalletFeatures
* Rename errors
* Add docs
* Change error message
* Change the format of CollectionConfig to store more data
* Move max supply to the CollectionConfig and allow to change it
* Remove ItemConfig from the mint() function and use the one set in mint settings
* Add different mint options
* Allow to change the mint settings
* Add a force_mint() method
* Check mint params
* Some optimisations
* Cover with tests
* Remove merge artifacts
* Chore
* Use the new has_role() method
* Rework item deposits
* More tests
* Refactoring
* Address comments
* Refactor lock_collection()
* Update frame/nfts/src/types.rs
Co-authored-by: Squirrel <gilescope@gmail.com >
* Update frame/nfts/src/types.rs
Co-authored-by: Squirrel <gilescope@gmail.com >
* Update frame/nfts/src/lib.rs
Co-authored-by: Squirrel <gilescope@gmail.com >
* Update frame/nfts/src/lib.rs
Co-authored-by: Squirrel <gilescope@gmail.com >
* Private => Issuer
* Add more tests
* Fix benchmarks
* Add benchmarks for new methods
* [Uniques v2] Refactoring (#12570 )
* Move do_set_price() and do_buy_item() to buy_sell.rs
* Move approvals to feature file
* Move metadata to feature files
* Move the rest of methods to feature files
* Remove artifacts
* Split force_collection_status into 2 methods
* Fix benchmarks
* Fix benchmarks
* Update deps
Co-authored-by: command-bot <>
Co-authored-by: Squirrel <gilescope@gmail.com >
* Rename module to NFT fractionalisation
* Loose coupling for pallet-assets
* cargo fmt
* [Uniques V2] Smart attributes (#12702 )
* Basics
* WIP: change the data format
* Refactor
* Remove redundant new() method
* Rename settings
* Enable tests
* Chore
* Change params order
* Delete the config on collection removal
* Chore
* Remove redundant system features
* Rename force_item_status to force_collection_status
* Update node runtime
* Chore
* Remove thaw_collection
* Chore
* Connect collection.is_frozen to config
* Allow to lock the collection in a new way
* Move free_holding into settings
* Connect collection's metadata locker to feature flags
* DRY
* Chore
* Connect pallet level feature flags
* Prepare tests for the new changes
* Implement Item settings
* Allow to lock the metadata or attributes of an item
* Common -> Settings
* Extract settings related code to a separate file
* Move feature flag checks inside the do_* methods
* Split settings.rs into parts
* Extract repeated code into macro
* Extract macros into their own file
* Chore
* Fix traits
* Fix traits
* Test SystemFeatures
* Fix benchmarks
* Add missing benchmark
* Fix node/runtime/lib.rs
* ".git/.scripts/bench-bot.sh" pallet dev pallet_nfts
* Keep item's config on burn if it's not empty
* Fix the merge artifacts
* Fmt
* Add SystemFeature::NoSwaps check
* Rename SystemFeatures to PalletFeatures
* Rename errors
* Add docs
* Change error message
* Change the format of CollectionConfig to store more data
* Move max supply to the CollectionConfig and allow to change it
* Remove ItemConfig from the mint() function and use the one set in mint settings
* Add different mint options
* Allow to change the mint settings
* Add a force_mint() method
* Check mint params
* Some optimisations
* Cover with tests
* Remove merge artifacts
* Chore
* Use the new has_role() method
* Rework item deposits
* More tests
* Refactoring
* Address comments
* Refactor lock_collection()
* Update frame/nfts/src/types.rs
Co-authored-by: Squirrel <gilescope@gmail.com >
* Update frame/nfts/src/types.rs
Co-authored-by: Squirrel <gilescope@gmail.com >
* Update frame/nfts/src/lib.rs
Co-authored-by: Squirrel <gilescope@gmail.com >
* Update frame/nfts/src/lib.rs
Co-authored-by: Squirrel <gilescope@gmail.com >
* Private => Issuer
* Add more tests
* Fix benchmarks
* Add benchmarks for new methods
* [Uniques v2] Refactoring (#12570 )
* Move do_set_price() and do_buy_item() to buy_sell.rs
* Move approvals to feature file
* Move metadata to feature files
* Move the rest of methods to feature files
* Remove artifacts
* Smart attributes
* Split force_collection_status into 2 methods
* Fix benchmarks
* Fix benchmarks
* Update deps
* Fix merge artifact
* Weights + benchmarks + docs
* Change params order
* Chore
* Update frame/nfts/src/lib.rs
Co-authored-by: Squirrel <gilescope@gmail.com >
* Update frame/nfts/src/lib.rs
Co-authored-by: Squirrel <gilescope@gmail.com >
* Update docs
* Update frame/nfts/src/lib.rs
Co-authored-by: Squirrel <gilescope@gmail.com >
* Add PalletId
* Chore
* Add tests
* More tests
* Add doc
* Update errors snapshots
* Ensure we track the owner_deposit field correctly
Co-authored-by: command-bot <>
Co-authored-by: Squirrel <gilescope@gmail.com >
* [Uniques V2] Final improvements (#12736 )
* Use KeyPrefixIterator instead of Box
* Change create_collection()
* Restrict from claiming NFTs twice
* Update Readme
* Remove dead code
* Refactoring
* Update readme
* Fix clippy
* Update frame/nfts/src/lib.rs
Co-authored-by: Squirrel <gilescope@gmail.com >
* ".git/.scripts/bench-bot.sh" pallet dev pallet_nfts
* Update docs
* Typo
* Fix benchmarks
* Add more docs
* Replace uniques with nfts, add minted volume storage
* DepositRequired setting should affect only the attributes within the CollectionOwner namespace
* Add unlock functionality
* [NFTs] Implement missed methods to set the attributes from other pallets (#12919 )
* Implement missed methods to set the attributes from other pallets
* Revert snapshots
* Update snapshot
* Update snapshot
* Revert snapshot changes
* Update snapshots
* Yet another snapshot update..
* Asset to NFT id storage mutations
* Minor fixes
* Minor comments
* cargo fmt
* Remove benchmarking, unused clone()
* Update frame/support/src/traits/tokens/nonfungible_v2.rs
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
* Update frame/support/src/traits/tokens/nonfungible_v2.rs
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
* Update frame/support/src/traits/tokens/nonfungible_v2.rs
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
* Update frame/support/src/traits/tokens/nonfungibles_v2.rs
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
* Update frame/nfts/src/lib.rs
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
* Update frame/nfts/src/lib.rs
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
* Update frame/nfts/src/lib.rs
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
* Update frame/nfts/src/lib.rs
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
* Update frame/nfts/src/lib.rs
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
* Update frame/support/src/traits/tokens/nonfungible_v2.rs
* Update frame/nfts/src/lib.rs
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
* Update frame/support/src/traits/tokens/nonfungibles_v2.rs
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
* Update frame/nfts/src/lib.rs
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
* Update frame/nfts/src/lib.rs
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
* Update frame/nfts/src/lib.rs
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
* Update frame/nfts/src/lib.rs
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
* Address comments
* [NFTs] Add the new `owner` param to mint() method (#12997 )
* Add the new `owner` param to mint() method
* Fmt
* Address comments
* ".git/.scripts/bench-bot.sh" pallet dev pallet_nfts
* Fmt
* Update frame/nfts/src/common_functions.rs
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
* Update frame/nfts/src/types.rs
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
* Update frame/nfts/src/types.rs
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
* Update frame/nfts/src/types.rs
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
* Update frame/nfts/src/types.rs
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
* Update frame/nfts/src/types.rs
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
* Add call indexes
* Update snapshots
* Refactor nft fractionalisation pallet (#13008 )
* Refactoring
* Make it compile
* Add tests
* Rename
* Rework nfts locking
* Update cargo.lock
* Connect the latest changes to the runtime-kitchensink
* Add benchmarks, fix other issues
* Chore
* Chore 2
* Chore 3
* Add runtime-benchmarks
* Rename
* Set metadata
* Make fields public
* Chore
* Created asset shouldn't be sufficient
* Add documentation
* minor edit to docs
* Minor corrections
Co-authored-by: lana-shanghai <svetlana.konstantinovna@gmail.com >
* fmt
* Add fee reserved before creating an asset
* Use ReservableCurrency for fee deposit
* Improvements
* Revert fmt changes
* A bit more cleanup
* Consistent naming
* Make it more generic
* Leftover
* Use Vec<u8> instead of String
* Update to the latest + improve the Locker trait
* Refactor NFTs locker
* Replace Vec with BoundedVec, add clearer errors
* cargo fmt
* Add README about unlocking NFTs
* add constant definition
* add fortitude & precision to asset related functions
* fix mock and tests
* transfer ExistentialDeposit to pallet if it's balance is below
* Refactoring
* Simplify the locking mechanism
* Use PalletAttributes enum instead of the LOCKED_NFT_KEY
* Fix benchmark
* Add missing licence details
* Update Cargo.toml
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_nft_fractionalization
* Apply suggestions from code review
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
* Update frame/nft-fractionalization/README.md
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
---------
Co-authored-by: Jegor Sidorenko <jegor@parity.io >
Co-authored-by: Sergej Sakac <73715684+Szegoo@users.noreply.github.com >
Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com >
Co-authored-by: Squirrel <gilescope@gmail.com >
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: Muharem Ismailov <ismailov.m.h@gmail.com >
Co-authored-by: command-bot <>
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
2023-05-23 07:17:48 +00:00
df87bae1a9
BREAKING - Try-runtime: Use proper error types ( #13993 )
...
* Try-state: DispatchResult as return type
* try_state for the rest of the pallets
* pre_upgrade
* post_upgrade
* try_runtime_upgrade
* fixes
* bags-list fix
* fix
* update test
* warning fix
* ...
* final fixes 🤞
* warning..
* frame-support
* warnings
* Update frame/staking/src/migrations.rs
Co-authored-by: Liam Aharon <liam.aharon@hotmail.com >
* fix
* fix warning
* nit fix
* merge fixes
* small fix
* should be good now
* missed these ones
* introduce TryRuntimeError and TryRuntimeResult
* fixes
* fix
* removed TryRuntimeResult & made some fixes
* fix testsg
* tests passing
* unnecessary imports
* Update frame/assets/src/migration.rs
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
---------
Co-authored-by: Liam Aharon <liam.aharon@hotmail.com >
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
2023-05-23 06:56:10 +00:00
801871afa1
Bump enumflags2 from 0.7.5 to 0.7.7 ( #13995 )
...
Bumps [enumflags2](https://github.com/meithecatte/enumflags2 ) from 0.7.5 to 0.7.7.
- [Release notes](https://github.com/meithecatte/enumflags2/releases )
- [Commits](https://github.com/meithecatte/enumflags2/compare/v0.7.5...v0.7.7 )
---
updated-dependencies:
- dependency-name: enumflags2
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-04-24 21:31:13 +02:00
7a1fc72a4a
[NFTs] Improve offchain signature validation ( #13960 )
...
* Improve signature validation
* Rework
2023-04-20 12:38:45 +00:00
ebfe00d590
Fixes PoV over-estimation ( #13766 )
...
* Align log
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Use max instead of sum
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Make comment ordering deterministic
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Dont add Pov overhead when all is ignored
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update test pallet weights
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Re-run weights on bm2
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix test
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Actually use new weights
Fucked up the merge for this file...
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update contract weights
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
---------
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
2023-04-13 13:11:58 +00:00
b83bf4784e
Globally upgrade to syn 2.x and latest quote and proc_macro2 1x versions ( #13846 )
...
* globally upgrade quote to latest 1.0.x (1.0.26)
* globally upgrade syn to final 1.0.x version (1.0.109)
* globally upgrade proc-macro2 to 1.0.56
* upgrade to syn v2.0.13 and fix everything except NestedMeta
* fix parse nested metadata code in decl_runtime_apis.rs
* Port more stuff to syn 2.0
* Make the rest compile
* Ignore error
* update to syn 2.0.14
---------
Co-authored-by: Bastian Köcher <info@kchr.de >
2023-04-12 18:42:22 +00:00
376a288fb6
[Deps] Bump scale-info to match cumulus and polkadot ( #13873 )
...
* [Deps] Bump scale-info to match cumulus and polkadot
* fix Cargo.lock
* fix identity
* more fixes
* fix
* fixes
* more fixes
2023-04-12 14:14:06 +02:00
480396fe06
Keystore overhaul (iter 2) ( #13634 )
...
* Remove bloat about remote keystore
* Update docs and remove unused 'KeystoreRef' trait
* Use wherever possible, MemoryKeystore for testing
* Remove unrequired fully qualified method syntax for Keystore
2023-03-20 18:21:26 +00:00
5d81f23f8f
Deprecate Currency; introduce holds and freezing into fungible traits ( #12951 )
...
* First reworking of fungibles API
* New API and docs
* More fungible::* API improvements
* New ref-counting logic for old API
* Missing files
* Fixes
* Use the new transfer logic
* Use fungibles for the dispatchables
* Use shelve/restore names
* Locking works with total balance.
* repotting and removal
* Separate Holds from Reserves
* Introduce freezes
* Missing files
* Tests for freezing
* Fix hold+freeze combo
* More tests
* Fee-free dispatchable for upgrading accounts
* Benchmarks and a few fixes
* Another test
* Docs and refactor to avoid blanket impls
* Repot
* Fit out ItemOf fully
* Add events to Balanced traits
* Introduced events into Hold traits
* Fix Assets pallet tests
* Assets benchmarks pass
* Missing files and fixes
* Fixes
* Fixes
* Benchmarks fixes
* Fix balance benchmarks
* Formatting
* Expose fungible sub modules
* Move NIS to fungible API
* Fix broken impl and add test
* Fix tests
* API for `transfer_and_hold`
* Use composite APIs
* Formatting
* Upgraded event
* Fixes
* Fixes
* Fixes
* Fixes
* Repot tests and some fixed
* Fix some bits
* Fix dust tests
* Rename `set_balance`
- `Balances::set_balance` becomes `Balances::force_set_balance`
- `Unbalanced::set_balance` becomes `Unbalances::write_balance`
* becomes
* Move dust handling to fungibles API
* Formatting
* Fixes and more refactoring
* Fixes
* Fixes
* Fixes
* Fixes
* Fixes
* Fixes
* Fixes
* Fixes
* Fixes
* Use reducible_balance for better correctness on fees
* Reducing hold to zero should remove entry.
* Add test
* Docs
* Update frame/support/src/traits/tokens/fungibles/hold.rs
Co-authored-by: Muharem Ismailov <ismailov.m.h@gmail.com >
* Update frame/support/src/traits/tokens/fungibles/regular.rs
Co-authored-by: Muharem Ismailov <ismailov.m.h@gmail.com >
* Update frame/support/src/traits/tokens/fungible/hold.rs
Co-authored-by: Muharem Ismailov <ismailov.m.h@gmail.com >
* Update frame/support/src/traits/tokens/fungible/regular.rs
Co-authored-by: Muharem Ismailov <ismailov.m.h@gmail.com >
* Docs
* Docs
* Docs
* Fix NIS benchmarks
* Doc comment
* Remove post_mutation
* Fix some tests
* Fix some grumbles
* Enumify bool args to fungible(s) functions
* Fix up assets and balances
* Formatting
* Fix contracts
* Fix tests & benchmarks build
* Typify minted boolean arg
* Typify on_hold boolean arg; renames
* Fix numerous tests
* Fix dependency issue
* Privatize dangerous API mutate_account
* Fix contracts (@alext - please check this commit)
* Remove println
* Fix tests for contracts
* Fix broken rename
* Fix broken rename
* Fix broken rename
* Docs
* Update frame/support/src/traits/tokens/fungible/hold.rs
Co-authored-by: Anthony Alaribe <anthonyalaribe@gmail.com >
* remove from_ref_time
* Update frame/executive/src/lib.rs
Co-authored-by: Anthony Alaribe <anthonyalaribe@gmail.com >
* Update frame/executive/src/lib.rs
Co-authored-by: Anthony Alaribe <anthonyalaribe@gmail.com >
* Reenable test
* Update frame/support/src/traits/tokens/fungibles/hold.rs
Co-authored-by: Anthony Alaribe <anthonyalaribe@gmail.com >
* Update frame/support/src/traits/tokens/fungible/hold.rs
Co-authored-by: Anthony Alaribe <anthonyalaribe@gmail.com >
* Update frame/support/src/traits/tokens/fungible/hold.rs
Co-authored-by: Anthony Alaribe <anthonyalaribe@gmail.com >
* Update frame/support/src/traits/tokens/fungible/hold.rs
Co-authored-by: Anthony Alaribe <anthonyalaribe@gmail.com >
* Update frame/support/src/traits/tokens/currency.rs
Co-authored-by: Anthony Alaribe <anthonyalaribe@gmail.com >
* Update frame/lottery/src/tests.rs
Co-authored-by: Anthony Alaribe <anthonyalaribe@gmail.com >
* Update frame/support/src/traits/tokens/fungible/mod.rs
Co-authored-by: Anthony Alaribe <anthonyalaribe@gmail.com >
* Update frame/support/src/traits/tokens/fungible/regular.rs
Co-authored-by: Anthony Alaribe <anthonyalaribe@gmail.com >
* Update frame/support/src/traits/tokens/fungibles/freeze.rs
Co-authored-by: Anthony Alaribe <anthonyalaribe@gmail.com >
* Update frame/support/src/traits/tokens/fungible/regular.rs
Co-authored-by: Anthony Alaribe <anthonyalaribe@gmail.com >
* Update frame/support/src/traits/tokens/fungibles/hold.rs
Co-authored-by: Anthony Alaribe <anthonyalaribe@gmail.com >
* Update frame/support/src/traits/tokens/fungibles/hold.rs
Co-authored-by: Anthony Alaribe <anthonyalaribe@gmail.com >
* Update frame/support/src/traits/tokens/fungibles/hold.rs
Co-authored-by: Anthony Alaribe <anthonyalaribe@gmail.com >
* Rename UnwantedRemoval to UnwantedAccountRemoval
* Docs
* Formatting
* Update frame/balances/src/lib.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update primitives/runtime/src/lib.rs
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
* handle_raw_dust oes nothing
* Formatting
* Fixes
* Grumble
* Fixes
* Add test
* Add test
* Tests for reducible_balance
* Fixes
* Fix Salary
* Fixes
* Disable broken test
* Disable nicely
* Fixes
* Fixes
* Fixes
* Rename some events
* Fix nomination pools breakage
* Add compatibility stub for transfer tx
* Reinstate a safely compatible version of Balances set_balance
* Fixes
* Grumble
* Update frame/nis/src/lib.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_balances
* disable flakey tests
* Update frame/balances/src/lib.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* Grumbles
* Grumble
---------
Co-authored-by: Muharem Ismailov <ismailov.m.h@gmail.com >
Co-authored-by: Alexander Theißen <alex.theissen@me.com >
Co-authored-by: Anthony Alaribe <anthonyalaribe@gmail.com >
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
Co-authored-by: command-bot <>
2023-03-18 14:47:55 +00:00
f110941b7f
Keystore overhaul ( #13615 )
...
* Remove 'supported_keys' 'sign_with_any' and 'sign_with_all' from keystore trait
* Remove the aync keystore
* Renaming:
- SyncCryptoStore -> Keystore
- SyncCryptoStorePtr -> KeystorePtr
- KeyStore -> MemoryKeystore
* Fix authority discovery worker and tests
* Rename 'insert_unknown' to 'insert'
* Remove leftover
2023-03-17 11:24:14 +00:00
3a3d93afee
Update all weights ( #13614 )
...
* Empty commit
* ".git/.scripts/commands/bench/bench.sh" all
---------
Co-authored-by: Alexander Theißen <alex.theissen@me.com >
Co-authored-by: command-bot <>
2023-03-16 17:57:45 +01:00
Squirrel