Vivek Pandya
bc53b9a03a
Remove years from copyright notes. ( #13415 )
...
* Change copyright year to 2023 from 2022
* Fix incorrect update of copyright year
* Remove years from copy right header
* Fix remaining files
* Fix typo in a header and remove update-copyright.sh
2023-02-21 18:46:41 +00:00
Michal Kucharczyk
548955a73f
BlockId removal: refactor: HeaderBackend::header (#12874 )
...
* BlockId removal: refactor: HeaderBackend::header
It changes the arguments of:
- `HeaderBackend::header`,
- `Client::header`,
- `PeersClient::header`
- `ChainApi::block_header`
methods from: `BlockId<Block>` to: `Block::Hash`
This PR is part of BlockId::Number refactoring analysis (paritytech/substrate#11292 )
* non-trivial usages of haeder(block_id) refactored
This may required introduction of dedicated function:
header_for_block_num
* fmt
* fix
* doc fixed
* ".git/.scripts/fmt.sh"
* BlockId removal: refactor: HeaderBackend::expect_header
It changes the arguments of `HeaderBackend::expect_header` method from: `BlockId<Block>` to: `Block::Hash`
* ".git/.scripts/fmt.sh"
* readme updated
* ".git/.scripts/fmt.sh"
* fix
Co-authored-by: parity-processbot <>
2022-12-20 09:43:31 +00:00
Michal Kucharczyk
1ed70004e7
BlockId removal: &Hash to Hash ( #12626 )
...
It changes &Block::Hash argument to Block::Hash.
This PR is part of BlockId::Number refactoring analysis (paritytech/substrate#11292 )
2022-11-07 21:42:16 +00:00
Michal Kucharczyk
76bcbd09a5
BlockId removal: refactor: Backend::body ( #12587 )
...
It changes the arguments of `Backend::body` method from: `BlockId<Block>` to: `&Block::Hash`
This PR is part of BlockId::Number refactoring analysis (paritytech/substrate#11292 )
Co-authored-by: parity-processbot <>
2022-11-01 16:24:09 +00:00
Michal Kucharczyk
62bca87f3a
Finalized block event triggers tx maintanance ( #12305 )
...
* finalized block event triggers tx maintanance
* tx-pool: enactment helper introduced
* tx-pool: ChainApi: added tree_route method
* enactment logic implemented + tests
Signed-off-by: Michal Kucharczyk <1728078+michalkucharczyk@users.noreply.github.com >
* Some additional tests
* minor improvements
* trigger CI job
* fix compilation errors
ChainApi::tree_route return type changed to Result<Option<..>>, as some
implementations (tests) are not required to provide this tree route.
* formatting
* trait removed
* implementation slightly simplified
(thanks to @koute)
* get rid of Arc<> in EnactmentState return value
* minor improvement
* Apply suggestions from code review
Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com >
* Apply suggestions from code review
* comment updated + formatting
* Apply suggestions from code review
Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com >
Co-authored-by: Davide Galassi <davxy@datawok.net >
* formatting
* finalization notification bug fix
+ new test case
+ log::warn message when finalized block is being retracted by new event
* added error message on tree_route failure
* Apply suggestions from code review
Co-authored-by: Bastian Köcher <git@kchr.de >
* use provided tree_route in Finalized event
* Option removed from ChainApi::tree_route
* doc added, test and logs improved
* handle_enactment aligned with original implementation
* use async-await
* Apply suggestions from code review
Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com >
* Apply suggestions from code review
Co-authored-by: Bastian Köcher <git@kchr.de >
* formatting + warn->debug
* compilation error fix
* enactment_state initializers added
* enactment_state: Option removed
* manual-seal: compilation & tests fix
* manual-seal: tests fixed
* tests cleanup
* another compilation error fixed
* TreeRoute::new added
* get rid of pub hack
* one more test added
* formatting
* TreeRoute::new doc added + formatting
* Apply suggestions from code review
Co-authored-by: Davide Galassi <davxy@datawok.net >
* (bool,Option) simplified to Option
* log message improved
* yet another review suggestions applied
* get rid of hash in handle_enactment
* Apply suggestions from code review
Co-authored-by: Bastian Köcher <git@kchr.de >
* Update client/transaction-pool/src/lib.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* minor corrections
* EnactmentState moved to new file
* File header corrected
* error formatting aligned with codebase
* Apply suggestions from code review
Co-authored-by: Bastian Köcher <git@kchr.de >
* remove commented code
* small nits
Signed-off-by: Michal Kucharczyk <1728078+michalkucharczyk@users.noreply.github.com >
Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com >
Co-authored-by: Davide Galassi <davxy@datawok.net >
Co-authored-by: Bastian Köcher <git@kchr.de >
Co-authored-by: André Silva <andrerfosilva@gmail.com >
2022-10-11 20:20:13 +00:00
Squirrel
a68a80fbae
declone and close the door ( #12035 )
...
* declone and close the door
* cargo fmt
* remove brackets
2022-08-15 19:38:36 +00:00
Bastian Köcher
424ddf33ee
Remove transaction-pool test-helpers feature ( #10571 )
...
* Remove transaction-pool `test-helpers` feature
`test-helpers` feature is a bad idea in general, because once the feature is enabled somewhere in
the workspace, it is enabled anywhere. While removing the feature, the tests were also rewritten to
get rid off other "only test" related code.
Contributes towards: https://github.com/paritytech/substrate/issues/9727
* Apply suggestions from code review
Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com >
* Fix benches
Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com >
2022-01-03 15:08:42 +00:00
Bastian Köcher
f3662b4bba
Happy new year 2022 ( #10573 )
2022-01-03 09:22:14 +01:00
Gavin Wood
1e24e45ea1
Remove Default bound for AccountId ( #10403 )
...
* Remove Default for AccountId
* More removals of default
* Update frame/authorship/src/lib.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Update frame/authorship/src/lib.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Update frame/authorship/src/lib.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Update frame/authorship/src/lib.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* More work
* More work
* Remove old code
* More work
* pallet-asset-tx-payment
* tips
* sc-consensus-babe
* sc-finality-grandpa
* sc-consensus-babe-rpc
* sc-cli
* make npos crates accept non-default account (#10420 )
* minimal changes to make npos pallets all work
* make this pesky reduce.rs a bit cleaner
* more work
* more work
* Tests build
* Fix imonline tests
* Formatting
* Fixes
* Fixes
* Fix bench
* Fixes
* Fixes
* Fixes
* Fixes
* Fixes
* Formatting
* Fixes
* Formatting
* Fixes
* Formatting
* Fixes
* Formatting
* Fixes
* Formatting
* Update client/keystore/src/local.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/finality-grandpa/src/lib.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/keystore/src/local.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/keystore/src/local.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Update frame/staking/src/lib.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Update frame/staking/src/lib.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Update primitives/runtime/src/traits.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Formatting
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
Co-authored-by: kianenigma <kian@parity.io >
2021-12-13 15:03:59 +01:00
Bastian Köcher
7b56ab15b4
Run cargo fmt on the whole code base ( #9394 )
...
* Run cargo fmt on the whole code base
* Second run
* Add CI check
* Fix compilation
* More unnecessary braces
* Handle weights
* Use --all
* Use correct attributes...
* Fix UI tests
* AHHHHHHHHH
* 🤦
* Docs
* Fix compilation
* 🤷
* Please stop
* 🤦 x 2
* More
* make rustfmt.toml consistent with polkadot
Co-authored-by: André Silva <andrerfosilva@gmail.com >
2021-07-21 14:32:32 +00:00
Seun Lanlege
2ae9d36758
sc-transcation-pool refactor ( #9228 )
...
* Use TransactionPool trait
* sc-transaction-pool-primitives
* sc-transaction-pool-api
* TP
* bye sc_transaction_graph
* fix line widths
* fix import errors
* fix import errors
* fix import errors 🤦🏾♂️
* fix import errors 🤦🏾♂️ 🤦🏾♂️ 🤦🏾♂️
* remove sp-keyring
2021-07-08 13:33:34 +00:00