e75ad88ae8
Add support for wasm runtime metrics try #2 ( #4483 )
...
* Add runtime metrics provider
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Runner changes
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Some sample metrics in paras_inherent
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* update cargo toml
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* fmt
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* bug
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* more fmt after merge
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Refactor metric prefix override
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* fmt
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* remove bug comment
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Add runtime metric primitives
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Impl trace event parsing
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Update metrics
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* cargo lock
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* fmt
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Fix target check
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Runtime metrics primitives
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Review feedback
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Runtime metrics crate
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Node side runtime metric changes
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* use runtime CounterVec instead of macro
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* fmt nice
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* remove dead code
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* base58 decoding
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* base58 encoding
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* fix warn
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* typo
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Review feedback
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Finish label support
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* fmt
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* please compile
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* add feature gate
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* fmt
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Comment cargo toml
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Fix cargo toml description
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Update doc.
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* switch to `runtime-metrics` feature
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* fmt
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* cargo toml
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* fix tests
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* fixes
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* better ux
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* from_utf8_unchecked is safe
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* fmt
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Add Counter and refactor
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Fixes
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* review fixes
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* more fixes
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* add integration test
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* dev deps
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* gitlab script update
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* review fixes
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* fix merge damage
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Run tests twice
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* small fix
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* typo
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* cargo lock
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* tests
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* spellcheck happy ?
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* more fixes
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Guard tracing init
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* missing copyright
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* update lockfile for substrate
Co-authored-by: parity-processbot <>
2021-12-16 11:56:25 +00:00
ca72ad636c
Companion #10403 : Remove Default for AccountId ( #4500 )
...
* Some work
* Fixes
* Tests builds
* Fixes
* Fixes
* Fixes
* Fixes
* Fixes
* Formatting
* Formatting
* Fix
* Fixes
* Fixes
* Fixes
* Fixes
* Update Cargo.lock
* Bump
* Fixes
2021-12-14 08:17:26 +01:00
39310088b0
Run paras inherent benchmarks ( #4454 )
...
* Some new lines
* cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras_inherent --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/runtime_parachains_paras_inherent.rs
* cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras_inherent --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/runtime_parachains_paras_inherent.rs
* cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=polkadot-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras_inherent --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/runtime_parachains_paras_inherent.rs
Co-authored-by: Parity Bot <admin@parity.io >
2021-12-06 20:12:12 +00:00
4adb8466a3
dev-comment spelling mistakes ( #4434 )
2021-12-06 15:20:29 +01:00
854d92a4a4
Assure backed candidates are sorted after sanitization ( #4422 )
2021-12-05 10:43:56 +00:00
89ccd18ccb
Add parent header hash to log ( #4421 )
...
* Add parent header hash to log
* add :
2021-12-02 13:31:57 +00:00
df19d3faa8
Improve paras runtime BenchBuilder api ( #4318 )
...
* Improve paras runtime `BenchBuilder` api
* fix
* Improve doc comment
* Some doc improvemens'
* Use setters and no params for build
* +nightly-2021-10-29 fmt
* Clean up some comments
* Simplify set_code_upgrade
* Accept a slice for set_dispute_sessions
* Doc comments
* Spelling
* use impl AsRef
* Prepare for merge
* fmt
Co-authored-by: Bernhard Schuster <bernhard@ahoi.io >
2021-12-02 03:32:43 +00:00
bb93a99710
separate parachains runtime tests ( #4419 )
2021-12-01 12:51:57 +01:00
90e1273462
Inherent filtering follow up ( #4305 )
...
* Add feature more feature gating for benchmarking + tests
* New line
* cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras_inherent --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/runtime_parachains_paras_inherent.rs
* cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=polkadot-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras_inherent --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/runtime_parachains_paras_inherent.rs
* Do not assume we use max validators per core
* Use kusama weights for rococo (hopefully temp)
* cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras_inherent --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/runtime_parachains_paras_inherent.rs
* Add more validity votes when neccesary
* Some fixes for the last commit
* Restore westend weights
* cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras_inherent --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/runtime_parachains_paras_inherent.rs
* Revert bad westend weights write
* Make sure to update val idx before skipping
* Fix validity vote range to max at group size'
* Temp setup for rococo
* cargo run --quiet --release --features runtime-benchmarks -- benchmark --chain=rococo-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras_inherent --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtime/rococo/src/weights/runtime_parachains_paras_inherent.rs --header=./file_header.txt
* Augment generated Rococo weights
* Make it compile
* Revert range for enter_backed_candidates_variable
* Delete runtime/kusama/src/weights/runtime_paras_paras_inherent.rs
Co-authored-by: Parity Bot <admin@parity.io >
2021-11-23 23:46:37 +00:00
1aa6a4aba4
move paras inherent filtering to runtime ( #4028 )
...
* move things around, add filter methods
* validator keys, modify availability bitfields according to disputes
* simplify, keep the filter -> sanitize generic for both usecases
* minor
* assure tests still work, reduce changeset
* integration
* start entropy passing
* fixins
* compile, 1 failing test
* filter with coverage
* fixins
* Update runtime/parachains/src/paras_inherent.rs
Co-authored-by: Robert Habermeier <rphmeier@gmail.com >
* slip of the pen
* improve test cases
* misc
* fix
* fixins
* test avoid extra into() calls in assert_noop!
* chores
* ff
* test fixup superfluous into call
* chore: pfmt
* improve apply_block_weight_limit to try to maximize the number of sufficiently backed
blocks and add extra bitfields in a round-robin fashion
* new code treats the lack of backed candidates as ok
* Use vrf based entropy
* fixup vrf random
* add warn
* slip of the pen
* fixup
* assure ordering
* rethink apply_weights
* mock
* use a closure as predicate check
* extract and use DisputedBitfield
* chore: simplify
* remove stray dbg
* chore: fmt
* address feedback
* fix test, halfway there
* stage1
* dbg stuff
* make group selection align
* fix session index
* fix wrongly returned candidates
* cleanup
* chore fmt
* fix ensure check
* make good case test work
* more tests for bitfields
* create sanitize_backed_candidates
* fixup tests
* update guide
* add check referenced in the guide
* improve weights code
* fmt
* fixins
* Update roadmap/implementers-guide/src/runtime/inclusion.md
Co-authored-by: Zeke Mostov <32168567+emostov@users.noreply.github.com >
* compiling + address review
* add comments
* fix weight calc
* address review comments and test failure
* fix
* fix: condition
* Fix random_sel function
* Fix overlength block check
* Zeke + Ladi commit for disputes filtering + integration test builder + runtime benchmarks + integration tests
* Add benchmarks for code upgrades
* Code upgrade bench; Feature gate TestWeightInfo
* Try and make CI happier
* Feature gate enter test to not(benchmarks)
* Make sure no unused imports/fn
* refactor, re-use, the beginning
* Fix issue with frame benchmarking dep compilation
* More precise feature gating for some derives
* integrate piece-wise
* foo
* fixins
* chore fmt
* fixins
* rename const generic
* Update runtime/parachains/src/paras_inherent.rs
Co-authored-by: Zeke Mostov <z.mostov@gmail.com >
* Fix compilation
* limit to test
* remove unused spam slots
* spellcheck
* remove a tick, fix a typo
* Add Code upgrade weights
* comment improvements + >=
Co-authored-by: Zeke Mostov <z.mostov@gmail.com >
* remove another tick
* Update runtime/parachains/src/paras_inherent/benchmarking.rs
Co-authored-by: Zeke Mostov <z.mostov@gmail.com >
* saturating fixins + some spaces
* fix
* benchmarking - preliminary results
* Add training wheels
* Refactor some early exit logic for enter
* Gracefully handle filtering bitfields & candidates (#4280 )
This updates the logic for sanitize_bitfields and sanitize_backed_candidates to never error when there is an issue, but instead to simply skip the problematic items.
* Refactor inherent data weight limiting logic (#4287 )
* Apply suggestions from code review
* Update runtime/parachains/src/builder.rs
Co-authored-by: Zeke Mostov <z.mostov@gmail.com >
* Update runtime/parachains/src/builder.rs
* Update runtime/parachains/src/paras_inherent.rs
* final pass
* Run cargo +nightly-2021-10-29 fmt
* Update implementors guide with `sanitize_*` & `enter` (#4294 )
* Make spell check happier
* Make wasm runtimes compile with benchmarks enabled (#4303 )
* comment stuff out, use old toml
* Seems to be working?
* Remove feature gating from builder
* Remove commented out stuff
* Remove generic from digest
* Update weight files for runtime
Co-authored-by: Robert Habermeier <rphmeier@gmail.com >
Co-authored-by: Zeke Mostov <32168567+emostov@users.noreply.github.com >
Co-authored-by: Lldenaurois <Ljdenaurois@gmail.com >
Co-authored-by: Zeke Mostov <z.mostov@gmail.com >
Co-authored-by: Bastian Köcher <info@kchr.de >
2021-11-16 18:39:39 +00:00
sandreim