* Bump Substrate to version used by Polkadot (`5f056830`)
* Use `log` crate for runtime logging
See https://github.com/paritytech/substrate/pull/8128/ for more info.
* Stop using return value from `execute_block`
* Update test weight
* Add skeleton for `pallet-finality-verifier`
* Sketch out implementation for importing finality proofs
* Get pallet compiling
* Introduce skeleton for mock runtime
* Start using real Grandpa types in finality pallet
* Redefine types in header chain primitives crate
* Implement HeaderChain for Substrate bridge pallet
* Plug Substrate Bridge Pallet into verifier mock
* Fix compilation of `header-chain` primitives
* Start writing to base pallet storage
* Add first "cross-pallet" test
* Move keyring primitives used in tests to shared crate
* Stop pulling `std` deps into `no_std` builds
* Revert "Stop pulling `std` deps into `no_std` builds"
This reverts commit f74dd660652f98b7336936d1534a4e63cc9169a5.
* Revert "Move keyring primitives used in tests to shared crate"
This reverts commit b774fa730b2cdc40545afff308a66b0840266001.
* Use new SS58Prefix type in mock
* Start using `bp-test-utils` in finality pallet
* Start using real justification code
* Get a test working with real justification verification
* Add basic tests for invalid proofs
* Get rid of AncestryProof config type
* Add error types to transaction outcome
* Bound number of headers allowed in a single ancestry proof
* Disallow invalid authority sets
* Remove unused items
* Add some documentation
* Get rid of Clippy warnings
* Rename BaseHeaderChain to TransactionVerifier
* Remove unused code
* Make dummy trait implementations more generic
* Fix more Clippy complaints
* Update tests to use fix for duplicate headers
* Fix benchmarking compilation
* Rename TransactionVerifier to InclusionProofVerifier
* Move justification module to header-chain primitives crate
* Get justification module compiling in new location
* Get justification module tests compiling
* Use justification code from `header-chain` crate
Mostly compiles, having issues with std/test feature flags across crates.
* Move some code around
* Move justification tests to integration testing crate
* Add `test-utils` crate
* Remove tests and test-helper module from justification code
* Use `test-utils` in Substrate bridge pallet tests
* Remove `sp-keyring` related code from `pallet-substrate-bridge`
* Remove `helpers` module from `pallet-substrate-bridge`
* Add some documentation
* Add more documentation
* Fix typo
Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
* Remove the Substrate primitives crate
The types here were only used in one place, the pallet itself. If other
components start using these types we can considering moving them back
into a standalone crate.
* Start trying to integrate justification module
* Make Substrate blocks configurable in Pallet
* WIP: Try and generalize justification test helpers
* Fix tests which use "real" justifications
* Put common test helpers alongside mock code
* Use common helper for creating headers
* Remove usage of UintAuthorityId
This change favours the use of the Ed25519Keyring authorities
in order to keep things consistent with the tests.
* Add documentation around config trait types
* Make test header, hash, and number types consistent
* Update modules/substrate/src/verifier.rs
Co-authored-by: Svyatoslav Nikolsky <svyatonik@gmail.com>
* Update modules/substrate/src/lib.rs
Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
* Update modules/substrate/Cargo.toml
Co-authored-by: Svyatoslav Nikolsky <svyatonik@gmail.com>
* Derive `RuntimeDebug` instead of `Debug`
* Add `Paramter` as a trait constraint on config types
Since we use these types as part of the dispatchable functions
we should explicitly require this.
* Enforce that hasher output matches expected hash type
* Accept headers over indexes when making test justifications
* Check that authority sets are valid
* Make Clippy happy
* Apply correct Clippy fix
* Move justification code into primitives module
* Use new module in verifier code
* Add primitives module for Substrate test helpers
* WIP
* Move justification generation into test_helpers
* Revert commits which move `justification` into primitives
This reverts commit 03a381f0bc4a8dbe4785c30d42ab252a06ba876c.
Co-authored-by: Svyatoslav Nikolsky <svyatonik@gmail.com>
Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
* Add pallet template from Substrate Dev Hub
* Clean up un-needed stuff from template
* Sketch out dispatchable interface
* Introduce notion of finality chain
* Add dependencies which were removed during a rebase
* Sketch out idea for finality header-chain pallet
* Sketch out ChainVerifier trait
* Add storage parameter to verifier
* Write out some things I think I need for finality verification
* Add some pseudocode for marking finalized headers
* Remove parity_scale_codec duplicate
* Move verification logic into pallet
I've been struggling with getting the generic types between the storage and verifier
traits to play nice with each other. As a way to continue making progress I'm moving
everything to the pallet. This way I hope to make progress towards a functional
pallet.
* Start doing verification around authority set changes
* Remove commented BridgeStorage and ChainVerifier traits
* Create Substrate bridge primitives crate
* Add logic for updating scheduled authority sets
* Introduce notion of imported headers
* Implement basic header ancestry checker
* Add mock runtime for tests
* Add testing boilerplate
* Add some storage read/write sanity tests
* Add some basic header import tests
* Add tests for ancestry proofs
* Create helper for changing authority sets
* Fix authority set test
Fixes a problem with how the scheduled change was counted as well as
a SCALE encoding issue
* Correctly check for scheduled change digests
There's no guarantee that the consensus digest item will be the last
one in a header, which is how it was previously being checked.
Thanks to Andre for pointing me to the Grandpa code that does this.
* Mark imported headers as finalized when appropriate
When a header that finalizes a chain of headers is succesfully imported
we also want to mark its ancestors as finalized.
* Add helper for writing test headers
* Add test helper for scheduling authority set changes
* Bump Substrate pallet and primitives to rc6
* Remove Millau verifier implementation
* Add some doc comments
* Remove some needless returns
* Make Clippy happy
* Split block import from finalization
* Make tests compile again
* Add test for finalizing header after importing children
* Create a test stub for importing future justifications
* Start adding genesis config
* Reject justifications from future
We should only be accepting justifications for the header
which enacted the current authority set. Any ancestors of
that header which require a justification can be imported
but they must not be finalized.
* Add explanation to some `expect()` calls
* Start adding GenesisConfig
* Plug genesis config into runtime
* Remove tests module
* Check for overflow when updating authority sets
* Make verifier take ownership of headers during import
* Only store best finalized header hash
Removed the need to store the whole header, since we store
it was part of the ImportedHeaders structure anyways
* Add some helpers to ImportedHeader
* Update ancestry checker to work with ImportedHeaders
* Update ancestry tests to use ImportedHeaders
* Update import tests to use ImportedHeaders
* Clean up some of the test helpers
* Remove stray dbg!
* Add doc comments throughout
* Remove runtime related code
* Fix Clippy warnings
* Remove trait bound on ImportedHeader struct
* Simplify checks in GenesisConfig
* Rename `get_header_by_hash()`
* Alias `parity_scale_codec` to `codec`
* Reword Verifier documentation
* Missed codec rename in tests
* Split ImportError into FinalizationError
* Remove ChainVerifier trait
This trait was a remenant of the original design, and it is not required
at the moment. Something like it should be added back in the future to
ensure that other chains which conform to this interface can be used
by higher-level bridge applications.
* Fix the verifier tests so they compile
* Implement Deref for ImportedHeader
* Get rid of `new` methods for some Substrate primitives
* Ensure that a child header's number follows its parent's
* Prevent ancestry checker from aimlessly traversing to genesis
If an ancestor which was newer than the child header we were checking we
would walk all the way to genesis before realizing that we weren't related.
This commit fixes that.
* Remove redundant clones
* Ensure that old headers are not finalized
Prevents a panic where if the header being imported and `best_finalized`
were the same header the ancestry checker would return an empty list. We
had made an assumption that the list would always be populated, and if this
didn't hold we would end up panicking.
* Disallow imports at same height as `best_finalized`
* Fix Clippy warnings
* Make NextScheduledChange optional
* Rework how scheduled authority set changes are enacted
We now require a justification for headers which _enact_ changes
instead of those which _schedule_ changes. A few changes had to
be made to accomodate this, such as changing when we check for
scheduled change logs in incoming headers.
* Update documentation for Substrate Primitives
* Clarify why we skip header in requires_justification check
* Add description to assert! call
* Fix formatting within macros
* Remove unused dependencies from runtime
* Remove expect call in GenesisConfig
* Turn FinalityProof into a struct
* Add some inline TODOs for follow up PRs
* Remove test which enacted multiple changes
This should be added back at some later point in time, but right now
the code doesn't allow for this behaviour.
* Use `contains_key` when checking for header
This is better than using `get().is_some()` since we skip
decoding the storage value
* Use initial hash when updating best_finalized
* Add better checks around enacting scheduled changes
* Rename finality related functions
* Appease Clippy
* Bump Substrate to rc5
* Bump async-std to v1.6.2
There was a bug in v.1.6.0 which kept us locked to v1.5 releases.
I think that's fixed now so I'm bumping this.
* Update bridge node runtime
* Update node service
* Update CLI
* Add SystemWeightInfo type to test runtimes
* Add RPC extension builder to service
* Directly return rpc_extensions_builder
* Allow complex types in service
This comes from Substrate, so I'd rather just keep the code as is
* Update benchmarking code for new CLI
* Bump Substrate to rc4
* Add BaseCallFilter type
* Add DenyUnsafe to SystemApi extension
* Use new ServiceBuilder build functions
* Add BaseCallFilter to test runtimes
* Remove old comments
* Add `rev` and `git` fields back
Turns out that if you don't have these future release candidates will
be used if available. For instance, once `rc5` is released a fresh pull
would use that instead of `rc4` which is what we want.
* Use tag release instead of specific commit
Will make scripted updates easier in the future
* Add short script to update between `rc` versions
* Update scripts/update_rc.sh
Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
* Update dependencies
Upgrades Substrate based dependencies from v2.0.0 -> v2.0.0-alpha.1
and uses the `jsonrpsee`'s new feature flags. The actual code hasn't
been updated though, so this won't compile.
* Use `RawClient`s from `jsonrpsee`
* Update to use jsonrpsee's new API
* Hook up Ethereum Bridge Runtime, Relay, and Node Runtime
* Bump `parity-crypto` from v0.4 to v0.6
Fixes error when trying to compile tests. This was caused by
`parity-crypto` v0.4's use of `parity-secp256k1` over `secp256k1'.
Using the Parity fork meant multiple version of the same underlying
C library were being pulled in. `parity-crypto` v0.6 moved away from
this, only relying on `secp256k1` thus fixing the issue.
* Copy node-template over from Substrate repo
Got the template at rev=6e6d06c33911
* Use dependencies from crates.io + stop renaming on import
* Remove template pallet
* Stop using crates.io dependencies
Instead they're going to be pinned at v2.0.0-alpha.2
at commit `2afecf81ee19b8a6edb364b419190ea47c4a4a31`
until something stable comes along.
* Remove LICENSE
* Change references of `node-template` to `bridge-node`
* Remove README
* Fix some missed node-template references
* Add WASM toolchain to CI
* Be more specific about nightly version to use
* Maybe don't tie to a specific nightly
* Use composite accounts
* Update to use lazy reaping
* Only use Development chain config
Tomasz Drwięga