* reward relayers for dispatching messages
* clippy
* Update modules/message-lane/src/lib.rs
Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
* added comment
* Update modules/message-lane/src/inbound_lane.rs
Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
* Update modules/message-lane/src/inbound_lane.rs
Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
* SubmitterId + RelayerId -> AccountId
* add confirmation_relayer arg to pay_relayer_reward
* cargo fmt --all
* removed verify_and_decode_messages_proof from SourceHeaderChain
* &mut self -> RefCell
* Optimize max messages at inbound lane (#418)
* Add tests for checking messages above max limit
Signed-off-by: MaciejBaj <macie.baj@gmail.com>
* Extend the relayers entry of inbound lane by additional msg nonce
Signed-off-by: MaciejBaj <macie.baj@gmail.com>
* Support additional message nonce from inbound relayers
Signed-off-by: MaciejBaj <macie.baj@gmail.com>
* Code format
Signed-off-by: MaciejBaj <macie.baj@gmail.com>
* Merge messages range for highest relayers
* Change unwrap() to ensure() while accessing relayers
* Edit rustdocs for relayers deque at inbound lane data
Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
* Declare additional relayers A & B and use across tests consistently
Signed-off-by: MaciejBaj <macie.baj@gmail.com>
* Remove duplicates and improve naming for inbound lane tests
* Fix test checking max limit per inbound lane
* Correct relayers rewards loop after a proof is received
* Remove redundant check for messages ahead of received range
* Correct grammar at inbound lane tests rustdocs
Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
* Improve code quality of relayers updates 💅
Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
* Test dispatches above max limit from same relayer
Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
* Fix typo.
Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
Co-authored-by: Maciej Baj <macie.baj@gmail.com>
Co-authored-by: Tomasz Drwięga <tomasz@parity.io>
* add HeaderTimestamp associated type
* use Header Timestamp
* rename HeaderTimestamp to ChainTime
* add unit test
* deal with clippy
* Apply suggestions from code review
Commit review suggestions
Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
* code review
* cargo fmt
* get rid of additional test runtime
* unit test asserts against concrete import context
Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
* Add Rialto as a target for the Millau node
* Rename Rialto module to Rialto-PoA
This will reduce confusion as the Millau runtime has a
Rialto module as well which refers to the Substrate chain.
* Add Millau as a target for the Rialto node
* Be more explicit about Rialto PoA related code
* Missed some name changes in the Ethereum PoA relay
* Re-export Substrate pallet structs used by node
* Remove `first_scheduled_change` of Millau in Rialto node
* Make Millau's genesis config for Rialto bridge more accurate
* Set initial header for Millau config
* Update initial Millau authorities
Co-authored-by: Svyatoslav Nikolsky <svyatonik@gmail.com>
* RustFmt Millau authorities
Co-authored-by: Svyatoslav Nikolsky <svyatonik@gmail.com>
* Implement public helpers for querying header info
* Update `best_header` when importing headers
* Add BestHeader to GenesisConfig
* Define extra types for Millau primitives
* Start implementing runtime APIs in Millau runtime
* Add helper for getting headers which require a justification
* Add runtime API for getting headers requiring a justification
* Reword `expect()` proof for valid authority sets
* Fix typo
* Clean up Hasher comment
* Add the Call Dispatch Pallet back to the Millau runtime
* Use types from Rialto in bridge pallet config
* Use the Rialto runtime APIS in the Millau runtime
* Include Millau bridge instance in Rialto runtime
* Add missing doc comment
* Use one storage function for setting and clearing `RequiresJustification`
* Remove TODO comments
* Split the Rialto Node into a standalone crate
* Split the Millau Node into a standalone crate
* Remove `bridge-node` crate
* Add benchmarking feature to nodes
* Check that benchmarks compile in CI
* Remove nodes from CI matrix
* Update Rialto node to Substrate 2.0
* Get Millau node compiling with Substrate 2.0
* Remove extra license text
* Remove comments in TOML files
* Move nodes and runtimes into Rialto and Millau folders
* Fix dependency paths
* Remove unused script
* Add issue to benchmarking TODO
* Fix benchmark manifest paths
* Remove the Substrate primitives crate
The types here were only used in one place, the pallet itself. If other
components start using these types we can considering moving them back
into a standalone crate.
* Start trying to integrate justification module
* Make Substrate blocks configurable in Pallet
* WIP: Try and generalize justification test helpers
* Fix tests which use "real" justifications
* Put common test helpers alongside mock code
* Use common helper for creating headers
* Remove usage of UintAuthorityId
This change favours the use of the Ed25519Keyring authorities
in order to keep things consistent with the tests.
* Add documentation around config trait types
* Make test header, hash, and number types consistent
* Update modules/substrate/src/verifier.rs
Co-authored-by: Svyatoslav Nikolsky <svyatonik@gmail.com>
* Update modules/substrate/src/lib.rs
Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
* Update modules/substrate/Cargo.toml
Co-authored-by: Svyatoslav Nikolsky <svyatonik@gmail.com>
* Derive `RuntimeDebug` instead of `Debug`
* Add `Paramter` as a trait constraint on config types
Since we use these types as part of the dispatchable functions
we should explicitly require this.
* Enforce that hasher output matches expected hash type
* Accept headers over indexes when making test justifications
* Check that authority sets are valid
* Make Clippy happy
* Apply correct Clippy fix
* Move justification code into primitives module
* Use new module in verifier code
* Add primitives module for Substrate test helpers
* WIP
* Move justification generation into test_helpers
* Revert commits which move `justification` into primitives
This reverts commit 03a381f0bc4a8dbe4785c30d42ab252a06ba876c.
Co-authored-by: Svyatoslav Nikolsky <svyatonik@gmail.com>
Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
* Add pallet template from Substrate Dev Hub
* Clean up un-needed stuff from template
* Sketch out dispatchable interface
* Introduce notion of finality chain
* Add dependencies which were removed during a rebase
* Sketch out idea for finality header-chain pallet
* Sketch out ChainVerifier trait
* Add storage parameter to verifier
* Write out some things I think I need for finality verification
* Add some pseudocode for marking finalized headers
* Remove parity_scale_codec duplicate
* Move verification logic into pallet
I've been struggling with getting the generic types between the storage and verifier
traits to play nice with each other. As a way to continue making progress I'm moving
everything to the pallet. This way I hope to make progress towards a functional
pallet.
* Start doing verification around authority set changes
* Remove commented BridgeStorage and ChainVerifier traits
* Create Substrate bridge primitives crate
* Add logic for updating scheduled authority sets
* Introduce notion of imported headers
* Implement basic header ancestry checker
* Add mock runtime for tests
* Add testing boilerplate
* Add some storage read/write sanity tests
* Add some basic header import tests
* Add tests for ancestry proofs
* Create helper for changing authority sets
* Fix authority set test
Fixes a problem with how the scheduled change was counted as well as
a SCALE encoding issue
* Correctly check for scheduled change digests
There's no guarantee that the consensus digest item will be the last
one in a header, which is how it was previously being checked.
Thanks to Andre for pointing me to the Grandpa code that does this.
* Mark imported headers as finalized when appropriate
When a header that finalizes a chain of headers is succesfully imported
we also want to mark its ancestors as finalized.
* Add helper for writing test headers
* Add test helper for scheduling authority set changes
* Bump Substrate pallet and primitives to rc6
* Remove Millau verifier implementation
* Add some doc comments
* Remove some needless returns
* Make Clippy happy
* Split block import from finalization
* Make tests compile again
* Add test for finalizing header after importing children
* Create a test stub for importing future justifications
* Start adding genesis config
* Reject justifications from future
We should only be accepting justifications for the header
which enacted the current authority set. Any ancestors of
that header which require a justification can be imported
but they must not be finalized.
* Add explanation to some `expect()` calls
* Start adding GenesisConfig
* Plug genesis config into runtime
* Remove tests module
* Check for overflow when updating authority sets
* Make verifier take ownership of headers during import
* Only store best finalized header hash
Removed the need to store the whole header, since we store
it was part of the ImportedHeaders structure anyways
* Add some helpers to ImportedHeader
* Update ancestry checker to work with ImportedHeaders
* Update ancestry tests to use ImportedHeaders
* Update import tests to use ImportedHeaders
* Clean up some of the test helpers
* Remove stray dbg!
* Add doc comments throughout
* Remove runtime related code
* Fix Clippy warnings
* Remove trait bound on ImportedHeader struct
* Simplify checks in GenesisConfig
* Rename `get_header_by_hash()`
* Alias `parity_scale_codec` to `codec`
* Reword Verifier documentation
* Missed codec rename in tests
* Split ImportError into FinalizationError
* Remove ChainVerifier trait
This trait was a remenant of the original design, and it is not required
at the moment. Something like it should be added back in the future to
ensure that other chains which conform to this interface can be used
by higher-level bridge applications.
* Fix the verifier tests so they compile
* Implement Deref for ImportedHeader
* Get rid of `new` methods for some Substrate primitives
* Ensure that a child header's number follows its parent's
* Prevent ancestry checker from aimlessly traversing to genesis
If an ancestor which was newer than the child header we were checking we
would walk all the way to genesis before realizing that we weren't related.
This commit fixes that.
* Remove redundant clones
* Ensure that old headers are not finalized
Prevents a panic where if the header being imported and `best_finalized`
were the same header the ancestry checker would return an empty list. We
had made an assumption that the list would always be populated, and if this
didn't hold we would end up panicking.
* Disallow imports at same height as `best_finalized`
* Fix Clippy warnings
* Make NextScheduledChange optional
* Rework how scheduled authority set changes are enacted
We now require a justification for headers which _enact_ changes
instead of those which _schedule_ changes. A few changes had to
be made to accomodate this, such as changing when we check for
scheduled change logs in incoming headers.
* Update documentation for Substrate Primitives
* Clarify why we skip header in requires_justification check
* Add description to assert! call
* Fix formatting within macros
* Remove unused dependencies from runtime
* Remove expect call in GenesisConfig
* Turn FinalityProof into a struct
* Add some inline TODOs for follow up PRs
* Remove test which enacted multiple changes
This should be added back at some later point in time, but right now
the code doesn't allow for this behaviour.
* Use `contains_key` when checking for header
This is better than using `get().is_some()` since we skip
decoding the storage value
* Use initial hash when updating best_finalized
* Add better checks around enacting scheduled changes
* Rename finality related functions
* Appease Clippy
* Rename Header to AuraHeader
This prevents some type conflicts with the PolkadotJS Apps types.
* Fix test and benchmark builds
* Update AuraHeader in types.json
* Add header-chain primitive crate
* Make MinimalHeaderChain functionaly the same as PeerBlockchain
* Use a better doc comment for MinimalHeaderChain
* Fix benchmark compilation
* Rust Fmt
* Remove Substrate based dependencies
* Rename MinimalHeaderChain to BaseHeaderChain
* Rename Ethereum PoA primitives crate
The "sp" prefix comes from Substrate primitives, since this crate originated
in that repo. However, it is not part of Substrate anymore and its name should
be updated to reflect that.
* Rename currency exchange primitives
* Rust Fmt
* Update import in benchmarking module
* Rust Fmt
* Split pub and no-pub
* Sort toml files.
Co-authored-by: Tomasz Drwięga <tomasz@parity.io>
* Bump Substrate to rc5
* Bump async-std to v1.6.2
There was a bug in v.1.6.0 which kept us locked to v1.5 releases.
I think that's fixed now so I'm bumping this.
* Update bridge node runtime
* Update node service
* Update CLI
* Add SystemWeightInfo type to test runtimes
* Add RPC extension builder to service
* Directly return rpc_extensions_builder
* Allow complex types in service
This comes from Substrate, so I'd rather just keep the code as is
* Update benchmarking code for new CLI
* Add Instance type parameter to pallet
* Sketch out what the runtime could look like
* Allow runtime to compile with multiple bridge pallets
* Cargo Fmt
* Allow an instance of a PoA chain to be used with currency-exchange
I specify that it's only _an instance_ instead of _instances_ since the currency-exchange
pallet does not support multiple instances itself. What this commit does is make it so
that the different instances of the PoA chains we currently have are compatible with the
currency-exchange pallet through the implementation of the PeerBlockchain trait.
* Add Instance type parameter to Currency Exchange pallet
* Wire up currency exchange intances in runtime
* Rust Fmt
* Show sccache
* Allow Eth pallet to use a default instance
* Use a default instance in Eth pallet tests
* Remove Rialto and Kovan feature flags
Through some discussions it has been decided that the `bridge-node` should, like
Substrate's `node-template`, be a showcase of the different pallets available in
a project. Because of this I've removed the feature flags for the Rialto and Kovan
networks in favour of having both of them included in the runtime.
* Update the chain_spec to use both Rialto and Kovan configs
* Update pallet level calls used by Substrate client
Allows the project to compile. However, it should be noted that in reality
we shouldn't be hardcoding the pallet we're calling.
* Allow currency-exchange pallet to use a default instance
* Support benchmarking an instance of the Eth pallet
* Update currency exchange benchmarks to work with instances
* Fix test helpers which now need a PoA instance
* Remove Actions for checking Rialto and Kovan features
* Add missing comments
* Update Runtime API string constants
* Add issue number for generic chain support in relay
* Add Runtime APIs for instances of the currency-exchange pallet
* Rust Fmt
Co-authored-by: Denis S. Soldatov aka General-Beck <general.beck@gmail.com>
* Bump Substrate to rc4
* Add BaseCallFilter type
* Add DenyUnsafe to SystemApi extension
* Use new ServiceBuilder build functions
* Add BaseCallFilter to test runtimes
* Remove old comments
* Add `rev` and `git` fields back
Turns out that if you don't have these future release candidates will
be used if available. For instance, once `rc5` is released a fresh pull
would use that instead of `rc4` which is what we want.
* Use tag release instead of specific commit
Will make scripted updates easier in the future
* Add short script to update between `rc` versions
* Update scripts/update_rc.sh
Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
* Add skeleton for worst case import_unsigned_header
* Fix a typo
* Add benchmark test for best case unsigned header import
* Add finality verification to worst case bench
* Move `insert_header()` from mock to test_utils
Allows the benchmarking code to use this without having to pull it in from the mock.
* Add a rough bench to test a finalizing a "long" chain
* Try to use complexity parameter for finality bench
* Improve long finality bench
* Remove stray dot file
* Remove old "worst" case bench
* Scribble some ideas down for pruning bench
* Prune headers during benchmarking
* Clean up some comments
* Make finality bench work for entire range of complexity parameter
* Place initialization code into a function
* Add bench for block finalization with caching
* First attempt at bench with receipts
* Try and trigger validator set change
* Perform a validator set change during benchmarking
* Move `validators_change_receipt()` to shared location
Allows unit tests and benchmarks to access the same helper function
and const
* Extract a test receipt root into a constant
* Clean up description of pruning bench
* Fix cache and pruning tests
* Remove unecessary `build_custom_header` usage
* Get rid of warnings
* Remove code duplication comment
I don't think its entirely worth it to split out so few lines of code.
The benches aren't particularly hard to read anyways.
* Increase the range of the complexity parameter
* Use dynamic number of receipts while benchmarking
As part of this change we have removed the hardcoded TEST_RECEIPT_ROOT
and instead chose to calculate the receipt root on the fly. This will
make tests and benches less fragile.
* Prune a dynamic number of headers
* runtime benchmarks: start
* merge tests + benchmarks infrastructure
* fix compilation
* Fix compilation issues with runtime-benchmark feature flag
Mainly involved pulling in correct dependencies and adding some functions
which were called but didn't yet exist.
* Fix broken compilation for tests
* Move header signing methods into trait
* Move signing related test helpers to own module
* Remove comment about feature flag
* Add constants to tests
* Add top level comment for testing utilities
Co-authored-by: Hernando Castano <castano.ha@gmail.com>
Svyatoslav Nikolsky