75b9456e69
Fix flaky test and error reporting ( #7282 )
...
* Fix flaky test and error reporting
* Address review comments and adjust recv timeouts
2023-05-24 15:50:00 +00:00
86564f1d66
[companion] Fix request-response protocols backpressure mechanism ( #7276 )
...
* Replace request-response incoming requests queue with `async-channel`
* Fix unused imports
* Fix channel type in tests
* Fix channel type in tests (part 2)
* Fix unused imports
* update lockfile for {"substrate"}
---------
Co-authored-by: parity-processbot <>
2023-05-24 10:34:06 +00:00
400864c352
Use Message Queue pallet for UMP dispatch ( #6271 )
...
* Add ProcessXcmMessage struct
* Migrate away from weights in host config
* New well-known key to report UMPQ capacity
* Add missing file
* Fixes
* Remove original UMP files
* Docs
* Update runtime/parachains/src/inclusion/mod.rs
Co-authored-by: asynchronous rob <rphmeier@gmail.com >
* Add benchmarking
* Benchmarks
* Mock example of using the QueueChangeHandler to update the WKK
* Use master Cargo.lock
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Merge remote-tracking branch 'origin/master' into gav-message-queue
* Update Cargo.lock
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update remove-weight migration
The migration got touched on master; just resolving conflicts here.
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add message- to dispatch-origin conversion for XCM processing
Just using the `impl Into<MultiLocation>` was a bit inflexible.
Like this, the Relaychain can convert `UMP(para)` to a MultiLocation `para`.
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* DNM: Temporarily comment code since XCMv3 is not merged yet
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Use u64 for queue-wide limits on UmpAcceptanceCheckErr
Using u32 here was one audit finding for the queue pallet.
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Define one sub-queue per *MP queue
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Harden check_upward_messages
Using safe math and casts.
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add type-safe well_known_keys
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add message-queue weights
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Deploy MessageQueue to Polkadot
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update Cargo.toml
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Migrate to parachain config V5
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update UMP tests
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Cleanup
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* fmt
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Revert messed up merge 🤦
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update remove-weight migration
The migration got touched on master; just resolving conflicts here.
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add message- to dispatch-origin conversion for XCM processing
Just using the `impl Into<MultiLocation>` was a bit inflexible.
Like this, the Relaychain can convert `UMP(para)` to a MultiLocation `para`.
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* DNM: Temporarily comment code since XCMv3 is not merged yet
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Use u64 for queue-wide limits on UmpAcceptanceCheckErr
Using u32 here was one audit finding for the queue pallet.
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Define one sub-queue per *MP queue
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Harden check_upward_messages
Using safe math and casts.
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add type-safe well_known_keys
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add message-queue weights
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Deploy MessageQueue to Polkadot
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update Cargo.toml
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Migrate to parachain config V5
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update UMP tests
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Cleanup
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* fmt
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Make stuff compile
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Move DMP and HRMP messages to the MessageQueue
It currently does not compile in the CIbecause of some local
tweaks to Substrate.
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Diener for CI
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* diener update cargo.lock
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Cleanup
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Revert wrong changes
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Revert "DNM: Temporarily comment code since XCMv3 is not merged yet"
This reverts commit 820aa235cb21dd1d2621843607f7682bf035434e.
* Make compile
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fixup runtimes
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* fmt
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Define benchmarks
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Cleanup
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix migration
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Use master Cargo.lock
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Lockfile
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix test
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add AggregateMessageOrigin
This enum currently only holds one value, but having it will make
it easier in the future to extend.
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Forbid UMP for off-boarding paras
- Reject candidates with UMP messages for off-boarding paras
- Forbid scheduling off-boarding when a para has unprocess UMPs
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Delete stupid test
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Use BoundedVec for upward messages
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add weights and fix MessageProcessor
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Bound receive_upward_messages and check bound in configuration pallet
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Bound Debug impl
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* fmt
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* clippy
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix test runtime
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix xcm-simulator
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Properly fix xcm-simulator and fuzzer
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix tests
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* fmt
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* cargo update -p sp-io
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Adapt to upstream Substrate changes
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix ProcesseMessage impls
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Some tests
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Use master Cargo.lock
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* cargo update -p sp-io
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Use new MQ API
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix test
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix migration
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update Cargo.lock
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add UMP while Para offboarding tests
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* fmt
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Use Mocked message processor for benchmarking
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Use variables for constants
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add MQ pallet weights
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Use MQ pallet weights
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Configure QueueChangeHandler
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* fmt
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add config test
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix MQ serive weight
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Cleanup
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Cleanup outgoing UMP dispatch queues
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Use Master Cargo.lock
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update Cargo.lock
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Weight mul is not const
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Clippy
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Remove merge marker
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update runtime/parachains/src/inclusion/mod.rs
Co-authored-by: Gavin Wood <gavin@parity.io >
* Update runtime/kusama/src/lib.rs
Co-authored-by: Gavin Wood <gavin@parity.io >
* Use lowercase UMP
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Clarify comment
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Use Weight::from_parts
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix test
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix doc
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Emit event after the fact
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add defensive_proof to receive_upward_messages
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Reapply "Remove original UMP files"
Looks like they came back from the dead. Re-apply commit cf6d316f0
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Remove old files
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Rename MaxUmpMessageLen -> MaxUmpMessageLenOf
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Test defensive message dropping of receive_upward_messages
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fixup imports
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update implementors guide
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix tests
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Remove FAIL-CI mark
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Delete unused code
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add another test for MQ change hook
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Imports
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Keep Kusama runtime formatting
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Revert "Delete unused code"
This reverts commit dd76bca5025b7e1ef846a9539c3607eed185f16a.
* Feature gate mock functions
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Review: Use saturating_add
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Test RelayDispatchQueueSize storage key
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Move migration to own file to avoid merge conflicts
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Migration in own file
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fixup migration
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Rococo: configure MQ pallet
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fixup tests
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Revert "Rococo: configure MQ pallet"
Going to do this as follow up, since it needs Substrate changes
and i dont want to stall this MR any longer.
This reverts commit b9c15e8a8339c4e877d654ee3f09903af4210736.
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Revert "Fixup tests"
This reverts commit 88f1cbe20774d20e5e1e554e798960ae39437af1.
* Fixup migration
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix migration
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* fmt
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix CI
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix migration
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix other migration
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Bump MAX_CODE_SIZE to 10MiB
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add ForceUpdateUmpLimits migration
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* fmt
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* clippy
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* clippy
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* imports
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Use defensive instead of defensive_proof
'defensive_proof' also prints the 'self', which spams the console
too much when running the tests. Just the length is enough.
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Rename to ScheduleConfigUpdate
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fixup migration checks
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add MAX_CODE_SIZE to ScheduleConfigUpdate
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Set MAX_CODE_SIZE to 4MiB
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix benchmark
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix formatting
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Revert "Add MAX_CODE_SIZE to ScheduleConfigUpdate"
This reverts commit 7caffb09e83083b57affd548215e45b25c3d64dc.
* Revert "Set MAX_CODE_SIZE to 4MiB"
This reverts commit 103ffbaf686487d2fbe0082a16826af17cacc1a1.
* Revert "Bump MAX_CODE_SIZE to 10MiB"
This reverts commit 530734b7b0da5b7680054e0242348fcc79a666fe.
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Remove consistency check from migration
Re-addig these checks is blocked on https://github.com/paritytech/polkadot/issues/7108
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix constants
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Bump MAX_UPWARD_MESSAGE_SIZE_BOUND for Westend
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix migrations
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Use old nightly for fmt
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fixes
* cargo fmt
* Fix tests
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix tests
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fixes
* Add MQ pallet to fuzzer
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fmt
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix XMC simulator example
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Remove runtime-benchmarks from fuzzers
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Revert "Remove runtime-benchmarks from fuzzers"
This reverts commit e1f2bb01b6dea2dd465539d3658719895b58b557.
* Fix example simulator
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add V6 migration and remove old ones
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Actually make old migrations reusable
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Dont delete old migrations
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Future proof AggregateMessageOrigin and review fixes
There are indications that Loopback and Bridged will be needed soon.
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* More cleanup
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* fmt
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* fix benchmarks
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix fuzzer build
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Review
Co-authored-by: muharem <ismailov.m.h@gmail.com >
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Remove old migration
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Set MQ service weight to 20%
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix tabs in Markdown
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
---------
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: asynchronous rob <rphmeier@gmail.com >
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
2023-05-19 16:14:13 +00:00
2ca3750f0f
Prefer fetching small PoVs from backing group ( #7173 )
...
* impl QueryChunkSize
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* QueryChunkSize message
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* enable fetching from backing group for small pov
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* review feedback
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Refactor `bypass_availability_store`
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* review feedback
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
---------
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
2023-05-05 09:56:54 +00:00
0ae0393042
Add option to skip av-store requests in availability-recovery-subsystem ( #7131 )
...
* Allow to skip availability-store
* Update node/network/availability-recovery/src/lib.rs
Co-authored-by: Michal Kucharczyk <1728078+michalkucharczyk@users.noreply.github.com >
---------
Co-authored-by: Michal Kucharczyk <1728078+michalkucharczyk@users.noreply.github.com >
2023-04-28 10:13:04 +00:00
83fb51a21c
Companion for Substrate #13889 ( #7063 )
...
* Companion for substrate #13889
* Remove leftover
* Remove removed dependency
* Remove sp-consensus-vrf from lock
* Revert "Remove sp-consensus-vrf from lock"
This reverts commit 2269ca1e32df89272e8fd4544292204db387f436.
* Fix after substrate modifications
* Fix tests to use new VRF Signature type
* Don't rely of Deref trait
* Fix test
* Further code simplification
* Reuse garbage_vrf_signature
* update lockfile for {"substrate"}
---------
Co-authored-by: parity-processbot <>
2023-04-19 09:43:42 +00:00
ecb6523b5c
approval distribution: trigger assignment/votes resend based on approval checking lag (#7038 )
...
* Send lag update message
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Process ApprovalCheckingLagUpdate
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Comput min age based on lag
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* fix comment
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Fix tests
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Fix test build
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Make the spawnhandle optional
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* remove unused
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
---------
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
2023-04-13 10:10:53 +00:00
64660ee8d2
Remove years from copyright notes ( #7034 )
...
* Happy New Year!
* Remove year entierly
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Remove years from copyright notice in the entire repo
---------
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
2023-04-08 20:38:35 +00:00
3ab60efc26
Cache SessionInfo on new activated leaf in dispute-distribution ( #6993 )
...
* Cache `SessionInfo` on new activated leaf in `dispute-distribution`
* Update node/network/dispute-distribution/src/sender/mod.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* fmt
* Decrease log level
---------
Co-authored-by: Bastian Köcher <git@kchr.de >
2023-04-03 18:51:31 +02:00
713f6625fa
Consolidate subsystem spans so they are all children of the leaf-activated root span ( #6458 )
...
* Pass the PerLeafSpan as mutable reference to handle_new_head function
* cargo +nightly fmt --all
* Add mock span for test
* cargo +nightly fmt --all
* add new-blocks-hashes to span
* ref span in match statement, set span to disabled if not passed
* remove second match clause, make handle_new_head_span mutable
* cargo +nightly fmt --all
* improve tag on error and warning
* add imported blocks and info span
* cargo +nightly fmt --all
* Improve error for imported_blocks_and_info trace
* format tags on get_header_span
* add lost-to-finality tag
* add missing bracket
* - Add bitfield child span
- Add block db insertion span
* - fix update-bitfield span tag
* - Fix type conversion to u64
- Add missing argument
* - Cargo fmt
* - Test add_follows_from
* - Revert as relationship between spans not working correctly
* - use drop to test if parent-child relationship can be re-established
* - remove bitfield span, check if parent-child relationship can be reestablished
* - Remove dangling bitfield span which is not used, to see if parent-child relationship can be re-established
* Another dangling bitfield span
* cargo fmt
* - add imported blocks and info span
- add candidate span per candidate
* add tags before moving block_header to push scope
* - Add db-insertion span
* cargo fmt
* fix types
* * Pass mutable reference to span in handle_new_head
* Change get-header-span tags in handle_new_head
* Create cache-session-info span in handle_new_head
* Create optional argument in determine_new_blocks
* Pass mutable reference to handle_new_head_span in determine_new_blocks in handle_new_head function
* Add candidate-hash, candidate-number, lost-to-finality tags to candidate_span in handle_new_head function
* Manually drop db_insertion_span and remove superfluous tags to it, only keeping approved-bitfields tag
* Add ApprovalVoting stage in jaeger
* * Pass mutable reference to jaeger::Span in stead of PerLeafSpan
* Add block-import span
* *Pass optional_span (optional argument) to determine_new_blocks util function
* * Add num-candidates int tag to block_import_span
* * Add head tag to cache_session_span
* * Create PerLeafSpan in handle_from_overseer (this is required to establish parent-child relationship between approval-voting span, and leaf-activated root span)
* * Add candidate-import-span as child of block-import-span
* Add candidate-hash and num-approval tags to candidate-import-span
* * Fix num-candidate tag to bitvec-len tag in candidate-import-span
* *Fix imported_blocKs_and_info span to create new-block-span as not dealing with candidates
* Consider the future::select! block
* Use HashMap<Hash, jaeger::PerLeafSpan>
* Remove Stage 9
* Add missing spans
* cargo +nightly fmt --all
* Remove optional span argument for determine_new_blocks
* * Remove no-longer needed default PerLeafSpan implementation
* Remove no-longer necessary mock span given re-factoring of handle_new_head() no longer neeing mutable span
* Split validation-result and request-data (availability and validation code) spans into two by dropping request_validation_data_spans
* Remove drop statements for cache_session_info_span
*
* Remove unnecessary span
* Remove another excessively spammy span
* Add missing spans from State in import tests
* Use functional approach to get spans
* - Add functional approach for the approval-voting span
- Add doc on block_numbers given labelling ambiguity
- Add span pruning logic
- Use .add_para_id on validation_result_span
* Replace for hash_set in hash_set_iter with map closure
* cargo +nightly fmt --all
* Change from unconsumed `map` to `.for_each`
* cargo +nightly fmt --all
* Refactor add_para_id to validation_result_span
* cargo +nightly fmt --all
* Remove duplicate tag
* Add missing tag to handle-approved-ancestor span
* Refactor span pruning to only invoke retain once
* Typo in span name
* - Replace unwrap_or with unwrap_or_else due to lazy evaluation of trace-identifier in polkadot_node_jaeger
- Remove some redundant spans
* Add approval-distribution spans
* - Add unwrap_or_else on note-approved-in-chain-selection
- Use child_with_trace_id to add traceID string tag on span (note this does not change the traceID, but just adds a tag)
* cargo +nightly fmt --all
* - Add traceID tags were necessary in approval-voting and availability-distribution
- Always use block-hash tag in stead of relay-parent tag in approval-distribution
* Remove schedule-wakeup span as it will duplicate spans on existing wakeups (which should be a no-op)
* Remove a couple of warnings related to mutability
* Fix failing tests in availability distribution
* Add traceID tag to launch-approval and validation-result
* Reshuffle the validation and validation result spans to where more appropriate and add block-hash tag
* - Add tranche and should-trigger tag to process-wakeup span
- Add candidate-hash and traceID to check-and-import-approval span
* cargo fmt
* - Adjustments after PR comments
* Move span pruning after other pruning logic
* Remove DerefMut - no longer needed
* Relabel request-chunk spans
* - Fix typo in span label
- Add docs for drops
* Add new approval-voting span pruning logic
* Undo removal of !
* cargo fmt
2023-03-31 15:54:19 +00:00
fc2cba1805
Subsystem channel tweaks ( #6905 )
...
* subsystem tweaks for higher scale
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Adjust queue sizes
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Orchestra 0.0.5
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* cargo lock
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
---------
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
2023-03-24 17:19:37 +00:00
260d073658
Companion for #13683 ( #6944 )
...
* Companion for #13683
* Wraps trait is not required
* update lockfile for {"substrate"}
---------
Co-authored-by: parity-processbot <>
2023-03-24 14:43:21 +00:00
95f0ca271e
Bump parity-scale-codec to v 3.4.0 ( #6945 )
2023-03-23 15:15:03 +00:00
46c36e5a4f
[Companion #13615 ] Keystore overhaul ( #6892 )
...
* Remove not required async calls
* Fixed missing renaming
* make_keystore can be sync
* More fixes
* Trivial nitpicks
* Cherry pick test fix from master
* Fixes after master merge
* update lockfile for {"substrate"}
---------
Co-authored-by: parity-processbot <>
2023-03-17 12:09:15 +00:00
0e1c932c42
Companion for paritytech/substrate#13592 ( #6869 )
...
* Move configs
* Start using `NetworkService` traits from `sc-network`
* Fix stuff
* Remove `sc-network-common` as dependency
* update lockfile for {"substrate"}
---------
Co-authored-by: parity-processbot <>
2023-03-14 12:52:15 +00:00
ce9fbe73d9
Companion for paritytech/substrate#12828 ( #6380 )
...
* Companion for paritytech/substrate#12828
* Pass sync service
* Fix test
* Fix tests again
* update lockfile for {"substrate"}
* cargo fmt
---------
Co-authored-by: parity-processbot <>
2023-03-06 17:46:27 +00:00
1790d0ae36
Bump parity-scale-codec to 3.3.0 ( #6666 )
2023-02-03 14:03:38 +00:00
caa5464c15
Add a CI check ensuring the code has license headers ( #6609 )
...
* Introduce a job scanning and ensuring there are licenses
* Showcase a red test
* Add missing licenses
* Cleanup
* Extend the check
* Add missing licenses
* CI trigger
2023-02-03 12:02:23 +00:00
59a8b59fe2
Bump lru from 0.8.1 to 0.9.0 ( #6538 )
...
Bumps [lru](https://github.com/jeromefroe/lru-rs ) from 0.8.1 to 0.9.0.
- [Release notes](https://github.com/jeromefroe/lru-rs/releases )
- [Changelog](https://github.com/jeromefroe/lru-rs/blob/master/CHANGELOG.md )
- [Commits](https://github.com/jeromefroe/lru-rs/compare/0.8.1...0.9.0 )
---
updated-dependencies:
- dependency-name: lru
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-01-22 22:40:49 +01:00
1a1bfd2af9
XCM v3 ( #4097 )
...
* cargo fmt
* Create benchmarks for XCM instructions introduced in v3 (#4564 )
* Create benchmarks for BurnAsset and ExpectAsset
* Add benchmarks for ExpectOrigin and ExpectError
* Add benchmarks for QueryPallet and ExpectPallet
* Add benchmarks for ReportTransactStatus and ClearTransactStatus
* cargo fmt
* Use AllPalletsWithSystem in mocks
* Update XCM generic benchmarks for westend
* Remove default impls for some XCM weight functions
* Fix compilation error
* Add weight_args helper attribute
* Remove manually written XcmWeightInfo
* Parse trailing comma
* Revert "Add weight_args helper attribute"
This reverts commit 3b7c47a6182e1b9227036c38b406d494c3fcf6fd.
* Fixes
* Fixes
* XCM v3: Introduce querier field into `QueryReponse` (#4732 )
* Introduce querier field into QueryReponse
* Convert &Option<MultiLocation> to Option<&MultiLocation>
&Option<T> is almost always never quite useful, most of the time it
still gets converted to an Option<&T> via `as_ref`, so we should simply
make functions that accept Option<&T> instead.
* Fix tests
* cargo fmt
* Fix benchmarks
* Appease spellchecker
* Fix test
* Fix tests
* Fix test
* Fix mock
* Fixes
* Fix tests
* Add test for response queriers
* Update xcm/pallet-xcm/src/lib.rs
* Test for non-existence of querier
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
* Fixes
* Fixes
* Add `starts_with` function to `MultiLocation` and `Junctions` (#4835 )
* add matches_prefix function to MultiLocation and Junctions
* rename matches_prefix to starts_with
* remove unnecessary main in doc comment
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Make use of starts_with in match_and_split
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
* XCM v3: Bridge infrastructure (#4681 )
* XCM bridge infrastructure
* Missing bit of cherry-pick
* Revamped XCM proc macros; new NetworkIds
* Fixes
* Formatting
* ExportMessage instruction and config type
* Add MessageExporter definitions
* Formatting
* Missing files
* Fixes
* Initial bridging config API
* Allow for two-stage XCM execution
* Update xcm/src/v3/mod.rs
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
* XCM crate building again
* Initial bridging primitive
* Docs
* Docs
* More work
* More work
* Merge branch 'gav-xcm-v3' into gav-xcm-v3-bridging
* Make build
* WithComputedOrigin and SovereignPaidRemoteExporter
* Remove TODOs
* Slim bridge API and tests.
* Fixes
* More work
* First bridge test passing
* Formatting
* Another test
* Next round of bridging tests
* Repot tests
* Cleanups
* Paid bridging
* Formatting
* Tests
* Spelling
* Formatting
* Fees and refactoring
* Fixes
* Formatting
* Refactor SendXcm to become two-phase
* Fix tests
* Refactoring of SendXcm and ExportXcm complete
* Formatting
* Rename CannotReachDestination -> NotApplicable
* Remove XCM v0
* Minor grumbles
* Formatting
* Formatting
* Fixes
* Fixes
* Cleanup XCM config
* Fee handling
* Fixes
* Formatting
* Fixes
* Bump
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
* Bump Substrate
* XCM v3: `ExchangeAsset` and Remote-locking (#4945 )
* Asset Exchange and Locks
* Make sure XCM typers impl MaxEncodedLen
* Basic implementation for locks
* Bump Substrate
* Missing files
* Use new API
* Introduce instruction
* Big refactor
* Docs
* Remove deprecated struct
* Remove deprecated struct
* Repot XCM builder tests
* ExchangeAsset test
* Exchange tests
* Locking tests
* Locking tests
* Fixes and tests
* Fixes
* Formatting
* Spelling
* Add simulator test for remote locking
* Fix tests
* Bump
* XCM v3: Support for non-fungibles (#4950 )
* NFT support and a test
* New files.
* Integration tests for sending NFTs
* Formatting
* Broken Cargo features
* Use 2021 edition
* Fixes
* Formatting
* Formatting
* Update xcm/xcm-builder/src/asset_conversion.rs
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
* Update xcm/xcm-builder/src/nonfungibles_adapter.rs
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
* Update xcm/xcm-executor/src/lib.rs
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
* Fixes
* Fixes
* Fixes
* Formatting
* Fixes
Co-authored-by: Bastian Köcher <info@kchr.de >
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
* XCM v3: Context & ID hash (#4756 )
* send_xcm returns message hash
* cargo fmt
* Create topic register and instructions
* Fix weights
* Use tabs
* Sketch out XcmContext
* Fix doc test
* Add the XCM context as a parameter to executor trait fns
* Fixes
* Add XcmContext parameter
* Revert adding context as an arg to SendXcm trait methods
* Revert adding context argument to ConvertOrigin trait methods
* cargo fmt
* Do not change the API of XcmExecutor::execute
* Fixes
* Fixes
* Fixes
* Fixes
* Remove convenience method
* Fixes
* Fixes
* cargo fmt
* Fixes
* Add benchmarks for XCM topic instructions
* cargo run --quiet --profile=production --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=pallet_xcm_benchmarks::generic --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --template=./xcm/pallet-xcm-benchmarks/template.hbs --output=./runtime/westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs
* Remove context argument on FilterAssetLocation
* Fixes
* Remove unused import
* Fixes
* Fixes
* Fixes
* Accept XCM hash parameter in ExecuteXcm trait methods
* cargo fmt
* Properly enable sp-io/std
* Fixes
* default-features = false
* Fixes
* Fixes
* Fixes
* Make XcmContext optional in withdraw_asset
* Fixes
* Fixes
* Fixes
* Modify tests to check for the correct XCM hash
* Small refactor
* cargo fmt
* Check for expected hash in xcm-builder unit tests
* Add doc comment for the optionality of the XCM context in withdraw_asset
* Update xcm/src/v3/traits.rs
* Update xcm/src/v3/traits.rs
* Store XcmContext and avoid rebuilding
* Use ref for XcmContext
* Formatting
* Fix incorrect hash CC @KiChjang
* Refactor and make clear fake hashes
* Fixes
* Fixes
* Fixes
* Fix broken hashing
* Docs
* Fixes
* Fixes
* Fixes
* Formatting
* Fixes
* Fixes
* Fixes
* Remove unknowable hash
* Formatting
* Use message hash for greater identifiability
* Formatting
* Fixes
* Formatting
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
Co-authored-by: Parity Bot <admin@parity.io >
* Fixes
* Fixes
* Fixes
* Fixes
* Formatting
* Fixes
* Formatting
* Fixes
* Fixes
* Formatting
* Formatting
* Remove horrible names
* Bump
* Remove InvertLocation trait (#5092 )
* Remove InvertLocation trait
* Remove unneeded functions
* Formatting
* Fixes
* Remove XCMv1 (#5094 )
* Remove XCMv1
* Remove XCMv1
* Formatting
* Fixes
* Fixes
* Formatting
* derive serialize/deserialize for xcm primitives (#5036 )
* derive serialize/deserialize for xcm primitives
* derive serialize/deserialize for xcm primitives
* update v3
* update v2
Co-authored-by: Gav Wood <gavin@parity.io >
* Update lock
* Fixes
* Add benchmarks for the ExchangeAsset instruction
* `AliasOrigin` instruction stub (#5122 )
* AliasOrigin instruction stub
* Fixes
* Fixes
* Update substrate
* Fixes
* Ensure same array length before using copy_from_slice
* Fixes
* Add benchmarks for the UniversalOrigin instruction
* Remove unused import
* Remove unused import
* Add benchmarks for SetFeesMode instruction
* Add benchmarks for asset (un)locking instructions
* Leave AliasOrigin unbenchmarked
* Fixes after merge
* cargo fmt
* Fixes
* Fixes
* Set TrustedReserves to None on both Kusama and Westend
* Remove extraneous reserve_asset_deposited benchmark
* Fix universal_origin benchmark
* cargo run --quiet --profile=production --features=runtime-benchmarks -- benchmark pallet --chain=westend-dev --steps=50 --repeat=20 --pallet=pallet_xcm_benchmarks::generic --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --template=./xcm/pallet-xcm-benchmarks/template.hbs --output=./runtime/westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs
* Don't rely on skipped benchmark functions
* Fixes
* cargo run --quiet --profile=production --features=runtime-benchmarks -- benchmark pallet --chain=kusama-dev --steps=50 --repeat=20 --pallet=pallet_xcm_benchmarks::generic --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --template=./xcm/pallet-xcm-benchmarks/template.hbs --output=./runtime/kusama/src/weights/xcm/pallet_xcm_benchmarks_generic.rs
* Fix unused variables
* Fixes
* Spelling
* Fixes
* Fix codec index of VersionedXcm
* Allows to customize how calls are dispatched from XCM (#5657 )
* CallDispatcher trait
* fmt
* unused import
* fix test-runtime
* remove JustDispatch type
* fix typo in test-runtime
* missing CallDispatcher
* more missing CallDispatcher
* Update comment `NoteAssetLocked` -> `NoteUnlockable`
* Fixes
* Fixes
* Adjust MultiAssets weights based on new wild card variants
* Fixes
* Fixes
* Fixes
* Fixes
* Fixes
* Some late fixes for XCMv3 (#5237 )
* Maximise chances that trapped assets can be reclaimed
* Do origin check as part of ExportMessage for security
* Formatting
* Fixes
* Cleanup export XCM APIs
* Formatting
* Update xcm/src/v3/junctions.rs
* UnpaidExecution instruction and associated barrier.
* Tighten barriers (ClearOrigin/QueryResponse)
* Allow only 1 ClearOrigin instruction in AllowTopLevelPaidExecutionFrom
* Bi-directional teleport accounting
* Revert other fix
* Build fixes]
* Tests build
* Benchmark fixes
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
* Update Substrate
* Re-export `pub` stuff from universal_exports.rs + removed unecessary clone (#6145 )
* Re-export `pub` stuff from universal_exports.rs
* Removed unnecessary clone
* Use 2D weights in XCM v3 (#6134 )
* Depend upon sp-core instead of sp-runtime
* Make sp-io a dev-dependency
* Use 2D weights in XCM v3
* cargo fmt
* Add XCM pallet migration to runtimes
* Use from_parts
* cargo fmt
* Fixes
* cargo fmt
* Remove XCMWeight import
* Fixes
* Fixes
* Fixes
* Fixes
* Use translate in migration
* Increase max upward message size in tests
* Fix doc test
* Remove most uses of from_ref_time
* cargo fmt
* Fixes
* Fixes
* Add extrinsic benchmarking to XCM pallet
* cargo fmt
* Fixes
* Use old syntax
* cargo fmt
* Fixes
* Remove hardcoded weights
* Add XCM pallet to benchmarks
* Use successful origin
* Fix weird type parameter compilation issue
* Fixes
* ".git/.scripts/bench-bot.sh" runtime westend-dev pallet_xcm
* ".git/.scripts/bench-bot.sh" runtime rococo-dev pallet_xcm
* ".git/.scripts/bench-bot.sh" runtime kusama-dev pallet_xcm
* ".git/.scripts/bench-bot.sh" runtime polkadot-dev pallet_xcm
* Use benchmarked XCM pallet weights
* Fixes
* Fixes
* Use override instead of skip
* Fixes
* Fixes
* Fixes
* Fixes
* ".git/.scripts/bench-bot.sh" runtime polkadot-dev pallet_xcm
* Fixes
* ".git/.scripts/bench-bot.sh" runtime polkadot-dev pallet_xcm
* ".git/.scripts/bench-bot.sh" runtime westend-dev pallet_xcm
Co-authored-by: command-bot <>
* Replace Weight::MAX with 100b weight units
* Add test to ensure all_gte in barriers is correct
* Update xcm/src/v3/junction.rs
Co-authored-by: asynchronous rob <rphmeier@gmail.com >
* Add more weight tests
* cargo fmt
* Create thread_local in XCM executor to limit recursion depth (#6304 )
* Create thread_local in XCM executor to limit recursion depth
* Add unit test for recursion limit
* Fix statefulness in tests
* Remove panic
* Use defer and environmental macro
* Fix the implementation
* Use nicer interface
* Change ThisNetwork to AnyNetwork
* Move recursion check up to top level
* cargo fmt
* Update comment
Co-authored-by: Bastian Köcher <info@kchr.de >
* Add upper limit on the number of overweight messages in the queue (#6298 )
* Add upper limit on the number of ovwerweight messages in the queue
* Add newline
* Introduce whitelist for Transact and limit UMP processing to 10 messages per block (#6280 )
* Add SafeCallFilter to XcmConfig
* Limit UMP to receive 10 messages every block
* Place 10 message limit on processing instead of receiving
* Always increment the message_processed count whenever a message is processed
* Add as_derivative to the Transact whitelist
* cargo fmt
* Fixes
* Update xcm/xcm-builder/src/universal_exports.rs
Co-authored-by: Branislav Kontur <bkontur@gmail.com >
* Fixes
* Fixes
* Remove topic register and instead use the topic field in XcmContext
* Derive some common traits for DispatchBlobError
* Fixes
* cargo fmt
* Fixes
* Fixes
* Fix comments
* Fixes
* Introduce WithOriginFilter and apply it as the CallDispatcher for runtimes
* Fixes
* Appease clippy and fixes
* Fixes
* Fix more clippy issues
* Fixes
* ".git/.scripts/bench-bot.sh" runtime polkadot-dev pallet_xcm
* ".git/.scripts/bench-bot.sh" runtime westend-dev pallet_xcm
* ".git/.scripts/bench-bot.sh" runtime westend-dev pallet_xcm
* Add benchmark function for ExportMessage
* Fix comment
* Add upper limit to DownwardMessageQueues size
* Add max size check for queue in can_queue_downward_message
* Fixes
* Make Transact runtime call configurable
* Return Weight::MAX when there is no successful send XCM origin
* Update substrate
* Fixes
* Fixes
* Remove ExportMessage benchmark
* Remove assertion on Transact instruction benchmark
* Make reachable destination configurable in XCM pallet benchmarks
* Fixes
* Fixes
* Remove cfg attribute in fuzzer
* Fixes
* Remove cfg attribute for XCM pallet in test runtime
* Fixes
* Use ReachableDest where possible
* Fixes
* Add benchmark for UnpaidExecution
* Update substrate
* Ensure benchmark functions pass filters
* Add runtime-benchmarks feature to fuzzer
* Ensure FixedRateOfFungible accounts for proof size weights
* cargo fmt
* Whitelist remark_with_event when runtime-benchmarks feature is enabled
* Use remark_with_event for Transact benchmarks
* Fix Cargo.lock
* Allow up to 3 DescendOrigin instructions before UnpaidExecution
* cargo fmt
* Edit code comment
* Check check_origin for unpaid execution privilege
* Fixes
* Small nits for xcm-v3 (#6408 )
* Add possibility to skip benchmark for export_message
* ".git/.scripts/bench-bot.sh" xcm westend-dev pallet_xcm_benchmarks::generic
* Revert
* ".git/.scripts/bench-bot.sh" xcm westend-dev pallet_xcm_benchmarks::generic
* Add HaulBlobError to `fn haul_blob`
* ".git/.scripts/bench-bot.sh" xcm westend-dev pallet_xcm_benchmarks::generic
Co-authored-by: command-bot <>
* Revert changes to UnpaidExecution
* Change AllowUnpaidExecutionFrom to be explicit
* Fix log text
* cargo fmt
* Add benchmarks for XCM pallet version migration (#6448 )
* Add benchmarks for XCM pallet version migration
* cargo fmt
* Fixes
* Fixes
* Fixes
* ".git/.scripts/bench-bot.sh" runtime westend-dev pallet_xcm
* ".git/.scripts/bench-bot.sh" runtime kusama-dev pallet_xcm
* ".git/.scripts/bench-bot.sh" runtime rococo-dev pallet_xcm
* ".git/.scripts/bench-bot.sh" runtime polkadot-dev pallet_xcm
* Fix benchmarks
* Fix benchmarks
* ".git/.scripts/bench-bot.sh" runtime westend-dev pallet_xcm
* ".git/.scripts/bench-bot.sh" runtime kusama-dev pallet_xcm
* ".git/.scripts/bench-bot.sh" runtime rococo-dev pallet_xcm
* ".git/.scripts/bench-bot.sh" runtime polkadot-dev pallet_xcm
Co-authored-by: command-bot <>
* Merge remote-tracking branch 'origin/master' into gav-xcm-v3
* Fixes
* Fix comments (#6470 )
* Specify Ethereum networks by their chain id (#6286 )
Co-authored-by: Squirrel <gilescope@gmail.com >
* Use for Kusama
* Use WithComputedOrigin for Polkadot, Rococo and Westend
* Update lock
* Fix warning
* Update xcm/pallet-xcm/src/tests.rs
Co-authored-by: Squirrel <gilescope@gmail.com >
* Update runtime/parachains/src/ump/migration.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update xcm/pallet-xcm/src/migration.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fixes
* cargo fmt
* Typo
* Update xcm/src/v3/mod.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Docs
* Docs
* Docs
* Docs
* Docs
* Update xcm/src/v3/multiasset.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add tests for MultiAssets::from_sorted_and_deduplicated
* Fail gracefully when same instance NFTs are detected during push
* Update Substrate to fix benchmarks
* Apply suggestions from code review
* Update runtime/kusama/src/xcm_config.rs
* Rename arguments
* Attempt to fix benchmark
* ".git/.scripts/commands/bench/bench.sh" runtime polkadot-dev runtime_parachains::ump
* Use actual weights for UMP pallet in Polkadot
* ".git/.scripts/commands/bench/bench.sh" runtime kusama-dev runtime_parachains::ump
* ".git/.scripts/commands/bench/bench.sh" runtime westend-dev runtime_parachains::ump
* ".git/.scripts/commands/bench/bench.sh" runtime rococo-dev runtime_parachains::ump
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
Co-authored-by: Alexander Popiak <alexander.popiak@parity.io >
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
Co-authored-by: Bastian Köcher <info@kchr.de >
Co-authored-by: Parity Bot <admin@parity.io >
Co-authored-by: stanly-johnson <stanlyjohnson@outlook.com >
Co-authored-by: nanocryk <6422796+nanocryk@users.noreply.github.com >
Co-authored-by: Branislav Kontur <bkontur@gmail.com >
Co-authored-by: asynchronous rob <rphmeier@gmail.com >
Co-authored-by: command-bot <>
Co-authored-by: Vincent Geddes <vincent.geddes@hey.com >
Co-authored-by: Squirrel <gilescope@gmail.com >
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com >
2023-01-17 07:04:34 +00:00
1cb1d03c08
Re-export current primitives in crate root ( #6487 )
...
* Re-export current primitives in crate root
* Add missing exports
* restart CI
2023-01-11 11:28:12 +00:00
3cf18f11ac
Minor fixes ( #6533 )
...
* Minor fixes
* Fix compile errors
2023-01-10 17:59:12 +00:00
cc650fe53d
Fix cycle dispute-coordinator <-> dispute-distribution ( #6489 )
...
* First iteration of message sender.
* dyn Fn variant (no cloning)
* Full implementation + Clone, without allocs on `Send`
* Further clarifications/cleanup.
* MessageSender -> NestingSender
* Doc update/clarification.
* dispute-coordinator: Send disputes on startup.
+ Some fixes, cleanup.
* Fix whitespace.
* Dispute distribution fixes, cleanup.
* Cargo.lock
* Fix spaces.
* More format fixes.
What is cargo fmt doing actually?
* More fmt fixes.
* Fix nesting sender.
* Fixes.
* Whitespace
* Enable logging.
* Guide update.
* Fmt fixes, typos.
* Remove unused function.
* Simplifications, doc fixes.
* Update roadmap/implementers-guide/src/node/disputes/dispute-coordinator.md
Co-authored-by: Marcin S. <marcin@bytedude.com >
* Fmt + doc example fix.
Co-authored-by: eskimor <eskimor@no-such-url.com >
Co-authored-by: Marcin S. <marcin@bytedude.com >
2023-01-10 12:04:05 +01:00
715e98268a
Use polkadot-node-metrics where possible ( #6484 )
...
See https://github.com/paritytech/polkadot/issues/6015 . (Doesn't close yet,
there might be more we can do.)
2023-01-06 15:01:23 +00:00
b5e44b7075
Adding some more logs ( #6455 )
...
* Adding some more logs
More logs are always better! Joke aside, these logs help to debug
certain issues.
* Apply suggestions from code review
2022-12-17 18:51:39 +01:00
3c1a28276d
Fix wrong rate limit + add a few logs. ( #6440 )
...
* Add trace log
* More tracing.
* Fix redundant rate limit.
* Add trace log.
* Improve logging.
Co-authored-by: eskimor <eskimor@no-such-url.com >
2022-12-15 09:47:06 +00:00
7f020eb527
approval-distribution: batched approval/assignment sending ( #6401 )
...
* Imple batched send
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Add batch tests
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* pub MAX_NOTIFICATION_SIZE
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* spell check
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* spellcheck ...
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Fix comment
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* o.O
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* 2 constants
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Ensure batch size is at least 1 element
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* feedback impl
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
2022-12-13 14:06:05 +02:00
c748250748
Make sure to preserve backing votes ( #6382 )
...
* Guide updates
* Consider more dead forks.
* Ensure backing votes don't get overridden.
* Fix spelling.
* Fix comments.
* Update node/primitives/src/lib.rs
Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io >
Co-authored-by: eskimor <eskimor@no-such-url.com >
Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io >
2022-12-07 17:14:13 +00:00
be403051dc
Set polkadot version in one place ( #6095 )
...
* rust 1.64 enables workspace properties
* add edition, repository and authors.
* of course, update the version in one place.
Co-authored-by: Andronik <write@reusable.software >
2022-12-05 11:36:16 +00:00
7341dbb20d
Add buckets on lower end of distribution to network bridge latency metrics ( #6359 )
...
* Add two more buckets on lower end of distribution
* add even smaller buckets
* cargo fmt
2022-12-02 18:28:24 +02:00
9ea14e66c8
Clippyfy ( #6341 )
...
* Add clippy config and remove .cargo from gitignore
* first fixes
* Clippyfied
* Add clippy CI job
* comment out rusty-cachier
* minor
* fix ci
* remove DAG from check-dependent-project
* add DAG to clippy
Co-authored-by: alvicsam <alvicsam@gmail.com >
2022-11-30 08:34:06 +00:00
b76086c617
sync versions with current release (0.9.33) ( #6363 )
...
* westend: update transaction version
* polkadot: update transaction version
* kusama: update transaction version
* Bump spec_version to 9330
* bump versions to 0.9.33
2022-11-30 10:32:20 +02:00
893a3ad784
Add more granularity to prometheus histogram buckets ( #6348 )
...
* Add buckets below 5ms
* Add more specific histogram buckets
* Add more specific buckets
* cargo fmt
2022-11-28 11:30:27 +00:00
53d9a50c06
Add support for outbound only configs on request/response protocols ( #6343 )
...
* Add option ot add outbound_only configurations
* Improve comment
2022-11-26 10:22:09 +01:00
7ba0847349
Rate limit improvements ( #6315 )
...
* We actually don't need to rate limit redundant requests.
Those redundant requests should not actually happen, but still.
* Add some logging.
* Also log message when the receiving side hit the rate limit.
* Update node/network/dispute-distribution/src/sender/mod.rs
Co-authored-by: Alexandru Vasile <60601340+lexnv@users.noreply.github.com >
Co-authored-by: eskimor <eskimor@no-such-url.com >
Co-authored-by: Alexandru Vasile <60601340+lexnv@users.noreply.github.com >
2022-11-23 16:43:30 +01:00
ccad411e46
Change best effort queue behaviour in dispute-coordinator ( #6275 )
...
* Change best effort queue behaviour in `dispute-coordinator`
Use the same type of queue (`BTreeMap<CandidateComparator,
ParticipationRequest>`) for best effort and priority in
`dispute-coordinator`.
Rework `CandidateComparator` to handle unavailable parent
block numbers.
Best effort queue will order disputes the same way as priority does - by
parent's block height. Disputes on candidates for which the parent's
block number can't be obtained will be treated with the lowest priority.
* Fix tests: Handle `ChainApiMessage::BlockNumber` in `handle_sync_queries`
* Some tests are deadlocking on sending messages via overseer so change `SingleItemSink`to `mpsc::Sender` with a buffer of 1
* Fix a race in test after adding a buffered queue for overseer messages
* Fix the rest of the tests
* Guide update - best-effort queue
* Guide update: clarification about spam votes
* Fix tests in `availability-distribution`
* Update comments
* Add `make_buffered_subsystem_context` in `subsystem-test-helpers`
* Code review feedback
* Code review feedback
* Code review feedback
* Don't add best effort candidate if it is already in priority queue
* Remove an old comment
* Fix insert in best_effort
2022-11-17 15:41:19 +00:00
ad41e56e6e
Dedup subsystem name ( #6305 )
...
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
2022-11-17 12:59:07 +00:00
a0f4287dd9
Provisioner should ignore unconfirmed disputes ( #6294 )
...
* Fix typos
* Filter unconfirmed disputes in provisioner - random_selection
* Rework dispute coordinator to return `DisputeStatus` with
`ActiveDisputes` message.
* Rework the random_selection implementation of `select_disptues` in
`provisioner` to return only confirmed disputes.
* Filter unconfirmed disputes in provisioner - prioritized_selection
* Add test for unconfirmed disputes handling
* Fix `dispute-distribution` tests
2022-11-16 14:39:05 +00:00
d53513ff66
Fixes "for loop over an Option" warnings ( #6291 )
...
Was seeing these warnings when running `cargo check --all`:
```
warning: for loop over an `Option`. This is more readably written as an `if let` statement
--> node/core/approval-voting/src/lib.rs:1147:21
|
1147 | for activated in update.activated {
| ^^^^^^^^^^^^^^^^
|
= note: `#[warn(for_loops_over_fallibles)]` on by default
help: to check pattern in a loop use `while let`
|
1147 | while let Some(activated) = update.activated {
| ~~~~~~~~~~~~~~~ ~~~
help: consider using `if let` to clear intent
|
1147 | if let Some(activated) = update.activated {
| ~~~~~~~~~~~~ ~~~
```
My guess is that `activated` used to be a SmallVec or similar, as is
`deactivated`. It was changed to an `Option`, the `for` still compiled (it's
technically correct, just weird), and the compiler didn't catch it until now.
2022-11-15 09:58:26 -05:00
8eb1f4617f
Use a more typesafe approach for managing indexed data ( #6150 )
...
* Fix for issue #2403
* Nightly fmt
* Quick documentation fixes
* Default Implementation
* iter() function integrated
* Implemented iter functionalities
* Fmt
* small change
* updates node-network
* updates in dispute-coordinator
* Updates
* benchmarking fix
* minor fix
* test fixes in runtime api
* Update primitives/src/v2/mod.rs
Co-authored-by: Andronik <write@reusable.software >
* Update primitives/src/v2/mod.rs
Co-authored-by: Andronik <write@reusable.software >
* Update primitives/src/v2/mod.rs
Co-authored-by: Andronik <write@reusable.software >
* Update primitives/src/v2/mod.rs
Co-authored-by: Andronik <write@reusable.software >
* Update primitives/src/v2/mod.rs
Co-authored-by: Andronik <write@reusable.software >
* Removal of [index], shorting of FromIterator, Renaming of GroupValidators to ValidatorGroups
* Removal of ops import
* documentation fixes for spell check
* implementation of generic type
* Refactoring
* Test and documentation fixes
* minor test fix
* minor test fix
* minor test fix
* Update node/network/statement-distribution/src/lib.rs
Co-authored-by: Andronik <write@reusable.software >
* Update primitives/src/v2/mod.rs
Co-authored-by: Andronik <write@reusable.software >
* Update primitives/src/v2/mod.rs
Co-authored-by: Andronik <write@reusable.software >
* removed IterMut
* Update node/core/dispute-coordinator/src/import.rs
Co-authored-by: Andronik <write@reusable.software >
* Update node/core/dispute-coordinator/src/initialized.rs
Co-authored-by: Andronik <write@reusable.software >
* Update primitives/src/v2/mod.rs
Co-authored-by: Andronik <write@reusable.software >
* fmt
* IterMut
* documentation update
Co-authored-by: Andronik <write@reusable.software >
* minor adjustments and new TypeIndex trait
* spelling fix
* TypeIndex fix
Co-authored-by: Andronik <write@reusable.software >
2022-10-22 08:39:11 +00:00
f8cc39a761
sync versions with current release (0.9.31) ( #6176 )
...
* Bump spec_version to 9310
* bump transaction_version (0.9.31) (#6171 )
* Bump transaction_version for polkadot
* Bump transaction_version for kusama
* Bump transaction_version for rococo
* Bump transaction_version for westend
* Bump transaction_version for polkadot
* Bump transaction_version for kusama
* Bump transaction_version for rococo
* Bump transaction_version for westend
* Bump crate versions (0.9.31)
2022-10-22 00:08:53 -04:00
befaec4cee
availability-recovery: use IfDisconnected::TryConnect for chunks ( #6081 )
...
* availability-recovery: use `IfDisconnected::TryConnect` for chunks
* fix tests
2022-10-18 13:15:49 +00:00
a7780e0797
refactor grid topology to expose more info to subsystems ( #6140 )
...
* refactor grid topology to expose more info to subsystems
* fix grid_topology test
* fix overseer test
* Update node/network/protocol/src/grid_topology.rs
Co-authored-by: Vsevolod Stakhov <vsevolod.stakhov@parity.io >
* Update node/network/protocol/src/grid_topology.rs
Co-authored-by: Andronik <write@reusable.software >
* Update node/network/protocol/src/grid_topology.rs
Co-authored-by: Andronik <write@reusable.software >
* fix bug in populating topology
* fmt
Co-authored-by: Vsevolod Stakhov <vsevolod.stakhov@parity.io >
Co-authored-by: Andronik <write@reusable.software >
2022-10-12 23:30:12 +00:00
4819d12711
Companion for paritytech/substrate#12441 ( #6117 )
...
* Companion for paritytech/substrate#12441
* update lockfile for {"substrate"}
Co-authored-by: parity-processbot <>
2022-10-10 11:13:59 +00:00
e4361b6d80
Fix flaky test ( #6131 )
...
* Split test + decrease test timeout
* fmt
* spellcheck
2022-10-10 08:06:44 +02:00
b13e07bc47
Buffered connection management for collator-protocol ( #6022 )
...
* Extract metrics into a separate module
* Introduce validators buffer
* Integrate buffer into the subsystem
* Only reconnect on new advertisements
* Test
* comma
* doc comment
* Make capacity buffer compile time non-zero
* Add doc comments
* nits
* remove derives
* review
* better naming
* check timeout
* Extract interval stream into lib
* Ensure collator disconnects after timeout
* spellcheck
* rename buf
* Remove double interval
* Add a log on timeout
* Cleanup buffer on timeout
2022-10-05 09:48:50 +02:00
938bc96a2c
Batch vote import in dispute-distribution ( #5894 )
...
* Start work on batching in dispute-distribution.
* Guide work.
* More guide changes. Still very much WIP.
* Finish guide changes.
* Clarification
* Adjust argument about slashing.
* WIP: Add constants to receiver.
* Maintain order of disputes.
* dispute-distribuion sender Rate limit.
* Cleanup
* WIP: dispute-distribution receiver.
- [ ] Rate limiting
- [ ] Batching
* WIP: Batching.
* fmt
* Update `PeerQueues` to maintain more invariants.
* WIP: Batching.
* Small cleanup
* Batching logic.
* Some integration work.
* Finish.
Missing: Tests
* Typo.
* Docs.
* Report missing metric.
* Doc pass.
* Tests for waiting_queue.
* Speed up some crypto by 10x.
* Fix redundant import.
* Add some tracing.
* Better sender rate limit
* Some tests.
* Tests
* Add logging to rate limiter
* Update roadmap/implementers-guide/src/node/disputes/dispute-distribution.md
Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io >
* Update roadmap/implementers-guide/src/node/disputes/dispute-distribution.md
Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io >
* Update node/network/dispute-distribution/src/receiver/mod.rs
Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io >
* Review feedback.
* Also log peer in log messages.
* Fix indentation.
* waker -> timer
* Guide improvement.
* Remove obsolete comment.
* waker -> timer
* Fix spell complaints.
* Fix Cargo.lock
Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io >
2022-10-04 18:02:05 +02:00
a64cc4a860
Bump lru from 0.7.8 to 0.8.0 ( #6060 )
...
* Bump lru from 0.7.8 to 0.8.0
Bumps [lru](https://github.com/jeromefroe/lru-rs ) from 0.7.8 to 0.8.0.
- [Release notes](https://github.com/jeromefroe/lru-rs/releases )
- [Changelog](https://github.com/jeromefroe/lru-rs/blob/master/CHANGELOG.md )
- [Commits](https://github.com/jeromefroe/lru-rs/compare/0.7.8...0.8.0 )
---
updated-dependencies:
- dependency-name: lru
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
* Change `LruCache` paramerter to `NonZeroUsize`
* Change type of `session_cache_lru_size` to `NonZeroUsize`
* Add expects instead of unwrap
Co-authored-by: Bastian Köcher <info@kchr.de >
* Use match to get rid of expects
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sebastian Kunert <skunert49@gmail.com >
Co-authored-by: Bastian Köcher <info@kchr.de >
2022-10-04 11:28:21 +00:00
372e6a95f3
add para_id to fetch_pov logging ( #6084 )
...
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
2022-09-30 11:56:45 +03:00
548b4c6c71
Validate chunks from disk in availability-recovery ( #6078 )
...
* Don't use corrupted chunks from disk.
Otherwise we would be going to dispute the candidate and get slashed.
* Add tests
2022-09-29 14:16:12 +02:00
Vsevolod Stakhov