2c77f8f4ca
Use sensible maths for from_rational ( #13660 )
...
* Use sensible maths for from_rational
* Fixes
* Fixes
* More fixes
* Remove debugging
* Add fuzzer tests
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Prevent panics
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* docs
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Clean up old code
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Test all rounding modes of from_rational
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Clean up code
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Revert "Prevent panics"
This reverts commit 7e88ac76138a1b590e68b68318505b69efe1e1f6.
* fix imports
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* cleanup
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fuzz test multiply_rational
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix import
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* fmt
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Return None in multiply_rational on zero div
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
---------
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
2023-03-24 14:48:37 +00:00
30122da07a
chain_head/tests: Check finalized block event before new block ( #13680 )
...
* chain_head/tests: Mock client for custom block notification
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io >
* chain_head/tests: Check finalized block event before new block
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io >
* Update client/rpc-spec-v2/src/chain_head/test_utils.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* Update client/rpc-spec-v2/src/chain_head/test_utils.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* Update client/rpc-spec-v2/src/chain_head/test_utils.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* chain_head/tests: Run import events with 10min timeout
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io >
* chain_head/tests: Add comments about test
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io >
---------
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io >
Co-authored-by: Bastian Köcher <git@kchr.de >
2023-03-23 15:40:02 +02:00
6c39bbf5d5
Update lockfile
...
The CI needs this.
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
2023-03-21 18:17:04 +01:00
77d8c522b6
Bump k256 from 0.11.6 to 0.13.0 ( #13624 )
...
Bumps [k256](https://github.com/RustCrypto/elliptic-curves ) from 0.11.6 to 0.13.0.
- [Release notes](https://github.com/RustCrypto/elliptic-curves/releases )
- [Commits](https://github.com/RustCrypto/elliptic-curves/compare/k256/v0.11.6...k256/v0.13.0 )
---
updated-dependencies:
- dependency-name: k256
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Davide Galassi <davxy@datawok.net >
2023-03-21 13:53:04 +00:00
87197b094f
Bump parity-db ( #13656 )
2023-03-21 10:45:40 +01:00
82cb69922f
contracts: Upgrade to wasmi 0.28 ( #13312 )
...
* Upgrade to wasmi 0.28
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_contracts
* Update stale comment
* Renamed variants of `Determinism`
* Compile fix
---------
Co-authored-by: command-bot <>
2023-03-20 23:09:22 +00:00
480396fe06
Keystore overhaul (iter 2) ( #13634 )
...
* Remove bloat about remote keystore
* Update docs and remove unused 'KeystoreRef' trait
* Use wherever possible, MemoryKeystore for testing
* Remove unrequired fully qualified method syntax for Keystore
2023-03-20 18:21:26 +00:00
1dd0dfb319
Bump hashbrown from 0.12.3 to 0.13.2 ( #13570 )
...
Bumps [hashbrown](https://github.com/rust-lang/hashbrown ) from 0.12.3 to 0.13.2.
- [Release notes](https://github.com/rust-lang/hashbrown/releases )
- [Changelog](https://github.com/rust-lang/hashbrown/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rust-lang/hashbrown/compare/v0.12.3...v0.13.2 )
---
updated-dependencies:
- dependency-name: hashbrown
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-03-20 12:27:43 +00:00
6c3747ba34
Bump trie-db to 0.27.1 (fix storage iteration bug + change seek behavior with prefix) ( #13630 )
2023-03-17 16:09:28 +00:00
bc2724f022
Bump grandpa to 0.16.2 ( #13622 )
2023-03-17 14:21:02 +01:00
f110941b7f
Keystore overhaul ( #13615 )
...
* Remove 'supported_keys' 'sign_with_any' and 'sign_with_all' from keystore trait
* Remove the aync keystore
* Renaming:
- SyncCryptoStore -> Keystore
- SyncCryptoStorePtr -> KeystorePtr
- KeyStore -> MemoryKeystore
* Fix authority discovery worker and tests
* Rename 'insert_unknown' to 'insert'
* Remove leftover
2023-03-17 11:24:14 +00:00
4ef1d0df02
sp-api: Support expanding the macro code ( #13573 )
...
* sp-api: Support expanding the macro code
This pr introduces the `expander` crate to expand the generated source code into a file. This gives
better error reporting when trying to fix issues in the macro itself as Rustc will point to the line
in this file. The feature can be enabled by setting `SP_API_EXPAND=1` at compile time.
Besides that the generated code is changed to fix warnings in the exanped version.
* Fixes
2023-03-14 22:14:58 +01:00
ef165cec3e
update trie deps ( #13601 )
2023-03-14 21:03:50 +00:00
9ced14e2de
Move code from sc-network-common back to sc-network ( #13592 )
...
* Move service tests to `client/network/tests`
These tests depend on `sc-network` and `sc-network-sync` so they should
live outside the crate.
* Move some configs from `sc-network-common` to `sc-network`
* Move `NetworkService` traits to `sc-network`
* Move request-responses to `sc-network`
* Remove more stuff
* Remove rest of configs from `sc-network-common` to `sc-network`
* Remove more stuff
* Fix warnings
* Update client/network/src/request_responses.rs
Co-authored-by: Dmitry Markin <dmitry@markin.tech >
* Fix cargo doc
---------
Co-authored-by: Dmitry Markin <dmitry@markin.tech >
2023-03-14 12:06:40 +00:00
4ad1ad2c60
Logic for the (Core) Fellowship ( #13503 )
...
* More drafting
* Paymaster pallet
* Fix build
* More tests
* Rename
* Rename
* Renaming
* Revert old changes
* Multi-phase payouts to avoid bank-runs
* Tests
* Tests
* Allow payment to be targeted elsewhere
* Proper ssync payment failure handling
* Test for repayment
* Docs
* Impl RankedMembers for RankedCollective
* Implement Pay for Pot (i.e. basic account).
* Benchmarks
* Weights
* Introduce Salary benchmark into node
* Fix warning
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_salary
* Update primitives/arithmetic/src/traits.rs
Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com >
* Update frame/salary/src/lib.rs
Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com >
* Update lib.rs
* Update frame/salary/src/lib.rs
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
* Docs
* Update frame/salary/src/lib.rs
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
* Update frame/salary/src/lib.rs
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
* Fix
* Fixes
* Fixes
* Move some salary traits stuff to a shared location
* Initial draft
* Comment out bits
* Fix
* First couple of tests
* One more test
* Update frame/salary/src/lib.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update frame/salary/src/lib.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Mul floor
* Tests
* Mul floor
* Fix warnings
* Fix test
* Tests
* Last tests
* Docs
* Fix warnings
* Benchmarks
* Weights
* Integrate benchmark
* Fixes
* Fix
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_core_fellowship
* Better process flow
* Fix benchmarks & tests
* Docs
* Fixes
* Fixes
* docs
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_core_fellowship
* Docs and allow custom evidence size
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_core_fellowship
* Update frame/core-fellowship/src/lib.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* Update frame/core-fellowship/src/tests.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* Update frame/core-fellowship/src/benchmarking.rs
* Update frame/core-fellowship/src/benchmarking.rs
* Apply suggestions from code review
* Rename
* Update primitives/arithmetic/src/traits.rs
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
* Reduce magic numbers
* Update frame/core-fellowship/src/lib.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update frame/core-fellowship/src/lib.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Benchmark result
* Remove dependency
* set_params should pay
* induct should pay
* Remove some other free calls
---------
Co-authored-by: command-bot <>
Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com >
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
2023-03-11 13:11:15 +01:00
57ba9232eb
Undeploy insecure randomness pallet ( #13560 )
...
* Undeploy insecure randomness pallet from node-template
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update lockfile
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Remove from runtime
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
---------
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
2023-03-09 12:29:03 +00:00
16fc65dc1c
Bump wasmtime from 6.0.0 to 6.0.1 ( #13566 )
...
Bumps [wasmtime](https://github.com/bytecodealliance/wasmtime ) from 6.0.0 to 6.0.1.
- [Release notes](https://github.com/bytecodealliance/wasmtime/releases )
- [Changelog](https://github.com/bytecodealliance/wasmtime/blob/main/docs/WASI-some-possible-changes.md )
- [Commits](https://github.com/bytecodealliance/wasmtime/compare/v6.0.0...v6.0.1 )
---
updated-dependencies:
- dependency-name: wasmtime
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-03-09 07:08:00 +00:00
03158cd48f
Switch to the blake2b_simd crate in sp-core-hashing ( #13548 )
...
* Switch to the `blake2b_simd` crate in `sp-core-hashing`
* ".git/.scripts/commands/bench/bench.sh" pallet dev frame_benchmarking
---------
Co-authored-by: command-bot <>
2023-03-07 08:57:16 +00:00
3118026576
Make unbounded channels size warning exact (part 2) ( #13504 )
2023-03-07 10:57:26 +03:00
1a7f5be07f
Extract syncing protocol from sc-network ( #12828 )
...
* Move import queue out of `sc-network`
Add supplementary asynchronous API for the import queue which means
it can be run as an independent task and communicated with through
the `ImportQueueService`.
This commit removes removes block and justification imports from
`sc-network` and provides `ChainSync` with a handle to import queue so
it can import blocks and justifications. Polling of the import queue is
moved complete out of `sc-network` and `sc_consensus::Link` is
implemented for `ChainSyncInterfaceHandled` so the import queue
can still influence the syncing process.
* Move stuff to SyncingEngine
* Move `ChainSync` instanation to `SyncingEngine`
Some of the tests have to be rewritten
* Move peer hashmap to `SyncingEngine`
* Let `SyncingEngine` to implement `ChainSyncInterface`
* Introduce `SyncStatusProvider`
* Move `sync_peer_(connected|disconnected)` to `SyncingEngine`
* Implement `SyncEventStream`
Remove `SyncConnected`/`SyncDisconnected` events from
`NetworkEvenStream` and provide those events through
`ChainSyncInterface` instead.
Modify BEEFY/GRANDPA/transactions protocol and `NetworkGossip` to take
`SyncEventStream` object which they listen to for incoming sync peer
events.
* Introduce `ChainSyncInterface`
This interface provides a set of miscellaneous functions that other
subsystems can use to query, for example, the syncing status.
* Move event stream polling to `SyncingEngine`
Subscribe to `NetworkStreamEvent` and poll the incoming notifications
and substream events from `SyncingEngine`.
The code needs refactoring.
* Make `SyncingEngine` into an asynchronous runner
This commits removes the last hard dependency of syncing from
`sc-network` meaning the protocol now lives completely outside of
`sc-network`, ignoring the hardcoded peerset entry which will be
addressed in the future.
Code needs a lot of refactoring.
* Fix warnings
* Code refactoring
* Use `SyncingService` for BEEFY
* Use `SyncingService` for GRANDPA
* Remove call delegation from `NetworkService`
* Remove `ChainSyncService`
* Remove `ChainSync` service tests
They were written for the sole purpose of verifying that `NetworWorker`
continues to function while the calls are being dispatched to
`ChainSync`.
* Refactor code
* Refactor code
* Update client/finality-grandpa/src/communication/tests.rs
Co-authored-by: Anton <anton.kalyaev@gmail.com >
* Fix warnings
* Apply review comments
* Fix docs
* Fix test
* cargo-fmt
* Update client/network/sync/src/engine.rs
Co-authored-by: Anton <anton.kalyaev@gmail.com >
* Update client/network/sync/src/engine.rs
Co-authored-by: Anton <anton.kalyaev@gmail.com >
* Add missing docs
* Refactor code
---------
Co-authored-by: Anton <anton.kalyaev@gmail.com >
2023-03-06 16:33:38 +00:00
9b9964394e
chore: reduce copy times for bytes in core-hashing ( #13519 )
...
* chore: reduce copy bytes for core-hashing
* improve by suggestions and remove unused `xx_into`
* chore: replace sha2 crate by `sp_core::hashing` for pallet-alliance
* fix features
* use sp-core-hashing directly
* add to dev-dep
2023-03-06 14:09:07 +00:00
f85d6dc6dd
[contracts] Forbid calling back to contracts after switching to runtime ( #13443 )
...
* save: compiles and tests pass
* save: added global
* done + test
* cleanup
* changelog update
* cleanup
* address feedback, step 1
* address feedback, step 2
* address feedback, step 3
* returned updated gas_estimation_call_runtime test
* clippy fix
* address feedback, step 4
* address feedback, step 5
* move data from context to inputs
* docs fix
* Apply suggestions from code review
Co-authored-by: Alexander Theißen <alex.theissen@me.com >
* address feedback, step 6
---------
Co-authored-by: Alexander Theißen <alex.theissen@me.com >
2023-03-06 08:40:03 +00:00
e4bf9f2125
Salary pallet ( #13378 )
...
* More drafting
* Paymaster pallet
* Fix build
* More tests
* Rename
* Rename
* Renaming
* Revert old changes
* Multi-phase payouts to avoid bank-runs
* Tests
* Tests
* Allow payment to be targeted elsewhere
* Proper ssync payment failure handling
* Test for repayment
* Docs
* Impl RankedMembers for RankedCollective
* Implement Pay for Pot (i.e. basic account).
* Benchmarks
* Weights
* Introduce Salary benchmark into node
* Fix warning
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_salary
* Update primitives/arithmetic/src/traits.rs
Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com >
* Update frame/salary/src/lib.rs
Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com >
* Update lib.rs
* Update frame/salary/src/lib.rs
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
* Docs
* Update frame/salary/src/lib.rs
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
* Update frame/salary/src/lib.rs
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
* Fix
* Fixes
* Fixes
* Move some salary traits stuff to a shared location
* Fix
* Update frame/salary/src/lib.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update frame/salary/src/lib.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Mul floor
* Fix warnings
* Fix test
* Docs
---------
Co-authored-by: command-bot <>
Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com >
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
2023-03-03 19:05:01 +00:00
ac4a23609c
Bump parity-db ( #13521 )
2023-03-03 17:16:59 +00:00
b29584d93a
sp-consensus: remove unused error variants ( #13495 )
2023-03-01 13:04:57 +00:00
ad410738e7
Make unbounded channels size warning exact (part 1) ( #13490 )
...
* Replace `futures-channel` with `async-channel` in `out_events`
* Apply suggestions from code review
Co-authored-by: Koute <koute@users.noreply.github.com >
* Also print the backtrace of `send()` call
* Switch from `backtrace` crate to `std::backtrace`
* Remove outdated `backtrace` dependency
* Remove `backtrace` from `Cargo.lock`
---------
Co-authored-by: Koute <koute@users.noreply.github.com >
2023-03-01 09:54:31 +00:00
55263fa2a1
Speed up storage iteration from within the runtime ( #13479 )
...
* Speed up storage iteration from within the runtime
* Move the cached iterator into an `Option`
* Use `RefCell` in no_std
* Simplify the code slightly
* Use `Option::replace`
* Update doc comment for `next_storage_key_slow`
2023-03-01 08:58:18 +00:00
20bf3c938e
chore: move genesis block builder to chain-spec crate. ( #13427 )
...
* chore: move genesis block builder to block builder crate.
* add missing file
* chore: move genesis block builder to sc-chain-spec
* Update client/chain-spec/src/genesis.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* Update test-utils/runtime/src/genesismap.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* Update test-utils/runtime/client/src/lib.rs
* fix warnings
* fix warnings
---------
Co-authored-by: Bastian Köcher <git@kchr.de >
2023-02-28 20:50:57 +01:00
1ef9c473e7
Move BEEFY code to consensus ( #13484 )
...
* Move beefy primitives to consensus dir
* Move beefy gadget to client consensus folder
* Rename beefy crates
2023-02-28 15:56:22 +01:00
a1c546e9aa
Add Windows support for storage monitor ( #13466 )
...
* Add Windows support for storage monitor
* Apply suggested changes
2023-02-27 20:26:38 +00:00
6aa4127a74
pallet-treasury: Ensure we respect max_amount for spend across batch calls (#13468 )
...
* `pallet-treasury`: Ensure we respect `max_amount` for spend across batch calls
When calling `spend` the origin defines the `max_amount` of tokens it is allowed to spend. The
problem is that someone can send a `batch(spend, spend)` to circumvent this restriction as we don't
check across different calls that the `max_amount` is respected. This pull request fixes this
behavior by introducing a so-called dispatch context. This dispatch context is created once per
outer most `dispatch` call. For more information see the docs in this pr. The treasury then uses
this dispatch context to attach information about already spent funds per `max_amount` (we assume
that each origin has a different `max_amount` configured). So, a `batch(spend, spend)` is now
checked to stay inside the allowed spending bounds.
Fixes: https://github.com/paritytech/substrate/issues/13167
* Import `Box` for wasm
* FMT
2023-02-27 17:49:16 +00:00
40c36c0c8a
Move grandpa crates to consensus folder ( #13458 )
...
* Move grandpa under consensus dir
* Rename grandpa folder
* Finish grandpa renaming
* Minor tweaks
* Cargo fmt
* Adjust path to chain spec
2023-02-27 17:15:08 +01:00
941288c6d0
wasm-executor: Support growing the memory ( #12520 )
...
* As always, start with something :P
* Add support for max_heap_pages
* Add support for wasmtime
* Make it compile
* Fix compilation
* Copy wrongly merged code
* Fix compilation
* Some fixes
* Fix
* Get stuff working
* More work
* More fixes
* ...
* More
* FIXEs
* Switch wasmi to use `RuntimeBlob` like wasmtime
* Removed unused stuff
* Cleanup
* More cleanups
* Introduce `CallContext`
* Fixes
* More fixes
* Add builder for creating the `WasmExecutor`
* Adds some docs
* FMT
* First round of feedback.
* Review feedback round 2
* More fixes
* Fix try-runtime
* Update client/executor/wasmtime/src/instance_wrapper.rs
Co-authored-by: Koute <koute@users.noreply.github.com >
* Update client/executor/common/src/wasm_runtime.rs
Co-authored-by: Koute <koute@users.noreply.github.com >
* Update client/executor/common/src/runtime_blob/runtime_blob.rs
Co-authored-by: Koute <koute@users.noreply.github.com >
* Update client/executor/common/src/wasm_runtime.rs
Co-authored-by: Koute <koute@users.noreply.github.com >
* Update client/allocator/src/freeing_bump.rs
Co-authored-by: Koute <koute@users.noreply.github.com >
* Update client/allocator/src/freeing_bump.rs
Co-authored-by: Koute <koute@users.noreply.github.com >
* Feedback round 3
* FMT
* Review comments
---------
Co-authored-by: Koute <koute@users.noreply.github.com >
2023-02-24 11:43:01 +00:00
c848d40775
Revert "Abstracts elections-phragmen pallet to use NposSolver ( #12588 )" ( #13451 )
...
This reverts commit b793666ca5
2023-02-23 12:15:08 -06:00
4af011f418
Nfts attribute read interface ( #13349 )
...
* feat: add custom and system attributes to Inspect
* feat: add nfts runtime api
* fix: pass std feature to runtime api
* fix: api copyright
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
---------
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
2023-02-23 15:06:12 +00:00
b793666ca5
Abstracts elections-phragmen pallet to use NposSolver ( #12588 )
...
* Abstracts elections-phragmen pallet to use NposSolver
* Update frame/elections-phragmen/src/lib.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* Update frame/elections-phragmen/src/lib.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* changes the name of the pallet; adds changelog
* update changelog
* Adds weight testing
* Adds log macro_rules
* renames elections-phragment dir to elections
* weights rename
* fixes typo in cargo toml
* pre/post solve weight scafolding
* refactor do_post_election
* refactors into pre and post election solve for independent benchmarking
* deconstructs PreElectionResults struct
* updates benchmarking pre and post election solve; mock weights
* Update frame/elections/src/lib.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* Update frame/elections/src/lib.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* addresses PR comments
* adds pre_solve and post_sove weights
* Adds comments on election pallet id param name change
* ".git/.scripts/bench-bot.sh" pallet dev pallet_elections
* Finishes pre-post solve weights
* Update frame/elections/src/lib.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* Update frame/elections/src/lib.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* Addresses PR comments: no panic in on_init path; nits
* Fixes node build
* Implements approval voting to use as a `NposSolver` (#13367 )
* Implements the approval voting methods in sp_npos_elections
* fmt
* remove unecessary file
* comment clarification
* re-run weights
* fix typo
* updates MaxVoters in tests for integrity_tests to pass
* Refactors election provider support benchmarks outside its own crate (#13431 )
* Refactors election provider support benchmarks outside its own crate
---------
Co-authored-by: command-bot <>
---------
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
Co-authored-by: parity-processbot <>
Co-authored-by: Ross Bulat <ross@parity.io >
2023-02-23 11:21:00 +00:00
17e055e594
Bump wasmtime to 6.0.0 ( #13429 )
...
* Bump `wasmtime` to 6.0.0
* Disable cranelift egraphs
2023-02-23 10:56:11 +00:00
f8e3bdad3d
Rework storage iterators ( #13284 )
...
* Rework storage iterators
* Make sure storage iteration is also accounted for when benchmarking
* Use `trie-db` from crates.io
* Appease clippy
* Bump `trie-bench` to 0.35.0
* Fix tests' compilation
* Update comment to clarify how `IterArgs::start_at` works
* Add extra tests
* Fix iterators on `Client` so that they behave as before
* Add extra `unwrap`s in tests
* More clippy fixes
* Come on clippy, give me a break already
* Rename `allow_missing` to `stop_on_incomplete_database`
* Add `#[inline]` to `with_recorder_and_cache`
* Use `with_recorder_and_cache` in `with_trie_db`; add doc comment
* Simplify code: use `with_trie_db` in `next_storage_key_from_root`
* Remove `expect`s in the benchmarking CLI
* Add extra doc comments
* Move `RawIter` before `TrieBackendEssence` (no code changes; just cut-paste)
* Remove a TODO in tests
* Update comment for `StorageIterator::was_complete`
* Update `trie-db` to 0.25.1
2023-02-22 07:49:25 +00:00
d5beaa5542
Glutton pallet ( #12833 )
...
* Pov-Limit pallet
* use Perbill & fixes
* fixes
* reads & writes
* update docs
* tests
* calculate weight
* fmt
* benchmark
* logic fix
* naming fix
* caclulate computation weight limit
* make the Hasher generic
* make the code compile
* generate weight
* fix on_idle
* fix
* fix
* make reading generic
* fix?
* fixes
* remove warning
* fix
* hasher fix :D
* change value
* test
* actual weight and expected weight are the same
* update
* fix
* add events
* remove useless line
* using actual hashing algorithm
* better readability
* fix nits
* Update
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* add migration
* hardcode proof_size in weights.rs
* format
* fixes
* Fix weight
* docs
* fix
* Update frame/pov-limit/src/lib.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* Update frame/pov-limit/src/lib.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* empty on_ilde & update weight.rs
* remove migration & fix benchmark
* remove migration from migrations
* initialize_pallet
* use blake2
* Update frame/pov-limit/Cargo.toml
Co-authored-by: Bastian Köcher <git@kchr.de >
* Update frame/pov-limit/src/lib.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* Update frame/pov-limit/Cargo.toml
Co-authored-by: Bastian Köcher <git@kchr.de >
* rename pallet
* make the wasters non-generic
* rename to glutton
* fix
* small fixes & run benchmark
* increase left over ref-time in tests
* Update frame/glutton/src/lib.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* or values
* fix
* generate weight
* Update frame/glutton/Cargo.toml
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* fix nits
* Adjustments
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fixes
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* fix
* Update weights
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Tweak constants
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update weights
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* remove genesis config
* passing tests
* More precise results
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* update node-executor test
* Calculate number of iterations in advance
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* increase criteria
* Final fixes
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update frame/glutton/src/tests.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* Update frame/glutton/src/lib.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* Update frame/glutton/src/lib.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* fix typos
* Update frame/glutton/src/lib.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* Update frame/glutton/src/lib.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* expand/shrink
* fmt
* Revert "Update frame/glutton/src/lib.rs"
This reverts commit 98a237afd27de3deb15ba381871e12f71a9d71b1.
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Use CountedStorageMap
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add benchmark
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Use manual map counter
Something with the R/W count in the benchmarking result did not add
up. Need to investigate but for now just using a manual counter.
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Use new template
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Doc+typos
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_glutton
* Apply suggestions from code review
Co-authored-by: Koute <koute@users.noreply.github.com >
* Add minimal README
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_glutton
---------
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: Bastian Köcher <git@kchr.de >
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
Co-authored-by: command-bot <>
Co-authored-by: Koute <koute@users.noreply.github.com >
2023-02-21 22:39:27 +00:00
2f1ec07953
Staking and nomination pools runtime API improvements ( #13119 )
...
* Adds StakingAPI_nominations_quota and NominationPoolsApi_balanceToPoint and NominationPoolsApi_pointsToBalance runtime APIs
* Adds balance param to api_nominations_quota
* Update frame/nomination-pools/src/lib.rs
Co-authored-by: Anton <anton.kalyaev@gmail.com >
* Update frame/nomination-pools/src/lib.rs
Co-authored-by: Anton <anton.kalyaev@gmail.com >
* Addresses comments - returns zero instead of error in runtime api
* Update frame/staking/runtime-api/src/lib.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* Update frame/staking/runtime-api/src/lib.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* Addresses PR comments
* Update frame/nomination-pools/runtime-api/Cargo.toml
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* Fixes points_to_balance logic; adds tests
* test comment fix
* Update frame/nomination-pools/runtime-api/src/lib.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* Update frame/nomination-pools/runtime-api/src/lib.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* Fix block pruning (#13323 )
* Referendum proposal's metadata (#12568 )
* referenda metadata
* todo comment
* remove TODO, update rustdocs
* referenda clear_metadata origin signed or root
* referenda metadata unit tests
* drop schema type for referenda metadata
* remove metadata type
* referenda metadata benches
* note different preimages
* metadata for democracy pallet
* metadata democracy pallet tests and benches
* fix cargo clippy
* update docs
* ".git/.scripts/bench-bot.sh" pallet dev pallet_democracy
* ".git/.scripts/bench-bot.sh" pallet dev pallet_referenda
* Update the doc frame/democracy/src/lib.rs
Co-authored-by: Roman Useinov <roman.useinov@gmail.com >
* Update the doc frame/democracy/src/lib.rs
Co-authored-by: Anthony Alaribe <anthonyalaribe@gmail.com >
* reference instead clone for take
Co-authored-by: Anthony Alaribe <anthonyalaribe@gmail.com >
* error rename BadMetadata to PreimageNotExist
* clear metadata within internal_cancel_referendum fn
* remove redundant clone
* collapse metadata api into one set_metadata method
* fmt
* review fixes
* not request preimage on set_metadata
* rename events and update docs
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_democracy
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_referenda
* rename reset_metadata to transfer_metadata
---------
Co-authored-by: command-bot <>
Co-authored-by: Roman Useinov <roman.useinov@gmail.com >
Co-authored-by: Anthony Alaribe <anthonyalaribe@gmail.com >
* Improve test coverage of the `Notifications` protocol (#13033 )
* Add handler and upgrade tests
* Add tests for `behaviour.rs`
* Apply review comments
* Update dependencies
* Apply suggestions from code review
Co-authored-by: Dmitry Markin <dmitry@markin.tech >
* Apply review comments
* Fix clippy
* Update mockall
* Apply review comment
---------
Co-authored-by: Dmitry Markin <dmitry@markin.tech >
* refactors runtime API logic to own pallet impl block
* removes unrelated changes
* Fixes cargo doc comments lint
* fixes node cargo
* fixes comment
* restart ci
* restart ci
* restart ci
---------
Co-authored-by: Anton <anton.kalyaev@gmail.com >
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
Co-authored-by: parity-processbot <>
Co-authored-by: Arkadiy Paronyan <arkady.paronyan@gmail.com >
Co-authored-by: Muharem Ismailov <ismailov.m.h@gmail.com >
Co-authored-by: Roman Useinov <roman.useinov@gmail.com >
Co-authored-by: Anthony Alaribe <anthonyalaribe@gmail.com >
Co-authored-by: Aaro Altonen <48052676+altonen@users.noreply.github.com >
Co-authored-by: Dmitry Markin <dmitry@markin.tech >
2023-02-21 11:17:01 +00:00
3595d87182
try-runtime::fast-forward (#12896 )
...
* try-runtime::fast-forward
* Revert un`pub`ing command's fields
* Handle storage change failure
* Adjust Substrate node
* Feature-gated imports
* doc link
* Feature-gated imports in node-template
* Move trait, blanket implementation and auxiliary functions to a new module
* Distinguish between plain babe+timestamp and substrate enhanced info
* Remove uncles inherents
* Missing argument
* Add doc comment about `blocktime_millis`
* Add licenses
2023-02-17 12:21:58 +00:00
c21f292a02
BEEFY: implement equivocations detection, reporting and slashing ( #13121 )
...
* client/beefy: simplify self_vote logic
* client/beefy: migrate to new state version
* client/beefy: detect equivocated votes
* fix typos
* sp-beefy: add equivocation primitives
* client/beefy: refactor vote processing
* fix version migration for new rounds struct
* client/beefy: track equivocations and create proofs
* client/beefy: adjust tests for new voting logic
* sp-beefy: fix commitment ordering and equality
* client/beefy: simplify handle_vote() a bit
* client/beefy: add simple equivocation test
* client/beefy: submit equivocation proof - WIP
* frame/beefy: add equivocation report runtime api - part 1
* frame/beefy: report equivocation logic - part 2
* frame/beefy: add pluggable Equivocation handler - part 3
* frame/beefy: impl ValidateUnsigned for equivocations reporting
* client/beefy: submit report equivocation unsigned extrinsic
* primitives/beefy: fix tests
* frame/beefy: add default weights
* frame/beefy: fix tests
* client/beefy: fix tests
* frame/beefy-mmr: fix tests
* frame/beefy: cross-check session index with equivocation report
* sp-beefy: make test Keyring useable in pallet
* frame/beefy: add basic equivocation test
* frame/beefy: test verify equivocation results in slashing
* frame/beefy: test report_equivocation_old_set
* frame/beefy: add more equivocation tests
* sp-beefy: fix docs
* beefy: simplify equivocations and fix tests
* client/beefy: address review comments
* frame/beefy: add ValidateUnsigned to test/mock runtime
* client/beefy: fixes after merge master
* fix missed merge damage
* client/beefy: add test for reporting equivocations
Also validated there's no unexpected equivocations reported in the
other tests.
Signed-off-by: acatangiu <adrian@parity.io >
* sp-beefy: move test utils to their own file
* client/beefy: add negative test for equivocation reports
* sp-beefy: move back MmrRootProvider - used in polkadot-service
* impl review suggestions
* client/beefy: add equivocation metrics
---------
Signed-off-by: acatangiu <adrian@parity.io >
Co-authored-by: parity-processbot <>
2023-02-17 09:45:00 +00:00
53b7778599
[contracts] make debug_message execution outcome invariant to node debug logging setting ( #13197 )
...
* update benchmark for seal_debug_message
* add seal_debug_message_per_kb benchmark
* un-fallable debug buffer: silently drops excessive and wrong utf-8 encoded messages
* charge debug_message per byte of the message
* improved benchmark
* cap debug_message
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_contracts
* Apply suggestions from code review
Co-authored-by: Alexander Theißen <alex.theissen@me.com >
* fix applied buggy suggestion
* make sure i*1024 < MaxDebugBufferLen
* fix schedule for our non-batched benchmark
* Switch to a `wasmtime` fork with LTO linking failure workaround
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_contracts
---------
Co-authored-by: command-bot <>
Co-authored-by: Alexander Theißen <alex.theissen@me.com >
Co-authored-by: Jan Bujak <jan@parity.io >
2023-02-14 18:28:34 +00:00
3b767e1238
[NFTs] Offchain mint ( #13158 )
...
* Allow to mint with the pre-signed signatures
* Another try
* WIP: test encoder
* Fix the deposits
* Refactoring + tests + benchmarks
* Add sp-core/runtime-benchmarks
* Remove sp-core from dev deps
* Enable full_crypto for benchmarks
* Typo
* Fix
* Update frame/nfts/src/mock.rs
Co-authored-by: Squirrel <gilescope@gmail.com >
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_nfts
* Add docs
* Add attributes into the pre-signed object & track the deposit owner for attributes
* Update docs
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_nfts
* Add the number of attributes provided to weights
* Apply suggestions
* Remove dead code
* Remove Copy
* Fix docs
* Update frame/nfts/src/lib.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update frame/nfts/src/lib.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
---------
Co-authored-by: Squirrel <gilescope@gmail.com >
Co-authored-by: command-bot <>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
2023-02-14 08:19:50 +00:00
eeb3e95701
subkey: only decode hex if requested, CLI 0x prefixed hex for all stdout ( #13258 )
...
* Only decode hex if requested
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Cleanup code
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add some tests
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add license
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Docs
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Clippy
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* bump version, breaking (tiny) change in output.
* Move integration tests to own folder
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
---------
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: Dan Shields <nukemandan@protonmail.com >
2023-02-13 16:09:34 +00:00
2f3f7d6b07
Improve test coverage of the Notifications protocol ( #13033 )
...
* Add handler and upgrade tests
* Add tests for `behaviour.rs`
* Apply review comments
* Update dependencies
* Apply suggestions from code review
Co-authored-by: Dmitry Markin <dmitry@markin.tech >
* Apply review comments
* Fix clippy
* Update mockall
* Apply review comment
---------
Co-authored-by: Dmitry Markin <dmitry@markin.tech >
2023-02-08 09:04:02 +00:00
fc2fda8d19
Rename pallet-random-collective-flip to Insecure... ( #13301 )
...
* Rename pallet-random-collective-flip to Insecure...
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* fmt
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
---------
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
2023-02-06 18:12:06 +00:00
44cbf303c4
Bump wasmtime to 5.0.0 (and a few other deps) ( #13160 )
...
* Bump `wasmtime` to 4.0.0 (and a few other deps)
* Use `Error::msg` instead of `anyhow!`
* Bump `wasmtime` to 5.0.0
* Update `Cargo.lock`
* Add `wasmtime` feature to `sp-wasm-interface` dependency
2023-02-06 15:40:50 +00:00
8851bbb0f0
BEEFY: client support for detecting equivocated votes ( #13285 )
...
* client/beefy: detect equivocated votes
* client/beefy: make sure to persist state after voting
* client/beefy: drop never-used aux-schema v2 migration
* impl review suggestion
---------
Signed-off-by: Adrian Catangiu <adrian@parity.io >
2023-02-06 14:42:54 +02:00
294726874c
update linregress in frame-benchmarking to 0.5.1 ( #13310 )
...
* update nalgebra in frame-benchmarking to 0.5.0
* upgrade to 0.5.1 to incorporate upstream fix in linregress
2023-02-05 20:18:56 +00:00
Gavin Wood