12 Commits

Author	SHA1	Message	Date
Bastian Köcher	4975521d48	Notify collators about seconded collation (#2430) ... * Notify collators about seconded collation This pr adds functionality to inform a collator that its collation was seconded by a parachain validator. Before this signed statement was only gossiped over the validation substream. Now, we explicitly send the seconded statement to the collator after it was validated successfully. Besides that it changes the `CollatorFn` to return an optional result sender that is informed when the build collation was seconded by a parachain validator. * Add test * Make sure we only send `Seconded` statements * Make sure we only receive valid statements * Review feedback	2021-02-14 17:36:04 +01:00
Sergei Shulepov	226af6a877	Remove TransientValidationData (#2272) ... * collation-generation: use persisted validation data * node: remote FullValidationData API * runtime: remove FullValidationData API * backing tests: use persisted validation data * FullCandidateReceipt: use persisted validation data This is not a big change since this type is not used anywhere * Remove ValidationData and TransientValidationData Also update the guide	2021-01-18 18:57:09 -05:00
Sergei Shulepov	2026228b77	Cleanups (#1933) ... * Introduce CollatorFn type alias * Make test-runtime imports consistent with rococo-runtime * Update node/primitives/src/lib.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * fix warnings Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>	2020-11-09 14:21:05 +00:00
Sergei Shulepov	e0336626ae	let go fees (#1867)	2020-10-28 13:11:06 +01:00
Bastian Köcher	2b798f8571	Use Pin<Box<>> for collation future (#1792)	2020-10-07 11:29:00 +00:00
Bastian Köcher	325c24580e	Pass relay parent as argument when collating (#1789) ... This pr changes the collation function to also pass the current relay parent the parachain block should be build on.	2020-10-06 18:37:19 +00:00
Bastian Köcher	a4662104db	Make collation an optional return (#1787) ... This pr changes the collator interface function to return an optional collation instead of a collation. This is required as the parachain itself can fail to generate a valid collation for various reason. Now if the collation fails it will return `None`. Besides that the pr adds some `RuntimeDebug` derive for `ValidationData` and removes some whitespaces.	2020-10-06 11:57:10 +02:00
Sergei Shulepov	796de5f3e3	collation-generation: guide and tidying (#1753) ... * Guide: Change for {Global,Local}ValidationData to ValidationData Seems like that was missed during the transition from notions of global and local validation data to persistent and transient * collation-generation: a small drive-by fix of line length * collation-generation: extract an error module this allows us to avoid piling Error and Result types from different contexts, specifically std vs. module-local * collation-generation: extract LOG_TARGET from log statements	2020-09-25 16:33:10 +00:00
Peter Goodspeed-Niklaus	54bec3bfc0	implement collation generation subsystem (#1557) ... * start sketching out a collation generation subsystem * invent a basic strategy for double initialization * clean up warnings * impl util requests from runtime assuming a context instead of a FromJob sender * implement collation generation algorithm from guide * update AllMessages in tests * fix trivial review comments * remove another redundant declaration from merge * filter availability cores by para_id * handle new activations each in their own async task * update guide according to the actual current implementation * add initialization to guide * add general-purpose subsystem_test_harness helper * write first handle_new_activations test * add test that handle_new_activations filters local_validation_data requests * add (failing) test of collation distribution message sending * rustfmt * broken: work on fixing sender test Unfortunately, for reasons that are not yet clear, despite the public key and checked data being identical, the signer is not producing an identical signature. This commit produces this output (among more): signing with Public(c4733ab0bbe3ba4c096685d1737a7f498cdbdd167a767d04a21dc7df12b8c858 (5GWHUNm5...)) checking with Public(c4733ab0bbe3ba4c096685d1737a7f498cdbdd167a767d04a21dc7df12b8c858 (5GWHUNm5...)) signed payload: [4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 10, 0, 0, 0, c7, e5, c0, 64, 7a, db, fe, 44, 81, e5, 51, 11, 79, 9f, a5, 63, 93, 94, 3c, c4, 36, c6, 30, 36, c2, c5, 44, a2, 1b, db, b7, 82, 3, 17, a, 2e, 75, 97, b7, b7, e3, d8, 4c, 5, 39, 1d, 13, 9a, 62, b1, 57, e7, 87, 86, d8, c0, 82, f2, 9d, cf, 4c, 11, 13, 14] checked payload: [4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 10, 0, 0, 0, c7, e5, c0, 64, 7a, db, fe, 44, 81, e5, 51, 11, 79, 9f, a5, 63, 93, 94, 3c, c4, 36, c6, 30, 36, c2, c5, 44, a2, 1b, db, b7, 82, 3, 17, a, 2e, 75, 97, b7, b7, e3, d8, 4c, 5, 39, 1d, 13, 9a, 62, b1, 57, e7, 87, 86, d8, c0, 82, f2, 9d, cf, 4c, 11, 13, 14] * fix broken test * collation function returns commitments hash It doesn't look like we use the actual commitments data anywhere, and it's not obvious if there are any fields of `CandidateCommitments` not available to the collator, so this commit just assigns them the entire responsibility of generating the hash. * add missing overseer impls * calculating erasure coding is polkadot's responsibility, not cumulus * concurrentize per-relay_parent requests	2020-08-17 14:27:37 +02:00
Robert Habermeier	2a96c19370	guide: validation data refactoring (#1576) ... * guide: validation data refactoring * address grumbles from review * Update roadmap/implementers-guide/src/types/candidate.md Co-authored-by: Bernhard Schuster <bernhard@ahoi.io> * last comments from review Co-authored-by: Sergei Shulepov <sergei@parity.io> Co-authored-by: Bernhard Schuster <bernhard@ahoi.io>	2020-08-13 14:22:13 +00:00
Robert Habermeier	490f80d8c7	guide: collator networking & subsystems (#1452) ... * Do a small write-up on collation-generation * preamble to collator protocol * notes on protocol * collation-generation: point to collator protocol * fix missing bracket * expand on collator protocol wire protocol * add a couple more sentences * expand on requests some more * go higher level * network bridge: note peerset * note peer-set = validation for protocols * add `ConnectToValidators` message * use ConnectToValidators in collator protocol * typo * remove references to sentry nodes	2020-07-31 11:07:31 -04:00
Robert Habermeier	42bd096413	I am dumb and can't spell (#1366) ... * rename implementor's guide to implementer's guide * fix typos in more places	2020-07-07 10:10:36 -04:00