* client/network: Report reputation changes via response
When handling a request by a remote peer in a request response handler,
one might want to in- or de-crease the reputation of the peer. E.g. one
might want to decrease the reputation slightly for each request, given
that it forces the local node to do work, or one might want to issue a
larger reputation change due to a malformed request by the remote peer.
Instead of having to pass a peerset handle to each request response
handler, this commit suggests to allow handlers to isssue reputation
changes via the provided `pending_response` `oneshot` channel.
A reputation change issued by a request response handler via the
`pending_response` channel is received by the
`RequestResponsesBehaviour` which passes the reputation change up as an
event to eventually be send to a peerset via a peerset handle.
* client/network/req-resp: Use Vec::new instead of None::<Vec<_>>
* client/network: Rename Response to OutgoingResponse
Given that a request-response request is not called `Request` but
`InomingRequest`, rename a request-response response to
`OutgoingResponse`.
* client/finality-grandpa-warp: Send empty rep change via response
* start graphing message flow between subsystems
This commit includes messages originating from the first three subsystems
(alphabetically).
* use standard arrowhead names
* add messages from bitfield distribution && use circo layout
* finish adding all subsystem message traffic to graph
* reduce line spam
* start work on graphing v1 types
* finish graphing candidate-related structs
* show hash relations, format
* show provenance of ValidityAttestation
* add the rest of the v1 polkadot primitives
* add type diagram from polkadot::parachain::primitives
* start work digramming the path to backing
* diagram message flow from collation generation -> candidate selection
* document flow through CandidateBacking, CandidateValidation
* graph data flow through StatementDistribution
* trace data flow through PoVDistribution to Backing
* finish documenting node side subsystem data flow
* Switch to custom `BlockAnnounceData`
Instead of sending a `SignedFullStatement` this switches to a new struct
`BlockAnnounceData` that is being send alongside the block announcement.
The signed full statement contains the candidate commitments, meaning it
could be a full runtime upgrade that we send alongside a block
announcement... To prevent this, we now only send the candidate receipt
and the compact statement.
* Update to latest polkadot
* initial impl approval distribution
* initial tests and fixes
* batching seems difficult: different peers have different needs
* bridge: fix test after merge
* some guide updates
* only send assignments to peers who know about the block
* fix a test, add approvals test
* simplify
* do not send assignment to peers for finalized blocks
* guide: protocol input and output
* one more test
* more comments, logs, initial metrics
* fix a typo
* one more thing: early return when reimporting a thing locally
* Fix weight syntax in comments
* Mention to add `IsType` bound
* Link to subsee
* Fix link
* Update frame/support/procedural/src/pallet/parse/call.rs
Co-authored-by: David <dvdplm@gmail.com>
* Apply review suggestion from @dvdplm, make StorageInstance doc link
* fix ui test
Co-authored-by: David <dvdplm@gmail.com>
Co-authored-by: thiolliere <gui.thiolliere@gmail.com>
* client/network/req-resp: Add unit test for request id collision
* client/network/req-resp: Prevent request id collision
`RequestId` is a monotonically increasing integer, starting at
`1`. A `RequestId` is unique for a single `RequestResponse`
behaviour, but not across multiple `RequestResponse` behaviours. Thus
when handling `RequestId` in the context of multiple
`RequestResponse` behaviours, one needs to couple the protocol name
with the `RequestId` to get a unique request identifier.
This commit ensures that pending requests (`pending_requests`) and
pending responses (`pending_response_arrival_time`) are tracked both by
their protocol name and `RequestId`.
* client/network/req-resp: Remove unused import
* client/network/req-resp: Introduce ProtocolRequestId struct
* client/network/req-resp: Update test doc comment
Treat `RequestId` as an opaque type.
* client/network/req-resp: Improve expect proof
* Moving offchain change set to state machine overlay change set,
preparing use of change set internally.
* Make change set generic over key and value, and use it for offchain
indexing.
* test ui change
* remaining delta
* generating with standard method
* Remove 'drain_committed' function, and documentation.
* Default constructor for enabling offchain indexing.
* Remove offchain change specific iterators.
* remove pub accessor
* keep previous hierarchy, just expose iterator instead.
* Update primitives/state-machine/src/overlayed_changes/mod.rs
Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
* fix line break
* missing renamings
* fix import
* fix new state-machine tests.
* Don't expose InnerValue type.
* Add test similar to set_storage.
* Remove conditional offchain storage (hard to instantiate correctly).
* fix
* offchain as children cannot fail if top doesn't
Co-authored-by: Addie Wagenknecht <addie@nortd.com>
Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
* grandpa: persist block number for last block of authority set
* grandpa: fix authority_set_changes field in tests
* grandpa: fix date on copyright notice
* grandpa-rpc: implement cleaner api for prove finality rpc
* grandpa-rpc: replace the old prove_finality with the new one
* grandpa: undo accidental whitespace change
* grandpa-rpc: start work on redo of the finality_proof RPC API
* grandpa: manual impl of Decode for AuthoritySet
* grandpa: add comment about appending changes for forced changes
* grandpa: flip order in set changes, tidy up some comments
* grandpa: update some of the doc comments
* grandpa: store authority set changes when applying forced changes
* grandpa: simplify finality_proof.rs
* grandpa: move checks and extend tests in finality_proof
* grandpa: address first set of review comments
* grandpa: check that set changes have well-defined start
* grandpa: rework prove_finality and assocated tests
* grandpa: make AuthoritySetChanges tuple struct
* grandpa: add assertions for tracking auth set changes
* grandpa: remove StorageAndProofProvider trait
* grandpa: return more informative results for unexpected input to RPC
* grandpa: tiny tweak to error msg
* grandpa: fix tests
* grandpa: add error specific to finality_proof
* grandpa: fix review comments
* grandpa: proper migration to new AuthoritySet
* grandpa: fix long lines
* grandpa: fix unused warning after merge
Co-authored-by: André Silva <andrerfosilva@gmail.com>
* Compress the PoV block before sending it over the network
This pr changes the way we send PoV blocks over the network. We now
compress the PoV block before it is send over the network. This should
reduce the size significant for PoVs which contain the runtime WASM for
example.
* Preallocate 1KB
* Try something..
* Switch to zstd and some renamings
* Make compression/decompression fail in browsers
* Use some sane maximum value
* Update roadmap/implementers-guide/src/types/network.md
Co-authored-by: Andronik Ordian <write@reusable.software>
* Fix and add test
* add
Co-authored-by: Andronik Ordian <write@reusable.software>
Co-authored-by: Robert Habermeier <rphmeier@gmail.com>
* Made a start
* So the proof between authority set is phragmen one, this is crazy big,
or is there some signing of the result : that is the storage key, damn?
* ok getting from header digest seems doable.
* for testing
* get set id from storage directly (should use runtime to handler change).
* move test to init
* correct auth key
* fix iteration
* Correct proof content
* actually update block number.
* actually check last justif against its header
* justification relation to new authorities through header hash check is
needed here. This assumes the hash from header is calculated.
* Few changes
* Connected up cheme's branch
* Clean up
* Move things around a bit so that adding the grandpa warp sync request response protocol happens in the node code
* Nits
* Changes to comments
* Cheme changes
* Remove todos and test compile.
* Rename _authority_ related proof function to _warp_sync_ .
* Update client/grandpa-warp-sync/src/lib.rs
quick fix
* Put the warp sync request response protocol behind a feature flag because we dont' need it on a light client.
* Update client/grandpa-warp-sync/src/lib.rs
Quick fix
* Update Cargo.lock
* Adding test, comment on limitation related to 'delay', this could
be implemented but with a cost.
* Set between a delay override last fragment.
* Check for pending authority set change at start.
* adjust index
* custom cache is not a good idea.
* Use a simple cache instead.
* restore broken indentation
* Address crate rename
* Merge conflict badly resolved, sorry
Co-authored-by: cheme <emericchevalier.pro@gmail.com>
Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com>
* rename parachain-{upgrade -> system}
* Merge message-broker into parachain-system
* Remove message-broker and clean up
* Update docs
* Test upward messages sending
And also update the relay-sproof-builder so that it allows to set the
relay dispatch queue size for the given parachain.
* Test horizontal message sending
* Remove old inherent definitions
* Make offchain indexing work
This fixes some bugs with offchain indexing to make it actually working ;)
* Fix tests
* Fix browser build
* Update client/db/src/offchain.rs
Co-authored-by: cheme <emericchevalier.pro@gmail.com>
* Remove seperation between prefix and key
Co-authored-by: cheme <emericchevalier.pro@gmail.com>
* Attempt to remove the where bounds.
* Fix further and further.
* Format better.
* Update primitives/npos-elections/src/lib.rs
* fix build
* remove unused
Sentry nodes are deprecated. Thus there is no need for
`.maintain/sentry-node` to spin up a sentry node test environment.
Instead this commit rewrites the setup to contain two full-connected
validators and one light client.
With the steps below one can now spin up a local test network with
two validators, one light-client, Prometheus and Grafana.
- cargo build --release
- sudo docker-compose -f .maintain/local-docker-test-network/docker-compose.yml up
* glossary: define DMQ
We are using DMQ quite often including in rustdoc, however, it may be
hard to know what is that. Adding it to the glossary.
* Clarify that DMP and HRMP are also module names
* Define PDK
* Define preimage
* Sync: Propagate block announcement data
This pr adds a feature to the sync protocol to propagate the data that
we received alongside a block announcement. This is done by adding a
cache that caches the last X block announcement data where X is set to
the number of `in_peers` (giving every peer the chance to send us a
different block). This will be required by parachains to ensure that
even peers who are not connected to a collator receive the data
alongside the block announcement to properly validate it and request the
block.
* Review comment
* Bring back the code and add new variant to ensure we don't insert block
announce data when something wasn't checked
* Also use out_peers
Ricardo Rius