610987a19d
removed pallet::getter usage from cumulus pallets ( #3471 )
...
Part of #3326
@ggwpez @kianenigma @shawntabrizi
polkadot address: 12poSUQPtcF1HUPQGY3zZu2P8emuW9YnsPduA4XG3oCEfJVp
---------
Signed-off-by: Matteo Muraca <mmuraca247@gmail.com >
2024-03-18 19:19:20 +00:00
f4fbddec42
fix(pallet-benchmarking): split test functions in v2 ( #3574 )
...
Closes #376
---------
Co-authored-by: command-bot <>
2024-03-07 23:19:52 +00:00
700d5f85b7
Enable async backing on all testnet system chains ( #2949 )
...
Built on top of https://github.com/paritytech/polkadot-sdk/pull/2826/
which was a trial run.
Guide:
https://github.com/w3f/polkadot-wiki/blob/master/docs/maintain/maintain-guides-async-backing.md
---------
Signed-off-by: georgepisaltu <george.pisaltu@parity.io >
Co-authored-by: Branislav Kontur <bkontur@gmail.com >
Co-authored-by: Dónal Murray <donal.murray@parity.io >
Co-authored-by: Dmitry Sinyavin <dmitry.sinyavin@parity.io >
Co-authored-by: s0me0ne-unkn0wn <48632512+s0me0ne-unkn0wn@users.noreply.github.com >
Co-authored-by: Svyatoslav Nikolsky <svyatonik@gmail.com >
Co-authored-by: Bastian Köcher <info@kchr.de >
Co-authored-by: georgepisaltu <52418509+georgepisaltu@users.noreply.github.com >
2024-02-02 13:58:21 +00:00
7d735fc8ae
Add simple collator election mechanism ( #1340 )
...
Fixes https://github.com/paritytech/polkadot-sdk/issues/106
Port of cumulus PR https://github.com/paritytech/cumulus/pull/2960
This PR adds the ability to bid for collator slots even after the max
number of collators have already registered. This eliminates the first
come, first served mechanism that was in place before.
Key changes:
- added `update_bond` extrinsic to allow registered candidates to adjust
their bonds in order to dynamically control their bids
- added `take_candidate_slot` extrinsic to try to replace an already
existing candidate by bidding more than them
- candidates are now kept in a sorted list in the pallet storage, where
the top `DesiredCandidates` out of `MaxCandidates` candidates in the
list will be selected by the session pallet as collators
- if the candidacy bond is increased through a `set_candidacy_bond`
call, candidates which don't meet the new bond requirements are kicked
# Checklist
- [ ] My PR includes a detailed description as outlined in the
"Description" section above
- [ ] My PR follows the [labeling
requirements](https://github.com/paritytech/polkadot-sdk/blob/master/docs/CONTRIBUTING.md#process )
of this project (at minimum one label for `T` required)
- [ ] I have made corresponding changes to the documentation (if
applicable)
- [ ] I have added tests that prove my fix is effective or that my
feature works (if applicable)
- [ ] If this PR alters any external APIs or interfaces used by
Polkadot, the corresponding Polkadot PR is ready as well as the
corresponding Cumulus PR (optional)
---------
Signed-off-by: georgepisaltu <george.pisaltu@parity.io >
2023-11-14 18:22:30 +02:00
bfb241d7f3
Add missing licenses and tune the scanning workflow ( #1288 )
...
* Add missing Cumulus licenses
* Typo
* Add missing Substrate licenses
* Single job checking the sub-repos in steps
* Remove dates
* Remove dates
* Add missing (C)
* Update FRAME UI tests
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update more UI tests
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
---------
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
2023-08-30 15:45:49 +03:00
8349c8d18a
Companion: restructure macro related exports ( #3015 )
...
* restructure macro related exports
* restructure macro related exports
* wip
* wip
* update cargo lock
* refactor RuntimeDebug on unincluded segment
* fmt
* Companion: restructure `benchmarking` macro related exports (#3039 )
* wip
* wip
* restructure benchmarking macro related exports
* add cargo lock
---------
Co-authored-by: parity-processbot <>
2023-08-23 11:35:12 +00:00
9ec80090f5
Use benchmarking::v2 in collator selection pallet ( #2904 )
...
* Use benchmarking v2 in collator selection pallet
Signed-off-by: georgepisaltu <george.pisaltu@parity.io >
* Use extrinsic_call syntax
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Replace `block` with `extrinsic_call` syntax
Signed-off-by: georgepisaltu <george.pisaltu@parity.io >
---------
Signed-off-by: georgepisaltu <george.pisaltu@parity.io >
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
2023-07-20 12:09:12 +00:00
24d6e46ad0
Moves Block to frame_system instead of construct_runtime and removes Header and BlockNumber ( #2790 )
...
* Fixes
* Removes unused import
* Uses Block and removes BlockNumber/Header from Chain
* Fixes bridges
* Fixes
* Removes unused import
* Fixes build
* Uses correct RelayBlock
* Minor fix
* Fixes glutton-kusama
* Uses correct RelayBlock
* Minor fix
* Fixes benchmark for pallet-bridge-parachains
* Adds appropriate constraints
* Minor fixes
* Removes unused import
* Fixes integrity tests
* Minor fixes
* Updates trait bounds
* Uses custom bound for AsPrimitive
* Fixes trait bounds
* Revert "Fixes trait bounds"
This reverts commit 0b0f42f583f3a616a88afe45fcd06d31e7d9a06f.
* Revert "Uses custom bound for AsPrimitive"
This reverts commit 838e5281adf8b6e9632a2abb9cd550db4ae24126.
* No AsPrimitive trait bound for now
* Removes bounds on Number
* update lockfile for {"substrate", "polkadot"}
* Formatting
* ".git/.scripts/commands/fmt/fmt.sh"
* Minor fix
---------
Co-authored-by: parity-processbot <>
2023-07-13 13:30:28 +00:00
5a8134029a
Better Handling of Candidates Who Become Invulnerable ( #2801 )
...
* remove candidate when to invulnerable
* fix
* candidates to collators
* make parameters consistent and more reasonable
* add call to kick invulnerable candidates
* factor removal into weight
* fix: use accrue instead of add
* make set_invulnerables non-atomic
* benchmark add_invulnerable to account for candidate removal
* don't remove from candidates with set_invulnerables
* fix bounds on benchmarking
* protect against zero min invulnerables underflow
* extra event and tests
* make candidates/invulnerables self-cleaning on session change
* add integrity test
* unused imports
* make rococo-contracts have 1 collator
2023-07-07 11:18:27 +00:00
2e43d25a4f
Fix max > T::MaxCandidates benchmark warning ( #2716 )
2023-06-09 00:25:28 +02:00
23584c7b42
Add Ability to Add/Remove Invulnerable Collators ( #2596 )
...
* add add and remove invulnerable dispatchables
* add migration
* fix benchmarking code
* add weights
* add migration to runtimes
* clippy
* pass SafeCallFilter
* make try-runtime work
* typos
Co-authored-by: Ankan <10196091+Ank4n@users.noreply.github.com >
* better insert and added test
* fix try-runtime update
* Apply suggestions from code review
Co-authored-by: Bastian Köcher <git@kchr.de >
* Update pallets/collator-selection/src/migration.rs
* check events in test
* Update pallets/collator-selection/src/migration.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* just dispatchresult
* only sp_std for try-runtime
---------
Co-authored-by: Ankan <10196091+Ank4n@users.noreply.github.com >
Co-authored-by: Bastian Köcher <git@kchr.de >
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
2023-05-29 13:03:48 +00:00
299d25ba4b
Fix Clippy ( #2522 )
...
* Import Clippy config from Polkadot
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Auto clippy fix
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* No tabs in comments
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Prefer matches
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Dont drop references
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Trivial
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Refactor
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* fmt
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* add clippy to ci
* Clippy reborrow
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update client/pov-recovery/src/lib.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* Update client/pov-recovery/src/lib.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* Partially revert 'Prefer matches'
Using matches! instead of match does give less compiler
checks as per review from @chevdor.
Partially reverts 8c0609677f3ea040f77fffd5be6facf7c3fec95c
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update .cargo/config.toml
Co-authored-by: Chevdor <chevdor@users.noreply.github.com >
* Revert revert 💩
Should be fine to use matches! macro since it is an explicit whitelist,
not wildcard matching.
---------
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: alvicsam <alvicsam@gmail.com >
Co-authored-by: Bastian Köcher <git@kchr.de >
Co-authored-by: Chevdor <chevdor@users.noreply.github.com >
Co-authored-by: parity-processbot <>
2023-05-06 08:01:03 +02:00
0494cefc72
Update benchmark's successful origin api ( #2122 )
...
* Update benchmark's successful origin api
* update lockfile for {"substrate", "polkadot"}
---------
Co-authored-by: parity-processbot <>
2023-01-29 23:34:59 +00:00
4f632887eb
only register MaxCandidates-1 candidates initially ( #1714 )
2022-10-03 13:00:53 +00:00
68ba7e544d
Companion for #11981 ( #1563 )
...
* Companion for #11981
* rename
* Event to RuntimeEvent in imports
* missed rename
* undo
* revert
* rename type Call & Event
* commit
* ...
* fix
* fix errors
* fixes
* fmt
* fix imports
* final fix?
* fmt
* fix?
* fixes after merge
* small fix
* cargo update -p polkadot-runtime-common
* cargo +nightly fmt
* update lockfile for {"polkadot", "substrate"}
* fix
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com >
Co-authored-by: parity-processbot <>
2022-09-12 23:55:33 +00:00
c7ef5f6a6b
Use named events in cumulus pallets ( #1260 )
...
* Use named events
* For now standardise on message_id
* cargo fmt
* reverting xcm changes
* remove superfluous comments
* renaming
* updating benches
2022-05-23 08:23:27 +00:00
1f91a3068f
Fix panic in pallet-collator-selection benchmarking ( #1061 )
...
* register validators in set_invulnerables benchmarking
* Apply suggestions from code review
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
2022-03-02 09:24:36 +00:00
70ea98995a
Integrate try-runtime into cumulus ( #793 )
...
* almost integrate
* revert branch changes
* remove extra deps
* some review comments'
* Fix a bunch of stuff
* Update parachain-template/node/Cargo.toml
Co-authored-by: Alexander Popiak <alexander.popiak@parity.io >
* Fix
* Fix
* fix benchmark
* fmt
* Remove wrong bench test
Co-authored-by: Alexander Popiak <alexander.popiak@parity.io >
2021-12-02 14:00:54 +01:00
3284976a1b
Tweaks from template downstream review #80 ( #705 )
...
* tweaks from template downstream review #80
* more tweaks
* Update parachain-template/node/src/command.rs
* tweaks to template and other chainspecs
* fmt
* update more tweaks from downstream
* fix build
2021-11-11 19:20:39 +00:00
c63c5229ba
Upstream Statemine Release v5 Changes to Master ( #720 )
...
* Update references
* update deps
* set substrate deps for pallet-asset-tx-payment
* add DisabledValidatorsThreshold to parachain template
* add DisabledValidatorsThreshold to statemint runtimes
* adjust imports
* update Cargo-lock
* add DisabledValidatorsThreshold to mock config
* cargo +nightly fmt
* adjust on_disabled type
* remove on_chain_votes function in ParachainHost impl
* remove ScrapedOnChainVotes
* bump polkadot-collator version
Co-authored-by: Chevdor <chevdor@users.noreply.github.com >
* update Cargo.lock
* set spec_versions to 500
* Statemine cannot execute.
* disallow XCM execute on statemint
* cargo fmt
* remove unnecessary dep on node-primitives
* select parachains-common/std feature when building rococo-runtime with std
* adjust Statemint to the three digit spec_version format
* Add script to generate simple changelogs (#668 )
* Update weights from v4 for v5 comparison (#673 )
* updates weights
* pallet_unique benchmarks added + weights upstream from v4
* Fix benchmarks after Parachain Template (#677 )
* updates weights
* pallet_unique benchmarks added + weights upstream from v4
* benchmarks fix for parachain template
* Weights updates for Statemine v5 (#682 )
* updates weights
* pallet_unique benchmarks added + weights upstream from v4
* weights updates for statemine v5
* mention Storage in construct_runtime macro for pallet-xcm (#680 )
* Use pallet-xcm for version wrapping (#689 )
* use PolkadotXcm for XcmRouter WrapVersion
* use PolkadotXcm for version wrapping
Co-authored-by: Bryan Chen <xlchen1291@gmail.com >
* patch weight for batch_all from rerun
* Runtime version bump to v503 (#694 )
* adjust genesis value generation scripts to output entries array + add script to derive encoded call
* add script to generate shell spec from runtime wasm
* Ensure a bad datastream cannot cause problems (#701 )
* Ensure a bad datastream cannot cause problems
* Formatting
* Formatting
* update Polkadot (to 0.9.11 169bab55d)
* bump spec versions
* Allow Queries and Subscriptions
Fixes
Formatting
* fix build
* make fmt happy
* statemint imports
* slight naming changes in script
* add shell genesis data + wasm + chainspec
* adjust generated shell spec with production config values
* update Substrate and Polkadot to master
* fix deps
* swap out bootnodes for statemint shell
* add a script for verifying the shell chain spec
* add sha checksum for head data
* remove verification script
* remove hex wasm file
* update Substrate and Polkadot again and fix compilation
* update and fix lock file
* formatting
* remove redundant dispatch_as weight
Co-authored-by: Bastian Köcher <info@kchr.de >
Co-authored-by: Chevdor <chevdor@users.noreply.github.com >
Co-authored-by: Gav Wood <gavin@parity.io >
Co-authored-by: Ignacio Palacios <ignacio.palacios.santos@gmail.com >
Co-authored-by: Bryan Chen <xlchen1291@gmail.com >
Co-authored-by: joepetrowski <joe@parity.io >
2021-11-08 15:52:47 +01:00
a29d4b6c87
remove session benchmark todo ( #665 )
2021-10-15 12:06:03 +02:00
2647053fd3
Upstream Statemine v4 Changes ( #649 )
...
* bump runtime spec version
* remove applied runtime migrations
* bump transaction_version
necessary because of extrinsic API changes to pallet-xcm
https://github.com/paritytech/polkadot/pull/3693
* Fix Benchmarks for Statemine-V4 release (#639 )
* register validators
* register_as_candidate & leave_intent fixed
* new_session benchmark fixed
* intent_leave_modified
* clean up
* clean up
* benchmark script updated
* update cargo.lock
* done
Co-authored-by: Alexander Popiak <alexander.popiak@parity.io >
* Version bump (#648 )
* Version bump
fix #646
* Revert "Version bump"
This reverts commit 07517e0e76a37a1dd67176fec0524d0211666635.
* Bump polkadot-collator version
* Update polkadot-parachains/Cargo.toml
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Update deps
* Bump version to 4.0.0
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* cargo toml fix
* update deps and remove DisabledValidatorThreshold
* cargo +nightly fmt
* fix compile error
* fix client tests after Polkadot update
Co-authored-by: Ignacio Palacios <ignacio.palacios.santos@gmail.com >
Co-authored-by: Chevdor <chevdor@users.noreply.github.com >
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
2021-10-11 10:27:49 +02:00
6b20f7a2c5
ci: add quick-check with rustfmt ( #615 )
...
* ci: add quick-check with clippy and rustfmt
* chore: rustfmt round
* chore: set the same rustfmt config than substrate
* chore: fix formatting
* cI: remove clippy
* ci: switch to nightly for the checks
* ci: fix toolchains and naming
* ci: Limit the check to formatting
* chore: fix formatting
* Update .rustfmt.toml
* Update .rustfmt.toml
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
2021-09-16 16:57:52 +02:00
eaa9f64671
Add Statemint ( #452 )
...
* Add Statemint
* Versioning.
* Fixes
* Fixes
* Fixes
* Fixes
* Fixes
* Benchmarking
* kick patch (paritytech/statemin#88 )
* Westmint Chain Spec (paritytech/statemint#90 )
* Tidy the common .toml
* Update weights
* add westmint sudo key comment
* Port consensus stuff
* fix typo
* fix typo ... again
* Recognise Westmint
Co-authored-by: Alexander Popiak <alexander.popiak@parity.io >
Co-authored-by: Bastian Köcher <info@kchr.de >
2021-06-01 21:31:03 +02:00
Matteo Muraca