* Support multiple "best headers" from different forks
* Update the name of a test
* Add note about multiple scheduled changes
* Disallow multiple scheduled authority set changes
* Return multiple best headers from Runtime APIs
* Remove invalid test write-up
* Add some sketch-ups of test scenarios
* Clean up test scenarios
* Add module for testing forks
* Write headers to storage
* Add way to check expected outcome for header imports
* Add support for importing finality proofs
* Support importing headers which schedule changes
* Write out test scenario using new framework
* Map authority set changes across forks
Gets all the tests in the `forks` module passing
* Remove basic tests
These were used when working on the initial test helper
* Prevent multiple pending set changes on the same fork
* Remove old test which allowed imports past unfinalized header
* Ignore failing test (for now)
* Rewrite `if` comparison using `match` and `cmp`
Fixes Clippy warning: `comparison_chain`
* Add helper for writing test headers with default characteristics
* Fix test that checked authority set updates
* Make note about importing headers on different unfinalized fork
* Perform some cleanup on the fork module
* Fix Clippy complaints
* Provide list of unfinalized headers to Runtime APIs
* Add proofs to expect() calls
* Make tests the focus of the forks module
* Allow specific errors to be checked in fork tests
* Remove unused method
* Replace unreachable() statement with expect()
* Rename storage `unfinalized_headers() `to make its purpose more clear
* Update Runtime API name in relayer to match pallet
* Commit `unfinalized_headers` changes I forgot to add
* Rename ChainTipHeight to BestHeight
* Make schedule_next_set_change require a mutable reference
* Remove check for key when enacting authority set
We only expect to take the happy-path in the pallet anyways, so this check
to save ourselves the time spent decoding the entry isn't really used.
* Clear justification set when writing headers to storage
* Clarify why we only allow one set change per fork
* Change best_headers() to return HeaderIDs
Prevents us from returning full headers (which are more expensive to
get from storage) since we only care about header IDs (number, hash)
anyways.
* Fix Clippy complaint
* Make note about equivocations
* Use HeaderIds when returning incomplete headers
This change stops returning full headers which are more expensive
to get from storage than header Ids (number, hash) are. Clients likely
don't need the full header anyways which is why this change is fine.
* Introduce HeaderId type to reduce type complexity
* Add signal hash to storage during genesis config
* Return error instead of expect()-ing
* Fix Clippy lint about `ok_or` fn call
* Rename `forks` module to indicate that it's for testing
* Use `const` for `expect()` proofs
* Remove check that key exists before `kill`-ing value
Co-authored-by: Svyatoslav Nikolsky <svyatonik@gmail.com>
* Add Rialto as a target for the Millau node
* Rename Rialto module to Rialto-PoA
This will reduce confusion as the Millau runtime has a
Rialto module as well which refers to the Substrate chain.
* Add Millau as a target for the Rialto node
* Be more explicit about Rialto PoA related code
* Missed some name changes in the Ethereum PoA relay
* Re-export Substrate pallet structs used by node
* Remove `first_scheduled_change` of Millau in Rialto node
* Make Millau's genesis config for Rialto bridge more accurate
* Set initial header for Millau config
* Update initial Millau authorities
Co-authored-by: Svyatoslav Nikolsky <svyatonik@gmail.com>
* RustFmt Millau authorities
Co-authored-by: Svyatoslav Nikolsky <svyatonik@gmail.com>
* Split the Rialto Node into a standalone crate
* Split the Millau Node into a standalone crate
* Remove `bridge-node` crate
* Add benchmarking feature to nodes
* Check that benchmarks compile in CI
* Remove nodes from CI matrix
* Update Rialto node to Substrate 2.0
* Get Millau node compiling with Substrate 2.0
* Remove extra license text
* Remove comments in TOML files
* Move nodes and runtimes into Rialto and Millau folders
* Fix dependency paths
* Remove unused script
* Add issue to benchmarking TODO
* Fix benchmark manifest paths
* Rename Header to AuraHeader
This prevents some type conflicts with the PolkadotJS Apps types.
* Fix test and benchmark builds
* Update AuraHeader in types.json
* Rename Ethereum PoA primitives crate
The "sp" prefix comes from Substrate primitives, since this crate originated
in that repo. However, it is not part of Substrate anymore and its name should
be updated to reflect that.
* Rename currency exchange primitives
* Rust Fmt
* Update import in benchmarking module
* Rust Fmt
* Split pub and no-pub
* Sort toml files.
Co-authored-by: Tomasz Drwięga <tomasz@parity.io>
* Sketch out how to support different bridge pallet instances
* Create a common interface for using pallet instances
* Start introducing generic instance parameter
Attemps to make the compiler happy, but I'm having second thoughts about
this approach. Commiting now as a way to have a checkpoint, but I think
I'm going to need to re-consider my approach here.
Ideally I want a change which introduces minimal changes, but this seems
to be propagating around the codebase in ways I don't want.
* Use trait objects instead of generics
* Implement traits for Boxed trait objects
This is done in order to statisfy trait bounds by types
which use these new trait objects
* Remove Clone usage for sync parameters
* Remove implementation of Default for sync params
* Require that BridgeInstance implements Debug
* Ensure that BridgeInstance trait implements Send/Sync
* Add documentation related to instances
* Rust Fmt
* Remove needless format
* Make instance CLI option case insensitive
* Replace `with_*` constructors with `new`
* Clean up usage of instance structs
* Enforce a default instance in the CLI params
* Build sync params as we process input from CLI
* Remove case insensitivity from sub-tx-mode
I think this should happen, but maybe as part of a different PR
* Process default Eth contract deployment config in CLI
* Build EthereumExchangeParams in CLI
* Process EthereumExchangeSubmitParams params in CLI
* Bump Substrate to rc5
* Bump async-std to v1.6.2
There was a bug in v.1.6.0 which kept us locked to v1.5 releases.
I think that's fixed now so I'm bumping this.
* Update bridge node runtime
* Update node service
* Update CLI
* Add SystemWeightInfo type to test runtimes
* Add RPC extension builder to service
* Directly return rpc_extensions_builder
* Allow complex types in service
This comes from Substrate, so I'd rather just keep the code as is
* Update benchmarking code for new CLI