Svyatoslav Nikolsky
3a145e5844
get rid of obsolete weight functions ( #1926 )
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
aa466a485d
Fix benchmarks ( #1919 )
...
* fixed benchmarks broken by rejecting storage proofs with excessive trie nodes and justifications with extra prevotes
* update weights
* fmt
* accidental paste
* revert changes to millau runtime (separate PR)
* revert comment change
2024-04-10 10:28:37 +02:00
Serban Iorga
ba155f990f
Refund messages confirmation tx ( #1904 )
...
* Refund messages confirmation tx
* Fixes
2024-04-10 10:28:37 +02:00
Serban Iorga
f5fee288b9
Relayers pallet: extend payment source id ( #1907 )
...
* Add Chain::ID const
* Relayers pallet: extend payment source id
* Addressed code review comments
* Fix benchmarks
* Fix dashboards
* Renamings
* Fix compilation
2024-04-10 10:28:37 +02:00
Serban Iorga
e7debc4b09
Fix init-bridge ( #1900 )
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
26330d9a25
get rid of ChainWithMessages::WeightInfo, because we can't have exact weights for "external chains" ( #1899 )
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
498a3e83d0
Weight+size limits for bridge GRANDPA pallet calls ( #1882 )
...
* weight+size limits for bridge GRANDPA pallet calls
* continue
* fixed all tests
* some changes to refund computations
* post_dispatch_refunds_relayer_in_all_finality_batch_with_extra_weight
* - dup code
* do not return Pays::No if call is above weight/size limits
* relayer_pays_tx_fee_when_submitting_huge_mandatory_header and relayer_pays_tx_fee_when_submitting_justification_with_long_ancestry_votes
* clippy
* fmt
* clippy
* small change in docs
* fixed GRANDPA-limits constants for Polkadot-like chains
* clippy
* clippy + spelling
* Update primitives/polkadot-core/src/lib.rs
Co-authored-by: Adrian Catangiu <adrian@parity.io >
* Update bin/runtime-common/src/refund_relayer_extension.rs
Co-authored-by: Adrian Catangiu <adrian@parity.io >
* reverted unnecessary change
* GrandpaJustification::max_reasonable_size
---------
Co-authored-by: Adrian Catangiu <adrian@parity.io >
2024-04-10 10:28:37 +02:00
Serban Iorga
623bd85a5e
RefundRelayerForMessagesFromParachain improvements ( #1895 )
...
* RefundRelayerForMessagesFromParachain changes
- some renamings and cosmetics
- removing the GI generic param since we can get it from the parachains
config
- merging (Parachains Instance, Parachain Id) and (Messages Instance,
Messages lane Id) generic params
- removing unnecessay derives
- renaming for the `TransactionFeeCalculation` and defining
`ActualFeeRefund` concrete implementation
- adding support for multiple RefundRelayerForMessagesFromParachain
(by adding a `StaticStrProvider` generic param)
* Revert to using RuntimeDebug
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
1d6e8a9a26
optimize justification before submit ( #1887 )
...
* optimize justification before submit
* fmt
* spelling
* clippy
* fmt again
* aaand compilation
* clippy
2024-04-10 10:28:37 +02:00
Branislav Kontur
6a2ef74707
Make weights::WeightInfo pub ( #1886 )
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
c6c39be967
ChainWithGrandpa in primitives ( #1885 )
...
* ChainWithGrandpa in primitives
* clippy ++ spelling
* fix benchmarks comppilation
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
914213d0af
Fix clippy issues ( #1884 )
...
* fix clippy issues
* fix?
* fix?
* forget about extra_unused_type_parameters lint for now
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
25c17feb23
Reject storage proofs with unused nodes: begin ( #1878 )
...
* reject storage proofs with unused nodes: begin
* fix ignores_parachain_head_if_it_is_missing_from_storage_proof
* message_proof_is_rejected_if_it_has_duplicate_trie_nodes && message_proof_is_rejected_if_it_has_unused_trie_nodes
* proof_with_duplicate_items_is_rejected and proof_with_unused_items_is_rejected
* clippy
* fix benchmarks compilation
* impl From<Error> for &'static str
* fix review comments
* added comment
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
9e30130054
Refund extra proof bytes in message delivery transaction ( #1864 )
...
* refund extra proof bytes in message delivery transaction
* Update modules/messages/src/lib.rs
Co-authored-by: Adrian Catangiu <adrian@parity.io >
* more tests
---------
Co-authored-by: Adrian Catangiu <adrian@parity.io >
2024-04-10 10:28:37 +02:00
Serban Iorga
c9c6d566d0
RefundRelayerForMessagesFromParachain improvements ( #1879 )
...
* RefundRelayerForMessagesFromParachain improvements
* Address code review comments
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
d8764450c9
MaxValues for OutboundLanes map ( #1871 )
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
89bb368e45
More tests for message pallet weights ( #1870 )
...
* more tests for message pallet weights
* move tests to ensure_weights_are_correct
* removed extra tests
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
4982d1c2e5
MaxValues for maps in parachain maps ( #1868 )
...
* MaxValues for maps in parachain maps
* fix compilation
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
bae329c66e
"refund" proof size in GRANDPa pallet ( #1863 )
...
* "refund" proof size in GRANDPa pallet
* clippy
* extra_proof_size_bytes_works
* use saturated_into
* fix review comments
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
e75d872aa7
MaxValues limit for storage maps in the pallet-bridge-grandpa ( #1861 )
...
* MaxValues limit for storage maps in the pallet-bridge-grandpa
* remove use from the future PR
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
a5a3f8065f
fixed TODOs for weights v2 ( #1860 )
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
795a049937
Message delivery transaction is not free!!! ( #1859 )
...
* message delivery transaction is not free!!!
* test pays_fee
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
7755c1b526
changed some tests for weights v2 ( #1855 )
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
cd12d1438e
Fix HeadersToKeep and MaxBridgedAuthorities in Millau benchmarks ( #1851 )
...
* fix `HeadersToKeep` and `MaxBridgedAuthorities` in Millau benchmarks
* typo
* impl review suggestion
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
a091b8405e
Update Substrate/Polkadot/Cumulus dependencies + weights v2 ( #1850 )
...
* cargo update
* weights v2
* clippy
* no spellcheck for weights.rs
* fix proof_size component in MAXIMUM_BLOCK_WEIGHT constants
* "fix" proof_size in select_delivery_transaction_limits_works
* spellcheck
2024-04-10 10:28:37 +02:00
Serban Iorga
5d875d05d3
Use named parameters for indirect calls ( #1823 )
2024-04-10 10:28:37 +02:00
omahs
a417c707d6
Fix: typos ( #1822 )
...
* Fix: typos
Fix: typos
* Fix: typos
Fix: typos
* Fix: typo
Fix: typo
* Fix: typos
Fix: typos
* Fix: typos
Fix: typos
2024-04-10 10:28:37 +02:00
Adrian Catangiu
f0c3cf4ca5
docs: fix broken link and minor nits ( #1821 )
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
c8c606dd66
Functions to benchmark messages pallet with linked to parachain ( #1817 )
...
* functions to benchmark messages pallet with linked to parachain
* unused imports
* fmt
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
ec9cd8ddb0
Remove chain-specific dependencies from crates that will be used in Cumulus ( #1783 )
...
* leave-modules.sh
* remove bp-rialto dependency from bp-relayers
* update leave-modules.sh
* fix Cargo.toml of pallet-bridge-relayers
* update leave-modules.sh
* remove bp-rialto and millau-runtime frombridge-runtime-common Cargo.toml
* update leave-modules.sh
* remove chain dependencies from bridge-runtime-common crate
* fix tests
* cleanup script
* rename script
* kind of success message
* remove leave-modules.sh
* use TargetHeaderChainAdapter and SourceHeaderChainAdapter in our testnets
* update script
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
4cdb85247e
add try-runtime feature to pallets ( #1779 )
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
74fb0a536d
Default impl for some methods in messages benchmarking pallet config ( #1777 )
...
* default impl for some methods in messages benchmarking pallet config
* typo
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
d7b131646c
Relayer reward metric ( #1742 )
...
* use StorageDoubleMapKeyProvider in RelayerRewards
* add metrics
* clippy
* fixed alerts that have caused missing dashboards
* fix metric name
* fix metric name again
* add new metrics to the RialtoParachain <> Millau maintenance dashboard
* remove obsolete dashboard
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
b06cd924e9
Crate-level documentation on finality relays and relayers pallet ( #1773 )
...
* started crate-level documentation on relays and relayers pallet
* fixes in finality and parachain finality relay docs
* fix links
* grammar fixes
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
8494162d2a
update Substrate/Polkadot/Cumulus deps to master ( #1775 )
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
c36ba5a562
Added crate-level docs for the parachains pallet ( #1772 )
...
* crate-level docs for the parachains pallet
* fix typos
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
763ab922fa
added/updated pallet level docs to grandpa and messages pallets ( #1771 )
2024-04-10 10:28:37 +02:00
Branislav Kontur
5fdc89d651
Bump xcm-v3 + substrate ( #1767 )
...
* Bump xcm-v3 + substrate
* More fixes
* Added `#[pallet::call_index`
* Fixes for MMR (TODO:plese check)
* More call indexes
* Cumulus bump
* Fixes for mmr
* Fixes for weights
* Fixes for xcm
* MMR fixes + cargo fmt
* Fix some rpc errors (bump jsonrpsee version)
* Fix cumulus stuff
* Fixes cumulus
* clippy
* more clipy
* Fix test + unused deps
* PR fixes
* cargo update (bump xcm-v3)
Co-authored-by: Serban Iorga <serban@parity.io >
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
cca75ee841
fixed receive_delivery_proof_for_two_messages_by_two_relayers ( #1764 )
2024-04-10 10:28:37 +02:00
Branislav Kontur
3c4cce9eef
cargo machete removed unused deps (#1761 )
2024-04-10 10:28:37 +02:00
Serban Iorga
63a538a9bb
Deduplicate pallet call structs used for indirect runtime calls ( #1744 )
...
* Small changes
* Define generic bridge pallets call structs
* polkadot-core SignedExtension simplifications
- we don't seem to need to pass the Call as a generic param
- we can use codec(skip) instead of implementing Encode and Decode
* Split BridgeHubRococo and BridgeHubWococo calls
* code review fixes
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
03425b33ae
Use TypedLaneId instead of LaneId ( #1738 )
...
* TypedLaneId -> LaneId
* fix benchmarks compilation
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
df1aed01c4
Updated db weights and some experiments ( #1732 )
...
* updated weights
* also fix off-by-one in benchmarks
2024-04-10 10:28:37 +02:00
Branislav Kontur
52542b11d4
Check origin? ( #1718 )
...
* Check origin?
* Removed ensure_signed
* clippy
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
7d55a0ffe2
fix parachains benchmarks ( #1717 )
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
d63a75697c
Only store header state root (pallet-bridge-parachains) ( #1701 )
...
* store block number ++ state root in parachains pallet
* fixed parachains finality APIs
* (test commit)
* removed test code
* deduplicated code a bit
* removed commented code
* spelling
* Update modules/parachains/src/lib.rs
Co-authored-by: Adrian Catangiu <adrian@parity.io >
* Update modules/parachains/src/lib.rs
Co-authored-by: Adrian Catangiu <adrian@parity.io >
* Update modules/parachains/src/mock.rs
Co-authored-by: Adrian Catangiu <adrian@parity.io >
* added comment
Co-authored-by: Adrian Catangiu <adrian@parity.io >
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
2c5e2f09eb
New relayer rewards scheme integration ( #1652 )
...
* relayer rewards integration: initial commit
* added refund-relayer-extension to the millau runtime
* spelling
* spelling again
* new -> Default
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
161d861d9b
Signed extension to refund relayer at the target chain ( #1657 )
...
* add utlity pallet to the Millau runtime
* RefundRelayerForMessagesDeliveryFromParachain prototype
* done with RefundRelayerForMessagesDeliveryFromParachain::post_dispatch
* parse calls
* check batch for obsolete headers/messages
* fmt
* shorten generic arg names + add parachain id generic arg
* check lane_id
* impl all state read functions
* fix typos from review
* renamed extension + reference issue from TODO
* tests for pre-dispaytch
* renamed extension source file
* tests for post-dispatch
* abstract fee calculation
* clippy
* actually fix clippy
* Update bin/runtime-common/src/refund_relayer_extension.rs
Co-authored-by: Adrian Catangiu <adrian@parity.io >
* Update bin/runtime-common/src/refund_relayer_extension.rs
Co-authored-by: Adrian Catangiu <adrian@parity.io >
* Update bin/runtime-common/src/refund_relayer_extension.rs
Co-authored-by: Adrian Catangiu <adrian@parity.io >
* Update bin/runtime-common/src/refund_relayer_extension.rs
Co-authored-by: Adrian Catangiu <adrian@parity.io >
Co-authored-by: Adrian Catangiu <adrian@parity.io >
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
aeeb53343e
DeliveryConfirmationPayments trait for paying relayer rewards at the source chain ( #1653 )
...
* DeliveryConfirmationPayments
* ref proper PR in TODO
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
7014046485
only store header state root (pallet-bridge-grandpa) ( #1699 )
2024-04-10 10:28:37 +02:00