4c10fd2a41
Move cryptographic hashing procedures to crypto folder. ( #2306 )
...
Step towards https://github.com/paritytech/polkadot-sdk/issues/1975
As reported
https://github.com/paritytech/polkadot-sdk/issues/1975#issuecomment-1774534225
I'd like to encapsulate crypto related stuff in a dedicated folder.
Currently all cryptographic primitive wrappers are all sparsed in
`substrate/core` which contains "misc core" stuff.
To simplify the process, as the first step with this PR I propose to
move the cryptographic hashing there.
The `substrate/crypto` folder was already created to contains `ec-utils`
crate.
Notes:
- rename `sp-core-hashing` to `sp-crypto-hashing`
- rename `sp-core-hashing-proc-macro` to `sp-crypto-hashing-proc-macro`
- As the crates name is changed I took the freedom to restart fresh from
version 0.1.0 for both crates
---------
Co-authored-by: Robert Hambrock <roberthambrock@gmail.com >
2024-01-22 23:36:14 +00:00
dca142398e
substrate: sysinfo: Expose failed hardware requirements ( #2144 )
...
The check_hardware functions does not give us too much information as to
what is failing, so let's return the list of failed metrics, so that callers can print
it.
This would make debugging easier, rather than try to guess which
dimension is actually failing.
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io >
2023-11-03 15:26:40 +02:00
bc53b9a03a
Remove years from copyright notes. ( #13415 )
...
* Change copyright year to 2023 from 2022
* Fix incorrect update of copyright year
* Remove years from copy right header
* Fix remaining files
* Fix typo in a header and remove update-copyright.sh
2023-02-21 18:46:41 +00:00
64b37b301d
Move slow hardware warning print logic to CLI ( #13198 )
...
* Move slow hardware warning print logic to CLI
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update client/sysinfo/src/sysinfo.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* fmt
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: Bastian Köcher <git@kchr.de >
2023-01-21 10:53:07 +00:00
5ccd9bfc5a
Warn validators with slow hardware ( #12620 )
...
* move Metric
* run hardware bench if validiator flag is being used
* fix rustdoc & update node-template
* fix
* unused improt
* warn
* move Requirement
* bench_result
* ensure_requirements
* make the code compile
* check if authority
* Update client/sysinfo/src/sysinfo.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* nit fixes
* warning signs
* Update client/sysinfo/src/sysinfo.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
2023-01-20 20:26:12 +01:00
74b52f9338
Remove duplicate units ( #12634 )
...
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
2022-11-08 14:01:47 +01:00
65b285e632
Move Throughput into sc-sysinfo ( #12368 )
...
* move Throughput to sc-sysinfo
* replace u64
* fix in tests
* change Throughput
* refactored Throughput
* fixes
* moved tests & fixes
* custom serializer
* note
* fix serializer
* forgot to remove
* deserialize
* functioning deserialization :)
* try to make clipply happy
* Serialize as function
* test HwBench
* rename
* fix serialization
* deserialize as function
* unused import
* move serialize/deserialize
* don't serialize none
* remove nonsense
* remove nonsense comment :P
* fixes
* remove all the todos
* return enum
* fixes
* fix nit
* improve docs & readability
* Update client/sysinfo/src/sysinfo.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* fix all the nits
* rename
* fix
* Update client/sysinfo/src/sysinfo.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* remove unit from serialization
* Update utils/frame/benchmarking-cli/src/machine/hardware.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
2022-11-04 17:13:57 +00:00
32d6d1b37c
More benchmark machine args ( #11428 )
...
* Add ExecutionLimits to sc-sysinfo and return float
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Increase benchmarking duration and add options
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix tests
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix tests
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
2022-05-17 13:57:08 +00:00
9980d314b1
Follow ups for benchmark machine ( #11270 )
...
* Follow ups for the MachineCmd
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix CI
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Review fixes
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add to node-template
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix test with feature flag
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Review fixes
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Lower disk requirements
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add ExecutionLimit to the disk benchmarks
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* fmt
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add doc
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Review fixes
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Rename DISK_WRITE_LIMIT -> DEFAULT_DISK_EXECUTION_LIMIT
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Rename POLKADOT_REFERENCE_HARDWARE -> SUBSTRATE_REFERENCE_HARDWARE
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix build profile + add license
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Remove deps
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Set tolerance to 10%
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix tests
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Ignore test
I cannot reproduce the CI error, even with the full command:
cargo test --workspace --locked --release --verbose --features runtime-benchmarks --manifest-path ./bin/node/cli/Cargo.toml
I will put an 'ignore' on that test for now, since it works for me and is worth having.
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Remove test
Still cannot reproduce the error and it fails in the CI.
Removing it now.
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com >
2022-04-26 14:31:26 +00:00
362dc50940
Add benchmark machine placeholder ( #11198 )
...
* Move new_rng to shared code
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add bechmark machine command
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Use sc-sysinfo
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add --no-hardware-benchmarks
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Lockfile
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Do not create components if not needed
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix tests
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Revert "Add --no-hardware-benchmarks"
This reverts commit d4ee98222bf1a5ea62ac60dd7d5c62070e2d7f70.
* Fix tests
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update Cargo deps
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Move sr255119::verify bench to sc-sysinfo
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Move sr255119::verify bench to sc-sysinfo
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Switch benchmarks to return f64
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Review fixes
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* fmt
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Hide command until completed
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Use concrete rand implementation
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Put clobber into a function
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add test
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add comment
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update cargo to match polkadot
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Remove doc that does not format in the console
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Limit benchmark by time
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add ExecutionLimit and make function infallible
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* CI
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add doc
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
2022-04-15 12:09:16 +00:00
8351ada6a3
Add new hardware and software metrics ( #11062 )
...
* Add new hardware and software metrics
* Move sysinfo tests into `mod tests`
* Correct a typo in a comment
* Remove unnecessary `nix` dependency
* Fix the version tests
* Add a `--disable-hardware-benchmarks` CLI argument
* Disable hardware benchmarks in the integration tests
* Remove unused import
* Fix benchmarks compilation
* Move code to a new `sc-sysinfo` crate
* Correct `impl_version` comment
* Move `--disable-hardware-benchmarks` to the chain-specific bin crate
* Move printing out of hardware bench results to `sc-sysinfo`
* Move hardware benchmarks to a separate messages; trigger them manually
* Rename some of the fields in the `HwBench` struct
* Revert changes to the telemetry crate; manually send hwbench messages
* Move sysinfo logs into the sysinfo crate
* Move the `TARGET_OS_*` constants into the sysinfo crate
* Minor cleanups
* Move the `HwBench` struct to the sysinfo crate
* Derive `Clone` for `HwBench`
* Fix broken telemetry connection notification stream
* Prevent the telemetry connection notifiers from leaking if they're disconnected
* Turn the telemetry notification failure log into a debug log
* Rename `--disable-hardware-benchmarks` to `--no-hardware-benchmarks`
2022-04-11 18:46:53 +09:00
Davide Galassi