* Revert "Pin Rust Nightly to 2020-12-17 (#652)"
This reverts commit e54e6f7e3d34c28d698e637f9099162b3c1917e9.
* fix clippy
* clippy again
* more clippy in test code
* and new cargo fmt
* another try
* Add Rialto as a target for the Millau node
* Rename Rialto module to Rialto-PoA
This will reduce confusion as the Millau runtime has a
Rialto module as well which refers to the Substrate chain.
* Add Millau as a target for the Rialto node
* Be more explicit about Rialto PoA related code
* Missed some name changes in the Ethereum PoA relay
* Re-export Substrate pallet structs used by node
* Remove `first_scheduled_change` of Millau in Rialto node
* Make Millau's genesis config for Rialto bridge more accurate
* Set initial header for Millau config
* Update initial Millau authorities
Co-authored-by: Svyatoslav Nikolsky <svyatonik@gmail.com>
* RustFmt Millau authorities
Co-authored-by: Svyatoslav Nikolsky <svyatonik@gmail.com>
* Rename Header to AuraHeader
This prevents some type conflicts with the PolkadotJS Apps types.
* Fix test and benchmark builds
* Update AuraHeader in types.json
* Rename Ethereum PoA primitives crate
The "sp" prefix comes from Substrate primitives, since this crate originated
in that repo. However, it is not part of Substrate anymore and its name should
be updated to reflect that.
* Rename currency exchange primitives
* Rust Fmt
* Update import in benchmarking module
* Rust Fmt
* Split pub and no-pub
* Sort toml files.
Co-authored-by: Tomasz Drwięga <tomasz@parity.io>
* Sketch out how to support different bridge pallet instances
* Create a common interface for using pallet instances
* Start introducing generic instance parameter
Attemps to make the compiler happy, but I'm having second thoughts about
this approach. Commiting now as a way to have a checkpoint, but I think
I'm going to need to re-consider my approach here.
Ideally I want a change which introduces minimal changes, but this seems
to be propagating around the codebase in ways I don't want.
* Use trait objects instead of generics
* Implement traits for Boxed trait objects
This is done in order to statisfy trait bounds by types
which use these new trait objects
* Remove Clone usage for sync parameters
* Remove implementation of Default for sync params
* Require that BridgeInstance implements Debug
* Ensure that BridgeInstance trait implements Send/Sync
* Add documentation related to instances
* Rust Fmt
* Remove needless format
* Make instance CLI option case insensitive
* Replace `with_*` constructors with `new`
* Clean up usage of instance structs
* Enforce a default instance in the CLI params
* Build sync params as we process input from CLI
* Remove case insensitivity from sub-tx-mode
I think this should happen, but maybe as part of a different PR
* Process default Eth contract deployment config in CLI
* Build EthereumExchangeParams in CLI
* Process EthereumExchangeSubmitParams params in CLI
* fixed PoA contract deploy (granda_authorities call)
* pause if all submitted headers were rejected
* give funds to Bertha and Carlos
* max 1 active PoA transaction in headers sync :(
* display initial header id when deploying PoA contract
* cargo fmt + clipy
* fix compilation
* Update relays/ethereum/src/sync_types.rs
Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
* Update relays/ethereum/src/utils.rs
Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
* Add Instance type parameter to pallet
* Sketch out what the runtime could look like
* Allow runtime to compile with multiple bridge pallets
* Cargo Fmt
* Allow an instance of a PoA chain to be used with currency-exchange
I specify that it's only _an instance_ instead of _instances_ since the currency-exchange
pallet does not support multiple instances itself. What this commit does is make it so
that the different instances of the PoA chains we currently have are compatible with the
currency-exchange pallet through the implementation of the PeerBlockchain trait.
* Add Instance type parameter to Currency Exchange pallet
* Wire up currency exchange intances in runtime
* Rust Fmt
* Show sccache
* Allow Eth pallet to use a default instance
* Use a default instance in Eth pallet tests
* Remove Rialto and Kovan feature flags
Through some discussions it has been decided that the `bridge-node` should, like
Substrate's `node-template`, be a showcase of the different pallets available in
a project. Because of this I've removed the feature flags for the Rialto and Kovan
networks in favour of having both of them included in the runtime.
* Update the chain_spec to use both Rialto and Kovan configs
* Update pallet level calls used by Substrate client
Allows the project to compile. However, it should be noted that in reality
we shouldn't be hardcoding the pallet we're calling.
* Allow currency-exchange pallet to use a default instance
* Support benchmarking an instance of the Eth pallet
* Update currency exchange benchmarks to work with instances
* Fix test helpers which now need a PoA instance
* Remove Actions for checking Rialto and Kovan features
* Add missing comments
* Update Runtime API string constants
* Add issue number for generic chain support in relay
* Add Runtime APIs for instances of the currency-exchange pallet
* Rust Fmt
Co-authored-by: Denis S. Soldatov aka General-Beck <general.beck@gmail.com>
* Move EthereumRpc implementation to Eth client
* Move SubstrateRpc implementation to SubstrateClient
* Update deploy_contract to use new RPC interface
* Fix some types in the Substrate client
* Swap out method bodies in Eth sync loop
* Swap out method bodies in Substrate sync loop
* Remove Client from SourceClient trait return types
* Remove Client from TargetClient trait return types
* Remove client from Source select! arms
* Remove client from Target select! arms
* Add missing mutable refs in Substrate client
* Use mutable references in Source/Target Client traits
* Try and use mutable references in Source/Client trait implementations
* Handle errors more gracefully
* Remove unused imports
* Remove dead_code and unused_variables lints
* Remove usage of `jsonrpsee::RawClient`
By using a `jsonrpsee::Client` we are able to remove all the shared
mutable references required when interacting with the RPC server. This
is convenient as trying to sharing mutable references in code that uses
async/await is a bit of a pain.
However, using a `Client` instead of a `RawClient` is not yet supported
by the `jsonrpsee::rpc_api` macro, so a fork must be used for the moment.
* Clean up dead code and warnings
* Clean up higher level RPCs
Some of the RPCs that were "high level" didn't necessarily belong
as part of the trait, so they were removed.
* Use positional parameters for RPCs
Both Substrate and Ethereum's RPCs use positional (array) parameters,
so in order to be compatible with both we need to make sure that
our API is defined with positional paramters in mind.
* Rename argument for eth_getBlockByNumber
* Remove some unecessary Ok-wraps
* Process client requests synchonously
Before the refactoring the sync loop would wait until a client finished
handling a request before issuing another one. This behaviour was
inadvertently changed during the refactoring leading to race conditions.
This commit makes sure that the previous behaviour is respected.
* Reduce the errors that are considered a connection error
* Only decode bridge contract once
* Set genesis_config at RPC client startup
* Fetch genesis hash in SubstrateRpcClient::new()
* Move Decode error into SubstrateNodeError
* Suppress warnings caused by `rpc_api!`
* Implement From RpcError for String
* Handle Substrate client initalization errors more gracefully
* Remove match in favour of ?
Co-authored-by: Svyatoslav Nikolsky <svyatonik@gmail.com>
* Use async_trait for SourceClient
* Use aync_trait for TargetClient
* Revert async_trait usage for Source/Target client
This reverts commit f636ffaffd60197e90e887362b4a0c35a0dc5a6c.
This reverts commit 2c15755e8c93318f8e0a605852efe87d72edb769.
I'm having a very hard time finding out what is causing compilation
issues, and I think it's best to start over again.
* Use async_trait for TargetClient
* Use async_trait for SourceClient
* Move where non-async methods are
* RustFmt
* QueuedHeader holds Arc to actual data
* Clean up async return type
Co-authored-by: Svyatoslav Nikolsky <svyatonik@gmail.com>
* Clean up async return type
Co-authored-by: Svyatoslav Nikolsky <svyatonik@gmail.com>
* Clean up async return type
Co-authored-by: Svyatoslav Nikolsky <svyatonik@gmail.com>
* Remove unused import
Co-authored-by: Svyatoslav Nikolsky <svyatonik@gmail.com>
* Test defining an RPC API
* Add wrapper clients for the RPC API
* Implement most Ethereum RPCs
Does not include RPCs that require the bridge contract.
* Implement a few of the Substrate RPCs
Still missing proper error handling, as well as decoding responses from the
Substrate node.
* Make error handling more ergonomic
* Implement Substrate RPCs that use `state_call`
* Implement rest of Substrate RPCs
* Implement `eth_call` RPC
This can be used to implement higher level requests like fetching Substrate headers
from an Ethereum node.
* Build some of the higher level Ethereum RPCs
Uses the new Ethereum RPC interface to do so
* Build some of the higher level Substrate RPCs
* Remove old Ethereum RPC methods
* Remove old Substrate RPC methods
* Add some documentation to Substrate RPCs
* Fix typo in enum construction
* Revert commits `0f0435d` to `ca75502`
This range of commits was mainly trying to integrate the new RPC interface into the existing
codebase, however this turned out to be a little out of scope for the current PR. Instead this work
will be incorporated into a PR which aims to close#72.
* Add documentation to RPCs
* Rename functions in RPC API to conform to snake_case
* Check that header contains a number and hash
* Put doc comments on trait instead of impl methods
* Remove expect() calls
* Replace runtime API enums with consts
* Accept Bytes when submitting extrinsic
Let's us avoid using a runtime specific Extrinsic.
* Add strictly typed arguments to RPC API
Missing two methods right now, which require a `serde::Deserialize`
implemenation before they can be changed.
* Add `chain_getBlock` Substrate RPC
* Use typed arguments for `eth_estimateGas` and `eth_call`
* Silence dead code warnings
* Add check for logs bloom
* Remove unused variables
* Add documentation to RPC error enums
Tomasz Drwięga