320aea743b
Nits for subtree ( #2241 )
...
* Updated version according to Cumulus
* Renaming
* Cargo.lock
2024-04-10 10:28:37 +02:00
ac725ec93f
backport cumulus changes to polkadot-staging ( #2167 )
...
* backport cumulus changes
* bump substrate & polkadot and make it build
* fix runtimes
* bump substrate, polkadot & cumulus
* fix build: remove ump leftovers
* fix tests: disable runtime version check in tests
* fix build: use sp_version::runtime_version macro
Signed-off-by: acatangiu <adrian@parity.io >
2024-04-10 10:28:37 +02:00
564cc5ead7
expose test utilities to be used in BH paras ( #2142 )
...
Signed-off-by: acatangiu <adrian@parity.io >
2024-04-10 10:28:37 +02:00
7188765244
BHK/P alignments ( #2115 )
...
* Constants
* Unused import?
* Cargo.lock
* Unused deps
* TODO: fix doc or reimport?
* Try to aviod redefine para_id constant for `RefundableParachainId`
* Checked and removed TODOs
2024-04-10 10:28:37 +02:00
d479232c34
Small fixes ( #2126 )
2024-04-10 10:28:37 +02:00
56d4013878
Propagate message verification errors ( #2114 )
...
* Propagate message verification errors
* Replace parse_finalized_storage_proof() with storage_proof_checker()
* small fixes
* fix comment
2024-04-10 10:28:37 +02:00
d9757f09c1
Add MessagesPalletInstance for integrity tests ( #2107 )
2024-04-10 10:28:37 +02:00
de918f8f3c
Fix sized messages (Follow-up on #2064 ) ( #2103 )
...
* Use wasm execution on millau and rialto
It's safer like this since here are some errors that aren't caught when
using native execution
* Revert "Revert "Fix max-size messages at test chains (#2064 )" (#2077 )"
This reverts commit 62f749e124fbcf074cdc9840690bb9049d4b3b99.
* Adjustments
2024-04-10 10:28:37 +02:00
49d11e9ce5
Add weight of refund extension post_dispatch to the weights of messages pallet ( #2089 )
...
* add weight of refund extension post_dispatch to the weights of messages pallet
* fixed tests and removed TODO
* verify runtime overhead weight in integrity tests
* add integrity tests to rialto-parachain runtime
* refactor weights a bit
* refund ext is disabled for Rialto <> Millau bridge
* Update bin/runtime-common/src/integrity.rs
Co-authored-by: Adrian Catangiu <adrian@parity.io >
* Update bin/runtime-common/src/integrity.rs
Co-authored-by: Adrian Catangiu <adrian@parity.io >
* Update modules/relayers/src/weights_ext.rs
Co-authored-by: Adrian Catangiu <adrian@parity.io >
---------
Co-authored-by: Adrian Catangiu <adrian@parity.io >
2024-04-10 10:28:37 +02:00
cffc8e3a7b
Bump scale-info from 2.5.0 to 2.6.0
...
Bumps [scale-info](https://github.com/paritytech/scale-info ) from 2.5.0 to 2.6.0.
- [Release notes](https://github.com/paritytech/scale-info/releases )
- [Changelog](https://github.com/paritytech/scale-info/blob/master/CHANGELOG.md )
- [Commits](https://github.com/paritytech/scale-info/commits )
---
updated-dependencies:
- dependency-name: scale-info
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-04-10 10:28:37 +02:00
f7cc060d9b
Nits ( #2083 )
2024-04-10 10:28:37 +02:00
db53d68e9b
Removed relayer_account: &AccountId from MessageDispatch ( #2080 )
...
* SourceBridgeHubChain/TargetBridgeHubChain replaced with RelayerAccountChain
* Fix
* Removed `relayer_account: &AccountId` from `MessageDispatch`
2024-04-10 10:28:37 +02:00
1f8b4d989e
Revert "Fix max-size messages at test chains ( #2064 )" ( #2077 )
...
This reverts commit f904623c65fbad542a878133c612b1f8782f47d1.
2024-04-10 10:28:37 +02:00
65b2196c6b
Fix max-size messages at test chains ( #2064 )
...
* fix max-size messages submit for test chains
* impl review suggestions
2024-04-10 10:28:37 +02:00
53e1b7e264
Slash relayers for invalid transactions ( #2025 )
...
* slash relayer balance for invalid transactions
* require some gap before unstake is possible
* more clippy
* log priority boost
* add issue ref to TODO
* fix typo
* is_message_delivery_call -> is_receive_messages_proof_call
* moved is_receive_messages_proof_call above
* only slash relayers for priority transactions
* Update primitives/relayers/src/registration.rs
Co-authored-by: Adrian Catangiu <adrian@parity.io >
* Update primitives/relayers/src/registration.rs
Co-authored-by: Adrian Catangiu <adrian@parity.io >
* Update bin/runtime-common/src/refund_relayer_extension.rs
Co-authored-by: Adrian Catangiu <adrian@parity.io >
* Update bin/runtime-common/src/refund_relayer_extension.rs
Co-authored-by: Adrian Catangiu <adrian@parity.io >
* Update bin/runtime-common/src/refund_relayer_extension.rs
Co-authored-by: Adrian Catangiu <adrian@parity.io >
* Update modules/relayers/src/lib.rs
Co-authored-by: Adrian Catangiu <adrian@parity.io >
* Update primitives/relayers/src/registration.rs
Co-authored-by: Adrian Catangiu <adrian@parity.io >
* benificiary -> beneficiary
---------
Co-authored-by: Adrian Catangiu <adrian@parity.io >
2024-04-10 10:28:37 +02:00
d7c5de1cc2
Another use of RangeInclusiveExt::checked_len() ( #2060 )
2024-04-10 10:28:37 +02:00
512d43fabe
Revert dispatch-results ( #2048 )
...
* Revert "Reintroduce msg dispatch status reporting (#2027 )"
This reverts commit 38bb051e3d778ee2f5e9451f89cf479a71fd68f8.
* post-revert fix
2024-04-10 10:28:37 +02:00
b8f4086095
Define RangeInclusiveExt ( #2037 )
...
* Define RangeInclusiveExt
* Use RangeInclusiveExt
* Add docs
2024-04-10 10:28:37 +02:00
ea39f4c0d2
Impl review suggestions from #2021 ( #2036 )
...
* unrewarded_relayers for ReceiveMessagesProofInfo only
* simplify return
* removed comment
* appends_to_stored_nonce
2024-04-10 10:28:37 +02:00
f7380490c0
Boost message delivery transaction priority ( #2023 )
...
* reject delivery transactions with at least one obsolete message
* clippy
* boost priority of message delivery transactions: transaction with more messages has larger priority than the transaction with less messages
* apply review suggestion
* CallInfo::bundled_messages
* validate_does_not_boost_priority_of_message_delivery_transactons_with_too_many_messages
* clippy
2024-04-10 10:28:37 +02:00
ceea1a10f7
Reject delivery transactions with at least one obsolete message ( #2021 )
...
* reject delivery transactions with at least one obsolete message
* clippy
* allow empty delivery transactions with rewards confirmations BUT only when there's no room left in the unrewarded relayers vector
* clippy
* allow empty delivery transactions if no message slots in unrewarded relayers vector
2024-04-10 10:28:37 +02:00
3b968a2aba
Reintroduce msg dispatch status reporting ( #2027 )
...
* Use an actual Result inside MessageDispatchResult
We need this in order to distinguish between Ok and Err
* Revert #1660
* Fixes + simplifications
* Implement review suggestions
2024-04-10 10:28:37 +02:00
4d29753f73
only refund if all bundled messages have been delivered ( #2019 )
2024-04-10 10:28:37 +02:00
98542685b1
Remove unneeded error debug strings ( #2017 )
...
* Remove unneeded error debug strings
This reverts commit ff33e6ce127ea22c359b1b0273d6f3a5a27f484c.
2024-04-10 10:28:37 +02:00
1659b4b447
Bump scale-info from 2.4.0 to 2.5.0
...
Bumps [scale-info](https://github.com/paritytech/scale-info ) from 2.4.0 to 2.5.0.
- [Release notes](https://github.com/paritytech/scale-info/releases )
- [Changelog](https://github.com/paritytech/scale-info/blob/master/CHANGELOG.md )
- [Commits](https://github.com/paritytech/scale-info/compare/v2.4.0...v2.5.0 )
---
updated-dependencies:
- dependency-name: scale-info
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-04-10 10:28:37 +02:00
fd3ebdf138
MaxRequests -> MaxFreeMandatoryHeadersPerBlock in pallet-bridge-grandpa ( #1997 )
...
* MaxRequests -> MaxFreeMandatoryHeadersPerBlock in pallet-bridge-grandpa
* fix comment
* fix comment
* fix comment
2024-04-10 10:28:37 +02:00
5fbabb3907
Try check-rustdoc pipeline ( #1782 )
...
* Try check-rustdoc pipeline
* another try
* another try without `--all-features`
* fixed cargo doc issues
* exclude relay-rialto-parachain-client from cargo doc
---------
Co-authored-by: Svyatoslav Nikolsky <svyatonik@gmail.com >
2024-04-10 10:28:37 +02:00
e55d4dd6e0
bump substrate+polkadot refs and fix builds ( #1989 )
...
* bump refs and fix build
* more fixes
* Fix rialto-parachain node
* Update dependencies for tools/runtime-codegen
* Regenerate rialto-parachain indirect runtime
* Fix register_parachain
* Fix clippy
* Undo clippy allow
---------
Co-authored-by: Serban Iorga <serban@parity.io >
2024-04-10 10:28:37 +02:00
830afff353
Added receive_single_message_proof_with_dispatch benchmark ( #1990 )
...
* added receive_single_message_proof_with_dispatch benchmark
* clippy
2024-04-10 10:28:37 +02:00
a75c28d5b2
Remove deprecated code from bridge-runtime-common ( #1983 )
...
* removed FromBridgedChainMessageDispatch in favor of XcmBlobMessageDispatch
* use HaulBlobExporter/HaulBlobExporterAdapter instead of XcmBridge/XcmBridgeAdapter
* tests for sending/dispatching messages
* use new schema in testnet bridges + some cleanup
* clippy
* spelling + added TODO
* cleanup some checks
* benchmarks compilation
* all is XCM
* updated README.md
* ref issue from TODO
2024-04-10 10:28:37 +02:00
2407228972
minor cosmetic updates ( #1985 )
2024-04-10 10:28:37 +02:00
74b0eca59c
added UpdatedBestFinalizedHeader event to pallet-bridge-grandpa ( #1967 )
2024-04-10 10:28:37 +02:00
a1c6502d9a
Backport xcm bridging extensions to the bridge repo ( #1813 )
...
* Backport xcm bridging extensions to the bridge repo
* Fixes
* Fixes
2024-04-10 10:28:37 +02:00
9b44db0fbe
Some error improvements ( #1956 )
...
* Use `HeaderChainError` in parachains module
* Use MessageProofError instead of 'static str in some places
* Avoid implementing Into<'static str> for some errors
We avoid deriving `Debug` for the structs that we use in the runtime and
we derive `RuntimeDebug` instead in order to avoid bloating th eruntime
with static strs. But implementing `Into<'static str>` does the same. So
in some places it makes sense to replace `Into<'static str>` with `Debug`.
* Move the messages error definition
Move the messages error definition outside of `mod target`
2024-04-10 10:28:37 +02:00
3a145e5844
get rid of obsolete weight functions ( #1926 )
2024-04-10 10:28:37 +02:00
aa466a485d
Fix benchmarks ( #1919 )
...
* fixed benchmarks broken by rejecting storage proofs with excessive trie nodes and justifications with extra prevotes
* update weights
* fmt
* accidental paste
* revert changes to millau runtime (separate PR)
* revert comment change
2024-04-10 10:28:37 +02:00
ba155f990f
Refund messages confirmation tx ( #1904 )
...
* Refund messages confirmation tx
* Fixes
2024-04-10 10:28:37 +02:00
f5fee288b9
Relayers pallet: extend payment source id ( #1907 )
...
* Add Chain::ID const
* Relayers pallet: extend payment source id
* Addressed code review comments
* Fix benchmarks
* Fix dashboards
* Renamings
* Fix compilation
2024-04-10 10:28:37 +02:00
498a3e83d0
Weight+size limits for bridge GRANDPA pallet calls ( #1882 )
...
* weight+size limits for bridge GRANDPA pallet calls
* continue
* fixed all tests
* some changes to refund computations
* post_dispatch_refunds_relayer_in_all_finality_batch_with_extra_weight
* - dup code
* do not return Pays::No if call is above weight/size limits
* relayer_pays_tx_fee_when_submitting_huge_mandatory_header and relayer_pays_tx_fee_when_submitting_justification_with_long_ancestry_votes
* clippy
* fmt
* clippy
* small change in docs
* fixed GRANDPA-limits constants for Polkadot-like chains
* clippy
* clippy + spelling
* Update primitives/polkadot-core/src/lib.rs
Co-authored-by: Adrian Catangiu <adrian@parity.io >
* Update bin/runtime-common/src/refund_relayer_extension.rs
Co-authored-by: Adrian Catangiu <adrian@parity.io >
* reverted unnecessary change
* GrandpaJustification::max_reasonable_size
---------
Co-authored-by: Adrian Catangiu <adrian@parity.io >
2024-04-10 10:28:37 +02:00
623bd85a5e
RefundRelayerForMessagesFromParachain improvements ( #1895 )
...
* RefundRelayerForMessagesFromParachain changes
- some renamings and cosmetics
- removing the GI generic param since we can get it from the parachains
config
- merging (Parachains Instance, Parachain Id) and (Messages Instance,
Messages lane Id) generic params
- removing unnecessay derives
- renaming for the `TransactionFeeCalculation` and defining
`ActualFeeRefund` concrete implementation
- adding support for multiple RefundRelayerForMessagesFromParachain
(by adding a `StaticStrProvider` generic param)
* Revert to using RuntimeDebug
2024-04-10 10:28:37 +02:00
c6c39be967
ChainWithGrandpa in primitives ( #1885 )
...
* ChainWithGrandpa in primitives
* clippy ++ spelling
* fix benchmarks comppilation
2024-04-10 10:28:37 +02:00
914213d0af
Fix clippy issues ( #1884 )
...
* fix clippy issues
* fix?
* fix?
* forget about extra_unused_type_parameters lint for now
2024-04-10 10:28:37 +02:00
25c17feb23
Reject storage proofs with unused nodes: begin ( #1878 )
...
* reject storage proofs with unused nodes: begin
* fix ignores_parachain_head_if_it_is_missing_from_storage_proof
* message_proof_is_rejected_if_it_has_duplicate_trie_nodes && message_proof_is_rejected_if_it_has_unused_trie_nodes
* proof_with_duplicate_items_is_rejected and proof_with_unused_items_is_rejected
* clippy
* fix benchmarks compilation
* impl From<Error> for &'static str
* fix review comments
* added comment
2024-04-10 10:28:37 +02:00
c9c6d566d0
RefundRelayerForMessagesFromParachain improvements ( #1879 )
...
* RefundRelayerForMessagesFromParachain improvements
* Address code review comments
2024-04-10 10:28:37 +02:00
2657973bb8
fix bridge-runtime-common build ( #1839 )
2024-04-10 10:28:37 +02:00
c8c606dd66
Functions to benchmark messages pallet with linked to parachain ( #1817 )
...
* functions to benchmark messages pallet with linked to parachain
* unused imports
* fmt
2024-04-10 10:28:37 +02:00
1f727beb5d
Remove InboundPayload check ( #1816 )
2024-04-10 10:28:37 +02:00
1b608e4b9f
No wildcard patterns in Cargo.toml ( #1789 )
...
* dependabot doesn't support wildcard patterns in cargo.toml and we want dependabot
* spelling for "fresh" crates
* and fmt
* spelling again
2024-04-10 10:28:37 +02:00
ec9cd8ddb0
Remove chain-specific dependencies from crates that will be used in Cumulus ( #1783 )
...
* leave-modules.sh
* remove bp-rialto dependency from bp-relayers
* update leave-modules.sh
* fix Cargo.toml of pallet-bridge-relayers
* update leave-modules.sh
* remove bp-rialto and millau-runtime frombridge-runtime-common Cargo.toml
* update leave-modules.sh
* remove chain dependencies from bridge-runtime-common crate
* fix tests
* cleanup script
* rename script
* kind of success message
* remove leave-modules.sh
* use TargetHeaderChainAdapter and SourceHeaderChainAdapter in our testnets
* update script
2024-04-10 10:28:37 +02:00
2ff3a7aa38
Add integrity check for signed extensions ( #1780 )
...
* Add integrity check for signed extensions
* Remove unneeded type specification
2024-04-10 10:28:37 +02:00
Branislav Kontur