Commit Graph

195 Commits

Author SHA1 Message Date
Pierre Krieger 4366e68d08 Fix alert about delay between best and finalized block (#9150)
* Fix alert about delay between best and finalized block

* Revert debugging changes
2021-06-23 15:17:10 +00:00
Pierre Krieger 1eca7767fe Add substrate-rpc-subscription to exceptions in alert (#9172) 2021-06-22 16:11:42 +00:00
radupopa2010 43422ba440 READY Update simnet tests to v5 (#8946)
* Update simnet tests to v4

* enable simnet tests for PRs

* add stage to job "test-linux-stable-int"

* v2.0.0simnet

* alow build-for-simnet option

* Fix passing of IMAGE_TAG to downstream

* forgot to build-for-simnet

* build-for-simnet

* build-for-simnet

* build-for-simnet

* build-for-simnet

* build-for-simnet

* take a shortcut build-for-simnet

* build-for-simnet

* update triggering script to polkadot version

* "revert me"

* "revert me"  build-for-simnet

* add simnet version as arg to script

* revert me build-for-simnet

* build-for-simnet

* remove triggering simnet for PRs for now

* Add suggestions from Vladimir

* Add suggestions from Vladimir
2021-06-09 13:51:27 +00:00
Alexander Theißen bf9837499a Fix check runtime CI (#8930)
* Fix check_runtime.sh script

* contracts: Remove confusing "Related Modules" doc
2021-05-28 09:33:22 +00:00
Denis Pisarev 95e296dea3 CI: fix simnet trigger (#8927)
* CI: chore

* CI: pin simnet version
2021-05-27 20:31:29 +02:00
Denis Pisarev a28a517c53 Fix build job (#8905)
* CI: fix node-template packaging

* add explicit deps versions
2021-05-25 23:01:00 +02:00
Pierre Krieger ff60db4c41 Update the Grafana dashboards (#8832)
* Update the Grafana dashboards

* Remove the panels on top
2021-05-20 08:34:52 +00:00
ddorgan 9e9527d756 Make some alerts warnings instead of critical (#8739) 2021-05-06 08:43:53 +01:00
François Garillot 052be8bbef Simplify some Option / Result / ? operator patterns (#8653)
* Simplify some Option / Result / ? operator patterns

When those match a combinator exactly.

Tool-aided by [comby-rust](https://github.com/huitseeker/comby-rust).

* adjust after review

* adjust post-review
2021-04-23 13:36:10 +00:00
Denis Pisarev 4dcbac4b58 CI updates (#8633)
* CI: opt bench jobs; add bench to triggered job

* CI: no need in manual builds; build=publish

* CI: more logs to the trigger job

* CI: DAGs and louts
2021-04-16 21:35:08 +02:00
Denis Pisarev 6679b88af8 WIP: fix Simnet trigger (#8493)
* CI: trigger guard [skip ci]

* CI: variables and dotenv [skip ci]

* CI: correct variable for simnet trigger

* CI: correct rules for simnet trigger

* fix linting issue :)

* CI: trigger simnet via API

Co-authored-by: radupopa2010 <radupopa2010@yahoo.com>
2021-04-13 01:29:21 +02:00
Robert Habermeier 1f67933afc remove real-overseer from polkadot compilation flags (#8560)
* remove real-overseer

* remove unneeded
2021-04-08 15:13:12 +02:00
Martin Pugh 467f42b5b3 fix monthly tags (#8554) 2021-04-07 12:52:02 +02:00
Jimmy Chu fb73a4eef6 Enhancement on Substrate Node Template (#8473)
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Co-authored-by: Alexander Popiak <alexander.popiak@parity.io>
2021-03-30 07:47:37 +08:00
Bastian Köcher 3e64293bd4 Fix companion check (#8464) 2021-03-26 14:59:05 +00:00
Bastian Köcher 6adf24ca0c Change companion check order (#8460)
* Change companion check order

Apparently if the pr isn't approved it counts as not mergable. However,
this is rahter confusing. To fix this, we just change the order.

* Move exit
2021-03-26 14:21:00 +01:00
Gavin Wood 956262a182 Fix CI for new labels (#8432)
* Fix up CI/CD for the new labels.

* New labels.

* Fix labels

* Fix labels

* Fix accidental change
2021-03-23 12:10:03 +01:00
Martin Pugh da6bf01ad9 add D1-trivial label (#8388) 2021-03-17 20:04:53 +00:00
Martin Pugh d6bc59df58 [CI] Require D*-audit labels for any runtime changes (#8345)
* add check for audit labels if runtime change

* fix shellcheck nits

* include lib.sh in check_runtime.sh

* fix check_labels.sh

* fix check_labels.sh

* oops, this is github actions...

* why wont this work

* fetch all refs

* Update check-labels.yml

* print env - wtf is happening

* checkout the PR...

* ffs

* fix

* REVERT ME: test runtime check

* Revert "REVERT ME: test runtime check"

This reverts commit 0fd2b04abeeac12dd8ede4c0708cb796f9e3e722.
2021-03-16 18:09:24 +01:00
Bastian Köcher 2cc9329b09 Update diener to enable polkadot companions that use new crates (#8371)
* Update diener to enable polkadot companions that use new crates

Diener will be updated in the CI image to make it possible to have
companions that add new crates from Substrate.

Besides that the wasm-bindgen is updated, because `0.2.70` is not
available anymore on crates.io.

* update lock

Co-authored-by: kianenigma <kian@parity.io>
2021-03-16 15:42:56 +01:00
gabriel klawitter d7ef668a30 alerting-rules: ContinuousTaskEnded alert should not drop all unspecified labels (#8369) 2021-03-16 13:44:05 +01:00
Guillaume Thiolliere 9c4e4d453c Fix doc build with --all-features (#8277)
* implement

* make default pre/post_upgrade

* simplify Cargo.toml

* revert removal of outdated/private links

* link in pallet-mmr
2021-03-05 16:08:44 +01:00
Pierre Krieger 9e84a5405c Add a Prometheus alert on no incoming connection (#7517) 2021-02-23 10:05:39 +01:00
Denis Pisarev 82e52b8be8 CI: test and update ci image, codeowners (#8142)
* CI: prep for the new ff deployment

* CI: variable for CI image

* git: add CI team and remove Max from CODEOWNERS

* CI: diener should be updated in CI image, not here.

* CI: diener should be updated in CI image, not here.

* CI: run cargo deny on changes to manifests and lock; run build jobs on schedules [skip ci]

* CI: remove flaming-fir deployment, it will be handled from s3 updates [skip ci]

* CI: trigger simnet with a certain substrate version

* CI: remove cargo-audit in favor of cargo-deny; prepare for being triggered

* CI: prepare to be triggered

* CI: chore
2021-02-19 15:48:08 +01:00
Pierre Krieger 11894bc21a Update Grafana dashboards (#8127) 2021-02-15 16:47:57 +00:00
Martin Pugh 07e4b9c997 [CI] Move check_labels to github actions (#8099)
* move lib.sh to common dir

* make check-labels a github action workflow
2021-02-11 13:34:43 +01:00
Bastian Köcher fd5fbd6252 Switch to use diener patch for companion build (#8073)
This switch to the new `diener patch` command to patch all Substrate
crates in Polkadot. This should remove the requirement to manually merge
Substrate master to make the companion build, as we now would use the
already with master merged code from this build job local checkout.
2021-02-10 12:38:29 +01:00
Pierre Krieger de838f9464 Remove outdated Grafana information (#8012) 2021-02-01 17:17:44 +01:00
Denis Pisarev 9c0f51ab8b CI: return flaming fir deployment (#8007)
* CI: return flaming-fir deployment jobs

* CI: no need in manual jobs; 'updated image'
2021-01-29 19:07:26 +01:00
Max Inden 9031c35114 .maintain: Replace sentry-node with local-docker-test-network (#7943)
Sentry nodes are deprecated. Thus there is no need for
`.maintain/sentry-node` to spin up a sentry node test environment.
Instead this commit rewrites the setup to contain two full-connected
validators and one light client.

With the steps below one can now spin up a local test network with
two validators, one light-client, Prometheus and Grafana.

- cargo build --release
- sudo docker-compose -f .maintain/local-docker-test-network/docker-compose.yml up
2021-01-21 09:29:50 +00:00
Pierre Krieger 2e44ffb7a7 Increase UnboundedChannelVeryLarge threshold from 5k to 15k (#7931) 2021-01-19 15:33:38 +01:00
Gavin Wood f1d36a7103 Introduces account existence providers reference counting (#7363)
* Initial draft

* Latest changes

* Final bits.

* Fixes

* Fixes

* Test fixes

* Fix tests

* Fix babe tests

* Fix

* Fix

* Fix

* Fix

* Fix

* fix warnings in assets

* Fix UI tests

* fix line width

* Fix

* Update frame/system/src/lib.rs

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

* Update frame/system/src/lib.rs

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

* Fix

* fix unused warnings

* Fix

* Update frame/system/src/lib.rs

Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>

* Update frame/system/src/lib.rs

Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>

* Fix

* fix slash and comprehensive slash test

* fix reserved slash and comprehensive tests

* check slash on non-existent account

* Revert "Fix UI tests"

This reverts commit e0002c0f13442f7d0c95a054a6c515536328a4a0.

* Fix

* Fix utility tests

* keep dispatch error backwards compatible

* Fix

* Fix

* fix ui test

* Companion checker shouldn't be so anal.

* Fix

* Fix

* Fix

* Apply suggestions from code review

Co-authored-by: Alexander Popiak <alexander.popiak@parity.io>

* Update frame/balances/src/lib.rs

Co-authored-by: Alexander Popiak <alexander.popiak@parity.io>

* return correct slash info when failing gracefully

* fix missing import

* Update frame/system/src/lib.rs

Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>

* Fix

* Update frame/balances/src/tests_local.rs

Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>

* Fixes

Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
Co-authored-by: Alexander Popiak <alexander.popiak@parity.io>
2021-01-16 18:47:28 +01:00
Denis Pisarev 3ee8b66e7d tests: fix UI test so we can update CI image (#7901)
* tests: fix UI test so we can update CI image

* CI: remove diener installation from the script as it's installed in CI image

* tests: another fix

* tests: fix another fix

* tests: NLoEOF

* tests: another broken stderr
2021-01-14 22:00:41 +01:00
Denis Pisarev 086c7946ca CI: trigger simnet master and wait for status (#7899)
* CI: trigger simnet master and wait for status

* chore: remove leftovers from chaosnet; remove flaming-fir deployment
2021-01-14 19:44:53 +01:00
Pierre Krieger c49ed20aec Update the Grafana dashboards (#7886) 2021-01-14 13:35:46 +00:00
Pierre Krieger 7dc47ab93d Add Prometheus alerts if unbounded channels are too large (#7866)
* Add Prometheus alerts if unbounded channels are too large

* Tweaks
2021-01-12 09:59:17 +01:00
Max Inden 3f629f743b client/network: Use request response for block requests (#7478)
* client/network: Add scaffolding for finality req to use req resp
	#sc

* client/network/src/finality_requests: Remove

* client/network/src/behaviour: Pass request id down to sync

* client/network: Use request response for block requests

* client/network: Move handler logic into *_*_handler.rs

* client/network: Track ongoing finality requests in protocol.rs

* client/network: Remove commented out finalization initialization

* client/network: Add docs for request handlers

* client/network/finality_request_handler: Log errors

* client/network/block_request_handler: Log errors

* client/network: Format

* client/network: Handle block request failure

* protocols/network: Fix tests

* client/network/src/behaviour: Handle request sending errors

* client/network: Move response handling into custom method

* client/network/protocol: Handle block response errors

* client/network/protocol: Remove tracking of obsolete requests

* client/network/protocol: Remove block request start time tracking

This will be handled generically via request-responses.

* client/network/protocol: Refactor on_*_request_started

* client/network: Pass protocol config instead of protocol name

* client/network: Pass protocol config in tests

* client/network/config: Document request response configs

* client/network/src/_request_handler: Document protocol config gen

* client/network/src/protocol: Document Peer request values

* client/network: Rework request response to always use oneshot

* client/network: Unified metric reporting for all request protocols

* client/network: Move protobuf parsing into protocol.rs

* client/network/src/protocol: Return pending events after poll

* client/network: Improve error handling and documentation

* client/network/behaviour: Remove outdated error types

* Update client/network/src/block_request_handler.rs

Co-authored-by: Ashley <ashley.ruglys@gmail.com>

* Update client/network/src/finality_request_handler.rs

Co-authored-by: Ashley <ashley.ruglys@gmail.com>

* client/network/protocol: Reduce reputation on timeout

* client/network/protocol: Refine reputation changes

* client/network/block_request_handler: Set and explain queue length

* client/service: Deny block requests when light client

* client/service: Fix role matching

* client: Enforce line width

* client/network/request_responses: Fix unit tests

* client/network: Expose time to build response via metrics

* client/network/request_responses: Fix early connection closed error

* client/network/protocol: Fix line length

* client/network/protocol: Disconnect on most request failures

* client/network/protocol: Disconnect peer when oneshot is canceled

* client/network/protocol: Disconnect peer even when connection closed

* client/network/protocol: Remove debugging log line

* client/network/request_response: Use Clone::clone for error

* client/network/request_response: Remove outdated comment

With libp2p v0.33.0 libp2p-request-response properly sends inbound
failures on connections being closed.

Co-authored-by: Addie Wagenknecht <addie@nortd.com>
Co-authored-by: Ashley <ashley.ruglys@gmail.com>
2021-01-05 18:20:54 +00:00
Bastian Köcher e3e651f72c Happy new year (#7814)
* Happy new year

Updates the copyright years and fixes wrong license headers.

* Fix the template

* Split HEADER into HEADER-APACHE & HEADER-GPL
2021-01-04 09:03:13 +00:00
Shawn Tabrizi 62bdfaa87a Fix UI Tests (#7722)
* Fix UI tests

* make updates.

* Revert "make updates."

This reverts commit 3f41979c12e86acb75fd086675ac09659dde533e.

* Try to fix companion build

* Use some depth

* tests: fix UI tests on the latest nightly

* tests: fix polkadot companion test, depth

* chore: update deps

* chore: update deps

* chore: sp-io

Co-authored-by: kianenigma <kian.peymani@gmail.com>
Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: Denis P <denis.pisarev@parity.io>
2020-12-19 16:16:34 +01:00
Bastian Köcher 5a19ece7e3 Fix polkadot companion test (#7732) 2020-12-15 10:28:40 +01:00
Bastian Köcher 588461f52a Make sure the companion CI test fails on any error (#7683) 2020-12-07 16:48:54 +01:00
Shawn Tabrizi 4b8cee9e55 Add Standard Error to Weight Template (#7652)
* Add standard error to weight template

* fix test compile
2020-12-04 22:09:19 +01:00
Guillaume Thiolliere 15b0dece54 Renames of Trait to Config in README.md, weight templates and few minor ones (#7636)
* manual rename

* renamse in README.md

* fix template
2020-11-30 20:33:49 +00:00
Max Inden d692d173f2 client/authority-discovery: Publish and query on exponential interval (#7545)
* client/authority-discovery: Publish and query on exponential interval

When a node starts up publishing and querying might fail due to various
reasons, for example due to being not yet fully bootstrapped on the DHT.
Thus one should retry rather sooner than later. On the other hand, a
long running node is likely well connected and thus timely retries are
not needed. For this reasoning use an exponentially increasing interval
for `publish_interval`, `query_interval` and
`priority_group_set_interval` instead of a constant interval.

* client/authority-discovery/src/interval.rs: Add license header

* .maintain/gitlab: Ensure adder collator tests are run on CI
2020-11-23 16:34:37 +00:00
André Silva 1871a95088 grandpa: remove light-client specific block import pipeline (#7546)
* grandpa: remove light-client specific block import

* consensus, network: remove finality proofs
2020-11-23 14:28:55 +00:00
Alexander Theißen f06625f03c Fix weight template to remove ugliness in rust doc (#7565)
fixed weight template
2020-11-20 13:24:02 +01:00
Bastian Köcher 9704c204e6 Run polkadot companion tests with correct feature enabled (#7507) 2020-11-09 14:33:45 +01:00
Denis Pisarev 3c50838dc3 CI: markdown link checker (#7145)
* change (CI): markdown link checker

* Fix some invalid doc links (re-run of cargo-unleash gen-readme w/ fixes).

* Fix some invalid doc links

* Fix some invalid doc links

* Fix some links

* Fix some links

* Apply @bkchr suggestions from code review

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

* Fix more links

* Fix more links

* typo

* Fix more links

* Fix more links

* Ignore valid link .. check wrongly sees it as invalid

* Fix style issue

* Fix style issue

* change (CI): update style guide link

* change (lib): suggestions

Co-authored-by: Dan Forbes <dan@danforbes.dev>
Co-authored-by: Steve Degosserie <steve@parity.io>
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
2020-11-05 19:18:55 +01:00
Pierre Krieger a12df194c6 Exclude basic-authorship-proposer from the continuous tasks alert (#7484) 2020-11-04 14:01:37 +01:00
Guillaume Thiolliere 1679919830 Fix benchmarks template whitespaces (#7447)
* fix

* actual fix

* cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_democracy --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/democracy/src/weights.rs --template=./.maintain/frame-weight-template.hbs

* cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=frame_system --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/system/src/weights.rs --template=./.maintain/frame-weight-template.hbs

* Update frame/system/src/weights.rs

Co-authored-by: Parity Benchmarking Bot <admin@parity.io>
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
2020-10-28 13:34:03 +00:00