7dc47ab93d
Add Prometheus alerts if unbounded channels are too large ( #7866 )
...
* Add Prometheus alerts if unbounded channels are too large
* Tweaks
2021-01-12 09:59:17 +01:00
3f629f743b
client/network: Use request response for block requests ( #7478 )
...
* client/network: Add scaffolding for finality req to use req resp
#sc
* client/network/src/finality_requests: Remove
* client/network/src/behaviour: Pass request id down to sync
* client/network: Use request response for block requests
* client/network: Move handler logic into *_*_handler.rs
* client/network: Track ongoing finality requests in protocol.rs
* client/network: Remove commented out finalization initialization
* client/network: Add docs for request handlers
* client/network/finality_request_handler: Log errors
* client/network/block_request_handler: Log errors
* client/network: Format
* client/network: Handle block request failure
* protocols/network: Fix tests
* client/network/src/behaviour: Handle request sending errors
* client/network: Move response handling into custom method
* client/network/protocol: Handle block response errors
* client/network/protocol: Remove tracking of obsolete requests
* client/network/protocol: Remove block request start time tracking
This will be handled generically via request-responses.
* client/network/protocol: Refactor on_*_request_started
* client/network: Pass protocol config instead of protocol name
* client/network: Pass protocol config in tests
* client/network/config: Document request response configs
* client/network/src/_request_handler: Document protocol config gen
* client/network/src/protocol: Document Peer request values
* client/network: Rework request response to always use oneshot
* client/network: Unified metric reporting for all request protocols
* client/network: Move protobuf parsing into protocol.rs
* client/network/src/protocol: Return pending events after poll
* client/network: Improve error handling and documentation
* client/network/behaviour: Remove outdated error types
* Update client/network/src/block_request_handler.rs
Co-authored-by: Ashley <ashley.ruglys@gmail.com >
* Update client/network/src/finality_request_handler.rs
Co-authored-by: Ashley <ashley.ruglys@gmail.com >
* client/network/protocol: Reduce reputation on timeout
* client/network/protocol: Refine reputation changes
* client/network/block_request_handler: Set and explain queue length
* client/service: Deny block requests when light client
* client/service: Fix role matching
* client: Enforce line width
* client/network/request_responses: Fix unit tests
* client/network: Expose time to build response via metrics
* client/network/request_responses: Fix early connection closed error
* client/network/protocol: Fix line length
* client/network/protocol: Disconnect on most request failures
* client/network/protocol: Disconnect peer when oneshot is canceled
* client/network/protocol: Disconnect peer even when connection closed
* client/network/protocol: Remove debugging log line
* client/network/request_response: Use Clone::clone for error
* client/network/request_response: Remove outdated comment
With libp2p v0.33.0 libp2p-request-response properly sends inbound
failures on connections being closed.
Co-authored-by: Addie Wagenknecht <addie@nortd.com >
Co-authored-by: Ashley <ashley.ruglys@gmail.com >
2021-01-05 18:20:54 +00:00
e3e651f72c
Happy new year ( #7814 )
...
* Happy new year
Updates the copyright years and fixes wrong license headers.
* Fix the template
* Split HEADER into HEADER-APACHE & HEADER-GPL
2021-01-04 09:03:13 +00:00
62bdfaa87a
Fix UI Tests ( #7722 )
...
* Fix UI tests
* make updates.
* Revert "make updates."
This reverts commit 3f41979c12e86acb75fd086675ac09659dde533e.
* Try to fix companion build
* Use some depth
* tests: fix UI tests on the latest nightly
* tests: fix polkadot companion test, depth
* chore: update deps
* chore: update deps
* chore: sp-io
Co-authored-by: kianenigma <kian.peymani@gmail.com >
Co-authored-by: Bastian Köcher <git@kchr.de >
Co-authored-by: Denis P <denis.pisarev@parity.io >
2020-12-19 16:16:34 +01:00
5a19ece7e3
Fix polkadot companion test ( #7732 )
2020-12-15 10:28:40 +01:00
588461f52a
Make sure the companion CI test fails on any error ( #7683 )
2020-12-07 16:48:54 +01:00
4b8cee9e55
Add Standard Error to Weight Template ( #7652 )
...
* Add standard error to weight template
* fix test compile
2020-12-04 22:09:19 +01:00
15b0dece54
Renames of Trait to Config in README.md, weight templates and few minor ones ( #7636 )
...
* manual rename
* renamse in README.md
* fix template
2020-11-30 20:33:49 +00:00
d692d173f2
client/authority-discovery: Publish and query on exponential interval ( #7545 )
...
* client/authority-discovery: Publish and query on exponential interval
When a node starts up publishing and querying might fail due to various
reasons, for example due to being not yet fully bootstrapped on the DHT.
Thus one should retry rather sooner than later. On the other hand, a
long running node is likely well connected and thus timely retries are
not needed. For this reasoning use an exponentially increasing interval
for `publish_interval`, `query_interval` and
`priority_group_set_interval` instead of a constant interval.
* client/authority-discovery/src/interval.rs: Add license header
* .maintain/gitlab: Ensure adder collator tests are run on CI
2020-11-23 16:34:37 +00:00
1871a95088
grandpa: remove light-client specific block import pipeline ( #7546 )
...
* grandpa: remove light-client specific block import
* consensus, network: remove finality proofs
2020-11-23 14:28:55 +00:00
f06625f03c
Fix weight template to remove ugliness in rust doc ( #7565 )
...
fixed weight template
2020-11-20 13:24:02 +01:00
9704c204e6
Run polkadot companion tests with correct feature enabled ( #7507 )
2020-11-09 14:33:45 +01:00
3c50838dc3
CI: markdown link checker ( #7145 )
...
* change (CI): markdown link checker
* Fix some invalid doc links (re-run of cargo-unleash gen-readme w/ fixes).
* Fix some invalid doc links
* Fix some invalid doc links
* Fix some links
* Fix some links
* Apply @bkchr suggestions from code review
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Fix more links
* Fix more links
* typo
* Fix more links
* Fix more links
* Ignore valid link .. check wrongly sees it as invalid
* Fix style issue
* Fix style issue
* change (CI): update style guide link
* change (lib): suggestions
Co-authored-by: Dan Forbes <dan@danforbes.dev >
Co-authored-by: Steve Degosserie <steve@parity.io >
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
2020-11-05 19:18:55 +01:00
a12df194c6
Exclude basic-authorship-proposer from the continuous tasks alert ( #7484 )
2020-11-04 14:01:37 +01:00
1679919830
Fix benchmarks template whitespaces ( #7447 )
...
* fix
* actual fix
* cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_democracy --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/democracy/src/weights.rs --template=./.maintain/frame-weight-template.hbs
* cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=frame_system --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/system/src/weights.rs --template=./.maintain/frame-weight-template.hbs
* Update frame/system/src/weights.rs
Co-authored-by: Parity Benchmarking Bot <admin@parity.io >
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com >
2020-10-28 13:34:03 +00:00
e4cfb2556d
New Weight Template + Organization ( #7391 )
...
* add_handlebar_template_to_benchmark
- add benchmark-cli arg to take in a handlebar-template file
* update to always use template
* rewrite writer for handlebars
* polish
* pass cmd data
* update docs
* new weight layout
* separate templates
* support custom filename output
* Update command.rs
* Create frame-weight-template.hbs
* use a vector to maintain benchmark order
* bring back ()
* fix tests
* fix build
* Custom string serializer, remove feature flag
* temp
* rename
* nit
* update docs
* docs on public objects
* small fix
* cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_balances --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/balances/src/weights.rs --template=./.maintain/frame-weight-template.hbs
* remove long line
* cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_balances --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/balances/src/weights.rs --template=./.maintain/frame-weight-template.hbs
* cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=frame_system --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/system/src/weights.rs --template=./.maintain/frame-weight-template.hbs
* update for system
* cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/staking/src/weights.rs --template=./.maintain/frame-weight-template.hbs
* update for staking
* cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_identity --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/identity/src/weights.rs --template=./.maintain/frame-weight-template.hbs
* update for identity and staking
* cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_collective --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/collective/src/weights.rs --template=./.maintain/frame-weight-template.hbs
* update for collective
* cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_democracy --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/democracy/src/weights.rs --template=./.maintain/frame-weight-template.hbs
* update for democracy
* clean up zeros
* cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_elections_phragmen --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/elections-phragmen/src/weights.rs --template=./.maintain/frame-weight-template.hbs
* update for elections phragmen
* cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_im_online --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/im-online/src/weights.rs --template=./.maintain/frame-weight-template.hbs
* update for im online
* cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_indices --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/indices/src/weights.rs --template=./.maintain/frame-weight-template.hbs
* update for indices
* cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_multisig --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/multisig/src/weights.rs --template=./.maintain/frame-weight-template.hbs
* update for multisig
* cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_proxy --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/proxy/src/weights.rs --template=./.maintain/frame-weight-template.hbs
* update for proxy
* cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_scheduler --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/scheduler/src/weights.rs --template=./.maintain/frame-weight-template.hbs
* update for scheduler
* cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_session --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/session/src/weights.rs --template=./.maintain/frame-weight-template.hbs
* update for session
* cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_timestamp --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/timestamp/src/weights.rs --template=./.maintain/frame-weight-template.hbs
* update for timestamp
* cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_treasury --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/treasury/src/weights.rs --template=./.maintain/frame-weight-template.hbs
* update for treasury
* cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_utility --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/utility/src/weights.rs --template=./.maintain/frame-weight-template.hbs
* update for utility
* cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_vesting --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/vesting/src/weights.rs --template=./.maintain/frame-weight-template.hbs
* update for vesting
* temp update
* cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_utility --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/utility/src/weights.rs --template=./.maintain/frame-weight-template.hbs
Co-authored-by: Ezadkiel Marbella <zadkiel.m@gmail.com >
Co-authored-by: Parity Benchmarking Bot <admin@parity.io >
2020-10-27 20:26:12 +00:00
3ac070b61e
Use Handlebars Template for Benchmark CLI Output ( #7390 )
...
* add_handlebar_template_to_benchmark
- add benchmark-cli arg to take in a handlebar-template file
* update to always use template
* rewrite writer for handlebars
* polish
* pass cmd data
* update docs
* support custom filename output
* Update command.rs
* Create frame-weight-template.hbs
* use a vector to maintain benchmark order
* fix tests
* Custom string serializer, remove feature flag
* update docs
* docs on public objects
* small fix
Co-authored-by: Ezadkiel Marbella <zadkiel.m@gmail.com >
2020-10-27 12:25:57 +00:00
da8ce4f258
remove github release action ( #7338 )
2020-10-16 16:27:20 +02:00
0ff724c939
.maintain/monitoring: Add alert when continuous task ends ( #7250 )
...
* .maintain/monitoring: Add alert when continuous task ends
Through the `polkadot_tasks_ended_total` Prometheus metric one can tell
when a task ended. Use this metric to alert when specific
known-to-be-continuous tasks end on a node.
* .maintain/monitoring: Don't hard-code task names
2020-10-05 08:40:24 +00:00
51c0d27aa1
.maintain/monitoring: Normalize alerting rules ( #7232 )
...
* .maintain/monitoring: Normalize alerting rules
- Start alert names with their component and end with the describing
adjective.
- Describe alert duration in `message` with `for more than` across all
alerts.
* .maintain/monitoring: Fix alert tests
2020-09-30 08:48:48 +00:00
b4aa5f328e
Update networking Prometheus dashboard ( #7180 )
2020-09-24 09:30:27 +00:00
649bee1a1e
Make sure we update the Cargo.lock in the polkadot companion ( #7135 )
2020-09-17 22:07:25 +00:00
a5ef77b86a
fix js dependancy alert, bumping bl version ( #7110 )
...
* fix js dependancy alert, bumping bl version
* fix low severity modules
2020-09-15 17:17:14 +02:00
5c1ae5f405
Use diener for Polkadot companion prs ( #7102 )
...
* Use diener for Polkadot companion prs
* Fix script
* Use gitlab env variable
* Update .maintain/gitlab/check_polkadot_companion_build.sh
Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com >
Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com >
2020-09-15 00:10:02 +02:00
7c7ad18d4e
Update the service tasks Grafana dashboard ( #7038 )
2020-09-08 09:59:37 +00:00
f04afd596b
.maintain/monitoring/alerting-rules: Add fd alert ( #6946 )
...
Alert on high file descriptor allocation.
2020-08-24 15:37:07 +02:00
bcc1b7c146
add runtime migrations to release notes/changelog ( #6875 )
2020-08-13 16:54:05 +00:00
5a81eb86c4
Bump elliptic from 6.5.2 to 6.5.3 in /.maintain/chaostest ( #6791 )
...
Bumps [elliptic](https://github.com/indutny/elliptic ) from 6.5.2 to 6.5.3.
- [Release notes](https://github.com/indutny/elliptic/releases )
- [Commits](https://github.com/indutny/elliptic/compare/v6.5.2...v6.5.3 )
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-08-03 10:52:43 +02:00
63bd1d8346
Add the Substrate Service Tasks dashboard ( #6665 )
2020-07-27 09:34:02 +00:00
36e312088e
[CI]Chaostest suite initiation ( #5793 )
...
* Initiate chaostest cli test suite: singlenodeheight on one dev node
Added chaostest stages in CI
Added new docker/k8s resources and environments to CI
Added new chaos-only tag to gitlab-ci.yml
* Update .maintain/chaostest/src/commands/singlenodeheight/index.js
Co-authored-by: Max Inden <mail@max-inden.de >
* change nameSpace to namespace(one word)
* update chaos ci job to match template
* rename build-pr ci stage to docker [chaos:basic]
* test gitlab-ci [chaos:basic]
* Update .gitlab-ci.yml
* add new build-chaos-only condition
* add *default-vars to singlenodeheight [chaos:basic]
* change build-only to build-rules on substrate jobs [chaos:basic]
* test and change when:on_success to when:always [chaos:basic]
* resolve conflicts and test [chaos:basic]
Co-authored-by: Max Inden <mail@max-inden.de >
Co-authored-by: Denis Pisarev <denis.pisarev@parity.io >
2020-07-23 12:53:55 +02:00
7e72a658c7
fix check polkadot companion status check ( #6688 )
2020-07-20 11:05:27 +02:00
fe9c01fc68
.maintain/monitoring/alerting-rules: Remove HighCPUUsage alert ( #6648 )
...
The `HighCPUUsage` alert is based on the `cpu_usage_percentage` metric.
Instead of exposing the overall CPU usage in percent, the metric exposes
the per core usage summed over all cores.
This commit removes the alert for two reasons:
1. Substrate itself does not expose the core count and thus one can not
alert based on the `cpu_usage_percentage` metric.
2. Alerting based on CPU usage is generic and not specific to Substrate
or Blockchains. Thus any CPU usage alert suffice.
2020-07-17 07:43:57 +00:00
84d607b5ff
Update substrate-networking Grafana dashboard ( #6649 )
2020-07-16 16:45:12 +00:00
2827637103
Remove polkadot companion detection from url anywhere ( #6570 )
2020-07-16 11:01:18 +02:00
f957281008
[CI] Fix check_polkadot_companion_status.sh ( #6631 )
...
* check changes_requested and approved separately
* handle checking more than 1 CHANGES_REQUESTED review
2020-07-15 13:30:18 +02:00
e3ba163714
ci: fix merge on polkadot companion job ( #6574 )
2020-07-03 21:07:11 +02:00
2ddbbd7c08
Remove polkadot companion detection from branch name ( #6565 )
...
* Initial commit
Forked at: f54614e256
2020-07-03 17:29:08 +02:00
540ae1c161
Update SubstrateCli to return String ( #6550 )
...
* Update SubstrateCli to return String
* Add default implementation for executable_name()
* Use display instead of PathBuf
* Get file_name in default impl of executable_name
* Remove String::from and use .into()
* Use default impl for executable_name()
* Use .as_str() and remove useless .to_string()
* Update only sp-io when running companion build
* Remove unneeded update of sp-io in CI
Co-authored-by: Cecile Tonglet <cecile@parity.io >
2020-07-02 13:34:56 +02:00
585ea531a3
.maintain/monitoring/alerting-rules: Adjust transaction queue size alert ( #6426 )
...
The transaction queue size alert has been firing with a constant 10
transactions in the queue. While maybe problematic those 10 transactions
don't need to be the same across scrape intervals.
Instead of alerting with a size above 10, alert based on two things:
1. Monotonically increasing queue size
2. Upper limit queue size reached
2020-07-01 10:31:56 +02:00
f6ebd5f87d
Releasing rc4 – Rhinoceros ( #6515 )
...
Co-authored-by: Martin Pugh <pugh@s3kr.it >
2020-06-25 23:18:43 +02:00
2cbefce35b
.maintain/sentry-node: Remove UI and update Prometheus target ( #6473 )
...
Remove burden on user to build polkadot-js apps Docker image locally in
order to get started.
Update Prometheus config fixing target name.
2020-06-25 11:25:28 +02:00
fe76ebd548
.maintain/monitoring: Add alerting rule tests ( #6343 )
...
* .maintain/monitoring: Add alerting rule tests
* .maintain/monitoring/alerting-rules/alerting-rules.yaml: Break lines
* .gitlab-ci.yml: Add promtool rule testing step
2020-06-19 08:31:42 +02:00
1d364404e7
Update s3 artifact url ( #6399 )
2020-06-18 10:48:34 +01:00
5f991ae9b8
Allow Sudo to do anything ( #6375 )
...
* All Sudo to do anything.
* Rename old labels.
2020-06-17 12:22:57 +02:00
0787b189fa
Use /dns/ instead of /dns4/ ( #6369 )
2020-06-16 22:49:44 +02:00
14ee618df0
[CI] Add label enforcement ( #6365 )
...
* Add label enforcement
* fix .gitlab-ci.yml
* update check_labels.sh
2020-06-16 15:50:50 +02:00
50604fb445
Fix check-line-width CI script ( #6326 )
...
* Compare lines to the hash that the PR branched off from
* Use git merge-base to determine common ancestor
* Fixup
2020-06-12 13:47:14 +02:00
8a8b4f99c3
Rename all the election operations ( #6245 )
...
* Rename and move sp-phragmen
* More renames for equalise
* Update main module doc
* Fix line width
* Line width
2020-06-05 17:33:13 +02:00
9cac359f44
Add a Substrate networking Grafana dashboard template ( #6171 )
...
* Add a substrate-networking grafana dashboard
* Capitalize data source
* Do changes
2020-06-01 10:46:34 +02:00
aa95c596e6
.maintain/monitoring: Add an initial set of Prometheus alerting rules ( #6095 )
...
Create a place to collaborate on Prometheus alerting rules for
Substrate starting with a basic set of rules covering:
- Resource usage
- Block production
- Block finalization
- Transaction queue
- Networking
- ... Others
2020-05-21 16:26:29 +02:00
Pierre Krieger