49f7e5cce4
Finish migration to v2 primitives ( #5037 )
...
* remove v0 primitives from polkadot-primitives
* first pass: remove v0
* fix fallout in erasure-coding
* remove v1 primitives, consolidate to v2
* the great import update
* update runtime_api_impl_v1 to v2 as well
* guide: add `Version` request for runtime API
* add version query to runtime API
* reintroduce OldV1SessionInfo in a limited way
2022-03-09 14:01:13 -06:00
e8cb6cdaac
Companion to "Updating scale to v3" ( #4958 )
...
* Updating dependencies
* Adapting code to scale v3
* Upgrade bitvec to 1.0.0
* Fix bitvec arithmetics
* Update Cargo.lock
* Update sp-io
* Fixing the build
* Yanked scale-info 2.0.0
Co-authored-by: Bastian Köcher <info@kchr.de >
2022-02-25 13:07:06 +01:00
5b06cc23d6
[chore] runtime split tests ( #4834 )
2022-02-03 09:12:41 +01:00
f7564591e7
Add tests to ensure session is set correctly in OnChainScrapingVotes ( #4821 )
...
Co-authored-by: Bernhard Schuster <bernhard@ahoi.io >
2022-02-02 18:40:21 +01:00
0302271053
Fix incomplete sorting. ( #4795 )
...
* Fix incomplete sorting.
* fmt.
* Better test.
* Update runtime/parachains/src/disputes.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* chore fmt
* simplify the sorting for two items
* add test for assure duplicates are detected
* fixup tests
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
Co-authored-by: Bernhard Schuster <bernhard@ahoi.io >
2022-01-27 18:16:31 +00:00
3d61cc01db
co #10662 : Require MaxEncodedLen per default ( #4746 )
...
* Add `without_storage_info`
The MaxEncodedLen trait is now enforced by default in Substrate.
All pallets missing an implementation need to be marked with
`without_storage_info` now.
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Remove `generate_storage_info`
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add more `without_storage_info`
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* update lockfile for {"substrate"}
Co-authored-by: parity-processbot <>
2022-01-20 12:36:22 +00:00
b7a05fd40b
[runtime] follow up relay chain cleanups ( #4657 )
...
* fix miscalculation of remaining weight
* rename a var
* move out enforcing filtering by dropping inherents
* prepare for dispute statement validity check being split off
* refactor
* refactor, only check disputes we actually want to include
* more refactor and documentation
* refactor and minimize inherent checks
* chore: warnings
* fix a few tests
* fix dedup regression
* fix
* more asserts in tests
* remove some asserts
* chore: fmt
* skip signatures checks, some more
* undo unwatend changes
* Update runtime/parachains/src/paras_inherent/mod.rs
Co-authored-by: sandreim <54316454+sandreim@users.noreply.github.com >
* cleanups, checking CheckedDisputeStatments makes no sense
* integrity, if called create_inherent_inner, it shall do the checks, and not rely on enter_inner
* review comments
* use from impl rather than into
* remove outdated comment
* adjust tests accordingly
* assure no weight is lost
* address review comments
* remove unused import
* split error into two and document
* use assurance, O(n)
* Revert "adjust tests accordingly"
This reverts commit 3cc9a3c449f82db38cea22c48f4a21876603374b.
* fix comment
* fix sorting
* comment
Co-authored-by: sandreim <54316454+sandreim@users.noreply.github.com >
2022-01-20 11:00:29 +00:00
5a4d0ebcba
Companion for substrate#10620 ( #4696 )
...
* fix tests
* update lockfile for substrate
Co-authored-by: parity-processbot <>
2022-01-12 10:34:50 +00:00
78b3dc214a
chore: fix copy&paste and tidy comments ( #4646 )
...
As was brought up in [here][og], we have some copy&paste comments. I
fixed them and also took liberty of fixing some other places.
Specifically, those that say "module" instead of contemporary "pallet".
[og]:
https://github.com/paritytech/polkadot/pull/4603#discussion_r776971291
2022-01-01 18:13:17 +01:00
4adb8466a3
dev-comment spelling mistakes ( #4434 )
2021-12-06 15:20:29 +01:00
e16f71b7b6
companion for pallet order fix. ( #4181 )
...
* companion
* remove no-op duplicated function
* fmt
* add comment on constraint
* Run cargo update
* fix integration test
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com >
2021-12-01 03:00:20 +00:00
49d78d99f7
rococo-runtime: Switch to latest construct_runtime! syntax ( #4389 )
...
* rococo-runtime: Switch to latest `construct_runtime!` syntax
Besides that it fixes pallet macro errors in other crates that popped up
because of this switch.
* FMT
2021-11-29 21:36:19 +01:00
1aa6a4aba4
move paras inherent filtering to runtime ( #4028 )
...
* move things around, add filter methods
* validator keys, modify availability bitfields according to disputes
* simplify, keep the filter -> sanitize generic for both usecases
* minor
* assure tests still work, reduce changeset
* integration
* start entropy passing
* fixins
* compile, 1 failing test
* filter with coverage
* fixins
* Update runtime/parachains/src/paras_inherent.rs
Co-authored-by: Robert Habermeier <rphmeier@gmail.com >
* slip of the pen
* improve test cases
* misc
* fix
* fixins
* test avoid extra into() calls in assert_noop!
* chores
* ff
* test fixup superfluous into call
* chore: pfmt
* improve apply_block_weight_limit to try to maximize the number of sufficiently backed
blocks and add extra bitfields in a round-robin fashion
* new code treats the lack of backed candidates as ok
* Use vrf based entropy
* fixup vrf random
* add warn
* slip of the pen
* fixup
* assure ordering
* rethink apply_weights
* mock
* use a closure as predicate check
* extract and use DisputedBitfield
* chore: simplify
* remove stray dbg
* chore: fmt
* address feedback
* fix test, halfway there
* stage1
* dbg stuff
* make group selection align
* fix session index
* fix wrongly returned candidates
* cleanup
* chore fmt
* fix ensure check
* make good case test work
* more tests for bitfields
* create sanitize_backed_candidates
* fixup tests
* update guide
* add check referenced in the guide
* improve weights code
* fmt
* fixins
* Update roadmap/implementers-guide/src/runtime/inclusion.md
Co-authored-by: Zeke Mostov <32168567+emostov@users.noreply.github.com >
* compiling + address review
* add comments
* fix weight calc
* address review comments and test failure
* fix
* fix: condition
* Fix random_sel function
* Fix overlength block check
* Zeke + Ladi commit for disputes filtering + integration test builder + runtime benchmarks + integration tests
* Add benchmarks for code upgrades
* Code upgrade bench; Feature gate TestWeightInfo
* Try and make CI happier
* Feature gate enter test to not(benchmarks)
* Make sure no unused imports/fn
* refactor, re-use, the beginning
* Fix issue with frame benchmarking dep compilation
* More precise feature gating for some derives
* integrate piece-wise
* foo
* fixins
* chore fmt
* fixins
* rename const generic
* Update runtime/parachains/src/paras_inherent.rs
Co-authored-by: Zeke Mostov <z.mostov@gmail.com >
* Fix compilation
* limit to test
* remove unused spam slots
* spellcheck
* remove a tick, fix a typo
* Add Code upgrade weights
* comment improvements + >=
Co-authored-by: Zeke Mostov <z.mostov@gmail.com >
* remove another tick
* Update runtime/parachains/src/paras_inherent/benchmarking.rs
Co-authored-by: Zeke Mostov <z.mostov@gmail.com >
* saturating fixins + some spaces
* fix
* benchmarking - preliminary results
* Add training wheels
* Refactor some early exit logic for enter
* Gracefully handle filtering bitfields & candidates (#4280 )
This updates the logic for sanitize_bitfields and sanitize_backed_candidates to never error when there is an issue, but instead to simply skip the problematic items.
* Refactor inherent data weight limiting logic (#4287 )
* Apply suggestions from code review
* Update runtime/parachains/src/builder.rs
Co-authored-by: Zeke Mostov <z.mostov@gmail.com >
* Update runtime/parachains/src/builder.rs
* Update runtime/parachains/src/paras_inherent.rs
* final pass
* Run cargo +nightly-2021-10-29 fmt
* Update implementors guide with `sanitize_*` & `enter` (#4294 )
* Make spell check happier
* Make wasm runtimes compile with benchmarks enabled (#4303 )
* comment stuff out, use old toml
* Seems to be working?
* Remove feature gating from builder
* Remove commented out stuff
* Remove generic from digest
* Update weight files for runtime
Co-authored-by: Robert Habermeier <rphmeier@gmail.com >
Co-authored-by: Zeke Mostov <32168567+emostov@users.noreply.github.com >
Co-authored-by: Lldenaurois <Ljdenaurois@gmail.com >
Co-authored-by: Zeke Mostov <z.mostov@gmail.com >
Co-authored-by: Bastian Köcher <info@kchr.de >
2021-11-16 18:39:39 +00:00
8aba3ea8ca
some spelling fixes ( #4088 )
...
* quotes around Job::ToJob
* add new words to dictionary
2021-10-18 11:59:46 +02:00
d59ef49195
Move runtime to with_transaction in order to Rollback state changes ( #4067 )
...
* Move runtime to with_transaction in order to Rollback state changes
* add assert_storage_noop to tests
2021-10-12 20:09:48 +00:00
547d166f20
Fix an off-by-one: revert rather than revert-to ( #3991 )
...
* fix off-by-one in disputes reversion code
* bump Rococo spec version
2021-10-01 20:24:35 +00:00
019d4e3b99
paras_inherent: reject only candidates with concluded disputes ( #3969 )
...
* paras_inherent: reject only candidates with concluded disputes
* remove unused Error variant
2021-09-29 13:58:04 -05:00
94986bec7e
disputes: reject single-sided disputes ( #3903 )
...
* disputes: reject single-sided disputes
* fmt
2021-09-27 12:16:34 -05:00
03934d2af1
Add a force_unfreeze extrinsic to the disputes module ( #3906 )
...
* add a 'force_unfreeze' to the Disputes module
* fmt
* Benchmark Disputes `force_unfreeze` extrinsic (#3908 )
* Companion for Generate storage info for pallet babe #9760 (#3831 )
* Adding MaxSegmentLength and MaxAuthorities
to pallet babe
* Missed a few to_vec
* Removing `MaxSegmentLength` as not needed anymore
* Adding `MaxAuthorities` to couple of missing place
* Adding missing definition of `MaxAuthorities`
* Adding a missing to_vec
* update Substrate
Co-authored-by: thiolliere <gui.thiolliere@gmail.com >
Co-authored-by: parity-processbot <>
* Benchmark Disputes `force_unfreeze` extrinsic
target pr: #3906
target branch: rh-unfreeze
* Add benchmark to rococo runtime; run benchmark locally
* Revert unintentionally added diff
* Some spacing and comments
* Bump proc-macro-crate from 1.0.0 to 1.1.0 (#3863 )
Bumps [proc-macro-crate](https://github.com/bkchr/proc-macro-crate ) from 1.0.0 to 1.1.0.
- [Release notes](https://github.com/bkchr/proc-macro-crate/releases )
- [Commits](https://github.com/bkchr/proc-macro-crate/commits )
---
updated-dependencies:
- dependency-name: proc-macro-crate
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump parity-scale-codec from 2.2.0 to 2.3.0 (#3833 )
Bumps [parity-scale-codec](https://github.com/paritytech/parity-scale-codec ) from 2.2.0 to 2.3.0.
- [Release notes](https://github.com/paritytech/parity-scale-codec/releases )
- [Changelog](https://github.com/paritytech/parity-scale-codec/blob/master/CHANGELOG.md )
- [Commits](https://github.com/paritytech/parity-scale-codec/compare/v2.2...parity-scale-codec-v2.3.0 )
---
updated-dependencies:
- dependency-name: parity-scale-codec
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Use super::WeightInfo to try and get CI to compile
* cargo run --quiet --release --features runtime-benchmarks -- benchmark --chain=rococo-dev --steps=50 --repeat=20 --pallet=runtime_parachains::disputes --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtime/parachains/src/disputes/weights.rs --header=./file_header.txt
* impl TestWeightInfo; remove weights from runtime_parachains dir
* fmt
* Update test-runtime
Co-authored-by: Georges <georges.dib@gmail.com >
Co-authored-by: thiolliere <gui.thiolliere@gmail.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Parity Bot <admin@parity.io >
Co-authored-by: Zeke Mostov <32168567+emostov@users.noreply.github.com >
Co-authored-by: Georges <georges.dib@gmail.com >
Co-authored-by: thiolliere <gui.thiolliere@gmail.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Parity Bot <admin@parity.io >
2021-09-23 19:29:26 +00:00
4c7539cab5
Companion for #8615 : enrich metadata with type information ( #3336 )
...
* Use beefy branch with scale-info
* Add patches
* Sprinkle some TypeInfo derives
* Add some TypeInfo deriv
* Cargo.lock
* Derive TypeInfo and skip type params for Xcm types
* Cargo.lock
* Fix up scale_info bounds attributes
* Fix up dependencies
* Use my own beefy-primitives branch
* Bump BEEFY
* Update patches
* Add some scale-info dependencies and TypeInfo derives
* More TypeInfo decoration
* Update scale-info
* Some TypeInfos and remove more Event pallet::metadata
* Moar TypeInfos
* TypeInfos galore, fix up metadata runtime API
* TypeInfo
* TypeInfos, update other runtime metadata APIs
* Fix up Kusama, comment out some `usize` QueueSize parameter types
* Remove local diener patches
* Cargo.lock
* Cargo.lock
* Update to scale-info crates.io release
* Update primitive-types branch
* Update pallet-beefy to use custom branch
* Update other parity-common deps
* Update parity-common patches
* bump a bunch of deps in parity-common
* Remove parity-common patches
* Bump finality-grandpa version
* Cargo.lock
* Update scale-info to 0.9.1
* Add recursion_limit for runtime-parachains
* Add some scale_info attributes
* Cargo.lock
* Revert finality-grandpa bump
* Cargo.lock, scale-info update
* cargo update
* Make sure using patched version of finality-grandpa
* Use patched scale-info
* Update to scale-info 0.10.0
* Update finality-grandpa
* Cargo.lock
* Update beefy deps
* Update beefy deps again
* Add scale-info dependency
* Remove deprecated pallet::metadata attributes.
* Add some missing scale-info deps and derives
* Use some variant struct call syntax
* Add missing TypeInfo impl
* Add some more TypeInfo impls
* Convert some call enum struct variant constructors
* More scale-info deps and derives
* Call enum struct variants
* TypeInfo derives
* Call enum variant structs
* scale-info deps and derives
* Call enum variant struct constructors
* Use beefy-primitives scale-info feature
* Use grandpa-bridge-gadget master branch
* Remove finality-grandpa patch
* Add missing scale_info dependency and derive
* Fix up some call variant constructors
* Add missing scale_info dependency
* Fix some test errors
* More TypeInfo derives
* More call variant structs
* Call variant structs in tests
* Cargo.lock
* Fmt
* Fix more call struct variants
* Another call struct variant
* add scale-info/std features explicitly
* More call struct variants
* Add missing scale-info dependency
* Fmt
* review: activate scale-info/std where missing
* Remove some duplicate std feature activation
* review: add scale_info bounds() attr
* More call variant structs
* Remove recursion limit
* Update beefy-primitives
* Update beefy-primitives
* Fix simnet call variant struct errors
* Fmt
* cargo update -p beefy-primitives
* Add some missing TypeInfo derives
* Fix some call variants
* Fix some call variant underscores
* Cargo.lock
* Cargo.lock
* Add missing TypeInfo derive
* Add some more missing TypeInfo derives
* Even more missing TypeInfo derives
* Add TypeInfo derives to new xcm types
* Fmt
* Cargo.lock
* Add missing TypeInfo impls
* Cargo.lock
* More missing TypeInfos
* Fixes
* Cargo.lock
* Cargo.lock
* Add TypeInfo impls to xcm v2
* Update to scale-info 1.0
* Update finality-grandpa 0.14.4, patch for now
* Update beefy
* Remove patched finality-grandpa
* Add TypeInfo impl to Outcome
* Fixes
* Call variant struct
* Call variant struct
* Fix test
* Add TypeInfo impl
* Cargo.lock
* Cargo.lock
* Cargo.lock
* git checkout master Cargo.lock
* update Substrate
* Add missing scale-info features for beefy-primitives
* Fmt
* Remove check for now
* Update beefy-primitives, removes scale-info feature
* Update beefy-primitives again
Co-authored-by: adoerr <0xad@gmx.net >
Co-authored-by: Andronik Ordian <write@reusable.software >
Co-authored-by: thiolliere <gui.thiolliere@gmail.com >
Co-authored-by: parity-processbot <>
Co-authored-by: Bastian Köcher <info@kchr.de >
2021-09-15 15:38:45 -05:00
68c03f66f3
Mass replace ,); pattern ( #3580 )
...
This is an artifact left by rustfmt which is not dare to remove the
comma being conservative.
2021-08-05 19:53:17 +02:00
24c0d5a51e
Parachains para_inherent.rs to FrameV2 ( #3531 )
...
* last parachains migration!
* migrate runtimes
* disable frame supertrait
* add pallet::inherent
* mock
* cargo +nightly fmt
2021-08-03 11:02:34 +00:00
ff5d56fb76
cargo +nightly fmt ( #3540 )
...
* cargo +nightly fmt
* add cargo-fmt check to ci
* update ci
* fmt
* fmt
* skip macro
* ignore bridges
2021-08-02 10:47:33 +00:00
84ca3b2b3b
Parachains configuration.rs FrameV2 ( #3516 )
...
* migration
* genesis build correctly
* migrate runtimes
* add genesis builds
* expose GenesisBuild
* chainspec migration
* fmt
* check before insert
* Reduce visibility of storage items to crate
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
2021-07-28 04:56:35 +00:00
675f71a882
Dispute vote filtering for block authors ( #3498 )
...
* guide: filter_multi_dispute_data
* guide: elaborate
* Implementation of dispute data filtering
* tests for filtering
* don't use std, you fool!
* use swap_remove
* Update runtime/parachains/src/disputes.rs
Co-authored-by: Andronik Ordian <write@reusable.software >
* use btreeste
* address API nit
Co-authored-by: Andronik Ordian <write@reusable.software >
2021-07-21 21:48:07 +02:00
ec98120f0e
Disputes runtime ( #2947 )
...
* disputes module skeleton and storage
* implement dispute module initialization logic
* implement disputes session change logic
* provide dispute skeletons
* deduplication & ancient check
* fix a couple of warnings
* begin provide_dispute_data impl
* flesh out statement set import somewhat
* move ApprovalVote to shared primitives
* add a signing-payload API to explicit dispute statements
* implement statement signature checking
* some bitflags glue for observing changes in disputes
* implement dispute vote import logic
* flesh out everything except slashing
* guide: tweaks
* declare and use punishment trait
* punish validators for inconclusive disputes
* guide: tiny fix
* guide: update docs
* add disputes getter fn
* guide: small change to spam slots handling
* improve spam slots handling and fix some bugs
* finish API of disputes runtime
* define and deposit `RevertTo` log
* begin integrating disputes into para_inherent
* use precomputed slash_for/against
* return candidate hash from process_bitfields
* implement inclusion::collect_disputed
* finish integration into rest of runtime
* add Disputes to initializer
* address suggestions
* use pallet macro
* fix typo
* Update runtime/parachains/src/disputes.rs
* add test: fix pruning
* document specific behavior
* deposit events on dispute changes
* add an allow(unused) on fn disputes
* add a dummy PunishValidators implementation
* add disputes module to Rococo
* add disputes module to westend runtime
* add disputes module to test runtime
* add disputes module to kusama runtime
* guide: prepare for runtime API for checking frozenness
* remove revert digests in favor of state variable
* merge reversions
* Update runtime/parachains/src/disputes.rs
Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com >
* Update runtime/parachains/src/disputes.rs
Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com >
* Update runtime/parachains/src/disputes.rs
Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com >
* add byzantine_threshold and supermajority_threshold utilities to primitives
* use primitive helpers
* deposit revert event when freezing chain
* deposit revert log when freezing chain
* test revert event and log are generated when freezing
* add trait to decouple disputes handling from paras inherent handling
* runtime: fix compilation and setup dispute handler
* disputes: add hook for filtering out dispute statements
* disputes: add initializer hooks to DisputesHandler
* runtime: remove disputes pallet from all runtimes
* tag TODOs
* don't import any dispute statements just yet...
* address grumbles
* fix spellcheck, hopefully
* maybe now?
* last spellcheck round
* fix runtime tests
* fix test-runtime
Co-authored-by: thiolliere <gui.thiolliere@gmail.com >
Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com >
Co-authored-by: André Silva <andrerfosilva@gmail.com >
2021-07-19 16:49:19 +00:00
Robert Habermeier