Commit Graph

15873 Commits

Author SHA1 Message Date
Andronik Ordian e7a420be0f Scheduler: handle timeouts for no group rotation (#1439)
* runtime: rename parachain_rotation_frequency to group_rotation_frequency

* scheduler: handle timeouts for no group rotation

* scheduler: apply fixes from code review

* scheduler: remove my comments
2020-07-21 20:08:01 -04:00
Dan Forbes 686ee971d9 Removing staging resources from node template README (#6701) 2020-07-21 21:45:07 +00:00
Xiliang Chen 143f5600f4 update impl_outer_origin (#1444) 2020-07-21 20:02:41 +02:00
Xiliang Chen 168e9df7e2 make impl_outer_origin default to use frame_system (#6695) 2020-07-21 15:47:08 +00:00
Bastian Köcher f1523c75f6 pallet-swap-action: Change BalanceSwapAction signature (#6580)
Instead of requiring `T: Trait` in `BalanceSwapAction`, we directly
depend on `AccountId`. This fixes a compilation error on wasm, where
`Runtime` does not implement `Debug`, but `BalanceSwapAction` required it.
2020-07-21 17:39:56 +02:00
Kian Paimani c9fd0c964a Properly filter out duplicate voters in elections. (#6693)
* Prevent duplicate voter

* Update primitives/npos-elections/src/lib.rs

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
2020-07-21 17:33:33 +02:00
Denis Pisarev 3b6597e0ed "cargo test" jobs optimization (#6606)
* change (ci): 3 jobs in 1 decreases concurrency and is more effectiv; w/o release it's ~20% faster, but needs testing on prod; wasmtest tests are already running within cargo test --workspace

* fix (test): these ones were failing on nightly

* save: cargo profiles [skip ci]

* change (ci): one test to run them all

* change (ci): rebase

* Revert "change (ci): rebase"

This reverts commit 8a6b7ea043a460bf71526ccaa4c7a68899a3b2bc.

* fix (config): fix manifest

* change (ci): bench release
2020-07-21 16:55:54 +02:00
Nikolay Volf 90413260f0 readme: --force no longer required (#1447) 2020-07-21 15:50:58 +02:00
Dan Forbes b93713d49f Remove dead link to out-of-date style guide (#6682)
* Remove dead link to out-of-date style guide

* Replace dead link with self-hosted doc

* Use relative link to style guide

Co-authored-by: Benjamin Kampmann <ben@gnunicorn.org>

* Format style guide

Co-authored-by: Benjamin Kampmann <ben@gnunicorn.org>

* Formatting

Co-authored-by: Benjamin Kampmann <ben@gnunicorn.org>
2020-07-21 13:14:25 +00:00
pscott 046fda914a Improve overall performance (#6699)
* Improve overall performance

* Clean up code

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

* Remove needless ::

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

* Remove needless ::

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
2020-07-21 14:46:49 +02:00
Pierre Krieger ab82eb1c98 Add sync_legacy_requests_received metric (#6698) 2020-07-21 11:59:49 +00:00
Benjamin Kampmann 629a801b6a Fixup cargo unleash (#6689)
* Bumping to rc5

* Revert "Bumping to rc5"

This reverts commit 5a63a8230e5a12db1b4ce4ac62e4967c52291da7.

* Bumping for rc5, correctly this time
2020-07-21 10:26:47 +00:00
Gavin Wood 3f57b1c6e8 Enable transfers (#1443)
* Enable transfers

Also quash any conviction from Referendum Zero; Sudo was always
going to have been removed so lock-voting doesn't make sense in
this case.

* Add test for migration; remove superfluous comment.

* Fixes

* Bump

* Weekly elections
2020-07-21 12:19:23 +02:00
Nikolay Volf dcaaf713e8 add ecdsa benches (#6697) 2020-07-21 09:50:31 +00:00
Shaopeng Wang c0179cb6e7 Add try_mutate_exists to StorageDoubleMap. (#6694) 2020-07-21 10:50:37 +02:00
Roman Borschel 025c501766 Update libp2p to 0.22. (#6690)
* Update libp2p to 0.22.

Primarily to begin the libp2p-noise upgrade process.

See https://github.com/libp2p/rust-libp2p/issues/1631.

* CI
2020-07-21 07:44:41 +00:00
Pierre Krieger 69da327677 Companion PR for substrate#6676 (#1427)
* Companion PR for substrate#6676

* Update Substrate
2020-07-21 07:27:16 +00:00
Peter Goodspeed-Niklaus 5cfcc8446c Add test suite and minor refinements to the utility subsystem (#1403)
* get conclude signal working properly; don't allocate a vector

* wip: add test suite / example / explanation for using utility subsystem

Unfortunately, the test fails right now for reasons which seem
very odd. Just have to keep poking at it.

* explicitly import everything

* fix subsystem-util test

The root problem here was two-fold:

- there was a circular dependency from subsystem -> test-helpers/subsystem ->
  subsystem
- cfg(test) doesn't propagate between crates

The solution: move the subsystem test helpers into a sub-module
within subsystem. Publicly export them from the previous location
so no other code breaks.

Doing this has an additional benefit: it ensures that no production
code can ever accidentally use the subsystem helpers, as they are compile-
gated on cfg(test).

* fully commit to moving test helpers into a subsystem module

* add some more tests

* get rid of log tests in favor of real error forwarding

It's not obvious whether we'll ever really want to chase down
these errors outside a testing context, but having the capability
won't hurt.

* fix issue which caused test to hang on osx

* only require that job errors are PartialEq when testing

also fix polkadot-node-core-backing tests

* get rid of any notion of partialeq

* rethink testing

Combine tests of starting and stopping job: leaving a test executor
with a job running was pretty clearly the cause of the sometimes-hang.

Also, add a timeout so tests _can't_ hang anymore; they just fail
after a while.

* rename fwd_errors -> forward_errors

* warn on error propagation failure

* fix unused import leftover from merge

* derive eq for subsystemerror
2020-07-20 20:35:14 -04:00
Gav Wood 9aadb5d499 Bump Polkadot runtime version 2020-07-20 19:13:09 +02:00
Gav Wood d14170c8e0 Fix typo in governance params 2020-07-20 19:11:26 +02:00
Gavin Wood 760d49c551 Remove Sudo (#1437)
* Remove Sudo

NOTE: To ensure minimal index changes to pre-existing pallet deployments,
this is done with a "swap_remove" style; the previous last pallet
(Purchase), which is hitherto unused, has been shifted into the old index
of Sudo.

* Remove CC1 designation.

* Fixes

* Bump

* Fixes

* Fixes

* Fixes

* Fixes

* Fixes

* Fixes

* Fixes

* Fixes

* Fixes

* Fixes
2020-07-20 17:47:09 +02:00
warfollowsme | ryabina.io bbabb17426 More app-friendly event description (#6684)
* More app-friendly event description

* change origin -> owner

* checked all decl_event! and changed decriptions.

* annotated parameter names for remaining events
2020-07-20 13:13:20 +02:00
Gavin Wood c5bf161738 Bump version, enable full governance (#1433) 2020-07-20 12:18:27 +02:00
Pierre Krieger 8ae4faba51 Fix compilation problems due to ed25519-dalek 1.0.0-pre.4 (#6676)
* Fix compilation problems due to ed25519-dalek 1.0.0-pre.4

* Update libp2p-core

* Revert rand downgrade
2020-07-20 09:53:39 +00:00
gabriel klawitter 7e72a658c7 fix check polkadot companion status check (#6688) 2020-07-20 11:05:27 +02:00
Benjamin Kampmann 1b8211dd4f CI Regression Test for determinism of our wasm runtimes (#1372)
* deterministic build check runtime

* fix yaml

* Apply suggestions from code review

Co-authored-by: s3krit <pugh@s3kr.it>

* Update cargo.lock

Co-authored-by: s3krit <pugh@s3kr.it>
2020-07-20 10:56:28 +02:00
Kian Paimani 42eb3f0695 Fix tx-payment integrity-test (#6633)
* Fix tx-payment integrity-test

* Better error message.

* Apply suggestions from code review

Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>

* Fix line width

* Apply suggestions from code review

Co-authored-by: Alexander Popiak <alexander.popiak@parity.io>

* Fix grumble

Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
Co-authored-by: Alexander Popiak <alexander.popiak@parity.io>
2020-07-20 09:57:51 +02:00
Amar Singh 0d2a794d48 done (#6673) 2020-07-19 16:12:04 +02:00
Robert Habermeier dddde219a2 Implement Runtime APIs (#1411)
* create a README on Runtime APIs

* add ParaId type

* write up runtime APIs

* more preamble

* rename

* rejig runtime APIs

* add occupied_since to `BlockNumber`

* skeleton crate for runtime API subsystem

* improve group_for_core

* improve docs on availability cores runtime API

* guide: freed -> free

* add primitives for runtime APIs

* create a v1 ParachainHost API trait

* guide: make validation code return `Option`al.

* skeleton runtime API helpers

* make parachain-host runtime-generic

* skeleton for most runtime API implementation functions

* guide: add runtime API helper methods

* implement new helpers of the inclusion module

* guide: remove retries check, as it is unneeded

* implement helpers for scheduler module for Runtime APIs

* clean up `validator_groups` implementation

* implement next_rotation_at and last_rotation_at

* guide: more helpers on GroupRotationInfo

* almost finish implementing runtime APIs

* add explicit block parameter to runtime API fns

* guide: generalize number parameter

* guide: add group_responsible to occupied-core

* update primitives due to guide changes

* finishing touches on runtime API implementation; squash warnings

* break out runtime API impl to separate file

* add tests for next_up logic

* test group rotation info

* point to filed TODO

* remove unused TODO [now]

* indentation

* guide: para -> para_id

* rename para field to para_id for core meta

* remove reference to outdated AvailabilityCores type

* add an event in `inclusion` for candidates being included or timing out

* guide: candidate events

* guide: adjust language

* Candidate events type from guide and adjust inclusion event

* implement `candidate_events` runtime API

* fix runtime test compilation

* max -> min

* fix typos

* guide: add `RuntimeAPIRequest::CandidateEvents`
2020-07-18 16:01:51 -04:00
Cecile Tonglet c891b2c219 Change unknown-commit to unknown to make parsing easier (#6675) 2020-07-17 20:30:09 +02:00
Fedor Sakharov 5624bd8bf4 Use SpawnNamed instead of Spawn in Overseer (#1430)
* Use SpawnNamed instead of Spawn in Overseer

* reexport SpawnNamed and fix doc tests

* Fix deps
2020-07-17 20:04:02 +03:00
Nikolay Volf cb4c6abca7 Transaction pool integrated benchmarks (#6579)
* txpool benchmarks

* updated api

* Update bin/node/bench/src/txpool.rs

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
2020-07-17 17:09:18 +03:00
Shawn Tabrizi 04f9c6ece8 Add purchase module to westend (#1429) 2020-07-17 15:18:02 +02:00
Shawn Tabrizi 3fa224bfa4 Pallet for Purchase (#1369)
* initial mock

* remove statement

* Merge branch 'master' into shawntabrizi-crowdsale

* only work for dead accounts

* Revert "Merge branch 'master' into shawntabrizi-crowdsale"

This reverts commit 5d26bc22f30fdbc58854dc64398bddc1f19c4d24.

* update storage name

* Re-mock

* Update comment

* payouts

* test signature verification

* Update wording

* fix tests

* support both free and locked balance

* Single statement set in configuration trait

* Configurable purchase limit, initiated status

* Account creation tests

* make note about `max_amount` check

* Update validity status tests

* update balance tests

* payment test

* finish tests

* enable in runtime

* Test and verify ed25519

* make purchase pallet more configurable on the fly

* Remove runtime check on purchase amount.

* clean up trait

* add basic weights

* add extra super saftey check for vesting

* Add vat tracking

* remove unused const

* Update to W3F Origins

* remove stale comment

* Support existing accounts w/o existing vesting schedule

* Update runtime/common/src/purchase.rs

Co-authored-by: Gavin Wood <gavin@parity.io>

* Add support for partially unlocked portion of purchased DOTs

* add trait import

* Expose constants from pallet

* Fixes

* Fixes

* Update runtime/polkadot/src/lib.rs

Co-authored-by: Gavin Wood <gavin@parity.io>
2020-07-17 14:23:56 +02:00
André Silva 0a049e81de runtime: update grandpa equivocation reporting api (#1407)
* runtime: update grandpa equivocation reporting api

* Bump

Co-authored-by: Gav Wood <gavin@parity.io>
2020-07-17 13:01:02 +02:00
Gavin Wood 63a655afb0 Define BurnDestination, Kusama Treasury burns to Society (#6671) (#1421)
* Define BurnDestination, Kusama Treasury burns to Society.

* Fixes

* Remove the council elections enabling.

* Bump

* whitespace
2020-07-17 12:36:36 +02:00
André Silva ae38a806ed grandpa: report equivocations with unsigned extrinsics (#6656)
* grandpa: use unsigned extrinsics for equivocation reporting

* grandpa: allow signed reports as well

* grandpa: change runtime api for submitting unsigned extrinsics

* grandpa: fix tests

* grandpa: add test for unsigned validation

* grandpa: add benchmark for equivocation proof checking

* offences: fix grandpa benchmark

* grandpa: add proper weight for equivocation reporting extrinsic

* grandpa: fix weight unit
2020-07-17 12:32:20 +02:00
Wei Tang 8ae1aa4c28 Switch to bounded mpsc for txpool import notification stream (#6640)
* Switch to bounded mpsc for txpool import notification stream

* Update client/transaction-pool/graph/src/validated_pool.rs

Co-authored-by: Nikolay Volf <nikvolf@gmail.com>

Co-authored-by: Nikolay Volf <nikvolf@gmail.com>
2020-07-17 12:31:47 +02:00
Gavin Wood 85e1f9aa8d Treasury burning can be directed (#6671)
* Treasury burning can be directed

Also, Society is a imbalance handler

* Build

* Introduce from_permill in perthings.

* Rename to from_perthousand to avoid confusion with Permill

* Fixes
2020-07-17 12:04:42 +02:00
Gavin Wood cad18b0fae identity: Don't let subs be re-registered (#6667)
* Fixes and tests

* Don't set subs be re-registered.

Also allow subs to de-register themselves and collect the deposit.

Also allow individual registering and removal of subs.

* Make it build

* Update frame/identity/src/lib.rs

Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>

* Tests

* Add benchmarks

* Add some reasonable weights

* Docs

Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
2020-07-17 11:11:03 +02:00
Max Inden fe9c01fc68 .maintain/monitoring/alerting-rules: Remove HighCPUUsage alert (#6648)
The `HighCPUUsage` alert is based on the `cpu_usage_percentage` metric.
Instead of exposing the overall CPU usage in percent, the metric exposes
the per core usage summed over all cores.

This commit removes the alert for two reasons:

1. Substrate itself does not expose the core count and thus one can not
alert based on the `cpu_usage_percentage` metric.

2. Alerting based on CPU usage is generic and not specific to Substrate
or Blockchains. Thus any CPU usage alert suffice.
2020-07-17 07:43:57 +00:00
Andronik Ordian 1ea2b27403 inclusion: split CandidatePendingAvailability according to the guide (#1413)
* inclusion: split PendingAvailability storage into descriptor and commitments

* inclusion: fix tests

* implementers-guide: update CandidatePendingAvailability type

* inclusion: simplify process_candidates a bit

* implementers-guide: more updates to the inclusion module

* inclusion: fix copy-paste errors in tests

* inclusion: revert some of the changes

* inclusion: lazy commitments loading and a test

* guide: revert enact_candidate changes

* inclusion: test process_bitfield for no commitments

* Grammar

Co-authored-by: Robert Habermeier <rphmeier@gmail.com>

Co-authored-by: Robert Habermeier <rphmeier@gmail.com>
2020-07-16 21:27:49 -04:00
Robert Habermeier 6e00002582 Runtime APIs for node-side code (#1401)
* create a README on Runtime APIs

* add ParaId type

* write up runtime APIs

* more preamble

* rename

* rejig runtime APIs

* add occupied_since to `BlockNumber`

* improve group_for_core

* improve docs on availability cores runtime API

* guide: freed -> free

* Update roadmap/implementers-guide/src/runtime-api/README.md

Co-authored-by: Peter Goodspeed-Niklaus <coriolinus@users.noreply.github.com>

* add explicit block parameter to runtime API fns

Co-authored-by: Peter Goodspeed-Niklaus <coriolinus@users.noreply.github.com>
2020-07-16 20:34:43 -04:00
Max Inden 6995e5e5e1 client/service/metrics: Rework metric HELP texts (#6647) 2020-07-16 23:07:32 +00:00
Gavin Wood 786cbacb40 Enable council elections (#1422) 2020-07-16 14:19:36 -04:00
Pierre Krieger 84d607b5ff Update substrate-networking Grafana dashboard (#6649) 2020-07-16 16:45:12 +00:00
Benjamin Kampmann 1628f537eb Regression test to ensure we don't break deterministic builds in wasm (#6597)
* Regression test to ensure we don't break deterministic builds in wasm again

* Apply suggestions from code review

Co-authored-by: s3krit <pugh@s3kr.it>

* Update .gitlab-ci.yml

Co-authored-by: s3krit <pugh@s3kr.it>

Co-authored-by: s3krit <pugh@s3kr.it>
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
2020-07-16 11:54:50 +00:00
Guillaume Thiolliere 4187827343 fix comment (#6670) 2020-07-16 13:13:12 +02:00
Cecile Tonglet 4ac2078992 The telemetry should not be initialized if no telemetry has been provided (#6666)
* Initial commit

Forked at: e10598af1f
Parent branch: origin/master

* Fix: do not initialize telemetry if telemetry is not set

* Update client/telemetry/src/lib.rs

Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com>

* Update client/telemetry/src/lib.rs

* Update client/telemetry/src/lib.rs

Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com>

Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com>
Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com>
2020-07-16 09:46:40 +00:00
Cecile Tonglet 2827637103 Remove polkadot companion detection from url anywhere (#6570) 2020-07-16 11:01:18 +02:00