* Make `decl_error!` errors usable
This pr implements support for returning errors of different pallets in
a pallet. These errors need to be declared with `decl_error!`.
The pr changes the following:
- Each dispatchable function now returns a `DispatchResult` which is an
alias for `Result<(), DispatchError>`.
- `DispatchError` is an enum that has 4 variants:
- `Other`: For storing string error messages
- `CannotLookup`: Variant that is returned when something returns a
`sp_runtime::LookupError`
- `BadOrigin`: Variant that is returned for any kind of bad origin
- `Module`: The error of a specific module. Contains the `index`,
`error` and the `message`. The index is the index of the module in
`construct_runtime!`. `error` is the index of the error in the error
enum declared by `decl_error!`. `message` is the message to the error
variant (this will not be encoded).
- `construct_runtime!` now creates a new struct `ModuleToIndex`. This
struct implements the trait `ModuleToIndex`.
- `frame_system::Trait` has a new associated type: `ModuleToIndex` that
expects the `ModuleToIndex` generated by `construct_runtime!`.
- All error strings returned in any module are being converted now to `DispatchError`.
- `BadOrigin` is the default error returned by any type that implements `EnsureOrigin`.
* Fix frame system benchmarks
* Update assets to `decl_error`
* Update aura to `decl_error`
* Update authority discovery to `decl_error`
* Update collective to `decl_error`
* Update evm to `decl_error!`
* Fix error with replace
* Revert "Update authority discovery to `decl_error`"
This reverts commit 26e8f3c56656963d847e984c6f2c8e1f88014899.
* Revert "Update aura to `decl_error`"
This reverts commit 8f17c44ca8375a4a755710aaab7ad4d9522c4376.
* Update democracy to `decl_error`
* Update finality-tracker to `decl_error`
* Update grandpa to `decl_error`
* `assert` to `ensure` in dispatchable function
* Adding script for rename, could be applicable for nodes on top of it, too
* add stderr and gitlab ci features
* apply script
* fix now minor details in expected stderr
* Update the Cargo.lock
* fix name: sc-transaction -> sc-tracing
* fix rename in script, too
Tomasz Drwięga