* Add option to relay for sending transfers to Millau chain
* Endow derived accounts on Millau chain
* Update message generator entrypoint script to send transfers
* Use correct command when sending messages
* Send Root messages from Root origin on source chain
* Wrap calls from Root Origin in Sudo Call
* Allow Root to send messages without paying fees
* Use correct variable when sending messages to Rialto
* Print warning if no message type is provided to script.
* Add note mentioning that certain source origins aren't supported yet
* Use correct runtime when initializing header sync
* Remove option to send messages as Root
* Remove endowment of derived Root accounts
* Fix indentation.
Co-authored-by: Tomasz Drwięga <tomasz@parity.io>
* Update `sp-io` dependency
* Rename Trait to Config
* RustFmt
* Bump `sp-io` again
* Use new frame_system weight types in Rialto and Millau runtimes
* Update test Runtimes to use new weight types
* Bump `sp-io` again
* Update to not-the latest first.
* Update benchmarks.
* Another Trai.
* Move new weight types into runtime primitive crates
This allows us to check limits for extrinsics from other parts
of the codebase without pulling in the entire chain runtime.
* Remove leftover comments
* Move new functions to a better location
* Small formatting fixes
* Add actual documentation to new weight config types
* Decrease maximum block weight of Millau chain
* Decreease maximum block length of Millau chain
Co-authored-by: Tomasz Drwięga <tomasz@parity.io>
* High level docs - start.
* Clean up README
* Start adding details to high level docs
* More docs on the header sync pallet
* Testing scenarios document.
* Add some scenarios.
* Add multi-sig scenario.
* Start writing about message dispatch pallet
* Move content from old README into PoA specific doc
* Apply suggestions from code review
Co-authored-by: Andreas Doerr <adoerr@users.noreply.github.com>
* GRANDPA for consistency.
* Describe scenario steps.
* WiP
* Add notes about block production and forks
* Update.
* Add sequence diagram for Millau to Rialto transfer
* Clean up header sync pallet overview
* Remove leftover example code
* Clean up testing scenarios and amend sequence diagram.
* Linking docs.
* Add some more docs.
* Do a bit of cleanup on the high-level docs
* Clean up the testing scenario
* Fix typos in flow charts
* Fix small typo
* Fix indentation of Rust block
* Another attempt at rendering block correctly
* TIL about lazy list numbering in Markdown
* Add list numbers across sections
* Start counting from correct number
* Update README to use correct path to local scripts
* Wrap ASCII art in code block
Co-authored-by: Tomasz Drwięga <tomasz@parity.io>
Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
Co-authored-by: Andreas Doerr <adoerr@users.noreply.github.com>
* Attempt at adding Cross-Chain Transfer Generator
* Add Transfer subcommand for sending messages to Rialto
* Add temp helper script for sending messages
* Remove Message and Lane Ids from Dispatch Event
* Increase transfer amount used by script
* Endow derived Dave account on Rialto with funds
* Update Message generator to send more types of messages
This commit first of all updates the script to use the new CLI
commands for sending messages. Second, it adds messages which are
sent from both Target and Source origins.
* Generate messages from Root origin
* Remove dbg! logs from relayer
* Log AccountId as well as HexId
* Remove Balances logs
* Add InstanceId and MessageId back to Dispatch Event
* Add InstanceId and MessageId types for Apps
* Add missing comment
* Document derived accounts as tests
* Move shared commands to variables
* Add example usage for send_message script
* Add docs to message variants
* Fix Clippy complaint
* limit maximal number of unconfirmed messages at inbound lane
* unrewarded_relayer_entries API
* change relay to support max unrewarded relayer entries
* Update modules/message-lane/src/inbound_lane.rs
Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
* Update relays/messages-relay/src/message_lane_loop.rs
Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
* removed pub
Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
* limit max number of messages in delivery tx
* support max-messages-in-delivery-tx in relayer
* clippy
* clippy
* Update modules/message-lane/src/lib.rs
Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
* Update some docs
* Add derived account origin
* Add tests for derived origin
* Do a little bit of cleanup
* Change Origin type to use AccountIds instead of Public keys
* Update (most) tests to use new Origin types
* Remove redundant test
* Update `runtime-common` tests to use new Origin types
* Remove unused import
* Fix documentation around origin verification
* Update config types to use AccountIds in runtime
* Update Origin type used in message relay
* Use correct type when verifying message origin
* Make CallOrigin docs more consistent
* Use AccountIds instead of Public keys in Runtime types
* Introduce trait for converting AccountIds
* Bring back standalone function for deriving account IDs
* Remove AccountIdConverter configuration trait
* Remove old bridge_account_id derivation function
* Handle target ID decoding errors more gracefully
* Update message-lane to use new AccountId derivation
* Update merged code to use new Origin types
* Use explicit conversion between H256 and AccountIds
* Make relayer fund account a config option in `message-lane` pallet
* Add note about deriving the same account on different chains
* Fix test weight
* Use AccountId instead of Public key when signing Calls
* Semi-hardcode relayer fund address into Message Lane pallet
* fixed clippy warnings
* Revert "Actually use pinned nightly version when building runtimes (#465)"
This reverts commit dedddb6b0f22260e00053c28873a0cb1fbea22e2.
* Revert "Pin Rust Nightly Version (#420)"
This reverts commit 8902ac2030cf7ef48ec512463424f134a3b38804.
* fix after revert
* another fix after revert
* more clippy fixes
* Allow bridge pallet to return no finalized headers
* Update Runtime APIs to optionally return best finalized header
* Update relay to handle optional best finalized headers
* Fix Clippy lints
* Return a dummy header instead of an Option
* Remove Option from runtime Apis
* Remove support for handling optional finalized headers in relay
* Copy-Pasta owner and freezing code from `message-lane`
* Halt pallet if bridge hasn't been initialized
* Make owner optional in `message-lane` pallet
* Add `is_halted` to `InitializationData`
* Fix initialization tests
* Only allow pallet to be initialized once
* Add some logging around halting and ownership changes
* Remove `target` in debugging calls
* Add dispatchable for intializing pallet
* Add Polkadot JS types for Substrate bridge pallet
* Ensure Root is the only one that can initialize the pallet
* Add some tests
* Pack initialization data into struct
* Only allow pallet to be initialized once
* Use new initialization config in nodes
* Rename ScheduledChange in Ethereum pallet
We're renaming it to prevent clashes with Substrate bridge pallet type
of the same name. This is relevant when importing types to Polkadot JS
Apps.
* Move all Polkadot JS types into one file
* Appease Clippy
* Support multiple "best headers" from different forks
* Update the name of a test
* Add note about multiple scheduled changes
* Disallow multiple scheduled authority set changes
* Return multiple best headers from Runtime APIs
* Remove invalid test write-up
* Add some sketch-ups of test scenarios
* Clean up test scenarios
* Add module for testing forks
* Write headers to storage
* Add way to check expected outcome for header imports
* Add support for importing finality proofs
* Support importing headers which schedule changes
* Write out test scenario using new framework
* Map authority set changes across forks
Gets all the tests in the `forks` module passing
* Remove basic tests
These were used when working on the initial test helper
* Prevent multiple pending set changes on the same fork
* Remove old test which allowed imports past unfinalized header
* Ignore failing test (for now)
* Rewrite `if` comparison using `match` and `cmp`
Fixes Clippy warning: `comparison_chain`
* Add helper for writing test headers with default characteristics
* Fix test that checked authority set updates
* Make note about importing headers on different unfinalized fork
* Perform some cleanup on the fork module
* Fix Clippy complaints
* Provide list of unfinalized headers to Runtime APIs
* Add proofs to expect() calls
* Make tests the focus of the forks module
* Allow specific errors to be checked in fork tests
* Remove unused method
* Replace unreachable() statement with expect()
* Rename storage `unfinalized_headers() `to make its purpose more clear
* Update Runtime API name in relayer to match pallet
* Commit `unfinalized_headers` changes I forgot to add
* Rename ChainTipHeight to BestHeight
* Make schedule_next_set_change require a mutable reference
* Remove check for key when enacting authority set
We only expect to take the happy-path in the pallet anyways, so this check
to save ourselves the time spent decoding the entry isn't really used.
* Clear justification set when writing headers to storage
* Clarify why we only allow one set change per fork
* Change best_headers() to return HeaderIDs
Prevents us from returning full headers (which are more expensive to
get from storage) since we only care about header IDs (number, hash)
anyways.
* Fix Clippy complaint
* Make note about equivocations
* Use HeaderIds when returning incomplete headers
This change stops returning full headers which are more expensive
to get from storage than header Ids (number, hash) are. Clients likely
don't need the full header anyways which is why this change is fine.
* Introduce HeaderId type to reduce type complexity
* Add signal hash to storage during genesis config
* Return error instead of expect()-ing
* Fix Clippy lint about `ok_or` fn call
* Rename `forks` module to indicate that it's for testing
* Use `const` for `expect()` proofs
* Remove check that key exists before `kill`-ing value
Co-authored-by: Svyatoslav Nikolsky <svyatonik@gmail.com>
* integrate message-lane RPCs into Millau and Rialto runtime
* fmt
* use instance in InboundLanes
* moved RialtoMessageLaneKeys/MillauMessageLaneKeys inside rpc_extensions_builder to ease Substrate refs update
* reward relayers for dispatching messages
* clippy
* Update modules/message-lane/src/lib.rs
Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
* added comment
* Update modules/message-lane/src/inbound_lane.rs
Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
* Update modules/message-lane/src/inbound_lane.rs
Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
* SubmitterId + RelayerId -> AccountId
* add confirmation_relayer arg to pay_relayer_reward
* cargo fmt --all
* removed verify_and_decode_messages_proof from SourceHeaderChain
* &mut self -> RefCell
* Optimize max messages at inbound lane (#418)
* Add tests for checking messages above max limit
Signed-off-by: MaciejBaj <macie.baj@gmail.com>
* Extend the relayers entry of inbound lane by additional msg nonce
Signed-off-by: MaciejBaj <macie.baj@gmail.com>
* Support additional message nonce from inbound relayers
Signed-off-by: MaciejBaj <macie.baj@gmail.com>
* Code format
Signed-off-by: MaciejBaj <macie.baj@gmail.com>
* Merge messages range for highest relayers
* Change unwrap() to ensure() while accessing relayers
* Edit rustdocs for relayers deque at inbound lane data
Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
* Declare additional relayers A & B and use across tests consistently
Signed-off-by: MaciejBaj <macie.baj@gmail.com>
* Remove duplicates and improve naming for inbound lane tests
* Fix test checking max limit per inbound lane
* Correct relayers rewards loop after a proof is received
* Remove redundant check for messages ahead of received range
* Correct grammar at inbound lane tests rustdocs
Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
* Improve code quality of relayers updates 💅
Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
* Test dispatches above max limit from same relayer
Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
* Fix typo.
Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
Co-authored-by: Maciej Baj <macie.baj@gmail.com>
Co-authored-by: Tomasz Drwięga <tomasz@parity.io>
* add HeaderTimestamp associated type
* use Header Timestamp
* rename HeaderTimestamp to ChainTime
* add unit test
* deal with clippy
* Apply suggestions from code review
Commit review suggestions
Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
* code review
* cargo fmt
* get rid of additional test runtime
* unit test asserts against concrete import context
Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
* Add Rialto as a target for the Millau node
* Rename Rialto module to Rialto-PoA
This will reduce confusion as the Millau runtime has a
Rialto module as well which refers to the Substrate chain.
* Add Millau as a target for the Rialto node
* Be more explicit about Rialto PoA related code
* Missed some name changes in the Ethereum PoA relay
* Re-export Substrate pallet structs used by node
* Remove `first_scheduled_change` of Millau in Rialto node
* Make Millau's genesis config for Rialto bridge more accurate
* Set initial header for Millau config
* Update initial Millau authorities
Co-authored-by: Svyatoslav Nikolsky <svyatonik@gmail.com>
* RustFmt Millau authorities
Co-authored-by: Svyatoslav Nikolsky <svyatonik@gmail.com>
* Implement public helpers for querying header info
* Update `best_header` when importing headers
* Add BestHeader to GenesisConfig
* Define extra types for Millau primitives
* Start implementing runtime APIs in Millau runtime
* Add helper for getting headers which require a justification
* Add runtime API for getting headers requiring a justification
* Reword `expect()` proof for valid authority sets
* Fix typo
* Clean up Hasher comment
* Add the Call Dispatch Pallet back to the Millau runtime
* Use types from Rialto in bridge pallet config
* Use the Rialto runtime APIS in the Millau runtime
* Include Millau bridge instance in Rialto runtime
* Add missing doc comment
* Use one storage function for setting and clearing `RequiresJustification`
* Remove TODO comments
* Split the Rialto Node into a standalone crate
* Split the Millau Node into a standalone crate
* Remove `bridge-node` crate
* Add benchmarking feature to nodes
* Check that benchmarks compile in CI
* Remove nodes from CI matrix
* Update Rialto node to Substrate 2.0
* Get Millau node compiling with Substrate 2.0
* Remove extra license text
* Remove comments in TOML files
* Move nodes and runtimes into Rialto and Millau folders
* Fix dependency paths
* Remove unused script
* Add issue to benchmarking TODO
* Fix benchmark manifest paths
* Remove the Substrate primitives crate
The types here were only used in one place, the pallet itself. If other
components start using these types we can considering moving them back
into a standalone crate.
* Start trying to integrate justification module
* Make Substrate blocks configurable in Pallet
* WIP: Try and generalize justification test helpers
* Fix tests which use "real" justifications
* Put common test helpers alongside mock code
* Use common helper for creating headers
* Remove usage of UintAuthorityId
This change favours the use of the Ed25519Keyring authorities
in order to keep things consistent with the tests.
* Add documentation around config trait types
* Make test header, hash, and number types consistent
* Update modules/substrate/src/verifier.rs
Co-authored-by: Svyatoslav Nikolsky <svyatonik@gmail.com>
* Update modules/substrate/src/lib.rs
Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
* Update modules/substrate/Cargo.toml
Co-authored-by: Svyatoslav Nikolsky <svyatonik@gmail.com>
* Derive `RuntimeDebug` instead of `Debug`
* Add `Paramter` as a trait constraint on config types
Since we use these types as part of the dispatchable functions
we should explicitly require this.
* Enforce that hasher output matches expected hash type
* Accept headers over indexes when making test justifications
* Check that authority sets are valid
* Make Clippy happy
* Apply correct Clippy fix
* Move justification code into primitives module
* Use new module in verifier code
* Add primitives module for Substrate test helpers
* WIP
* Move justification generation into test_helpers
* Revert commits which move `justification` into primitives
This reverts commit 03a381f0bc4a8dbe4785c30d42ab252a06ba876c.
Co-authored-by: Svyatoslav Nikolsky <svyatonik@gmail.com>
Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
* Add pallet template from Substrate Dev Hub
* Clean up un-needed stuff from template
* Sketch out dispatchable interface
* Introduce notion of finality chain
* Add dependencies which were removed during a rebase
* Sketch out idea for finality header-chain pallet
* Sketch out ChainVerifier trait
* Add storage parameter to verifier
* Write out some things I think I need for finality verification
* Add some pseudocode for marking finalized headers
* Remove parity_scale_codec duplicate
* Move verification logic into pallet
I've been struggling with getting the generic types between the storage and verifier
traits to play nice with each other. As a way to continue making progress I'm moving
everything to the pallet. This way I hope to make progress towards a functional
pallet.
* Start doing verification around authority set changes
* Remove commented BridgeStorage and ChainVerifier traits
* Create Substrate bridge primitives crate
* Add logic for updating scheduled authority sets
* Introduce notion of imported headers
* Implement basic header ancestry checker
* Add mock runtime for tests
* Add testing boilerplate
* Add some storage read/write sanity tests
* Add some basic header import tests
* Add tests for ancestry proofs
* Create helper for changing authority sets
* Fix authority set test
Fixes a problem with how the scheduled change was counted as well as
a SCALE encoding issue
* Correctly check for scheduled change digests
There's no guarantee that the consensus digest item will be the last
one in a header, which is how it was previously being checked.
Thanks to Andre for pointing me to the Grandpa code that does this.
* Mark imported headers as finalized when appropriate
When a header that finalizes a chain of headers is succesfully imported
we also want to mark its ancestors as finalized.
* Add helper for writing test headers
* Add test helper for scheduling authority set changes
* Bump Substrate pallet and primitives to rc6
* Remove Millau verifier implementation
* Add some doc comments
* Remove some needless returns
* Make Clippy happy
* Split block import from finalization
* Make tests compile again
* Add test for finalizing header after importing children
* Create a test stub for importing future justifications
* Start adding genesis config
* Reject justifications from future
We should only be accepting justifications for the header
which enacted the current authority set. Any ancestors of
that header which require a justification can be imported
but they must not be finalized.
* Add explanation to some `expect()` calls
* Start adding GenesisConfig
* Plug genesis config into runtime
* Remove tests module
* Check for overflow when updating authority sets
* Make verifier take ownership of headers during import
* Only store best finalized header hash
Removed the need to store the whole header, since we store
it was part of the ImportedHeaders structure anyways
* Add some helpers to ImportedHeader
* Update ancestry checker to work with ImportedHeaders
* Update ancestry tests to use ImportedHeaders
* Update import tests to use ImportedHeaders
* Clean up some of the test helpers
* Remove stray dbg!
* Add doc comments throughout
* Remove runtime related code
* Fix Clippy warnings
* Remove trait bound on ImportedHeader struct
* Simplify checks in GenesisConfig
* Rename `get_header_by_hash()`
* Alias `parity_scale_codec` to `codec`
* Reword Verifier documentation
* Missed codec rename in tests
* Split ImportError into FinalizationError
* Remove ChainVerifier trait
This trait was a remenant of the original design, and it is not required
at the moment. Something like it should be added back in the future to
ensure that other chains which conform to this interface can be used
by higher-level bridge applications.
* Fix the verifier tests so they compile
* Implement Deref for ImportedHeader
* Get rid of `new` methods for some Substrate primitives
* Ensure that a child header's number follows its parent's
* Prevent ancestry checker from aimlessly traversing to genesis
If an ancestor which was newer than the child header we were checking we
would walk all the way to genesis before realizing that we weren't related.
This commit fixes that.
* Remove redundant clones
* Ensure that old headers are not finalized
Prevents a panic where if the header being imported and `best_finalized`
were the same header the ancestry checker would return an empty list. We
had made an assumption that the list would always be populated, and if this
didn't hold we would end up panicking.
* Disallow imports at same height as `best_finalized`
* Fix Clippy warnings
* Make NextScheduledChange optional
* Rework how scheduled authority set changes are enacted
We now require a justification for headers which _enact_ changes
instead of those which _schedule_ changes. A few changes had to
be made to accomodate this, such as changing when we check for
scheduled change logs in incoming headers.
* Update documentation for Substrate Primitives
* Clarify why we skip header in requires_justification check
* Add description to assert! call
* Fix formatting within macros
* Remove unused dependencies from runtime
* Remove expect call in GenesisConfig
* Turn FinalityProof into a struct
* Add some inline TODOs for follow up PRs
* Remove test which enacted multiple changes
This should be added back at some later point in time, but right now
the code doesn't allow for this behaviour.
* Use `contains_key` when checking for header
This is better than using `get().is_some()` since we skip
decoding the storage value
* Use initial hash when updating best_finalized
* Add better checks around enacting scheduled changes
* Rename finality related functions
* Appease Clippy
Svyatoslav Nikolsky