9a4e23d594
service: fix RPC unsafe exposed address detection ( #6070 )
2020-05-19 02:16:48 +01:00
d5411969ac
fix whitespace ( #6062 )
2020-05-18 13:51:28 +02:00
cdb7808a0e
Remove on_block_imported ( #6039 )
...
* remove on_block_imported
* Update client/network/src/service.rs
Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com >
Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com >
2020-05-16 12:59:34 +02:00
efc4849f1a
Meter block import results via prometheus ( #6025 )
2020-05-15 17:25:51 +02:00
be8c96adec
Relax substrate licensing scheme ( #5947 )
2020-05-15 13:21:56 +02:00
e4edd502bf
Only send last finalized block to telemetry ( #6003 )
...
Instead of informing the telemetry about each block that is finalized,
we only need to send the last finalized block. This removes log spam on
initial sync.
2020-05-12 22:08:24 +01:00
9220bdf361
Spawn the network worker with spawn_blocking ( #5909 )
...
* Spawn the network worker with spawn_blocking
* Some comment adjustments
* Fix shutdown not working
2020-05-12 17:12:32 +02:00
679c91e18c
Refactor network transactions handling ( #5939 )
...
* change propagation
* add bound
2020-05-11 10:36:00 +02:00
fd35738163
Improve error message when essential task failed ( #5918 )
...
* Initial commit
Forked at: 9acf88f58b
2020-05-06 15:28:00 +02:00
ddf6f8a1e1
Fix wrong task name ( #5917 )
2020-05-06 15:27:18 +02:00
9acf88f58b
client: Replace unsafe_rpc_expose with an RpcMethods enum ( #5729 )
...
* client: Replace `unsafe_rpc_expose` with an `RpcMethods` enum
which can be either Default, Safe or Unsafe. The idea is to have the
following:
| | --rpc-external=false | --rpc-external=true |
|--------------------- |------------------- |----------------- |
| --rpc-methods=Default | | unsafe calls denied |
| --rpc-methods=Safe | unsafe calls denied | unsafe calls denied |
| --rpc-methods=Unsafe | | |
Since the previous `unsafe-rpc-expose` option was confusing.
* client: Only warn against exposing externally unsafe RPC method set
* Apply suggestions from code review
Co-Authored-By: Cecile Tonglet <cecile.tonglet@cecton.com >
* cli: Rephrase doc comment for rpc_methods config
* Improve debuggability of build_spec_works
...by printing to stderr the stderr of the command. This is normally
suppressed for succesful tests but not for failing ones - if that's the
case then it's useful to see the test failure reason inline rather than
having to execute the command separately ourselves.
* Rename RpcMethods::{Default => Auto} variant
* Update bin/node/cli/tests/build_spec_works.rs
Co-authored-by: Benjamin Kampmann <ben.kampmann@googlemail.com >
Co-authored-by: Cecile Tonglet <cecile.tonglet@cecton.com >
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
2020-05-06 11:30:54 +02:00
9c5536e01a
Expose that BasicQueue expects blocking spawn ( #5860 )
...
* Expose that `BasicQueue` expects blocking spawn
Up to now `BasicQueue` expected a closure that to spawn a `Future`.
This was expected to be a closure that spawns a blocking future.
However, this wasn't documented anywhere. This pr introduces a new trait
`SpawnBlocking` that exposes this requirement to the outside.
* Feedback
2020-05-04 19:40:29 +02:00
4151dc6bfe
Use header cache when creating state. ( #5868 )
...
* Use header cache for state_at
* Fixed warnings
* Update client/db/src/lib.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
2020-05-04 13:47:23 +00:00
ccc3f9767c
Report tasks panics in metrics ( #5878 )
...
* Report tasks panics in metrics
* Renames
* Renames
2020-05-04 13:43:54 +02:00
5b8d3607e9
Adds export-state subcommand ( #5842 )
...
* Export state cli
* More work
* Fix tests
* Make it work
* Fix compilation
* Apply suggestions from code review
2020-04-30 15:44:40 +02:00
71d3863a78
Remove background_tasks field in ServiceBuilder ( #5830 )
...
* Spawn tasks instead of pushing them to background_tasks
* Remove unnecessary mut keyword for self
* Remove background_tasks field in ServiceBuilder
2020-04-29 20:47:42 +02:00
1fd18dd260
Drop ClientProvider ( #5823 )
2020-04-29 18:48:24 +02:00
0f401e4699
Move spawning tasks from thread pools to Service's TaskManager for block importing ( #5647 )
...
Co-Authored-By: Pierre Krieger <pierre.krieger1708@gmail.com >
2020-04-29 18:46:39 +02:00
4fa5941f44
Move sc-client into sc-service ( #5502 )
...
* Drop client from sc-network and sc-client-db, move LongestChain to sc-client-api
* move leaves, cht, in_mem to sc-client-api, drop client from sc-finality-grandpa
* drop sc-service from sc-rpc
* drop sc-service from sc-consensus-aura
* drop sc-client from manual-seal and babe
* drop sc-client from utils/frame/rpc/system and utils/frame/benchmarking-cli
* drop sc-client from bin/node and bin/node-template
* drop sc-client
* fix tests
* remove check -p sc-client from gitlab.yml
* fix warnings
* fixes ui test
* fix light client tests
* adds associated Client type to AbstractService
* adds UsageProvider to Client
* fixed ui test, again
* tried and failed to get node-cli to compile for wasm
* thanks to tomaka for helping me get node-cli to compile for wasmm
* ui test pls pas 🙏🏾
* all tests passing 🪄
* no_run documentation code
* rm -f documentation code
* ClientProvider
* fix mega trait
* move LongestChain to sc-consensus, use adds minimal bounds to AbstractService::Client
* adds license to sc-consensus
Co-authored-by: Benjamin Kampmann <ben@parity.io >
2020-04-28 11:59:31 +00:00
9e4901f3d5
Add method with_default_block_announcer to ServiceBuilder ( #5797 )
...
* Initial commit
Forked at: 64ed36d093
2020-04-27 15:05:11 +00:00
72ee7d5797
feat/ocw/bookkeeping ( #5200 )
...
Co-Authored-By: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
Co-Authored-By: Tomasz Drwięga <tomusdrw@users.noreply.github.com >
2020-04-24 16:46:19 +02:00
f66168505b
Fix the cfg guards in service/metrics.rs ( #5770 )
2020-04-24 16:16:54 +02:00
f5d7b5bc92
Remove TaskManagerBuilder ( #5725 )
...
* Remove TaskManagerBuilder
* Clean up use declaration fo SpawnTaskHandle
Co-Authored-By: Pierre Krieger <pierre.krieger1708@gmail.com >
Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com >
2020-04-22 00:35:01 +02:00
4ffcf98d8d
Child trie api changes BREAKING ( #4857 )
...
Co-Authored-By: thiolliere <gui.thiolliere@gmail.com >
2020-04-20 15:21:22 +02:00
4b1f7d187f
Allow to expose a subset of unsafe RPCs ( #5233 )
...
* sc-cli: Use type-safe constructors for RPC/Prometheus interfaces
* service: Simplify rpc handler creation
Could probably be further simplifies once [this][commit] lands.
[commit]: https://github.com/paritytech/jsonrpc/commit/20485387ed06a48f1a70bf4d609a7cde6cf0accf
* service: Streamline some HTTP & WS server start logic
* client: Introduce a simple RPC policy mechanism
* rpc/system: Check unsafe RPCs
* rpc/offchain: Check unsafe RPCs
* rpc/author: Check unsafe RPCs
2020-04-20 11:03:58 +02:00
fea626ca84
Add prometheus registry to transaction pool, with couple of initial metrics ( #5657 )
...
* make new contructor
* add metrics to txpool
* fix review
* fix doc comment
* change to counters
* Update client/transaction-pool/src/metrics.rs
Co-Authored-By: Max Inden <mail@max-inden.de >
* Update client/transaction-pool/src/metrics.rs
Co-Authored-By: Max Inden <mail@max-inden.de >
* Update client/transaction-pool/src/metrics.rs
Co-Authored-By: Max Inden <mail@max-inden.de >
* Update client/transaction-pool/src/lib.rs
Co-Authored-By: Max Inden <mail@max-inden.de >
* Update client/transaction-pool/src/lib.rs
Co-Authored-By: Max Inden <mail@max-inden.de >
* use dedicated wrapper
Co-authored-by: Max Inden <mail@max-inden.de >
2020-04-17 11:02:45 +02:00
95ee37d242
Add alternative RPC methods to system_networkState ( #5643 )
...
* Add alternatives to system_networkState
* Fix tests
* Apply suggestions from code review
Co-Authored-By: Tomasz Drwięga <tomusdrw@users.noreply.github.com >
Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com >
2020-04-16 16:36:14 +01:00
91af5b6fcc
New database trait ( #5549 )
...
* Introduce trait
* The trait
* Generic
* Basic impls.
* Remove unneeded bounds
* Minor changes
* Switch over to the new DB trait
* Integrated parity-db and added CLI for db selection
* Default impl.
* Fix logs.
* Started integrating subdb
* Apply suggestions from code review
Co-Authored-By: Cecile Tonglet <cecile@parity.io >
* Apply suggestions from code review
Co-Authored-By: Nikolay Volf <nikvolf@gmail.com >
* Enable subdb
* Bump parity-db
* Fixed CLI macro
* Fixed browser build
* Fixed features
* Sort out features
* Use parity-db from crates.io
* Typo
Co-authored-by: arkpar <arkady.paronyan@gmail.com >
Co-authored-by: Cecile Tonglet <cecile@parity.io >
Co-authored-by: Nikolay Volf <nikvolf@gmail.com >
2020-04-15 14:38:39 +02:00
cff1390456
Report tasks metrics to Prometheus ( #5619 )
...
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
2020-04-15 11:10:03 +02:00
7cdfaff12b
Add new RPC method to get the chain type ( #5576 )
...
* Add new RPC method to get the chain type
This adds a new RPC method to get the chain type of the running chain.
The chain type needs to be specified in the chain spec. This should make
it easier for tools/UI to display extra information without needing to
rely on parsing the chain name.
* Update client/rpc-api/src/system/mod.rs
Co-Authored-By: Tomasz Drwięga <tomusdrw@users.noreply.github.com >
* Primitive crate
* Feedback
Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com >
2020-04-08 20:41:51 +02:00
f202c58bbb
Fix compilation of service metrics on Windows ( #5548 )
...
* Fix compilation of service metrics on Windows
* Fix browser node
* Ahh
* Remove duplicate code...
2020-04-07 19:32:21 +02:00
3da069e359
CLI: refactoring: remove Options from sc_service::Configuration's fields ( #5271 )
...
* WIP
Forked at: d6aa8e954cd6aa8e954cd6aa8e954cd6aa8e954cd6aa8e954cd6aa8e954cd6aa8e954cseunlanlege@gmail.com >
* Fail if using proc_macro and build.rs is not set properly
* Dropped all get_ in front of methods
* Clean-up
* Fixing proc macro missing env var
* Get the configuration inside the Runtime (needed for polkadot)
* Clean-up
* Get is_dev from argument like the others
* Get chain ID instead of chain spec from shared params
* &self is passed to spec_factory/load_spec
* Wrong text
* Fix example
* Officialize macro and made a cool doc
* Renamed spec_factory to load_spec (substrate_cli_configuration)
* Removed not so useful ChainSpec
* Renamed SubstrateCLI to SubstrateCli
* Added changelog for impl_version being full now
* Renamed Runtime to Runner
* Update changelog to show example
* Removed option on database cache size
* WIP
Forked at: d6aa8e954cd6aa8e954cd6aa8e954cd6aa8e954cd6aa8e954cd6aa8e954cd6aa8e954cbkchr@users.noreply.github.com >
* Update client/cli/src/commands/runcmd.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/cli/src/commands/export_blocks_cmd.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/cli/src/commands/check_block_cmd.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Update bin/node/cli/src/command.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Update bin/node/cli/src/command.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/cli/src/commands/export_blocks_cmd.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Revert "Update client/cli/src/commands/export_blocks_cmd.rs"
This reverts commit 5906776953392c02beac6bc0bf50f8cbe1a12a01.
* Revert "Update client/cli/src/commands/check_block_cmd.rs"
This reverts commit f705f42b7f3d732be001141afee210fe46a1ef47.
* Revert "Update client/cli/src/commands/export_blocks_cmd.rs"
This reverts commit 8d57c0550164449e6eb2d3bacb04c750c714fcea.
* Revert "Update client/cli/src/commands/runcmd.rs"
This reverts commit 93e74cf5d2e1c0dc49cdff8608d59fc40fc59338.
* Revert "Update client/cli/src/commands/runcmd.rs"
This reverts commit 11d527ba345c0d79f0d3b5b071933d95474d0614.
* Update client/cli/src/commands/export_blocks_cmd.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/cli/src/commands/import_blocks_cmd.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/cli/src/commands/purge_chain_cmd.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Changed ::sc_cli to $crate in the macro
* fixed tests
* fixed conflicts
* Fixing test
* Update client/cli/src/commands/purge_chain_cmd.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/cli/src/params/pruning_params.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Remove comment as suggested
* Apply suggestion
* Update client/cli/src/commands/purge_chain_cmd.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/cli/src/commands/purge_chain_cmd.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/cli/src/commands/purge_chain_cmd.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Update utils/frame/benchmarking-cli/src/command.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/cli/src/runner.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/cli/src/runner.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/cli/src/runner.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/cli/src/params/pruning_params.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/cli/src/params/node_key_params.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/cli/src/params/network_params.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/cli/src/lib.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/cli/src/config.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Added doc
* Fixed error introduced after applying suggestion
* Revert "Update client/cli/src/params/pruning_params.rs"
This reverts commit 0574d06a4f1efd86e94c1214420a12e7a4be0099.
* Print error
* Apply suggestions from code review
* Remove useless Results
* Fixed CI failing on polkadot approval
Co-authored-by: Seun Lanlege <seunlanlege@gmail.com >
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
2020-04-07 11:38:07 +02:00
d155a9d97d
Fix non-linux build of sc-client ( #5524 )
...
* procfs is linux only
* also for the import
* fixup non-linux build
2020-04-04 19:52:19 +02:00
247822bb33
Additional Metrics collected and exposed via prometheus ( #5414 )
...
This PR refactors the metrics measuring and Prometheus exposing entity in sc-service into its own submodule and extends the parameters it exposes by:
- system load average (over one, five and 15min)
- the TCP connection state of the process (lsof), refs #5304
- number of tokio threads
- number of known forks
- counter for items in each unbounded queue (with internal unbounded channels)
- number of file descriptors opened by this process (*nix only at this point)
- number of system threads (*nix only at this point)
refs #4679
Co-authored-by: Max Inden <mail@max-inden.de >
Co-authored-by: Ashley <ashley.ruglys@gmail.com >
2020-04-04 15:13:35 +02:00
8c03a4fcef
Split the Roles in three types ( #5520 )
...
* Split the Roles bitfield in three
* Forgot to include some changes
* Fix cli test
* More test fixes
* Oh God, merging master broke other tests
* Didn't run the doctests
* Address review
* I'm trying to fix the build blindly because it's taking a good hour to compile on my machine
* Address some review
* Also update the peerset's API to make sense
* Fix peerset tests
* Fix browser node
* client: distinguish between local and network authority
Co-authored-by: André Silva <andre.beat@gmail.com >
2020-04-03 19:08:14 +02:00
3b43429729
More emojies and spaces ( #5498 )
...
* More emojies and spaces
* Sync emojis
* More emoji
2020-04-02 20:17:39 +02:00
433824511e
Reset benchmarks by removing post-genesis changes ( #5435 )
...
* Reset by removing pos-genesis changes
* CLI option for DB cache size
* Update Cargo.lock
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com >
2020-04-01 14:08:23 +02:00
439887a773
Allow changing the behavior for imported blocks ( #5236 )
...
* Added option to disable default block announce
* Added on_block_imported on NetworkService
* Revert "Added on_block_imported on NetworkService"
This reverts commit ba360cad96e0cb041d7047af30df2a35eb112449.
* Do not announce block if set to not announce block
* Revert fix
* Moving default announce block to NetworkConfig
* WIP
Forked at: ad90ab7ec9ad90ab7ec9ad90ab7ec9ad90ab7ec9
2020-03-31 11:02:16 +02:00
c3c8552aaa
src/service/src/builder: Fix memory metric exposed in bytes not KiB ( #5459 )
...
The library `sysinfo` exposes process memory as kibibytes and not bytes,
thus the value needs to be multiplied by 1024 to comply with the metric
name and the Prometheus base units [1].
[1] https://prometheus.io/docs/practices/naming/#base-units
2020-03-30 15:48:59 +02:00
acab5f0570
Add emojis ( #5420 )
2020-03-27 10:41:31 +01:00
04ccb179e9
Pass transaction source to validate_transaction ( #5366 )
...
* WiP
* Support source in the runtime API.
* Finish implementation in txpool.
* Fix warning.
* Fix tests.
* Apply suggestions from code review
Co-Authored-By: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
Co-Authored-By: Nikolay Volf <nikvolf@gmail.com >
* Extra changes.
* Fix test and benches.
* fix test
* Fix test & benches again.
* Fix tests.
* Update bumpalo
* Fix doc test.
* Fix doctest.
* Fix doctest.
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
Co-authored-by: Nikolay Volf <nikvolf@gmail.com >
2020-03-25 14:09:23 +01:00
e85d7a4ba7
Fix propagation in network ( #5395 )
...
* fix propagation in network
* Update client/service/src/lib.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* fix suggestion
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
2020-03-25 13:03:58 +01:00
372745705d
create parallel tasks extension ( #5249 )
2020-03-16 16:30:39 +01:00
9898fc7e81
removes use of sc_client::Client from sc_network ( #5147 )
...
* removes use of sc_client::Client from sc_network
* rename BlockProvider to BlockBackend
* fix broken test
2020-03-12 14:02:04 +01:00
dc0bf210fb
ChainSpec trait ( #5185 )
...
* ChainSpec trait
* Apply suggestions from code review
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Added docs
* Fixed build
* Fixed build
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
2020-03-12 00:00:10 +01:00
93ee3104e7
Use CLI to configure max instances cache ( #5177 )
...
* Use CLI to configure max instances cache
* Fix tests
* Move default value into CLI
* Use SmallVec
* Apply review comments
* Get rid of `SmallVec`
Co-authored-by: Bastian Köcher <git@kchr.de >
2020-03-11 09:43:37 +01:00
0cc3b96076
client/service/src/builder.rs: Add build_info metric ( #5192 )
...
* client/service/src/builder.rs: Add build_info metric
Add static Prometheus metric exposing the chain name, the version and
the commit.
* client/service/src/builder.rs: Move node_role to static metrics
The Prometheus metrics `node_role` is static and thus there is no need
to keep a reference of it within `ServiceMetrics`. This follows the
example of the `build_info` metric.
* client/service/src/builder.rs: Adjust indentation
2020-03-10 11:12:32 +01:00
5e1667c406
Add state/database caches to prometheus ( #5165 )
...
* add state/database caches to prometheus
* also state-db memory
* use suggestions from review
2020-03-06 18:32:33 +01:00
c244b1d036
Revert "Build block without checking signatures ( #4916 )" ( #5159 )
...
* Revert "Build block without checking signatures (#4916 )"
This reverts commit e50f610907
2020-03-06 15:27:59 +01:00
99ae5342eb
removes use of sc_client::Client from sc-rpc ( #5063 )
...
* removes use of sc_client::Client from sc-rpc
* remove Client impl from sc-finality-benches
* remove client impl from sc-finality-grandpa
* read_proof accepts iterator
* remove generic Executor param from ExecutorProvider
* fix long ass line
* code style changes
* merge with master
Co-authored-by: Arkadiy Paronyan <arkady.paronyan@gmail.com >
2020-03-05 16:41:10 +01:00
André Silva