9fc4e16eff
Version bump to v0.9.26/9260 ( #5755 )
...
* Bump spec_version to 9260
* Version bump to v0.9.26
2022-07-06 10:31:45 +00:00
9dc99f0229
Limit stagnant checks to a certain amount of entries ( #5742 )
...
* Limit number of elements loaded from the stagnant key
This will likely be required if we enable stagnant prunning as currently database has way
too many entries to be prunned in a single iteration
* Fmt run
* Slightly improve logging
* Some more debug nits
* Fmt pass
2022-07-04 08:08:27 +00:00
09b10fa25e
Bump parity-scale-codec from 3.1.2 to 3.1.5 ( #5720 )
...
Bumps [parity-scale-codec](https://github.com/paritytech/parity-scale-codec ) from 3.1.2 to 3.1.5.
- [Release notes](https://github.com/paritytech/parity-scale-codec/releases )
- [Changelog](https://github.com/paritytech/parity-scale-codec/blob/master/CHANGELOG.md )
- [Commits](https://github.com/paritytech/parity-scale-codec/compare/parity-scale-codec-3.1.2...parity-scale-codec-3.1.5 )
---
updated-dependencies:
- dependency-name: parity-scale-codec
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-06-27 10:27:49 +00:00
94a85eeac7
pvf: ensure enough stack space ( #5712 )
...
* pvf: ensure enough stack space
* fix typos
Co-authored-by: Andronik <write@reusable.software >
* Use rayon to cache the thread
Co-authored-by: Andronik <write@reusable.software >
2022-06-24 13:16:36 +02:00
e03c24ec47
pvf: unignore terminates_on_timeout test ( #5722 )
2022-06-23 12:45:19 +00:00
97f9b840e4
bump versions to 0.9.25 ( #5684 )
...
* kusama: bump spec_version to 9250
* polkadot: bump spec_version to 9250
* rococo: bump spec_version to 9250
* westend: bump spec_version to 9250
* bump version to 0.9.25
* bump transaction version (polkadot & kusama) (#5690 )
* kusama: bump transaction_version to 12
* polkadot: bump transaction_version to 13
2022-06-21 13:02:04 +00:00
1dc991374b
Get rid of unnecessary clone. ( #5685 )
2022-06-16 19:15:20 +00:00
345fe4fa23
Bump lru from 0.7.5 to 0.7.7 ( #5675 )
...
Bumps [lru](https://github.com/jeromefroe/lru-rs ) from 0.7.5 to 0.7.7.
- [Release notes](https://github.com/jeromefroe/lru-rs/releases )
- [Changelog](https://github.com/jeromefroe/lru-rs/blob/master/CHANGELOG.md )
- [Commits](https://github.com/jeromefroe/lru-rs/compare/0.7.5...0.7.7 )
---
updated-dependencies:
- dependency-name: lru
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-06-14 19:16:30 +00:00
c3c10ce4c4
Fix a storage leak in parachains db ( #5594 )
...
* Fix cleanup of old votes.
* Cleanup.
* Get rid of redundant import
* Tests + logging
* Fix db key name.
* Add some reasoning to batch size.
* Add dispute data to indexed columns
* Fix fmt
* Add helper function.
* Fix typos.
* Update node/core/dispute-coordinator/src/db/v1.rs
Co-authored-by: Andronik <write@reusable.software >
* Update node/core/dispute-coordinator/src/db/v1.rs
Co-authored-by: Andronik <write@reusable.software >
* Add metric for how long cleanup takes.
Co-authored-by: Andronik <write@reusable.software >
2022-06-13 15:38:42 +02:00
72723c8a9f
Request backed candidates unbounded. ( #5610 )
...
We are awaiting on the oneshot anyways, so we have back pressure. By
using the unbounded channel make log messages like the following less
likely (due to higher priority):
2022-05-30 13:46:38
2022-05-30 11:46:38.565 WARN tokio-runtime-worker parachain::provisioner: failed to assemble or send inherent data err=CanceledBackedCandidates(Canceled)
2022-05-30 22:04:12 +02:00
026848c932
Companion to Substrate #11490 ( #5603 )
...
* Fix warnings
* Bump
2022-05-30 11:21:03 +01:00
13900dfeea
Improve forceApprove logging ( #5595 )
...
* Add some meaningful logging to the force approval to understand why it fails
* Add original block into the log to simplify logs lurking
* Update node/core/approval-voting/src/import.rs
Co-authored-by: asynchronous rob <rphmeier@gmail.com >
Co-authored-by: asynchronous rob <rphmeier@gmail.com >
2022-05-27 09:32:24 +00:00
7eba8f2162
bump to 0.9.23 ( #5593 )
...
* bump version to 0.9.23
* bump spec_version to 9230
2022-05-27 10:18:23 +02:00
d0453cf24d
Migrate provisioner subsystem ( #5568 )
2022-05-23 14:43:58 -05:00
4060017059
Availability: provisioner bitfield metrics ( #5484 )
...
* Add histogram for inherent data bitfields
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* -500ms bitfield sign job delay, +500ms bitfield gossip
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Revert "-500ms bitfield sign job delay, +500ms bitfield gossip"
This reverts commit 3d3f2c0fae651653ffdca50c1ad38c5757166edc.
* fmt
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Update node/core/provisioner/src/metrics.rs
Co-authored-by: Bernhard Schuster <bernhard@ahoi.io >
Co-authored-by: Andronik <write@reusable.software >
Co-authored-by: Bernhard Schuster <bernhard@ahoi.io >
2022-05-19 18:53:43 +02:00
450ca2baca
overseer becomes orchestra ( #5542 )
...
* rename overseer-gen to orchestra
Also drop `gum` and use `tracing`.
* make orchestra compile as standalone
* introduce Spawner trait to split from sp_core
Finalizes the independence of orchestra from polkadot-overseer
* slip of the pen
* other fixins
* remove unused import
* Update node/overseer/orchestra/proc-macro/src/impl_builder.rs
Co-authored-by: Vsevolod Stakhov <vsevolod.stakhov@parity.io >
* Update node/overseer/orchestra/proc-macro/src/impl_builder.rs
Co-authored-by: Vsevolod Stakhov <vsevolod.stakhov@parity.io >
* orchestra everywhere
* leaky data
* Bump scale-info from 2.1.1 to 2.1.2 (#5552 )
Bumps [scale-info](https://github.com/paritytech/scale-info ) from 2.1.1 to 2.1.2.
- [Release notes](https://github.com/paritytech/scale-info/releases )
- [Changelog](https://github.com/paritytech/scale-info/blob/master/CHANGELOG.md )
- [Commits](https://github.com/paritytech/scale-info/compare/v2.1.1...v2.1.2 )
---
updated-dependencies:
- dependency-name: scale-info
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Add missing markdown code block delimiter (#5555 )
* bitfield-signing: remove util::jobs usage (#5523 )
* Switch to pooling copy-on-write instantiation strategy for WASM (companion for Substrate#11232) (#5337 )
* Switch to pooling copy-on-write instantiation strategy for WASM
* Fix compilation of `polkadot-test-service`
* Update comments
* Move `max_memory_size` to `Semantics`
* Rename `WasmInstantiationStrategy` to `WasmtimeInstantiationStrategy`
* Update a safety comment
* update lockfile for {"substrate"}
Co-authored-by: parity-processbot <>
* Fix build
Co-authored-by: Vsevolod Stakhov <vsevolod.stakhov@parity.io >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Malte Kliemann <mail@maltekliemann.com >
Co-authored-by: Chris Sosnin <48099298+slumber@users.noreply.github.com >
Co-authored-by: Koute <koute@users.noreply.github.com >
2022-05-19 13:42:02 +01:00
d9eff4ecd4
Switch to pooling copy-on-write instantiation strategy for WASM (companion for Substrate#11232) ( #5337 )
...
* Switch to pooling copy-on-write instantiation strategy for WASM
* Fix compilation of `polkadot-test-service`
* Update comments
* Move `max_memory_size` to `Semantics`
* Rename `WasmInstantiationStrategy` to `WasmtimeInstantiationStrategy`
* Update a safety comment
* update lockfile for {"substrate"}
Co-authored-by: parity-processbot <>
2022-05-19 13:06:34 +02:00
f1006f5a43
bitfield-signing: remove util::jobs usage ( #5523 )
2022-05-19 13:01:22 +02:00
0ce850f959
runtime-api: remove internal queue to make ToFs relevant again (#5545 )
...
* Make back pressure great again
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Test commit - parallel vs caching
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Increase concurrency
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Fixups
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* fix comment
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* update todo issue
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* another doc change
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* More comments
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
2022-05-18 12:56:03 +00:00
3b685fbf91
version bumps (0.9.22) ( #5495 )
...
* bump versions to 0.9.22
* bump spec_version to 9220
2022-05-16 13:24:24 +02:00
511891dcce
refactor+feat: allow subsystems to send only declared messages, generate graphviz ( #5314 )
...
Closes #3774
Closes #3826
2022-05-12 17:39:05 +02:00
26340b9054
more ParaId::from uses ( #5514 )
2022-05-12 16:46:19 +02:00
d437a33e0b
polkadot-node-subsystem package rename mish mash cleanup ( #5502 )
...
* unify to polkadot-node-subsystem{,-test-helpers}
* chore: fmt
2022-05-11 15:32:38 +00:00
8837dc7e6f
Revert approval voting ( #5438 )
...
* Revert approval-voting subsystem
* Approval voting revert encapsulated within 'ops' module
* use 'get_stored_blocks' to get lower block height
* Fix error message
* Optionally shrink/delete stored blocks range
* range end number is last block number plus 1
* Apply code review suggestions
* Use tristate enum for block range in backend overlay
* Add clarification comment
* Add comments to private struct
2022-05-11 10:28:16 +02:00
e29d8e91da
Improve dispute-coordinator message burstiness handling ( #5471 )
...
* Increase message channel size to 2048
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Use unbounded channel for reading data
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
2022-05-09 10:00:05 +00:00
992705d127
Bump log from 0.4.16 to 0.4.17
...
Bumps [log](https://github.com/rust-lang/log ) from 0.4.16 to 0.4.17.
- [Release notes](https://github.com/rust-lang/log/releases )
- [Changelog](https://github.com/rust-lang/log/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rust-lang/log/commits/0.4.17 )
---
updated-dependencies:
- dependency-name: log
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-05-08 22:32:57 +02:00
35a87e0fa3
Include log target for parachains-inherent. ( #5470 )
2022-05-06 13:20:56 +00:00
20e56a453c
Disputes which are unknown for the Runtime are sent with priority by the Provisioner when preparing inherent data ( #5336 )
...
* Implement MallocSizeOf for DisputeState
* Implementation of `Disputes` Runtime API message
* Modify on-chain dispute import
* Add feature flag for the new functionality
* Update node/core/provisioner/src/onchain_disputes.rs
Co-authored-by: Andrei Sandu <54316454+sandreim@users.noreply.github.com >
* Add target to log messages
* Update node/core/provisioner/src/lib.rs
Co-authored-by: Andronik <write@reusable.software >
* Use `staging-client` feature to enable the client code using the staging runtime api
* Remove TODO comment
* Don't filter out DisputeState
* Fix disputes selection logic
* spelling
* Tests
* Rename `Disputes` message to `StagingDisputes`
* Update node/core/provisioner/src/lib.rs
Co-authored-by: Bernhard Schuster <bernhard@ahoi.io >
* Code review feedback
- Logging
- Separate error module
- Add additional fields for GetOnchainDisputesErr
- logging and impl MallocSizeOf
- fix impl MallocSizeOf for DisputeState
- fix tests
* Update node/core/provisioner/src/error.rs
Co-authored-by: Andronik <write@reusable.software >
* Update node/core/provisioner/src/lib.rs
Co-authored-by: Andronik <write@reusable.software >
* Update node/core/provisioner/src/lib.rs
Co-authored-by: Andronik <write@reusable.software >
* Apply suggestions from code review
dummy metrics instance
Co-authored-by: Bernhard Schuster <bernhard@ahoi.io >
* Revert "Apply suggestions from code review"
This reverts commit 6dc518cbf77e037ff4760d315938a68c806e662e.
* Code review feedback: #[cfg(test)] for new_dummy() in metrics
* Code review feedback: break the disputes generation logic in separate functions
* Code review feedback - align_eight
Co-authored-by: Andrei Sandu <54316454+sandreim@users.noreply.github.com >
Co-authored-by: Andronik <write@reusable.software >
Co-authored-by: Bernhard Schuster <bernhard@ahoi.io >
2022-05-06 12:58:04 +00:00
bd5db20e7c
Bump thiserror from 1.0.30 to 1.0.31 ( #5439 )
...
Bumps [thiserror](https://github.com/dtolnay/thiserror ) from 1.0.30 to 1.0.31.
- [Release notes](https://github.com/dtolnay/thiserror/releases )
- [Commits](https://github.com/dtolnay/thiserror/compare/1.0.30...1.0.31 )
---
updated-dependencies:
- dependency-name: thiserror
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-05-04 13:53:53 +00:00
69af87a199
more verbose assignment cert errors ( #5433 )
...
* more verbose assignment cert errors
* rename a variant to InvalidAssignmentKey
2022-05-04 14:45:11 +02:00
a641ba1e7a
have av-store bail when recv() fails ( #5418 )
2022-05-01 15:22:23 +00:00
5142bb98bc
break provisioner/candidate-backing cycle ( #5419 )
2022-04-29 14:00:42 +00:00
bbdfc3d9c6
Chain-selection subsystem data revert ( #5350 )
...
* Chain-selection subsystem data revert
* Cargo fmt
* Better code comments
* Remove unwraps
* Document public method
* Remove duplicated 'ChainSelectionSubsystem' impl block
* Fix typos
* Nitpicks
* Revert returns a service Error
* Removed superflous error handling
* Apply suggestions from code review
* Rename tree 'revert' to 'revert_to'
Co-authored-by: Sebastian Kunert <skunert49@gmail.com >
2022-04-28 17:44:14 +02:00
9c1a3bd18b
backing: refactor off of jobs system ( #5377 )
...
* backing: refactor off of jobs system
* rename FailedToSpawnBg
* refactor: backing uses fatality
* fix service compilation
2022-04-27 22:19:45 +00:00
033950ca36
metrics separation ( #5391 )
...
* split metrics from collation generation
* move metrics to separate file out of backing
* split bitfield signing metrics
* split candidate validation metrics
* split chain api metrics
* split metrics from runtime API
* util is not used in backed metrics mod
* fmt
* missing types
* sure
2022-04-25 17:17:29 +00:00
79ecc53801
Reduce network bandwidth, improve parablock times: optimize approval-distribution ( #5164 )
...
* gossip-support: be explicit about dimensions
* some guide updates
* update network-bridge to distinguish x and y dimensions
* get everything to compile
* beginnings
* some TODOs
* polkadot runtime: use relevant_authorities
* make gossip topologies per-session
* better formatting
* gossip support: use current session validators
* expand in comment
* adjust tests and fix index bug
* add past/present/future connection test and clean up code
* fmt
* network bridge: updated types
* update protocols to new gossip topology message
* guide updates
* add session to BlockApprovalMeta
* add session to block info
* refactor knowledge and remove most unify logic
* start replacing gossip_peers with new SessionTopologies
* add routing information to message state
* add some utilities to SessionTopology
* implement new gossip topology logic
* re-implement unify_with_peer
* distribute assignments according to topology
* finish grid topology implementation
* refactor network bridge slightly
* issue connection requests on all past/present/future
* fmt
* address grumbles
* tighten invariants in unify_with_peer
* implement random propagation
* refactor: extract required routing adjustment logic
* some block-age logic
* aggressively propagate messages when finality is slow
* overhaul aggression system to have 3 levels
* add aggression metrics
* remove aggression L3
* reduce random circulation
* remove PeerData
* get approval tests compiling
* use btree_map in known_by to make deterministic
* Revert "use btree_map in known_by to make deterministic"
This reverts commit 330d65343a7bb6fe4dd0f24bd8dbc15c0cbdbd9d.
* test XY grid propagation
* remove stray println
* test unshared dimension propagation
* add random gossip check
* test unify_with_peer better
* test sending after getting gossip topology
* test L1 aggression on originator
* test L1 aggression for non-originators
* test non-originator aggression L2
* fnt
* ~spellcheck
* fix statement-distribution tests
* fix flaky test
* fix metrics typo
* re-send periodically
* test resending
* typo
Co-authored-by: Bernhard Schuster <bernhard@ahoi.io >
* add more metrics about apd messages
* add back unify_with_peer logs
* make Resend an enum
* be more explicit when resending
* fmt
* fix error
* add a TODO for refactoring
* remove debug metrics
* add some guide stuff
* fmt
* update runtime API in test-runtim
Co-authored-by: Bernhard Schuster <bernhard@ahoi.io >
2022-04-19 20:26:55 +02:00
edfa24bbc5
flatten dispute-coordinator 'real' module. ( #5254 )
...
* flatton dispute-coordinator 'real' module,
* Drop obsolete modules.
Co-authored-by: Robert Klotzner <robert.klotzner@gmx.at >
2022-04-19 18:14:50 +00:00
f820db494f
dispute-coordinator: Cleanup + Bug fixes ( #5323 )
...
* Make import confirmation oneshot optional.
* Cleanup for further improvements.
* Queue adoptions.
* Fix fieldname
* Use correct relay parent
* Fix scraper tests.
* Small optimization.
* Fix all tests.
* Fix other tests.
* fmt
* spelling
* Fix warning.
2022-04-19 14:51:02 +02:00
cddd5749d3
Malus: improvements in dispute ancestor and suggest garbage candidate implementation ( #5011 )
...
* Implement fake validation results
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* refactor
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* cargo lock
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* spell check
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* spellcheck
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* typos
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Review feedback
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* move stuff around
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* chores
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Impl valid - still wip
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* fixes
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* fmt
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Pull Ladi's implementation:
https://github.com/paritytech/polkadot/pull/4711
Co-authored-by: Lldenaurois <Ljdenaurois@gmail.com >
Co-authored-by: Andrei Sandu <andrei-mihail@parity.io >
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Fix build
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Logs and comments
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* WIP: suggest garbage candidate + implement validation result caching
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* fix
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Do commitment hash checks in candidate validation
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Minor refactor in approval, backing, dispute-coord
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Working version of suggest garbage candidate
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Dedup
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* cleanup #1
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Fix tests
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* remove debug leftovers
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* fmt
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Accidentally commited some local test
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* spellcheck
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* some more fixes
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Refactor and fix it
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* review feedback
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* typo
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* tests review feedback
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* refactor disputer
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* fix tests
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Fix zombienet disputes test
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* spellcheck
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* fix
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Fix ui tests
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* fix typo
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
Co-authored-by: Lldenaurois <Ljdenaurois@gmail.com >
2022-04-13 13:45:39 +00:00
fd020c07e5
Add staging runtime api ( #5048 )
...
* Move `trait ParachainHost` to a separate version independent module
`trait ParachainHost` is no longer part of a specific primitives
version. Instead there is a single trait for stable and staging api
versions. The trait contains stable AND staging methods. The latter are
explicitly marked as unstable.
* Fix `use` primitives
`polkadot_primitives::v2` becomes `polkadot_primitives::runtime_api`
* Staging API declaration and stubs
Introduces the concept for 'staging functions' in runtime API. These
functions are still in testing and they are meant to be used only
within test networks (Westend).
They coexist with the stable calls for technical reasons - maintaining
different runtime APIs for different networks is hard to implement.
Check the doc comments in source files for more details how the staging
API should be used.
* Add new staging method - get_session_disputes()
Add `staging_get_session_disputes` to `ParachainHost` as the first
method of the staging API.
* Hide vstaging runtime api implementations behind feature flag
* Fix test runtime
* fn staging_get_session_disputes() is renamed to fn staging_get_disputes()
2022-04-12 15:47:46 +00:00
b89dc00ec0
Fixes the dead lock when any of the channels get at capacity. ( #5297 )
...
The PVF host is designed to avoid spawning tasks to minimize knowledge
of outer code. Using `async_std::task::spawn` (or Tokio's counterpart)
deemed unacceptable, `SpawnNamed` undesirable. Instead there is only one
task returned that is spawned by the candidate-validation subsystem.
The tasks from the sub-components are polled by that root task.
However, the way the tasks are bundled was incorrect. There was a giant
select that was polling those tasks. Particularly, that implies that as soon as
one of the arms of that select goes into await those sub-tasks stop
getting polled. This is a recipe for a deadlock which indeed happened
here.
Specifically, the deadlock happened during sending messages to the
execute queue by calling
[`send_execute`](https://github.com/paritytech/polkadot/blob/a68d9be35656dcd96e378fd9dd3d613af754d48a/node/core/pvf/src/host.rs#L601 ).
When the channel to the queue reaches the capacity, the control flow is
suspended until the queue handles those messages. Since this code is
essentially reached from [one of the select
arms](https://github.com/paritytech/polkadot/blob/a68d9be35656dcd96e378fd9dd3d613af754d48a/node/core/pvf/src/host.rs#L371 ),
the queue won't be given the control and thus no further progress can be
made.
This problem is solved by bundling the tasks one level higher instead,
by `selecting` over those long-running tasks.
We also stop treating returning from those long-running tasks as error
conditions, since that can happen during legit shutdown.
2022-04-09 10:57:34 +00:00
7ed275bff8
bump version to 0.9.19 ( #5290 )
2022-04-08 11:48:43 +00:00
243c855f03
Session is actually ancient not unknown. ( #5286 )
2022-04-08 13:04:59 +02:00
ef4e64c641
Improve error handling in approval voting block import ( #5283 )
...
* Print out original the runtime API error
* Improved error handling in approval voting block import
* Fix test
* Update comment
2022-04-08 10:26:38 +02:00
cccf59d742
Bump lru from 0.7.4 to 0.7.5 ( #5251 )
...
Bumps [lru](https://github.com/jeromefroe/lru-rs ) from 0.7.4 to 0.7.5.
- [Release notes](https://github.com/jeromefroe/lru-rs/releases )
- [Changelog](https://github.com/jeromefroe/lru-rs/blob/master/CHANGELOG.md )
- [Commits](https://github.com/jeromefroe/lru-rs/compare/0.7.4...0.7.5 )
---
updated-dependencies:
- dependency-name: lru
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-07 14:22:25 +02:00
f04e6065dd
Bump lru from 0.7.3 to 0.7.4 ( #5244 )
...
Bumps [lru](https://github.com/jeromefroe/lru-rs ) from 0.7.3 to 0.7.4.
- [Release notes](https://github.com/jeromefroe/lru-rs/releases )
- [Changelog](https://github.com/jeromefroe/lru-rs/blob/master/CHANGELOG.md )
- [Commits](https://github.com/jeromefroe/lru-rs/compare/0.7.3...0.7.4 )
---
updated-dependencies:
- dependency-name: lru
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-04 13:55:11 +02:00
74078d8eb9
Comanion for substrate#11136 ( #5218 )
...
* Comanion for substrate#11136
Signed-off-by: koushiro <koushiro.cqx@gmail.com >
* revert changes in bridge
Signed-off-by: koushiro <koushiro.cqx@gmail.com >
2022-04-04 11:13:34 +02:00
c8cdf9fc03
Integrate benchmark-overhead command ( #5137 )
...
* Integrate benchmark-overhead command
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Beauty fix test
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Spellcheck on
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Remove constants:: module
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update block+extrinsic weights
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Revert "Update block+extrinsic weights"
This reverts commit d77bf977f6bca0b1ded35daa2fd54b97e18a67db.
* Revert "Remove constants:: module"
This reverts commit 2d3bcd0212c438f6b96755900a01762592d90265.
* Review fixes
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Review fixes
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Review fixes
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Review fixes
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* CI
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: parity-processbot <>
2022-04-01 10:34:40 +00:00
52912ab392
fix approval-voting force-approve ( #5229 )
2022-03-31 21:12:38 +00:00
d9f454f903
Bump log from 0.4.14 to 0.4.16 ( #5187 )
...
Bumps [log](https://github.com/rust-lang/log ) from 0.4.14 to 0.4.16.
- [Release notes](https://github.com/rust-lang/log/releases )
- [Changelog](https://github.com/rust-lang/log/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rust-lang/log/commits )
---
updated-dependencies:
- dependency-name: log
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-03-30 13:23:27 +02:00
Chevdor