Pierre Krieger
07b984b609
Add a test for lots of nodes connecting at the same time ( #6247 )
...
* Add a test for lots of nodes connecting at the same time
* Do small change
2020-06-09 16:30:34 +02:00
Cecile Tonglet
8034285da4
Allow adding a prefix to the informant ( #6174 )
...
* Initial commit
Forked at: 1d93746b64
Parent branch: origin/master
* Add a Service Configuration's field + adapt informant + provide means to CLI
* CLEANUP
Forked at: 1d93746b64
Parent branch: origin/master
* fix tests
* fixed bad path to object
* Change OutputFormat enum to struct
* Add informant_prefix to builder and service
* Revert "Change OutputFormat enum to struct"
This reverts commit cd86c583c92668426c35cc174401155bf2880c1f.
* Revert "fix tests"
This reverts commit a3c306ebe94720f350c5bc74b9c5fcde2565d340.
* Revert "Add a Service Configuration's field + adapt informant + provide means to CLI"
This reverts commit 9c2e7267423305705916c30d605893524113c8e3.
* Implementation using the ServiceBuilder
* reduce line length
* fix line width again
* WIP
Forked at: 1d93746b64
Parent branch: origin/master
* WIP
Forked at: 1d93746b64
Parent branch: origin/master
* WIP
Forked at: 1d93746b64
Parent branch: origin/master
* use struct instead of enum
* WIP
Forked at: 1d93746b64
Parent branch: origin/master
* Update client/service/src/lib.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* improve doc
* Update client/service/src/builder.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/service/src/builder.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* change code
* Update client/informant/src/lib.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* enable_color
* reorg log
* remove macro
* Removed builder for informant prefix
* fix doc
* Update client/informant/src/lib.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/informant/src/lib.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/informant/src/lib.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/informant/src/lib.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/service/src/builder.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/service/src/builder.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/service/src/builder.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
2020-06-09 14:29:01 +02:00
Nikolay Volf
65ba701f50
Fix transaction pool & network issues ( #6288 )
...
* fix & tweaks
* address review
* line width
2020-06-08 23:58:08 +02:00
Pierre Krieger
34b7cc8a7a
Sentry nodes and validator nodes also imply reserved ( #6251 )
2020-06-04 23:57:02 +02:00
Arkadiy Paronyan
31921c4eb9
Use number of downloaded blocks for test ( #6234 )
2020-06-04 23:41:48 +02:00
Pierre Krieger
3fef099893
Fix service tests not calling update_chain ( #6232 )
2020-06-04 12:06:44 +00:00
Pierre Krieger
7a969aa401
Remove ReportHandle ( #6213 )
2020-06-02 17:16:53 +02:00
Pierre Krieger
cf185302fa
Improve the log messages printed when a listener closes ( #6162 )
...
* Improve the log messages printed when a listener closes
* Oops, didn't finish the expired listen addrs thing
2020-05-27 19:55:54 +02:00
Pierre Krieger
e2e44f005c
Add a warning when the user passes a legacy PeerId ( #6158 )
...
* Add a warning when the user passes a legacy PeerId
* Update client/network/src/config.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
2020-05-27 19:55:13 +02:00
Pierre Krieger
9906a2e39d
Don't iterate over peers in generic_proto::behaviour::poll ( #6142 )
...
* Don't iterate over peers in generic_proto::behaviour::poll
* Improve comment
* Rework to use DelayIds
2020-05-26 21:23:32 +02:00
Pierre Krieger
c6e23b615f
Add a note about the deprecation of register_notifications_protocol ( #6111 )
2020-05-22 12:43:55 +02:00
Arkadiy Paronyan
5bf9e63181
Optimize network poll ( #6099 )
2020-05-21 13:54:50 +02:00
Pierre Krieger
c8339f9694
Turn a SmallVec into VecDeque for performances ( #6091 )
...
* Turn a SmallVec into VecDeque for performances
* Fix the other SmallVecs
2020-05-20 21:12:49 +02:00
Pierre Krieger
717fa95bc7
Restore the empty line after the license ( #6088 )
2020-05-20 13:08:27 +00:00
Arkadiy Paronyan
f275c6ab0b
Detect obsolete block responses ( #6077 )
2020-05-19 17:06:52 +02:00
Pierre Krieger
8b9bd9018e
Upgrade to libp2p v0.19 - Changes the default PeerId representation ( #6064 )
...
* Upgrade to libp2p v0.19
* Listen on IPv6 by default
* Increase channels sizes
* Use spec-compliant noise protocol
* Show legacy PeerId
* Switch order of Noise protocols
* Switch to crates.io version
* Fix subkey's version
* Fix line width and Wasm build
* I think Wasm is fixed for real this time
2020-05-18 19:57:08 +02:00
Pierre Krieger
7536de97b1
Print an error if we discover our own network identity ( #6047 )
...
* Add an error if we discover our own network identity
* Fix tests
2020-05-18 18:42:44 +02:00
Nikolay Volf
d5411969ac
fix whitespace ( #6062 )
2020-05-18 13:51:28 +02:00
Arkadiy Paronyan
cdb7808a0e
Remove on_block_imported ( #6039 )
...
* remove on_block_imported
* Update client/network/src/service.rs
Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com >
Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com >
2020-05-16 12:59:34 +02:00
Benjamin Kampmann
efc4849f1a
Meter block import results via prometheus ( #6025 )
2020-05-15 17:25:51 +02:00
Pierre Krieger
6ecdf20a1f
Fix lots of small nits in sc-network ( #6028 )
...
* Fix lots of small nits in sc-network
* Update client/network/src/protocol/sync/blocks.rs
Co-authored-by: Arkadiy Paronyan <arkady.paronyan@gmail.com >
* Fix warning
* Yes. The line width.
Co-authored-by: Arkadiy Paronyan <arkady.paronyan@gmail.com >
2020-05-15 12:58:52 +01:00
Benjamin Kampmann
be8c96adec
Relax substrate licensing scheme ( #5947 )
2020-05-15 13:21:56 +02:00
Pierre Krieger
074d80f519
Fix potential state mismatch in behaviour.rs ( #6013 )
...
* Fix state mismatch in behaviour.rs
* Add TODO
2020-05-13 19:50:01 +02:00
Pierre Krieger
10492c0689
Add mitigation for the state inconsistency issue ( #5996 )
...
* Add mitigation for the state inconsistency issue
* Add logging
2020-05-13 14:54:59 +02:00
Pierre Krieger
0a11c48aa1
Turn an error! into a debug! ( #6000 )
2020-05-12 19:22:41 +02:00
Max Inden
1ede6d1e36
client/network: Remove default Kademlia DHT in favor of per protocol DHT ( #5993 )
...
Substrate was previously running both a chain specific Kademlia DHT as
well as the `/ipfs/kad/1.0.0` Kademlia DHT for backwards compatibility.
(See 4db45a8 for details.)
With the end of the transition period this commit removes the former
only leaving the latter and thus preventing the discovery of
incompatible nodes via Kademlia.
2020-05-12 19:07:36 +02:00
Pierre Krieger
b4b1293c78
Restore the reputation penalty for timeouts ( #5984 )
2020-05-12 17:08:05 +02:00
Pierre Krieger
e5a36c8fa9
Small fix to block response completion reporting ( #5967 )
...
* Small fix to block response completion reporting
* while -> if
2020-05-11 17:39:39 +02:00
Pierre Krieger
ed6c5bb190
Properly log when we discard a sync response ( #5969 )
2020-05-11 14:31:56 +02:00
Nikolay Volf
679c91e18c
Refactor network transactions handling ( #5939 )
...
* change propagation
* add bound
2020-05-11 10:36:00 +02:00
Pierre Krieger
a8fac92396
Disconnect node after sync request cancelled ( #5945 )
2020-05-07 15:07:52 +02:00
Nikolay Volf
ffb2d09aa1
change to vecdeque ( #5937 )
2020-05-07 12:50:07 +02:00
Arkadiy Paronyan
8606b886aa
Validate block bodies when syncing ( #5894 )
2020-05-05 16:21:12 +02:00
Bastian Köcher
9c5536e01a
Expose that BasicQueue expects blocking spawn ( #5860 )
...
* Expose that `BasicQueue` expects blocking spawn
Up to now `BasicQueue` expected a closure that to spawn a `Future`.
This was expected to be a closure that spawns a blocking future.
However, this wasn't documented anywhere. This pr introduces a new trait
`SpawnBlocking` that exposes this requirement to the outside.
* Feedback
2020-05-04 19:40:29 +02:00
Bastian Köcher
3d188ef17d
Fix sync logging ( #5879 )
2020-05-04 13:43:08 +02:00
Pierre Krieger
2d9e6dc18e
Include the network overhead in the request-in-time metric ( #5854 )
2020-04-30 17:38:28 +00:00
Pierre Krieger
929bd07bef
Move around stuff in sc_network ( #5847 )
2020-04-30 13:08:38 +00:00
Nikolay Volf
c09bb1f350
Use mem::take instead of mem::replace where appropriate ( #5846 )
...
* replace replace with take
* Update client/api/src/cht.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/api/src/cht.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
2020-04-30 12:53:36 +00:00
Arkadiy Paronyan
fdde90077b
Optimize collecting pending block requests ( #5829 )
...
* Optimized collecting pending block requests
* Make sure request iterator is consumed
2020-04-30 09:50:08 +02:00
pscott
0f401e4699
Move spawning tasks from thread pools to Service's TaskManager for block importing ( #5647 )
...
Co-Authored-By: Pierre Krieger <pierre.krieger1708@gmail.com >
2020-04-29 18:46:39 +02:00
Arkadiy Paronyan
ba50664fea
Reputation penalty for sending empty block response ( #5814 )
2020-04-29 10:12:23 +02:00
Pierre Krieger
1be634da85
Add metrics about block requests ( #5811 )
...
* Add metrics about block requests
* Apply suggestions from code review
Co-Authored-By: Max Inden <mail@max-inden.de >
Co-authored-by: Gavin Wood <i@gavwood.com >
Co-authored-by: Max Inden <mail@max-inden.de >
2020-04-28 17:47:40 +02:00
Seun Lanlege
4fa5941f44
Move sc-client into sc-service ( #5502 )
...
* Drop client from sc-network and sc-client-db, move LongestChain to sc-client-api
* move leaves, cht, in_mem to sc-client-api, drop client from sc-finality-grandpa
* drop sc-service from sc-rpc
* drop sc-service from sc-consensus-aura
* drop sc-client from manual-seal and babe
* drop sc-client from utils/frame/rpc/system and utils/frame/benchmarking-cli
* drop sc-client from bin/node and bin/node-template
* drop sc-client
* fix tests
* remove check -p sc-client from gitlab.yml
* fix warnings
* fixes ui test
* fix light client tests
* adds associated Client type to AbstractService
* adds UsageProvider to Client
* fixed ui test, again
* tried and failed to get node-cli to compile for wasm
* thanks to tomaka for helping me get node-cli to compile for wasmm
* ui test pls pas 🙏🏾
* all tests passing 🪄
* no_run documentation code
* rm -f documentation code
* ClientProvider
* fix mega trait
* move LongestChain to sc-consensus, use adds minimal bounds to AbstractService::Client
* adds license to sc-consensus
Co-authored-by: Benjamin Kampmann <ben@parity.io >
2020-04-28 11:59:31 +00:00
Pierre Krieger
636ddd95d2
Extra timeout handling in block_requests ( #5794 )
2020-04-27 12:17:26 +02:00
Pierre Krieger
6a7e86e677
Use new block requests protocol ( #5760 )
...
* Use new block requests protocol
* Tweak comment
2020-04-24 13:48:22 +02:00
Chevdor
e731817e24
Fix error message when providing an incorrect peer-id ( #5724 )
...
* Fix error message when providing an incorrect peer-id
* Fix error message to cover all cases
Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com >
2020-04-23 22:20:24 +02:00
Toralf Wittner
421ef498f4
network: Only insert global addresses into the DHT. ( #5735 )
...
* network: Only insert global addresses into the DHT.
Currently every address reported via libp2p-identify is inserted into
the DHT which thus contains a multitude of unreachable addresses such
as from 127.0.0.0/8 or 10.0.0.0/8.
Issue #5099 suggested a dedicated service over UDP to gauge the
reachability of an address, which would however incur extra I/O costs
and be of limited use.
As an alternative and simpler tactic, this PR only allows global IP
addresses to be inserted into the DHT unless an explicit command-line
flag `--allow-non-global-addresses-in-dht` is given or a node is
started with `--dev`. This opt-in behaviour is meant to allow
site-local networks to still make use of a DHT.
* Enable non-global in more test setups.
* Replace command-line option with different name.
* Another test fix.
2020-04-23 09:52:20 +02:00
Pierre Krieger
a7f578d63a
Add a protocol that answers finality proofs ( #5718 )
...
* Add a protocol that answers finality proofs
* Fix documentation
* Use Toggle
2020-04-22 10:58:26 +02:00
Pierre Krieger
3ad9f65f11
Send a status message on block announce handshake ( #5726 )
...
* Send a status message on block announce handshake
* Make sure to send the handshake to all handlers
2020-04-22 10:20:52 +02:00
Pierre Krieger
25c3ab2c1e
Fix warning reported in out_events when Registry is None ( #5716 )
2020-04-22 00:36:12 +02:00