Svyatoslav Nikolsky
b03c584e31
Add millau specific messages weights ( #2097 )
...
* refactor weights a bit
* post cherry-pick fixes
* do not run spellcheck on new weight files
* fix
2024-04-10 10:28:37 +02:00
dependabot[bot]
cffc8e3a7b
Bump scale-info from 2.5.0 to 2.6.0
...
Bumps [scale-info](https://github.com/paritytech/scale-info ) from 2.5.0 to 2.6.0.
- [Release notes](https://github.com/paritytech/scale-info/releases )
- [Changelog](https://github.com/paritytech/scale-info/blob/master/CHANGELOG.md )
- [Commits](https://github.com/paritytech/scale-info/commits )
---
updated-dependencies:
- dependency-name: scale-info
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
c17f625770
Add more logs to relayer and message pallets ( #2082 )
...
* add more logs
* unused import
* fmt
2024-04-10 10:28:37 +02:00
bear
b495f8b28d
Update comment ( #2081 )
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
1f738f1389
Benchmarks for new relayers pallet calls ( #2040 )
...
* slash relayer balance for invalid transactions
* require some gap before unstake is possible
* more clippy
* log priority boost
* add issue ref to TODO
* fix typo
* is_message_delivery_call -> is_receive_messages_proof_call
* moved is_receive_messages_proof_call above
* only slash relayers for priority transactions
* benchmarks for new relayers pallet calls
* generated weights
* regenerated weights afer master merge
* actually use weights
2024-04-10 10:28:37 +02:00
Branislav Kontur
db53d68e9b
Removed relayer_account: &AccountId from MessageDispatch ( #2080 )
...
* SourceBridgeHubChain/TargetBridgeHubChain replaced with RelayerAccountChain
* Fix
* Removed `relayer_account: &AccountId` from `MessageDispatch`
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
dc61bcdc01
Fixed off-by-one when confirming rewards in messages pallet ( #2075 )
...
* fixed off-by-one when confirming rewards in messages pallet
* Update modules/messages/src/inbound_lane.rs
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
53e1b7e264
Slash relayers for invalid transactions ( #2025 )
...
* slash relayer balance for invalid transactions
* require some gap before unstake is possible
* more clippy
* log priority boost
* add issue ref to TODO
* fix typo
* is_message_delivery_call -> is_receive_messages_proof_call
* moved is_receive_messages_proof_call above
* only slash relayers for priority transactions
* Update primitives/relayers/src/registration.rs
Co-authored-by: Adrian Catangiu <adrian@parity.io >
* Update primitives/relayers/src/registration.rs
Co-authored-by: Adrian Catangiu <adrian@parity.io >
* Update bin/runtime-common/src/refund_relayer_extension.rs
Co-authored-by: Adrian Catangiu <adrian@parity.io >
* Update bin/runtime-common/src/refund_relayer_extension.rs
Co-authored-by: Adrian Catangiu <adrian@parity.io >
* Update bin/runtime-common/src/refund_relayer_extension.rs
Co-authored-by: Adrian Catangiu <adrian@parity.io >
* Update modules/relayers/src/lib.rs
Co-authored-by: Adrian Catangiu <adrian@parity.io >
* Update primitives/relayers/src/registration.rs
Co-authored-by: Adrian Catangiu <adrian@parity.io >
* benificiary -> beneficiary
---------
Co-authored-by: Adrian Catangiu <adrian@parity.io >
2024-04-10 10:28:37 +02:00
Serban Iorga
13ecaf1eca
Small simplifications ( #2050 )
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
512d43fabe
Revert dispatch-results ( #2048 )
...
* Revert "Reintroduce msg dispatch status reporting (#2027 )"
This reverts commit 38bb051e3d778ee2f5e9451f89cf479a71fd68f8.
* post-revert fix
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
bd583d6334
update refs ( #2041 )
2024-04-10 10:28:37 +02:00
Serban Iorga
b8f4086095
Define RangeInclusiveExt ( #2037 )
...
* Define RangeInclusiveExt
* Use RangeInclusiveExt
* Add docs
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
9e48162df2
refund extra weight in receive_messages_delivery_proof call ( #2031 )
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
ceea1a10f7
Reject delivery transactions with at least one obsolete message ( #2021 )
...
* reject delivery transactions with at least one obsolete message
* clippy
* allow empty delivery transactions with rewards confirmations BUT only when there's no room left in the unrewarded relayers vector
* clippy
* allow empty delivery transactions if no message slots in unrewarded relayers vector
2024-04-10 10:28:37 +02:00
Serban Iorga
3b968a2aba
Reintroduce msg dispatch status reporting ( #2027 )
...
* Use an actual Result inside MessageDispatchResult
We need this in order to distinguish between Ok and Err
* Revert #1660
* Fixes + simplifications
* Implement review suggestions
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
f659ebed7a
fail with InsufficientDispatchWeight if dispatch_weight doesn't cover weight of all bundled messages ( #2018 )
2024-04-10 10:28:37 +02:00
dependabot[bot]
1659b4b447
Bump scale-info from 2.4.0 to 2.5.0
...
Bumps [scale-info](https://github.com/paritytech/scale-info ) from 2.4.0 to 2.5.0.
- [Release notes](https://github.com/paritytech/scale-info/releases )
- [Changelog](https://github.com/paritytech/scale-info/blob/master/CHANGELOG.md )
- [Commits](https://github.com/paritytech/scale-info/compare/v2.4.0...v2.5.0 )
---
updated-dependencies:
- dependency-name: scale-info
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
fd3ebdf138
MaxRequests -> MaxFreeMandatoryHeadersPerBlock in pallet-bridge-grandpa ( #1997 )
...
* MaxRequests -> MaxFreeMandatoryHeadersPerBlock in pallet-bridge-grandpa
* fix comment
* fix comment
* fix comment
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
068f6f648b
Run benchmarks for mock runtimes ( #1996 )
...
* run benchmarks for pallet-bridge-grandpa mock runtime
* run benchmarks for pallet-bridge-relayers mock runtime
* run benchmarks for pallet-bridge-parachains mock runtime
* run benchmarks for pallet-bridge-messages mock runtime
* test benchmarks on mockj runtimes from CI
* clippy and spelling
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
88fb2befa0
Rust cargo doc for all features ( #1995 )
...
* run rustfix rustdoc in grandpa pallet benchmarks
* enable rustdoc for all features
* fix rialto parachain runtime compilation
2024-04-10 10:28:37 +02:00
Adrian Catangiu
e55d4dd6e0
bump substrate+polkadot refs and fix builds ( #1989 )
...
* bump refs and fix build
* more fixes
* Fix rialto-parachain node
* Update dependencies for tools/runtime-codegen
* Regenerate rialto-parachain indirect runtime
* Fix register_parachain
* Fix clippy
* Undo clippy allow
---------
Co-authored-by: Serban Iorga <serban@parity.io >
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
830afff353
Added receive_single_message_proof_with_dispatch benchmark ( #1990 )
...
* added receive_single_message_proof_with_dispatch benchmark
* clippy
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
eccbdff851
remove invalid weight, returned by send_message ( #1984 )
2024-04-10 10:28:37 +02:00
dependabot[bot]
8e14f3f9af
Bump finality-grandpa from 0.16.1 to 0.16.2
...
Bumps [finality-grandpa](https://github.com/paritytech/finality-grandpa ) from 0.16.1 to 0.16.2.
- [Release notes](https://github.com/paritytech/finality-grandpa/releases )
- [Commits](https://github.com/paritytech/finality-grandpa/compare/v0.16.1...v0.16.2 )
---
updated-dependencies:
- dependency-name: finality-grandpa
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
74b0eca59c
added UpdatedBestFinalizedHeader event to pallet-bridge-grandpa ( #1967 )
2024-04-10 10:28:37 +02:00
Branislav Kontur
ce89a2edca
Removed deprecated #[pallet::generate_store(pub(super) trait Store)] according to latest Cumulus ( #1964 )
2024-04-10 10:28:37 +02:00
Branislav Kontur
874ab44e00
Bump substrate/polkadot/cumulus ( #1962 )
...
* Bump substrate/polkadot/cumulus
* sp_finality_grandpa - >sp_consensus_grandpa
* sp_beefy -> sp_consensus_beefy
* pallet_randomness_collective_flip -> pallet_insecure_randomness_collective_flip
* fix
* Cumulus parachain stuff
* Cumulus parachain stuff one more
* Millau/Rialto runtimes
* Removed pallet_insecure_randomness_collective_flip
* Millau node
* Removed session historial
* TMP: just try disable all fetches
* Docs in gitlab.yml
2024-04-10 10:28:37 +02:00
Serban Iorga
9b44db0fbe
Some error improvements ( #1956 )
...
* Use `HeaderChainError` in parachains module
* Use MessageProofError instead of 'static str in some places
* Avoid implementing Into<'static str> for some errors
We avoid deriving `Debug` for the structs that we use in the runtime and
we derive `RuntimeDebug` instead in order to avoid bloating th eruntime
with static strs. But implementing `Into<'static str>` does the same. So
in some places it makes sense to replace `Into<'static str>` with `Debug`.
* Move the messages error definition
Move the messages error definition outside of `mod target`
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
3a145e5844
get rid of obsolete weight functions ( #1926 )
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
aa466a485d
Fix benchmarks ( #1919 )
...
* fixed benchmarks broken by rejecting storage proofs with excessive trie nodes and justifications with extra prevotes
* update weights
* fmt
* accidental paste
* revert changes to millau runtime (separate PR)
* revert comment change
2024-04-10 10:28:37 +02:00
Serban Iorga
ba155f990f
Refund messages confirmation tx ( #1904 )
...
* Refund messages confirmation tx
* Fixes
2024-04-10 10:28:37 +02:00
Serban Iorga
f5fee288b9
Relayers pallet: extend payment source id ( #1907 )
...
* Add Chain::ID const
* Relayers pallet: extend payment source id
* Addressed code review comments
* Fix benchmarks
* Fix dashboards
* Renamings
* Fix compilation
2024-04-10 10:28:37 +02:00
Serban Iorga
e7debc4b09
Fix init-bridge ( #1900 )
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
26330d9a25
get rid of ChainWithMessages::WeightInfo, because we can't have exact weights for "external chains" ( #1899 )
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
498a3e83d0
Weight+size limits for bridge GRANDPA pallet calls ( #1882 )
...
* weight+size limits for bridge GRANDPA pallet calls
* continue
* fixed all tests
* some changes to refund computations
* post_dispatch_refunds_relayer_in_all_finality_batch_with_extra_weight
* - dup code
* do not return Pays::No if call is above weight/size limits
* relayer_pays_tx_fee_when_submitting_huge_mandatory_header and relayer_pays_tx_fee_when_submitting_justification_with_long_ancestry_votes
* clippy
* fmt
* clippy
* small change in docs
* fixed GRANDPA-limits constants for Polkadot-like chains
* clippy
* clippy + spelling
* Update primitives/polkadot-core/src/lib.rs
Co-authored-by: Adrian Catangiu <adrian@parity.io >
* Update bin/runtime-common/src/refund_relayer_extension.rs
Co-authored-by: Adrian Catangiu <adrian@parity.io >
* reverted unnecessary change
* GrandpaJustification::max_reasonable_size
---------
Co-authored-by: Adrian Catangiu <adrian@parity.io >
2024-04-10 10:28:37 +02:00
Serban Iorga
623bd85a5e
RefundRelayerForMessagesFromParachain improvements ( #1895 )
...
* RefundRelayerForMessagesFromParachain changes
- some renamings and cosmetics
- removing the GI generic param since we can get it from the parachains
config
- merging (Parachains Instance, Parachain Id) and (Messages Instance,
Messages lane Id) generic params
- removing unnecessay derives
- renaming for the `TransactionFeeCalculation` and defining
`ActualFeeRefund` concrete implementation
- adding support for multiple RefundRelayerForMessagesFromParachain
(by adding a `StaticStrProvider` generic param)
* Revert to using RuntimeDebug
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
1d6e8a9a26
optimize justification before submit ( #1887 )
...
* optimize justification before submit
* fmt
* spelling
* clippy
* fmt again
* aaand compilation
* clippy
2024-04-10 10:28:37 +02:00
Branislav Kontur
6a2ef74707
Make weights::WeightInfo pub ( #1886 )
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
c6c39be967
ChainWithGrandpa in primitives ( #1885 )
...
* ChainWithGrandpa in primitives
* clippy ++ spelling
* fix benchmarks comppilation
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
914213d0af
Fix clippy issues ( #1884 )
...
* fix clippy issues
* fix?
* fix?
* forget about extra_unused_type_parameters lint for now
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
25c17feb23
Reject storage proofs with unused nodes: begin ( #1878 )
...
* reject storage proofs with unused nodes: begin
* fix ignores_parachain_head_if_it_is_missing_from_storage_proof
* message_proof_is_rejected_if_it_has_duplicate_trie_nodes && message_proof_is_rejected_if_it_has_unused_trie_nodes
* proof_with_duplicate_items_is_rejected and proof_with_unused_items_is_rejected
* clippy
* fix benchmarks compilation
* impl From<Error> for &'static str
* fix review comments
* added comment
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
9e30130054
Refund extra proof bytes in message delivery transaction ( #1864 )
...
* refund extra proof bytes in message delivery transaction
* Update modules/messages/src/lib.rs
Co-authored-by: Adrian Catangiu <adrian@parity.io >
* more tests
---------
Co-authored-by: Adrian Catangiu <adrian@parity.io >
2024-04-10 10:28:37 +02:00
Serban Iorga
c9c6d566d0
RefundRelayerForMessagesFromParachain improvements ( #1879 )
...
* RefundRelayerForMessagesFromParachain improvements
* Address code review comments
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
d8764450c9
MaxValues for OutboundLanes map ( #1871 )
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
89bb368e45
More tests for message pallet weights ( #1870 )
...
* more tests for message pallet weights
* move tests to ensure_weights_are_correct
* removed extra tests
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
4982d1c2e5
MaxValues for maps in parachain maps ( #1868 )
...
* MaxValues for maps in parachain maps
* fix compilation
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
bae329c66e
"refund" proof size in GRANDPa pallet ( #1863 )
...
* "refund" proof size in GRANDPa pallet
* clippy
* extra_proof_size_bytes_works
* use saturated_into
* fix review comments
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
e75d872aa7
MaxValues limit for storage maps in the pallet-bridge-grandpa ( #1861 )
...
* MaxValues limit for storage maps in the pallet-bridge-grandpa
* remove use from the future PR
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
a5a3f8065f
fixed TODOs for weights v2 ( #1860 )
2024-04-10 10:28:37 +02:00
Svyatoslav Nikolsky
795a049937
Message delivery transaction is not free!!! ( #1859 )
...
* message delivery transaction is not free!!!
* test pays_fee
2024-04-10 10:28:37 +02:00