Liam Aharon
0b3444c51d
Fix try-runtime follow-chain, try-runtime upgrade tuple tests, cli test utils ( #13794 )
...
* new test for try-runtime tuple stuff
* fix
* remove development comment
* formatting
* remove todo comment
* follow-chain working test
* refactor common cli testing utils
* fix comment
* revert Cargo.lock changes
* update Cargo.lock
* improve doc comment
* fix error typo
* update Cargo.lock
* feature gate try-runtime test
* build_substrate cli test util
* feature gate follow_chain tests
* move fn start_node to test-utils
* improve test pkg name
* use tokio Child and Command
* remove redundant import
* fix ci
* fix ci
* don't leave hanging processes
* improved child process cleanup
* use existing KillChildOnDrop
* remove redundant comment
* Update test-utils/cli/src/lib.rs
Co-authored-by: Koute <koute@users.noreply.github.com >
---------
Co-authored-by: kianenigma <kian@parity.io >
Co-authored-by: Koute <koute@users.noreply.github.com >
2023-04-06 19:49:53 +10:00
Bastian Köcher
495773f96d
Move registration of ReadRuntimeVersionExt to ExecutionExtension ( #13820 )
...
Instead of registering `ReadRuntimeVersionExt` in `sp-state-machine` it is moved to
`ExecutionExtension` which provides the default extensions.
2023-04-05 14:27:26 +02:00
Muharem Ismailov
e524bf0e30
Scheduler pre block limit note ( #13231 )
...
Co-authored-by: parity-processbot <>
2023-04-03 10:59:01 +00:00
PG Herveou
1bd5d2f78d
[Contracts] Overflowing bounded DeletionQueue allows DoS against contract termination ( #13702 )
...
* [Contracts review] Overflowing bounded `DeletionQueue` allows DoS against contract termination
* wip
* wip
* wip
* wip
* wip
* fix doc
* wip
* PR review
* unbreak tests
* fixes
* update budget computation
* PR comment: use BlockWeights::get().max_block
* PR comment: Update queue_trie_for_deletion signature
* PR comment: update deletion budget docstring
* PR comment: impl Default with derive(DefaultNoBound)
* PR comment: Remove DeletedContract
* PR comment Add ring_buffer test
* remove missed comment
* misc comments
* contracts: add sr25519_recover
* Revert "contracts: add sr25519_recover"
This reverts commit d4600e00934b90e5882cf5288f36f98911b51722.
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_contracts
* PR comments update print_schedule
* Update frame/contracts/src/benchmarking/mod.rs
* Update frame/contracts/src/storage.rs
* Update frame/contracts/src/storage.rs
* rm temporary fixes
* fix extra ;
* Update frame/contracts/src/storage.rs
Co-authored-by: juangirini <juangirini@gmail.com >
* Update frame/contracts/src/storage.rs
Co-authored-by: Alexander Theißen <alex.theissen@me.com >
* Update frame/contracts/src/lib.rs
Co-authored-by: Alexander Theißen <alex.theissen@me.com >
* Update frame/contracts/src/lib.rs
Co-authored-by: Alexander Theißen <alex.theissen@me.com >
* Support stable rust for compiling the runtime (#13580 )
* Support stable rust for compiling the runtime
This pull request brings support for compiling the runtime with stable Rust. This requires at least
rust 1.68.0 to work on stable. The code is written in a way that it is backwards compatible and
should automatically work when someone compiles with 1.68.0+ stable.
* We always support nightlies!
* 🤦
* Sort by version
* Review feedback
* Review feedback
* Fix version parsing
* Apply suggestions from code review
Co-authored-by: Koute <koute@users.noreply.github.com >
---------
Co-authored-by: Koute <koute@users.noreply.github.com >
* github PR commit fixes
* Revert "Support stable rust for compiling the runtime (#13580 )"
This reverts commit 0b985aa5ad114a42003519b712d25a6acc40b0ad.
* Restore DeletionQueueMap
* fix namings
* PR comment
* move comments
* Update frame/contracts/src/storage.rs
* Update frame/contracts/src/storage.rs
* fixes
---------
Co-authored-by: command-bot <>
Co-authored-by: juangirini <juangirini@gmail.com >
Co-authored-by: Alexander Theißen <alex.theissen@me.com >
Co-authored-by: Bastian Köcher <git@kchr.de >
Co-authored-by: Koute <koute@users.noreply.github.com >
2023-03-31 11:03:56 +00:00
Roman Useinov
c91b5b5b21
[Fix] Bump tuple element number in frame-support. ( #13760 )
...
That is to avoid hitting the pallet limit that emits a cryptic error. More detail could be found here: https://substrate.stackexchange.com/questions/7212 .
Co-authored-by: parity-processbot <>
2023-03-29 20:30:15 +00:00
Davide Galassi
40e1704e1c
Keystore overhaul (final) ( #13683 )
...
* Introduce keystore specialized sign methods
* Get rid of 'AppKey::UntypedGeneric' associated type.
Untyped generics are accessible using associated types 'Generic' associated type.
I.e. <T as AppKey>::Public::Generic
* Get rid of 'CryptoTypePublicPair'
* Trivial fix
* Small refactory of local keystore implementations
* Remove 'crypto_id' method from 'Public'
* Trivial rename of 'AppKey' to 'AppCrypto'
* Remove unused import
* Improve docs
* Better signature related errors for authority-discovery
* Apply review suggestion
* Apply review suggestions
Co-authored-by: Koute <koute@users.noreply.github.com >
* Authority discoverty signing error revisited
* Signing error revisited for babe and aura as well
* Further cleanup
---------
Co-authored-by: Koute <koute@users.noreply.github.com >
2023-03-24 13:46:02 +00:00
Arkadiy Paronyan
87197b094f
Bump parity-db ( #13656 )
2023-03-21 10:45:40 +01:00
Alexander Theißen
82cb69922f
contracts: Upgrade to wasmi 0.28 ( #13312 )
...
* Upgrade to wasmi 0.28
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_contracts
* Update stale comment
* Renamed variants of `Determinism`
* Compile fix
---------
Co-authored-by: command-bot <>
2023-03-20 23:09:22 +00:00
Davide Galassi
480396fe06
Keystore overhaul (iter 2) ( #13634 )
...
* Remove bloat about remote keystore
* Update docs and remove unused 'KeystoreRef' trait
* Use wherever possible, MemoryKeystore for testing
* Remove unrequired fully qualified method syntax for Keystore
2023-03-20 18:21:26 +00:00
Gavin Wood
5d81f23f8f
Deprecate Currency; introduce holds and freezing into fungible traits ( #12951 )
...
* First reworking of fungibles API
* New API and docs
* More fungible::* API improvements
* New ref-counting logic for old API
* Missing files
* Fixes
* Use the new transfer logic
* Use fungibles for the dispatchables
* Use shelve/restore names
* Locking works with total balance.
* repotting and removal
* Separate Holds from Reserves
* Introduce freezes
* Missing files
* Tests for freezing
* Fix hold+freeze combo
* More tests
* Fee-free dispatchable for upgrading accounts
* Benchmarks and a few fixes
* Another test
* Docs and refactor to avoid blanket impls
* Repot
* Fit out ItemOf fully
* Add events to Balanced traits
* Introduced events into Hold traits
* Fix Assets pallet tests
* Assets benchmarks pass
* Missing files and fixes
* Fixes
* Fixes
* Benchmarks fixes
* Fix balance benchmarks
* Formatting
* Expose fungible sub modules
* Move NIS to fungible API
* Fix broken impl and add test
* Fix tests
* API for `transfer_and_hold`
* Use composite APIs
* Formatting
* Upgraded event
* Fixes
* Fixes
* Fixes
* Fixes
* Repot tests and some fixed
* Fix some bits
* Fix dust tests
* Rename `set_balance`
- `Balances::set_balance` becomes `Balances::force_set_balance`
- `Unbalanced::set_balance` becomes `Unbalances::write_balance`
* becomes
* Move dust handling to fungibles API
* Formatting
* Fixes and more refactoring
* Fixes
* Fixes
* Fixes
* Fixes
* Fixes
* Fixes
* Fixes
* Fixes
* Fixes
* Use reducible_balance for better correctness on fees
* Reducing hold to zero should remove entry.
* Add test
* Docs
* Update frame/support/src/traits/tokens/fungibles/hold.rs
Co-authored-by: Muharem Ismailov <ismailov.m.h@gmail.com >
* Update frame/support/src/traits/tokens/fungibles/regular.rs
Co-authored-by: Muharem Ismailov <ismailov.m.h@gmail.com >
* Update frame/support/src/traits/tokens/fungible/hold.rs
Co-authored-by: Muharem Ismailov <ismailov.m.h@gmail.com >
* Update frame/support/src/traits/tokens/fungible/regular.rs
Co-authored-by: Muharem Ismailov <ismailov.m.h@gmail.com >
* Docs
* Docs
* Docs
* Fix NIS benchmarks
* Doc comment
* Remove post_mutation
* Fix some tests
* Fix some grumbles
* Enumify bool args to fungible(s) functions
* Fix up assets and balances
* Formatting
* Fix contracts
* Fix tests & benchmarks build
* Typify minted boolean arg
* Typify on_hold boolean arg; renames
* Fix numerous tests
* Fix dependency issue
* Privatize dangerous API mutate_account
* Fix contracts (@alext - please check this commit)
* Remove println
* Fix tests for contracts
* Fix broken rename
* Fix broken rename
* Fix broken rename
* Docs
* Update frame/support/src/traits/tokens/fungible/hold.rs
Co-authored-by: Anthony Alaribe <anthonyalaribe@gmail.com >
* remove from_ref_time
* Update frame/executive/src/lib.rs
Co-authored-by: Anthony Alaribe <anthonyalaribe@gmail.com >
* Update frame/executive/src/lib.rs
Co-authored-by: Anthony Alaribe <anthonyalaribe@gmail.com >
* Reenable test
* Update frame/support/src/traits/tokens/fungibles/hold.rs
Co-authored-by: Anthony Alaribe <anthonyalaribe@gmail.com >
* Update frame/support/src/traits/tokens/fungible/hold.rs
Co-authored-by: Anthony Alaribe <anthonyalaribe@gmail.com >
* Update frame/support/src/traits/tokens/fungible/hold.rs
Co-authored-by: Anthony Alaribe <anthonyalaribe@gmail.com >
* Update frame/support/src/traits/tokens/fungible/hold.rs
Co-authored-by: Anthony Alaribe <anthonyalaribe@gmail.com >
* Update frame/support/src/traits/tokens/currency.rs
Co-authored-by: Anthony Alaribe <anthonyalaribe@gmail.com >
* Update frame/lottery/src/tests.rs
Co-authored-by: Anthony Alaribe <anthonyalaribe@gmail.com >
* Update frame/support/src/traits/tokens/fungible/mod.rs
Co-authored-by: Anthony Alaribe <anthonyalaribe@gmail.com >
* Update frame/support/src/traits/tokens/fungible/regular.rs
Co-authored-by: Anthony Alaribe <anthonyalaribe@gmail.com >
* Update frame/support/src/traits/tokens/fungibles/freeze.rs
Co-authored-by: Anthony Alaribe <anthonyalaribe@gmail.com >
* Update frame/support/src/traits/tokens/fungible/regular.rs
Co-authored-by: Anthony Alaribe <anthonyalaribe@gmail.com >
* Update frame/support/src/traits/tokens/fungibles/hold.rs
Co-authored-by: Anthony Alaribe <anthonyalaribe@gmail.com >
* Update frame/support/src/traits/tokens/fungibles/hold.rs
Co-authored-by: Anthony Alaribe <anthonyalaribe@gmail.com >
* Update frame/support/src/traits/tokens/fungibles/hold.rs
Co-authored-by: Anthony Alaribe <anthonyalaribe@gmail.com >
* Rename UnwantedRemoval to UnwantedAccountRemoval
* Docs
* Formatting
* Update frame/balances/src/lib.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update primitives/runtime/src/lib.rs
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
* handle_raw_dust oes nothing
* Formatting
* Fixes
* Grumble
* Fixes
* Add test
* Add test
* Tests for reducible_balance
* Fixes
* Fix Salary
* Fixes
* Disable broken test
* Disable nicely
* Fixes
* Fixes
* Fixes
* Rename some events
* Fix nomination pools breakage
* Add compatibility stub for transfer tx
* Reinstate a safely compatible version of Balances set_balance
* Fixes
* Grumble
* Update frame/nis/src/lib.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_balances
* disable flakey tests
* Update frame/balances/src/lib.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* Grumbles
* Grumble
---------
Co-authored-by: Muharem Ismailov <ismailov.m.h@gmail.com >
Co-authored-by: Alexander Theißen <alex.theissen@me.com >
Co-authored-by: Anthony Alaribe <anthonyalaribe@gmail.com >
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
Co-authored-by: command-bot <>
2023-03-18 14:47:55 +00:00
PG Herveou
8fcd235e38
contracts: Refactor trait Ext::*_storage_transparent functions ( #13600 )
...
* Refactor _transparent methods
rewrote commits, stashed the typo changes to remove some diff noise
fixed my unverified email commit
* remove type alias
* Get rid of From<Fix/VarSizedKey> impl blocks
* Get rid of KeyType impl block
* remove unnecessary Key export
* Update frame/contracts/src/exec.rs
Co-authored-by: Sasha Gryaznov <hi@agryaznov.com >
* PR review comment
---------
Co-authored-by: Sasha Gryaznov <hi@agryaznov.com >
2023-03-17 23:17:21 +01:00
Davide Galassi
f110941b7f
Keystore overhaul ( #13615 )
...
* Remove 'supported_keys' 'sign_with_any' and 'sign_with_all' from keystore trait
* Remove the aync keystore
* Renaming:
- SyncCryptoStore -> Keystore
- SyncCryptoStorePtr -> KeystorePtr
- KeyStore -> MemoryKeystore
* Fix authority discovery worker and tests
* Rename 'insert_unknown' to 'insert'
* Remove leftover
2023-03-17 11:24:14 +00:00
Bastian Köcher
3e73b7557e
Try to fix flaky temp-base-path-work test ( #13505 )
...
* Try to fix flaky `temp-base-path-work` test
The test is most of the time failing when checking if the database path was deleted. The assumption
is that it takes a little bit more time by the OS to actually clean up the temp path under high
load. The pr tries to fix this by checking multiple times if the path was deleted. Besides that it
also ensures that the tests that require the benchmark feature don't fail when compiled without the feature.
* ".git/.scripts/commands/fmt/fmt.sh"
* Capture signals earlier
* Rewrite tests to let them having one big timeout
* Remove unneeded dep
* Update bin/node/cli/tests/common.rs
Co-authored-by: Koute <koute@users.noreply.github.com >
* Review feedback
* Update bin/node/cli/tests/common.rs
Co-authored-by: Anton <anton.kalyaev@gmail.com >
---------
Co-authored-by: command-bot <>
Co-authored-by: Koute <koute@users.noreply.github.com >
Co-authored-by: Anton <anton.kalyaev@gmail.com >
2023-03-16 12:24:20 +01:00
Francisco Aguirre
33fd17061e
Make Pay trait from salaries pallet more generic ( #13609 )
...
* Make Pay trait from salaries pallet more generic
* Rename and add missing
* Update frame/support/src/traits/tokens/pay.rs
* Update pay.rs
* Update pay.rs
* Update pay.rs
* Add better documentation for the AssetKind associated type
---------
Co-authored-by: Gavin Wood <gavin@parity.io >
Co-authored-by: parity-processbot <>
2023-03-15 21:04:28 +00:00
Alexandru Vasile
1a88833d73
Metadata V15: Expose API to fetch metadata for version ( #13287 )
...
* impl_runtime_apis: Generate getters for `metadata_at` functions
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io >
* runtime: Implement new `Metadata` runtime trait
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io >
* runtime: Move `metadata_at` functions to construct_runtime macro
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io >
* contruct_runtime: Use `OpaqueMetadata` from hidden imports
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io >
* Adjust testing
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io >
* frame/tests: Add tests for the new API
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io >
* frame/tests: Adjust metdata naming
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io >
* frame/support: Expose `metadata-v14` feature flag
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io >
* frame/support: Expose metadata only under feature flags
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io >
* frame/support: Expose v14 metadata by default
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io >
* frame/support: Expose metadata feature for testing
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io >
* frame/support: Test metadata under different feature flags
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io >
* Update primitives/api/src/lib.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* Update primitives/api/src/lib.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* client/tests: Adjust testing to reflect trait Metadata change
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io >
* frame/metadata-ir: Add intermediate representation types for metadata
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io >
* frame/metadata-ir: Convert metadata to V14
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io >
* frame/metadata-ir: Add API to convert metadata to multiple versions
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io >
* frame/metadata-ir: Expose V14 under feature flag
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io >
* frame/support: Adjust to metadata IR
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io >
* frame/support: More adjustments
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io >
* frame/support: Guard v14 details under feature flag
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io >
* frame/support: Adjust testing
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io >
* CI: Ensure `quick-benchmarks` uses `metadata-v14`
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io >
* frame/support: Use `metadata-v14` for benchmarks
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io >
* Adjust cargo fmt
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io >
* kitchensink-runtime: Add feature flag for `metadata-v14`
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io >
* frame/support/test: Adjust testing
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io >
* frame/support/test: Check crates locally
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io >
* Activate metadata-v14 for pallets
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io >
* Remove metadata-v14 feature flag
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io >
* frame/metadata_ir: Move `api.rs` to `mod.rs`
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io >
* frame/support: Handle latest metadata conversion via IR
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io >
* frame/tests: Add constant for metadata version 14
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io >
* frame/support/test: Fix merge conflict
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io >
* Update frame/support/Cargo.toml
Co-authored-by: Bastian Köcher <git@kchr.de >
* Update frame/support/src/metadata_ir/mod.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* Update frame/support/test/Cargo.toml
Co-authored-by: Bastian Köcher <git@kchr.de >
* Update primitives/api/src/lib.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* frame/metadata: Collect pallet documentation for MetadataIR
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io >
* frame/tests: Check pallet documentation is propagated to MetadataIR
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io >
* frame/support: Improve documentation
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io >
---------
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io >
Co-authored-by: parity-processbot <>
Co-authored-by: Bastian Köcher <git@kchr.de >
2023-03-15 17:49:28 +00:00
Niklas Adolfsson
5e3f1b1af5
frame epm: expose feasibility_check in MinerConfig ( #13555 )
...
* frame epm: expose feasibity_check in miner
The goal with this commit is to expose the `feasibity_check` such
that anyone that implements the `MinerConfig trait` can utilize it
* cleanup
* fix tests
2023-03-14 22:53:03 +00:00
cheme
ef165cec3e
update trie deps ( #13601 )
2023-03-14 21:03:50 +00:00
Aaro Altonen
9ced14e2de
Move code from sc-network-common back to sc-network ( #13592 )
...
* Move service tests to `client/network/tests`
These tests depend on `sc-network` and `sc-network-sync` so they should
live outside the crate.
* Move some configs from `sc-network-common` to `sc-network`
* Move `NetworkService` traits to `sc-network`
* Move request-responses to `sc-network`
* Remove more stuff
* Remove rest of configs from `sc-network-common` to `sc-network`
* Remove more stuff
* Fix warnings
* Update client/network/src/request_responses.rs
Co-authored-by: Dmitry Markin <dmitry@markin.tech >
* Fix cargo doc
---------
Co-authored-by: Dmitry Markin <dmitry@markin.tech >
2023-03-14 12:06:40 +00:00
Gavin Wood
4ad1ad2c60
Logic for the (Core) Fellowship ( #13503 )
...
* More drafting
* Paymaster pallet
* Fix build
* More tests
* Rename
* Rename
* Renaming
* Revert old changes
* Multi-phase payouts to avoid bank-runs
* Tests
* Tests
* Allow payment to be targeted elsewhere
* Proper ssync payment failure handling
* Test for repayment
* Docs
* Impl RankedMembers for RankedCollective
* Implement Pay for Pot (i.e. basic account).
* Benchmarks
* Weights
* Introduce Salary benchmark into node
* Fix warning
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_salary
* Update primitives/arithmetic/src/traits.rs
Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com >
* Update frame/salary/src/lib.rs
Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com >
* Update lib.rs
* Update frame/salary/src/lib.rs
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
* Docs
* Update frame/salary/src/lib.rs
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
* Update frame/salary/src/lib.rs
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
* Fix
* Fixes
* Fixes
* Move some salary traits stuff to a shared location
* Initial draft
* Comment out bits
* Fix
* First couple of tests
* One more test
* Update frame/salary/src/lib.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update frame/salary/src/lib.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Mul floor
* Tests
* Mul floor
* Fix warnings
* Fix test
* Tests
* Last tests
* Docs
* Fix warnings
* Benchmarks
* Weights
* Integrate benchmark
* Fixes
* Fix
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_core_fellowship
* Better process flow
* Fix benchmarks & tests
* Docs
* Fixes
* Fixes
* docs
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_core_fellowship
* Docs and allow custom evidence size
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_core_fellowship
* Update frame/core-fellowship/src/lib.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* Update frame/core-fellowship/src/tests.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* Update frame/core-fellowship/src/benchmarking.rs
* Update frame/core-fellowship/src/benchmarking.rs
* Apply suggestions from code review
* Rename
* Update primitives/arithmetic/src/traits.rs
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
* Reduce magic numbers
* Update frame/core-fellowship/src/lib.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update frame/core-fellowship/src/lib.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Benchmark result
* Remove dependency
* set_params should pay
* induct should pay
* Remove some other free calls
---------
Co-authored-by: command-bot <>
Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com >
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
2023-03-11 13:11:15 +01:00
Davide Galassi
9dd10d131d
Offences report system rework ( #13425 )
...
* Experiments with common equivocation trait
* Improved equivocation trait
* Fix grandpa equivocation implementation
* Remove some cruft
* Remove some more cruft
* More generic naming
* Simplification of offences manipilation
* More refactory
* Some prograss with the encapsulation of offence report system
* Finally unit type works as a universal null report system
* Align substrate node code
* Further simplification
* Fix test utils
* Remove not required associated type
* Fix benches
* Rollback to prev field name
* Box big params
* Fix typo
* Remove new tag computation
* Remove default implementations
* Better docs
* Return 'Result' instead of bool
* Change offence report system return types
* Some renaming and documentation
* Improve documentation
* More abstract offence report system
* Rename 'consume_evidence' to 'process_evidence'
* Further docs refinements
* Doc for dummy offence report
* Fix rustdoc
* Fix after master merge
* Apply code review suggestions
* Improve docs
2023-03-07 20:25:55 +00:00
André Silva
13b0f24abd
consensus: remove caching functionality from block import pipeline ( #13551 )
...
* consensus: remove caching functionality from block import pipeline
* client: update docs on Verifier::verify
* node: fix block production benchmark
2023-03-07 11:19:19 +00:00
afm
d86a32630b
Pub enum runtime to pub struct runtime ( #13250 )
...
* pub enum Runtime -> pub struct Runtime
* changing some more
* fmt
* updating *.stderr files
* re-run trybuild after rust update
* keep a test file for `pub enum Runtime`
* Delete construct_runtime_2.rs
* ".git/.scripts/commands/fmt/fmt.sh"
---------
Co-authored-by: Bastian Köcher <git@kchr.de >
Co-authored-by: parity-processbot <>
2023-03-07 12:14:12 +01:00
Aaro Altonen
1a7f5be07f
Extract syncing protocol from sc-network ( #12828 )
...
* Move import queue out of `sc-network`
Add supplementary asynchronous API for the import queue which means
it can be run as an independent task and communicated with through
the `ImportQueueService`.
This commit removes removes block and justification imports from
`sc-network` and provides `ChainSync` with a handle to import queue so
it can import blocks and justifications. Polling of the import queue is
moved complete out of `sc-network` and `sc_consensus::Link` is
implemented for `ChainSyncInterfaceHandled` so the import queue
can still influence the syncing process.
* Move stuff to SyncingEngine
* Move `ChainSync` instanation to `SyncingEngine`
Some of the tests have to be rewritten
* Move peer hashmap to `SyncingEngine`
* Let `SyncingEngine` to implement `ChainSyncInterface`
* Introduce `SyncStatusProvider`
* Move `sync_peer_(connected|disconnected)` to `SyncingEngine`
* Implement `SyncEventStream`
Remove `SyncConnected`/`SyncDisconnected` events from
`NetworkEvenStream` and provide those events through
`ChainSyncInterface` instead.
Modify BEEFY/GRANDPA/transactions protocol and `NetworkGossip` to take
`SyncEventStream` object which they listen to for incoming sync peer
events.
* Introduce `ChainSyncInterface`
This interface provides a set of miscellaneous functions that other
subsystems can use to query, for example, the syncing status.
* Move event stream polling to `SyncingEngine`
Subscribe to `NetworkStreamEvent` and poll the incoming notifications
and substream events from `SyncingEngine`.
The code needs refactoring.
* Make `SyncingEngine` into an asynchronous runner
This commits removes the last hard dependency of syncing from
`sc-network` meaning the protocol now lives completely outside of
`sc-network`, ignoring the hardcoded peerset entry which will be
addressed in the future.
Code needs a lot of refactoring.
* Fix warnings
* Code refactoring
* Use `SyncingService` for BEEFY
* Use `SyncingService` for GRANDPA
* Remove call delegation from `NetworkService`
* Remove `ChainSyncService`
* Remove `ChainSync` service tests
They were written for the sole purpose of verifying that `NetworWorker`
continues to function while the calls are being dispatched to
`ChainSync`.
* Refactor code
* Refactor code
* Update client/finality-grandpa/src/communication/tests.rs
Co-authored-by: Anton <anton.kalyaev@gmail.com >
* Fix warnings
* Apply review comments
* Fix docs
* Fix test
* cargo-fmt
* Update client/network/sync/src/engine.rs
Co-authored-by: Anton <anton.kalyaev@gmail.com >
* Update client/network/sync/src/engine.rs
Co-authored-by: Anton <anton.kalyaev@gmail.com >
* Add missing docs
* Refactor code
---------
Co-authored-by: Anton <anton.kalyaev@gmail.com >
2023-03-06 16:33:38 +00:00
Gavin Wood
e4bf9f2125
Salary pallet ( #13378 )
...
* More drafting
* Paymaster pallet
* Fix build
* More tests
* Rename
* Rename
* Renaming
* Revert old changes
* Multi-phase payouts to avoid bank-runs
* Tests
* Tests
* Allow payment to be targeted elsewhere
* Proper ssync payment failure handling
* Test for repayment
* Docs
* Impl RankedMembers for RankedCollective
* Implement Pay for Pot (i.e. basic account).
* Benchmarks
* Weights
* Introduce Salary benchmark into node
* Fix warning
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_salary
* Update primitives/arithmetic/src/traits.rs
Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com >
* Update frame/salary/src/lib.rs
Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com >
* Update lib.rs
* Update frame/salary/src/lib.rs
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
* Docs
* Update frame/salary/src/lib.rs
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
* Update frame/salary/src/lib.rs
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
* Fix
* Fixes
* Fixes
* Move some salary traits stuff to a shared location
* Fix
* Update frame/salary/src/lib.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update frame/salary/src/lib.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Mul floor
* Fix warnings
* Fix test
* Docs
---------
Co-authored-by: command-bot <>
Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com >
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
2023-03-03 19:05:01 +00:00
Arkadiy Paronyan
ac4a23609c
Bump parity-db ( #13521 )
2023-03-03 17:16:59 +00:00
Oliver Tale-Yazdi
9e56e1acdd
Deprecate Weight::from_{ref_time, proof_size} ( #13475 )
...
* Deprecate Weight::from_{ref_time, proof_size}
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update templates
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Use from_parts
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Use from_parts
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Dont revert comment 🤦
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_balances
* Update weight files
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* More fixes
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Adapt to Master changes
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
---------
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: command-bot <>
2023-03-02 21:28:17 +00:00
Jegor Sidorenko
7981d4aa59
Return account's asset balances ( #13352 )
...
* Runtime method to get user's assets balances
* Fix test (typo)
* Update frame/assets/src/functions.rs
* Remove instance param
* Update frame/assets/src/functions.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* Remove instance param
* Refactor
* Chore
* Update doc
---------
Co-authored-by: Bastian Köcher <git@kchr.de >
Co-authored-by: parity-processbot <>
2023-03-02 13:58:41 +00:00
Michal Kucharczyk
b5e7fbfb58
Service::Error: Storage variant removed ( #13481 )
2023-02-27 23:10:34 +00:00
Davide Galassi
40c36c0c8a
Move grandpa crates to consensus folder ( #13458 )
...
* Move grandpa under consensus dir
* Rename grandpa folder
* Finish grandpa renaming
* Minor tweaks
* Cargo fmt
* Adjust path to chain spec
2023-02-27 17:15:08 +01:00
Oliver Tale-Yazdi
16773d3696
Yieldable queues for pallet MessageQueue ( #13424 )
...
* Add Yield message processing error
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add NoopServiceQueues
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Implement temporary error aka Yield
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Make NoopMessageProcessor generic
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Mock pausable message processor
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Test paused queues
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Integration test paused queues
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Use WeightMeter instead of weight return
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* fix
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Make compile
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add tests
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_message_queue
* Fix test
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
---------
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: command-bot <>
2023-02-25 16:13:20 +00:00
Bastian Köcher
941288c6d0
wasm-executor: Support growing the memory ( #12520 )
...
* As always, start with something :P
* Add support for max_heap_pages
* Add support for wasmtime
* Make it compile
* Fix compilation
* Copy wrongly merged code
* Fix compilation
* Some fixes
* Fix
* Get stuff working
* More work
* More fixes
* ...
* More
* FIXEs
* Switch wasmi to use `RuntimeBlob` like wasmtime
* Removed unused stuff
* Cleanup
* More cleanups
* Introduce `CallContext`
* Fixes
* More fixes
* Add builder for creating the `WasmExecutor`
* Adds some docs
* FMT
* First round of feedback.
* Review feedback round 2
* More fixes
* Fix try-runtime
* Update client/executor/wasmtime/src/instance_wrapper.rs
Co-authored-by: Koute <koute@users.noreply.github.com >
* Update client/executor/common/src/wasm_runtime.rs
Co-authored-by: Koute <koute@users.noreply.github.com >
* Update client/executor/common/src/runtime_blob/runtime_blob.rs
Co-authored-by: Koute <koute@users.noreply.github.com >
* Update client/executor/common/src/wasm_runtime.rs
Co-authored-by: Koute <koute@users.noreply.github.com >
* Update client/allocator/src/freeing_bump.rs
Co-authored-by: Koute <koute@users.noreply.github.com >
* Update client/allocator/src/freeing_bump.rs
Co-authored-by: Koute <koute@users.noreply.github.com >
* Feedback round 3
* FMT
* Review comments
---------
Co-authored-by: Koute <koute@users.noreply.github.com >
2023-02-24 11:43:01 +00:00
Gonçalo Pestana
c848d40775
Revert "Abstracts elections-phragmen pallet to use NposSolver ( #12588 )" ( #13451 )
...
This reverts commit b793666ca5 .
2023-02-23 12:15:08 -06:00
Daniel Shiposha
4af011f418
Nfts attribute read interface ( #13349 )
...
* feat: add custom and system attributes to Inspect
* feat: add nfts runtime api
* fix: pass std feature to runtime api
* fix: api copyright
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
---------
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
2023-02-23 15:06:12 +00:00
Gonçalo Pestana
b793666ca5
Abstracts elections-phragmen pallet to use NposSolver ( #12588 )
...
* Abstracts elections-phragmen pallet to use NposSolver
* Update frame/elections-phragmen/src/lib.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* Update frame/elections-phragmen/src/lib.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* changes the name of the pallet; adds changelog
* update changelog
* Adds weight testing
* Adds log macro_rules
* renames elections-phragment dir to elections
* weights rename
* fixes typo in cargo toml
* pre/post solve weight scafolding
* refactor do_post_election
* refactors into pre and post election solve for independent benchmarking
* deconstructs PreElectionResults struct
* updates benchmarking pre and post election solve; mock weights
* Update frame/elections/src/lib.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* Update frame/elections/src/lib.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* addresses PR comments
* adds pre_solve and post_sove weights
* Adds comments on election pallet id param name change
* ".git/.scripts/bench-bot.sh" pallet dev pallet_elections
* Finishes pre-post solve weights
* Update frame/elections/src/lib.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* Update frame/elections/src/lib.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* Addresses PR comments: no panic in on_init path; nits
* Fixes node build
* Implements approval voting to use as a `NposSolver` (#13367 )
* Implements the approval voting methods in sp_npos_elections
* fmt
* remove unecessary file
* comment clarification
* re-run weights
* fix typo
* updates MaxVoters in tests for integrity_tests to pass
* Refactors election provider support benchmarks outside its own crate (#13431 )
* Refactors election provider support benchmarks outside its own crate
---------
Co-authored-by: command-bot <>
---------
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
Co-authored-by: parity-processbot <>
Co-authored-by: Ross Bulat <ross@parity.io >
2023-02-23 11:21:00 +00:00
Daniel Shiposha
236bbbd5ef
Introduce EnsureOrigin to democracy.propose ( #13410 )
...
* feat: add submitorigin to democracy
* fix: democracy tests
* fix: SubmitOrigin doc comment
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
---------
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
2023-02-21 22:56:07 +00:00
Sergej Sakac
d5beaa5542
Glutton pallet ( #12833 )
...
* Pov-Limit pallet
* use Perbill & fixes
* fixes
* reads & writes
* update docs
* tests
* calculate weight
* fmt
* benchmark
* logic fix
* naming fix
* caclulate computation weight limit
* make the Hasher generic
* make the code compile
* generate weight
* fix on_idle
* fix
* fix
* make reading generic
* fix?
* fixes
* remove warning
* fix
* hasher fix :D
* change value
* test
* actual weight and expected weight are the same
* update
* fix
* add events
* remove useless line
* using actual hashing algorithm
* better readability
* fix nits
* Update
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* add migration
* hardcode proof_size in weights.rs
* format
* fixes
* Fix weight
* docs
* fix
* Update frame/pov-limit/src/lib.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* Update frame/pov-limit/src/lib.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* empty on_ilde & update weight.rs
* remove migration & fix benchmark
* remove migration from migrations
* initialize_pallet
* use blake2
* Update frame/pov-limit/Cargo.toml
Co-authored-by: Bastian Köcher <git@kchr.de >
* Update frame/pov-limit/src/lib.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* Update frame/pov-limit/Cargo.toml
Co-authored-by: Bastian Köcher <git@kchr.de >
* rename pallet
* make the wasters non-generic
* rename to glutton
* fix
* small fixes & run benchmark
* increase left over ref-time in tests
* Update frame/glutton/src/lib.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* or values
* fix
* generate weight
* Update frame/glutton/Cargo.toml
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* fix nits
* Adjustments
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fixes
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* fix
* Update weights
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Tweak constants
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update weights
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* remove genesis config
* passing tests
* More precise results
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* update node-executor test
* Calculate number of iterations in advance
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* increase criteria
* Final fixes
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update frame/glutton/src/tests.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* Update frame/glutton/src/lib.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* Update frame/glutton/src/lib.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* fix typos
* Update frame/glutton/src/lib.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* Update frame/glutton/src/lib.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* expand/shrink
* fmt
* Revert "Update frame/glutton/src/lib.rs"
This reverts commit 98a237afd27de3deb15ba381871e12f71a9d71b1.
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Use CountedStorageMap
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add benchmark
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Use manual map counter
Something with the R/W count in the benchmarking result did not add
up. Need to investigate but for now just using a manual counter.
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Use new template
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Doc+typos
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_glutton
* Apply suggestions from code review
Co-authored-by: Koute <koute@users.noreply.github.com >
* Add minimal README
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_glutton
---------
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: Bastian Köcher <git@kchr.de >
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
Co-authored-by: command-bot <>
Co-authored-by: Koute <koute@users.noreply.github.com >
2023-02-21 22:39:27 +00:00
Vivek Pandya
bc53b9a03a
Remove years from copyright notes. ( #13415 )
...
* Change copyright year to 2023 from 2022
* Fix incorrect update of copyright year
* Remove years from copy right header
* Fix remaining files
* Fix typo in a header and remove update-copyright.sh
2023-02-21 18:46:41 +00:00
Michal Kucharczyk
5ef88dd398
BlockId removal: BlockBuilderProvider::new_block_at (#13401 )
...
* `BlockId` removal: `BlockBuilderProvider::new_block_at`
It changes the arguments of `BlockBuilderProvider::new_block_at` from:
`BlockId<Block>` to: `Block::Hash`
* fmt
* fix
* more fixes
2023-02-21 18:36:00 +00:00
Gonçalo Pestana
2f1ec07953
Staking and nomination pools runtime API improvements ( #13119 )
...
* Adds StakingAPI_nominations_quota and NominationPoolsApi_balanceToPoint and NominationPoolsApi_pointsToBalance runtime APIs
* Adds balance param to api_nominations_quota
* Update frame/nomination-pools/src/lib.rs
Co-authored-by: Anton <anton.kalyaev@gmail.com >
* Update frame/nomination-pools/src/lib.rs
Co-authored-by: Anton <anton.kalyaev@gmail.com >
* Addresses comments - returns zero instead of error in runtime api
* Update frame/staking/runtime-api/src/lib.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* Update frame/staking/runtime-api/src/lib.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* Addresses PR comments
* Update frame/nomination-pools/runtime-api/Cargo.toml
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* Fixes points_to_balance logic; adds tests
* test comment fix
* Update frame/nomination-pools/runtime-api/src/lib.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* Update frame/nomination-pools/runtime-api/src/lib.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* Fix block pruning (#13323 )
* Referendum proposal's metadata (#12568 )
* referenda metadata
* todo comment
* remove TODO, update rustdocs
* referenda clear_metadata origin signed or root
* referenda metadata unit tests
* drop schema type for referenda metadata
* remove metadata type
* referenda metadata benches
* note different preimages
* metadata for democracy pallet
* metadata democracy pallet tests and benches
* fix cargo clippy
* update docs
* ".git/.scripts/bench-bot.sh" pallet dev pallet_democracy
* ".git/.scripts/bench-bot.sh" pallet dev pallet_referenda
* Update the doc frame/democracy/src/lib.rs
Co-authored-by: Roman Useinov <roman.useinov@gmail.com >
* Update the doc frame/democracy/src/lib.rs
Co-authored-by: Anthony Alaribe <anthonyalaribe@gmail.com >
* reference instead clone for take
Co-authored-by: Anthony Alaribe <anthonyalaribe@gmail.com >
* error rename BadMetadata to PreimageNotExist
* clear metadata within internal_cancel_referendum fn
* remove redundant clone
* collapse metadata api into one set_metadata method
* fmt
* review fixes
* not request preimage on set_metadata
* rename events and update docs
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_democracy
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_referenda
* rename reset_metadata to transfer_metadata
---------
Co-authored-by: command-bot <>
Co-authored-by: Roman Useinov <roman.useinov@gmail.com >
Co-authored-by: Anthony Alaribe <anthonyalaribe@gmail.com >
* Improve test coverage of the `Notifications` protocol (#13033 )
* Add handler and upgrade tests
* Add tests for `behaviour.rs`
* Apply review comments
* Update dependencies
* Apply suggestions from code review
Co-authored-by: Dmitry Markin <dmitry@markin.tech >
* Apply review comments
* Fix clippy
* Update mockall
* Apply review comment
---------
Co-authored-by: Dmitry Markin <dmitry@markin.tech >
* refactors runtime API logic to own pallet impl block
* removes unrelated changes
* Fixes cargo doc comments lint
* fixes node cargo
* fixes comment
* restart ci
* restart ci
* restart ci
---------
Co-authored-by: Anton <anton.kalyaev@gmail.com >
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
Co-authored-by: parity-processbot <>
Co-authored-by: Arkadiy Paronyan <arkady.paronyan@gmail.com >
Co-authored-by: Muharem Ismailov <ismailov.m.h@gmail.com >
Co-authored-by: Roman Useinov <roman.useinov@gmail.com >
Co-authored-by: Anthony Alaribe <anthonyalaribe@gmail.com >
Co-authored-by: Aaro Altonen <48052676+altonen@users.noreply.github.com >
Co-authored-by: Dmitry Markin <dmitry@markin.tech >
2023-02-21 11:17:01 +00:00
Michal Kucharczyk
7a10154188
BlockId removal: runtime-api refactor (#13255 )
...
* BlockId removal: refactor of runtime API
It changes the arguments of:
- `ApiExt` methods: `has_api`, `has_api_with`, `api_version`
- `CallApiAt` method: `runtime_version_at`
from: `BlockId<Block>` to: `Block::Hash`
It also changes the first argument of all generated runtime API calls from: `BlockId<Block>` to: `Block::Hash`
This PR is part of BlockId::Number refactoring analysis (paritytech/substrate#11292 )
* BlockId removal: refactor of runtime API - tests
- tests adjusted to new runtime API,
- some tests migrated from block number to block hash
* benchmarking-cli: BlockId(0) migrated to info().genesis_hash
`runtime_api.call()` now requires the block hash instead of BlockId::Number.
To access the genesis hash widely used in benchmarking engine the Client
was constrained to satisfy `sp_blockchain::HeaderBackend<Block>` trait
which provides `info().genesis_hash`.
* trivial: api.call(BlockId) -> api.call(Hash)
- Migrated all `runtime_api.calls` to use Hash
- Noteworthy (?):
-- `validate_transaction_blocking` in transaction pool,
* CallApiAtParams::at changed to Block::Hash
* missed doc updated
* Apply suggestions from code review
Co-authored-by: Bastian Köcher <git@kchr.de >
* ".git/.scripts/commands/fmt/fmt.sh"
* BlockId removal: Benchmark::consumed_weight
Little refactor around `Benchmark::consumed_weight`: `BlockId` removed.
* at_hash renamed
* wrong merge fixed
* beefy worker: merged with master
* beefy: tests: missing block problem fixed
* Apply review suggestion
* fix
---------
Co-authored-by: Bastian Köcher <git@kchr.de >
Co-authored-by: command-bot <>
2023-02-20 22:47:21 +00:00
Piotr Mikołajczyk
3595d87182
try-runtime::fast-forward (#12896 )
...
* try-runtime::fast-forward
* Revert un`pub`ing command's fields
* Handle storage change failure
* Adjust Substrate node
* Feature-gated imports
* doc link
* Feature-gated imports in node-template
* Move trait, blanket implementation and auxiliary functions to a new module
* Distinguish between plain babe+timestamp and substrate enhanced info
* Remove uncles inherents
* Missing argument
* Add doc comment about `blocktime_millis`
* Add licenses
2023-02-17 12:21:58 +00:00
Michal Kucharczyk
36480b158d
BlockId removal: Client::runtime_version_at (#13393 )
...
* BlockId removal: Client::runtime_version_at
It changes the arguments of `Client::runtime_version_at` from: `BlockId<Block>` to: `Block::Hash`
* Apply suggestions from code review
Co-authored-by: Anton <anton.kalyaev@gmail.com >
---------
Co-authored-by: Anton <anton.kalyaev@gmail.com >
Co-authored-by: parity-processbot <>
2023-02-16 22:34:00 +00:00
Sam Elamin
df24729d74
add warp to target block for parachains ( #12761 )
...
* add warp to target block for parachains
* fix for failing tests
* format using `Cargo +nightly fmt`
* Remove blocking based on PR comments and create new `WarpSync` on poll
* remove method from trait
* add tests for wait for target
* Update client/network/common/src/sync/warp.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* Update client/network/common/src/sync/warp.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* Update client/network/test/src/sync.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* Update client/network/test/src/sync.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* Update client/network/test/src/lib.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* Update client/network/test/src/sync.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* Update client/network/test/src/sync.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* code refactor based on pr comments
* Second round of PR comments
* Third round of pr comments
* add comments to explain logic
* Update client/network/sync/src/lib.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* Update client/network/sync/src/lib.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* Update client/network/sync/src/warp.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* Update client/network/sync/src/warp.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* Update client/network/sync/src/warp.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* Update client/network/sync/src/lib.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* code refactor based on last PR comments
* move warp sync polling before `process_outbound_requests`
Add error message if target block fails to be retreived
* Update client/network/sync/src/warp.rs
Co-authored-by: Arkadiy Paronyan <arkady.paronyan@gmail.com >
* Update client/network/sync/src/lib.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* Update client/network/sync/src/warp.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* fmt after code suggestions
* rebase changes
* Bring down the node if the target block fails to return
* Revert "Bring down the node if the target block fails to return"
This reverts commit c0ecb220d66dd8e7b1a5ee29831b776f4f18d024.
* Update client/network/common/src/sync/warp.rs
Co-authored-by: Michal Kucharczyk <1728078+michalkucharczyk@users.noreply.github.com >
* Update client/network/common/src/sync/warp.rs
Co-authored-by: Michal Kucharczyk <1728078+michalkucharczyk@users.noreply.github.com >
* use matching on polling to avoid calling poll more than once
* Update client/network/sync/src/warp.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* Update client/network/sync/src/warp.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* Update client/network/sync/src/warp.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* fix typo on comment
* update snapshot with new folder structure
* Upload snapshot
* Bump zombienet
* bump zombienet again
* Improve test
* Update client/network/test/src/sync.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* Update client/network/test/src/sync.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* fix tests
* dummy commit to restart builds
* Converted the target block to an optional value that is set to `None` when an error occurs
* dummy commit to restart builds
---------
Co-authored-by: Bastian Köcher <git@kchr.de >
Co-authored-by: Arkadiy Paronyan <arkady.paronyan@gmail.com >
Co-authored-by: Michal Kucharczyk <1728078+michalkucharczyk@users.noreply.github.com >
Co-authored-by: Sebastian Kunert <skunert49@gmail.com >
2023-02-14 17:46:51 +00:00
Jegor Sidorenko
3b767e1238
[NFTs] Offchain mint ( #13158 )
...
* Allow to mint with the pre-signed signatures
* Another try
* WIP: test encoder
* Fix the deposits
* Refactoring + tests + benchmarks
* Add sp-core/runtime-benchmarks
* Remove sp-core from dev deps
* Enable full_crypto for benchmarks
* Typo
* Fix
* Update frame/nfts/src/mock.rs
Co-authored-by: Squirrel <gilescope@gmail.com >
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_nfts
* Add docs
* Add attributes into the pre-signed object & track the deposit owner for attributes
* Update docs
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_nfts
* Add the number of attributes provided to weights
* Apply suggestions
* Remove dead code
* Remove Copy
* Fix docs
* Update frame/nfts/src/lib.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update frame/nfts/src/lib.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
---------
Co-authored-by: Squirrel <gilescope@gmail.com >
Co-authored-by: command-bot <>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
2023-02-14 08:19:50 +00:00
girazoki
79cde7b126
SetMembers configurable origin ( #13159 )
...
* SetMembers configurable origin
* root origin comment replaced
* fmt
2023-02-12 10:43:03 +00:00
Kian Paimani
928a12405b
Configurable voting-degree in council elections pallet ( #13305 )
...
* configurable council elections pallet
* configurable council elections pallet
* add warning
* reduce sizes
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_elections_phragmen
* fix stuff
* make assert
* fix docs
* fix docs again
* fix docs again
* Update frame/elections-phragmen/src/lib.rs
Co-authored-by: Gonçalo Pestana <g6pestana@gmail.com >
* Update frame/elections-phragmen/src/lib.rs
Co-authored-by: Gonçalo Pestana <g6pestana@gmail.com >
* Update frame/elections-phragmen/src/lib.rs
Co-authored-by: Gonçalo Pestana <g6pestana@gmail.com >
* fix docs
---------
Co-authored-by: command-bot <>
Co-authored-by: Gonçalo Pestana <g6pestana@gmail.com >
2023-02-08 14:37:36 +00:00
Oliver Tale-Yazdi
fc2fda8d19
Rename pallet-random-collective-flip to Insecure... ( #13301 )
...
* Rename pallet-random-collective-flip to Insecure...
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* fmt
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
---------
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
2023-02-06 18:12:06 +00:00
André Silva
a46203efb6
grandpa: cleanup stale entries in set id session mapping ( #13237 )
...
* grandpa: cleanup stale entries in set id session mapping
* Update frame/grandpa/src/migrations.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* grandpa: remove unused import
* grandpa: migration off-by-one
* Update frame/grandpa/src/lib.rs
Co-authored-by: Anton <anton.kalyaev@gmail.com >
* Update frame/grandpa/src/lib.rs
Co-authored-by: Anton <anton.kalyaev@gmail.com >
* grandpa: MaxSetIdSessionEntries as u64
* node-template: fix MaxSetIdSessionEntries type
---------
Co-authored-by: Bastian Köcher <git@kchr.de >
Co-authored-by: Anton <anton.kalyaev@gmail.com >
2023-01-30 15:25:11 +00:00
Bastian Köcher
e851b3ae73
Remove uncles related code ( #13216 )
...
The code was added without any clear usage. The inherent for example is not benchmarked and not used.
2023-01-29 20:56:10 +00:00
Qinxuan Chen
b77a1a67eb
update criterion to v0.4.0 ( #13142 )
2023-01-28 19:43:32 +00:00