Commit Graph

14282 Commits

Author SHA1 Message Date
joe petrowski dcc8387dfa typo in from_rational rounding example (#11301) 2022-04-26 21:15:00 +02:00
yjh 130880754f chore: remove unused scoped-tls (#11286)
* chore: remove unused scoped-tls

* rm irrelevant files

* rm sp-core
2022-04-26 20:21:30 +02:00
Oliver Tale-Yazdi c5298f6245 Co #11270: Update benchmark machine command (#1214)
* Use polkadot reference hardware for benchmark machine

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Rename POLKADOT_REFERENCE_HARDWARE -> SUBSTRATE_REFERENCE_HARDWARE

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* cargo update -p polkadot-primitives

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Revert "cargo update -p polkadot-primitives"

This reverts commit 051d51c5ab3fdd80c6351e16d3255efc67288136.

* cargo update -p polkadot-primitives

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
2022-04-26 17:46:13 +00:00
Oliver Tale-Yazdi 9621dbebc9 Co #11270: Update benchmark machine command (#5386)
* Update benchmark machine command

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Add import

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Rename POLKADOT_REFERENCE_HARDWARE -> SUBSTRATE_REFERENCE_HARDWARE

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* update lockfile for {"substrate"}

* Bump spec_version to 9200

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Co-authored-by: parity-processbot <>
2022-04-26 18:26:11 +02:00
João Paulo Silva de Souza d6a66fd831 use options for check_dependent_project (#11284)
Co-authored-by: TriplEight <denis.pisarev@parity.io>
2022-04-26 16:59:13 +02:00
João Paulo Silva de Souza 4a311f1da4 use options for check_dependent_project (#5392)
Co-authored-by: TriplEight <denis.pisarev@parity.io>
2022-04-26 16:58:57 +02:00
Oliver Tale-Yazdi 9980d314b1 Follow ups for benchmark machine (#11270)
* Follow ups for the MachineCmd

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Fix CI

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Review fixes

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Add to node-template

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Fix test with feature flag

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Review fixes

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Lower disk requirements

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Add ExecutionLimit to the disk benchmarks

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* fmt

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Add doc

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Review fixes

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Rename DISK_WRITE_LIMIT -> DEFAULT_DISK_EXECUTION_LIMIT

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Rename POLKADOT_REFERENCE_HARDWARE -> SUBSTRATE_REFERENCE_HARDWARE

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Fix build profile + add license

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Remove deps

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Set tolerance to 10%

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Fix tests

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Ignore test

I cannot reproduce the CI error, even with the full command:
cargo test --workspace --locked --release --verbose --features runtime-benchmarks --manifest-path ./bin/node/cli/Cargo.toml

I will put an 'ignore' on that test for now, since it works for me and is worth having.

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Remove test

Still cannot reproduce the error and it fails in the CI.
Removing it now.

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
2022-04-26 14:31:26 +00:00
Adrian Catangiu 8e7663ba3d service: use deny-list instead of allow-list for BEEFY (#5331)
* use deny-list instead of allow-list for BEEFY

Instead of allowing BEEFY to run on specific test nets,
inverse the condition to explicitly disallow BEEFY on
production chains that we don't want it to run on yet.

This allows other test chains (other than Rococo/Wococo)
that use the polkadot service file to enable and test BEEFY.

Signed-off-by: Adrian Catangiu <adrian@parity.io>

* address review comments

* throw error if BEEFY enabled on production networks

Signed-off-by: acatangiu <adrian@parity.io>
2022-04-26 13:24:09 +00:00
Ayevbeosa Iyamu 7d0252784d Companion for Recovery Pallet benchmarking #11176 (#5366)
* benchmarking for `pallet_recovery`

* Added WeightInfo implementation for pallet_recovery

* Update Cargo.lock

* Update Cargo.toml

Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
2022-04-26 13:09:03 +00:00
João Paulo Silva de Souza 39579ea87f Skip pr-custom-review if pull request is in Draft (#5356)
* skip pr-custom-review if pull request is in Draft

* fix
2022-04-26 14:17:14 +02:00
João Paulo Silva de Souza 9a3201ef3d Skip pr-custom-review if pull request is in Draft (#11248)
* skip pr-custom-review if pull request is in Draft

* ready_for_review

* document steps[*].if

* fix

* converted_to_draft

* fix

Co-authored-by: Giles Cope <gilescope@gmail.com>
2022-04-26 12:14:21 +00:00
Ayevbeosa Iyamu 8a9961b48e Recovery Pallet benchmarking (#11176)
* Created benchmarks

* Added recovery benchmarks

* benchmark for `create_recovery`

* benchmark for `initiate_recovery`

* benchmark for `vouch_recovery`

* benchmark for `claim_recovery`

* benchmark for `close_recovery`

* benchmark for `remove_recovery`

* benchmark for `cancel_recovered`

* benchmark for `as_recovered`

* Some refactoring

* Some refactoring

* Fix create_recovery benchmark

* fix close_recovery benchmark test

* fixed issues with failing tests

* Update frame/recovery/src/benchmarking.rs

Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* removed repetitive code

* create weights file

* Used weights to annotate extrinsics

* Added WeightInfo implementation to mock

* Beauty fixes

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Update frame/recovery/src/benchmarking.rs

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

* Update frame/recovery/src/benchmarking.rs

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

* Set vec to be mut

* set delay_period to use non-zero amount

* set delay default

* Add weights

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
2022-04-26 11:57:55 +00:00
Koute 9550172cb9 Companion for Substrate#11062 (#1113)
* Align to changes in Substrate

* Align to the newest changes in substrate

* Update `Cargo.lock`

* Add hwbenches to `parachain-template` too

* update lockfile for {"polkadot"}

Co-authored-by: parity-processbot <>
2022-04-26 09:51:18 +00:00
Sergejs Kostjucenko 9cdde52cac Change ci vars to use group one's (#11281) 2022-04-26 12:28:18 +03:00
Qinxuan Chen e9b69bc1b0 sp-sandbox: move the sandbox module of sp-core into sp-sandbox (#11027)
* sp-sandbox: move the sandbox module of sp-core into sp-sandbox

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* Fix

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* Fix

Signed-off-by: koushiro <koushiro.cqx@gmail.com>
2022-04-26 11:25:41 +02:00
Koute b049d4f1c9 Add hardware benchmark telemetry (Companion for Substrate#11062) (#5206)
* Align to changes in Substrate

* Align to the newest changes in substrate

* Rename `--disable-hardware-benchmarks` to `--no-hardware-benchmarks`

* Fix `polkadot-test-service` compilation

* Fix compilation of test parachains
2022-04-26 09:16:31 +00:00
Alexander Samusev f0b61c91ce [ci] Fix benchmark branch name and typo (#1216) 2022-04-26 11:05:54 +02:00
Koute 7a92f1678d Update tracing-log to 0.1.3 (Companion for Substrate#11264) (#5393)
* Update `tracing-log` to 0.1.3

* update lockfile for {"substrate"}

Co-authored-by: parity-processbot <>
2022-04-26 09:05:46 +00:00
Koute 94dac682b4 Turn on logger's interest cache (#11264) 2022-04-26 08:05:51 +00:00
dependabot[bot] 2e8d7aae6c Bump nix from 0.24.0 to 0.24.1 (#1215)
Bumps [nix](https://github.com/nix-rust/nix) from 0.24.0 to 0.24.1.
- [Release notes](https://github.com/nix-rust/nix/releases)
- [Changelog](https://github.com/nix-rust/nix/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nix-rust/nix/compare/v0.24.0...v0.24.1)

---
updated-dependencies:
- dependency-name: nix
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-26 09:40:30 +02:00
Sergejs Kostjucenko 631a5db536 Move scripts used in CI to the new location (#5198)
* Move CI scripts and update references

* Update paths in .gitlab-ci.yml

* Removed outdated entries from CODEOWNERS
2022-04-26 08:39:31 +03:00
tgmichel 9a840bb12a Companion to chain-info Subcommand: #11250 (#5370)
* Companion to `blockchain-info` Subcommand: #11250

* Rename to `chain-info`

* Remove `ensure_dev`

* Update cli/src/command.rs

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

* Pin substrate `59a2150`

* `service::Block`

* Unused `chain_spec`

* fmt

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
2022-04-25 23:09:42 +02:00
tgmichel 5eb2e3292d Add chain-info Subcommand (#11250)
* Add `blockchain-info` Subcommand

* Update comment

* Cleanup

* Cleanup

* Use `sync_run`

* Use `sc_client_db` utility fns instead service backend

* Use service `Backend` builder

* Impl `From<sp_blockchain::Info>`

* Rename to `chain-info`

* fmt

* Copyright year

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

* Expose `DatabaseParams`

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
2022-04-25 21:07:26 +02:00
Bastian Köcher 2541efdbcc pallet-asset: Fix transfer of a large amount of an asset (#11241)
* pallet-asset: Fix transfer of a large amount of an asset

Before this pr transferring a large amount of an asset would check that transferring the asset would
not overflow the supply of the asset. However, it doesn't make sense to check for asset supply
overflow when we just transfer from one account to another account and don't increase the supply in
any way. It also required to extend the `can_deposit` method of `fungible` and `fungibles` with a
`mint` parameter. If this parameter is set to `true`, it means we want to mint the amount of an
asset before transferring it into an account. For `can_withdraw` we don't need to add an extra
parameter, because withdrawing should never be able to underflow the supply. If that would happen,
it would mean that somewhere the supply wasn't increased while increasing the balance of an account.

* Update frame/assets/src/functions.rs

* Update frame/assets/src/functions.rs

* Update frame/assets/src/functions.rs

Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>

* FMT

Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
2022-04-25 20:12:06 +02:00
Bernhard Schuster 033950ca36 metrics separation (#5391)
* split metrics from collation generation

* move metrics to separate file out of backing

* split bitfield signing metrics

* split candidate validation metrics

* split chain api metrics

* split metrics from runtime API

* util is not used in backed metrics mod

* fmt

* missing types

* sure
2022-04-25 17:17:29 +00:00
Squirrel c01a9ea524 polkadot-like testnets should be 10 decimal places (#5369)
* polkadot is 10 decimal places

* cargo fmt

* Update node/service/src/chain_spec.rs

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

* name change

* update test also

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
2022-04-25 17:17:11 +00:00
Mara Robin B 9f79fcaef0 Remove SlotsCrowdloanIndexMigration & InjectValidatorsIntoVoterList (#5374) (#5379)
* Remove SlotsCrowdloanIndexMigration

* Remove slots index migration code

* Remove crowdloan index migration code

* remove reference to migration

* rustfmt

* westend: remove unused import OnRuntimeUpgrade

* kusama: remove unused import OnRuntimeUpgrade

* polkadot: remove unused import OnRuntimeUpgrade

* Revert "Remove crowdloan index migration code"

This reverts commit fe84b59e3133e950740d911fb019e6002f60d5a3.

* Revert "Remove slots index migration code"

This reverts commit 62c5a28e21d2949189bdb52835cc3a44f6e9c561.

* Revert "remove reference to migration"

This reverts commit 1f8806c010210b638cc59979ab873619910596c0.

* Remove InjectValidatorsIntoVoterList migration
2022-04-25 18:44:47 +02:00
Squirrel 35f6712c5e fast-runtime tweak (#5201)
* These should be included in fast-runtime
2022-04-25 17:23:47 +01:00
Bastian Köcher 914db49d04 cumulus-companion: Fix CI when there is no Polkadot companion (#11280)
This tries to fix the CI if there is no polkadot companion. Currently we don't update Polkadot
master in Cumulus, which means we may use some old commit that isn't compiling with the latest
Substrate master anymore. This can happen if there was a pr that had a companion in Polkadot, but no
companion was required for Cumulus. Then Cumulus will still point to some old Polkadot commit that
isn't compiling anymore with the latest Substrate commit. So, we need to tell the script to use the
latest master of Polkadot. If there is a companion for Polkadot, it would simply override the extra
dependency patch later on.
2022-04-25 17:07:09 +02:00
Bastian Köcher 5ebcf3643c Update Substrate master (#5380) 2022-04-25 10:22:54 +00:00
nodi-andy 2d63f6da2e bash tutorial: change the working path after clone (#1210) 2022-04-25 10:38:21 +02:00
Nazar Mokrynskyi 539946911e More efficient identity and multiplier weight to fee (#11226) 2022-04-25 04:16:38 +00:00
Squirrel aed6d02055 benchmark now takes a command. (#1191) 2022-04-23 20:44:19 +00:00
dependabot[bot] f88b06a151 Bump clap from 3.1.10 to 3.1.12 (#1208)
Bumps [clap](https://github.com/clap-rs/clap) from 3.1.10 to 3.1.12.
- [Release notes](https://github.com/clap-rs/clap/releases)
- [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md)
- [Commits](https://github.com/clap-rs/clap/compare/v3.1.10...v3.1.12)

---
updated-dependencies:
- dependency-name: clap
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-23 20:42:44 +00:00
girazoki f41f8a0740 Default not implemented for non-std builds for PersistedValidationData (#1207)
* Default not implemented for non-std builds for PersistedValidationData

* Remove v1

* Remove v1 for v2, this time correct

* More reverts of v1 for v2

* Update pallets/parachain-system/src/lib.rs

* fmt

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
2022-04-22 22:35:47 +02:00
Bastian Köcher 53575a959c BABE: Fix aux data cleaning (#11263)
With the latest optimizations of the `FinalityNotification` generation, the aux data pruning started
to print a warning. The problem here was that we printed a warning and stopped the adding of blocks
to prune when we hit the `heigh_limit`. This is now wrong, as we could for example have two 512 long
forks and then we start finalizing one of them. The second fork head would be part of the stale
heads at some point (in the current implementation when we finalize second fork head number + 1),
but then we would actually need to go back into the past than `heigh_limit` (which was actually
last_finalized - 1). We now go back until we reach the canonical chain.

Also fixed some wrong comment that was added by be about the content of the `finalized` blocks in
the `FinalityNotification`.
2022-04-22 16:58:53 +02:00
dependabot[bot] 08f5cc9ca6 Bump bounded-vec from 0.5.0 to 0.6.0 (#5372)
Bumps [bounded-vec](https://github.com/ergoplatform/bounded-vec) from 0.5.0 to 0.6.0.
- [Release notes](https://github.com/ergoplatform/bounded-vec/releases)
- [Changelog](https://github.com/ergoplatform/bounded-vec/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/ergoplatform/bounded-vec/compare/v0.5.0...v0.6.0)

---
updated-dependencies:
- dependency-name: bounded-vec
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-22 16:56:55 +02:00
Chevdor e5d990b5fd Fix priority thresholds (#1203) 2022-04-22 15:52:24 +02:00
Chevdor 85bf52342f Fix priority thresholds (#5375)
Fix for the priorities shown in the release notes
2022-04-22 15:25:49 +02:00
Sebastian Kunert 20a7ffbfcc Bump jsonrpsee-core to 11.0 2022-04-22 11:46:19 +00:00
dependabot[bot] ffdea6a159 Bump jsonrpsee from 0.10.1 to 0.11.0
Bumps [jsonrpsee](https://github.com/paritytech/jsonrpsee) from 0.10.1 to 0.11.0.
- [Release notes](https://github.com/paritytech/jsonrpsee/releases)
- [Changelog](https://github.com/paritytech/jsonrpsee/blob/master/CHANGELOG.md)
- [Commits](https://github.com/paritytech/jsonrpsee/compare/v0.10.1...v0.11.0)

---
updated-dependencies:
- dependency-name: jsonrpsee
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-04-22 11:46:19 +00:00
Vsevolod Stakhov a5742b9ec1 Extract peers grid topology related code to a separate unit (#5365)
* Initial attempt to extract grid topology related code

* Use shared code in the approval distribution subsystem

* Fix spellcheck issues

* Moe Aggression stuff back to the approval-distribution subsystem

* Cargo fmt
2022-04-22 11:19:36 +01:00
Mara Robin B bb3cc7b041 update weights (#5361)
* polkadot: update weights

* kusama: update weights

* rococo: update weights

* westend: update weights
2022-04-22 09:26:19 +00:00
Alexander Samusev abb574000e [ci] small fixes for benchmark jobs (#1195) 2022-04-22 11:10:47 +02:00
João Paulo Silva de Souza ed17955466 skip pr-custom-review if pull request is in Draft (#1188) 2022-04-22 05:51:17 -03:00
dependabot[bot] 02c7433baa Bump tracing-core from 0.1.21 to 0.1.26 (#11258)
Bumps [tracing-core](https://github.com/tokio-rs/tracing) from 0.1.21 to 0.1.26.
- [Release notes](https://github.com/tokio-rs/tracing/releases)
- [Commits](https://github.com/tokio-rs/tracing/compare/tracing-core-0.1.21...tracing-core-0.1.26)

---
updated-dependencies:
- dependency-name: tracing-core
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-22 10:39:33 +02:00
Squirrel 45520d105b warn not info (#1190)
* warn not info

Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
2022-04-22 08:51:59 +01:00
dependabot[bot] c456ffa3f5 Bump nix from 0.23.1 to 0.24.0 (#1200)
Bumps [nix](https://github.com/nix-rust/nix) from 0.23.1 to 0.24.0.
- [Release notes](https://github.com/nix-rust/nix/releases)
- [Changelog](https://github.com/nix-rust/nix/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nix-rust/nix/commits)

---
updated-dependencies:
- dependency-name: nix
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-22 08:53:57 +02:00
Zeke Mostov 42cbfba5d3 Companion to Proportional Slashing: Substrate #10982 (#5306)
* Companion to Proportional Slashing

* update lockfile for {"substrate"}

Co-authored-by: parity-processbot <>
2022-04-22 00:14:28 +00:00
Zeke Mostov e0bf4f36bf staking: Proportional ledger slashing (#10982)
* staking: Proportional ledger slashing

* Some comment cleanup

* Update frame/staking/src/pallet/mod.rs

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

* Fix benchmarks

* FMT

* Try fill in all staking configs

* round of feedback and imp from kian

* demonstrate per_thing usage

* Update some tests

* FMT

* Test that era offset works correctly

* Update mocks

* Remove unnescary docs

* Remove unlock_era

* Update frame/staking/src/lib.rs

* Adjust tests to account for only remove when < ED

* Remove stale TODOs

* Remove dupe test

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Co-authored-by: kianenigma <kian@parity.io>
2022-04-21 22:53:54 +00:00