e8ad74824d
[fix lint warnings: Uniques pallet] fix clippy::missing_errors_doc lint warnings ( #14588 )
...
* Fix clippy::missing_errors_doc lint warnings
* update error docs
* cargo +nightly fmt
* add intra doc linking
* fmt
---------
Co-authored-by: parity-processbot <>
2023-08-14 15:34:05 +00:00
8f6445fb8e
Remove the Copy bound on CollectionId in the uniques pallet ( #14111 )
...
* Remove the `Copy` bound on `CollectionId` in the uniques pallet
* Also add `clone`s in benchmarks
2023-05-10 09:39:43 +00:00
bc53b9a03a
Remove years from copyright notes. ( #13415 )
...
* Change copyright year to 2023 from 2022
* Fix incorrect update of copyright year
* Remove years from copy right header
* Fix remaining files
* Fix typo in a header and remove update-copyright.sh
2023-02-21 18:46:41 +00:00
ae8ef86ec0
Use non-binary pronouns in comments. ( #13209 )
...
* use non binary pronouns in comments
* cargo fmt
* fix the use of "it" with "they" when dealing about an opperations identity
2023-01-27 12:31:17 +01:00
25b4f8c688
Disallow burning externally locked nfts ( #13054 )
...
* Disallow burning externally locked nfts
* Update docs
2023-01-04 08:30:43 +00:00
7f1b9a937a
Uniques: Reset approved account after transfer ( #12145 )
...
* reset approved account
* wrap at 100
* doc
* fmt
* Update frame/uniques/src/tests.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* new test
* Update frame/uniques/src/lib.rs
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
* fmt
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
2022-09-01 08:45:20 +00:00
b0ff805740
Revert "Auto-incremental CollectionId ( #11796 )" ( #12059 )
...
This reverts commit 658b179686oliver.tale-yazdi@parity.io >
2022-08-19 13:15:57 +00:00
a68a80fbae
declone and close the door ( #12035 )
...
* declone and close the door
* cargo fmt
* remove brackets
2022-08-15 19:38:36 +00:00
658b179686
Auto-incremental CollectionId ( #11796 )
...
* autoincrementing CollectionId
* fix
* benchmarking fix
* fmt
* fix
* update before checking
* fmt
* fix
* fmt
* commit
* tests & fix
* fix
* commit
* docs
* safe math
* unexpose function
* benchmark
* fmt
* better naming
* fix?
* merge fixes
* fmt
* ".git/.scripts/bench-bot.sh" pallet dev pallet_uniques
* wrong weight
* Update frame/uniques/src/lib.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update frame/uniques/src/lib.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* using substrate trait instead of num-traits
* remove unnecessary trait
* emit NextCollectionIdIncremented in do_create_collection
* fix in benchmarks
* check for event & group import
* docs
Co-authored-by: Sergej Sakač <sergejsakac@Sergejs-MacBook-Air.local >
Co-authored-by: command-bot <>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
2022-07-30 14:09:25 +00:00
5d96c0a0ea
Buy&Sell methods for Uniques ( #11398 )
...
* Allow to set item's price
* Clean the state when we transfer/burn an item or destroy a collection
* Allow to buy an item
* Remove redundant checks
* Improve events
* Cover with tests
* Add comments
* Apply suggestions
* Fmt
* Improvements for price validation
* Improve validation
* Update to use the new terminology
* Remove multi-assets support
* Chore
* Weights + benchmarking
* Shield against human error
* Test when we pass the higher item's price
* fmt fix
* Chore
* cargo run --quiet --profile=production --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark pallet --chain=dev --steps=50 --repeat=20 --pallet=pallet_uniques --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/uniques/src/weights.rs --template=./.maintain/frame-weight-template.hbs
* Remove is_frozen check when setting the price
* Try to fix benchmarking
* Fix benchmarking
* cargo run --quiet --profile=production --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark pallet --chain=dev --steps=50 --repeat=20 --pallet=pallet_uniques --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/uniques/src/weights.rs --template=./.maintain/frame-weight-template.hbs
* Add transactional
* Add 'allow deprecated' flag for transactional
* Remove #[allow(deprecated)]
* ".git/.scripts/bench-bot.sh" pallet dev pallet_uniques
Co-authored-by: Parity Bot <admin@parity.io >
Co-authored-by: command-bot <>
2022-07-13 12:41:20 +00:00
7b712fa4ff
Remove a max supply record on collection's destruction ( #11593 )
...
* Remove a max supply record on collection's destruction
* cargo run --quiet --profile=production --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark pallet --chain=dev --steps=50 --repeat=20 --pallet=pallet_utility --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/utility/src/weights.rs --template=./.maintain/frame-weight-template.hbs
* cargo run --quiet --profile=production --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark pallet --chain=dev --steps=50 --repeat=20 --pallet=pallet_uniques --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/uniques/src/weights.rs --template=./.maintain/frame-weight-template.hbs
* cargo run --quiet --profile=production --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark pallet --chain=dev --steps=50 --repeat=20 --pallet=pallet_uniques --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/uniques/src/weights.rs --template=./.maintain/frame-weight-template.hbs
Co-authored-by: Parity Bot <admin@parity.io >
2022-06-07 10:08:58 +00:00
ecbd65fb95
Safe and sane multi-item storage removal ( #11490 )
...
* Fix overlay prefix removal result
* Second part of the overlay prefix removal fix.
* Report only items deleted from storage in clear_prefix
* Fix kill_prefix
* Formatting
* Remove unused code
* Fixes
* Fixes
* Introduce clear_prefix host function v3
* Formatting
* Use v2 for now
* Fixes
* Formatting
* Docs
* Child prefix removal should also hide v3 for now
* Fixes
* Fixes
* Formatting
* Fixes
* apply_to_keys_whle takes start_at
* apply_to_keys_whle takes start_at
* apply_to_keys_whle takes start_at
* Cursor API; force limits
* Use unsafe deprecated functions
* Formatting
* Fixes
* Grumbles
* Fixes
* Docs
* Some nitpicks 🙈
* Update primitives/externalities/src/lib.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Formatting
* Fixes
* cargo fmt
* Fixes
* Update primitives/io/src/lib.rs
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
* Formatting
* Fixes
Co-authored-by: Bastian Köcher <info@kchr.de >
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
2022-05-29 12:56:26 +01:00
236cc98be2
Allow to set the max supply for collection ( #11441 )
...
* Allow to set the max supply for collection
* Update error
* Add weights info
* cargo run --quiet --profile=production --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark pallet --chain=dev --steps=50 --repeat=20 --pallet=pallet_uniques --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/uniques/src/weights.rs --template=./.maintain/frame-weight-template.hbs
* Update frame/uniques/src/lib.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: Parity Bot <admin@parity.io >
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
2022-05-18 11:23:44 +00:00
ed7d1e7ac0
Use 'Items' and 'Collections' in uniques pallet ( #11389 )
...
* Rename class to collection
* Use "assets collection" instead of "asset collection"
* Rename 'instance' to 'asset'
* Change "asset `collection`" to "`collection`"
* A bit more clean up
* Rename Asset to Item
* Add a storage hack
* Typos
* fix compile
* fmt
* Fix
* cargo run --quiet --profile=production --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark pallet --chain=dev --steps=50 --repeat=20 --pallet=pallet_uniques --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/uniques/src/weights.rs --template=./.maintain/frame-weight-template.hbs
* Update frame/uniques/src/lib.rs
* cargo run --quiet --profile=production --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark pallet --chain=dev --steps=50 --repeat=20 --pallet=pallet_uniques --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/uniques/src/weights.rs --template=./.maintain/frame-weight-template.hbs
* Change 'items collection' to 'collection'
* Apply suggestions
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com >
Co-authored-by: Parity Bot <admin@parity.io >
2022-05-16 13:38:12 +00:00
b581604aa7
Apply some clippy lints ( #11154 )
...
* Apply some clippy hints
* Revert clippy ci changes
* Update client/cli/src/commands/generate.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/cli/src/commands/inspect_key.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/db/src/bench.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/db/src/bench.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/service/src/client/block_rules.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/service/src/client/block_rules.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/network/src/transactions.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/network/src/protocol.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Revert due to missing `or_default` function.
* Fix compilation and simplify code
* Undo change that corrupts benchmark.
* fix clippy
* Update client/service/test/src/lib.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/state-db/src/noncanonical.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/state-db/src/noncanonical.rs
remove leftovers!
* Update client/tracing/src/logging/directives.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Update utils/fork-tree/src/lib.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* added needed ref
* Update frame/referenda/src/benchmarking.rs
* Simplify byte-vec creation
* let's just not overlap the ranges
* Correction
* cargo fmt
* Update utils/frame/benchmarking-cli/src/shared/stats.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Update utils/frame/benchmarking-cli/src/pallet/command.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Update utils/frame/benchmarking-cli/src/pallet/command.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
Co-authored-by: Giles Cope <gilescope@gmail.com >
2022-04-30 21:28:27 +00:00
21341f35e2
Dependency Injection Trait Locker for Uniques Pallet ( #11025 )
...
* Create a dependency injection trait named Locker that can be implemented downstream to enable locking of an asset. Use case defined in RMRK substrate pallet PR76
* Formatting
* Change impl Locker function name to is_locked
* Remove unused import
* Add docstring header
* Remove impl_locker file and add Locker trait to frame_support::traits
* Expose Locker from frame_support::traits::misc
* Formatting
* Move to tokens folder
* Move to tokens folder
* Format and remove Locker from misc traits
* Punctuation
* Update frame/support/src/traits/tokens/misc.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com >
Co-authored-by: Giles Cope <gilescope@gmail.com >
2022-04-28 11:05:18 +00:00
939d1b089c
Rename Uniques Error::Unknown to something more sensible ( #10895 )
...
* Rename Uniques Error::Unknown to something more sensible
* Typos
* Typos
* fmt
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix tests
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* fmt
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
2022-02-22 10:42:46 +00:00
f3662b4bba
Happy new year 2022 ( #10573 )
2022-01-03 09:22:14 +01:00
42468edd53
Expose Uniques helper functions and DestroyWitness fields ( #10529 )
2021-12-31 11:49:04 +01:00
94056a4da7
Add ClassAccount storage to unique pallet ( #9940 )
...
* add ClassAccount to uniques storage
* add tests for Class and ClassAccount storage
* fix format
* fix description
* add migration
* remove extra iteration
* Update frame/uniques/src/migration.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_uniques --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/uniques/src/weights.rs --template=./.maintain/frame-weight-template.hbs
* fix format
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
Co-authored-by: Parity Bot <admin@parity.io >
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com >
2021-12-18 15:41:05 +00:00
8a5bb77e03
Add field names to pallet Event variants ( #10184 )
...
* Changed named fields to struct variants
* Fixed errors.
* Made adjustments as per `cargo +nightly fmt`.
* Update frame/uniques/src/lib.rs
Co-authored-by: Alexander Theißen <alex.theissen@me.com >
* Removed redundant comments for structs.
* Moved frame-support to dev dependencies
Co-authored-by: Alexander Theißen <alex.theissen@me.com >
2021-11-15 19:16:03 +00:00
f8a228859e
Fungibles and Non-Fungibles Create and Destroy Traits + Assets and Uniques Implementation ( #9844 )
...
* refactor `do_destroy`
* destroy trait
* refactor do_force_create
* impl create trait
* do not bleed weight into api
* Do the same for uniques
* add docs
2021-09-26 22:05:01 +00:00
76611ba6a3
Add nonfungibles::Create Trait & Implement for Uniques ( #9438 )
...
* Add nonfungibles::Create Trait & Implement for Uniques
Closes #9419
* Formatting
* Remove default implementation (`TokenError::Unsupported`) from `Create` trait
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Formatting
* Do not wrap parameters in Options
* Formatting
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
2021-07-28 13:39:04 +00:00
7b56ab15b4
Run cargo fmt on the whole code base ( #9394 )
...
* Run cargo fmt on the whole code base
* Second run
* Add CI check
* Fix compilation
* More unnecessary braces
* Handle weights
* Use --all
* Use correct attributes...
* Fix UI tests
* AHHHHHHHHH
* 🤦
* Docs
* Fix compilation
* 🤷
* Please stop
* 🤦 x 2
* More
* make rustfmt.toml consistent with polkadot
Co-authored-by: André Silva <andrerfosilva@gmail.com >
2021-07-21 14:32:32 +00:00
bf1ea96c66
Non-fungible token traits ( #8993 )
...
* Non-fungible token traits
* Docs
* Fixes
* Implement non-fungible trait for Uniques
* Update frame/uniques/src/impl_nonfungibles.rs
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com >
* Update frame/uniques/src/impl_nonfungibles.rs
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com >
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com >
2021-06-03 13:20:34 +02:00
Sacha Lansky