Commit Graph

14404 Commits

Author SHA1 Message Date
Nazar Mokrynskyi 47bfa4f90f Trivial networking changes for Substrate PR #11940 (#1486)
* Trivial networking changes for Substrate PR https://github.com/paritytech/substrate/pull/11940

* Apply formatting rules

* update lockfile for {"polkadot", "substrate"}

Co-authored-by: parity-processbot <>
2022-08-09 23:59:34 +02:00
Nazar Mokrynskyi f1dce2f548 Trivial networking changes for Substrate PR #11940 (#5841)
* Trivial networking changes for Substrate PR https://github.com/paritytech/substrate/pull/11940

* update lockfile for {"substrate"}

Co-authored-by: parity-processbot <>
2022-08-09 19:37:31 +00:00
Nazar Mokrynskyi a685582bfd Network sync refactoring (part 6) (#11940)
* Extract `NetworkKVProvider` trait in `sc-authority-discovery` and remove unnecessary dependency

* Extract `NetworkSyncForkRequest` trait in `sc-finality-grandpa`

* Relax requirements on `SyncOracle` trait, remove extra native methods from `NetworkService` that are already provided by trait impls

* Move `NetworkSigner` trait from `sc-authority-discovery` into `sc-network-common` and de-duplicate methods on `NetworkService`

* Move `NetworkKVProvider` trait from `sc-authority-discovery` into `sc-network-common` and de-duplicate methods on `NetworkService`

* Minimize `sc-authority-discovery` dependency on `sc-network`

* Move `NetworkSyncForkRequest` trait from `sc-finality-grandpa` to `sc-network-common` and de-duplicate methods in `NetworkService`

* Extract `NetworkStatusProvider` trait and de-duplicate methods on `NetworkService`

* Extract `NetworkPeers` trait and de-duplicate methods on `NetworkService`

* Extract `NetworkEventStream` trait and de-duplicate methods on `NetworkService`

* Move more methods from `NetworkService` into `NetworkPeers` trait

* Move `NetworkStateInfo` trait into `sc-network-common`

* Extract `NetworkNotification` trait and de-duplicate methods on `NetworkService`

* Extract `NetworkRequest` trait and de-duplicate methods on `NetworkService`

* Remove `NetworkService::local_peer_id()`, it is already provided by `NetworkStateInfo` impl

* Extract `NetworkTransaction` trait and de-duplicate methods on `NetworkService`

* Extract `NetworkBlock` trait and de-duplicate methods on `NetworkService`

* Remove dependencies on `NetworkService` from most of the methods of `sc-service`

* Address simple review comments
2022-08-09 18:28:32 +00:00
Koute 9c56e79c43 Restore wasmtime's default stack size limit to 1MB (#11993)
* Restore `wasmtime`'s default stack size limit to 1MB

* Add extra comments

* Enforce different maximum call depth in release mode

* Split the call depth limit in two
2022-08-09 11:04:28 +00:00
Roman Useinov 4436f2b1b6 [Fix] Benchmark build artifact folder creation (#1518) 2022-08-09 07:15:26 +00:00
Ignacio Palacios d9d19c1d53 Upgrade spec_version to 9230 and bump transaction_version for assets parachains. (#1340) (#1494)
* Transaction version bump + updated spec_version

* Reformatting issue

* Adding missing runtimes

* Upgrading contracts pallet runtime version

* Upgrading Seedling runtime

* Bump polkadot-parachain version

Co-authored-by: Wilfried Kopp <wilfried@parity.io>

Co-authored-by: Hector Bulgarini <hbulgarini@gmail.com>
Co-authored-by: Wilfried Kopp <wilfried@parity.io>
2022-08-08 17:02:50 +02:00
Alexander Theißen d910386081 contracts: Apply depth limit when decoding (#11991) 2022-08-08 14:32:00 +00:00
Nikos Kontakis f545af2a81 Renaming CLI prunning and keep-blocks flags (#1514)
* Rename keep blocksflag

* Add correct use of BlocksPruning

* update lockfile for {"polkadot", "substrate"}

Co-authored-by: parity-processbot <>
2022-08-08 14:22:57 +00:00
Nikos Kontakis 8a947d4c5d Renaming CLI prunning and keep-blocks flags (#5863)
* Renaming CLI prunning and keep-blocks flags

* update lockfile for {"substrate"}

Co-authored-by: parity-processbot <>
2022-08-08 10:15:08 +00:00
yjh e945ae6365 chore: fix typos and sort trait impls (#11989) 2022-08-08 09:49:00 +00:00
Kevin Wang 266fa8516a Fix 16bit func_id (#11985) 2022-08-08 09:46:57 +00:00
Nikos Kontakis 20c49b20a7 Rename --pruning and --keep-blocks to be more similar to one another (#11934)
* rename prunning and keep-blocks flags

* Add aliases in keep-blocks and pruning for backward compatibility

* Rename in code variables from  and  to  and
2022-08-08 09:31:26 +00:00
Bastian Köcher a196b1618b Update yamux to fix a potential crash (#5861) 2022-08-05 20:05:40 +02:00
Bastian Köcher a314484865 system_syncState: Always return highest block (#11979)
Before `highestBlock` was an optional that was omitted when it was `None`. We recently changed the
way the `highestBlock` is determined, this resulted in having this value in 99.99% of the time being
`None` when the node is syncing blocks at the tip. Now we always return a block for `highestBlock`.
If sync doesn't return us any best seen block, we return our own local best block as `highestBlock`.
This should mainly reflect the same behavior to before we changed the way the best seen block is determined.
2022-08-05 19:53:56 +02:00
Dmitry Markin 43107b5391 Update RequestResponseConfig interface to match substrate (#5849)
* Update RequestResponseConfig interface

* minor: Bump CI

* update lockfile for {"substrate"}

* update lockfile for {"substrate"}

Co-authored-by: parity-processbot <>
2022-08-05 10:37:19 +00:00
Dmitry Markin a1ee0fca0b sync protocol now can have negotiated fallback name (#11982) 2022-08-05 09:48:05 +00:00
Dmitry Markin 6eda842cf0 Change on-the-wire protocol names to include genesis hash & fork id (#11938)
* Rename transactions protocol to include genesis hash

* Add protocol name generation to sc_network::utils

* Use utils functions for transactions protocol name generation

* Extract protocol name generation into public module

* Use sc_network::protocol_name::standard_protocol_name() for BEEFY and GRANDPA

* minor: add missing newline at EOF

* Change block-announces protocol name to include genesis_hash & fork_id

* Change protocol names to include genesis hash and fork id

Protocols changed:
    - sync
    - state
    - light
    - sync/warp

* Revert "Use sc_network::protocol_name::standard_protocol_name() for BEEFY and GRANDPA"

This reverts commit cd60a95a3face397e1b67f4bc95dd0f2b581bfae.

* Get rid of `protocol_name` module
2022-08-05 06:50:57 +00:00
Davide Galassi 946f6a2818 Prevent duplicated leaves in the backend (#11941)
* Prevent duplicated leaves in the backend

* Comments...

* Use highest known heaf as a shortcut for not existing header detection

* Apply code review suggestion

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
2022-08-04 20:57:05 +00:00
dependabot[bot] 6ad411a5fe Bump tracing from 0.1.35 to 0.1.36 (#1495)
Bumps [tracing](https://github.com/tokio-rs/tracing) from 0.1.35 to 0.1.36.
- [Release notes](https://github.com/tokio-rs/tracing/releases)
- [Commits](https://github.com/tokio-rs/tracing/compare/tracing-0.1.35...tracing-0.1.36)

---
updated-dependencies:
- dependency-name: tracing
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-08-04 22:24:26 +02:00
dependabot[bot] dff1ed159c Bump dyn-clone from 1.0.8 to 1.0.9
Bumps [dyn-clone](https://github.com/dtolnay/dyn-clone) from 1.0.8 to 1.0.9.
- [Release notes](https://github.com/dtolnay/dyn-clone/releases)
- [Commits](https://github.com/dtolnay/dyn-clone/compare/1.0.8...1.0.9)

---
updated-dependencies:
- dependency-name: dyn-clone
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-08-04 16:15:55 +02:00
Javier Viola 023c70badd [Zombienet] update the image to the version 1.2.51 globally (#5856)
* rollback global version and use new version for beefy test

* move zombienet to v1.2.51

* use global version in all tests

* add image value to tests
2022-08-04 12:42:04 +00:00
dependabot[bot] 278e0ebde3 Bump async-trait from 0.1.56 to 0.1.57 (#1493)
Bumps [async-trait](https://github.com/dtolnay/async-trait) from 0.1.56 to 0.1.57.
- [Release notes](https://github.com/dtolnay/async-trait/releases)
- [Commits](https://github.com/dtolnay/async-trait/compare/0.1.56...0.1.57)

---
updated-dependencies:
- dependency-name: async-trait
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-08-04 10:56:41 +00:00
dependabot[bot] 1c6ba1cae5 Bump cranelift-codegen from 0.85.1 to 0.85.3 (#1466)
Bumps [cranelift-codegen](https://github.com/bytecodealliance/wasmtime) from 0.85.1 to 0.85.3.
- [Release notes](https://github.com/bytecodealliance/wasmtime/releases)
- [Changelog](https://github.com/bytecodealliance/wasmtime/blob/main/docs/WASI-some-possible-changes.md)
- [Commits](https://github.com/bytecodealliance/wasmtime/commits)

---
updated-dependencies:
- dependency-name: cranelift-codegen
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-08-04 10:28:35 +00:00
Giles Cope c58a7ec911 and again 2022-08-04 12:26:07 +02:00
Giles Cope e243f5e92c There's already one directly below 2022-08-04 12:26:07 +02:00
Giles Cope ddb8690a7e if not in a subdir... 2022-08-04 12:26:07 +02:00
Giles Cope 2823e29388 another shot 2022-08-04 12:26:07 +02:00
Giles Cope 4a172317a4 broader scope 2022-08-04 12:26:07 +02:00
Giles Cope 70bbf38dde Like polkadot, save context.json as an artifact 2022-08-04 12:26:07 +02:00
Giles Cope dd3762bb5a adapt to subwasm version output format change 2022-08-04 12:26:07 +02:00
ZhiYong 27747b4d1a Companion for substrate#11962 (#5852)
* Companion for substrate#11962

* update lockfile

Co-authored-by: acatangiu <adrian@parity.io>
2022-08-04 13:24:34 +03:00
Bernhard Schuster 3f01d04ad2 chore; don't require default features for cli (#1497)
* don't require default features for an API crate

Let the consumer define by overriding the features for the inner deps as needed.
Cargo feature resolution allows this.

Ref https://github.com/paritytech/polkadot/pull/5792

* Update client/relay-chain-inprocess-interface/Cargo.toml

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
2022-08-04 09:46:01 +00:00
Bastian Köcher 753907a184 Timestamp: set_timestamp sets DidUpdate (#11960)
* Timestamp: `set_timestamp` sets `DidUpdate`

There exists the `set_timestamp` in the Timestamp pallet for setting the current timestamp. The
problem is that it doesn't set `DidUpdate`. This results in `on_finalize` panicking. There is no
real reason why the function doesn't also set `DidUpdate`.

* Update frame/timestamp/src/lib.rs

Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Fix Babe tests

Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
2022-08-04 11:34:19 +02:00
ZhiYong b8ad45373f Beefy: use VersionedFinalityProof instead of SignedCommitment (#11962)
* beefy: use VersionedFinalityProof instead of SignedCommitment.

* Change the exposed RPC API to support versioned proofs.

Co-authored-by: Adrian Catangiu <adrian@parity.io>
2022-08-04 10:47:52 +03:00
Adrian Catangiu 8d1bba18af zombienet: BEEFY and MMR test (#5840)
Signed-off-by: acatangiu <adrian@parity.io>
2022-08-04 10:27:17 +03:00
lucasvanmol 97b2a5ee75 Update node-template's docker-compose.yml (#11802)
* Update docker-compose.yml

* Use production image

Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>

Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>
Co-authored-by: parity-processbot <>
2022-08-04 09:16:24 +02:00
Oliver Tale-Yazdi b065b4364c Run benchmarks with --steps=2 (#5853)
The benchmarks have been run internally with at least two values
even when called with --steps=1. substrate/#11890 changed this
to explicitly require at least --steps=2.

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
2022-08-03 21:00:35 +00:00
girazoki 8f2a3a5077 Statemint runtimes to accept sufficient assets as xcm fee payment (#1278)
* point to my branch

* girazoki-add-TakeFirstAssetTrader-to-utility

* Commit lock

* point at custom branch

* add new trader to statemine runtimes

* compiles

* Back to master

* Update last tomls

* Imports up

* remove non-needing imports

* FMT

* log messages properly

* Use TakeRevenue instead of HandleCredit

* Introduce xcm fee handler

* check total supply in tests

* FMT

* fix test

* Start decoupling balance calculation into different traits

* Make traits a bit more generic

* PR suggestions

* add import

* import well

* Place xcmfeesassethandler into parachains common

* fix tests

* config parameters

* Min amount to fee receiver

* Make minimum amount for block author to be at least the ED

* Doc in AssetFeeAsExistentialDepositMultiplier

* saturating sub

* make sure we dont enter twice

* FMT

* fmt again

* adapt tests

* Add doc and struct for weight refund

* Doc

* More doc

* PR suggestions

* store all info related to asset payment as multiasset

* return AssetNotFound instead of TooExpensive

* Use asset transactor to deposit fee

* uninstall from statemint

* R for RUntime and CON for BalanceConverter

* Rework logic to avoid unnecesary match and error

* Rework ED check, also in case of refund

* rework typo

* In case refund makes drop below ED, just refund the difference

* fix test westmint

* clone id

* move test imports to preamble

* move test imports to preamble

* test-utils with builderS

* lock file updated

* remove unused imports

Co-authored-by: Stephen Shelton <steve@brewcraft.org>
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
Co-authored-by: joepetrowski <joe@parity.io>
2022-08-03 16:04:13 +00:00
Alexandru Vasile 935e682a5f Companion for #11939 (#1487)
* Bump jsonrpsee to v0.15.1

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

* Update Cargo.lock

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

* Update cargo.lock

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

* client: Upadte jsonrpsee-core from relay-chain-interface

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

* update substrate & polkadot

* update substrate & polkadot

Co-authored-by: Niklas Adolfsson <niklasadolfsson1@gmail.com>
2022-08-03 15:25:18 +02:00
Shawn Tabrizi e7e2018203 nit improvements to pallet template (#11968) 2022-08-03 13:35:47 +02:00
Sacha Lansky df07421904 Fix docs urls (#11966)
* Fix docs urls

* Update bin/node-template/README.md

* Update frame/aura/src/lib.rs

* Run cargo +nightly fmt

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
2022-08-03 13:34:33 +02:00
Alexandru Vasile d84433bd7f Companion for #11939 (#5846)
* Bump jsonrpsee to v0.15.1

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

* Update cargo.lock

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

* Minimal update to Cargo.lock

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

* update substrate

* update lockfile for {"substrate"}

* update substrate master

* Allow benchmark checks to fail

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Co-authored-by: Niklas Adolfsson <niklasadolfsson1@gmail.com>
Co-authored-by: parity-processbot <>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
2022-08-03 12:23:16 +02:00
Bastian Köcher 5ebf17bfe1 Revert non-best block (#11716)
* Revert non-best block

This makes `revert` also revert non-best blocks.

* Update client/db/src/lib.rs

* Do not count leaves against the maximum number to revert

* Add some explanation

* Fix bug

* Apply suggestions from code review

Co-authored-by: Davide Galassi <davxy@datawok.net>

Co-authored-by: Davide Galassi <davxy@datawok.net>
2022-08-03 08:46:10 +00:00
Andronik 0cda69d34a offences: make fn slash_fraction non-static (#11956)
* offences: make fn slash_fraction non-static

* Bastifmt (inline variable)
2022-08-02 18:49:03 +00:00
Alexandru Vasile 63f847c24f rpc: Update jsonrpsee v0.15.1 (#11939)
* Bump jsonrpsee to v0.15.1

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

* Update cargo.lock

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

* rpc-servers: Adjust RpcMiddleware to WS and HTTP traits

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

* rpc/author: Use `SubscriptionSink`

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

* rpc/chain: Use `SubscriptionSink`

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

* rpc/state:  Use `SubscriptionSink`

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

* rpc/finality-grandpa: Use `SubscriptionSink`

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

* rpc/beefy: Use `SubscriptionSink`

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

* client: Extract RPC string result from queries

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

* Apply rust-fmt

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

* Fix warnings

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

* Fix testing

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

* rpc/tests: Remove trailing comma

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

* rpc: Use `SubscriptionResult` for implementations

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

* rpc: Remove comment

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

* rpc: Delegate middleware calls to `RpcMiddleware`

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

* rpc: Remove comment

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

* Revert Cargo.lock

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

* Update Cargo.lock with minimal changes

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

* rpc: Update imports for `SubscriptionResult`

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

* Apply cargo fmt

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

* rpc/tests: Submit raw json requests to validate DenyUnsafe

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
2022-08-02 17:00:18 +00:00
Nikos Kontakis 103f770e75 Rename node-runtime to node-kitchensink-runtime (#11930)
* Rename node=runtime to kithensink-runtime

* Undo md formatting
2022-08-02 15:25:52 +00:00
Ignacio Palacios 708bb7bee6 Add script to run integration tests (#1431)
* script run integration tests

* Update scripts/parachains_integration_tests.sh

Co-authored-by: Squirrel <gilescope@gmail.com>

* Update scripts/parachains_integration_tests.sh

Co-authored-by: Chevdor <chevdor@users.noreply.github.com>

* Update scripts/parachains_integration_tests.sh

Co-authored-by: Squirrel <gilescope@gmail.com>
Co-authored-by: Chevdor <chevdor@users.noreply.github.com>
2022-08-02 16:33:34 +02:00
Muharem Ismailov 65e24ec498 gitignore dot-underscore (#1488) 2022-08-02 13:12:34 +00:00
Alexander Samusev 2e8249dc17 [ci] chores: remove cargo install nextest (#11961) 2022-08-02 15:01:15 +02:00
bernardo f5c644f272 benchmarking f32 step calculation (#11890)
* benchmark steps with f32

* divide by self.steps - 1

* avoid steps <= 1

* Fix step size

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Fix 'steps' print and print number of args

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Add Test

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* fix comments

* Remove unneeded comment

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: parity-processbot <>
2022-08-02 12:43:57 +00:00