e77099c1a6
Make blocks per request configurable ( #13824 )
...
* Make blocks per request configurable
* Correct type
* Update docs
* Update client/cli/src/params/network_params.rs
2023-04-07 08:20:17 +00:00
23de70a536
Update the frame-weight-template to use PhantomData from core ( #13844 )
...
* update weights template and recalculate weights from pallet template
* update template file in benchmarking-cli
2023-04-06 16:19:46 +00:00
b0d99a084a
Fix typos ( #13842 )
...
* Fix typo
GRANPA -> GRANDPA
* Fix capitalisation
Fixed words capitalised in the middle of sentences.
2023-04-06 18:06:15 +02:00
5cd939bda1
RemovePallet migration utility struct (#13835 )
...
* remove pallet utility struct
* Update frame/support/src/remove_pallet.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* Update frame/support/src/remove_pallet.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* make removepallet a module of migrations
* fix rust doc lint
---------
Co-authored-by: Bastian Köcher <git@kchr.de >
2023-04-07 00:27:25 +10:00
0d7402eb8c
Use proper weights in the pallet-template ( #13817 )
...
* benchmarking to generate weights file
* add the calculated weights in the extrinsics
* use benchmarking v2 syntax to generate the weights
* minor syntax change when benchmarking
* added WeightInfo in the mock to pass tests
* minor cargo fmt format changes
2023-04-06 11:27:43 +00:00
0b3444c51d
Fix try-runtime follow-chain, try-runtime upgrade tuple tests, cli test utils ( #13794 )
...
* new test for try-runtime tuple stuff
* fix
* remove development comment
* formatting
* remove todo comment
* follow-chain working test
* refactor common cli testing utils
* fix comment
* revert Cargo.lock changes
* update Cargo.lock
* improve doc comment
* fix error typo
* update Cargo.lock
* feature gate try-runtime test
* build_substrate cli test util
* feature gate follow_chain tests
* move fn start_node to test-utils
* improve test pkg name
* use tokio Child and Command
* remove redundant import
* fix ci
* fix ci
* don't leave hanging processes
* improved child process cleanup
* use existing KillChildOnDrop
* remove redundant comment
* Update test-utils/cli/src/lib.rs
Co-authored-by: Koute <koute@users.noreply.github.com >
---------
Co-authored-by: kianenigma <kian@parity.io >
Co-authored-by: Koute <koute@users.noreply.github.com >
2023-04-06 19:49:53 +10:00
38f3b053d7
Add HoldReason to the NIS pallet ( #13823 )
...
* Add HoldReason to the NIS pallet
* Rename composable_enum to composite_enum
* Add encoding test
* Add more doc comments
2023-04-06 06:24:45 +00:00
3ace2f50c5
remove duplicate sync option documentation ( #13828 )
2023-04-06 07:28:21 +02:00
fa8e323231
ProofRecorder: Implement transactional support ( #13769 )
...
* TrieRecorder: Start adding support for transactions
* Adds `transactions` functions and some test
* More tests
* Docs
* Ensure that we rollback failed transactions in the storage proof
* FMT
* Update primitives/trie/src/recorder.rs
Co-authored-by: Dmitry Markin <dmitry@markin.tech >
* Review comments
* Update primitives/trie/src/recorder.rs
Co-authored-by: Sebastian Kunert <skunert49@gmail.com >
* ".git/.scripts/commands/fmt/fmt.sh"
* For the holy clippy!
* Update primitives/trie/src/recorder.rs
Co-authored-by: Anton <anton.kalyaev@gmail.com >
---------
Co-authored-by: Dmitry Markin <dmitry@markin.tech >
Co-authored-by: Sebastian Kunert <skunert49@gmail.com >
Co-authored-by: command-bot <>
Co-authored-by: Anton <anton.kalyaev@gmail.com >
2023-04-05 14:43:17 +00:00
06f84830b6
Mention on_idle round-robin logic to trait Hooks cargo doc ( #13797 )
...
* Adds on_idle round-robin logic to trait Hooks docs
* Makes the docs more concise
* Update frame/support/src/traits/hooks.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* fmt
---------
Co-authored-by: Bastian Köcher <git@kchr.de >
2023-04-05 13:14:46 +00:00
495773f96d
Move registration of ReadRuntimeVersionExt to ExecutionExtension ( #13820 )
...
Instead of registering `ReadRuntimeVersionExt` in `sp-state-machine` it is moved to
`ExecutionExtension` which provides the default extensions.
2023-04-05 14:27:26 +02:00
d3f5c70dde
update links to ink! ( #13819 )
2023-04-05 04:34:42 +00:00
36957d6760
Deprecate V1 Weights ( #13699 )
...
* Remove deprecated pallet calls
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Deprecate old weight
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update Runtime API
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix tests
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Delete shitty code
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix doctest
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update frame/alliance/src/lib.rs
Co-authored-by: Koute <koute@users.noreply.github.com >
* Add doc
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* contracts: Use u64 as old weight type
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update frame/contracts/src/lib.rs
Co-authored-by: Alexander Theißen <alex.theissen@me.com >
---------
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: Koute <koute@users.noreply.github.com >
Co-authored-by: Alexander Theißen <alex.theissen@me.com >
Co-authored-by: parity-processbot <>
2023-04-04 18:57:21 +00:00
0766072393
Expose WASM extensions in executor semantics ( #13811 )
...
* Expose WASM extensions in executor semantics
* Fix benches
* Remove redundant extensions
2023-04-04 15:10:27 +00:00
1a55f961c6
Implement #[pallet::composite_enum] ( #13722 )
...
* Implement #[pallet::hold_reason]
* Appease clippy
* cargo fmt
* Update test expectations
* Update test expectations
* Support composite_enum attribute instead
* Update test expectations
* Change hold_reason to composite_enum
* Add UI test for unsupported identifier when using composite_enum
* Fix comment
* Add documentation for pallet::composable_enum
* More docs
* cargo fmt
2023-04-04 12:28:46 +00:00
c268f3d3c8
Update documentation for uniques (This PR renames classes and instances to collections and items in the Uniques pallet in order to follow the commonly accepted NFTs terminology.) ( #13322 )
...
* Update documentation for uniques
The documentation was outdated after merge of #11389
Using the widely spread term collections and item instead
of the previous class and instance.
* Update README.md
---------
Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com >
Co-authored-by: Jegor Sidorenko <jegor@parity.io >
2023-04-04 11:42:46 +00:00
07dcd47d59
Uniform pallet warnings ( #13798 )
...
* Use proc-macro-warning crate
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fixup
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix pallet_ui tests
Also renamed some of the odd-named ones.
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update dep
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Ignore hardcoded weight warning
To be fixed in https://github.com/paritytech/substrate/issues/13813
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix test pallet
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix more tests
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
---------
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: parity-processbot <>
2023-04-04 11:32:10 +00:00
846ec8cd01
Remove deprecated batch verification ( #13799 )
...
This removes the deprecated batch verification. This was actually never really activated.
Nevertheless, we need to keep the host functions around to support old runtimes which may import
these host functions. However, we do not give access to these functions anymore. This means that any new
runtime can not call them anymore. The host function implementations we keep will not do batch verification and will
instead fall back to the always existing option of directly verifying the passed signature.
`finish_batch_verification` will return the combined result of all the batch verify calls.
This removes the `TaskExecutorExt` which only existed to support the batch verification. So, any
code that used this extension can just remove the registration of them. It also removes
`SignatureBatching` that was used by `frame-executive` to control the batch verification.
However, there wasn't any `Verify` implementation that called the batch verification functions.
2023-04-04 10:02:47 +00:00
74bbae6901
refactor: inconsistent BalanceConversion fn ( #13610 )
...
* refactor: inconsistent BalanceConversion fn
* Revert "refactor: inconsistent BalanceConversion fn"
This reverts commit 1177877631a11b64df6f019b5390a8a7018e3a3f.
* refactor: rename BalanceConversion trait
* feat: add ConversionFromAssetBalance
2023-04-04 07:40:30 +00:00
795fcf0484
Disable sign-ext WASM feature when building runtimes ( #13804 )
...
Co-authored-by: parity-processbot <>
2023-04-03 12:00:31 +00:00
e524bf0e30
Scheduler pre block limit note ( #13231 )
...
Co-authored-by: parity-processbot <>
2023-04-03 10:59:01 +00:00
7e3e3db282
Force upgrade snow to 0.9.2 ( #13806 )
...
This fixes the compilation on master for the node template that was not pulling the latest release
as part of its build.
2023-04-03 11:37:18 +02:00
77fbb82b6b
Adjustments to RPC-query docstrings. ( #13698 )
...
* Changes in RPC docs.
* ".git/.scripts/commands/fmt/fmt.sh"
---------
Co-authored-by: command-bot <>
2023-04-03 10:36:28 +02:00
d997103476
FRAME: Minor fix for failsafe. ( #13741 )
...
* max instead of min
* Remove debug stuff
* remove debug code
* warn log on no provider ref
* format string for log
---------
Co-authored-by: muharem <ismailov.m.h@gmail.com >
2023-04-01 23:59:37 +02:00
197b8d6571
add claim_commission weight ( #13774 )
2023-04-01 17:19:12 +00:00
8d802eece0
contracts: make test work with debugger ( #13776 )
...
* contracts: make test work with debugger
* fix path
* PR review
* Add comment
* space
* Update frame/contracts/src/tests.rs
* lint
* spelling
2023-03-31 19:44:29 +02:00
2a44372ea1
Refactor: extract most aura logic out to standalone module, make use of these ( #13764 )
...
* Extract most aura logic out to standalone module, make use of these
* Update client/consensus/aura/src/standalone.rs
improve docs
Co-authored-by: Bastian Köcher <git@kchr.de >
* add slot_duration_at
* ".git/.scripts/commands/fmt/fmt.sh"
---------
Co-authored-by: Bastian Köcher <git@kchr.de >
Co-authored-by: parity-processbot <>
2023-03-31 14:00:07 +02:00
1bd5d2f78d
[Contracts] Overflowing bounded DeletionQueue allows DoS against contract termination ( #13702 )
...
* [Contracts review] Overflowing bounded `DeletionQueue` allows DoS against contract termination
* wip
* wip
* wip
* wip
* wip
* fix doc
* wip
* PR review
* unbreak tests
* fixes
* update budget computation
* PR comment: use BlockWeights::get().max_block
* PR comment: Update queue_trie_for_deletion signature
* PR comment: update deletion budget docstring
* PR comment: impl Default with derive(DefaultNoBound)
* PR comment: Remove DeletedContract
* PR comment Add ring_buffer test
* remove missed comment
* misc comments
* contracts: add sr25519_recover
* Revert "contracts: add sr25519_recover"
This reverts commit d4600e00934b90e5882cf5288f36f98911b51722.
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_contracts
* PR comments update print_schedule
* Update frame/contracts/src/benchmarking/mod.rs
* Update frame/contracts/src/storage.rs
* Update frame/contracts/src/storage.rs
* rm temporary fixes
* fix extra ;
* Update frame/contracts/src/storage.rs
Co-authored-by: juangirini <juangirini@gmail.com >
* Update frame/contracts/src/storage.rs
Co-authored-by: Alexander Theißen <alex.theissen@me.com >
* Update frame/contracts/src/lib.rs
Co-authored-by: Alexander Theißen <alex.theissen@me.com >
* Update frame/contracts/src/lib.rs
Co-authored-by: Alexander Theißen <alex.theissen@me.com >
* Support stable rust for compiling the runtime (#13580 )
* Support stable rust for compiling the runtime
This pull request brings support for compiling the runtime with stable Rust. This requires at least
rust 1.68.0 to work on stable. The code is written in a way that it is backwards compatible and
should automatically work when someone compiles with 1.68.0+ stable.
* We always support nightlies!
* 🤦
* Sort by version
* Review feedback
* Review feedback
* Fix version parsing
* Apply suggestions from code review
Co-authored-by: Koute <koute@users.noreply.github.com >
---------
Co-authored-by: Koute <koute@users.noreply.github.com >
* github PR commit fixes
* Revert "Support stable rust for compiling the runtime (#13580 )"
This reverts commit 0b985aa5ad114a42003519b712d25a6acc40b0ad.
* Restore DeletionQueueMap
* fix namings
* PR comment
* move comments
* Update frame/contracts/src/storage.rs
* Update frame/contracts/src/storage.rs
* fixes
---------
Co-authored-by: command-bot <>
Co-authored-by: juangirini <juangirini@gmail.com >
Co-authored-by: Alexander Theißen <alex.theissen@me.com >
Co-authored-by: Bastian Köcher <git@kchr.de >
Co-authored-by: Koute <koute@users.noreply.github.com >
2023-03-31 11:03:56 +00:00
2f3a8b9e38
bump zombienet version ( #13772 )
2023-03-30 23:01:50 +02:00
5d5cc9a007
sp-runtime-interface-test: Fix flaky test ( #13770 )
2023-03-30 21:31:08 +02:00
95da8d7ace
Fix nomiantion pools doc render ( #13748 )
...
Co-authored-by: parity-processbot <>
2023-03-30 16:50:45 +02:00
92c1229e24
BEEFY: gossip finality proofs ( #13727 )
...
* sc-consensus-beefy: add justifications to gossip protocol
* sc-consensus-beefy: voter gossips finality proofs
* sc-consensus-beefy: add finality proof gossip test
* sc-consensus-beefy: always gossip finality proof
Gossip finality proof in _both_ cases of reaching finality threshold
through votes:
1. threshold reached through self vote,
2. threshold reached through incoming vote.
* address comments
2023-03-30 17:23:36 +03:00
25a616ce08
Build wasm for mvp cpu ( #13758 )
2023-03-30 16:20:12 +02:00
cc3152bc2f
[Enhancement] Throw an error when there are too many pallets ( #13763 )
...
* [Enhancement] Throw an error when there are too many pallets
* fix ui test
* fix PR comments
* Update frame/support/procedural/src/construct_runtime/mod.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* Update frame/support/procedural/src/construct_runtime/mod.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* ".git/.scripts/commands/fmt/fmt.sh"
---------
Co-authored-by: Bastian Köcher <git@kchr.de >
Co-authored-by: command-bot <>
2023-03-30 14:53:47 +02:00
4240490d1d
Attempt to relieve pressure on mpsc_network_worker ( #13725 )
...
* Attempt to relieve pressure on `mpsc_network_worker`
`SyncingEngine` interacting with `NetworkWorker` can put a lot of strain
on the channel if the number of inbound connections is high. This is
because `SyncingEngine` is notified of each inbound substream which it
then can either accept or reject and this causes a lot of message
exchange on the already busy channel.
Use a direct channel pair between `Protocol` and `SyncingEngine`
to exchange notification events. It is a temporary change to alleviate
the problems caused by syncing being an independent protocol and the
fix will be removed once `NotificationService` is implemented.
* Apply review comments
* fixes
* trigger ci
* Fix tests
Verify that both peers have a connection now that the validation goes
through `SyncingEngine`. Depending on how the tasks are scheduled,
one of them might not have the peer registered in `SyncingEngine` at which
point the test won't make any progress because block announcement received
from an unknown peer is discarded.
Move polling of `ChainSync` at the end of the function so that if a block
announcement causes a block request to be sent, that can be sent in the
same call to `SyncingEngine::poll()`.
---------
Co-authored-by: parity-processbot <>
2023-03-30 11:59:58 +00:00
7985495b8c
Application Crypto cleanup ( #13746 )
...
* Adjust application crypto docs
* Blanket implementation for 'RuntimeAppPublic' trait
* Blanket implementation for 'BoundToRuntimeAppPublic' for 'RuntimeAppPublic'
* Relax type bounds
* Docs fix
* restore MaybeHash
* Commit suggestion
Co-authored-by: Anton <anton.kalyaev@gmail.com >
---------
Co-authored-by: Anton <anton.kalyaev@gmail.com >
2023-03-30 10:30:35 +02:00
29e31f2b0a
Generic keystore internals ( #13749 )
...
* Generic testing keystore internals
* Generic local keystore internals
* Restore deleted comment
2023-03-30 01:22:34 +02:00
c91b5b5b21
[Fix] Bump tuple element number in frame-support. ( #13760 )
...
That is to avoid hitting the pallet limit that emits a cryptic error. More detail could be found here: https://substrate.stackexchange.com/questions/7212 .
Co-authored-by: parity-processbot <>
2023-03-29 20:30:15 +00:00
212d6a5a6f
Clean up after debian 11 rollout ( #13762 )
...
This reverts commit 86d638d08f
2023-03-29 20:25:41 +02:00
469726ee74
proc-macro: check for non-args runtime calls added ( #13742 )
...
* proc-macro: check for non-args runtime calls added
* Update primitives/api/proc-macro/src/impl_runtime_apis.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
---------
Co-authored-by: Bastian Köcher <git@kchr.de >
Co-authored-by: parity-processbot <>
2023-03-29 14:54:02 +00:00
c32b240df0
Swap 'base58' with 'bs58' ( #13739 )
...
* Swap base58 with bs58
* Removed unused clone
* std flag
2023-03-29 15:46:05 +02:00
86d638d08f
roll out new debian 11 ci image ( #13744 )
2023-03-29 15:27:40 +02:00
f843b7f447
provide a default value for RELENG_SCRIPTS_BRANCH ( #13743 )
...
Currently this variable is configured exclusively via a project
variable, which makes it impossible to override for specific test prs.
2023-03-29 12:27:48 +02:00
d338e9a114
Support stable rust for compiling the runtime ( #13580 )
...
* Support stable rust for compiling the runtime
This pull request brings support for compiling the runtime with stable Rust. This requires at least
rust 1.68.0 to work on stable. The code is written in a way that it is backwards compatible and
should automatically work when someone compiles with 1.68.0+ stable.
* We always support nightlies!
* 🤦
* Sort by version
* Review feedback
* Review feedback
* Fix version parsing
* Apply suggestions from code review
Co-authored-by: Koute <koute@users.noreply.github.com >
---------
Co-authored-by: Koute <koute@users.noreply.github.com >
2023-03-29 07:17:50 +00:00
acec84cc1e
contracts: proper event link in docs ( #13729 )
2023-03-28 16:38:13 +02:00
9c9492476c
CI: rephrase RUSTFLAGS ( #13735 )
2023-03-28 15:41:10 +04:00
c41eadc090
Remove HeaderBackend requirement from AuthorityDiscovery and NetworkWorker ( #13730 )
...
* Remove `HeaderBackend` requirement from `NetworkWorker`
* Remove HeaderBackend from authority-discovery
2023-03-28 07:10:50 +00:00
551367d4cb
CI: Investigate why RUSTFLAGS differs on master and PRs ( #13686 )
2023-03-28 04:00:18 +04:00
7c18bc9dfd
updating labels descriptions ( #13557 )
...
* updating labels descriptions
* delete milestones
* Update docs/CONTRIBUTING.adoc
Co-authored-by: Bastian Köcher <git@kchr.de >
* link to label docs
* Update docs/CONTRIBUTING.adoc
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
---------
Co-authored-by: Bastian Köcher <git@kchr.de >
Co-authored-by: parity-processbot <>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
2023-03-27 23:27:16 +02:00
a59ea80cec
Change license of node-template and FRAME examples to MIT-0 ( #13465 )
...
* Change node-template license from Unlicense to MIT-0
* Change frame examples license from Unlicense to MIT-0
* Update bin/node-template/LICENSE
---------
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: parity-processbot <>
2023-03-27 22:36:20 +02:00
Aaro Altonen