d68868f64a
Fix clippy lints behind feature gates and add new CI step all features ( #2569 )
...
Many clippy lints usually enforced by `-Dcomplexity` and `-Dcorrectness`
are not caught by CI as they are gated by `features`, like
`runtime-benchmarks`, while the clippy CI job runs with only the default
features for all targets.
This PR also adds a CI step to run clippy with `--all-features` to
ensure the code quality is maintained behind feature gates from now on.
To improve local development, clippy lints are downgraded to warnings,
but they still will result in an error at CI due to the `-Dwarnings`
rustflag.
---------
Co-authored-by: Liam Aharon <liam.aharon@hotmail.com >
2023-12-20 16:30:10 +00:00
4ac9c4a364
rename benchmark ( #2173 )
...
A quick fix where a benchmark test was wrongly renamed in this PR
https://github.com/paritytech/polkadot-sdk/pull/1868
2023-11-06 12:54:37 +00:00
24840290af
Refactor alliance benchmarks to v2 ( #1868 )
...
- This PR refactors `alliance/src/benchmarkings.rs` to use benchmarking
v2. These changes are needed to improve the readability and
maintainability of the benchmarking code.
- No known issue to backlink.
## Local Testing
1. `cargo build --features runtime-benchmarks`
2. `cargo run --locked --release -p node-cli --bin substrate-node
--features runtime-benchmarks -- benchmark pallet --execution wasm
--wasm-execution compiled --chain dev --pallet "*" --extrinsic "*"
--steps 2 --repeat 1`
2023-10-13 21:54:45 +01:00
5e7b27e98c
Moves Block to frame_system instead of construct_runtime and removes Header and BlockNumber ( #14437 )
...
* Initial setup
* Adds node block
* Uses UncheckedExtrinsic and removes Where section
* Updates frame_system to use Block
* Adds deprecation warning
* Fixes pallet-timestamp
* Removes Header and BlockNumber
* Addresses review comments
* Addresses review comments
* Adds comment about compiler bug
* Removes where clause
* Refactors code
* Fixes errors in cargo check
* Fixes errors in cargo check
* Fixes warnings in cargo check
* Formatting
* Fixes construct_runtime tests
* Uses import instead of full path for BlockNumber
* Uses import instead of full path for Header
* Formatting
* Fixes construct_runtime tests
* Fixes imports in benchmarks
* Formatting
* Fixes construct_runtime tests
* Formatting
* Minor updates
* Fixes construct_runtime ui tests
* Fixes construct_runtime ui tests with 1.70
* Fixes docs
* Fixes docs
* Adds u128 mock block type
* Fixes split example
* fixes for cumulus
* ".git/.scripts/commands/fmt/fmt.sh"
* Updates new tests
* Fixes fully-qualified path in few places
* Formatting
* Update frame/examples/default-config/src/lib.rs
Co-authored-by: Juan <juangirini@gmail.com >
* Update frame/support/procedural/src/construct_runtime/mod.rs
Co-authored-by: Juan <juangirini@gmail.com >
* ".git/.scripts/commands/fmt/fmt.sh"
* Addresses some review comments
* Fixes build
* ".git/.scripts/commands/fmt/fmt.sh"
* Update frame/democracy/src/lib.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update frame/democracy/src/lib.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update frame/support/procedural/src/construct_runtime/mod.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update frame/support/procedural/src/construct_runtime/mod.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Addresses review comments
* Updates trait bounds
* Minor fix
* ".git/.scripts/commands/fmt/fmt.sh"
* Removes unnecessary bound
* ".git/.scripts/commands/fmt/fmt.sh"
* Updates test
* Fixes build
* Adds a bound for header
* ".git/.scripts/commands/fmt/fmt.sh"
* Removes where block
* Minor fix
* Minor fix
* Fixes tests
* ".git/.scripts/commands/update-ui/update-ui.sh" 1.70
* Updates test
* Update primitives/runtime/src/traits.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* Update primitives/runtime/src/traits.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* Updates doc
* Updates doc
---------
Co-authored-by: command-bot <>
Co-authored-by: Juan <juangirini@gmail.com >
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: Bastian Köcher <git@kchr.de >
2023-07-13 12:01:34 +00:00
9b9964394e
chore: reduce copy times for bytes in core-hashing ( #13519 )
...
* chore: reduce copy bytes for core-hashing
* improve by suggestions and remove unused `xx_into`
* chore: replace sha2 crate by `sp_core::hashing` for pallet-alliance
* fix features
* use sp-core-hashing directly
* add to dev-dep
2023-03-06 14:09:07 +00:00
bc53b9a03a
Remove years from copyright notes. ( #13415 )
...
* Change copyright year to 2023 from 2022
* Fix incorrect update of copyright year
* Remove years from copy right header
* Fix remaining files
* Fix typo in a header and remove update-copyright.sh
2023-02-21 18:46:41 +00:00
3079a17c94
Benchmark's successful origin api update ( #13146 )
...
* try successful origin unimplemented by default
* error as a default impl for try_successful_origin
* remove successful_origin func of EnsureOrigin trait
* default impl -> unimplemented!()
* update EnsureOriginWithArg
* fix EnsureOriginWithArg
* prefix unused arg with underscore
* use try_successful_origin instead successful_origin, map err to Weightless
* fix tests
* remove default impl
* unwrap for indirect origin dep
* replace unwrap by expect with a message
---------
Co-authored-by: parity-processbot <>
2023-02-01 03:11:41 +01:00
c9361bed1a
migrate new benchmarking syntax from frame_support::benchmarking to frame_benchmarking::v2 ( #13235 )
...
* * re-export frame_support::benchmarking in frame_benchmarking::
* prefer use frame_benchmarking::*; in examples, etc
* switch to frame_benchmarking::v2
* completely migrate new benchmarking code out of frame_support
* fix doc links
* remove unneeded return
Co-authored-by: Bastian Köcher <git@kchr.de >
* remove another unneeded return
Co-authored-by: Bastian Köcher <git@kchr.de >
* properly export all macros in v1
* refactor existing frame_benchmarking imports to use ::v1
---------
Co-authored-by: Bastian Köcher <git@kchr.de >
2023-01-27 20:59:39 +00:00
bcea0d7e7f
Allow Alliance Fellows to Give Up Voting Rights ( #12730 )
...
* allow fellows to abdicate voting rights
* rename founders to founding fellows, give equal power
* Drop FoundingFellow role and veto call (#12762 )
* drop FoundingFellow role
* drop veto call
* Storage migration to remove founder role (#12766 )
* storage migration to remove founder role
* skip migration if no members
* truncate the final fellows set if overflows
* change log - action order
* MemberAbdicated -> FellowAbdicated
Co-authored-by: Muharem Ismailov <ismailov.m.h@gmail.com >
2022-11-25 14:52:26 +00:00
eee79a1fa4
Extend the lower bounds of some of the benchmarks to also include 0 ( #12386 )
...
* Extend the lower bounds of some of the benchmarks to also include `0`
* Fix verify snippet for `pallet_bounties/spend_funds`
2022-10-07 14:16:41 +00:00
6e8795afe6
BREAKING: Rename Call & Event ( #11981 )
...
* rename Event to RuntimeEvent
* rename Call
* rename in runtimes
* small fix
* rename Event
* small fix & rename RuntimeCall back to Call for now
* small fixes
* more renaming
* a bit more renaming
* fmt
* small fix
* commit
* prep for renaming associated types
* fix
* rename associated Event type
* rename to RuntimeEvent
* commit
* merge conflict fixes & fmt
* additional renaming
* fix.
* fix decl_event
* rename in tests
* remove warnings
* remove accidental rename
* .
* commit
* update .stderr
* fix in test
* update .stderr
* TRYBUILD=overwrite
* docs
* fmt
* small change in docs
* rename PalletEvent to Event
* rename Call to RuntimeCall
* renamed at wrong places :P
* rename Call
* rename
* rename associated type
* fix
* fix & fmt
* commit
* frame-support-test
* passing tests
* update docs
* rustdoc fix
* update .stderr
* wrong code in docs
* merge fix
* fix in error message
* update .stderr
* docs & error message
* .
* merge fix
* merge fix
* fmt
* fmt
* merge fix
* more fixing
* fmt
* remove unused
* fmt
* fix
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com >
2022-09-12 22:03:31 +00:00
f919894c84
Alliance pallet: split force_set_members call ( #12179 )
...
* Alliance pallet: split force_set_members call
* use counts for event
* ".git/.scripts/bench-bot.sh" pallet dev pallet_alliance
Co-authored-by: command-bot <>
2022-09-05 15:08:50 +00:00
a9a2fdca7b
Alliance pallet: fix func name, fix migration weights ( #12174 )
...
* Alliance pallet: fix func name, fix migration weights
* update comment order
2022-09-02 18:54:30 +02:00
d8e951758c
Alliance pallet: add force_set_members instead of init_members function ( #11997 )
...
* Alliance pallet: add force_set_members instead of init_members function
* benchmark with witness data
* remove invalid limit for clear
* Apply suggestions from code review
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
* Revert "remove invalid limit for clear"
This reverts commit dba54e3071b63bfea908087aef213f4640e3ccbf.
* compile constructor only for test
* Update comments for force_set_members
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
* Apply suggestions from code review
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
* ".git/.scripts/bench-bot.sh" pallet dev pallet_alliance
* benchmark - founders count range
* Revert "benchmark - founders count range"
This reverts commit aad16796f8dfed48079fb7f587b8f5b59382cda6.
* witness members count instead votable members count
* update the doc
* use decode_len for witness data checks
* change witness data member count to voting member count; update clear limits
* ".git/.scripts/bench-bot.sh" pallet dev pallet_alliance
* merge master
* fixes after merge master
* revert to cb3e63
* disband alliance and return deposits
* revert debug changes
* weights
* update docs
* update test comments
* Apply Joe suggestions from code review
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
* rename event from AllianceDisband to AllianceDisbanded
* ".git/.scripts/bench-bot.sh" pallet dev pallet_alliance
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
Co-authored-by: command-bot <>
2022-09-01 10:31:32 +00:00
30951822ba
Weight v1.5: Opaque Struct ( #12138 )
...
* initial idea
* update frame_support
* update a bunch more
* add ord
* adjust RuntimeDbWeight
* frame_system builds
* re-export
* frame_support tests pass
* frame_executive compile
* frame_executive builds
* frame_system tests passing
* pallet-utility tests pass
* fix a bunch of pallets
* more
* phragmen
* state-trie-migration
* scheduler and referenda
* pallet-election-provider-multi-phase
* aura
* staking
* more
* babe
* balances
* bunch more
* sudo
* transaction-payment
* asset-tx-payment
* last pallets
* fix alliance merge
* fix node template runtime
* fix pallet-contracts cc @athei
* fix node runtime
* fix compile on runtime-benchmarks feature
* comment
* fix frame-support-test
* fix more tests
* weight regex
* frame system works
* fix a bunch
* more
* more
* more
* more
* more
* more fixes
* update templates
* fix contracts benchmarks
* Update lib.rs
* Update lib.rs
* fix ui
* make scalar saturating mul const
* more const functions
* scalar div
* refactor using constant functions
* move impl
* fix overhead template
* use compactas
* Update lib.rs
2022-08-31 11:26:13 +00:00
b74fba5dac
Alliance pallet: retirement notice call ( #11970 )
...
* Alliance pallet: retirement notice
* add alliance pallet to benchmark list for dev chain
* fix type
* ".git/.scripts/bench-bot.sh" pallet dev pallet_alliance
* ".git/.scripts/bench-bot.sh" pallet dev pallet_alliance
* link weight generated by bench for retirement_notice method
* migration to clear UpForKicking storage prefix
* rename migration from v1 to v0_to_v1
* Apply suggestions from code review
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
* rename `retirement-notice to give-retirement-notice
* Apply suggestions from code review
Co-authored-by: Squirrel <gilescope@gmail.com >
* review fixes: update doc, saturating add, BlockNumber type alias
* add suffix to duratin consts *_IN_BLOCKS
* ".git/.scripts/bench-bot.sh" pallet dev pallet_alliance
* add negative tests (#11995 )
* add negative tests
* remove tests powerless asserts checking against announcment origin
* assert bad origin from announcement origin checks
Co-authored-by: muharem <ismailov.m.h@gmail.com >
Co-authored-by: command-bot <>
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
Co-authored-by: Squirrel <gilescope@gmail.com >
2022-08-29 16:02:23 +00:00
d46f6f0d34
Replace T::AccountId with <T::Lookup as StaticLookup>::Source ( #11670 )
...
* initial
* update
* update
* update
* cargo fmt
* update
* update benchmarks
* AccountIdLookupOf<T>
* cargo fmt
* fix conflits
* cargo fmt
* update
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
2022-08-18 09:30:46 +00:00
5788461196
pallet alliance ( #11112 )
...
* Add pallet-alliance
Signed-off-by: koushiro <koushiro.cqx@gmail.com >
* Update multihash/cid and format
Signed-off-by: koushiro <koushiro.cqx@gmail.com >
* Remove useless deps
Signed-off-by: koushiro <koushiro.cqx@gmail.com >
* Add pallet-alliance into node runtime
Signed-off-by: koushiro <koushiro.cqx@gmail.com >
* Fix has_identity
Signed-off-by: koushiro <koushiro.cqx@gmail.com >
* Add TooMantBlacklist Error
Signed-off-by: koushiro <koushiro.cqx@gmail.com >
* Add TooLongWebsiteUrlLength Error
Signed-off-by: koushiro <koushiro.cqx@gmail.com >
* Add remove_announcement
Signed-off-by: koushiro <koushiro.cqx@gmail.com >
* Derive pallet_identity::Config and Fix test/benchmarking
Signed-off-by: koushiro <koushiro.cqx@gmail.com >
* Add part weight for call of pallet-alliance
Signed-off-by: koushiro <koushiro.cqx@gmail.com >
* Remove pallet_identity Config trait
Signed-off-by: koushiro <koushiro.cqx@gmail.com >
* Fix propose arguments
Signed-off-by: koushiro <koushiro.cqx@gmail.com >
* Some nits
Signed-off-by: koushiro <koushiro.cqx@gmail.com >
* cargo fmt
Signed-off-by: koushiro <koushiro.cqx@gmail.com >
* Fix benchmarking of add_blacklist/remove_blacklist
Signed-off-by: koushiro <koushiro.cqx@gmail.com >
* Some nits
Signed-off-by: koushiro <koushiro.cqx@gmail.com >
* Add benchmarking for init_members
Signed-off-by: koushiro <koushiro.cqx@gmail.com >
* Add benchmarking for propose/vote/veto
Signed-off-by: koushiro <koushiro.cqx@gmail.com >
* Fix benchmarking
Signed-off-by: koushiro <koushiro.cqx@gmail.com >
* Remove some useless
Signed-off-by: koushiro <koushiro.cqx@gmail.com >
* fix some compile issue
* more fix
* all checks
* refactor
* refactor event
* refactor
* cleanup
* cleanup
* fix benchmarking
* fix warning
* fmt
* fix benchmarks
* with storage info
* fmt
* add new config
* fix benchmarks
* fix
* fmt
* Apply suggestions from code review
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* improvements
* fix
* update docs
* rename events, errors, and functions
* make kicking events clearer
* fix
* fix tests
* fix tests
* fix runtime
* fix build
* remove unneeded change
* remove Candidate role from Alliance
* fmt grumbles
* update lock
* update recursion limit
* benchmarks
* convert-try
* benchmark assertions
* fmt ,
* cargo lock
* Update frame/alliance/src/benchmarking.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* Apply suggestions from code review
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* add docs to public interfaces
* Apply suggestions from code review
Co-authored-by: Squirrel <gilescope@gmail.com >
* fix build (node)
* review
* use EitherOfDiverse
* update cargo toml
* make all dispatch class Normal
* change blacklist to unscrupulous
* formatting
* fmt oops
* rename benchmarking unscrupulous account creator
Co-authored-by: koushiro <koushiro.cqx@gmail.com >
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
Co-authored-by: joepetrowski <joe@parity.io >
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
Co-authored-by: Squirrel <gilescope@gmail.com >
2022-06-10 18:39:26 +00:00
Dónal Murray