a30092ab42
Markdown linter ( #1309 )
...
* Add markdown linting
- add linter default rules
- adapt rules to current code
- fix the code for linting to pass
- add CI check
fix #1243
* Fix markdown for Substrate
* Fix tooling install
* Fix workflow
* Add documentation
* Remove trailing spaces
* Update .github/.markdownlint.yaml
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix mangled markdown/lists
* Fix captalization issues on known words
2023-09-04 12:02:32 +03:00
f1c16d05e7
Update Reference Hardware Specs ( #13317 )
...
* Remove Polkadot Wiki
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update requirements for new ref hardware
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add test
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
---------
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: parity-processbot <>
2023-06-28 21:16:55 +00:00
bc53b9a03a
Remove years from copyright notes. ( #13415 )
...
* Change copyright year to 2023 from 2022
* Fix incorrect update of copyright year
* Remove years from copy right header
* Fix remaining files
* Fix typo in a header and remove update-copyright.sh
2023-02-21 18:46:41 +00:00
5ccd9bfc5a
Warn validators with slow hardware ( #12620 )
...
* move Metric
* run hardware bench if validiator flag is being used
* fix rustdoc & update node-template
* fix
* unused improt
* warn
* move Requirement
* bench_result
* ensure_requirements
* make the code compile
* check if authority
* Update client/sysinfo/src/sysinfo.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* nit fixes
* warning signs
* Update client/sysinfo/src/sysinfo.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
2023-01-20 20:26:12 +01:00
65b285e632
Move Throughput into sc-sysinfo ( #12368 )
...
* move Throughput to sc-sysinfo
* replace u64
* fix in tests
* change Throughput
* refactored Throughput
* fixes
* moved tests & fixes
* custom serializer
* note
* fix serializer
* forgot to remove
* deserialize
* functioning deserialization :)
* try to make clipply happy
* Serialize as function
* test HwBench
* rename
* fix serialization
* deserialize as function
* unused import
* move serialize/deserialize
* don't serialize none
* remove nonsense
* remove nonsense comment :P
* fixes
* remove all the todos
* return enum
* fixes
* fix nit
* improve docs & readability
* Update client/sysinfo/src/sysinfo.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* fix all the nits
* rename
* fix
* Update client/sysinfo/src/sysinfo.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* remove unit from serialization
* Update utils/frame/benchmarking-cli/src/machine/hardware.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
2022-11-04 17:13:57 +00:00
f687db40f7
Bump clap to 4.0.x and adjust to best practices ( #12381 )
...
* Bump clap to 3.2.22
* Replace `from_os_str` with `value_parser`
* Replace `from_str` and `try_from_str` with `value_parser`
* Move possible_values to the new format
* Remove unwanted print
* Add missing match branch
* Update clap to 4.0.9 and make it compile
* Replace deprecated `clap` macro with `command` and `value`
* Move remaining `clap` attributes to `arg`
* Remove no-op value_parsers
* Adjust value_parser for state_version
* Remove "deprecated" feature flag and bump to 4.0.11
* Improve range
Co-authored-by: Bastian Köcher <git@kchr.de >
* Apply suggestions
* Trigger CI
* Fix unused error warning
* Fix doc errors
* Fix ArgGroup naming conflict
* Change default_value to default_value_t
* Use 1.. instead of 0..
Co-authored-by: Bastian Köcher <git@kchr.de >
2022-10-18 06:52:46 +00:00
113727950b
Fuzz testing for nomination pools ( #12002 )
...
* some additional tests and stuff
* make sanity public
* add some sort of fuzz test for pools
* breaks every now and then
* breaks every now and then
* IT WORKS AND PASSES 100k TESTS
* cleanup
* safe id addition
* fix assert_eq_error_rate
* Update frame/nomination-pools/src/tests.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update frame/nomination-pools/src/tests.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* add some doc
* Fix
* ".git/.scripts/fmt.sh" 1
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: command-bot <>
2022-09-12 14:27:11 +00:00
29474f9893
Document benchmarking CLI ( #11246 )
...
* Decrese default repeats
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add benchmarking READMEs
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update docs
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update docs
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update README
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Review fixes
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com >
Co-authored-by: parity-processbot <>
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com >
2022-05-25 03:47:21 +00:00
8f78f4bb89
Migrate abandoned prettytable-rs to comfy-table ( #11430 )
...
* Migrate to comfy-table
Signed-off-by: koushiro <koushiro.cqx@gmail.com >
* disable the default features
Signed-off-by: koushiro <koushiro.cqx@gmail.com >
2022-05-17 16:38:51 +00:00
32d6d1b37c
More benchmark machine args ( #11428 )
...
* Add ExecutionLimits to sc-sysinfo and return float
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Increase benchmarking duration and add options
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix tests
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix tests
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
2022-05-17 13:57:08 +00:00
9980d314b1
Follow ups for benchmark machine ( #11270 )
...
* Follow ups for the MachineCmd
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix CI
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Review fixes
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add to node-template
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix test with feature flag
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Review fixes
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Lower disk requirements
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add ExecutionLimit to the disk benchmarks
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* fmt
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add doc
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Review fixes
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Rename DISK_WRITE_LIMIT -> DEFAULT_DISK_EXECUTION_LIMIT
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Rename POLKADOT_REFERENCE_HARDWARE -> SUBSTRATE_REFERENCE_HARDWARE
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix build profile + add license
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Remove deps
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Set tolerance to 10%
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix tests
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Ignore test
I cannot reproduce the CI error, even with the full command:
cargo test --workspace --locked --release --verbose --features runtime-benchmarks --manifest-path ./bin/node/cli/Cargo.toml
I will put an 'ignore' on that test for now, since it works for me and is worth having.
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Remove test
Still cannot reproduce the error and it fails in the CI.
Removing it now.
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com >
2022-04-26 14:31:26 +00:00
362dc50940
Add benchmark machine placeholder ( #11198 )
...
* Move new_rng to shared code
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add bechmark machine command
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Use sc-sysinfo
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add --no-hardware-benchmarks
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Lockfile
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Do not create components if not needed
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix tests
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Revert "Add --no-hardware-benchmarks"
This reverts commit d4ee98222bf1a5ea62ac60dd7d5c62070e2d7f70.
* Fix tests
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update Cargo deps
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Move sr255119::verify bench to sc-sysinfo
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Move sr255119::verify bench to sc-sysinfo
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Switch benchmarks to return f64
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Review fixes
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* fmt
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Hide command until completed
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Use concrete rand implementation
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Put clobber into a function
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add test
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add comment
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update cargo to match polkadot
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Remove doc that does not format in the console
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Limit benchmark by time
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add ExecutionLimit and make function infallible
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* CI
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add doc
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
2022-04-15 12:09:16 +00:00
Chevdor