342d720573
Use same fmt and clippy configs as in Substrate ( #7611 )
...
* Use same rustfmt.toml as Substrate
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* format format file
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Format with new config
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add Substrate Clippy config
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Print Clippy version in CI
Otherwise its difficult to reproduce locally.
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Make fmt happy
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update node/core/pvf/src/error.rs
Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io >
* Update node/core/pvf/src/error.rs
Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io >
---------
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io >
2023-08-14 14:29:29 +00:00
2802414473
Moves Block to frame_system instead of construct_runtime and removes Header and BlockNumber ( #7431 )
...
* Companion for substrate
* Minor update
* Formatting
* Fixes for cumulus
* Fixes tests in polkadot-runtime-parachains
* Minor update
* Removes unused import
* Fixes tests in polkadot-runtime-common
* Minor fix
* Update roadmap/implementers-guide/src/runtime/configuration.md
Co-authored-by: ordian <write@reusable.software >
* ".git/.scripts/commands/fmt/fmt.sh"
* update lockfile for {"substrate"}
---------
Co-authored-by: ordian <write@reusable.software >
Co-authored-by: command-bot <>
2023-07-13 12:37:50 +00:00
596a9ccd02
Unify code paths of create_inherent and enter ( #7137 )
...
* Remove redundant enter call.
* Remove optionality in dispute signature checking
* Make enter_inner and create_inherent the same.
* Remove redundant metric.
* Unification: enter and create_inherent.
* Remove `enter_inner` function.
* Remove dead code.
* Remove redundant import.
* Remove dead code in disputes.
* ".git/.scripts/commands/bench/bench.sh" runtime polkadot runtime_parachains::paras_inherent
* ".git/.scripts/commands/bench/bench.sh" runtime kusama runtime_parachains::paras_inherent
* ".git/.scripts/commands/bench/bench.sh" runtime westend runtime_parachains::paras_inherent
* Merge fix.
* Fix tests.
* Remove obsolete comment.
* ".git/.scripts/commands/bench/bench.sh" runtime polkadot runtime_parachains::paras_inherent
* ".git/.scripts/commands/bench/bench.sh" runtime westend runtime_parachains::paras_inherent
* ".git/.scripts/commands/bench/bench.sh" runtime kusama runtime_parachains::paras_inherent
* Review remarks, fixes.
* Guide updates.
* Fmt.
* ".git/.scripts/commands/bench/bench.sh" runtime polkadot runtime_parachains::paras_inherent
---------
Co-authored-by: eskimor <eskimor@no-such-url.com >
Co-authored-by: command-bot <>
2023-06-14 10:57:06 +02:00
9e4bca6895
Freeze chain if there are byzantine threshold + 1 invalid votes against a local candidate ( #7225 )
2023-05-17 18:29:20 +00:00
676bb648d2
Ensure all StorageVersions on Polkadot/Kusama are correct ( #7199 )
...
* Yeah
* Fix all the migrations for Kusama & Polkadot
---------
Co-authored-by: Liam Aharon <liam.aharon@hotmail.com >
2023-05-17 14:53:01 +00:00
64660ee8d2
Remove years from copyright notes ( #7034 )
...
* Happy New Year!
* Remove year entierly
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Remove years from copyright notice in the entire repo
---------
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
2023-04-08 20:38:35 +00:00
22f404f092
Histogram support in runtime metrics ( #6935 )
...
* Histogram support in runtime metrics
Add support for histograms to the runtime metrics. Additionally add
`polkadot_parachain_verify_dispute_signature` histogram which tracks the
time needed from the runtime to verify a single validator signature of a
dispute statement.
* Add noops
* u64 instead of f64
* Update buckets
* Wrap `get_current_time()` in runtime metrics
* Change the dimension of the Histogram from usec to sec
* Fix a compilation error
* Update buckets
* Fix `on_signature_check_complete` calculation
* Update buckets
* Update buckets
* formatting
* Another weights update
* Adjust buckets again
* Final buckets adjustment
* Revert "Fix a compilation error"
This reverts commit 06290b40a39eeb78de2602d8916a39edf7a8b714.
* Update primitives/src/v4/metrics.rs
Co-authored-by: Andrei Sandu <54316454+sandreim@users.noreply.github.com >
* Use `saturating_sub` for time difference calculation
* Pass nanoseconds to client instead of seconds (using f64 in runtime is dangerous)
---------
Co-authored-by: Andrei Sandu <54316454+sandreim@users.noreply.github.com >
2023-03-28 13:37:19 +00:00
bd209c2d70
inherent disputes: remove per block initializer and disputes timeout event ( #6937 )
...
* Limit disputes weight and remove initializer code
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* const
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* remove timeout test
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* review feedback #1
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Remove the new weight limiting for disputes
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* cargo lock
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Remove dispute_conclusion_by_time_out_period
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Enable migrations
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Update guide
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Fix comment
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* More guide fixes
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Also migrate pending configs
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* fix build
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* fix test
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
---------
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
2023-03-24 12:48:56 +01:00
508f3bd19a
parachains-runtime: Less cloning! ( #6896 )
...
* parachains-runtime: Less cloning!
* Fix tests
* FMT
2023-03-16 18:56:52 +00:00
2fa8565f9d
Some late short-term fixes for dispute slashing ( #6249 )
...
* disputes/slashing: slash only backers for ForInvalid
* add an assertion in mock impl
* fix tests
* do not slash backers on onconcluded disputes
* slash an intersection of backers and losers
* zombienet/disputes: check for offence only for invalid disputes
* add backing votes to disputes bench builder
* Update runtime/parachains/src/builder.rs
* Brad implementers guide revisions 2 (#6239 )
* Add disputes subsystems fix
* Updated dispute approval vote import reasoning
* Improved wording of my changes
* Resolving issues brought up in comments
* Update disputes prioritisation in `dispute-coordinator` (#6130 )
* Scraper processes CandidateBacked events
* Change definition of best-effort
* Fix `dispute-coordinator` tests
* Unit test for dispute filtering
* Clarification comment
* Add tests
* Fix logic
If a dispute is not backed, not included and not confirmed we
don't participate but we do import votes.
* Add metrics for refrained participations
* Revert "Add tests"
This reverts commit 7b8391a087922ced942cde9cd2b50ff3f633efc0.
* Revert "Unit test for dispute filtering"
This reverts commit 92ba5fe678214ab360306313a33c781338e600a0.
* fix dispute-coordinator tests
* Fix scraping
* new tests
* Small fixes in guide
* Apply suggestions from code review
Co-authored-by: Andrei Sandu <54316454+sandreim@users.noreply.github.com >
* Fix some comments and remove a pointless test
* Code review feedback
* Clarification comment in tests
* Some tests
* Reference counted `CandidateHash` in scraper
* Proper handling for Backed and Included candidates in scraper
Backed candidates which are not included should be kept for a
predetermined window of finalized blocks. E.g. if a candidate is backed
but not included in block 2, and the window size is 2, the same
candidate should be cleaned after block 4 is finalized.
Add reference counting for candidates in scraper. A candidate can be
added on multiple block heights so we have to make sure we don't clean
it prematurely from the scraper.
Add tests.
* Update comments in tests
* Guide update
* Fix cleanup logic for `backed_candidates_by_block_number`
* Simplify cleanup
* Make spellcheck happy
* Update tests
* Extract candidate backing logic in separate struct
* Code review feedback
* Treat backed and included candidates in the same fashion
* Update some comments
* Small improvements in test
* spell check
* Fix some more comments
* clean -> prune
* Code review feedback
* Reword comment
* spelling
Co-authored-by: Andrei Sandu <54316454+sandreim@users.noreply.github.com >
* approval-voting: remove redundant validation check (#6266 )
* approval-voting: remove a redundant check
* candidate-validation: remove unreachable check
* remove fill_block (#6200 )
Co-authored-by: parity-processbot <>
* fix a compilation warning (#6279 )
Fixes #6277 .
* Only report concluded if there is an actual dispute. (#6270 )
* Only report concluded if there is an actual dispute.
Hence no "non"-disputes will be added to disputes anymore.
* Fix redundant check.
* Test for no onesided disputes.
Co-authored-by: eskimor <eskimor@no-such-url.com >
* [ci] fix buildah image (#6281 )
* Revert special casing of Kusama for grandpa rounds. (#6217 )
Co-authored-by: eskimor <eskimor@no-such-url.com >
* Fixes "for loop over an `Option`" warnings (#6291 )
Was seeing these warnings when running `cargo check --all`:
```
warning: for loop over an `Option`. This is more readably written as an `if let` statement
--> node/core/approval-voting/src/lib.rs:1147:21
|
1147 | for activated in update.activated {
| ^^^^^^^^^^^^^^^^
|
= note: `#[warn(for_loops_over_fallibles)]` on by default
help: to check pattern in a loop use `while let`
|
1147 | while let Some(activated) = update.activated {
| ~~~~~~~~~~~~~~~ ~~~
help: consider using `if let` to clear intent
|
1147 | if let Some(activated) = update.activated {
| ~~~~~~~~~~~~ ~~~
```
My guess is that `activated` used to be a SmallVec or similar, as is
`deactivated`. It was changed to an `Option`, the `for` still compiled (it's
technically correct, just weird), and the compiler didn't catch it until now.
* companion for #12599 (#6290 )
* companion for #12599
* update Cargo.lock
* use cargo path instead of diener
* update lockfile for {"substrate"}
Co-authored-by: parity-processbot <>
* remove the runtime check and test
* append keys on past-session slashing
* runtime/disputes: allow importing backing votes after explicit for
* explicit MaliciousBacker error and a test
* update an outdated comment
* Revert "update an outdated comment"
This reverts commit 7c4c3f5a848f16e2b61435e981d814f00333ed41.
* Revert "remove the runtime check and test"
This reverts commit a5bff0c75e77effb5b7d3a1691de1b14bcdbd648.
* incremental punishment post conclusion + test
* punish backers post FOR vote
* remove unnecessary lifetime annotation
* add a comment to zombinet test
* typo
* fmt
* post merge test fixes
* fix test after changes in master
* address review nits
---------
Co-authored-by: Bradley Olson <34992650+BradleyOlson64@users.noreply.github.com >
Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io >
Co-authored-by: Andrei Sandu <54316454+sandreim@users.noreply.github.com >
Co-authored-by: Sergej Sakac <73715684+Szegoo@users.noreply.github.com >
Co-authored-by: eskimor <eskimor@users.noreply.github.com >
Co-authored-by: eskimor <eskimor@no-such-url.com >
Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com >
Co-authored-by: Marcin S <marcin@bytedude.com >
Co-authored-by: Niklas Adolfsson <niklasadolfsson1@gmail.com >
2023-02-01 11:36:05 -03:00
1a1bfd2af9
XCM v3 ( #4097 )
...
* cargo fmt
* Create benchmarks for XCM instructions introduced in v3 (#4564 )
* Create benchmarks for BurnAsset and ExpectAsset
* Add benchmarks for ExpectOrigin and ExpectError
* Add benchmarks for QueryPallet and ExpectPallet
* Add benchmarks for ReportTransactStatus and ClearTransactStatus
* cargo fmt
* Use AllPalletsWithSystem in mocks
* Update XCM generic benchmarks for westend
* Remove default impls for some XCM weight functions
* Fix compilation error
* Add weight_args helper attribute
* Remove manually written XcmWeightInfo
* Parse trailing comma
* Revert "Add weight_args helper attribute"
This reverts commit 3b7c47a6182e1b9227036c38b406d494c3fcf6fd.
* Fixes
* Fixes
* XCM v3: Introduce querier field into `QueryReponse` (#4732 )
* Introduce querier field into QueryReponse
* Convert &Option<MultiLocation> to Option<&MultiLocation>
&Option<T> is almost always never quite useful, most of the time it
still gets converted to an Option<&T> via `as_ref`, so we should simply
make functions that accept Option<&T> instead.
* Fix tests
* cargo fmt
* Fix benchmarks
* Appease spellchecker
* Fix test
* Fix tests
* Fix test
* Fix mock
* Fixes
* Fix tests
* Add test for response queriers
* Update xcm/pallet-xcm/src/lib.rs
* Test for non-existence of querier
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
* Fixes
* Fixes
* Add `starts_with` function to `MultiLocation` and `Junctions` (#4835 )
* add matches_prefix function to MultiLocation and Junctions
* rename matches_prefix to starts_with
* remove unnecessary main in doc comment
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Make use of starts_with in match_and_split
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
* XCM v3: Bridge infrastructure (#4681 )
* XCM bridge infrastructure
* Missing bit of cherry-pick
* Revamped XCM proc macros; new NetworkIds
* Fixes
* Formatting
* ExportMessage instruction and config type
* Add MessageExporter definitions
* Formatting
* Missing files
* Fixes
* Initial bridging config API
* Allow for two-stage XCM execution
* Update xcm/src/v3/mod.rs
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
* XCM crate building again
* Initial bridging primitive
* Docs
* Docs
* More work
* More work
* Merge branch 'gav-xcm-v3' into gav-xcm-v3-bridging
* Make build
* WithComputedOrigin and SovereignPaidRemoteExporter
* Remove TODOs
* Slim bridge API and tests.
* Fixes
* More work
* First bridge test passing
* Formatting
* Another test
* Next round of bridging tests
* Repot tests
* Cleanups
* Paid bridging
* Formatting
* Tests
* Spelling
* Formatting
* Fees and refactoring
* Fixes
* Formatting
* Refactor SendXcm to become two-phase
* Fix tests
* Refactoring of SendXcm and ExportXcm complete
* Formatting
* Rename CannotReachDestination -> NotApplicable
* Remove XCM v0
* Minor grumbles
* Formatting
* Formatting
* Fixes
* Fixes
* Cleanup XCM config
* Fee handling
* Fixes
* Formatting
* Fixes
* Bump
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
* Bump Substrate
* XCM v3: `ExchangeAsset` and Remote-locking (#4945 )
* Asset Exchange and Locks
* Make sure XCM typers impl MaxEncodedLen
* Basic implementation for locks
* Bump Substrate
* Missing files
* Use new API
* Introduce instruction
* Big refactor
* Docs
* Remove deprecated struct
* Remove deprecated struct
* Repot XCM builder tests
* ExchangeAsset test
* Exchange tests
* Locking tests
* Locking tests
* Fixes and tests
* Fixes
* Formatting
* Spelling
* Add simulator test for remote locking
* Fix tests
* Bump
* XCM v3: Support for non-fungibles (#4950 )
* NFT support and a test
* New files.
* Integration tests for sending NFTs
* Formatting
* Broken Cargo features
* Use 2021 edition
* Fixes
* Formatting
* Formatting
* Update xcm/xcm-builder/src/asset_conversion.rs
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
* Update xcm/xcm-builder/src/nonfungibles_adapter.rs
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
* Update xcm/xcm-executor/src/lib.rs
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
* Fixes
* Fixes
* Fixes
* Formatting
* Fixes
Co-authored-by: Bastian Köcher <info@kchr.de >
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
* XCM v3: Context & ID hash (#4756 )
* send_xcm returns message hash
* cargo fmt
* Create topic register and instructions
* Fix weights
* Use tabs
* Sketch out XcmContext
* Fix doc test
* Add the XCM context as a parameter to executor trait fns
* Fixes
* Add XcmContext parameter
* Revert adding context as an arg to SendXcm trait methods
* Revert adding context argument to ConvertOrigin trait methods
* cargo fmt
* Do not change the API of XcmExecutor::execute
* Fixes
* Fixes
* Fixes
* Fixes
* Remove convenience method
* Fixes
* Fixes
* cargo fmt
* Fixes
* Add benchmarks for XCM topic instructions
* cargo run --quiet --profile=production --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=pallet_xcm_benchmarks::generic --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --template=./xcm/pallet-xcm-benchmarks/template.hbs --output=./runtime/westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs
* Remove context argument on FilterAssetLocation
* Fixes
* Remove unused import
* Fixes
* Fixes
* Fixes
* Accept XCM hash parameter in ExecuteXcm trait methods
* cargo fmt
* Properly enable sp-io/std
* Fixes
* default-features = false
* Fixes
* Fixes
* Fixes
* Make XcmContext optional in withdraw_asset
* Fixes
* Fixes
* Fixes
* Modify tests to check for the correct XCM hash
* Small refactor
* cargo fmt
* Check for expected hash in xcm-builder unit tests
* Add doc comment for the optionality of the XCM context in withdraw_asset
* Update xcm/src/v3/traits.rs
* Update xcm/src/v3/traits.rs
* Store XcmContext and avoid rebuilding
* Use ref for XcmContext
* Formatting
* Fix incorrect hash CC @KiChjang
* Refactor and make clear fake hashes
* Fixes
* Fixes
* Fixes
* Fix broken hashing
* Docs
* Fixes
* Fixes
* Fixes
* Formatting
* Fixes
* Fixes
* Fixes
* Remove unknowable hash
* Formatting
* Use message hash for greater identifiability
* Formatting
* Fixes
* Formatting
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
Co-authored-by: Parity Bot <admin@parity.io >
* Fixes
* Fixes
* Fixes
* Fixes
* Formatting
* Fixes
* Formatting
* Fixes
* Fixes
* Formatting
* Formatting
* Remove horrible names
* Bump
* Remove InvertLocation trait (#5092 )
* Remove InvertLocation trait
* Remove unneeded functions
* Formatting
* Fixes
* Remove XCMv1 (#5094 )
* Remove XCMv1
* Remove XCMv1
* Formatting
* Fixes
* Fixes
* Formatting
* derive serialize/deserialize for xcm primitives (#5036 )
* derive serialize/deserialize for xcm primitives
* derive serialize/deserialize for xcm primitives
* update v3
* update v2
Co-authored-by: Gav Wood <gavin@parity.io >
* Update lock
* Fixes
* Add benchmarks for the ExchangeAsset instruction
* `AliasOrigin` instruction stub (#5122 )
* AliasOrigin instruction stub
* Fixes
* Fixes
* Update substrate
* Fixes
* Ensure same array length before using copy_from_slice
* Fixes
* Add benchmarks for the UniversalOrigin instruction
* Remove unused import
* Remove unused import
* Add benchmarks for SetFeesMode instruction
* Add benchmarks for asset (un)locking instructions
* Leave AliasOrigin unbenchmarked
* Fixes after merge
* cargo fmt
* Fixes
* Fixes
* Set TrustedReserves to None on both Kusama and Westend
* Remove extraneous reserve_asset_deposited benchmark
* Fix universal_origin benchmark
* cargo run --quiet --profile=production --features=runtime-benchmarks -- benchmark pallet --chain=westend-dev --steps=50 --repeat=20 --pallet=pallet_xcm_benchmarks::generic --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --template=./xcm/pallet-xcm-benchmarks/template.hbs --output=./runtime/westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs
* Don't rely on skipped benchmark functions
* Fixes
* cargo run --quiet --profile=production --features=runtime-benchmarks -- benchmark pallet --chain=kusama-dev --steps=50 --repeat=20 --pallet=pallet_xcm_benchmarks::generic --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --template=./xcm/pallet-xcm-benchmarks/template.hbs --output=./runtime/kusama/src/weights/xcm/pallet_xcm_benchmarks_generic.rs
* Fix unused variables
* Fixes
* Spelling
* Fixes
* Fix codec index of VersionedXcm
* Allows to customize how calls are dispatched from XCM (#5657 )
* CallDispatcher trait
* fmt
* unused import
* fix test-runtime
* remove JustDispatch type
* fix typo in test-runtime
* missing CallDispatcher
* more missing CallDispatcher
* Update comment `NoteAssetLocked` -> `NoteUnlockable`
* Fixes
* Fixes
* Adjust MultiAssets weights based on new wild card variants
* Fixes
* Fixes
* Fixes
* Fixes
* Fixes
* Some late fixes for XCMv3 (#5237 )
* Maximise chances that trapped assets can be reclaimed
* Do origin check as part of ExportMessage for security
* Formatting
* Fixes
* Cleanup export XCM APIs
* Formatting
* Update xcm/src/v3/junctions.rs
* UnpaidExecution instruction and associated barrier.
* Tighten barriers (ClearOrigin/QueryResponse)
* Allow only 1 ClearOrigin instruction in AllowTopLevelPaidExecutionFrom
* Bi-directional teleport accounting
* Revert other fix
* Build fixes]
* Tests build
* Benchmark fixes
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
* Update Substrate
* Re-export `pub` stuff from universal_exports.rs + removed unecessary clone (#6145 )
* Re-export `pub` stuff from universal_exports.rs
* Removed unnecessary clone
* Use 2D weights in XCM v3 (#6134 )
* Depend upon sp-core instead of sp-runtime
* Make sp-io a dev-dependency
* Use 2D weights in XCM v3
* cargo fmt
* Add XCM pallet migration to runtimes
* Use from_parts
* cargo fmt
* Fixes
* cargo fmt
* Remove XCMWeight import
* Fixes
* Fixes
* Fixes
* Fixes
* Use translate in migration
* Increase max upward message size in tests
* Fix doc test
* Remove most uses of from_ref_time
* cargo fmt
* Fixes
* Fixes
* Add extrinsic benchmarking to XCM pallet
* cargo fmt
* Fixes
* Use old syntax
* cargo fmt
* Fixes
* Remove hardcoded weights
* Add XCM pallet to benchmarks
* Use successful origin
* Fix weird type parameter compilation issue
* Fixes
* ".git/.scripts/bench-bot.sh" runtime westend-dev pallet_xcm
* ".git/.scripts/bench-bot.sh" runtime rococo-dev pallet_xcm
* ".git/.scripts/bench-bot.sh" runtime kusama-dev pallet_xcm
* ".git/.scripts/bench-bot.sh" runtime polkadot-dev pallet_xcm
* Use benchmarked XCM pallet weights
* Fixes
* Fixes
* Use override instead of skip
* Fixes
* Fixes
* Fixes
* Fixes
* ".git/.scripts/bench-bot.sh" runtime polkadot-dev pallet_xcm
* Fixes
* ".git/.scripts/bench-bot.sh" runtime polkadot-dev pallet_xcm
* ".git/.scripts/bench-bot.sh" runtime westend-dev pallet_xcm
Co-authored-by: command-bot <>
* Replace Weight::MAX with 100b weight units
* Add test to ensure all_gte in barriers is correct
* Update xcm/src/v3/junction.rs
Co-authored-by: asynchronous rob <rphmeier@gmail.com >
* Add more weight tests
* cargo fmt
* Create thread_local in XCM executor to limit recursion depth (#6304 )
* Create thread_local in XCM executor to limit recursion depth
* Add unit test for recursion limit
* Fix statefulness in tests
* Remove panic
* Use defer and environmental macro
* Fix the implementation
* Use nicer interface
* Change ThisNetwork to AnyNetwork
* Move recursion check up to top level
* cargo fmt
* Update comment
Co-authored-by: Bastian Köcher <info@kchr.de >
* Add upper limit on the number of overweight messages in the queue (#6298 )
* Add upper limit on the number of ovwerweight messages in the queue
* Add newline
* Introduce whitelist for Transact and limit UMP processing to 10 messages per block (#6280 )
* Add SafeCallFilter to XcmConfig
* Limit UMP to receive 10 messages every block
* Place 10 message limit on processing instead of receiving
* Always increment the message_processed count whenever a message is processed
* Add as_derivative to the Transact whitelist
* cargo fmt
* Fixes
* Update xcm/xcm-builder/src/universal_exports.rs
Co-authored-by: Branislav Kontur <bkontur@gmail.com >
* Fixes
* Fixes
* Remove topic register and instead use the topic field in XcmContext
* Derive some common traits for DispatchBlobError
* Fixes
* cargo fmt
* Fixes
* Fixes
* Fix comments
* Fixes
* Introduce WithOriginFilter and apply it as the CallDispatcher for runtimes
* Fixes
* Appease clippy and fixes
* Fixes
* Fix more clippy issues
* Fixes
* ".git/.scripts/bench-bot.sh" runtime polkadot-dev pallet_xcm
* ".git/.scripts/bench-bot.sh" runtime westend-dev pallet_xcm
* ".git/.scripts/bench-bot.sh" runtime westend-dev pallet_xcm
* Add benchmark function for ExportMessage
* Fix comment
* Add upper limit to DownwardMessageQueues size
* Add max size check for queue in can_queue_downward_message
* Fixes
* Make Transact runtime call configurable
* Return Weight::MAX when there is no successful send XCM origin
* Update substrate
* Fixes
* Fixes
* Remove ExportMessage benchmark
* Remove assertion on Transact instruction benchmark
* Make reachable destination configurable in XCM pallet benchmarks
* Fixes
* Fixes
* Remove cfg attribute in fuzzer
* Fixes
* Remove cfg attribute for XCM pallet in test runtime
* Fixes
* Use ReachableDest where possible
* Fixes
* Add benchmark for UnpaidExecution
* Update substrate
* Ensure benchmark functions pass filters
* Add runtime-benchmarks feature to fuzzer
* Ensure FixedRateOfFungible accounts for proof size weights
* cargo fmt
* Whitelist remark_with_event when runtime-benchmarks feature is enabled
* Use remark_with_event for Transact benchmarks
* Fix Cargo.lock
* Allow up to 3 DescendOrigin instructions before UnpaidExecution
* cargo fmt
* Edit code comment
* Check check_origin for unpaid execution privilege
* Fixes
* Small nits for xcm-v3 (#6408 )
* Add possibility to skip benchmark for export_message
* ".git/.scripts/bench-bot.sh" xcm westend-dev pallet_xcm_benchmarks::generic
* Revert
* ".git/.scripts/bench-bot.sh" xcm westend-dev pallet_xcm_benchmarks::generic
* Add HaulBlobError to `fn haul_blob`
* ".git/.scripts/bench-bot.sh" xcm westend-dev pallet_xcm_benchmarks::generic
Co-authored-by: command-bot <>
* Revert changes to UnpaidExecution
* Change AllowUnpaidExecutionFrom to be explicit
* Fix log text
* cargo fmt
* Add benchmarks for XCM pallet version migration (#6448 )
* Add benchmarks for XCM pallet version migration
* cargo fmt
* Fixes
* Fixes
* Fixes
* ".git/.scripts/bench-bot.sh" runtime westend-dev pallet_xcm
* ".git/.scripts/bench-bot.sh" runtime kusama-dev pallet_xcm
* ".git/.scripts/bench-bot.sh" runtime rococo-dev pallet_xcm
* ".git/.scripts/bench-bot.sh" runtime polkadot-dev pallet_xcm
* Fix benchmarks
* Fix benchmarks
* ".git/.scripts/bench-bot.sh" runtime westend-dev pallet_xcm
* ".git/.scripts/bench-bot.sh" runtime kusama-dev pallet_xcm
* ".git/.scripts/bench-bot.sh" runtime rococo-dev pallet_xcm
* ".git/.scripts/bench-bot.sh" runtime polkadot-dev pallet_xcm
Co-authored-by: command-bot <>
* Merge remote-tracking branch 'origin/master' into gav-xcm-v3
* Fixes
* Fix comments (#6470 )
* Specify Ethereum networks by their chain id (#6286 )
Co-authored-by: Squirrel <gilescope@gmail.com >
* Use for Kusama
* Use WithComputedOrigin for Polkadot, Rococo and Westend
* Update lock
* Fix warning
* Update xcm/pallet-xcm/src/tests.rs
Co-authored-by: Squirrel <gilescope@gmail.com >
* Update runtime/parachains/src/ump/migration.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update xcm/pallet-xcm/src/migration.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fixes
* cargo fmt
* Typo
* Update xcm/src/v3/mod.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Docs
* Docs
* Docs
* Docs
* Docs
* Update xcm/src/v3/multiasset.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add tests for MultiAssets::from_sorted_and_deduplicated
* Fail gracefully when same instance NFTs are detected during push
* Update Substrate to fix benchmarks
* Apply suggestions from code review
* Update runtime/kusama/src/xcm_config.rs
* Rename arguments
* Attempt to fix benchmark
* ".git/.scripts/commands/bench/bench.sh" runtime polkadot-dev runtime_parachains::ump
* Use actual weights for UMP pallet in Polkadot
* ".git/.scripts/commands/bench/bench.sh" runtime kusama-dev runtime_parachains::ump
* ".git/.scripts/commands/bench/bench.sh" runtime westend-dev runtime_parachains::ump
* ".git/.scripts/commands/bench/bench.sh" runtime rococo-dev runtime_parachains::ump
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
Co-authored-by: Alexander Popiak <alexander.popiak@parity.io >
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
Co-authored-by: Bastian Köcher <info@kchr.de >
Co-authored-by: Parity Bot <admin@parity.io >
Co-authored-by: stanly-johnson <stanlyjohnson@outlook.com >
Co-authored-by: nanocryk <6422796+nanocryk@users.noreply.github.com >
Co-authored-by: Branislav Kontur <bkontur@gmail.com >
Co-authored-by: asynchronous rob <rphmeier@gmail.com >
Co-authored-by: command-bot <>
Co-authored-by: Vincent Geddes <vincent.geddes@hey.com >
Co-authored-by: Squirrel <gilescope@gmail.com >
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com >
2023-01-17 07:04:34 +00:00
1cb1d03c08
Re-export current primitives in crate root ( #6487 )
...
* Re-export current primitives in crate root
* Add missing exports
* restart CI
2023-01-11 11:28:12 +00:00
ed9a1a400e
disputes pallet: Remove spam slots ( #6345 )
...
* disputes pallet: Filter disputes with votes less than supermajority threshold
* Remove `max_spam_slots` usages
* Remove `SpamSlots`
* Remove `SpamSlotChange`
* Remove `Error<T>::PotentialSpam` and stale comments
* `create_disputes_with_no_spam` -> `create_disputes`
* Make tests compile - wip commit
* Rework `test_dispute_timeout`. Rename `update_spam_slots` to `filter_dispute_set`
* Remove `dispute_statement_becoming_onesided_due_to_spamslots_is_accepted` and `filter_correctly_accounts_spam_slots` -> they bring no value with removed spam slots
* Fix `test_provide_multi_dispute_success_and_other`
* Remove an old comment
* Remove spam slots from tests - clean todo comments
* Remove test - `test_decrement_spam`
* todo comments
* Update TODO comments
* Extract `test_unconfirmed_are_ignored` as separate test case
* Remove dead code
* Fix `test_unconfirmed_are_ignored`
* Remove dead code in `filter_dispute_data`
* Fix weights (related to commit "Remove `SpamSlots`")
* Disputes migration - first try
* Remove `dispute_max_spam_slots` + storage migration
* Fix `HostConfig` migration tests
* Deprecate `SpamSlots`
* Code review feedback
* add weight for storage version update
* fix bound for clear()
* Fix weights in disputes migration
* Revert "Deprecate `SpamSlots`"
This reverts commit 8c4d967c7b061abd76ba8b551223918c0b9e6370.
* Make mod migration public
* Remove `SpamSlots` from disputes pallet and use `storage_alias` in the migration
* Fix call to `clear()` for `SpamSlots` in migration
* Update migration and add a `try-runtime` test
* Add `pre_upgrade` `try-runtime` test
* Fix some test names in `HostConfiguration` migration
* Link spamslots migration in all runtimes
* Add `test_unconfirmed_disputes_cause_block_import_error`
* Update guide
- Remove `SpamSlots` related information from roadmap/implementers-guide/src/runtime/disputes.md
- Add 'Disputes filtering' to Runtime section of the Implementor's guide
* Update runtime/parachains/src/configuration/migration.rs
Co-authored-by: Marcin S. <marcin@bytedude.com >
* Code review feedback - update logs
* Code review feedback: fix weights
* Update runtime/parachains/src/disputes.rs
Co-authored-by: s0me0ne-unkn0wn <48632512+s0me0ne-unkn0wn@users.noreply.github.com >
* Additional logs in disputes migration
* Fix merge conflicts
* Add version checks in try-runtime tests
* Fix a compilation warning`
Co-authored-by: Marcin S. <marcin@bytedude.com >
Co-authored-by: s0me0ne-unkn0wn <48632512+s0me0ne-unkn0wn@users.noreply.github.com >
2023-01-07 14:56:14 +01:00
d387338fb0
Use explicit call indices ( #6449 )
...
* cargo update -p sp-io
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Use explicit call indices
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
2022-12-19 23:13:34 +01:00
9ea14e66c8
Clippyfy ( #6341 )
...
* Add clippy config and remove .cargo from gitignore
* first fixes
* Clippyfied
* Add clippy CI job
* comment out rusty-cachier
* minor
* fix ci
* remove DAG from check-dependent-project
* add DAG to clippy
Co-authored-by: alvicsam <alvicsam@gmail.com >
2022-11-30 08:34:06 +00:00
8eb1f4617f
Use a more typesafe approach for managing indexed data ( #6150 )
...
* Fix for issue #2403
* Nightly fmt
* Quick documentation fixes
* Default Implementation
* iter() function integrated
* Implemented iter functionalities
* Fmt
* small change
* updates node-network
* updates in dispute-coordinator
* Updates
* benchmarking fix
* minor fix
* test fixes in runtime api
* Update primitives/src/v2/mod.rs
Co-authored-by: Andronik <write@reusable.software >
* Update primitives/src/v2/mod.rs
Co-authored-by: Andronik <write@reusable.software >
* Update primitives/src/v2/mod.rs
Co-authored-by: Andronik <write@reusable.software >
* Update primitives/src/v2/mod.rs
Co-authored-by: Andronik <write@reusable.software >
* Update primitives/src/v2/mod.rs
Co-authored-by: Andronik <write@reusable.software >
* Removal of [index], shorting of FromIterator, Renaming of GroupValidators to ValidatorGroups
* Removal of ops import
* documentation fixes for spell check
* implementation of generic type
* Refactoring
* Test and documentation fixes
* minor test fix
* minor test fix
* minor test fix
* Update node/network/statement-distribution/src/lib.rs
Co-authored-by: Andronik <write@reusable.software >
* Update primitives/src/v2/mod.rs
Co-authored-by: Andronik <write@reusable.software >
* Update primitives/src/v2/mod.rs
Co-authored-by: Andronik <write@reusable.software >
* removed IterMut
* Update node/core/dispute-coordinator/src/import.rs
Co-authored-by: Andronik <write@reusable.software >
* Update node/core/dispute-coordinator/src/initialized.rs
Co-authored-by: Andronik <write@reusable.software >
* Update primitives/src/v2/mod.rs
Co-authored-by: Andronik <write@reusable.software >
* fmt
* IterMut
* documentation update
Co-authored-by: Andronik <write@reusable.software >
* minor adjustments and new TypeIndex trait
* spelling fix
* TypeIndex fix
Co-authored-by: Andronik <write@reusable.software >
2022-10-22 08:39:11 +00:00
18c077a818
runtime/disputes: slashing ( #5535 )
...
* disputes: runtime part of slashing
* disputes: reward winners
* disputes/slashing: validate_unsigned impl
* fmt
* disputes/slashing: report_dispute_lost_unsigned
* disputes/slashing: separate winners from losers and report winners
* disputes/slashing: refactoring
* impl HandleReports
* enable on Wenstend
* fmt
* add slashing pallet to the mock and test runtimes
* fix a bug in report_dispute_lost_unsigned
* fmt
* disputes: remove new_participants from summary
* disputes: remove punish_inconclusive
* impl SlashingHandler for Pallet for type-safety
* do not impl slashing::Config on mainnets yet
* teach spellcheck deduplication
* simplify interfaces and resolve some TODOs
* resolve some more TODOs
* minor typos
* move slashing into a folder
* remove unnecessary clone
* fix validator_set_count calculation
* introduce ValidatorSetCount
* store ValidatorSetCount
* fmt
* add the benchmark
* fmt
* unflatten slashing
* post-rebase fixes
* remove winners eagerly
* use real slashing weights for westend
* remove bench test suite
* zombinet: modify disputes test to check for an offence report
* zombinet: add a timeout
* add slashing pallet to Rococo
* zombienet: revert back to rococo-local
* fmt
* remove TODOs
* revert some accidental changes
* slashing is submodule of disputes
* Change the log target
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* wrap comments with rustfmt, more docs, constants
* use Defensive trait
* cargo update -p sp-io
* merge offence types, remove rewards for now
* cargo update -p sp-io
* benchmark fixes
* fmt
* unused var
* fix block_author impl
* ressurect RewardValidators trait
* remove outdated comment
* more module docs
* introduce BenchmarkingConfig
* typo fix
* teach spellcheck unapplied
* use Weight::new()
* fix mocking rewards
* use RefTimeWeight
* ".git/.scripts/bench-bot.sh" runtime westend-dev runtime_parachains::disputes::slashing
* refactor maybe_identify_validators
* no more ticket in disguise
* remove outdated comments
* lower against valid to 0.1%
* bump zombienet version for debug
* use from_perthousand
* post-merge fixes
* another day, another Weight changes
* Revert "bump zombienet version for debug"
This reverts commit 0d9978711f8ec9a746a5e1c45e8ffbe7c75e7b5c.
* do not reward block authors
* fix outdated comment
* use Pays from frame_support::dispatch::Pays
* add timeout to is up
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
Co-authored-by: command-bot <>
Co-authored-by: Javier Viola <javier@parity.io >
Co-authored-by: Javier Viola <pepoviola@gmail.com >
2022-09-20 10:56:55 +00:00
8ea6076fe5
Companion for #11981 ( #5915 )
...
* Companion for #11981
* more renaming
* fmt
* fixes
* add generic type
* Companion for #11831
* fix
* revert changes
* Delete rename-outer-enum.diff
* revert
* Update run_benches_for_runtime.sh
* rename type Call & type Event
* passing tests
* fmt
* small fixes
* commit
* fix
* fmt
* commit
* error fixes
* fix
* small fix in test
* Update lib.rs
* Update lib.rs
* Update lib.rs
* Update lib.rs
* Update lib.rs
* Update lib.rs
* Update lib.rs
* remove RuntimeCall from pallet_grandpa
* last fix
* commit
* rename
* merge fix
* update lockfile for {"substrate"}
* cargo +nightly fmt
* fix
Co-authored-by: parity-processbot <>
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com >
2022-09-12 23:03:47 +00:00
e28bf2e476
Companion for Weight v1.5 Follow Up ( #5949 )
...
* updates
* remove new
* fix up some stuff
* fix cargo files
* fix
* fix template
* update lockfile for {"substrate"}
* Update block_weights.rs
* remove unused
* remove unused
Co-authored-by: parity-processbot <>
2022-09-01 19:00:51 +00:00
28e94d97dd
Companion for Weight v1.5 ( #5943 )
...
* fix to latest substrate pr
* update weights
* cargo build -p polkadot-runtime-parachains
* fix xcm-builder
* fix import
* fix a bunch
* fix a bunch of weight stuff
* kusama compile
* unused
* builds
* maybe fix
* cargo test -p polkadot-runtime-parachains
* xcm simulator example
* fix tests
* xcm sim fuzz
* fix runtime tests
* remove unused
* fix integration tests
* scalar div
* update lockfile for {"substrate"}
Co-authored-by: parity-processbot <>
2022-08-31 11:59:39 +00:00
2ba1c54fc7
Companion to combine iteratons and tolerance in sp-npos-elections API #11498 ( #5581 )
...
* Fixing staking miner
* cargo update -p sp-io
* fix spell
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com >
2022-06-15 20:57:26 -04:00
11357d4095
secondary filtering ( #4783 )
...
* filter again if it's the first statement and spam slots were applied
* Update runtime/parachains/src/disputes.rs
Co-authored-by: Andronik <write@reusable.software >
* fixins
* add a proper test case, simplify some code
Co-authored-by: Andronik <write@reusable.software >
2022-06-14 12:31:35 +00:00
026848c932
Companion to Substrate #11490 ( #5603 )
...
* Fix warnings
* Bump
2022-05-30 11:21:03 +01:00
49f7e5cce4
Finish migration to v2 primitives ( #5037 )
...
* remove v0 primitives from polkadot-primitives
* first pass: remove v0
* fix fallout in erasure-coding
* remove v1 primitives, consolidate to v2
* the great import update
* update runtime_api_impl_v1 to v2 as well
* guide: add `Version` request for runtime API
* add version query to runtime API
* reintroduce OldV1SessionInfo in a limited way
2022-03-09 14:01:13 -06:00
e8cb6cdaac
Companion to "Updating scale to v3" ( #4958 )
...
* Updating dependencies
* Adapting code to scale v3
* Upgrade bitvec to 1.0.0
* Fix bitvec arithmetics
* Update Cargo.lock
* Update sp-io
* Fixing the build
* Yanked scale-info 2.0.0
Co-authored-by: Bastian Köcher <info@kchr.de >
2022-02-25 13:07:06 +01:00
5b06cc23d6
[chore] runtime split tests ( #4834 )
2022-02-03 09:12:41 +01:00
f7564591e7
Add tests to ensure session is set correctly in OnChainScrapingVotes ( #4821 )
...
Co-authored-by: Bernhard Schuster <bernhard@ahoi.io >
2022-02-02 18:40:21 +01:00
0302271053
Fix incomplete sorting. ( #4795 )
...
* Fix incomplete sorting.
* fmt.
* Better test.
* Update runtime/parachains/src/disputes.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* chore fmt
* simplify the sorting for two items
* add test for assure duplicates are detected
* fixup tests
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
Co-authored-by: Bernhard Schuster <bernhard@ahoi.io >
2022-01-27 18:16:31 +00:00
3d61cc01db
co #10662 : Require MaxEncodedLen per default ( #4746 )
...
* Add `without_storage_info`
The MaxEncodedLen trait is now enforced by default in Substrate.
All pallets missing an implementation need to be marked with
`without_storage_info` now.
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Remove `generate_storage_info`
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add more `without_storage_info`
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* update lockfile for {"substrate"}
Co-authored-by: parity-processbot <>
2022-01-20 12:36:22 +00:00
b7a05fd40b
[runtime] follow up relay chain cleanups ( #4657 )
...
* fix miscalculation of remaining weight
* rename a var
* move out enforcing filtering by dropping inherents
* prepare for dispute statement validity check being split off
* refactor
* refactor, only check disputes we actually want to include
* more refactor and documentation
* refactor and minimize inherent checks
* chore: warnings
* fix a few tests
* fix dedup regression
* fix
* more asserts in tests
* remove some asserts
* chore: fmt
* skip signatures checks, some more
* undo unwatend changes
* Update runtime/parachains/src/paras_inherent/mod.rs
Co-authored-by: sandreim <54316454+sandreim@users.noreply.github.com >
* cleanups, checking CheckedDisputeStatments makes no sense
* integrity, if called create_inherent_inner, it shall do the checks, and not rely on enter_inner
* review comments
* use from impl rather than into
* remove outdated comment
* adjust tests accordingly
* assure no weight is lost
* address review comments
* remove unused import
* split error into two and document
* use assurance, O(n)
* Revert "adjust tests accordingly"
This reverts commit 3cc9a3c449f82db38cea22c48f4a21876603374b.
* fix comment
* fix sorting
* comment
Co-authored-by: sandreim <54316454+sandreim@users.noreply.github.com >
2022-01-20 11:00:29 +00:00
5a4d0ebcba
Companion for substrate#10620 ( #4696 )
...
* fix tests
* update lockfile for substrate
Co-authored-by: parity-processbot <>
2022-01-12 10:34:50 +00:00
78b3dc214a
chore: fix copy&paste and tidy comments ( #4646 )
...
As was brought up in [here][og], we have some copy&paste comments. I
fixed them and also took liberty of fixing some other places.
Specifically, those that say "module" instead of contemporary "pallet".
[og]:
https://github.com/paritytech/polkadot/pull/4603#discussion_r776971291
2022-01-01 18:13:17 +01:00
4adb8466a3
dev-comment spelling mistakes ( #4434 )
2021-12-06 15:20:29 +01:00
e16f71b7b6
companion for pallet order fix. ( #4181 )
...
* companion
* remove no-op duplicated function
* fmt
* add comment on constraint
* Run cargo update
* fix integration test
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com >
2021-12-01 03:00:20 +00:00
49d78d99f7
rococo-runtime: Switch to latest construct_runtime! syntax ( #4389 )
...
* rococo-runtime: Switch to latest `construct_runtime!` syntax
Besides that it fixes pallet macro errors in other crates that popped up
because of this switch.
* FMT
2021-11-29 21:36:19 +01:00
1aa6a4aba4
move paras inherent filtering to runtime ( #4028 )
...
* move things around, add filter methods
* validator keys, modify availability bitfields according to disputes
* simplify, keep the filter -> sanitize generic for both usecases
* minor
* assure tests still work, reduce changeset
* integration
* start entropy passing
* fixins
* compile, 1 failing test
* filter with coverage
* fixins
* Update runtime/parachains/src/paras_inherent.rs
Co-authored-by: Robert Habermeier <rphmeier@gmail.com >
* slip of the pen
* improve test cases
* misc
* fix
* fixins
* test avoid extra into() calls in assert_noop!
* chores
* ff
* test fixup superfluous into call
* chore: pfmt
* improve apply_block_weight_limit to try to maximize the number of sufficiently backed
blocks and add extra bitfields in a round-robin fashion
* new code treats the lack of backed candidates as ok
* Use vrf based entropy
* fixup vrf random
* add warn
* slip of the pen
* fixup
* assure ordering
* rethink apply_weights
* mock
* use a closure as predicate check
* extract and use DisputedBitfield
* chore: simplify
* remove stray dbg
* chore: fmt
* address feedback
* fix test, halfway there
* stage1
* dbg stuff
* make group selection align
* fix session index
* fix wrongly returned candidates
* cleanup
* chore fmt
* fix ensure check
* make good case test work
* more tests for bitfields
* create sanitize_backed_candidates
* fixup tests
* update guide
* add check referenced in the guide
* improve weights code
* fmt
* fixins
* Update roadmap/implementers-guide/src/runtime/inclusion.md
Co-authored-by: Zeke Mostov <32168567+emostov@users.noreply.github.com >
* compiling + address review
* add comments
* fix weight calc
* address review comments and test failure
* fix
* fix: condition
* Fix random_sel function
* Fix overlength block check
* Zeke + Ladi commit for disputes filtering + integration test builder + runtime benchmarks + integration tests
* Add benchmarks for code upgrades
* Code upgrade bench; Feature gate TestWeightInfo
* Try and make CI happier
* Feature gate enter test to not(benchmarks)
* Make sure no unused imports/fn
* refactor, re-use, the beginning
* Fix issue with frame benchmarking dep compilation
* More precise feature gating for some derives
* integrate piece-wise
* foo
* fixins
* chore fmt
* fixins
* rename const generic
* Update runtime/parachains/src/paras_inherent.rs
Co-authored-by: Zeke Mostov <z.mostov@gmail.com >
* Fix compilation
* limit to test
* remove unused spam slots
* spellcheck
* remove a tick, fix a typo
* Add Code upgrade weights
* comment improvements + >=
Co-authored-by: Zeke Mostov <z.mostov@gmail.com >
* remove another tick
* Update runtime/parachains/src/paras_inherent/benchmarking.rs
Co-authored-by: Zeke Mostov <z.mostov@gmail.com >
* saturating fixins + some spaces
* fix
* benchmarking - preliminary results
* Add training wheels
* Refactor some early exit logic for enter
* Gracefully handle filtering bitfields & candidates (#4280 )
This updates the logic for sanitize_bitfields and sanitize_backed_candidates to never error when there is an issue, but instead to simply skip the problematic items.
* Refactor inherent data weight limiting logic (#4287 )
* Apply suggestions from code review
* Update runtime/parachains/src/builder.rs
Co-authored-by: Zeke Mostov <z.mostov@gmail.com >
* Update runtime/parachains/src/builder.rs
* Update runtime/parachains/src/paras_inherent.rs
* final pass
* Run cargo +nightly-2021-10-29 fmt
* Update implementors guide with `sanitize_*` & `enter` (#4294 )
* Make spell check happier
* Make wasm runtimes compile with benchmarks enabled (#4303 )
* comment stuff out, use old toml
* Seems to be working?
* Remove feature gating from builder
* Remove commented out stuff
* Remove generic from digest
* Update weight files for runtime
Co-authored-by: Robert Habermeier <rphmeier@gmail.com >
Co-authored-by: Zeke Mostov <32168567+emostov@users.noreply.github.com >
Co-authored-by: Lldenaurois <Ljdenaurois@gmail.com >
Co-authored-by: Zeke Mostov <z.mostov@gmail.com >
Co-authored-by: Bastian Köcher <info@kchr.de >
2021-11-16 18:39:39 +00:00
8aba3ea8ca
some spelling fixes ( #4088 )
...
* quotes around Job::ToJob
* add new words to dictionary
2021-10-18 11:59:46 +02:00
d59ef49195
Move runtime to with_transaction in order to Rollback state changes ( #4067 )
...
* Move runtime to with_transaction in order to Rollback state changes
* add assert_storage_noop to tests
2021-10-12 20:09:48 +00:00
547d166f20
Fix an off-by-one: revert rather than revert-to ( #3991 )
...
* fix off-by-one in disputes reversion code
* bump Rococo spec version
2021-10-01 20:24:35 +00:00
019d4e3b99
paras_inherent: reject only candidates with concluded disputes ( #3969 )
...
* paras_inherent: reject only candidates with concluded disputes
* remove unused Error variant
2021-09-29 13:58:04 -05:00
94986bec7e
disputes: reject single-sided disputes ( #3903 )
...
* disputes: reject single-sided disputes
* fmt
2021-09-27 12:16:34 -05:00
03934d2af1
Add a force_unfreeze extrinsic to the disputes module ( #3906 )
...
* add a 'force_unfreeze' to the Disputes module
* fmt
* Benchmark Disputes `force_unfreeze` extrinsic (#3908 )
* Companion for Generate storage info for pallet babe #9760 (#3831 )
* Adding MaxSegmentLength and MaxAuthorities
to pallet babe
* Missed a few to_vec
* Removing `MaxSegmentLength` as not needed anymore
* Adding `MaxAuthorities` to couple of missing place
* Adding missing definition of `MaxAuthorities`
* Adding a missing to_vec
* update Substrate
Co-authored-by: thiolliere <gui.thiolliere@gmail.com >
Co-authored-by: parity-processbot <>
* Benchmark Disputes `force_unfreeze` extrinsic
target pr: #3906
target branch: rh-unfreeze
* Add benchmark to rococo runtime; run benchmark locally
* Revert unintentionally added diff
* Some spacing and comments
* Bump proc-macro-crate from 1.0.0 to 1.1.0 (#3863 )
Bumps [proc-macro-crate](https://github.com/bkchr/proc-macro-crate ) from 1.0.0 to 1.1.0.
- [Release notes](https://github.com/bkchr/proc-macro-crate/releases )
- [Commits](https://github.com/bkchr/proc-macro-crate/commits )
---
updated-dependencies:
- dependency-name: proc-macro-crate
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump parity-scale-codec from 2.2.0 to 2.3.0 (#3833 )
Bumps [parity-scale-codec](https://github.com/paritytech/parity-scale-codec ) from 2.2.0 to 2.3.0.
- [Release notes](https://github.com/paritytech/parity-scale-codec/releases )
- [Changelog](https://github.com/paritytech/parity-scale-codec/blob/master/CHANGELOG.md )
- [Commits](https://github.com/paritytech/parity-scale-codec/compare/v2.2...parity-scale-codec-v2.3.0 )
---
updated-dependencies:
- dependency-name: parity-scale-codec
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Use super::WeightInfo to try and get CI to compile
* cargo run --quiet --release --features runtime-benchmarks -- benchmark --chain=rococo-dev --steps=50 --repeat=20 --pallet=runtime_parachains::disputes --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtime/parachains/src/disputes/weights.rs --header=./file_header.txt
* impl TestWeightInfo; remove weights from runtime_parachains dir
* fmt
* Update test-runtime
Co-authored-by: Georges <georges.dib@gmail.com >
Co-authored-by: thiolliere <gui.thiolliere@gmail.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Parity Bot <admin@parity.io >
Co-authored-by: Zeke Mostov <32168567+emostov@users.noreply.github.com >
Co-authored-by: Georges <georges.dib@gmail.com >
Co-authored-by: thiolliere <gui.thiolliere@gmail.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Parity Bot <admin@parity.io >
2021-09-23 19:29:26 +00:00
4c7539cab5
Companion for #8615 : enrich metadata with type information ( #3336 )
...
* Use beefy branch with scale-info
* Add patches
* Sprinkle some TypeInfo derives
* Add some TypeInfo deriv
* Cargo.lock
* Derive TypeInfo and skip type params for Xcm types
* Cargo.lock
* Fix up scale_info bounds attributes
* Fix up dependencies
* Use my own beefy-primitives branch
* Bump BEEFY
* Update patches
* Add some scale-info dependencies and TypeInfo derives
* More TypeInfo decoration
* Update scale-info
* Some TypeInfos and remove more Event pallet::metadata
* Moar TypeInfos
* TypeInfos galore, fix up metadata runtime API
* TypeInfo
* TypeInfos, update other runtime metadata APIs
* Fix up Kusama, comment out some `usize` QueueSize parameter types
* Remove local diener patches
* Cargo.lock
* Cargo.lock
* Update to scale-info crates.io release
* Update primitive-types branch
* Update pallet-beefy to use custom branch
* Update other parity-common deps
* Update parity-common patches
* bump a bunch of deps in parity-common
* Remove parity-common patches
* Bump finality-grandpa version
* Cargo.lock
* Update scale-info to 0.9.1
* Add recursion_limit for runtime-parachains
* Add some scale_info attributes
* Cargo.lock
* Revert finality-grandpa bump
* Cargo.lock, scale-info update
* cargo update
* Make sure using patched version of finality-grandpa
* Use patched scale-info
* Update to scale-info 0.10.0
* Update finality-grandpa
* Cargo.lock
* Update beefy deps
* Update beefy deps again
* Add scale-info dependency
* Remove deprecated pallet::metadata attributes.
* Add some missing scale-info deps and derives
* Use some variant struct call syntax
* Add missing TypeInfo impl
* Add some more TypeInfo impls
* Convert some call enum struct variant constructors
* More scale-info deps and derives
* Call enum struct variants
* TypeInfo derives
* Call enum variant structs
* scale-info deps and derives
* Call enum variant struct constructors
* Use beefy-primitives scale-info feature
* Use grandpa-bridge-gadget master branch
* Remove finality-grandpa patch
* Add missing scale_info dependency and derive
* Fix up some call variant constructors
* Add missing scale_info dependency
* Fix some test errors
* More TypeInfo derives
* More call variant structs
* Call variant structs in tests
* Cargo.lock
* Fmt
* Fix more call struct variants
* Another call struct variant
* add scale-info/std features explicitly
* More call struct variants
* Add missing scale-info dependency
* Fmt
* review: activate scale-info/std where missing
* Remove some duplicate std feature activation
* review: add scale_info bounds() attr
* More call variant structs
* Remove recursion limit
* Update beefy-primitives
* Update beefy-primitives
* Fix simnet call variant struct errors
* Fmt
* cargo update -p beefy-primitives
* Add some missing TypeInfo derives
* Fix some call variants
* Fix some call variant underscores
* Cargo.lock
* Cargo.lock
* Add missing TypeInfo derive
* Add some more missing TypeInfo derives
* Even more missing TypeInfo derives
* Add TypeInfo derives to new xcm types
* Fmt
* Cargo.lock
* Add missing TypeInfo impls
* Cargo.lock
* More missing TypeInfos
* Fixes
* Cargo.lock
* Cargo.lock
* Add TypeInfo impls to xcm v2
* Update to scale-info 1.0
* Update finality-grandpa 0.14.4, patch for now
* Update beefy
* Remove patched finality-grandpa
* Add TypeInfo impl to Outcome
* Fixes
* Call variant struct
* Call variant struct
* Fix test
* Add TypeInfo impl
* Cargo.lock
* Cargo.lock
* Cargo.lock
* git checkout master Cargo.lock
* update Substrate
* Add missing scale-info features for beefy-primitives
* Fmt
* Remove check for now
* Update beefy-primitives, removes scale-info feature
* Update beefy-primitives again
Co-authored-by: adoerr <0xad@gmx.net >
Co-authored-by: Andronik Ordian <write@reusable.software >
Co-authored-by: thiolliere <gui.thiolliere@gmail.com >
Co-authored-by: parity-processbot <>
Co-authored-by: Bastian Köcher <info@kchr.de >
2021-09-15 15:38:45 -05:00
68c03f66f3
Mass replace ,); pattern ( #3580 )
...
This is an artifact left by rustfmt which is not dare to remove the
comma being conservative.
2021-08-05 19:53:17 +02:00
24c0d5a51e
Parachains para_inherent.rs to FrameV2 ( #3531 )
...
* last parachains migration!
* migrate runtimes
* disable frame supertrait
* add pallet::inherent
* mock
* cargo +nightly fmt
2021-08-03 11:02:34 +00:00
ff5d56fb76
cargo +nightly fmt ( #3540 )
...
* cargo +nightly fmt
* add cargo-fmt check to ci
* update ci
* fmt
* fmt
* skip macro
* ignore bridges
2021-08-02 10:47:33 +00:00
84ca3b2b3b
Parachains configuration.rs FrameV2 ( #3516 )
...
* migration
* genesis build correctly
* migrate runtimes
* add genesis builds
* expose GenesisBuild
* chainspec migration
* fmt
* check before insert
* Reduce visibility of storage items to crate
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
2021-07-28 04:56:35 +00:00
675f71a882
Dispute vote filtering for block authors ( #3498 )
...
* guide: filter_multi_dispute_data
* guide: elaborate
* Implementation of dispute data filtering
* tests for filtering
* don't use std, you fool!
* use swap_remove
* Update runtime/parachains/src/disputes.rs
Co-authored-by: Andronik Ordian <write@reusable.software >
* use btreeste
* address API nit
Co-authored-by: Andronik Ordian <write@reusable.software >
2021-07-21 21:48:07 +02:00
ec98120f0e
Disputes runtime ( #2947 )
...
* disputes module skeleton and storage
* implement dispute module initialization logic
* implement disputes session change logic
* provide dispute skeletons
* deduplication & ancient check
* fix a couple of warnings
* begin provide_dispute_data impl
* flesh out statement set import somewhat
* move ApprovalVote to shared primitives
* add a signing-payload API to explicit dispute statements
* implement statement signature checking
* some bitflags glue for observing changes in disputes
* implement dispute vote import logic
* flesh out everything except slashing
* guide: tweaks
* declare and use punishment trait
* punish validators for inconclusive disputes
* guide: tiny fix
* guide: update docs
* add disputes getter fn
* guide: small change to spam slots handling
* improve spam slots handling and fix some bugs
* finish API of disputes runtime
* define and deposit `RevertTo` log
* begin integrating disputes into para_inherent
* use precomputed slash_for/against
* return candidate hash from process_bitfields
* implement inclusion::collect_disputed
* finish integration into rest of runtime
* add Disputes to initializer
* address suggestions
* use pallet macro
* fix typo
* Update runtime/parachains/src/disputes.rs
* add test: fix pruning
* document specific behavior
* deposit events on dispute changes
* add an allow(unused) on fn disputes
* add a dummy PunishValidators implementation
* add disputes module to Rococo
* add disputes module to westend runtime
* add disputes module to test runtime
* add disputes module to kusama runtime
* guide: prepare for runtime API for checking frozenness
* remove revert digests in favor of state variable
* merge reversions
* Update runtime/parachains/src/disputes.rs
Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com >
* Update runtime/parachains/src/disputes.rs
Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com >
* Update runtime/parachains/src/disputes.rs
Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com >
* add byzantine_threshold and supermajority_threshold utilities to primitives
* use primitive helpers
* deposit revert event when freezing chain
* deposit revert log when freezing chain
* test revert event and log are generated when freezing
* add trait to decouple disputes handling from paras inherent handling
* runtime: fix compilation and setup dispute handler
* disputes: add hook for filtering out dispute statements
* disputes: add initializer hooks to DisputesHandler
* runtime: remove disputes pallet from all runtimes
* tag TODOs
* don't import any dispute statements just yet...
* address grumbles
* fix spellcheck, hopefully
* maybe now?
* last spellcheck round
* fix runtime tests
* fix test-runtime
Co-authored-by: thiolliere <gui.thiolliere@gmail.com >
Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com >
Co-authored-by: André Silva <andrerfosilva@gmail.com >
2021-07-19 16:49:19 +00:00
Oliver Tale-Yazdi