Kian Paimani
eaf1bc5633
Introduce Polkadot-Sdk developer_hub ( #2102 )
...
This PR introduces the new crate `developer_hub` into the polkadot-sdk
repo. The vision for the developer-hub crate is detailed in [this
document](https://docs.google.com/document/d/1XLLkFNE8v8HLvZpI2rzsa8N2IN1FcKntc8q-Sc4xBAk/edit?usp=sharing ).
<img width="1128" alt="Screenshot 2023-11-02 at 10 45 48"
src="https://github.com/paritytech/polkadot-sdk/assets/5588131/1e12b60f-fef5-42c4-8503-a3ba234077c3 ">
Other than adding the new crate, it also does the following:
* Remove the `substrate` crate, as there is now a unique umbrella crate
for multiple things in `developer_hub::polkadot_sdk`.
* (backport candidate) A minor change to `frame-support` macros that
allows `T::RuntimeOrigin` to also be acceptable as the origin type.
* (backport candidate) A minor change to `frame-system` that allows us
to deposit events at genesis because now the real genesis config is
generated via wasm, and we can safely assume `cfg!(feature = "std")`
means only testing. related to #62 .
* (backport candidate) Introduces a small `read_events_for_pallet` to
`frame_system` for easier event reading in tests.
* From https://github.com/paritytech/polkadot-sdk-docs/issues/31 , it
takes action on improving the `pallet::call` docs.
* From https://github.com/paritytech/polkadot-sdk-docs/issues/31 , it
takes action on improving the `UncheckedExtrinsic` docs.
## Way Forward
First, a version of this is deployed temporarily
[here](https://blog.kianenigma.nl/polkadot-sdk/developer_hub/index.html ).
I will keep it up to date on a daily basis.
### This Pull Request
I see two ways forward:
1. We acknowledge that everything in `developer-hub` is going to be WIP,
and merge this asap. We should not yet use links to this crate anywhere.
2. We make this be the feature branch, make PRs against this, and either
gradually backport it, or only merge to master once it is done.
I am personally in favor of option 1. If we stick to option 2, we need a
better way to deploy a staging version of this to gh-pages.
### Issue Tracking
The main issues related to the future of `developer_hub` are:
- https://github.com/paritytech/polkadot-sdk-docs/issues/31
- https://github.com/paritytech/polkadot-sdk-docs/issues/4
- https://github.com/paritytech/polkadot-sdk-docs/issues/26
- https://github.com/paritytech/polkadot-sdk-docs/issues/32
- https://github.com/paritytech/polkadot-sdk-docs/issues/36
### After This Pull Request
- [ ] create a redirect for
https://paritytech.github.io/polkadot-sdk/master/substrate/
- [x] analytics
- [ ] link checker
- [ ] the matter of publishing, and how all of these relative links for
when we do, that is still an open question. There is section on this in
the landing page.
- [ ] updated https://paritytech.github.io/
---------
Co-authored-by: Liam Aharon <liam.aharon@hotmail.com >
Co-authored-by: Juan Girini <juangirini@gmail.com >
Co-authored-by: bader y <ibnbassem@gmail.com >
Co-authored-by: Sebastian Kunert <skunert49@gmail.com >
Co-authored-by: James Wilson <james@jsdw.me >
Co-authored-by: Michal Kucharczyk <1728078+michalkucharczyk@users.noreply.github.com >
2023-11-30 12:15:46 +01:00
Przemek Rzad
bfb241d7f3
Add missing licenses and tune the scanning workflow ( #1288 )
...
* Add missing Cumulus licenses
* Typo
* Add missing Substrate licenses
* Single job checking the sub-repos in steps
* Remove dates
* Remove dates
* Add missing (C)
* Update FRAME UI tests
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update more UI tests
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
---------
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
2023-08-30 15:45:49 +03:00
Juan
878c562cd4
Restructure frame_support macro related exports ( #14745 )
...
* make reexports private
* make reexports private 2
* make reexports private for runtime-benchmarking
* make reexports private for try-runtime
* fix for try-runtime
* make reexports private for tests
* fmt
* make reexports private for tests
* make reexports private for experimental
* fix beefy
* fix ui test
* fix ui test
* fix benches
* ".git/.scripts/commands/fmt/fmt.sh"
* fix contracts use
* wip
* wip
* do not reexport sp_api::metadata_ir
* fix CI checks
* fix support tests
* ".git/.scripts/commands/fmt/fmt.sh"
* Update frame/support/src/lib.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* import codec directly
* fmt
* fix node-cli tests
---------
Co-authored-by: command-bot <>
Co-authored-by: Bastian Köcher <git@kchr.de >
2023-08-23 12:30:12 +00:00
Liam Aharon
13f05272fd
Disarm OnRuntimeUpgrade::pre/post_upgrade Tuple footgun ( #14759 )
...
* return error on incorrect tuple usage of pre_upgrade and post_upgrade
* add test
* comment lint
* Update frame/support/src/traits/hooks.rs
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
* Update frame/support/src/traits/hooks.rs
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
* address feedback
* Update frame/support/src/traits/hooks.rs
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
* Update frame/support/src/traits/hooks.rs
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
* Update frame/support/src/traits/hooks.rs
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
* muharem comments
* Update frame/support/src/traits/hooks.rs
Co-authored-by: Muharem Ismailov <ismailov.m.h@gmail.com >
* Update frame/support/src/traits/hooks.rs
Co-authored-by: Muharem Ismailov <ismailov.m.h@gmail.com >
* remove useless type
---------
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
Co-authored-by: Muharem Ismailov <ismailov.m.h@gmail.com >
2023-08-16 17:04:15 +00:00
Liam Aharon
ffbc395d84
Free standing elections-phragmen and tips Gov V1 unlock/unreserve migrations ( #14779 )
...
* standalone elections-phragmen migration
* standalone tips migration
* remove redundant comment
2023-08-16 15:58:05 +00:00
Bastian Köcher
53f4b4df76
Run all tests with try-runtime feature enabled ( #14396 )
...
* Run all tests with `try-runtime` feature enabled
There are some tests that are guarded behind the `try-runtime` feature which are currently not being
executed. This pull requests changes this and enables the feature for the test run.
* Add some docs
* Rename variable
2023-06-16 12:16:19 +02:00
Liam Aharon
72046c2830
migration(elections-phragmen): unreserve deposits and clear locks ( #14218 )
...
* pre_upgrade hook wip
* working pre_upgrade
* simplify code
* cleanup and document
* return reads from get_account_deposited_and_staked_sums
* improve comment
* on_runtime_upgrade comment
* post upgrade comment
* use saturating_add
* clippy
* clean up balances
* add tests
* fix comment
* oops
* actually fix comment
* fix std build
* address pr comments
* remove redundant comment
* update comment
* add comment
* oliver comments from tips pallet pr
* lint
* remove need for do_pre/do_post runtime functions
* generic dbweight
* Update frame/elections-phragmen/src/migrations/unlock_and_unreserve_all_funds.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update frame/elections-phragmen/src/migrations/unlock_and_unreserve_all_funds.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* pr comments
* remove useless check
* feature gate log target
* lint
* Update frame/elections-phragmen/src/migrations/unlock_and_unreserve_all_funds.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* add log for unexpected amounts
---------
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
2023-06-13 16:07:13 +00:00
Gonçalo Pestana
c848d40775
Revert "Abstracts elections-phragmen pallet to use NposSolver ( #12588 )" ( #13451 )
...
This reverts commit b793666ca5 .
2023-02-23 12:15:08 -06:00
Gonçalo Pestana
b793666ca5
Abstracts elections-phragmen pallet to use NposSolver ( #12588 )
...
* Abstracts elections-phragmen pallet to use NposSolver
* Update frame/elections-phragmen/src/lib.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* Update frame/elections-phragmen/src/lib.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* changes the name of the pallet; adds changelog
* update changelog
* Adds weight testing
* Adds log macro_rules
* renames elections-phragment dir to elections
* weights rename
* fixes typo in cargo toml
* pre/post solve weight scafolding
* refactor do_post_election
* refactors into pre and post election solve for independent benchmarking
* deconstructs PreElectionResults struct
* updates benchmarking pre and post election solve; mock weights
* Update frame/elections/src/lib.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* Update frame/elections/src/lib.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* addresses PR comments
* adds pre_solve and post_sove weights
* Adds comments on election pallet id param name change
* ".git/.scripts/bench-bot.sh" pallet dev pallet_elections
* Finishes pre-post solve weights
* Update frame/elections/src/lib.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* Update frame/elections/src/lib.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* Addresses PR comments: no panic in on_init path; nits
* Fixes node build
* Implements approval voting to use as a `NposSolver` (#13367 )
* Implements the approval voting methods in sp_npos_elections
* fmt
* remove unecessary file
* comment clarification
* re-run weights
* fix typo
* updates MaxVoters in tests for integrity_tests to pass
* Refactors election provider support benchmarks outside its own crate (#13431 )
* Refactors election provider support benchmarks outside its own crate
---------
Co-authored-by: command-bot <>
---------
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
Co-authored-by: parity-processbot <>
Co-authored-by: Ross Bulat <ross@parity.io >
2023-02-23 11:21:00 +00:00
Vivek Pandya
bc53b9a03a
Remove years from copyright notes. ( #13415 )
...
* Change copyright year to 2023 from 2022
* Fix incorrect update of copyright year
* Remove years from copy right header
* Fix remaining files
* Fix typo in a header and remove update-copyright.sh
2023-02-21 18:46:41 +00:00
Anthony Alaribe
c04e68fd01
introduce log-target constant to more frame pallets ( #13116 )
...
* introduce log-target constant to more frame pallets
* cargo fmt
* make LOG_TARGET in session public
* Update frame/elections-phragmen/src/lib.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* Update frame/elections-phragmen/src/migrations/v3.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* Update frame/elections-phragmen/src/migrations/v3.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* Update frame/elections-phragmen/src/migrations/v3.rs
Co-authored-by: Bastian Köcher <git@kchr.de >
* move LOG_TARGET=runtime::session_historical to migrations module, where it's actually used
Co-authored-by: Bastian Köcher <git@kchr.de >
2023-01-10 19:18:12 +00:00
Shawn Tabrizi
1df4561676
Weight v1.5 Follow Ups ( #12155 )
...
* update api
* update
* remove unused
* remove `one` api
* fix unused
* fmt
* add saturating accrue
* remove `Weight::new()`
* use some macros
* div makes no sense
* Update weight_v2.rs
* missed some
* more patch
* fixes
* more fixes
* more fix
* more fix
* Update frame/support/src/weights/weight_v2.rs
* not needed
* fix weight file
2022-09-01 17:48:03 +00:00
Shawn Tabrizi
30951822ba
Weight v1.5: Opaque Struct ( #12138 )
...
* initial idea
* update frame_support
* update a bunch more
* add ord
* adjust RuntimeDbWeight
* frame_system builds
* re-export
* frame_support tests pass
* frame_executive compile
* frame_executive builds
* frame_system tests passing
* pallet-utility tests pass
* fix a bunch of pallets
* more
* phragmen
* state-trie-migration
* scheduler and referenda
* pallet-election-provider-multi-phase
* aura
* staking
* more
* babe
* balances
* bunch more
* sudo
* transaction-payment
* asset-tx-payment
* last pallets
* fix alliance merge
* fix node template runtime
* fix pallet-contracts cc @athei
* fix node runtime
* fix compile on runtime-benchmarks feature
* comment
* fix frame-support-test
* fix more tests
* weight regex
* frame system works
* fix a bunch
* more
* more
* more
* more
* more
* more fixes
* update templates
* fix contracts benchmarks
* Update lib.rs
* Update lib.rs
* fix ui
* make scalar saturating mul const
* more const functions
* scalar div
* refactor using constant functions
* move impl
* fix overhead template
* use compactas
* Update lib.rs
2022-08-31 11:26:13 +00:00
Bastian Köcher
74428fa8ac
generate_storage_alias: Rewrite as proc macro attribute ( #11387 )
...
* generate_storage_alias: Rewrite as proc macro attribute
This rewrites the `generate_storage_alias!` declarative macro as proc-macro attribute. While doing
this the name is changed to `storage_alias`. The prefix can now also be the name of a pallet. This
makes storage aliases work in migrations for all kind of chains and not just for the ones that use
predefined prefixes.
* Fix compilation and FMT
* Moare fixes
* 🤦
* ......
* Rework the syntax and support instancing
* FMT
* Prefix variants with `Storage`
* Make it compile
* Fix where clause on rust stable
2022-05-17 18:45:56 -04:00
Falco Hirschenberger
b581604aa7
Apply some clippy lints ( #11154 )
...
* Apply some clippy hints
* Revert clippy ci changes
* Update client/cli/src/commands/generate.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/cli/src/commands/inspect_key.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/db/src/bench.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/db/src/bench.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/service/src/client/block_rules.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/service/src/client/block_rules.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/network/src/transactions.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/network/src/protocol.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Revert due to missing `or_default` function.
* Fix compilation and simplify code
* Undo change that corrupts benchmark.
* fix clippy
* Update client/service/test/src/lib.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/state-db/src/noncanonical.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/state-db/src/noncanonical.rs
remove leftovers!
* Update client/tracing/src/logging/directives.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Update utils/fork-tree/src/lib.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* added needed ref
* Update frame/referenda/src/benchmarking.rs
* Simplify byte-vec creation
* let's just not overlap the ranges
* Correction
* cargo fmt
* Update utils/frame/benchmarking-cli/src/shared/stats.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Update utils/frame/benchmarking-cli/src/pallet/command.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Update utils/frame/benchmarking-cli/src/pallet/command.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
Co-authored-by: Giles Cope <gilescope@gmail.com >
2022-04-30 21:28:27 +00:00
Zeke Mostov
afdec55069
Migration for over locked accounts in phgragmen elections ( #10649 )
...
* use free balance rather than total balance
* Docs
* Migration for over-locked phrag voters
* New line
* comment
* Update frame/elections-phragmen/src/migrations/v5.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* Only set lock, don't remove it
* delete commented out
* docs
* Update migration to just take a set of accounts
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com >
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
2022-01-18 03:06:25 +00:00
Bastian Köcher
f3662b4bba
Happy new year 2022 ( #10573 )
2022-01-03 09:22:14 +01:00
Alexander Popiak
8cf6474388
add query types to generate_storage_alias ( #9659 )
...
* add query types to generate_storage_alias
* adjust comment
* use ValueQuery explicitly for generate_storage_alias with generic value type
* bump impl_version
* adjust line width and add import
* more compilation and formatting fixes
* formatting
2021-09-08 08:48:49 +00:00
Bastian Köcher
4fe55f0bcb
Move PalletVersion away from the crate version ( #9165 )
...
* Move `PalletVersion` away from the crate version
Before this pr, `PalletVersion` was referring to the crate version that
hosted the pallet. This pr introduces a custom `package.metadata.frame`
section in the `Cargo.toml` that can contain a `pallet-version` key
value pair. While the value is expected to be a valid u16. If this
key/value pair isn't given, the version is set to 1.
It also changes the `PalletVersion` declaration. We now only have one
`u16` that represents the version. Not a major/minor/patch version. As
the old `PalletVersion` was starting with the `u16` major, decoding the
old values will work.
* Overhaul the entire implementation
- Drop PalletVersion
- Introduce StorageVersion
- StorageVersion needs to be set in the crate and set for the macros
- Added migration
* Fix migrations
* Review feedback
* Remove unneeded dep
* remove pub consts
* Brings back logging and implements `GetStorageVersion`
* Return weight from migration
* Fmt and remove unused import
* Update frame/support/src/dispatch.rs
Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com >
* Update frame/support/src/traits/metadata.rs
Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com >
Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com >
2021-07-27 21:21:27 +00:00
Bastian Köcher
7b56ab15b4
Run cargo fmt on the whole code base ( #9394 )
...
* Run cargo fmt on the whole code base
* Second run
* Add CI check
* Fix compilation
* More unnecessary braces
* Handle weights
* Use --all
* Use correct attributes...
* Fix UI tests
* AHHHHHHHHH
* 🤦
* Docs
* Fix compilation
* 🤷
* Please stop
* 🤦 x 2
* More
* make rustfmt.toml consistent with polkadot
Co-authored-by: André Silva <andrerfosilva@gmail.com >
2021-07-21 14:32:32 +00:00
Kian Paimani
8cc1af31c4
migrate pallet-elections-phragmen to attribute macros ( #8044 )
...
* All done
* Fix benchmarks
* Apply suggestions from code review
Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com >
* Fix metadata.
* Fix build
* Add migrations
* Fix
* Update frame/elections-phragmen/src/migrations/v4.rs
* Better migeation test
* More test
* Fix warn
* Update frame/elections-phragmen/src/lib.rs
Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com >
* Fix test
* early exit
* Fix
* Fix build
Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com >
2021-04-23 07:12:34 +00:00