672ee582e0
gossip-support: set last_session_index earlier ( #3978 )
...
* gossip-support: set last_session_index earlier
* gossip-support: issue_connection_request never fails
* fmt
2021-09-30 17:04:37 -05:00
72eab56e88
Bump version, tx_version and spec_version in prep for v0.9.11 ( #3970 )
...
* bump version and spec_version
* bump transaction version
* Bump of the default value in CI
* bump tx version for westend and kusama
Co-authored-by: Wilfried Kopp <wilfried@parity.io >
2021-09-30 14:44:19 +02:00
3c8e8637ff
feat: measured oneshots ( #3902 )
...
* overseer: remove mut in connector
* monitored oneshots
* fmt
* remove debug log
* Update node/metered-channel/src/oneshot.rs
Co-authored-by: Andronik Ordian <write@reusable.software >
* Update node/metered-channel/src/oneshot.rs
Co-authored-by: Andronik Ordian <write@reusable.software >
* avoid two Arcs
* add expects
* alt impl
* rework the measured oneshots
* address review comments, use `Measurable` where possible
* chore/tracing: move `PrettyAuthorities` construction out of tracing macros
Co-authored-by: Andronik Ordian <write@reusable.software >
2021-09-29 16:06:20 +00:00
c57a1e7934
remove AllSubsystems and AllSubsystemsGen types ( #3874 )
...
* introduce the OverseerConnector, use it
* introduce is_relay_chain to RelayChainSelection
* Update node/service/src/lib.rs
Co-authored-by: Andronik Ordian <write@reusable.software >
* avoid the deferred setting of `is_relay_chain` in `RelayChainSelection`
* positive assertion is not mandated, only the negative one, to avoid a stall
* cleanup: overseer residue
* spellcheck
* fixin
* groundwork to obsolete Overseer::new and AllSubsystemsGen proc-macro
* Now all malus & tests can be ported to the builder pattern.
Obsoletes `Overseer::new`, `AllSubsystemsGen` derive macro, `AllSubsystems`.
* spellcheck
* adjust tests, minor fixes
* remove derive macro AllSubsystemsGen
* add forgotten file dummy.rs
* remove residue
* good news everyone!
* spellcheck
* address review comments
* fixup imports
* make it conditional
* fixup docs
* reduce import
* chore: fmt
* chore: fmt
* chore: spellcheck / nlprules
* fixup malus variant-a
* fmt
* fix
* fixins
* pfmt
* fixins
* chore: fmt
* remove expanded overseer generation
* tracing version
* Update node/network/statement-distribution/src/lib.rs
Co-authored-by: Robert Habermeier <rphmeier@gmail.com >
* use future::ready instead
* silence warning
* chore: fmt
Co-authored-by: Andronik Ordian <write@reusable.software >
Co-authored-by: Robert Habermeier <rphmeier@gmail.com >
2021-09-29 14:24:56 +00:00
c0719034a1
Bump parity-scale-codec from 2.3.0 to 2.3.1 ( #3959 )
...
Bumps [parity-scale-codec](https://github.com/paritytech/parity-scale-codec ) from 2.3.0 to 2.3.1.
- [Release notes](https://github.com/paritytech/parity-scale-codec/releases )
- [Changelog](https://github.com/paritytech/parity-scale-codec/blob/master/CHANGELOG.md )
- [Commits](https://github.com/paritytech/parity-scale-codec/compare/parity-scale-codec-v2.3.0...parity-scale-codec-v2.3.1 )
---
updated-dependencies:
- dependency-name: parity-scale-codec
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-09-29 11:57:24 +02:00
7c3b3c4a59
Log info about low connectivity and unreachable validators ( #3916 )
...
* Attempt to add log stats to gossip-support.
* WIP: Keep track of connected validators.
* Clarify metric.
* WIP: Make gossip support report connectivity.
* WIP: Fixing tests.
* Fix network bridge + integrate in overseer.
* Consistent naming.
* Fix logic error
* cargo fmt
* Pretty logs.
* cargo fmt
* Use `Delay` to trigger periodic checks.
* fmt
* Fix warning for authority set size of 1.
* More correct ratio report if there are no resolved validators.
* Prettier rendering of empty set.
* Fix typo.
* Another typo.
* Don't check on every leaf update.
* Make compatible with older rustc.
* Fix tests.
* Demote warning.
2021-09-27 16:30:02 +02:00
724a1b4885
Bump tracing from 0.1.27 to 0.1.28 ( #3937 )
...
Bumps [tracing](https://github.com/tokio-rs/tracing ) from 0.1.27 to 0.1.28.
- [Release notes](https://github.com/tokio-rs/tracing/releases )
- [Commits](https://github.com/tokio-rs/tracing/compare/tracing-0.1.27...tracing-0.1.28 )
---
updated-dependencies:
- dependency-name: tracing
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-09-27 07:57:14 +02:00
4f70899f6b
Bump parity-scale-codec from 2.2.0 to 2.3.0 ( #3833 )
...
Bumps [parity-scale-codec](https://github.com/paritytech/parity-scale-codec ) from 2.2.0 to 2.3.0.
- [Release notes](https://github.com/paritytech/parity-scale-codec/releases )
- [Changelog](https://github.com/paritytech/parity-scale-codec/blob/master/CHANGELOG.md )
- [Commits](https://github.com/paritytech/parity-scale-codec/compare/v2.2...parity-scale-codec-v2.3.0 )
---
updated-dependencies:
- dependency-name: parity-scale-codec
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-09-23 00:29:41 +00:00
63a520b056
Dispute distribution improvements ( #3853 )
...
* Better warning policy on dispute-distribution.
Network errors happen, only warn on a minimum number of failed attempts.
* Add metric to see how long it takes to get a dispute vote out.
* Let's be alert.
2021-09-17 12:10:50 +02:00
973183cfb1
Don't try to connect to ourselves. ( #3855 )
...
* Don't try to connecto to ourselves.
* Use swap_remove instead of remove O(1)
Co-authored-by: Andronik Ordian <write@reusable.software >
Co-authored-by: Andronik Ordian <write@reusable.software >
2021-09-16 16:05:07 +02:00
de637b966a
Better error messages. ( #3835 )
...
* Better error messages.
Right now, logged messages are hardly useful.
Together with https://github.com/paritytech/substrate/pull/9768 , this
should help with debugging.
* cargo fmt
2021-09-14 14:18:32 +02:00
135d9ae931
Put all authorities of a session into SessionInfo. ( #3813 )
...
* Make SessionInfo include all authorities
of the current session.
* Add missing import.
* Only take subset for assignment keys.
* Fix typo.
* Make spellcheck happy.
* Really.
* Fix test.
* More clear documentation.
* Update comments in `SessionInfo`.
2021-09-14 13:58:37 +02:00
b9e1f09b30
Bump tracing from 0.1.26 to 0.1.27 ( #3841 )
...
Bumps [tracing](https://github.com/tokio-rs/tracing ) from 0.1.26 to 0.1.27.
- [Release notes](https://github.com/tokio-rs/tracing/releases )
- [Commits](https://github.com/tokio-rs/tracing/compare/tracing-0.1.26...tracing-0.1.27 )
---
updated-dependencies:
- dependency-name: tracing
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-09-14 12:23:05 +02:00
a14b667723
Fix flaky availability-recovery test ( #3812 )
...
* Increase timeout in tests.
Fixes #3798
* Fix timeout.
2021-09-08 12:56:45 +00:00
2bd84151ed
Add tests and modify as_vec implementation ( #3715 )
...
* Add tests and modify as_vec implementation
* Address feedback
* fix typo in test
2021-09-06 13:24:04 +02:00
c71a221097
Bump futures from 0.3.16 to 0.3.17 ( #3742 )
...
Bumps [futures](https://github.com/rust-lang/futures-rs ) from 0.3.16 to 0.3.17.
- [Release notes](https://github.com/rust-lang/futures-rs/releases )
- [Changelog](https://github.com/rust-lang/futures-rs/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rust-lang/futures-rs/compare/0.3.16...0.3.17 )
---
updated-dependencies:
- dependency-name: futures
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-09-04 21:16:23 +02:00
ffcde1e5e7
Fixes/improvements for disputes ( #3753 )
...
* More debugging output.
* Fix chain selection in case of disputes.
* Fix flaky test.
2021-09-01 14:25:56 -05:00
80f8c5106e
Removed unneeded deps ( #3658 )
...
* Removed unneeded deps (except under bridge)
Co-authored-by: Andronik Ordian <write@reusable.software >
2021-08-30 18:18:33 +01:00
e56efb82d9
Further improved availability recovery ( #3711 )
...
* WiP.
* Things compile.
* cargo fmt
* Passing tests + fix warnings.
* Metrics for availability recovery.
* Basic test.
* Fix typos and actually check for overflow.
* cargo fmt
* Register metrics.
* More tests.
* Fix warning.
* cargo +nightly fmt
* Fix metrics
* Get rid of unsafe.
* tabify
* spellcheck
Co-authored-by: Andronik Ordian <write@reusable.software >
Co-authored-by: Bastian Köcher <info@kchr.de >
2021-08-27 18:59:23 +02:00
4193f05fa3
Bump async-trait from 0.1.50 to 0.1.51 ( #3721 )
...
Bumps [async-trait](https://github.com/dtolnay/async-trait ) from 0.1.50 to 0.1.51.
- [Release notes](https://github.com/dtolnay/async-trait/releases )
- [Commits](https://github.com/dtolnay/async-trait/compare/0.1.50...0.1.51 )
---
updated-dependencies:
- dependency-name: async-trait
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-08-26 12:19:22 +02:00
9b45483cb1
backing-availability-audit: Move ErasureChunk Proof to BoundedVec ( #3626 )
...
* backing-availability-audit: Move ErasureChunk Proof to BoundedVec
* WIP
* Touch up
* Fix spelling mistake
* Address Feedback
2021-08-24 12:50:33 -04:00
489a8e6da1
Fill up requests slots via launch_parallel_requests ( #3681 )
...
in case waiting for the next response takes too long.
2021-08-24 15:05:25 +02:00
9a1b614c47
demote warnings due to disconnected dispute coordinator ( #3672 )
...
* demote warnings due to disconnected dispute coordinator
* cargo fmt
Co-authored-by: Robert Klotzner <robert.klotzner@gmx.at >
2021-08-20 15:01:49 +02:00
8792d0e407
Bump strum from 0.20.0 to 0.21.0 ( #3343 )
...
Bumps [strum](https://github.com/Peternator7/strum ) from 0.20.0 to 0.21.0.
- [Release notes](https://github.com/Peternator7/strum/releases )
- [Changelog](https://github.com/Peternator7/strum/blob/master/CHANGELOG.md )
- [Commits](https://github.com/Peternator7/strum/commits )
---
updated-dependencies:
- dependency-name: strum
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-08-19 21:15:43 +02:00
d6abe70c06
Better logs. ( #3650 )
2021-08-19 20:07:59 +02:00
1c039fda48
Bump env_logger from 0.8.4 to 0.9.0 ( #3608 )
...
Bumps [env_logger](https://github.com/env-logger-rs/env_logger ) from 0.8.4 to 0.9.0.
- [Release notes](https://github.com/env-logger-rs/env_logger/releases )
- [Changelog](https://github.com/env-logger-rs/env_logger/blob/main/CHANGELOG.md )
- [Commits](https://github.com/env-logger-rs/env_logger/compare/v0.8.4...v0.9.0 )
---
updated-dependencies:
- dependency-name: env_logger
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-08-13 12:42:26 +02:00
55154a8d37
Remove request multiplexer ( #3624 )
...
* WIP: Get rid of request multiplexer.
* WIP
* Receiver for handling of incoming requests.
* Get rid of useless `Fault` abstraction.
The things the type system let us do are not worth getting abstracted in
its own type. Instead error handling is going to be merely a pattern.
* Make most things compile again.
* Port availability distribution away from request multiplexer.
* Formatting.
* Port dispute distribution over.
* Fixup statement distribution.
* Handle request directly in collator protocol.
+ Only allow fatal errors at top level.
* Use direct request channel for availability recovery.
* Finally get rid of request multiplexer
Fixes #2842 and paves the way for more back pressure possibilities.
* Fix overseer and statement distribution tests.
* Fix collator protocol and network bridge tests.
* Fix tests in availability recovery.
* Fix availability distribution tests.
* Fix dispute distribution tests.
* Add missing dependency
* Typos.
* Review remarks.
* More remarks.
2021-08-12 13:11:36 +02:00
a4527cbc49
Bump thiserror from 1.0.24 to 1.0.26 ( #3592 )
...
Bumps [thiserror](https://github.com/dtolnay/thiserror ) from 1.0.24 to 1.0.26.
- [Release notes](https://github.com/dtolnay/thiserror/releases )
- [Commits](https://github.com/dtolnay/thiserror/compare/1.0.24...1.0.26 )
---
updated-dependencies:
- dependency-name: thiserror
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-08-07 19:42:37 +00:00
05ec3d9875
Bump lru from 0.6.5 to 0.6.6 ( #3583 )
...
Bumps [lru](https://github.com/jeromefroe/lru-rs ) from 0.6.5 to 0.6.6.
- [Release notes](https://github.com/jeromefroe/lru-rs/releases )
- [Changelog](https://github.com/jeromefroe/lru-rs/blob/master/CHANGELOG.md )
- [Commits](https://github.com/jeromefroe/lru-rs/compare/0.6.5...0.6.6 )
---
updated-dependencies:
- dependency-name: lru
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-08-06 20:17:36 +02:00
789017cc76
Version bumps to 0.9.9 ( #3576 )
...
* chore: version bump to 0.9.9
* bump from 0.9.0 to 0.9.9
2021-08-06 16:39:13 +02:00
68c03f66f3
Mass replace ,); pattern ( #3580 )
...
This is an artifact left by rustfmt which is not dare to remove the
comma being conservative.
2021-08-05 19:53:17 +02:00
fe5c303893
Return relay_parent as result of collation seconded signal as well ( #3577 )
...
* Return `relay_parent` as result of collation seconded signal as well
Before we only returned the seconded statement. However, to verify the
statement in a future proof way, we also need the relay parent that was
used as a context to sign the statement.
* FMT
2021-08-05 14:26:02 +00:00
e0b3c5cba0
Better size limits. ( #3572 )
...
* Better size limits.
* Remove reference to private repo.
* Update node/network/protocol/src/request_response/mod.rs
Fix statement response size.
Co-authored-by: Andronik Ordian <write@reusable.software >
Co-authored-by: Andronik Ordian <write@reusable.software >
2021-08-04 17:00:56 +02:00
1718ed1dcc
Fix flaky test ( #3569 )
...
Fixes #3557
2021-08-04 14:15:44 +02:00
ff5d56fb76
cargo +nightly fmt ( #3540 )
...
* cargo +nightly fmt
* add cargo-fmt check to ci
* update ci
* fmt
* fmt
* skip macro
* ignore bridges
2021-08-02 10:47:33 +00:00
e1be821fe1
change ActiveLeaves to contain at most one activated ( #3525 )
...
* change ActiveLeaves to contain at most one activated
* fix test
2021-07-27 16:45:15 +02:00
8fbd3a4f62
Do not leak active head data in statement distribution ( #3519 )
2021-07-26 13:58:24 +02:00
1fd956079a
Bump indexmap from 1.6.1 to 1.7.0 ( #3497 )
...
Bumps [indexmap](https://github.com/bluss/indexmap ) from 1.6.1 to 1.7.0.
- [Release notes](https://github.com/bluss/indexmap/releases )
- [Commits](https://github.com/bluss/indexmap/compare/1.6.1...1.7.0 )
---
updated-dependencies:
- dependency-name: indexmap
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-07-21 10:56:14 +00:00
fc253e6e4d
WIP: CI: add spellcheck ( #3421 )
...
* CI: add spellcheck
* revert me
* CI: explicit command for spellchecker
* spellcheck: edit misspells
* CI: run spellcheck on diff
* spellcheck: edits
* spellcheck: edit misspells
* spellcheck: add rules
* spellcheck: mv configs
* spellcheck: more edits
* spellcheck: chore
* spellcheck: one more thing
* spellcheck: and another one
* spellcheck: seems like it doesn't get to an end
* spellcheck: new words after rebase
* spellcheck: new words appearing out of nowhere
* chore
* review edits
* more review edits
* more edits
* wonky behavior
* wonky behavior 2
* wonky behavior 3
* change git behavior
* spellcheck: another bunch of new edits
* spellcheck: new words are koming out of nowhere
* CI: finding the master
* CI: fetching master implicitly
* CI: undebug
* new errors
* a bunch of new edits
* and some more
* Update node/core/approval-voting/src/approval_db/v1/mod.rs
Co-authored-by: Andronik Ordian <write@reusable.software >
* Update xcm/xcm-executor/src/assets.rs
Co-authored-by: Andronik Ordian <write@reusable.software >
* Apply suggestions from code review
Co-authored-by: Andronik Ordian <write@reusable.software >
* Suggestions from the code review
* CI: scan only changed files
Co-authored-by: Andronik Ordian <write@reusable.software >
2021-07-14 19:22:58 +02:00
2d66b8f256
Dispute Coordinator: Batch queries ( #3459 )
...
* disputes: Allow batch queries in dispute-coordinator
This commit moves to batch queries when responding to QueryCandidateVotes
messages. This simplifies the code in the provisioner and dispute-coordinator
by no longer requiring to make use of a FuturesOrdered when awaiting multiple
quries. Instead, the provisioner need only request the batch itself.
* node/approval-voting: Address Feedback to fail on query element missing.
* Address feedback
* Fix implementer's guide
2021-07-12 20:06:14 -05:00
6994682a86
DoS protection on the collator protocol ( #3446 )
...
* Move on to next validator after timeout.
* Better naming.
* Wrong implementation of validator fetch timeouts.
* Validator side: Move on to next collator
if download takes too long.
* Drop multiple requests from same validator.
* Add test that next response is sent after timeout.
* Multiple requests by same validator should get dropped.
* Test that another collator is tried
after exclusive download time.
* Add dep.
* Cleanup.
* Merge fix.
* Review remarks.
* Fixes.
* Add log targets to trace logs
Co-authored-by: Andronik Ordian <write@reusable.software >
2021-07-12 13:01:17 +02:00
d76560fea2
thiserror annotations + spelling ( #3452 )
...
* remove duplicate thiserror annotations
* chore: cargo spellcheck
2021-07-09 12:31:52 +00:00
b5257b2407
Dispute distribution implementation ( #3282 )
...
* Dispute protocol.
* Dispute distribution protocol.
* Get network requests routed.
* WIP: Basic dispute sender logic.
* Basic validator determination logic.
* WIP: Getting things to typecheck.
* Slightly larger timeout.
* More typechecking stuff.
* Cleanup.
* Finished most of the sending logic.
* Handle active leaves updates
- Cleanup dead disputes
- Update sends for new sessions
- Retry on errors
* Pass sessions in already.
* Startup dispute sending.
* Provide incoming decoding facilities
and use them in statement-distribution.
* Relaxed runtime util requirements.
We only need a `SubsystemSender` not a full `SubsystemContext`.
* Better usability of incoming requests.
Make it possible to consume stuff without clones.
* Add basic receiver functionality.
* Cleanup + fixes for sender.
* One more sender fix.
* Start receiver.
* Make sure to send responses back.
* WIP: Exposed authority discovery
* Make tests pass.
* Fully featured receiver.
* Decrease cost of `NotAValidator`.
* Make `RuntimeInfo` LRU cache size configurable.
* Cache more sessions.
* Fix collator protocol.
* Disable metrics for now.
* Make dispute-distribution a proper subsystem.
* Fix naming.
* Code style fixes.
* Factored out 4x copied mock function.
* WIP: Tests.
* Whitespace cleanup.
* Accessor functions.
* More testing.
* More Debug instances.
* Fix busy loop.
* Working tests.
* More tests.
* Cleanup.
* Fix build.
* Basic receiving test.
* Non validator message gets dropped.
* More receiving tests.
* Test nested and subsequent imports.
* Fix spaces.
* Better formatted imports.
* Import cleanup.
* Metrics.
* Message -> MuxedMessage
* Message -> MuxedMessage
* More review remarks.
* Add missing metrics.rs.
* Fix flaky test.
* Dispute coordinator - deliver confirmations.
* Send out `DisputeMessage` on issue local statement.
* Unwire dispute distribution.
* Review remarks.
* Review remarks.
* Better docs.
2021-07-09 04:29:53 +02:00
3c9104daff
refactor overseer into proc-macro based pattern ( #2962 )
2021-07-08 21:09:26 +02:00
378905df9d
Warn on low connectivity. ( #3408 )
...
* Warn on low connectivity.
* Better timeout and docs.
* Review remarks.
2021-07-05 21:22:03 +02:00
7b054b3c77
cleanup stream polls ( #3397 )
...
* metered-channel: remove dead code
* we don't need no fuse
* even more
2021-07-02 10:23:26 +02:00
f293fb1025
Fix busy loops. ( #3392 )
2021-07-01 08:44:13 +02:00
e8d7e9f0dc
Ensure that we fetch another collation if the first collation was invalid ( #3362 )
...
* Ensure that we fetch another collation if the first collation was invalid
* Feedback
2021-06-28 14:28:58 +02:00
2ea1587e8d
Only send one collation per relay parent at a time to validators ( #3360 )
...
* Only send one collation per relay parent at a time to validators
This changes the way we are sending collations to validators. Before we
answered every collation request immediatley. Now we only answer one
pov request at a time per relay parent. This should bring down the
bandwidth requirements and should help parachains to include bigger
blocks more easily.
* Guide updates
* Review feedback.
2021-06-28 11:07:44 +00:00
dcb08fd533
Use associated constant for max ( #3375 )
2021-06-28 11:32:33 +02:00
Andronik Ordian