* use CountedMap in pallet-bags-list
* Fix build
* Update frame/bags-list/src/list/mod.rs
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
* add a check as well
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
* Add a block production benchmark
* Simplify the block production benchmark
* Cleanups; switch execution strategy to WASM
* Switch WASM execution to `Compiled`
* Reduce the setup cost of the benchmark
Creating all of those extrinsics takes up *a lot* of time, up to the point
where the majority of the time is actually spent *outside* of the code
which we want to benchmark here. So let's only do it once.
* Add a variant of the block production benchmark with proof recording
* Remove the RPC client example
Might be slightly contentious but I think we want to migrate this example to `subxt` and redirect the community to use that for things like this.
* Remove rpc-client example code from workspace
* Removal of light client from substrate
* add missing import
* These tests relate to there being light and non light clients.
* removing lightnodes from test
* cargo fmt
* not needed
* LightDataChecker not needed any longer
* cargo fmt
* Update client/service/test/src/lib.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
* Update client/service/test/src/lib.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
* cargo fmt
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
* pallet-scheduler: Introduce `OriginPrivilegeCmp`
When a scheduled task should be canceled, the origin that tries to
cancel the task is compared to the origin the task should be executed
with. Before this pr this check only allowed that both origins are
equal. However, this is problematic as this means that for example a
council origin it needs to be have the same amount of yes votes to
cancel the scheduled task. While a council origin with more yes votes
should be able to cancel this task. This happened recently on Kusama and
lead to a failed cancelation of a scheduled task. With this pr the two
origins are compared and the cancelling origin needs to have greater or
equal privileges as the origin that scheduled the task. What a greater,
equal or less privilege is, can be configured in the runtime.
For simplicity, a `EqualPrivilegeOnly` implementation is provided that
only checks if two origins are equal. So, this mimics the old behaviour.
* FMT
* fix import
* Small optimizations
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
* Disable log reloading by default
This disables the log reloading that was enabled by default. The problem
is that the log reload implementation of `tracing` is using a lock to
make the layer replaceable. This lock needs to be locked every time we
need to check if a particular target is enabled (assuming the log level
is high enough). This kills the performance when for example
`sometarget=trace` logging is enabled.
* 🤦
* Remove unused parameter
* Fix test
* Fix
* Yep
* Make it compile
* Make the benchmark work
* Some stuff
* Optimize transaction pool `BestIterator`
* Some docs
* Fix more warnings
* Fix compilation
* FMT
* Adding MaxEncodedLen for:
* NextConfigDescriptor
* AllowedSlots
* BabeEpochConfiguration
In prepation for adding storage information on pallet babe
* Adding stotage_info to pallet babe
Refactored UNDER_CONSTRUCTION_SEGMENT_LENGTH to become a runtime
parameter MaxSegmentLength
* Reinstate Slice as opposed to Vec
* Refactoring code to make it neater
* Replace `MaxSegmentLength` by
`UNDER_CONSTRUCTION_SEGMENT_LENGTH`
Stop exposing the bounds to the runtime
* Removing extra line
Co-authored-by: thiolliere <gui.thiolliere@gmail.com>
Converting some `Vec` to `WeakBoundedVec`
Adding `MaxAuthorities` type to bound the `WeakBoundedVec`
Co-authored-by: thiolliere <gui.thiolliere@gmail.com>
* deadlock, need to ask someone to help now
* Finally it seems to be working.. at least for a few blocks
* self-review
* major mega revamp
* some small fixes
* another mega refactor
* add license
* Apply suggestions from code review
* hack around signature verification
* Some fixes
* Update utils/frame/try-runtime/cli/src/lib.rs
Co-authored-by: Zeke Mostov <32168567+emostov@users.noreply.github.com>
* Update utils/frame/try-runtime/cli/src/lib.rs
Co-authored-by: Zeke Mostov <32168567+emostov@users.noreply.github.com>
* Update utils/frame/try-runtime/cli/src/lib.rs
Co-authored-by: Zeke Mostov <32168567+emostov@users.noreply.github.com>
* final tweaks, hopefully.
* a little self-review
* Add the ext root check
Co-authored-by: Zeke Mostov <32168567+emostov@users.noreply.github.com>
* Integrating WrapperOpaque from PR #9738
* Adding storage_info to pallet im-online
Changing some `Vec` to `WeakBoundedVec`
Adding the following bounds:
* `MaxKeys
* `MaxPeerInHeartbeats`
* `MaxPeerDataEncodingSize`
to limit the size of `WeakBoundedVec`
* Fix syntax
* Need to clone keys
* Changes in formatting
* remove extra whitespace
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
* only emit rebag event on success
* add doc explaining the term voter
* revamp/simplify rebag test
* ensure genesis accounts are placed into the correct nodes/bags
* bond_extra implicitly rebags
* types at top; doc public type
* start sketching out adjustable thresholds
* add integrity test for voter bag threshold requirements
* get rid of BagIdx
This reorganizes bag storage such that bags are always referred to
by their upper threshold. This in turn means that adding and removing
bags is cheaper; you only need to migrate certain voters, not all of them.
* implement migration logic for when the threshold list changes
* start sketching out threshold proc macros
* further refine macro signatures
* WIP: implement make_ratio macro
* start rethinking the process of producing threshold lists
The macro approach seems to be a non-starter; that only really works
if we're throwing around numeric literals everywhere, and that's just
not nice in this case.
Instead, let's write helper functions and make it really easy to
generate the tables in separate, permanent files, which humans
can then edit.
* write helper functions to emit voter bags module
* WIP: demo generating voter bags for a realistic runtime
This isn't yet done, becuase it seems to take a Very Long Time to run,
and it really shouldn't. Need to look into that.
Still, it's a lot closer than it was this morning.
* rm unnecessary arg_enum
* fix voter bags math
Turns out that when you're working in exponential space, you need
to divide, not subtract, in order to keep the math working properly.
Also neaten up the output a little bit to make it easier to read.
* add computed voter bags thresholds to node
* fixup some docs
* iter from large bags to small, fulfuilling the contract
* make tests compile
* add VoterBagThresholds to some configs
* ensure that iteration covers all voters even with implied final bag
* use sp_std::boxed::Box;
* fix unused import
* add some more voter bags tests
* file_header.txt
* integrity test to ensure min bag exceeds existential weight
* add more debug assertions about node list length
* rm unused imports
* Kian enters
* Update frame/election-provider-support/src/onchain.rs
Co-authored-by: Zeke Mostov <32168567+emostov@users.noreply.github.com>
* Suggestions for #9081 (Store voters in unsorted bags) (#9328)
* Add some debug asserts to node::get and remove_node
* Improve the debug asserts in remove_node
* improve debug asserts
* Space
* Remove bad assertions
* Tests: WIP take_works
* Take test
* Doc comment
* Apply suggestions from code review
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
* Test storage is cleaned up;
* formatting
* Switch to simpler thresholds
* Update the storage cleanup test
* Remove hardcoded values from benchmark to make it more robust
* Fix tests to acces bags properly
* Sanity check WIP; tests failing
* Update sanity checks to be more correct
* Improve storage cleanup tests
* WIP remote_ext_tests
* Some notes on next steps
* Remove some stuff that was for remote-ext tests
* Some more cleanup to reduce diff
* More :clean:
* Mo cleanin
* small fix
* A lot of changes from kian
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Co-authored-by: kianenigma <kian@parity.io>
* merge fallout
* Run cargo +nightly fmt
* Fix a bunch of stuff, remove not needed runtime arg of make-bags
* add logs
* Glue the new staking bags to the election snapshot (#9415)
* Glue the new staking bags to the election snapshot
* add CheckedRem (#9412)
* add CheckedRem
* fix
* Run fmt
* Test comment
Co-authored-by: Xiliang Chen <xlchen1291@gmail.com>
Co-authored-by: emostov <32168567+emostov@users.noreply.github.com>
* Update node runtime with VoterSnapshotPerBlock
* Unit test for pallet-staking unsorted bags feature (targets #9081) (#9422)
* impl notional_bag_for_works
* Add tests: insert_as_works & insert_works
* Impl test: remove_works
* Trivial cleaning
* Add test: update_position_for_works
* Write out edge case; probably can delete later
* Add test: bags::get_works
* Add test: remove_node_happy_path_works
* Add test: remove_node_bad_paths_documented
* WIP: voting_data_works
* done
* Improve test voting_data_works
* Add comment
* Fill out test basic_setup_works
* Update: iteration_is_semi_sorted
* Improve remove_works
* Update update_position_for_works; create set_ledger_and_free_balance
* Improve get_works
* Improve storage clean up checks in remove test
* Test: impl rebag_works + insert_and_remove_works
* forgot file - Test: impl rebag_works + insert_and_remove_works
* Small tweak
* Update voter_bags test to reflect unused bags are removed
* Unbond & Rebond: do_rebag
* Prevent infinite loops with duplicate tail insert
* Check iter.count on voter list in pre-migrate
* undo strang fmt comment stuff
* Add in todo
Co-authored-by: kianenigma <kian@parity.io>
* Try prepare for master merge
* Reduce diff
* Add comment for test to add
* Add in code TODO for update_position efficiency updates
* Initial impl compiles
* impl StakingVoterListStub
* Sample impl<T: Config> VoterListProvider<T> for VoterList<T>
* impl VoterListProvider for voter-bags
* WIP integrate pallet-voter-bags to staking mock
* the trait `pallet_staking::pallet::pallet::Config` is not implemented for `mock::Test`
* random
* pushing my stuff
* Mock working
* WIP voter list tests
* Add bag insert, remove tests
* Add test for bag insert and remove
* Add remaining tests for VoterList
* Add tests for node
* Add rebag works
* Add rebag extrinsic tests
* Rename to bags-list and name the list .. list!
* Rename VoterBagThresholds => BagThresholds
* Add test count_works
* Test on_update_works
* test sanity check
* a round of test fixes
* push a lot of changes
* my last changes
* all bags-list test work; fmt
* Beautify some tests
* Doc comment for bags-list
* Add insert warnings
* Setup initial benchmark
* Wire up WeightInfo
* is_terminal wip; everything broken!
* Is terminal working
* add TODOs for remove_node
* clean up remoe_node
* Fix all staking tests
* retire VoterBagFor
* commit
* bring in stashed changes
* save
* bench pipeline works now, but I can't run stuff
* sabe
* benchmarks now run, but we have a failure
* WIP: Wire up make_bags
* bags-thresholds compiles
* Fix most build issues
* This will fix all the tests
* move bag thresholds to bags-list
* Move bag-thresholds bin to within pallet-bags
* Remove some unnescary TODOs
* Impl tets wrong_rebag_is_noop
* assert remove is a noop with bad data
* Assert integrity test panics
* Return an error when inserting duplicates
* Update to handle error in staking pallet when inserting to list
* Test contains and on_insert error
* Test re-nominate does not mess up list or count
* Everything builds and works, only the benchmark...
* fuck yeah benchmarks
* more cleanup, more hardening.
* use the bags list again
* fix benhc
* Some questions and changs for List::migration
* Fix migration removed_bags and new_bags usage
* Some trivial aesthetic changes
* Some more trivial changes
* tiny changes/
* mega rename
* fix all tests and ci build
* nit
* Test and fix migration
* nit
* fmt
* cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/staking/src/weights.rs --template=./.maintain/frame-weight-template.hbs
* fmt
* remove unused
* make a few things pub
* make node also pub.. for remote-ext test
* Fix all tests again
* Force bag changes in relevant benchmarks (targets #9507) (#9529)
* force rebag for unbond, rebond, and bond_extra
* nit
* Improve utils
* fmt
* nits
* Move generate_bags to its own pallet
* Get runtime-benchmarks feature setup with prepare_on_update_benchmark
* Withdraw unbonded kill working
* Nominate bench working
* some cleanup
* WIP
* update to check head pre & post conditions
* Add some post condition verification stuff for on_remove
* Update nominate
* fmt
* Improvements
* Fix build
* fix build with polkadot companion
* Update frame/bags-list/src/list/tests.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
* move generate-bag from frame to utils
* wip
* refactor WIP
* WIP save
* Refactor working
* some variable renaming
* WIP: prepare to remove head checks
* Finish MvP refactor
* Some cleanup
* Soem more cleanup
* save
* fix a lot of stuff
* Update client/db/src/bench.rs
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
* Apply suggestions from code review
* Apply suggestions from code review
* Fix some issues that came from trying to merge comments on github
* some small changes
* simplify it
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Co-authored-by: kianenigma <kian@parity.io>
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
* Build works
* Apply suggestions from code review
Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
* Apply suggestions from code review
Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
* Remove commented out debug assert
* Remove some unused deps and some unused benchmarking stuff
* Fix stakings ElectionDataProvider clear
* cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_bags_list --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/bags-list/src/weights.rs --template=./.maintain/frame-weight-template.hbs
* cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_bags_list --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/bags-list/src/weights.rs --template=./.maintain/frame-weight-template.hbs
* cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_bags_list --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/bags-list/src/weights.rs --template=./.maintain/frame-weight-template.hbs
* cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_bags_list --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/bags-list/src/weights.rs --template=./.maintain/frame-weight-template.hbs
* Improving staking pallet-bags-list migration
* fix build and some comments;
* comment
* Reduce visibility in bags list components
* make node.bag_upper only accesible to benchmarks
* Address some feedback; comments updates
* use nominator map comment
* fix vec capacity debug assert
* Apply suggestions from code review
Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
* clarify VoterSnapshotPerBlock
* Reduce diff on create_validators by wrapping with_seed
* Some small improvements to staking benches
* Soem comment updates
* fix vec capacity debug assert ... for real this time
* Reduce ListBags viz
* cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/staking/src/weights.rs --template=./.maintain/frame-weight-template.hbs
* cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/staking/src/weights.rs --template=./.maintain/frame-weight-template.hbs
* Remove supports_eq_unordered & Support eq_unordered
* Update utils/frame/generate-bags/src/lib.rs
Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
* Make total-issuance & minimium-balance CLI args; Dont use emptry ext
* Improve docs for generate bags CLI args
* Apply suggestions from code review
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
* Apply suggestions from code review
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
* Don't use default bags weight in node runtime
* Feature gating sanity_check not working
* Feature gate sanity check by creating duplicate fns
* Fix line wrapping
* Document VoteWeightProvider
* Make bags ext-builder not a module
* Apply suggestions from code review
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
* use pallet_bags_list instead of crate in mock
* Make get_bags test helper fn live in List
* use remove_from_storage_unchecked for node removal
* Remove count of ids removed in remove_many
* Add node sanity check, improve list sanity check
* Do a list sanity check after on_update
* List::migrate: clean up debug assert, exit early when no change in thresholds
* Improve public doc comments for pallet_bags_list::list::List
* Improve public doc comments for pallet_bags_list::list::List
* Update generate bags docs
* Fix grammar in bags-list benchmark
* Add benchmark case for `rebag` extrinsic
* Add count parameter to List::clear; WIP adding MaxEncodedLen to list'
* MaxEncodeLen + generate_storage_info not working for Bag or Node
* Get MaxEncodeLen derive to work
* Try to correctly feature gate SortedListProvider::clear
* Use u32::MAX, not u32::max_value
* Get up to nominators_quota noms
* SortedListProvider::clear takes an Option
* Eplicitly ignore SortedListProvider return value
* Fix doc comment
* Update node-runtime voter snapshot per block
* Add test get_max_len_voters_even_if_some_nominators_are_slashed
* Add test only_iterates_max_2_times_nominators_quota
* Fix generate bags cargo.toml
* use sp_std vec
* Remove v8 migration hooks from pallet-staking
* Update npos trait
* Try respect line width
* cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_bags_list --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/bags-list/src/weights.rs --template=./.maintain/frame-weight-template.hbs
* Update frame/bags-list/src/benchmarks.rs
* Unwrap try-runtime error; remove sortedlistprovider pre upgrade len check
* trigger ci
* restore
* trigger ci
* restore
* trigger ci
* revert
* trigger ci
* revert
Co-authored-by: Peter Goodspeed-Niklaus <coriolinus@users.noreply.github.com>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Co-authored-by: Peter Goodspeed-Niklaus <peter.r.goodspeedniklaus@gmail.com>
Co-authored-by: kianenigma <kian@parity.io>
Co-authored-by: Xiliang Chen <xlchen1291@gmail.com>
Co-authored-by: Parity Benchmarking Bot <admin@parity.io>
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
* Use tokio runtime handle instead of TaskExecutor abstraction
Before this pr we had the `TaskExecutor` abstraction which theoretically
allowed that any futures executor could have been used. However, this
was never tested and is currently not really required. Anyone running a
node currently only used tokio and nothing else (because this was hard
coded in CLI). So, this pr removes the `TaskExecutor` abstraction and
relies directly on the tokio runtime handle.
Besides this changes, this pr also makes sure that the http and ws rpc
server use the same tokio runtime. This fixes a panic that occurred when
you drop the rpc servers inside an async function (tokio doesn't like
that a tokio runtime is dropped in the async context of another tokio
runtime).
As we don't use any custom runtime in the http rpc server anymore, this
pr also removes the `rpc-http-threads` cli argument. If external parties
complain that there aren't enough threads for the rpc server, we could
bring support for increasing the thread count of the tokio runtime.
* FMT
* Fix try runtime
* Fix integration tests and some other optimizations
* Remove warnings
* build the template, hand it over to zeke now.
* Tests working
* save wip
* Some updates
* Some cleanup
* mo cleanin
* Link to issue
* Apply suggestions from code review
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
* Apply suggestions from code review
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
* Apply suggestions from code review
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
* Apply suggestions from code review
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
* Bound accuracy for prepare_election_result
* Use npos_election::Error for phragmms
* save
* Apply suggestions from code review
* Simplify test to use Balancing::set
* Cargo.lock after build
* Revert "Cargo.lock after build"
This reverts commit 7d726c8efa687c09e4f377196b106eb9e9760487.
* Try reduce cargo.lock diff
* Update bin/node/runtime/src/lib.rs
* Comment
* Apply suggestions from code review
* Set balancing directly
* Document som pub items
* Update frame/election-provider-multi-phase/src/unsigned.rs
* Apply suggestions from code review
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
* Improve some comments
* Revert accidental change to random file
* tiney
* revert
Co-authored-by: kianenigma <kian@parity.io>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
* add query types to generate_storage_alias
* adjust comment
* use ValueQuery explicitly for generate_storage_alias with generic value type
* bump impl_version
* adjust line width and add import
* more compilation and formatting fixes
* formatting
* Store the database in a role specific subdirectory
This is a cleaned up version of #8658 fixing #6880
polkadot companion: paritytech/polkadot#2923
* Disable prometheus in tests
* Also change p2p port
* Fix migration logic
* Use different identification file for rocks and parity db
Add tests for paritydb migration
* Migrate Aura pallet to BoundedVec
Implementing issue #8629
* Fixed aura tests after BoundedVec change
* Moved Vec to BoundedVec in authority-discovery
* Merging into the main branch
* Added MaxEncodedLen to crypto
Need this without full_crypto to be able to add generate_store_info
* Add generate_store_info for aura
* Adding changes to Slot to add MaxEncodedLen
* Adding generate_store_info to authority discovery
* fmt
* removing panics in runtime if vec size too large
* authority-discovery: Remove panics in runtime
Can happen if vec size is too large, so truncate the vec in that case
* Adding logging when I truncate Vecs
* Got the sign the other way around
* Reverting pallet_aura changes
This is already being addressed by PR #9371
* Change BoundedVec to WeakBoundedVec
More robust implementation following @thiolliere recommendation.
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
* Support multiple, mergable vesting schedules
* Update node runtime
* Remove some TODO design questions and put them as commennts
* Update frame/vesting/src/benchmarking.rs
* Syntax and comment clean up
* Create filter enum for removing schedules
* Dry vesting calls with do_vest
* Improve old benchmarks to account for max schedules
* Update WeightInfo trait and make dummy fns
* Add merge_schedule weights
* Explicitly test multiple vesting scheudles
* Make new vesting tests more more clear
* Apply suggestions from code review
* Update remove_vesting_schedule to error with no index
* Try reduce spacing diff
* Apply suggestions from code review
* Use get on vesting for bounds check; check origin first
* No filter tuple; various simplifications
* unwrap or default when getting user schedules
* spaces be gone
* ReadMe fixes
* Update frame/vesting/src/lib.rs
Co-authored-by: Peter Goodspeed-Niklaus <coriolinus@users.noreply.github.com>
* address some comments for docs
* merge sched docs
* Apply suggestions from code review
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
* log error when trying to push to vesting vec
* use let Some, not is_some
* remove_vesting_schedule u32, not optin
* new not try_new, create validate builder; VestingInfo
* Merge prep: break out tests and mock
* Add files forgot to include in merge
* revert some accidental changes to merged files
* Revert remaining accidental file changes
* More revert of accidental file change
* Try to reduce diff on tests
* namespace Vesting; check key when key should not exist;
* ending_block throws error on per_block of 0
* Try improve merge vesting info comment
* Update frame/vesting/src/lib.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
* add validate + correct; handle duration > blocknumber
* Move vesting_info module to its own file
* Seperate Vesting/locks updates from writing
* Add can_add_vesting schedule
* Adjust min vested transfer to be greater than all ED
* Initial integrity test impl
* merge_finished_and_yet_to_be_started_schedules
* Make sure to assert storage items are cleaned up
* Migration initial impl (not tested)
* Correct try-runtime hooks
* Apply suggestions from code review
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
* header
* WIP: improve benchmarks
* Benchmarking working
* benchmarking: step over max schedules
* cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_vesting --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/vesting/src/weights.rs --template=./.maintain/frame-weight-template.hbs
* Simplify APIs by accepting vec; convert to bounded on write
* Test: build_genesis_has_storage_version_v1
* Test more error cases
* Hack to get polkadot weights to work; should revert later
* Improve benchmarking; works on polkadot
* cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_vesting --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/vesting/src/weights.rs --template=./.maintain/frame-weight-template.hbs
* WIP override storage
* Set storage not working example
* Remove unused tests
* VestingInfo: make public, derive MaxEndcodedLen
* Rename ending_block to ending_block_as_balance
* Superificial improvements
* Check for end block infinite, not just duration
* More superficial update
* Update tests
* Test vest with multi schedule
* Don't use half max balance in benchmarks
* Use debug_assert when locked is unexpected 0
* Implement exec_action
* Simplify per_block calc in vesting_info
* VestingInfo.validate in add_vesting_schedule & can_add_vesting_schedule
* Simplify post migrate check
* Remove merge event
* Minor benchmarking updates
* Remove VestingInfo.correct
* per_block accesor max with 1
* Improve comment
* Remoe debug
* Fix add schedule comment
* Apply suggestions from code review
Co-authored-by: Peter Goodspeed-Niklaus <coriolinus@users.noreply.github.com>
* no ref for should_remove param
* Remove unused vestingaction derive
* Asserts to show balance unlock in merge benchmark
* Remove unused imports
* trivial
* Fix benchmark asserts to handle non-multiple of 20 locked
* Add generate_storage_info
* migration :facepalm
* Remove per_block 0 logic
* Update frame/vesting/src/lib.rs
* Do not check for ending later than greatest block
* Apply suggestions from code review
* Benchmarks: simplify vesting schedule creation
* Add log back for migration
* Add note in ext docs explaining that all schedules will vest
* Make integrity test work
* Improve integrity test
* Remove unnescary type param from VestingInfo::new
* Remove unnescary resut for ending_block_as_balance
* Remove T param from ending_block_as_balance
* Reduce visibility of raw_per_block
* Remove unused type param for validate
* update old comment
* Make log a dep; log warn in migrate
* VestingInfo.validate returns Err(()), no T type param
* Try improve report_schedule_updates
* is_valid, not validate
* revert node runtime reorg;
* change schedule validity check to just warning
* Simplify merge_vesting_info return type
* Apply suggestions from code review
* Apply suggestions from code review
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
* Add warning for migration
* Fix indentation
* Delete duplicate warnings
* Reduce diff in node runtime
* Fix benchmark build
* Upgrade cargo.toml to use 4.0.0-dev
* Cleanup
* MaxVestingSchedulesGetter initial impl
* MinVestedTransfer getter inintial impl
* Test MaxVestingSchedules & MinVestedTransfer getters; use getters in benchmarks
* Run cargo fmt
* Revert MinVestedTransfer & MaxVestingSchedules getters; Add integrity test
* Make MAX_VESTING_SCHEDULES a const
* fmt
* WIP: benchmark improvements
* Finish benchmark update
* Add test for transfer to account with less than ed
* Rm min_new_account_transfer; move sp-io to dev-dep
* Reduce cargo.toml diff
* Explain MAX_VESTING_SCHEDULES choice
* Fix after merge
* Try fix CI complaints
* cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_vesting --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/vesting/src/weights.rs --template=./.maintain/frame-weight-template.hbs
* cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_vesting --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/vesting/src/weights.rs --template=./.maintain/frame-weight-template.hbs
* fmt
* trigger
* fmt
Co-authored-by: Parity Bot <admin@parity.io>
Co-authored-by: Peter Goodspeed-Niklaus <coriolinus@users.noreply.github.com>
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Co-authored-by: kianenigma <kian@parity.io>
* Split native executor stuff from wasm executor stuff
* Remove `native_runtime_version` in places
* Fix warning
* Fix test warning
* Remove redundant NativeRuntimeInfo trait
* Add a warning for use_native
* Run cargo fmt
* Revert "Add a warning for use_native"
This reverts commit 9494f765a06037e991dd60524f2ed1b14649bfd6.
* Make choosing an executor (native/wasm) an explicit part of service construction
* Add Cargo.lock
* Rename Executor to ExecutorDispatch
* Update bin/node/executor/src/lib.rs
Co-authored-by: Squirrel <gilescope@gmail.com>
* Fix tests
* Fix minor node-executor error
* Fix node cli command thing
Co-authored-by: Squirrel <gilescope@gmail.com>
* Comment out browser stuff
* Remove browser stuff
* Remove more wasm transport code
* Remove ExtTransport and rework how telemetry initialises.
* Change (most) wasm-timer using code to use std::time
* Rename CI-job
* Aura does not compile for wasm
* Remove testing in the browser on CI
* Update README
* Leave `StreamSink` be
* fmt
David