3da069e359
CLI: refactoring: remove Options from sc_service::Configuration's fields ( #5271 )
...
* WIP
Forked at: d6aa8e954cd6aa8e954cd6aa8e954cd6aa8e954cd6aa8e954cd6aa8e954cd6aa8e954cseunlanlege@gmail.com >
* Fail if using proc_macro and build.rs is not set properly
* Dropped all get_ in front of methods
* Clean-up
* Fixing proc macro missing env var
* Get the configuration inside the Runtime (needed for polkadot)
* Clean-up
* Get is_dev from argument like the others
* Get chain ID instead of chain spec from shared params
* &self is passed to spec_factory/load_spec
* Wrong text
* Fix example
* Officialize macro and made a cool doc
* Renamed spec_factory to load_spec (substrate_cli_configuration)
* Removed not so useful ChainSpec
* Renamed SubstrateCLI to SubstrateCli
* Added changelog for impl_version being full now
* Renamed Runtime to Runner
* Update changelog to show example
* Removed option on database cache size
* WIP
Forked at: d6aa8e954cd6aa8e954cd6aa8e954cd6aa8e954cd6aa8e954cd6aa8e954cd6aa8e954cbkchr@users.noreply.github.com >
* Update client/cli/src/commands/runcmd.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/cli/src/commands/export_blocks_cmd.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/cli/src/commands/check_block_cmd.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Update bin/node/cli/src/command.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Update bin/node/cli/src/command.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/cli/src/commands/export_blocks_cmd.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Revert "Update client/cli/src/commands/export_blocks_cmd.rs"
This reverts commit 5906776953392c02beac6bc0bf50f8cbe1a12a01.
* Revert "Update client/cli/src/commands/check_block_cmd.rs"
This reverts commit f705f42b7f3d732be001141afee210fe46a1ef47.
* Revert "Update client/cli/src/commands/export_blocks_cmd.rs"
This reverts commit 8d57c0550164449e6eb2d3bacb04c750c714fcea.
* Revert "Update client/cli/src/commands/runcmd.rs"
This reverts commit 93e74cf5d2e1c0dc49cdff8608d59fc40fc59338.
* Revert "Update client/cli/src/commands/runcmd.rs"
This reverts commit 11d527ba345c0d79f0d3b5b071933d95474d0614.
* Update client/cli/src/commands/export_blocks_cmd.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/cli/src/commands/import_blocks_cmd.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/cli/src/commands/purge_chain_cmd.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Changed ::sc_cli to $crate in the macro
* fixed tests
* fixed conflicts
* Fixing test
* Update client/cli/src/commands/purge_chain_cmd.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/cli/src/params/pruning_params.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Remove comment as suggested
* Apply suggestion
* Update client/cli/src/commands/purge_chain_cmd.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/cli/src/commands/purge_chain_cmd.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/cli/src/commands/purge_chain_cmd.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Update utils/frame/benchmarking-cli/src/command.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/cli/src/runner.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/cli/src/runner.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/cli/src/runner.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/cli/src/params/pruning_params.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/cli/src/params/node_key_params.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/cli/src/params/network_params.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/cli/src/lib.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/cli/src/config.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Added doc
* Fixed error introduced after applying suggestion
* Revert "Update client/cli/src/params/pruning_params.rs"
This reverts commit 0574d06a4f1efd86e94c1214420a12e7a4be0099.
* Print error
* Apply suggestions from code review
* Remove useless Results
* Fixed CI failing on polkadot approval
Co-authored-by: Seun Lanlege <seunlanlege@gmail.com >
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
2020-04-07 11:38:07 +02:00
433824511e
Reset benchmarks by removing post-genesis changes ( #5435 )
...
* Reset by removing pos-genesis changes
* CLI option for DB cache size
* Update Cargo.lock
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com >
2020-04-01 14:08:23 +02:00
b472d60a52
Batch benchmarks together with * notation. ( #5436 )
...
* Batch benchmarks together with `*` notation.
* Fix short structopt conflict
* Return error if `batches` is empty
* Move fast benchmarks macro into `frame_benchmarking` (#5445 )
* Move macro into `frame_benchmarking`
* Update docs
* Extra line
* Return error if `batches` is empty
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com >
2020-03-31 15:20:09 +02:00
408455f8bc
Build for only one target for docs.rs ( #5427 )
...
* Add docs.rs metadata to all cargo.toml files
* Remove docs.rs metada in substrate's cargo.toml
2020-03-30 09:46:30 +02:00
1242a7df3c
Upgrade parity-scale-codec to 1.3.0 ( #5443 )
2020-03-28 22:16:05 +01:00
ba06d5ef64
Releasing 2.0.0-alpha.5 ( #5340 )
...
* bump pre-version
* Changelog alpha.4->alpha.5
* repo + homepage to sp-consensus-vrf
* Add default rocksdb feature to `frame-benchmarking-cli` (#5367 )
* Add default rocksdb feature
* Update Cargo.toml
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com >
2020-03-24 15:08:02 +01:00
0c10687022
Regression algorithm for runtime benchmarks ( #5288 )
...
* Add linregress
* Regression, initial stuff.
* More analytics
* whitespace
* Fix
* Median slopes regression algo
* Warnings
* Update to lastest benchmark changes.
* Use both algorithms temp.
* Move analysis to frame.
* Fix tests.
* Only build analysis in std
Co-authored-by: Gav Wood <gavin@parity.io >
2020-03-23 14:07:25 +01:00
400a62680f
Benchmark Im Online Pallet ( #5318 )
...
* Initial benchmarking setup
* Add keystore
* validate unsigned
* Update frame/im-online/src/benchmarking.rs
Co-Authored-By: Marcio Diaz <marcio.diaz@gmail.com >
* Fix verify_unsigned benchmark
* add variable for teting the external addresss length
* Update frame/im-online/src/benchmarking.rs
Co-Authored-By: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* Update utils/frame/benchmarking-cli/src/lib.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
Co-authored-by: Marcio Diaz <marcio.diaz@gmail.com >
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
Co-authored-by: Benjamin Kampmann <ben@gnunicorn.org >
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
2020-03-20 12:42:00 +01:00
25e25a83b9
Releasing 2.0.0-alpha.4 ( #5279 )
...
* Version bump
* Split generate_changelog.sh into separate script
Can be run in the format `generate_changelog.sh $previous_version $version`.
* remove early exit from publish_draft_release.sh
* adding changelog
* ci: change last_github_release to also find pre-releases
Co-authored-by: Martin Pugh <pugh@s3kr.it >
2020-03-18 14:37:21 +01:00
372745705d
create parallel tasks extension ( #5249 )
2020-03-16 16:30:39 +01:00
dc0bf210fb
ChainSpec trait ( #5185 )
...
* ChainSpec trait
* Apply suggestions from code review
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Added docs
* Fixed build
* Fixed build
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
2020-03-12 00:00:10 +01:00
914ce67fd7
Add dev chain as default chain for benchmarks. ( #5204 )
2020-03-11 12:44:48 +01:00
93ee3104e7
Use CLI to configure max instances cache ( #5177 )
...
* Use CLI to configure max instances cache
* Fix tests
* Move default value into CLI
* Use SmallVec
* Apply review comments
* Get rid of `SmallVec`
Co-authored-by: Bastian Köcher <git@kchr.de >
2020-03-11 09:43:37 +01:00
f21680209f
Minor fixes for Android compilation ( #5209 )
...
* Minor fixes for Android
* Update parity-multiaddr
* Bump in service Cargo.toml too
2020-03-10 20:54:58 +01:00
1cfcf5cbfe
Don't include :code by default in storage proofs ( #5179 )
...
* Don't include `:code` by default in storage proofs (#5060 )
* Adds test to verify that the runtime currently is always contained in
the proof
* Start passing the runtime wasm code from the outside
* Fix compilation
* More build fixes
* Make the test work as expected now :)
* Last fixes
* Fixes benchmarks
* Review feedback
* Apply suggestions from code review
Co-Authored-By: Sergei Pepyakin <sergei@parity.io >
* Review feedback
* Fix compilation
Co-authored-by: Sergei Pepyakin <s.pepyakin@gmail.com >
* Fix compilation and change the way `RuntimeCode` works
* Fix tests
* Switch to `Cow`
Co-authored-by: Benjamin Kampmann <ben@gnunicorn.org >
Co-authored-by: Sergei Pepyakin <s.pepyakin@gmail.com >
2020-03-10 11:13:20 +01:00
9a1b3b53f2
Revert "Don't include :code by default in storage proofs ( #5060 )" ( #5136 )
...
This reverts commit 6ee39261c8
2020-03-05 10:55:05 +01:00
6ee39261c8
Don't include :code by default in storage proofs ( #5060 )
...
* Adds test to verify that the runtime currently is always contained in
the proof
* Start passing the runtime wasm code from the outside
* Fix compilation
* More build fixes
* Make the test work as expected now :)
* Last fixes
* Fixes benchmarks
* Review feedback
* Apply suggestions from code review
Co-Authored-By: Sergei Pepyakin <sergei@parity.io >
* Review feedback
* Fix compilation
Co-authored-by: Sergei Pepyakin <s.pepyakin@gmail.com >
2020-03-04 20:26:16 +01:00
a1b53280b4
Update to SCALE 1.2.0 ( #5113 )
...
This updates `parity-scale-codec` to `1.2.0`, which includes multiple
performance improvements and a fix that bounds the capacity of a vector
at decoding.
2020-03-03 14:40:02 +01:00
347b5d641c
Add options to overwrite range bounds in benchmark command. ( #5072 )
...
* Add --mins --maxs to benchmark command.
* Apply review suggestions.
2020-02-28 15:40:42 +01:00
d39605d9cd
Propagate DispatchError for benchmarks. ( #5075 )
...
* Propagate DispatchError for benchmarks.
* Apply review suggestions.
* Use RuntimeString.
* fix expect
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
2020-02-28 12:05:27 +01:00
25d1b7878a
prepping for Alpha.3 ( #5080 )
...
* Bump to alpha.3
* update gitlab-ci
2020-02-27 22:06:08 +01:00
d6aa8e954c
set missing metadata fields, prepping alpha.2 ( #5067 )
...
* setting first batch of descriptions
* fix what I just broke
* next batch
* and pallets, too
* last batch
* set cargo.lock
* keep'em dev-deps
* bump version to alpha.2
2020-02-27 00:22:44 +01:00
e2776f42f9
prepare version to alpha.1 ( #5055 )
...
bump version to -alpha.1
2020-02-25 21:44:23 +01:00
d024364503
Add steps setting to benchmarking CLI ( #5033 )
...
* Add steps setting to CLI, use max value to hit worst case.
* Bump impl_version.
* Apply review suggestion.
2020-02-25 15:51:25 +01:00
ad90ab7ec9
Add storage root recalculation time to benchmarks ( #5035 )
2020-02-24 18:07:38 +01:00
c412c6230e
Cargo.toml fixups for the release ( #4975 )
...
* setting versions to development pre-release
fixing version in dependencies
* unset already released wasm-builder
* do not publish test crates
* adding licenses
* setting homepage metadata
* set repository url
2020-02-21 17:07:00 +01:00
e8000e7429
Add tests & Service's Configuration has optional fields that shouldn't be optional ( #4842 )
...
Related to #4776
Related to https://github.com/paritytech/polkadot/pull/832
To summarize the changes:
1. I did not manage to validate with types the service's Configuration. But I did reduce the possibility of errors by moving all the "fill" functions to their respective structopts
2. I split params.rs to multiple modules: one module params for just CLI parameters and one module commands for CLI subcommands (and RunCmd). Every command and params are in their own file so things are grouped better together and easier to remove
3. I removed the run and run_subcommand helpers as they are not helping much anymore. Running a command is always a set of 3 commands: 1. init 2. update config 3. run. This still allow the user to change the config before arguments get parsed or right after.
4. I added tests for all subcommands.
5. [deleted]
Overall the aim is to improve the situation with the Configuration and the optional parameters, add tests, make the API more consistent and simpler.
2020-02-21 13:53:01 +01:00
b4ebd41c21
Consolidate frame benchmarking into a frame crate ( #4977 )
...
This prs cleans up some of the frame benchmarking stuff:
- Move CLI into `frame-benchmarking-cli`. No frame related CLI should
exists in the default Substrate CLI.
- Move all traits and types related to frame benchmarking into the
`frame-benchmarking` trait. Frame types should be isolated in Frame.
2020-02-19 10:22:36 +01:00
Cecile Tonglet