// Copyright 2017-2019 Parity Technologies (UK) Ltd. // This file is part of Substrate. // Substrate is free software: you can redistribute it and/or modify // it under the terms of the GNU General Public License as published by // the Free Software Foundation, either version 3 of the License, or // (at your option) any later version. // Substrate is distributed in the hope that it will be useful, // but WITHOUT ANY WARRANTY; without even the implied warranty of // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the // GNU General Public License for more details. // You should have received a copy of the GNU General Public License // along with Substrate. If not, see . //! Election module for stake-weighted membership selection of a collective. //! //! The composition of a set of account IDs works according to one or more approval votes //! weighted by stake. There is a partial carry-over facility to give greater weight to those //! whose voting is serially unsuccessful. #![cfg_attr(not(feature = "std"), no_std)] #![recursion_limit="128"] use rstd::prelude::*; use sr_primitives::{ RuntimeDebug, print, traits::{Zero, One, StaticLookup, Bounded, Saturating}, weights::SimpleDispatchInfo, }; use support::{ dispatch::Result, decl_storage, decl_event, ensure, decl_module, traits::{ Currency, ExistenceRequirement, Get, LockableCurrency, LockIdentifier, OnUnbalanced, ReservableCurrency, WithdrawReason, WithdrawReasons, ChangeMembers } }; use codec::{Encode, Decode}; use system::{self, ensure_signed, ensure_root}; mod mock; mod tests; // no polynomial attacks: // // all unbonded public operations should be constant time. // all other public operations must be linear time in terms of prior public operations and: // - those "valid" ones that cost nothing be limited to a constant number per single protected // operation // - the rest costing the same order as the computational complexity // all protected operations must complete in at most O(public operations) // // we assume "beneficial" transactions will have the same access as attack transactions. // // any storage requirements should be bonded by the same order as the volume. // public operations: // - express approvals (you pay in a "voter" bond the first time you do this; O(1); one extra DB // entry, one DB change) // - remove active voter (you get your "voter" bond back; O(1); one fewer DB entry, one DB change) // - remove inactive voter (either you or the target is removed; if the target, you get their // "voter" bond back; O(1); one fewer DB entry, one DB change) // - submit candidacy (you pay a "candidate" bond; O(1); one extra DB entry, two DB changes) // - present winner/runner-up (you may pay a "presentation" bond of O(voters) if the presentation // is invalid; O(voters) compute; ) protected operations: // - remove candidacy (remove all votes for a candidate) (one fewer DB entry, two DB changes) // to avoid a potentially problematic case of not-enough approvals prior to voting causing a // back-to-back votes that have no way of ending, then there's a forced grace period between votes. // to keep the system as stateless as possible (making it a bit easier to reason about), we just // restrict when votes can begin to blocks that lie on boundaries (`voting_period`). // for an approval vote of C members: // top K runners-up are maintained between votes. all others are discarded. // - candidate removed & bond returned when elected. // - candidate removed & bond burned when discarded. // at the point that the vote ends (), all voters' balances are snapshotted. // for B blocks following, there's a counting period whereby each of the candidates that believe // they fall in the top K+C voted can present themselves. they get the total stake // recorded (based on the snapshot); an ordered list is maintained (the leaderboard). Noone may // present themselves that, if elected, would result in being included twice in the collective // (important since existing members will have their approval votes as it may be that they // don't get removed), nor if existing presenters would mean they're not in the top K+C. // following B blocks, the top C candidates are elected and have their bond returned. the top C // candidates and all other candidates beyond the top C+K are cleared. // vote-clearing happens lazily; for an approval to count, the most recent vote at the time of the // voter's most recent vote must be no later than the most recent vote at the time that the // candidate in the approval position was registered there. as candidates are removed from the // register and others join in their place, this prevents an approval meant for an earlier candidate // being used to elect a new candidate. // the candidate list increases as needed, but the contents (though not really the capacity) reduce // after each vote as all but K entries are cleared. newly registering candidates must use cleared // entries before they increase the capacity. /// The activity status of a voter. #[derive(PartialEq, Eq, Copy, Clone, Encode, Decode, Default, RuntimeDebug)] pub struct VoterInfo { /// Last VoteIndex in which this voter assigned (or initialized) approvals. last_active: VoteIndex, /// Last VoteIndex in which one of this voter's approvals won. /// Note that `last_win = N` indicates a last win at index `N-1`, hence `last_win = 0` means no /// win ever. last_win: VoteIndex, /// The amount of stored weight as a result of not winning but changing approvals. pot: Balance, /// Current staked amount. A lock equal to this value always exists. stake: Balance, } /// Used to demonstrate the status of a particular index in the global voter list. #[derive(PartialEq, Eq, RuntimeDebug)] pub enum CellStatus { /// Any out of bound index. Means a push a must happen to the chunk pointed by `NextVoterSet`. /// Voting fee is applied in case a new chunk is created. Head, /// Already occupied by another voter. Voting fee is applied. Occupied, /// Empty hole which should be filled. No fee will be applied. Hole, } const MODULE_ID: LockIdentifier = *b"py/elect"; /// Number of voters grouped in one chunk. pub const VOTER_SET_SIZE: usize = 64; /// NUmber of approvals grouped in one chunk. pub const APPROVAL_SET_SIZE: usize = 8; type BalanceOf = <::Currency as Currency<::AccountId>>::Balance; type NegativeImbalanceOf = <::Currency as Currency<::AccountId>>::NegativeImbalance; /// Index used to access chunks. type SetIndex = u32; /// Index used to count voting rounds. pub type VoteIndex = u32; /// Underlying data type of the approvals. type ApprovalFlag = u32; /// Number of approval flags that can fit into [`ApprovalFlag`] type. const APPROVAL_FLAG_LEN: usize = 32; pub trait Trait: system::Trait { type Event: From> + Into<::Event>; /// The currency that people are electing with. type Currency: LockableCurrency + ReservableCurrency; /// Handler for the unbalanced reduction when slashing a validator. type BadPresentation: OnUnbalanced>; /// Handler for the unbalanced reduction when slashing an invalid reaping attempt. type BadReaper: OnUnbalanced>; /// Handler for the unbalanced reduction when submitting a bad `voter_index`. type BadVoterIndex: OnUnbalanced>; /// Handler for the unbalanced reduction when a candidate has lost (and is not a runner up) type LoserCandidate: OnUnbalanced>; /// What to do when the members change. type ChangeMembers: ChangeMembers; /// How much should be locked up in order to submit one's candidacy. A reasonable /// default value is 9. type CandidacyBond: Get>; /// How much should be locked up in order to be able to submit votes. type VotingBond: Get>; /// The amount of fee paid upon each vote submission, unless if they submit a /// _hole_ index and replace it. type VotingFee: Get>; /// Minimum about that can be used as the locked value for voting. type MinimumVotingLock: Get>; /// The punishment, per voter, if you provide an invalid presentation. A /// reasonable default value is 1. type PresentSlashPerVoter: Get>; /// How many runners-up should have their approvals persist until the next /// vote. A reasonable default value is 2. type CarryCount: Get; /// How many vote indices need to go by after a target voter's last vote before /// they can be reaped if their approvals are moot. A reasonable default value /// is 1. type InactiveGracePeriod: Get; /// How often (in blocks) to check for new votes. A reasonable default value /// is 1000. type VotingPeriod: Get; /// Decay factor of weight when being accumulated. It should typically be set to /// __at least__ `membership_size -1` to keep the collective secure. /// When set to `N`, it indicates `(1/N)^t` of staked is decayed at weight /// increment step `t`. 0 will result in no weight being added at all (normal /// approval voting). A reasonable default value is 24. type DecayRatio: Get; } decl_storage! { trait Store for Module as Council { // ---- parameters /// How long to give each top candidate to present themselves after the vote ends. pub PresentationDuration get(fn presentation_duration) config(): T::BlockNumber; /// How long each position is active for. pub TermDuration get(fn term_duration) config(): T::BlockNumber; /// Number of accounts that should constitute the collective. pub DesiredSeats get(fn desired_seats) config(): u32; // ---- permanent state (always relevant, changes only at the finalization of voting) /// The current membership. When there's a vote going on, this should still be used for /// executive matters. The block number (second element in the tuple) is the block that /// their position is active until (calculated by the sum of the block number when the /// member was elected and their term duration). pub Members get(fn members) config(): Vec<(T::AccountId, T::BlockNumber)>; /// The total number of vote rounds that have happened or are in progress. pub VoteCount get(fn vote_index): VoteIndex; // ---- persistent state (always relevant, changes constantly) // A list of votes for each voter. The votes are stored as numeric values and parsed in a // bit-wise manner. In order to get a human-readable representation (`Vec`), use // [`all_approvals_of`]. Furthermore, each vector of scalars is chunked with the cap of // `APPROVAL_SET_SIZE`. pub ApprovalsOf get(fn approvals_of): map (T::AccountId, SetIndex) => Vec; /// The vote index and list slot that the candidate `who` was registered or `None` if they /// are not currently registered. pub RegisterInfoOf get(fn candidate_reg_info): map T::AccountId => Option<(VoteIndex, u32)>; /// Basic information about a voter. pub VoterInfoOf get(fn voter_info): map T::AccountId => Option>>; /// The present voter list (chunked and capped at [`VOTER_SET_SIZE`]). pub Voters get(fn voters): map SetIndex => Vec>; /// the next free set to store a voter in. This will keep growing. pub NextVoterSet get(fn next_nonfull_voter_set): SetIndex = 0; /// Current number of Voters. pub VoterCount get(fn voter_count): SetIndex = 0; /// The present candidate list. pub Candidates get(fn candidates): Vec; // has holes /// Current number of active candidates pub CandidateCount get(fn candidate_count): u32; // ---- temporary state (only relevant during finalization/presentation) /// The accounts holding the seats that will become free on the next tally. pub NextFinalize get(fn next_finalize): Option<(T::BlockNumber, u32, Vec)>; /// Get the leaderboard if we're in the presentation phase. The first element is the weight /// of each entry; It may be the direct summed approval stakes, or a weighted version of it. /// Sorted from low to high. pub Leaderboard get(fn leaderboard): Option, T::AccountId)> >; /// Who is able to vote for whom. Value is the fund-holding account, key is the /// vote-transaction-sending account. pub Proxy get(fn proxy): map T::AccountId => Option; } } decl_module! { pub struct Module for enum Call where origin: T::Origin { /// How much should be locked up in order to submit one's candidacy. A reasonable /// default value is 9. const CandidacyBond: BalanceOf = T::CandidacyBond::get(); /// How much should be locked up in order to be able to submit votes. const VotingBond: BalanceOf = T::VotingBond::get(); /// The amount of fee paid upon each vote submission, unless if they submit a /// _hole_ index and replace it. const VotingFee: BalanceOf = T::VotingFee::get(); /// The punishment, per voter, if you provide an invalid presentation. A /// reasonable default value is 1. const PresentSlashPerVoter: BalanceOf = T::PresentSlashPerVoter::get(); /// How many runners-up should have their approvals persist until the next /// vote. A reasonable default value is 2. const CarryCount: u32 = T::CarryCount::get(); /// How many vote indices need to go by after a target voter's last vote before /// they can be reaped if their approvals are moot. A reasonable default value /// is 1. const InactiveGracePeriod: VoteIndex = T::InactiveGracePeriod::get(); /// How often (in blocks) to check for new votes. A reasonable default value /// is 1000. const VotingPeriod: T::BlockNumber = T::VotingPeriod::get(); /// Minimum about that can be used as the locked value for voting. const MinimumVotingLock: BalanceOf = T::MinimumVotingLock::get(); /// Decay factor of weight when being accumulated. It should typically be set to /// __at least__ `membership_size -1` to keep the collective secure. /// When set to `N`, it indicates `(1/N)^t` of staked is decayed at weight /// increment step `t`. 0 will result in no weight being added at all (normal /// approval voting). A reasonable default value is 24. const DecayRatio: u32 = T::DecayRatio::get(); /// The chunk size of the voter vector. const VOTER_SET_SIZE: u32 = VOTER_SET_SIZE as u32; /// The chunk size of the approval vector. const APPROVAL_SET_SIZE: u32 = APPROVAL_SET_SIZE as u32; fn deposit_event() = default; /// Set candidate approvals. Approval slots stay valid as long as candidates in those slots /// are registered. /// /// Locks `value` from the balance of `origin` indefinitely. Only [`retract_voter`] or /// [`reap_inactive_voter`] can unlock the balance. /// /// `hint` argument is interpreted differently based on: /// - if `origin` is setting approvals for the first time: The index will be checked for /// being a valid _hole_ in the voter list. /// - if the hint is correctly pointing to a hole, no fee is deducted from `origin`. /// - Otherwise, the call will succeed but the index is ignored and simply a push to the /// last chunk with free space happens. If the new push causes a new chunk to be /// created, a fee indicated by [`VotingFee`] is deducted. /// - if `origin` is already a voter: the index __must__ be valid and point to the correct /// position of the `origin` in the current voters list. /// /// Note that any trailing `false` votes in `votes` is ignored; In approval voting, not /// voting for a candidate and voting false, are equal. /// /// # /// - O(1). /// - Two extra DB entries, one DB change. /// - Argument `votes` is limited in length to number of candidates. /// # #[weight = SimpleDispatchInfo::FixedNormal(2_500_000)] fn set_approvals( origin, votes: Vec, #[compact] index: VoteIndex, hint: SetIndex, #[compact] value: BalanceOf ) -> Result { let who = ensure_signed(origin)?; Self::do_set_approvals(who, votes, index, hint, value) } /// Set candidate approvals from a proxy. Approval slots stay valid as long as candidates in /// those slots are registered. /// /// # /// - Same as `set_approvals` with one additional storage read. /// # #[weight = SimpleDispatchInfo::FixedNormal(2_500_000)] fn proxy_set_approvals(origin, votes: Vec, #[compact] index: VoteIndex, hint: SetIndex, #[compact] value: BalanceOf ) -> Result { let who = Self::proxy(ensure_signed(origin)?).ok_or("not a proxy")?; Self::do_set_approvals(who, votes, index, hint, value) } /// Remove a voter. For it not to be a bond-consuming no-op, all approved candidate indices /// must now be either unregistered or registered to a candidate that registered the slot /// after the voter gave their last approval set. /// /// Both indices must be provided as explained in [`voter_at`] function. /// /// May be called by anyone. Returns the voter deposit to `signed`. /// /// # /// - O(1). /// - Two fewer DB entries, one DB change. /// # #[weight = SimpleDispatchInfo::FixedNormal(2_500_000)] fn reap_inactive_voter( origin, #[compact] reporter_index: u32, who: ::Source, #[compact] who_index: u32, #[compact] assumed_vote_index: VoteIndex ) { let reporter = ensure_signed(origin)?; let who = T::Lookup::lookup(who)?; ensure!(!Self::presentation_active(), "cannot reap during presentation period"); ensure!(Self::voter_info(&reporter).is_some(), "reporter must be a voter"); let info = Self::voter_info(&who) .ok_or("target for inactivity cleanup must be active")?; let last_active = info.last_active; ensure!(assumed_vote_index == Self::vote_index(), "vote index not current"); ensure!( assumed_vote_index > last_active + T::InactiveGracePeriod::get(), "cannot reap during grace period" ); let reporter_index = reporter_index as usize; let who_index = who_index as usize; let assumed_reporter = Self::voter_at(reporter_index).ok_or("invalid reporter index")?; let assumed_who = Self::voter_at(who_index).ok_or("invalid target index")?; ensure!(assumed_reporter == reporter, "bad reporter index"); ensure!(assumed_who == who, "bad target index"); // will definitely kill one of reporter or who now. let valid = !Self::all_approvals_of(&who).iter() .zip(Self::candidates().iter()) .any(|(&appr, addr)| appr && *addr != T::AccountId::default() && // defensive only: all items in candidates list are registered Self::candidate_reg_info(addr).map_or(false, |x| x.0 <= last_active) ); Self::remove_voter( if valid { &who } else { &reporter }, if valid { who_index } else { reporter_index } ); T::Currency::remove_lock( MODULE_ID, if valid { &who } else { &reporter } ); if valid { // This only fails if `reporter` doesn't exist, which it clearly must do since its // the origin. Still, it's no more harmful to propagate any error at this point. T::Currency::repatriate_reserved(&who, &reporter, T::VotingBond::get())?; Self::deposit_event(RawEvent::VoterReaped(who, reporter)); } else { let imbalance = T::Currency::slash_reserved(&reporter, T::VotingBond::get()).0; T::BadReaper::on_unbalanced(imbalance); Self::deposit_event(RawEvent::BadReaperSlashed(reporter)); } } /// Remove a voter. All votes are cancelled and the voter deposit is returned. /// /// The index must be provided as explained in [`voter_at`] function. /// /// Also removes the lock on the balance of the voter. See [`do_set_approvals()`]. /// /// # /// - O(1). /// - Two fewer DB entries, one DB change. /// # #[weight = SimpleDispatchInfo::FixedNormal(1_250_000)] fn retract_voter(origin, #[compact] index: u32) { let who = ensure_signed(origin)?; ensure!(!Self::presentation_active(), "cannot retract when presenting"); ensure!(>::exists(&who), "cannot retract non-voter"); let index = index as usize; let voter = Self::voter_at(index).ok_or("retraction index invalid")?; ensure!(voter == who, "retraction index mismatch"); Self::remove_voter(&who, index); T::Currency::unreserve(&who, T::VotingBond::get()); T::Currency::remove_lock(MODULE_ID, &who); } /// Submit oneself for candidacy. /// /// Account must have enough transferrable funds in it to pay the bond. /// /// NOTE: if `origin` has already assigned approvals via [`set_approvals`], /// it will NOT have any usable funds to pass candidacy bond and must first retract. /// Note that setting approvals will lock the entire balance of the voter until /// retraction or being reported. /// /// # /// - Independent of input. /// - Three DB changes. /// # #[weight = SimpleDispatchInfo::FixedNormal(2_500_000)] fn submit_candidacy(origin, #[compact] slot: u32) { let who = ensure_signed(origin)?; ensure!(!Self::is_a_candidate(&who), "duplicate candidate submission"); let slot = slot as usize; let count = Self::candidate_count() as usize; let candidates = Self::candidates(); ensure!( (slot == count && count == candidates.len()) || (slot < candidates.len() && candidates[slot] == T::AccountId::default()), "invalid candidate slot" ); // NOTE: This must be last as it has side-effects. T::Currency::reserve(&who, T::CandidacyBond::get()) .map_err(|_| "candidate has not enough funds")?; >::insert(&who, (Self::vote_index(), slot as u32)); let mut candidates = candidates; if slot == candidates.len() { candidates.push(who); } else { candidates[slot] = who; } >::put(candidates); CandidateCount::put(count as u32 + 1); } /// Claim that `candidate` is one of the top `carry_count + desired_seats` candidates. Only /// works iff the presentation period is active. `candidate` should have at least collected /// some non-zero `total` votes and `origin` must have enough funds to pay for a potential /// slash. /// /// # /// - O(voters) compute. /// - One DB change. /// # #[weight = SimpleDispatchInfo::FixedNormal(10_000_000)] fn present_winner( origin, candidate: ::Source, #[compact] total: BalanceOf, #[compact] index: VoteIndex ) -> Result { let who = ensure_signed(origin)?; ensure!( !total.is_zero(), "stake deposited to present winner and be added to leaderboard should be non-zero", ); let candidate = T::Lookup::lookup(candidate)?; ensure!(index == Self::vote_index(), "index not current"); let (_, _, expiring) = Self::next_finalize() .ok_or("cannot present outside of presentation period")?; let bad_presentation_punishment = T::PresentSlashPerVoter::get() * BalanceOf::::from(Self::voter_count() as u32); ensure!( T::Currency::can_slash(&who, bad_presentation_punishment), "presenter must have sufficient slashable funds" ); let mut leaderboard = Self::leaderboard() .ok_or("leaderboard must exist while present phase active")?; ensure!(total > leaderboard[0].0, "candidate not worthy of leaderboard"); if let Some(p) = Self::members().iter().position(|&(ref c, _)| c == &candidate) { ensure!( p < expiring.len(), "candidate must not form a duplicated member if elected" ); } let voters = Self::all_voters(); let (registered_since, candidate_index): (VoteIndex, u32) = Self::candidate_reg_info(&candidate).ok_or("presented candidate must be current")?; let actual_total = voters.iter() .filter_map(|maybe_voter| maybe_voter.as_ref()) .filter_map(|voter| match Self::voter_info(voter) { Some(b) if b.last_active >= registered_since => { let last_win = b.last_win; let now = Self::vote_index(); let stake = b.stake; let offset = Self::get_offset(stake, now - last_win); let weight = stake + offset + b.pot; if Self::approvals_of_at(voter, candidate_index as usize) { Some(weight) } else { None } }, _ => None, }) .fold(Zero::zero(), |acc, n| acc + n); let dupe = leaderboard.iter().find(|&&(_, ref c)| c == &candidate).is_some(); if total == actual_total && !dupe { // insert into leaderboard leaderboard[0] = (total, candidate); leaderboard.sort_by_key(|&(t, _)| t); >::put(leaderboard); Ok(()) } else { // we can rest assured it will be Ok since we checked `can_slash` earlier; still // better safe than sorry. let imbalance = T::Currency::slash(&who, bad_presentation_punishment).0; T::BadPresentation::on_unbalanced(imbalance); Err(if dupe { "duplicate presentation" } else { "incorrect total" }) } } /// Set the desired member count; if lower than the current count, then seats will not be up /// election when they expire. If more, then a new vote will be started if one is not /// already in progress. #[weight = SimpleDispatchInfo::FixedOperational(10_000)] fn set_desired_seats(origin, #[compact] count: u32) { ensure_root(origin)?; DesiredSeats::put(count); } /// Remove a particular member from the set. This is effective immediately. /// /// Note: A tally should happen instantly (if not already in a presentation /// period) to fill the seat if removal means that the desired members are not met. #[weight = SimpleDispatchInfo::FixedOperational(10_000)] fn remove_member(origin, who: ::Source) { ensure_root(origin)?; let who = T::Lookup::lookup(who)?; let new_set: Vec<(T::AccountId, T::BlockNumber)> = Self::members() .into_iter() .filter(|i| i.0 != who) .collect(); >::put(&new_set); let new_set = new_set.into_iter().map(|x| x.0).collect::>(); T::ChangeMembers::change_members(&[], &[who], new_set); } /// Set the presentation duration. If there is currently a vote being presented for, will /// invoke `finalize_vote`. #[weight = SimpleDispatchInfo::FixedOperational(10_000)] fn set_presentation_duration(origin, #[compact] count: T::BlockNumber) { ensure_root(origin)?; >::put(count); } /// Set the presentation duration. If there is current a vote being presented for, will /// invoke `finalize_vote`. #[weight = SimpleDispatchInfo::FixedOperational(10_000)] fn set_term_duration(origin, #[compact] count: T::BlockNumber) { ensure_root(origin)?; >::put(count); } fn on_initialize(n: T::BlockNumber) { if let Err(e) = Self::end_block(n) { print("Guru meditation"); print(e); } } } } decl_event!( pub enum Event where ::AccountId { /// reaped voter, reaper VoterReaped(AccountId, AccountId), /// slashed reaper BadReaperSlashed(AccountId), /// A tally (for approval votes of seat(s)) has started. TallyStarted(u32), /// A tally (for approval votes of seat(s)) has ended (with one or more new members). TallyFinalized(Vec, Vec), } ); impl Module { // exposed immutables. /// True if we're currently in a presentation period. pub fn presentation_active() -> bool { >::exists() } /// If `who` a candidate at the moment? pub fn is_a_candidate(who: &T::AccountId) -> bool { >::exists(who) } /// Iff the member `who` still has a seat at blocknumber `n` returns `true`. pub fn will_still_be_member_at(who: &T::AccountId, n: T::BlockNumber) -> bool { Self::members().iter() .find(|&&(ref a, _)| a == who) .map(|&(_, expires)| expires > n) .unwrap_or(false) } /// Determine the block that a vote can happen on which is no less than `n`. pub fn next_vote_from(n: T::BlockNumber) -> T::BlockNumber { let voting_period = T::VotingPeriod::get(); (n + voting_period - One::one()) / voting_period * voting_period } /// The block number on which the tally for the next election will happen. `None` only if the /// desired seats of the set is zero. pub fn next_tally() -> Option { let desired_seats = Self::desired_seats(); if desired_seats == 0 { None } else { let c = Self::members(); let (next_possible, count, coming) = if let Some((tally_end, comers, leavers)) = Self::next_finalize() { // if there's a tally in progress, then next tally can begin immediately afterwards (tally_end, c.len() - leavers.len() + comers as usize, comers) } else { (>::block_number(), c.len(), 0) }; if count < desired_seats as usize { Some(next_possible) } else { // next tally begins once enough members expire to bring members below desired. if desired_seats <= coming { // the entire amount of desired seats is less than those new members - we'll // have to wait until they expire. Some(next_possible + Self::term_duration()) } else { Some(c[c.len() - (desired_seats - coming) as usize].1) } }.map(Self::next_vote_from) } } // Private /// Check there's nothing to do this block fn end_block(block_number: T::BlockNumber) -> Result { if (block_number % T::VotingPeriod::get()).is_zero() { if let Some(number) = Self::next_tally() { if block_number == number { Self::start_tally(); } } } if let Some((number, _, _)) = Self::next_finalize() { if block_number == number { Self::finalize_tally()? } } Ok(()) } /// Remove a voter at a specified index from the system. fn remove_voter(voter: &T::AccountId, index: usize) { let (set_index, vec_index) = Self::split_index(index, VOTER_SET_SIZE); let mut set = Self::voters(set_index); set[vec_index] = None; >::insert(set_index, set); VoterCount::mutate(|c| *c = *c - 1); Self::remove_all_approvals_of(voter); >::remove(voter); } /// Actually do the voting. /// /// The voter index must be provided as explained in [`voter_at`] function. fn do_set_approvals( who: T::AccountId, votes: Vec, index: VoteIndex, hint: SetIndex, value: BalanceOf, ) -> Result { let candidates_len = ::Candidates::decode_len().unwrap_or(0_usize); ensure!(!Self::presentation_active(), "no approval changes during presentation period"); ensure!(index == Self::vote_index(), "incorrect vote index"); ensure!( !candidates_len.is_zero(), "amount of candidates to receive approval votes should be non-zero" ); // Prevent a vote from voters that provide a list of votes that exceeds the candidates // length since otherwise an attacker may be able to submit a very long list of `votes` that // far exceeds the amount of candidates and waste more computation than a reasonable voting // bond would cover. ensure!( candidates_len >= votes.len(), "amount of candidate votes cannot exceed amount of candidates" ); ensure!(value >= T::MinimumVotingLock::get(), "locked value must be more than limit"); // Amount to be locked up. let mut locked_balance = value.min(T::Currency::total_balance(&who)); let mut pot_to_set = Zero::zero(); let hint = hint as usize; if let Some(info) = Self::voter_info(&who) { // already a voter. Index must be valid. No fee. update pot. O(1) let voter = Self::voter_at(hint).ok_or("invalid voter index")?; ensure!(voter == who, "wrong voter index"); // write new accumulated offset. let last_win = info.last_win; let now = index; let offset = Self::get_offset(info.stake, now - last_win); pot_to_set = info.pot + offset; } else { // not yet a voter. Index _could be valid_. Fee might apply. Bond will be reserved O(1). ensure!( T::Currency::free_balance(&who) > T::VotingBond::get(), "new voter must have sufficient funds to pay the bond" ); let (set_index, vec_index) = Self::split_index(hint, VOTER_SET_SIZE); match Self::cell_status(set_index, vec_index) { CellStatus::Hole => { // requested cell was a valid hole. >::mutate(set_index, |set| set[vec_index] = Some(who.clone())); }, CellStatus::Head | CellStatus::Occupied => { // Either occupied or out-of-range. let next = Self::next_nonfull_voter_set(); let set_len = >::decode_len(next).unwrap_or(0_usize); // Caused a new set to be created. Pay for it. // This is the last potential error. Writes will begin afterwards. if set_len == 0 { let imbalance = T::Currency::withdraw( &who, T::VotingFee::get(), WithdrawReason::Fee, ExistenceRequirement::KeepAlive, )?; T::BadVoterIndex::on_unbalanced(imbalance); // NOTE: this is safe since the `withdraw()` will check this. locked_balance -= T::VotingFee::get(); } if set_len + 1 == VOTER_SET_SIZE { NextVoterSet::put(next + 1); } >::append_or_insert(next, &[Some(who.clone())][..]) } } T::Currency::reserve(&who, T::VotingBond::get())?; VoterCount::mutate(|c| *c = *c + 1); } T::Currency::set_lock( MODULE_ID, &who, locked_balance, T::BlockNumber::max_value(), WithdrawReasons::all(), ); >::insert( &who, VoterInfo::> { last_active: index, last_win: index, stake: locked_balance, pot: pot_to_set, } ); Self::set_approvals_chunked(&who, votes); Ok(()) } /// Close the voting, record the number of seats that are actually up for grabs. fn start_tally() { let members = Self::members(); let desired_seats = Self::desired_seats() as usize; let number = >::block_number(); let expiring = members.iter().take_while(|i| i.1 <= number).map(|i| i.0.clone()).collect::>(); let retaining_seats = members.len() - expiring.len(); if retaining_seats < desired_seats { let empty_seats = desired_seats - retaining_seats; >::put( (number + Self::presentation_duration(), empty_seats as u32, expiring) ); // initialize leaderboard. let leaderboard_size = empty_seats + T::CarryCount::get() as usize; >::put(vec![(BalanceOf::::zero(), T::AccountId::default()); leaderboard_size]); Self::deposit_event(RawEvent::TallyStarted(empty_seats as u32)); } } /// Finalize the vote, removing each of the `removals` and inserting `seats` of the most /// approved candidates in their place. If the total number of members is less than the desired /// membership a new vote is started. Clears all presented candidates, returning the bond of the /// elected ones. fn finalize_tally() -> Result { let (_, coming, expiring): (T::BlockNumber, u32, Vec) = >::take() .ok_or("finalize can only be called after a tally is started.")?; let leaderboard: Vec<(BalanceOf, T::AccountId)> = >::take() .unwrap_or_default(); let new_expiry = >::block_number() + Self::term_duration(); // return bond to winners. let candidacy_bond = T::CandidacyBond::get(); let incoming: Vec<_> = leaderboard.iter() .rev() .take_while(|&&(b, _)| !b.is_zero()) .take(coming as usize) .map(|(_, a)| a) .cloned() .inspect(|a| { T::Currency::unreserve(a, candidacy_bond); }) .collect(); // Update last win index for anyone voted for any of the incomings. incoming.iter().filter_map(|i| Self::candidate_reg_info(i)).for_each(|r| { let index = r.1 as usize; Self::all_voters() .iter() .filter_map(|mv| mv.as_ref()) .filter(|v| Self::approvals_of_at(*v, index)) .for_each(|v| >::mutate(v, |a| { if let Some(activity) = a { activity.last_win = Self::vote_index() + 1; } })); }); let members = Self::members(); let outgoing: Vec<_> = members.iter() .take(expiring.len()) .map(|a| a.0.clone()).collect(); // set the new membership set. let mut new_set: Vec<_> = members .into_iter() .skip(expiring.len()) .chain(incoming.iter().cloned().map(|a| (a, new_expiry))) .collect(); new_set.sort_by_key(|&(_, expiry)| expiry); >::put(&new_set); let new_set = new_set.into_iter().map(|x| x.0).collect::>(); T::ChangeMembers::change_members(&incoming, &outgoing, new_set); // clear all except runners-up from candidate list. let candidates = Self::candidates(); let mut new_candidates = vec![T::AccountId::default(); candidates.len()]; // shrink later. let runners_up = leaderboard.into_iter() .rev() .take_while(|&(b, _)| !b.is_zero()) .skip(coming as usize) .filter_map(|(_, a)| Self::candidate_reg_info(&a).map(|i| (a, i.1))); let mut count = 0u32; for (address, slot) in runners_up { new_candidates[slot as usize] = address; count += 1; } for (old, new) in candidates.iter().zip(new_candidates.iter()) { // candidate is not a runner up. if old != new { // removed - kill it >::remove(old); // and candidate is not a winner. if incoming.iter().find(|e| *e == old).is_none() { // slash the bond. let (imbalance, _) = T::Currency::slash_reserved(&old, T::CandidacyBond::get()); T::LoserCandidate::on_unbalanced(imbalance); } } } // discard any superfluous slots. if let Some(last_index) = new_candidates .iter() .rposition(|c| *c != T::AccountId::default()) { new_candidates.truncate(last_index + 1); } Self::deposit_event(RawEvent::TallyFinalized(incoming, outgoing)); >::put(new_candidates); CandidateCount::put(count); VoteCount::put(Self::vote_index() + 1); Ok(()) } /// Get the set and vector index of a global voter index. /// /// Note that this function does not take holes into account. /// See [`voter_at`]. fn split_index(index: usize, scale: usize) -> (SetIndex, usize) { let set_index = (index / scale) as u32; let vec_index = index % scale; (set_index, vec_index) } /// Return a concatenated vector over all voter sets. fn all_voters() -> Vec> { let mut all = >::get(0); let mut index = 1; // NOTE: we could also use `Self::next_nonfull_voter_set()` here but that might change based // on how we do chunking. This is more generic. loop { let next_set = >::get(index); if next_set.is_empty() { break; } else { index += 1; all.extend(next_set); } } all } /// Shorthand for fetching a voter at a specific (global) index. /// /// NOTE: this function is used for checking indices. Yet, it does not take holes into account. /// This means that any account submitting an index at any point in time should submit: /// `VOTER_SET_SIZE * set_index + local_index`, meaning that you are ignoring all holes in the /// first `set_index` sets. fn voter_at(index: usize) -> Option { let (set_index, vec_index) = Self::split_index(index, VOTER_SET_SIZE); let set = Self::voters(set_index); if vec_index < set.len() { set[vec_index].clone() } else { None } } /// A more sophisticated version of `voter_at`. Will be kept separate as most often it is an /// overdue compared to `voter_at`. Only used when setting approvals. fn cell_status(set_index: SetIndex, vec_index: usize) -> CellStatus { let set = Self::voters(set_index); if vec_index < set.len() { if let Some(_) = set[vec_index] { CellStatus::Occupied } else { CellStatus::Hole } } else { CellStatus::Head } } /// Sets the approval of a voter in a chunked manner. fn set_approvals_chunked(who: &T::AccountId, approvals: Vec) { let approvals_flag_vec = Self::bool_to_flag(approvals); approvals_flag_vec .chunks(APPROVAL_SET_SIZE) .enumerate() .for_each(|(index, slice)| >::insert( (&who, index as SetIndex), slice) ); } /// shorthand for fetching a specific approval of a voter at a specific (global) index. /// /// Using this function to read a vote is preferred as it reads `APPROVAL_SET_SIZE` items of /// type `ApprovalFlag` from storage at most; not all of them. /// /// Note that false is returned in case of no-vote or an explicit `false`. fn approvals_of_at(who: &T::AccountId, index: usize) -> bool { let (flag_index, bit) = Self::split_index(index, APPROVAL_FLAG_LEN); let (set_index, vec_index) = Self::split_index(flag_index as usize, APPROVAL_SET_SIZE); let set = Self::approvals_of((who.clone(), set_index)); if vec_index < set.len() { // This is because bit_at treats numbers in lsb -> msb order. let reversed_index = set.len() - 1 - vec_index; Self::bit_at(set[reversed_index], bit) } else { false } } /// Return true of the bit `n` of scalar `x` is set to `1` and false otherwise. fn bit_at(x: ApprovalFlag, n: usize) -> bool { if n < APPROVAL_FLAG_LEN { x & ( 1 << n ) != 0 } else { false } } /// Convert a vec of boolean approval flags to a vec of integers, as denoted by /// the type `ApprovalFlag`. see `bool_to_flag_should_work` test for examples. pub fn bool_to_flag(x: Vec) -> Vec { let mut result: Vec = Vec::with_capacity(x.len() / APPROVAL_FLAG_LEN); if x.is_empty() { return result; } result.push(0); let mut index = 0; let mut counter = 0; loop { let shl_index = counter % APPROVAL_FLAG_LEN; result[index] += (if x[counter] { 1 } else { 0 }) << shl_index; counter += 1; if counter > x.len() - 1 { break; } if counter % APPROVAL_FLAG_LEN == 0 { result.push(0); index += 1; } } result } /// Convert a vec of flags (u32) to boolean. pub fn flag_to_bool(chunk: Vec) -> Vec { let mut result = Vec::with_capacity(chunk.len()); if chunk.is_empty() { return vec![] } chunk.into_iter() .map(|num| (0..APPROVAL_FLAG_LEN).map(|bit| Self::bit_at(num, bit)).collect::>() ) .for_each(|c| { let last_approve = match c.iter().rposition(|n| *n) { Some(index) => index + 1, None => 0 }; result.extend(c.into_iter().take(last_approve)); }); result } /// Return a concatenated vector over all approvals of a voter as boolean. /// The trailing zeros are removed. fn all_approvals_of(who: &T::AccountId) -> Vec { let mut all: Vec = vec![]; let mut index = 0_u32; loop { let chunk = Self::approvals_of((who.clone(), index)); if chunk.is_empty() { break; } all.extend(Self::flag_to_bool(chunk)); index += 1; } all } /// Remove all approvals associated with one account. fn remove_all_approvals_of(who: &T::AccountId) { let mut index = 0; loop { let set = Self::approvals_of((who.clone(), index)); if set.len() > 0 { >::remove((who.clone(), index)); index += 1; } else { break } } } /// Calculates the offset value (stored pot) of a stake, based on the distance /// to the last win_index, `t`. Regardless of the internal implementation, /// it should always be used with the following structure: /// /// Given Stake of voter `V` being `x` and distance to last_win index `t`, the new weight /// of `V` is `x + get_offset(x, t)`. /// /// In other words, this function returns everything extra that should be added /// to a voter's stake value to get the correct weight. Indeed, zero is /// returned if `t` is zero. fn get_offset(stake: BalanceOf, t: VoteIndex) -> BalanceOf { let decay_ratio: BalanceOf = T::DecayRatio::get().into(); if t > 150 { return stake * decay_ratio } let mut offset = stake; let mut r = Zero::zero(); let decay = decay_ratio + One::one(); for _ in 0..t { offset = offset.saturating_sub(offset / decay); r += offset } r } }