// Copyright 2019-2020 Parity Technologies (UK) Ltd. // This file is part of Substrate. // Substrate is free software: you can redistribute it and/or modify // it under the terms of the GNU General Public License as published by // the Free Software Foundation, either version 3 of the License, or // (at your option) any later version. // Substrate is distributed in the hope that it will be useful, // but WITHOUT ANY WARRANTY; without even the implied warranty of // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the // GNU General Public License for more details. // You should have received a copy of the GNU General Public License // along with Substrate. If not, see . //! FRAME Pallet that tracks the last finalized block, as perceived by block authors. #![cfg_attr(not(feature = "std"), no_std)] use sp_inherents::{InherentIdentifier, ProvideInherent, InherentData, MakeFatalError}; use sp_runtime::traits::{One, Zero, SaturatedConversion}; use sp_std::{prelude::*, result, cmp, vec}; use frame_support::{decl_module, decl_storage, decl_error, ensure}; use frame_support::traits::Get; use frame_system::{ensure_none, Trait as SystemTrait}; use sp_finality_tracker::{INHERENT_IDENTIFIER, FinalizedInherentData}; pub const DEFAULT_WINDOW_SIZE: u32 = 101; pub const DEFAULT_REPORT_LATENCY: u32 = 1000; pub trait Trait: SystemTrait { /// Something which can be notified when the timestamp is set. Set this to `()` /// if not needed. type OnFinalizationStalled: OnFinalizationStalled; /// The number of recent samples to keep from this chain. Default is 101. type WindowSize: Get; /// The delay after which point things become suspicious. Default is 1000. type ReportLatency: Get; } decl_storage! { trait Store for Module as Timestamp { /// Recent hints. RecentHints get(fn recent_hints) build(|_| vec![T::BlockNumber::zero()]): Vec; /// Ordered recent hints. OrderedHints get(fn ordered_hints) build(|_| vec![T::BlockNumber::zero()]): Vec; /// The median. Median get(fn median) build(|_| T::BlockNumber::zero()): T::BlockNumber; /// Final hint to apply in the block. `None` means "same as parent". Update: Option; // when initialized through config this is set in the beginning. Initialized get(fn initialized) build(|_| false): bool; } } decl_error! { pub enum Error for Module { /// Final hint must be updated only once in the block AlreadyUpdated, /// Finalized height above block number BadHint, } } decl_module! { pub struct Module for enum Call where origin: T::Origin { type Error = Error; /// The number of recent samples to keep from this chain. Default is 101. const WindowSize: T::BlockNumber = T::WindowSize::get(); /// The delay after which point things become suspicious. Default is 1000. const ReportLatency: T::BlockNumber = T::ReportLatency::get(); /// Hint that the author of this block thinks the best finalized /// block is the given number. fn final_hint(origin, #[compact] hint: T::BlockNumber) { ensure_none(origin)?; ensure!(!::Update::exists(), Error::::AlreadyUpdated); ensure!( frame_system::Module::::block_number() >= hint, Error::::BadHint, ); ::Update::put(hint); } fn on_finalize() { Self::update_hint(::Update::take()) } } } impl Module { fn update_hint(hint: Option) { if !Self::initialized() { ::RecentHints::put(vec![T::BlockNumber::zero()]); ::OrderedHints::put(vec![T::BlockNumber::zero()]); ::Median::put(T::BlockNumber::zero()); ::Initialized::put(true); } let mut recent = Self::recent_hints(); let mut ordered = Self::ordered_hints(); let window_size = cmp::max(T::BlockNumber::one(), T::WindowSize::get()); let hint = hint.unwrap_or_else(|| recent.last() .expect("always at least one recent sample; qed").clone() ); // prune off the front of the list -- typically 1 except for when // the sample size has just been shrunk. { // take into account the item we haven't pushed yet. let to_prune = (recent.len() + 1).saturating_sub(window_size.saturated_into::()); for drained in recent.drain(..to_prune) { let idx = ordered.binary_search(&drained) .expect("recent and ordered contain the same items; qed"); ordered.remove(idx); } } // find the position in the ordered list where the new item goes. let ordered_idx = ordered.binary_search(&hint) .unwrap_or_else(|idx| idx); ordered.insert(ordered_idx, hint); recent.push(hint); let two = T::BlockNumber::one() + T::BlockNumber::one(); let median = { let len = ordered.len(); assert!(len > 0, "pruning dictated by window_size which is always saturated at 1; qed"); if len % 2 == 0 { let a = ordered[len / 2]; let b = ordered[(len / 2) - 1]; // compute average. (a + b) / two } else { ordered[len / 2] } }; let our_window_size = recent.len() as u32; ::RecentHints::put(recent); ::OrderedHints::put(ordered); ::Median::put(median); if T::BlockNumber::from(our_window_size) == window_size { let now = frame_system::Module::::block_number(); let latency = T::ReportLatency::get(); // the delay is the latency plus half the window size. let delay = latency + (window_size / two); // median may be at most n - delay if median + delay <= now { T::OnFinalizationStalled::on_stalled(window_size - T::BlockNumber::one(), median); } } } } /// Called when finalization stalled at a given number. #[impl_trait_for_tuples::impl_for_tuples(30)] pub trait OnFinalizationStalled { /// The parameter here is how many more blocks to wait before applying /// changes triggered by finality stalling. fn on_stalled(further_wait: N, median: N); } impl ProvideInherent for Module { type Call = Call; type Error = MakeFatalError<()>; const INHERENT_IDENTIFIER: InherentIdentifier = INHERENT_IDENTIFIER; fn create_inherent(data: &InherentData) -> Option { if let Ok(final_num) = data.finalized_number() { // make hint only when not same as last to avoid bloat. Self::recent_hints().last().and_then(|last| if last == &final_num { None } else { Some(Call::final_hint(final_num)) }) } else { None } } fn check_inherent(_call: &Self::Call, _data: &InherentData) -> result::Result<(), Self::Error> { Ok(()) } } #[cfg(test)] mod tests { use super::*; use sp_io::TestExternalities; use sp_core::H256; use sp_runtime::{ testing::Header, Perbill, traits::{BlakeTwo256, IdentityLookup, OnFinalize, Header as HeaderT}, }; use frame_support::{assert_ok, impl_outer_origin, parameter_types, weights::Weight}; use frame_system as system; use std::cell::RefCell; #[derive(Clone, PartialEq, Debug)] pub struct StallEvent { at: u64, further_wait: u64, } #[derive(Clone, Eq, PartialEq)] pub struct Test; impl_outer_origin! { pub enum Origin for Test where system = frame_system {} } thread_local! { static NOTIFICATIONS: RefCell> = Default::default(); } pub struct StallTracker; impl OnFinalizationStalled for StallTracker { fn on_stalled(further_wait: u64, _median: u64) { let now = System::block_number(); NOTIFICATIONS.with(|v| v.borrow_mut().push(StallEvent { at: now, further_wait })); } } parameter_types! { pub const BlockHashCount: u64 = 250; pub const MaximumBlockWeight: Weight = 1024; pub const MaximumBlockLength: u32 = 2 * 1024; pub const AvailableBlockRatio: Perbill = Perbill::one(); } impl system::Trait for Test { type Origin = Origin; type Index = u64; type BlockNumber = u64; type Call = (); type Hash = H256; type Hashing = BlakeTwo256; type AccountId = u64; type Lookup = IdentityLookup; type Header = Header; type Event = (); type BlockHashCount = BlockHashCount; type MaximumBlockWeight = MaximumBlockWeight; type AvailableBlockRatio = AvailableBlockRatio; type MaximumBlockLength = MaximumBlockLength; type Version = (); type ModuleToIndex = (); type AccountData = (); type OnNewAccount = (); type OnKilledAccount = (); } parameter_types! { pub const WindowSize: u64 = 11; pub const ReportLatency: u64 = 100; } impl Trait for Test { type OnFinalizationStalled = StallTracker; type WindowSize = WindowSize; type ReportLatency = ReportLatency; } type System = system::Module; type FinalityTracker = Module; #[test] fn median_works() { let t = system::GenesisConfig::default().build_storage::().unwrap(); TestExternalities::new(t).execute_with(|| { FinalityTracker::update_hint(Some(500)); assert_eq!(FinalityTracker::median(), 250); assert!(NOTIFICATIONS.with(|n| n.borrow().is_empty())); }); } #[test] fn notifies_when_stalled() { let t = system::GenesisConfig::default().build_storage::().unwrap(); TestExternalities::new(t).execute_with(|| { let mut parent_hash = System::parent_hash(); for i in 2..106 { System::initialize( &i, &parent_hash, &Default::default(), &Default::default(), Default::default() ); FinalityTracker::on_finalize(i); let hdr = System::finalize(); parent_hash = hdr.hash(); } assert_eq!( NOTIFICATIONS.with(|n| n.borrow().clone()), vec![StallEvent { at: 105, further_wait: 10 }] ) }); } #[test] fn recent_notifications_prevent_stalling() { let t = system::GenesisConfig::default().build_storage::().unwrap(); TestExternalities::new(t).execute_with(|| { let mut parent_hash = System::parent_hash(); for i in 2..106 { System::initialize( &i, &parent_hash, &Default::default(), &Default::default(), Default::default(), ); assert_ok!(FinalityTracker::dispatch( Call::final_hint(i-1), Origin::NONE, )); FinalityTracker::on_finalize(i); let hdr = System::finalize(); parent_hash = hdr.hash(); } assert!(NOTIFICATIONS.with(|n| n.borrow().is_empty())); }); } }