// Copyright 2019-2021 Parity Technologies (UK) Ltd. // This file is part of Parity Bridges Common. // Parity Bridges Common is free software: you can redistribute it and/or modify // it under the terms of the GNU General Public License as published by // the Free Software Foundation, either version 3 of the License, or // (at your option) any later version. // Parity Bridges Common is distributed in the hope that it will be useful, // but WITHOUT ANY WARRANTY; without even the implied warranty of // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the // GNU General Public License for more details. // You should have received a copy of the GNU General Public License // along with Parity Bridges Common. If not, see . //! Everything required to serve Millau <-> Rialto messages. use crate::Runtime; use bp_messages::{ source_chain::{SenderOrigin, TargetHeaderChain}, target_chain::{ProvedMessages, SourceHeaderChain}, InboundLaneData, LaneId, Message, MessageNonce, Parameter as MessagesParameter, }; use bp_runtime::{Chain, ChainId, MILLAU_CHAIN_ID, RIALTO_CHAIN_ID}; use bridge_runtime_common::messages::{self, MessageBridge, MessageTransaction}; use codec::{Decode, Encode}; use frame_support::{ parameter_types, weights::{DispatchClass, Weight}, RuntimeDebug, }; use scale_info::TypeInfo; use sp_runtime::{traits::Saturating, FixedPointNumber, FixedU128}; use sp_std::{convert::TryFrom, ops::RangeInclusive}; /// Initial value of `MillauToRialtoConversionRate` parameter. pub const INITIAL_MILLAU_TO_RIALTO_CONVERSION_RATE: FixedU128 = FixedU128::from_inner(FixedU128::DIV); /// Initial value of `MillauFeeMultiplier` parameter. pub const INITIAL_MILLAU_FEE_MULTIPLIER: FixedU128 = FixedU128::from_inner(FixedU128::DIV); parameter_types! { /// Millau to Rialto conversion rate. Initially we treat both tokens as equal. pub storage MillauToRialtoConversionRate: FixedU128 = INITIAL_MILLAU_TO_RIALTO_CONVERSION_RATE; /// Fee multiplier value at Millau chain. pub storage MillauFeeMultiplier: FixedU128 = INITIAL_MILLAU_FEE_MULTIPLIER; } /// Message payload for Rialto -> Millau messages. pub type ToMillauMessagePayload = messages::source::FromThisChainMessagePayload; /// Message verifier for Rialto -> Millau messages. pub type ToMillauMessageVerifier = messages::source::FromThisChainMessageVerifier; /// Message payload for Millau -> Rialto messages. pub type FromMillauMessagePayload = messages::target::FromBridgedChainMessagePayload; /// Encoded Rialto Call as it comes from Millau. pub type FromMillauEncodedCall = messages::target::FromBridgedChainEncodedMessageCall; /// Call-dispatch based message dispatch for Millau -> Rialto messages. pub type FromMillauMessageDispatch = messages::target::FromBridgedChainMessageDispatch< WithMillauMessageBridge, crate::Runtime, pallet_balances::Pallet, (), >; /// Messages proof for Millau -> Rialto messages. pub type FromMillauMessagesProof = messages::target::FromBridgedChainMessagesProof; /// Messages delivery proof for Rialto -> Millau messages. pub type ToMillauMessagesDeliveryProof = messages::source::FromBridgedChainMessagesDeliveryProof; /// Millau <-> Rialto message bridge. #[derive(RuntimeDebug, Clone, Copy)] pub struct WithMillauMessageBridge; impl MessageBridge for WithMillauMessageBridge { const RELAYER_FEE_PERCENT: u32 = 10; const THIS_CHAIN_ID: ChainId = RIALTO_CHAIN_ID; const BRIDGED_CHAIN_ID: ChainId = MILLAU_CHAIN_ID; const BRIDGED_MESSAGES_PALLET_NAME: &'static str = bp_rialto::WITH_RIALTO_MESSAGES_PALLET_NAME; type ThisChain = Rialto; type BridgedChain = Millau; fn bridged_balance_to_this_balance( bridged_balance: bp_millau::Balance, bridged_to_this_conversion_rate_override: Option, ) -> bp_rialto::Balance { let conversion_rate = bridged_to_this_conversion_rate_override .unwrap_or_else(|| MillauToRialtoConversionRate::get()); bp_rialto::Balance::try_from(conversion_rate.saturating_mul_int(bridged_balance)) .unwrap_or(bp_rialto::Balance::MAX) } } /// Rialto chain from message lane point of view. #[derive(RuntimeDebug, Clone, Copy)] pub struct Rialto; impl messages::ChainWithMessages for Rialto { type Hash = bp_rialto::Hash; type AccountId = bp_rialto::AccountId; type Signer = bp_rialto::AccountSigner; type Signature = bp_rialto::Signature; type Weight = Weight; type Balance = bp_rialto::Balance; } impl messages::ThisChainWithMessages for Rialto { type Origin = crate::Origin; type Call = crate::Call; fn is_message_accepted(send_origin: &Self::Origin, lane: &LaneId) -> bool { send_origin.linked_account().is_some() && (*lane == [0, 0, 0, 0] || *lane == [0, 0, 0, 1]) } fn maximal_pending_messages_at_outbound_lane() -> MessageNonce { MessageNonce::MAX } fn estimate_delivery_confirmation_transaction() -> MessageTransaction { let inbound_data_size = InboundLaneData::::encoded_size_hint( bp_rialto::MAXIMAL_ENCODED_ACCOUNT_ID_SIZE, 1, 1, ) .unwrap_or(u32::MAX); MessageTransaction { dispatch_weight: bp_rialto::MAX_SINGLE_MESSAGE_DELIVERY_CONFIRMATION_TX_WEIGHT, size: inbound_data_size .saturating_add(bp_millau::EXTRA_STORAGE_PROOF_SIZE) .saturating_add(bp_rialto::TX_EXTRA_BYTES), } } fn transaction_payment(transaction: MessageTransaction) -> bp_rialto::Balance { // `transaction` may represent transaction from the future, when multiplier value will // be larger, so let's use slightly increased value let multiplier = FixedU128::saturating_from_rational(110, 100) .saturating_mul(pallet_transaction_payment::Pallet::::next_fee_multiplier()); // in our testnets, both per-byte fee and weight-to-fee are 1:1 messages::transaction_payment( bp_rialto::BlockWeights::get().get(DispatchClass::Normal).base_extrinsic, 1, multiplier, |weight| weight as _, transaction, ) } } /// Millau chain from message lane point of view. #[derive(RuntimeDebug, Clone, Copy)] pub struct Millau; impl messages::ChainWithMessages for Millau { type Hash = bp_millau::Hash; type AccountId = bp_millau::AccountId; type Signer = bp_millau::AccountSigner; type Signature = bp_millau::Signature; type Weight = Weight; type Balance = bp_millau::Balance; } impl messages::BridgedChainWithMessages for Millau { fn maximal_extrinsic_size() -> u32 { bp_millau::Millau::max_extrinsic_size() } fn message_weight_limits(_message_payload: &[u8]) -> RangeInclusive { // we don't want to relay too large messages + keep reserve for future upgrades let upper_limit = messages::target::maximal_incoming_message_dispatch_weight( bp_millau::Millau::max_extrinsic_weight(), ); // we're charging for payload bytes in `WithMillauMessageBridge::transaction_payment` // function // // this bridge may be used to deliver all kind of messages, so we're not making any // assumptions about minimal dispatch weight here 0..=upper_limit } fn estimate_delivery_transaction( message_payload: &[u8], include_pay_dispatch_fee_cost: bool, message_dispatch_weight: Weight, ) -> MessageTransaction { let message_payload_len = u32::try_from(message_payload.len()).unwrap_or(u32::MAX); let extra_bytes_in_payload = Weight::from(message_payload_len) .saturating_sub(pallet_bridge_messages::EXPECTED_DEFAULT_MESSAGE_LENGTH.into()); MessageTransaction { dispatch_weight: extra_bytes_in_payload .saturating_mul(bp_millau::ADDITIONAL_MESSAGE_BYTE_DELIVERY_WEIGHT) .saturating_add(bp_millau::DEFAULT_MESSAGE_DELIVERY_TX_WEIGHT) .saturating_sub(if include_pay_dispatch_fee_cost { 0 } else { bp_millau::PAY_INBOUND_DISPATCH_FEE_WEIGHT }) .saturating_add(message_dispatch_weight), size: message_payload_len .saturating_add(bp_rialto::EXTRA_STORAGE_PROOF_SIZE) .saturating_add(bp_millau::TX_EXTRA_BYTES), } } fn transaction_payment(transaction: MessageTransaction) -> bp_millau::Balance { // we don't have a direct access to the value of multiplier at Millau chain // => it is a messages module parameter let multiplier = MillauFeeMultiplier::get(); // in our testnets, both per-byte fee and weight-to-fee are 1:1 messages::transaction_payment( bp_millau::BlockWeights::get().get(DispatchClass::Normal).base_extrinsic, 1, multiplier, |weight| weight as _, transaction, ) } } impl TargetHeaderChain for Millau { type Error = &'static str; // The proof is: // - hash of the header this proof has been created with; // - the storage proof of one or several keys; // - id of the lane we prove state of. type MessagesDeliveryProof = ToMillauMessagesDeliveryProof; fn verify_message(payload: &ToMillauMessagePayload) -> Result<(), Self::Error> { messages::source::verify_chain_message::(payload) } fn verify_messages_delivery_proof( proof: Self::MessagesDeliveryProof, ) -> Result<(LaneId, InboundLaneData), Self::Error> { messages::source::verify_messages_delivery_proof::< WithMillauMessageBridge, Runtime, crate::MillauGrandpaInstance, >(proof) } } impl SourceHeaderChain for Millau { type Error = &'static str; // The proof is: // - hash of the header this proof has been created with; // - the storage proof of one or several keys; // - id of the lane we prove messages for; // - inclusive range of messages nonces that are proved. type MessagesProof = FromMillauMessagesProof; fn verify_messages_proof( proof: Self::MessagesProof, messages_count: u32, ) -> Result>, Self::Error> { messages::target::verify_messages_proof::< WithMillauMessageBridge, Runtime, crate::MillauGrandpaInstance, >(proof, messages_count) } } impl SenderOrigin for crate::Origin { fn linked_account(&self) -> Option { match self.caller { crate::OriginCaller::system(frame_system::RawOrigin::Signed(ref submitter)) => Some(submitter.clone()), crate::OriginCaller::system(frame_system::RawOrigin::Root) | crate::OriginCaller::system(frame_system::RawOrigin::None) => crate::RootAccountForPayments::get(), _ => None, } } } /// Rialto -> Millau message lane pallet parameters. #[derive(RuntimeDebug, Clone, Encode, Decode, PartialEq, Eq, TypeInfo)] pub enum RialtoToMillauMessagesParameter { /// The conversion formula we use is: `RialtoTokens = MillauTokens * conversion_rate`. MillauToRialtoConversionRate(FixedU128), } impl MessagesParameter for RialtoToMillauMessagesParameter { fn save(&self) { match *self { RialtoToMillauMessagesParameter::MillauToRialtoConversionRate(ref conversion_rate) => MillauToRialtoConversionRate::set(conversion_rate), } } } #[cfg(test)] mod tests { use super::*; use crate::{ AccountId, Call, DbWeight, ExistentialDeposit, MillauGrandpaInstance, Runtime, SystemCall, SystemConfig, WithMillauMessagesInstance, VERSION, }; use bp_message_dispatch::CallOrigin; use bp_messages::{ target_chain::{DispatchMessage, DispatchMessageData, MessageDispatch}, MessageKey, }; use bp_runtime::{derive_account_id, messages::DispatchFeePayment, Chain, SourceAccount}; use bridge_runtime_common::{ assert_complete_bridge_types, integrity::{ assert_complete_bridge_constants, AssertBridgeMessagesPalletConstants, AssertBridgePalletNames, AssertChainConstants, AssertCompleteBridgeConstants, }, messages::target::{FromBridgedChainEncodedMessageCall, FromBridgedChainMessagePayload}, }; use frame_support::{ traits::Currency, weights::{GetDispatchInfo, WeightToFeePolynomial}, }; use sp_runtime::traits::Convert; #[test] fn transfer_happens_when_dispatch_fee_is_paid_at_target_chain() { // this test actually belongs to the `bridge-runtime-common` crate, but there we have no // mock runtime. Making another one there just for this test, given that both crates // live n single repo is an overkill let mut ext: sp_io::TestExternalities = SystemConfig::default().build_storage::().unwrap().into(); ext.execute_with(|| { let bridge = MILLAU_CHAIN_ID; let call: Call = SystemCall::set_heap_pages { pages: 64 }.into(); let dispatch_weight = call.get_dispatch_info().weight; let dispatch_fee = ::WeightToFee::calc( &dispatch_weight, ); assert!(dispatch_fee > 0); // create relayer account with minimal balance let relayer_account: AccountId = [1u8; 32].into(); let initial_amount = ExistentialDeposit::get(); let _ = as Currency>::deposit_creating( &relayer_account, initial_amount, ); // create dispatch account with minimal balance + dispatch fee let dispatch_account = derive_account_id::< ::SourceChainAccountId, >(bridge, SourceAccount::Root); let dispatch_account = ::AccountIdConverter::convert( dispatch_account, ); let _ = as Currency>::deposit_creating( &dispatch_account, initial_amount + dispatch_fee, ); // dispatch message with intention to pay dispatch fee at the target chain FromMillauMessageDispatch::dispatch( &relayer_account, DispatchMessage { key: MessageKey { lane_id: Default::default(), nonce: 0 }, data: DispatchMessageData { payload: Ok(FromBridgedChainMessagePayload:: { spec_version: VERSION.spec_version, weight: dispatch_weight, origin: CallOrigin::SourceRoot, dispatch_fee_payment: DispatchFeePayment::AtTargetChain, call: FromBridgedChainEncodedMessageCall::new(call.encode()), }), fee: 1, }, }, ); // ensure that fee has been transferred from dispatch to relayer account assert_eq!( as Currency>::free_balance( &relayer_account ), initial_amount + dispatch_fee, ); assert_eq!( as Currency>::free_balance( &dispatch_account ), initial_amount, ); }); } #[test] fn ensure_rialto_message_lane_weights_are_correct() { type Weights = pallet_bridge_messages::weights::MillauWeight; pallet_bridge_messages::ensure_weights_are_correct::( bp_rialto::DEFAULT_MESSAGE_DELIVERY_TX_WEIGHT, bp_rialto::ADDITIONAL_MESSAGE_BYTE_DELIVERY_WEIGHT, bp_rialto::MAX_SINGLE_MESSAGE_DELIVERY_CONFIRMATION_TX_WEIGHT, bp_rialto::PAY_INBOUND_DISPATCH_FEE_WEIGHT, DbWeight::get(), ); let max_incoming_message_proof_size = bp_millau::EXTRA_STORAGE_PROOF_SIZE.saturating_add( messages::target::maximal_incoming_message_size(bp_rialto::Rialto::max_extrinsic_size()), ); pallet_bridge_messages::ensure_able_to_receive_message::( bp_rialto::Rialto::max_extrinsic_size(), bp_rialto::Rialto::max_extrinsic_weight(), max_incoming_message_proof_size, messages::target::maximal_incoming_message_dispatch_weight( bp_rialto::Rialto::max_extrinsic_weight(), ), ); let max_incoming_inbound_lane_data_proof_size = bp_messages::InboundLaneData::<()>::encoded_size_hint( bp_rialto::MAXIMAL_ENCODED_ACCOUNT_ID_SIZE, bp_rialto::MAX_UNREWARDED_RELAYERS_IN_CONFIRMATION_TX as _, bp_rialto::MAX_UNCONFIRMED_MESSAGES_IN_CONFIRMATION_TX as _, ) .unwrap_or(u32::MAX); pallet_bridge_messages::ensure_able_to_receive_confirmation::( bp_rialto::Rialto::max_extrinsic_size(), bp_rialto::Rialto::max_extrinsic_weight(), max_incoming_inbound_lane_data_proof_size, bp_rialto::MAX_UNREWARDED_RELAYERS_IN_CONFIRMATION_TX, bp_rialto::MAX_UNCONFIRMED_MESSAGES_IN_CONFIRMATION_TX, DbWeight::get(), ); } #[test] fn ensure_bridge_integrity() { assert_complete_bridge_types!( runtime: Runtime, with_bridged_chain_grandpa_instance: MillauGrandpaInstance, with_bridged_chain_messages_instance: WithMillauMessagesInstance, bridge: WithMillauMessageBridge, this_chain: bp_rialto::Rialto, bridged_chain: bp_millau::Millau, this_chain_account_id_converter: bp_rialto::AccountIdConverter ); assert_complete_bridge_constants::< Runtime, MillauGrandpaInstance, WithMillauMessagesInstance, WithMillauMessageBridge, bp_rialto::Rialto, >(AssertCompleteBridgeConstants { this_chain_constants: AssertChainConstants { block_length: bp_rialto::BlockLength::get(), block_weights: bp_rialto::BlockWeights::get(), }, messages_pallet_constants: AssertBridgeMessagesPalletConstants { max_unrewarded_relayers_in_bridged_confirmation_tx: bp_millau::MAX_UNREWARDED_RELAYERS_IN_CONFIRMATION_TX, max_unconfirmed_messages_in_bridged_confirmation_tx: bp_millau::MAX_UNCONFIRMED_MESSAGES_IN_CONFIRMATION_TX, bridged_chain_id: bp_runtime::MILLAU_CHAIN_ID, }, pallet_names: AssertBridgePalletNames { with_this_chain_messages_pallet_name: bp_rialto::WITH_RIALTO_MESSAGES_PALLET_NAME, with_bridged_chain_grandpa_pallet_name: bp_millau::WITH_MILLAU_GRANDPA_PALLET_NAME, with_bridged_chain_messages_pallet_name: bp_millau::WITH_MILLAU_MESSAGES_PALLET_NAME, }, }); assert_eq!( MillauToRialtoConversionRate::key().to_vec(), bp_runtime::storage_parameter_key( bp_rialto::MILLAU_TO_RIALTO_CONVERSION_RATE_PARAMETER_NAME ) .0, ); } #[test] #[ignore] fn no_stack_overflow_when_decoding_nested_call_during_dispatch() { // this test is normally ignored, because it only makes sense to run it in release mode let mut ext: sp_io::TestExternalities = SystemConfig::default().build_storage::().unwrap().into(); ext.execute_with(|| { let bridge = MILLAU_CHAIN_ID; let mut call: Call = SystemCall::set_heap_pages { pages: 64 }.into(); for _i in 0..3000 { call = Call::Sudo(pallet_sudo::Call::sudo { call: Box::new(call) }); } let dispatch_weight = 500; let dispatch_fee = ::WeightToFee::calc( &dispatch_weight, ); assert!(dispatch_fee > 0); // create relayer account with minimal balance let relayer_account: AccountId = [1u8; 32].into(); let initial_amount = ExistentialDeposit::get(); let _ = as Currency>::deposit_creating( &relayer_account, initial_amount, ); // create dispatch account with minimal balance + dispatch fee let dispatch_account = derive_account_id::< ::SourceChainAccountId, >(bridge, SourceAccount::Root); let dispatch_account = ::AccountIdConverter::convert( dispatch_account, ); let _ = as Currency>::deposit_creating( &dispatch_account, initial_amount + dispatch_fee, ); // dispatch message with intention to pay dispatch fee at the target chain // // this is where the stack overflow has happened before the fix has been applied FromMillauMessageDispatch::dispatch( &relayer_account, DispatchMessage { key: MessageKey { lane_id: Default::default(), nonce: 0 }, data: DispatchMessageData { payload: Ok(FromBridgedChainMessagePayload:: { spec_version: VERSION.spec_version, weight: dispatch_weight, origin: CallOrigin::SourceRoot, dispatch_fee_payment: DispatchFeePayment::AtTargetChain, call: FromBridgedChainEncodedMessageCall::new(call.encode()), }), fee: 1, }, }, ); }); } }