// This file is part of Substrate. // Copyright (C) 2017-2021 Parity Technologies (UK) Ltd. // SPDX-License-Identifier: Apache-2.0 // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agreed to in writing, software // distributed under the License is distributed on an "AS IS" BASIS, // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. // See the License for the specific language governing permissions and // limitations under the License. //! # Tipping Module ( pallet-tips ) //! //! > NOTE: This pallet is tightly coupled with pallet-treasury. //! //! A subsystem to allow for an agile "tipping" process, whereby a reward may be given without first //! having a pre-determined stakeholder group come to consensus on how much should be paid. //! //! A group of `Tippers` is determined through the config `Config`. After half of these have declared //! some amount that they believe a particular reported reason deserves, then a countdown period is //! entered where any remaining members can declare their tip amounts also. After the close of the //! countdown period, the median of all declared tips is paid to the reported beneficiary, along //! with any finders fee, in case of a public (and bonded) original report. //! //! //! ### Terminology //! //! Tipping protocol: //! - **Tipping:** The process of gathering declarations of amounts to tip and taking the median //! amount to be transferred from the treasury to a beneficiary account. //! - **Tip Reason:** The reason for a tip; generally a URL which embodies or explains why a //! particular individual (identified by an account ID) is worthy of a recognition by the //! treasury. //! - **Finder:** The original public reporter of some reason for tipping. //! - **Finders Fee:** Some proportion of the tip amount that is paid to the reporter of the tip, //! rather than the main beneficiary. //! //! ## Interface //! //! ### Dispatchable Functions //! //! Tipping protocol: //! - `report_awesome` - Report something worthy of a tip and register for a finders fee. //! - `retract_tip` - Retract a previous (finders fee registered) report. //! - `tip_new` - Report an item worthy of a tip and declare a specific amount to tip. //! - `tip` - Declare or redeclare an amount to tip for a particular reason. //! - `close_tip` - Close and pay out a tip. #![cfg_attr(not(feature = "std"), no_std)] mod tests; mod benchmarking; pub mod weights; use sp_std::prelude::*; use frame_support::{decl_module, decl_storage, decl_event, ensure, decl_error, Parameter}; use frame_support::traits::{ Currency, Get, ExistenceRequirement::{KeepAlive}, ReservableCurrency }; use sp_runtime::{ Percent, RuntimeDebug, traits::{ Zero, AccountIdConversion, Hash, BadOrigin }}; use frame_support::traits::{Contains, ContainsLengthBound, OnUnbalanced, EnsureOrigin}; use codec::{Encode, Decode}; use frame_system::{self as system, ensure_signed}; pub use weights::WeightInfo; pub type BalanceOf = pallet_treasury::BalanceOf; pub type NegativeImbalanceOf = pallet_treasury::NegativeImbalanceOf; pub trait Config: frame_system::Config + pallet_treasury::Config { /// Maximum acceptable reason length. type MaximumReasonLength: Get; /// The amount held on deposit per byte within the tip report reason or bounty description. type DataDepositPerByte: Get>; /// Origin from which tippers must come. /// /// `ContainsLengthBound::max_len` must be cost free (i.e. no storage read or heavy operation). type Tippers: Contains + ContainsLengthBound; /// The period for which a tip remains open after is has achieved threshold tippers. type TipCountdown: Get; /// The percent of the final tip which goes to the original reporter of the tip. type TipFindersFee: Get; /// The amount held on deposit for placing a tip report. type TipReportDepositBase: Get>; /// The overarching event type. type Event: From> + Into<::Event>; /// Weight information for extrinsics in this pallet. type WeightInfo: WeightInfo; } /// An open tipping "motion". Retains all details of a tip including information on the finder /// and the members who have voted. #[derive(Clone, Eq, PartialEq, Encode, Decode, RuntimeDebug)] pub struct OpenTip< AccountId: Parameter, Balance: Parameter, BlockNumber: Parameter, Hash: Parameter, > { /// The hash of the reason for the tip. The reason should be a human-readable UTF-8 encoded string. A URL would be /// sensible. reason: Hash, /// The account to be tipped. who: AccountId, /// The account who began this tip. finder: AccountId, /// The amount held on deposit for this tip. deposit: Balance, /// The block number at which this tip will close if `Some`. If `None`, then no closing is /// scheduled. closes: Option, /// The members who have voted for this tip. Sorted by AccountId. tips: Vec<(AccountId, Balance)>, /// Whether this tip should result in the finder taking a fee. finders_fee: bool, } // Note :: For backward compatability reasons, // pallet-tips uses Treasury for storage. // This is temporary solution, soon will get replaced with // Own storage identifier. decl_storage! { trait Store for Module as Treasury { /// TipsMap that are not yet completed. Keyed by the hash of `(reason, who)` from the value. /// This has the insecure enumerable hash function since the key itself is already /// guaranteed to be a secure hash. pub Tips get(fn tips): map hasher(twox_64_concat) T::Hash => Option, T::BlockNumber, T::Hash>>; /// Simple preimage lookup from the reason's hash to the original data. Again, has an /// insecure enumerable hash since the key is guaranteed to be the result of a secure hash. pub Reasons get(fn reasons): map hasher(identity) T::Hash => Option>; } } decl_event!( pub enum Event where Balance = BalanceOf, ::AccountId, ::Hash, { /// A new tip suggestion has been opened. \[tip_hash\] NewTip(Hash), /// A tip suggestion has reached threshold and is closing. \[tip_hash\] TipClosing(Hash), /// A tip suggestion has been closed. \[tip_hash, who, payout\] TipClosed(Hash, AccountId, Balance), /// A tip suggestion has been retracted. \[tip_hash\] TipRetracted(Hash), /// A tip suggestion has been slashed. \[tip_hash, finder, deposit\] TipSlashed(Hash, AccountId, Balance), } ); decl_error! { /// Error for the tips module. pub enum Error for Module { /// The reason given is just too big. ReasonTooBig, /// The tip was already found/started. AlreadyKnown, /// The tip hash is unknown. UnknownTip, /// The account attempting to retract the tip is not the finder of the tip. NotFinder, /// The tip cannot be claimed/closed because there are not enough tippers yet. StillOpen, /// The tip cannot be claimed/closed because it's still in the countdown period. Premature, } } decl_module! { pub struct Module for enum Call where origin: T::Origin { /// The period for which a tip remains open after is has achieved threshold tippers. const TipCountdown: T::BlockNumber = T::TipCountdown::get(); /// The amount of the final tip which goes to the original reporter of the tip. const TipFindersFee: Percent = T::TipFindersFee::get(); /// The amount held on deposit for placing a tip report. const TipReportDepositBase: BalanceOf = T::TipReportDepositBase::get(); /// The amount held on deposit per byte within the tip report reason. const DataDepositPerByte: BalanceOf = T::DataDepositPerByte::get(); /// Maximum acceptable reason length. const MaximumReasonLength: u32 = T::MaximumReasonLength::get(); type Error = Error; fn deposit_event() = default; /// Report something `reason` that deserves a tip and claim any eventual the finder's fee. /// /// The dispatch origin for this call must be _Signed_. /// /// Payment: `TipReportDepositBase` will be reserved from the origin account, as well as /// `DataDepositPerByte` for each byte in `reason`. /// /// - `reason`: The reason for, or the thing that deserves, the tip; generally this will be /// a UTF-8-encoded URL. /// - `who`: The account which should be credited for the tip. /// /// Emits `NewTip` if successful. /// /// # /// - Complexity: `O(R)` where `R` length of `reason`. /// - encoding and hashing of 'reason' /// - DbReads: `Reasons`, `Tips` /// - DbWrites: `Reasons`, `Tips` /// # #[weight = ::WeightInfo::report_awesome(reason.len() as u32)] fn report_awesome(origin, reason: Vec, who: T::AccountId) { let finder = ensure_signed(origin)?; ensure!(reason.len() <= T::MaximumReasonLength::get() as usize, Error::::ReasonTooBig); let reason_hash = T::Hashing::hash(&reason[..]); ensure!(!Reasons::::contains_key(&reason_hash), Error::::AlreadyKnown); let hash = T::Hashing::hash_of(&(&reason_hash, &who)); ensure!(!Tips::::contains_key(&hash), Error::::AlreadyKnown); let deposit = T::TipReportDepositBase::get() + T::DataDepositPerByte::get() * (reason.len() as u32).into(); T::Currency::reserve(&finder, deposit)?; Reasons::::insert(&reason_hash, &reason); let tip = OpenTip { reason: reason_hash, who, finder, deposit, closes: None, tips: vec![], finders_fee: true }; Tips::::insert(&hash, tip); Self::deposit_event(RawEvent::NewTip(hash)); } /// Retract a prior tip-report from `report_awesome`, and cancel the process of tipping. /// /// If successful, the original deposit will be unreserved. /// /// The dispatch origin for this call must be _Signed_ and the tip identified by `hash` /// must have been reported by the signing account through `report_awesome` (and not /// through `tip_new`). /// /// - `hash`: The identity of the open tip for which a tip value is declared. This is formed /// as the hash of the tuple of the original tip `reason` and the beneficiary account ID. /// /// Emits `TipRetracted` if successful. /// /// # /// - Complexity: `O(1)` /// - Depends on the length of `T::Hash` which is fixed. /// - DbReads: `Tips`, `origin account` /// - DbWrites: `Reasons`, `Tips`, `origin account` /// # #[weight = ::WeightInfo::retract_tip()] fn retract_tip(origin, hash: T::Hash) { let who = ensure_signed(origin)?; let tip = Tips::::get(&hash).ok_or(Error::::UnknownTip)?; ensure!(tip.finder == who, Error::::NotFinder); Reasons::::remove(&tip.reason); Tips::::remove(&hash); if !tip.deposit.is_zero() { let _ = T::Currency::unreserve(&who, tip.deposit); } Self::deposit_event(RawEvent::TipRetracted(hash)); } /// Give a tip for something new; no finder's fee will be taken. /// /// The dispatch origin for this call must be _Signed_ and the signing account must be a /// member of the `Tippers` set. /// /// - `reason`: The reason for, or the thing that deserves, the tip; generally this will be /// a UTF-8-encoded URL. /// - `who`: The account which should be credited for the tip. /// - `tip_value`: The amount of tip that the sender would like to give. The median tip /// value of active tippers will be given to the `who`. /// /// Emits `NewTip` if successful. /// /// # /// - Complexity: `O(R + T)` where `R` length of `reason`, `T` is the number of tippers. /// - `O(T)`: decoding `Tipper` vec of length `T` /// `T` is charged as upper bound given by `ContainsLengthBound`. /// The actual cost depends on the implementation of `T::Tippers`. /// - `O(R)`: hashing and encoding of reason of length `R` /// - DbReads: `Tippers`, `Reasons` /// - DbWrites: `Reasons`, `Tips` /// # #[weight = ::WeightInfo::tip_new(reason.len() as u32, T::Tippers::max_len() as u32)] fn tip_new(origin, reason: Vec, who: T::AccountId, #[compact] tip_value: BalanceOf) { let tipper = ensure_signed(origin)?; ensure!(T::Tippers::contains(&tipper), BadOrigin); let reason_hash = T::Hashing::hash(&reason[..]); ensure!(!Reasons::::contains_key(&reason_hash), Error::::AlreadyKnown); let hash = T::Hashing::hash_of(&(&reason_hash, &who)); Reasons::::insert(&reason_hash, &reason); Self::deposit_event(RawEvent::NewTip(hash.clone())); let tips = vec![(tipper.clone(), tip_value)]; let tip = OpenTip { reason: reason_hash, who, finder: tipper, deposit: Zero::zero(), closes: None, tips, finders_fee: false, }; Tips::::insert(&hash, tip); } /// Declare a tip value for an already-open tip. /// /// The dispatch origin for this call must be _Signed_ and the signing account must be a /// member of the `Tippers` set. /// /// - `hash`: The identity of the open tip for which a tip value is declared. This is formed /// as the hash of the tuple of the hash of the original tip `reason` and the beneficiary /// account ID. /// - `tip_value`: The amount of tip that the sender would like to give. The median tip /// value of active tippers will be given to the `who`. /// /// Emits `TipClosing` if the threshold of tippers has been reached and the countdown period /// has started. /// /// # /// - Complexity: `O(T)` where `T` is the number of tippers. /// decoding `Tipper` vec of length `T`, insert tip and check closing, /// `T` is charged as upper bound given by `ContainsLengthBound`. /// The actual cost depends on the implementation of `T::Tippers`. /// /// Actually weight could be lower as it depends on how many tips are in `OpenTip` but it /// is weighted as if almost full i.e of length `T-1`. /// - DbReads: `Tippers`, `Tips` /// - DbWrites: `Tips` /// # #[weight = ::WeightInfo::tip(T::Tippers::max_len() as u32)] fn tip(origin, hash: T::Hash, #[compact] tip_value: BalanceOf) { let tipper = ensure_signed(origin)?; ensure!(T::Tippers::contains(&tipper), BadOrigin); let mut tip = Tips::::get(hash).ok_or(Error::::UnknownTip)?; if Self::insert_tip_and_check_closing(&mut tip, tipper, tip_value) { Self::deposit_event(RawEvent::TipClosing(hash.clone())); } Tips::::insert(&hash, tip); } /// Close and payout a tip. /// /// The dispatch origin for this call must be _Signed_. /// /// The tip identified by `hash` must have finished its countdown period. /// /// - `hash`: The identity of the open tip for which a tip value is declared. This is formed /// as the hash of the tuple of the original tip `reason` and the beneficiary account ID. /// /// # /// - Complexity: `O(T)` where `T` is the number of tippers. /// decoding `Tipper` vec of length `T`. /// `T` is charged as upper bound given by `ContainsLengthBound`. /// The actual cost depends on the implementation of `T::Tippers`. /// - DbReads: `Tips`, `Tippers`, `tip finder` /// - DbWrites: `Reasons`, `Tips`, `Tippers`, `tip finder` /// # #[weight = ::WeightInfo::close_tip(T::Tippers::max_len() as u32)] fn close_tip(origin, hash: T::Hash) { ensure_signed(origin)?; let tip = Tips::::get(hash).ok_or(Error::::UnknownTip)?; let n = tip.closes.as_ref().ok_or(Error::::StillOpen)?; ensure!(system::Module::::block_number() >= *n, Error::::Premature); // closed. Reasons::::remove(&tip.reason); Tips::::remove(hash); Self::payout_tip(hash, tip); } /// Remove and slash an already-open tip. /// /// May only be called from `T::RejectOrigin`. /// /// As a result, the finder is slashed and the deposits are lost. /// /// Emits `TipSlashed` if successful. /// /// # /// `T` is charged as upper bound given by `ContainsLengthBound`. /// The actual cost depends on the implementation of `T::Tippers`. /// # #[weight = ::WeightInfo::slash_tip(T::Tippers::max_len() as u32)] fn slash_tip(origin, hash: T::Hash) { T::RejectOrigin::ensure_origin(origin)?; let tip = Tips::::take(hash).ok_or(Error::::UnknownTip)?; if !tip.deposit.is_zero() { let imbalance = T::Currency::slash_reserved(&tip.finder, tip.deposit).0; T::OnSlash::on_unbalanced(imbalance); } Reasons::::remove(&tip.reason); Self::deposit_event(RawEvent::TipSlashed(hash, tip.finder, tip.deposit)); } } } impl Module { // Add public immutables and private mutables. /// The account ID of the treasury pot. /// /// This actually does computation. If you need to keep using it, then make sure you cache the /// value and only call this once. pub fn account_id() -> T::AccountId { T::ModuleId::get().into_account() } /// Given a mutable reference to an `OpenTip`, insert the tip into it and check whether it /// closes, if so, then deposit the relevant event and set closing accordingly. /// /// `O(T)` and one storage access. fn insert_tip_and_check_closing( tip: &mut OpenTip, T::BlockNumber, T::Hash>, tipper: T::AccountId, tip_value: BalanceOf, ) -> bool { match tip.tips.binary_search_by_key(&&tipper, |x| &x.0) { Ok(pos) => tip.tips[pos] = (tipper, tip_value), Err(pos) => tip.tips.insert(pos, (tipper, tip_value)), } Self::retain_active_tips(&mut tip.tips); let threshold = (T::Tippers::count() + 1) / 2; if tip.tips.len() >= threshold && tip.closes.is_none() { tip.closes = Some(system::Module::::block_number() + T::TipCountdown::get()); true } else { false } } /// Remove any non-members of `Tippers` from a `tips` vector. `O(T)`. fn retain_active_tips(tips: &mut Vec<(T::AccountId, BalanceOf)>) { let members = T::Tippers::sorted_members(); let mut members_iter = members.iter(); let mut member = members_iter.next(); tips.retain(|(ref a, _)| loop { match member { None => break false, Some(m) if m > a => break false, Some(m) => { member = members_iter.next(); if m < a { continue } else { break true; } } } }); } /// Execute the payout of a tip. /// /// Up to three balance operations. /// Plus `O(T)` (`T` is Tippers length). fn payout_tip(hash: T::Hash, tip: OpenTip, T::BlockNumber, T::Hash>) { let mut tips = tip.tips; Self::retain_active_tips(&mut tips); tips.sort_by_key(|i| i.1); let treasury = Self::account_id(); let max_payout = pallet_treasury::Module::::pot(); let mut payout = tips[tips.len() / 2].1.min(max_payout); if !tip.deposit.is_zero() { let _ = T::Currency::unreserve(&tip.finder, tip.deposit); } if tip.finders_fee && tip.finder != tip.who { // pay out the finder's fee. let finders_fee = T::TipFindersFee::get() * payout; payout -= finders_fee; // this should go through given we checked it's at most the free balance, but still // we only make a best-effort. let _ = T::Currency::transfer(&treasury, &tip.finder, finders_fee, KeepAlive); } // same as above: best-effort only. let _ = T::Currency::transfer(&treasury, &tip.who, payout, KeepAlive); Self::deposit_event(RawEvent::TipClosed(hash, tip.who, payout)); } pub fn migrate_retract_tip_for_tip_new() { /// An open tipping "motion". Retains all details of a tip including information on the finder /// and the members who have voted. #[derive(Clone, Eq, PartialEq, Encode, Decode, RuntimeDebug)] pub struct OldOpenTip< AccountId: Parameter, Balance: Parameter, BlockNumber: Parameter, Hash: Parameter, > { /// The hash of the reason for the tip. The reason should be a human-readable UTF-8 encoded string. A URL would be /// sensible. reason: Hash, /// The account to be tipped. who: AccountId, /// The account who began this tip and the amount held on deposit. finder: Option<(AccountId, Balance)>, /// The block number at which this tip will close if `Some`. If `None`, then no closing is /// scheduled. closes: Option, /// The members who have voted for this tip. Sorted by AccountId. tips: Vec<(AccountId, Balance)>, } use frame_support::{Twox64Concat, migration::StorageKeyIterator}; for (hash, old_tip) in StorageKeyIterator::< T::Hash, OldOpenTip, T::BlockNumber, T::Hash>, Twox64Concat, >::new(b"Treasury", b"Tips").drain() { let (finder, deposit, finders_fee) = match old_tip.finder { Some((finder, deposit)) => { (finder, deposit, true) }, None => { (T::AccountId::default(), Zero::zero(), false) }, }; let new_tip = OpenTip { reason: old_tip.reason, who: old_tip.who, finder, deposit, closes: old_tip.closes, tips: old_tip.tips, finders_fee }; Tips::::insert(hash, new_tip) } } }