// This file is part of Substrate. // Copyright (C) 2020-2021 Parity Technologies (UK) Ltd. // SPDX-License-Identifier: Apache-2.0 // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agreed to in writing, software // distributed under the License is distributed on an "AS IS" BASIS, // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. // See the License for the specific language governing permissions and // limitations under the License. //! Staking pallet benchmarking. use super::*; use frame_benchmarking::{ account, benchmarks_instance, impl_benchmark_test_suite, whitelisted_caller, }; use frame_system::RawOrigin as SystemOrigin; use sp_runtime::traits::Bounded; use sp_std::mem::size_of; use crate::Module as Collective; use frame_system::{Call as SystemCall, Pallet as System}; const SEED: u32 = 0; const MAX_BYTES: u32 = 1_024; fn assert_last_event, I: Instance>(generic_event: >::Event) { frame_system::Pallet::::assert_last_event(generic_event.into()); } benchmarks_instance! { set_members { let m in 1 .. T::MaxMembers::get(); let n in 1 .. T::MaxMembers::get(); let p in 1 .. T::MaxProposals::get(); // Set old members. // We compute the difference of old and new members, so it should influence timing. let mut old_members = vec![]; let mut last_old_member = T::AccountId::default(); for i in 0 .. m { last_old_member = account("old member", i, SEED); old_members.push(last_old_member.clone()); } let old_members_count = old_members.len() as u32; Collective::::set_members( SystemOrigin::Root.into(), old_members.clone(), Some(last_old_member.clone()), T::MaxMembers::get(), )?; // Set a high threshold for proposals passing so that they stay around. let threshold = m.max(2); // Length of the proposals should be irrelevant to `set_members`. let length = 100; for i in 0 .. p { // Proposals should be different so that different proposal hashes are generated let proposal: T::Proposal = SystemCall::::remark(vec![i as u8; length]).into(); Collective::::propose( SystemOrigin::Signed(last_old_member.clone()).into(), threshold, Box::new(proposal.clone()), MAX_BYTES, )?; let hash = T::Hashing::hash_of(&proposal); // Vote on the proposal to increase state relevant for `set_members`. // Not voting for `last_old_member` because they proposed and not voting for the first member // to keep the proposal from passing. for j in 2 .. m - 1 { let voter = &old_members[j as usize]; let approve = true; Collective::::vote( SystemOrigin::Signed(voter.clone()).into(), hash, i, approve, )?; } } // Construct `new_members`. // It should influence timing since it will sort this vector. let mut new_members = vec![]; let mut last_member = T::AccountId::default(); for i in 0 .. n { last_member = account("member", i, SEED); new_members.push(last_member.clone()); } }: _(SystemOrigin::Root, new_members.clone(), Some(last_member), T::MaxMembers::get()) verify { new_members.sort(); assert_eq!(Collective::::members(), new_members); } execute { let b in 1 .. MAX_BYTES; let m in 1 .. T::MaxMembers::get(); let bytes_in_storage = b + size_of::() as u32; // Construct `members`. let mut members = vec![]; for i in 0 .. m - 1 { let member = account("member", i, SEED); members.push(member); } let caller: T::AccountId = whitelisted_caller(); members.push(caller.clone()); Collective::::set_members(SystemOrigin::Root.into(), members, None, T::MaxMembers::get())?; let proposal: T::Proposal = SystemCall::::remark(vec![1; b as usize]).into(); }: _(SystemOrigin::Signed(caller), Box::new(proposal.clone()), bytes_in_storage) verify { let proposal_hash = T::Hashing::hash_of(&proposal); // Note that execution fails due to mis-matched origin assert_last_event::( RawEvent::MemberExecuted(proposal_hash, Err(DispatchError::BadOrigin)).into() ); } // This tests when execution would happen immediately after proposal propose_execute { let b in 1 .. MAX_BYTES; let m in 1 .. T::MaxMembers::get(); let bytes_in_storage = b + size_of::() as u32; // Construct `members`. let mut members = vec![]; for i in 0 .. m - 1 { let member = account("member", i, SEED); members.push(member); } let caller: T::AccountId = whitelisted_caller(); members.push(caller.clone()); Collective::::set_members(SystemOrigin::Root.into(), members, None, T::MaxMembers::get())?; let proposal: T::Proposal = SystemCall::::remark(vec![1; b as usize]).into(); let threshold = 1; }: propose(SystemOrigin::Signed(caller), threshold, Box::new(proposal.clone()), bytes_in_storage) verify { let proposal_hash = T::Hashing::hash_of(&proposal); // Note that execution fails due to mis-matched origin assert_last_event::( RawEvent::Executed(proposal_hash, Err(DispatchError::BadOrigin)).into() ); } // This tests when proposal is created and queued as "proposed" propose_proposed { let b in 1 .. MAX_BYTES; let m in 2 .. T::MaxMembers::get(); let p in 1 .. T::MaxProposals::get(); let bytes_in_storage = b + size_of::() as u32; // Construct `members`. let mut members = vec![]; for i in 0 .. m - 1 { let member = account("member", i, SEED); members.push(member); } let caller: T::AccountId = whitelisted_caller(); members.push(caller.clone()); Collective::::set_members(SystemOrigin::Root.into(), members, None, T::MaxMembers::get())?; let threshold = m; // Add previous proposals. for i in 0 .. p - 1 { // Proposals should be different so that different proposal hashes are generated let proposal: T::Proposal = SystemCall::::remark(vec![i as u8; b as usize]).into(); Collective::::propose( SystemOrigin::Signed(caller.clone()).into(), threshold, Box::new(proposal), bytes_in_storage, )?; } assert_eq!(Collective::::proposals().len(), (p - 1) as usize); let proposal: T::Proposal = SystemCall::::remark(vec![p as u8; b as usize]).into(); }: propose(SystemOrigin::Signed(caller.clone()), threshold, Box::new(proposal.clone()), bytes_in_storage) verify { // New proposal is recorded assert_eq!(Collective::::proposals().len(), p as usize); let proposal_hash = T::Hashing::hash_of(&proposal); assert_last_event::(RawEvent::Proposed(caller, p - 1, proposal_hash, threshold).into()); } vote { // We choose 5 as a minimum so we always trigger a vote in the voting loop (`for j in ...`) let m in 5 .. T::MaxMembers::get(); let p = T::MaxProposals::get(); let b = MAX_BYTES; let bytes_in_storage = b + size_of::() as u32; // Construct `members`. let mut members = vec![]; let proposer: T::AccountId = account("proposer", 0, SEED); members.push(proposer.clone()); for i in 1 .. m - 1 { let member = account("member", i, SEED); members.push(member); } let voter: T::AccountId = account("voter", 0, SEED); members.push(voter.clone()); Collective::::set_members(SystemOrigin::Root.into(), members.clone(), None, T::MaxMembers::get())?; // Threshold is 1 less than the number of members so that one person can vote nay let threshold = m - 1; // Add previous proposals let mut last_hash = T::Hash::default(); for i in 0 .. p { // Proposals should be different so that different proposal hashes are generated let proposal: T::Proposal = SystemCall::::remark(vec![i as u8; b as usize]).into(); Collective::::propose( SystemOrigin::Signed(proposer.clone()).into(), threshold, Box::new(proposal.clone()), bytes_in_storage, )?; last_hash = T::Hashing::hash_of(&proposal); } let index = p - 1; // Have almost everyone vote aye on last proposal, while keeping it from passing. for j in 0 .. m - 3 { let voter = &members[j as usize]; let approve = true; Collective::::vote( SystemOrigin::Signed(voter.clone()).into(), last_hash.clone(), index, approve, )?; } // Voter votes aye without resolving the vote. let approve = true; Collective::::vote( SystemOrigin::Signed(voter.clone()).into(), last_hash.clone(), index, approve, )?; assert_eq!(Collective::::proposals().len(), p as usize); // Voter switches vote to nay, but does not kill the vote, just updates + inserts let approve = false; // Whitelist voter account from further DB operations. let voter_key = frame_system::Account::::hashed_key_for(&voter); frame_benchmarking::benchmarking::add_to_whitelist(voter_key.into()); }: _(SystemOrigin::Signed(voter), last_hash.clone(), index, approve) verify { // All proposals exist and the last proposal has just been updated. assert_eq!(Collective::::proposals().len(), p as usize); let voting = Collective::::voting(&last_hash).ok_or(Error::::ProposalMissing)?; assert_eq!(voting.ayes.len(), (m - 3) as usize); assert_eq!(voting.nays.len(), 1); } close_early_disapproved { // We choose 4 as a minimum so we always trigger a vote in the voting loop (`for j in ...`) let m in 4 .. T::MaxMembers::get(); let p in 1 .. T::MaxProposals::get(); let bytes = 100; let bytes_in_storage = bytes + size_of::() as u32; // Construct `members`. let mut members = vec![]; let proposer: T::AccountId = account("proposer", 0, SEED); members.push(proposer.clone()); for i in 1 .. m - 1 { let member = account("member", i, SEED); members.push(member); } let voter: T::AccountId = account("voter", 0, SEED); members.push(voter.clone()); Collective::::set_members(SystemOrigin::Root.into(), members.clone(), None, T::MaxMembers::get())?; // Threshold is total members so that one nay will disapprove the vote let threshold = m; // Add previous proposals let mut last_hash = T::Hash::default(); for i in 0 .. p { // Proposals should be different so that different proposal hashes are generated let proposal: T::Proposal = SystemCall::::remark(vec![i as u8; bytes as usize]).into(); Collective::::propose( SystemOrigin::Signed(proposer.clone()).into(), threshold, Box::new(proposal.clone()), bytes_in_storage, )?; last_hash = T::Hashing::hash_of(&proposal); } let index = p - 1; // Have most everyone vote aye on last proposal, while keeping it from passing. for j in 0 .. m - 2 { let voter = &members[j as usize]; let approve = true; Collective::::vote( SystemOrigin::Signed(voter.clone()).into(), last_hash.clone(), index, approve, )?; } // Voter votes aye without resolving the vote. let approve = true; Collective::::vote( SystemOrigin::Signed(voter.clone()).into(), last_hash.clone(), index, approve, )?; assert_eq!(Collective::::proposals().len(), p as usize); // Voter switches vote to nay, which kills the vote let approve = false; Collective::::vote( SystemOrigin::Signed(voter.clone()).into(), last_hash.clone(), index, approve, )?; // Whitelist voter account from further DB operations. let voter_key = frame_system::Account::::hashed_key_for(&voter); frame_benchmarking::benchmarking::add_to_whitelist(voter_key.into()); }: close(SystemOrigin::Signed(voter), last_hash.clone(), index, Weight::max_value(), bytes_in_storage) verify { // The last proposal is removed. assert_eq!(Collective::::proposals().len(), (p - 1) as usize); assert_last_event::(RawEvent::Disapproved(last_hash).into()); } close_early_approved { let b in 1 .. MAX_BYTES; // We choose 4 as a minimum so we always trigger a vote in the voting loop (`for j in ...`) let m in 4 .. T::MaxMembers::get(); let p in 1 .. T::MaxProposals::get(); let bytes_in_storage = b + size_of::() as u32; // Construct `members`. let mut members = vec![]; for i in 0 .. m - 1 { let member = account("member", i, SEED); members.push(member); } let caller: T::AccountId = whitelisted_caller(); members.push(caller.clone()); Collective::::set_members(SystemOrigin::Root.into(), members.clone(), None, T::MaxMembers::get())?; // Threshold is 2 so any two ayes will approve the vote let threshold = 2; // Add previous proposals let mut last_hash = T::Hash::default(); for i in 0 .. p { // Proposals should be different so that different proposal hashes are generated let proposal: T::Proposal = SystemCall::::remark(vec![i as u8; b as usize]).into(); Collective::::propose( SystemOrigin::Signed(caller.clone()).into(), threshold, Box::new(proposal.clone()), bytes_in_storage, )?; last_hash = T::Hashing::hash_of(&proposal); } // Caller switches vote to nay on their own proposal, allowing them to be the deciding approval vote Collective::::vote( SystemOrigin::Signed(caller.clone()).into(), last_hash.clone(), p - 1, false, )?; // Have almost everyone vote nay on last proposal, while keeping it from failing. for j in 2 .. m - 1 { let voter = &members[j as usize]; let approve = false; Collective::::vote( SystemOrigin::Signed(voter.clone()).into(), last_hash.clone(), p - 1, approve, )?; } // Member zero is the first aye Collective::::vote( SystemOrigin::Signed(members[0].clone()).into(), last_hash.clone(), p - 1, true, )?; assert_eq!(Collective::::proposals().len(), p as usize); // Caller switches vote to aye, which passes the vote let index = p - 1; let approve = true; Collective::::vote( SystemOrigin::Signed(caller.clone()).into(), last_hash.clone(), index, approve, )?; }: close(SystemOrigin::Signed(caller), last_hash.clone(), index, Weight::max_value(), bytes_in_storage) verify { // The last proposal is removed. assert_eq!(Collective::::proposals().len(), (p - 1) as usize); assert_last_event::(RawEvent::Executed(last_hash, Err(DispatchError::BadOrigin)).into()); } close_disapproved { // We choose 4 as a minimum so we always trigger a vote in the voting loop (`for j in ...`) let m in 4 .. T::MaxMembers::get(); let p in 1 .. T::MaxProposals::get(); let bytes = 100; let bytes_in_storage = bytes + size_of::() as u32; // Construct `members`. let mut members = vec![]; for i in 0 .. m - 1 { let member = account("member", i, SEED); members.push(member); } let caller: T::AccountId = whitelisted_caller(); members.push(caller.clone()); Collective::::set_members( SystemOrigin::Root.into(), members.clone(), Some(caller.clone()), T::MaxMembers::get(), )?; // Threshold is one less than total members so that two nays will disapprove the vote let threshold = m - 1; // Add proposals let mut last_hash = T::Hash::default(); for i in 0 .. p { // Proposals should be different so that different proposal hashes are generated let proposal: T::Proposal = SystemCall::::remark(vec![i as u8; bytes as usize]).into(); Collective::::propose( SystemOrigin::Signed(caller.clone()).into(), threshold, Box::new(proposal.clone()), bytes_in_storage, )?; last_hash = T::Hashing::hash_of(&proposal); } let index = p - 1; // Have almost everyone vote aye on last proposal, while keeping it from passing. // A few abstainers will be the nay votes needed to fail the vote. for j in 2 .. m - 1 { let voter = &members[j as usize]; let approve = true; Collective::::vote( SystemOrigin::Signed(voter.clone()).into(), last_hash.clone(), index, approve, )?; } // caller is prime, prime votes nay Collective::::vote( SystemOrigin::Signed(caller.clone()).into(), last_hash.clone(), index, false, )?; System::::set_block_number(T::BlockNumber::max_value()); assert_eq!(Collective::::proposals().len(), p as usize); // Prime nay will close it as disapproved }: close(SystemOrigin::Signed(caller), last_hash, index, Weight::max_value(), bytes_in_storage) verify { assert_eq!(Collective::::proposals().len(), (p - 1) as usize); assert_last_event::(RawEvent::Disapproved(last_hash).into()); } close_approved { let b in 1 .. MAX_BYTES; // We choose 4 as a minimum so we always trigger a vote in the voting loop (`for j in ...`) let m in 4 .. T::MaxMembers::get(); let p in 1 .. T::MaxProposals::get(); let bytes_in_storage = b + size_of::() as u32; // Construct `members`. let mut members = vec![]; for i in 0 .. m - 1 { let member = account("member", i, SEED); members.push(member); } let caller: T::AccountId = whitelisted_caller(); members.push(caller.clone()); Collective::::set_members( SystemOrigin::Root.into(), members.clone(), Some(caller.clone()), T::MaxMembers::get(), )?; // Threshold is two, so any two ayes will pass the vote let threshold = 2; // Add proposals let mut last_hash = T::Hash::default(); for i in 0 .. p { // Proposals should be different so that different proposal hashes are generated let proposal: T::Proposal = SystemCall::::remark(vec![i as u8; b as usize]).into(); Collective::::propose( SystemOrigin::Signed(caller.clone()).into(), threshold, Box::new(proposal.clone()), bytes_in_storage, )?; last_hash = T::Hashing::hash_of(&proposal); } // The prime member votes aye, so abstentions default to aye. Collective::::vote( SystemOrigin::Signed(caller.clone()).into(), last_hash.clone(), p - 1, true // Vote aye. )?; // Have almost everyone vote nay on last proposal, while keeping it from failing. // A few abstainers will be the aye votes needed to pass the vote. for j in 2 .. m - 1 { let voter = &members[j as usize]; let approve = false; Collective::::vote( SystemOrigin::Signed(voter.clone()).into(), last_hash.clone(), p - 1, approve )?; } // caller is prime, prime already votes aye by creating the proposal System::::set_block_number(T::BlockNumber::max_value()); assert_eq!(Collective::::proposals().len(), p as usize); // Prime aye will close it as approved }: close(SystemOrigin::Signed(caller), last_hash, p - 1, Weight::max_value(), bytes_in_storage) verify { assert_eq!(Collective::::proposals().len(), (p - 1) as usize); assert_last_event::(RawEvent::Executed(last_hash, Err(DispatchError::BadOrigin)).into()); } disapprove_proposal { let p in 1 .. T::MaxProposals::get(); let m = 3; let b = MAX_BYTES; let bytes_in_storage = b + size_of::() as u32; // Construct `members`. let mut members = vec![]; for i in 0 .. m - 1 { let member = account("member", i, SEED); members.push(member); } let caller: T::AccountId = account("caller", 0, SEED); members.push(caller.clone()); Collective::::set_members( SystemOrigin::Root.into(), members.clone(), Some(caller.clone()), T::MaxMembers::get(), )?; // Threshold is one less than total members so that two nays will disapprove the vote let threshold = m - 1; // Add proposals let mut last_hash = T::Hash::default(); for i in 0 .. p { // Proposals should be different so that different proposal hashes are generated let proposal: T::Proposal = SystemCall::::remark(vec![i as u8; b as usize]).into(); Collective::::propose( SystemOrigin::Signed(caller.clone()).into(), threshold, Box::new(proposal.clone()), bytes_in_storage, )?; last_hash = T::Hashing::hash_of(&proposal); } System::::set_block_number(T::BlockNumber::max_value()); assert_eq!(Collective::::proposals().len(), p as usize); }: _(SystemOrigin::Root, last_hash) verify { assert_eq!(Collective::::proposals().len(), (p - 1) as usize); assert_last_event::(RawEvent::Disapproved(last_hash).into()); } } impl_benchmark_test_suite!(Collective, crate::tests::new_test_ext(), crate::tests::Test,);