// Copyright 2017-2019 Parity Technologies (UK) Ltd. // This file is part of Substrate. // Substrate is free software: you can redistribute it and/or modify // it under the terms of the GNU General Public License as published by // the Free Software Foundation, either version 3 of the License, or // (at your option) any later version. // Substrate is distributed in the hope that it will be useful, // but WITHOUT ANY WARRANTY; without even the implied warranty of // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the // GNU General Public License for more details. // You should have received a copy of the GNU General Public License // along with Substrate. If not, see . //! # Treasury Module //! //! The `treasury` module keeps account of currency in a `pot` and manages the subsequent //! deployment of these funds. //! //! ## Overview //! //! Funds for treasury are raised in two ways: //! 1. By minting new tokens, leading to inflation, and //! 2. By channeling tokens from transaction fees and slashing. //! //! Treasury funds can be used to pay for developers who provide software updates, //! any changes decided by referenda, and to generally keep the system running smoothly. //! //! Treasury can be used with other modules, such as to tax validator rewards in the `staking` module. //! //! ### Implementations //! //! The treasury module provides an implementation for the following trait: //! - `OnDilution` - Mint extra funds upon dilution; maintain the ratio of `portion` diluted to `total_issuance`. //! //! ## Interface //! //! ### Dispatchable Functions //! //! - `propose_spend` - Propose a spending proposal and stake a proposal deposit. //! - `set_pot` - Set the spendable balance of funds. //! - `configure` - Configure the module's proposal requirements. //! - `reject_proposal` - Reject a proposal and slash the deposit. //! - `approve_proposal` - Accept the proposal and return the deposit. //! //! Please refer to the [`Call`](./enum.Call.html) enum and its associated variants for documentation on each function. //! //! ### Public Functions //! //! See the [module](./struct.Module.html) for details on publicly available functions. //! //! ## Related Modules //! //! The treasury module depends on the `system` and `srml_support` modules as well as //! Substrate Core libraries and the Rust standard library. //! #![cfg_attr(not(feature = "std"), no_std)] #[cfg(feature = "std")] use serde::{Serialize, Deserialize}; use rstd::prelude::*; use srml_support::{StorageValue, StorageMap, decl_module, decl_storage, decl_event, ensure}; use srml_support::traits::{Currency, ReservableCurrency, OnDilution, OnUnbalanced, Imbalance}; use runtime_primitives::{Permill, traits::{Zero, EnsureOrigin, StaticLookup}}; use parity_codec::{Encode, Decode}; use system::ensure_signed; type BalanceOf = <::Currency as Currency<::AccountId>>::Balance; type PositiveImbalanceOf = <::Currency as Currency<::AccountId>>::PositiveImbalance; type NegativeImbalanceOf = <::Currency as Currency<::AccountId>>::NegativeImbalance; pub trait Trait: system::Trait { /// The staking balance. type Currency: Currency + ReservableCurrency; /// Origin from which approvals must come. type ApproveOrigin: EnsureOrigin; /// Origin from which rejections must come. type RejectOrigin: EnsureOrigin; /// The overarching event type. type Event: From> + Into<::Event>; /// Handler for the unbalanced increase when minting cash from the "Pot". type MintedForSpending: OnUnbalanced>; /// Handler for the unbalanced decrease when slashing for a rejected proposal. type ProposalRejection: OnUnbalanced>; } type ProposalIndex = u32; decl_module! { pub struct Module for enum Call where origin: T::Origin { fn deposit_event() = default; /// Put forward a suggestion for spending. A deposit proportional to the value /// is reserved and slashed if the proposal is rejected. It is returned once the /// proposal is awarded. fn propose_spend( origin, #[compact] value: BalanceOf, beneficiary: ::Source ) { let proposer = ensure_signed(origin)?; let beneficiary = T::Lookup::lookup(beneficiary)?; let bond = Self::calculate_bond(value); T::Currency::reserve(&proposer, bond) .map_err(|_| "Proposer's balance too low")?; let c = Self::proposal_count(); >::put(c + 1); >::insert(c, Proposal { proposer, value, beneficiary, bond }); Self::deposit_event(RawEvent::Proposed(c)); } /// Set the balance of funds available to spend. fn set_pot(#[compact] new_pot: BalanceOf) { // Put the new value into storage. >::put(new_pot); } /// (Re-)configure this module. fn configure( #[compact] proposal_bond: Permill, #[compact] proposal_bond_minimum: BalanceOf, #[compact] spend_period: T::BlockNumber, #[compact] burn: Permill ) { >::put(proposal_bond); >::put(proposal_bond_minimum); >::put(spend_period); >::put(burn); } /// Reject a proposed spend. The original deposit will be slashed. fn reject_proposal(origin, #[compact] proposal_id: ProposalIndex) { T::RejectOrigin::ensure_origin(origin)?; let proposal = >::take(proposal_id).ok_or("No proposal at that index")?; let value = proposal.bond; let imbalance = T::Currency::slash_reserved(&proposal.proposer, value).0; T::ProposalRejection::on_unbalanced(imbalance); } /// Approve a proposal. At a later time, the proposal will be allocated to the beneficiary /// and the original deposit will be returned. fn approve_proposal(origin, #[compact] proposal_id: ProposalIndex) { T::ApproveOrigin::ensure_origin(origin)?; ensure!(>::exists(proposal_id), "No proposal at that index"); >::mutate(|v| v.push(proposal_id)); } fn on_finalize(n: T::BlockNumber) { // Check to see if we should spend some funds! if (n % Self::spend_period()).is_zero() { Self::spend_funds(); } } } } /// A spending proposal. #[cfg_attr(feature = "std", derive(Serialize, Deserialize, Debug))] #[derive(Encode, Decode, Clone, PartialEq, Eq)] pub struct Proposal { proposer: AccountId, value: Balance, beneficiary: AccountId, bond: Balance, } decl_storage! { trait Store for Module as Treasury { // Config... /// Proportion of funds that should be bonded in order to place a proposal. An accepted /// proposal gets these back. A rejected proposal doesn't. ProposalBond get(proposal_bond) config(): Permill; /// Minimum amount of funds that should be placed in a deposit for making a proposal. ProposalBondMinimum get(proposal_bond_minimum) config(): BalanceOf; /// Period between successive spends. SpendPeriod get(spend_period) config(): T::BlockNumber = runtime_primitives::traits::One::one(); /// Percentage of spare funds (if any) that are burnt per spend period. Burn get(burn) config(): Permill; // State... /// Total funds available to this module for spending. Pot get(pot): BalanceOf; /// Number of proposals that have been made. ProposalCount get(proposal_count): ProposalIndex; /// Proposals that have been made. Proposals get(proposals): map ProposalIndex => Option>>; /// Proposal indices that have been approved but not yet awarded. Approvals get(approvals): Vec; } } decl_event!( pub enum Event where Balance = BalanceOf, ::AccountId { /// New proposal. Proposed(ProposalIndex), /// We have ended a spend period and will now allocate funds. Spending(Balance), /// Some funds have been allocated. Awarded(ProposalIndex, Balance, AccountId), /// Some of our funds have been burnt. Burnt(Balance), /// Spending has finished; this is the amount that rolls over until next spend. Rollover(Balance), } ); impl Module { // Add public immutables and private mutables. /// The needed bond for a proposal whose spend is `value`. fn calculate_bond(value: BalanceOf) -> BalanceOf { Self::proposal_bond_minimum().max(Self::proposal_bond() * value) } // Spend some money! fn spend_funds() { let mut budget_remaining = Self::pot(); Self::deposit_event(RawEvent::Spending(budget_remaining)); let mut missed_any = false; let mut imbalance = >::zero(); >::mutate(|v| { v.retain(|&index| { // Should always be true, but shouldn't panic if false or we're screwed. if let Some(p) = Self::proposals(index) { if p.value <= budget_remaining { budget_remaining -= p.value; >::remove(index); // return their deposit. let _ = T::Currency::unreserve(&p.proposer, p.bond); // provide the allocation. imbalance.subsume(T::Currency::deposit_creating(&p.beneficiary, p.value)); Self::deposit_event(RawEvent::Awarded(index, p.value, p.beneficiary)); false } else { missed_any = true; true } } else { false } }); }); T::MintedForSpending::on_unbalanced(imbalance); if !missed_any { // burn some proportion of the remaining budget if we run a surplus. let burn = (Self::burn() * budget_remaining).min(budget_remaining); budget_remaining -= burn; Self::deposit_event(RawEvent::Burnt(burn)) } Self::deposit_event(RawEvent::Rollover(budget_remaining)); >::put(budget_remaining); } } impl OnDilution> for Module { fn on_dilution(minted: BalanceOf, portion: BalanceOf) { // Mint extra funds for the treasury to keep the ratio of portion to total_issuance equal // pre dilution and post-dilution. if !minted.is_zero() && !portion.is_zero() { let total_issuance = T::Currency::total_issuance(); let funding = (total_issuance - portion) / portion * minted; >::mutate(|x| *x += funding); } } } #[cfg(test)] mod tests { use super::*; use runtime_io::with_externalities; use srml_support::{impl_outer_origin, assert_ok, assert_noop}; use substrate_primitives::{H256, Blake2Hasher}; use runtime_primitives::BuildStorage; use runtime_primitives::traits::{BlakeTwo256, OnFinalize, IdentityLookup}; use runtime_primitives::testing::{Digest, DigestItem, Header}; impl_outer_origin! { pub enum Origin for Test {} } #[derive(Clone, Eq, PartialEq)] pub struct Test; impl system::Trait for Test { type Origin = Origin; type Index = u64; type BlockNumber = u64; type Hash = H256; type Hashing = BlakeTwo256; type Digest = Digest; type AccountId = u64; type Lookup = IdentityLookup; type Header = Header; type Event = (); type Log = DigestItem; } impl balances::Trait for Test { type Balance = u64; type OnNewAccount = (); type OnFreeBalanceZero = (); type Event = (); type TransactionPayment = (); type TransferPayment = (); type DustRemoval = (); } impl Trait for Test { type Currency = balances::Module; type ApproveOrigin = system::EnsureRoot; type RejectOrigin = system::EnsureRoot; type Event = (); type MintedForSpending = (); type ProposalRejection = (); } type Balances = balances::Module; type Treasury = Module; fn new_test_ext() -> runtime_io::TestExternalities { let mut t = system::GenesisConfig::::default().build_storage().unwrap().0; t.extend(balances::GenesisConfig::{ balances: vec![(0, 100), (1, 99), (2, 1)], transaction_base_fee: 0, transaction_byte_fee: 0, transfer_fee: 0, creation_fee: 0, existential_deposit: 0, vesting: vec![], }.build_storage().unwrap().0); t.extend(GenesisConfig::{ proposal_bond: Permill::from_percent(5), proposal_bond_minimum: 1, spend_period: 2, burn: Permill::from_percent(50), }.build_storage().unwrap().0); t.into() } #[test] fn genesis_config_works() { with_externalities(&mut new_test_ext(), || { assert_eq!(Treasury::proposal_bond(), Permill::from_percent(5)); assert_eq!(Treasury::proposal_bond_minimum(), 1); assert_eq!(Treasury::spend_period(), 2); assert_eq!(Treasury::burn(), Permill::from_percent(50)); assert_eq!(Treasury::pot(), 0); assert_eq!(Treasury::proposal_count(), 0); }); } #[test] fn minting_works() { with_externalities(&mut new_test_ext(), || { // Check that accumulate works when we have Some value in Dummy already. Treasury::on_dilution(100, 100); assert_eq!(Treasury::pot(), 100); }); } #[test] fn spend_proposal_takes_min_deposit() { with_externalities(&mut new_test_ext(), || { assert_ok!(Treasury::propose_spend(Origin::signed(0), 1, 3)); assert_eq!(Balances::free_balance(&0), 99); assert_eq!(Balances::reserved_balance(&0), 1); }); } #[test] fn spend_proposal_takes_proportional_deposit() { with_externalities(&mut new_test_ext(), || { assert_ok!(Treasury::propose_spend(Origin::signed(0), 100, 3)); assert_eq!(Balances::free_balance(&0), 95); assert_eq!(Balances::reserved_balance(&0), 5); }); } #[test] fn spend_proposal_fails_when_proposer_poor() { with_externalities(&mut new_test_ext(), || { assert_noop!(Treasury::propose_spend(Origin::signed(2), 100, 3), "Proposer's balance too low"); }); } #[test] fn accepted_spend_proposal_ignored_outside_spend_period() { with_externalities(&mut new_test_ext(), || { Treasury::on_dilution(100, 100); assert_ok!(Treasury::propose_spend(Origin::signed(0), 100, 3)); assert_ok!(Treasury::approve_proposal(Origin::ROOT, 0)); >::on_finalize(1); assert_eq!(Balances::free_balance(&3), 0); assert_eq!(Treasury::pot(), 100); }); } #[test] fn unused_pot_should_diminish() { with_externalities(&mut new_test_ext(), || { Treasury::on_dilution(100, 100); >::on_finalize(2); assert_eq!(Treasury::pot(), 50); }); } #[test] fn rejected_spend_proposal_ignored_on_spend_period() { with_externalities(&mut new_test_ext(), || { Treasury::on_dilution(100, 100); assert_ok!(Treasury::propose_spend(Origin::signed(0), 100, 3)); assert_ok!(Treasury::reject_proposal(Origin::ROOT, 0)); >::on_finalize(2); assert_eq!(Balances::free_balance(&3), 0); assert_eq!(Treasury::pot(), 50); }); } #[test] fn reject_already_rejected_spend_proposal_fails() { with_externalities(&mut new_test_ext(), || { Treasury::on_dilution(100, 100); assert_ok!(Treasury::propose_spend(Origin::signed(0), 100, 3)); assert_ok!(Treasury::reject_proposal(Origin::ROOT, 0)); assert_noop!(Treasury::reject_proposal(Origin::ROOT, 0), "No proposal at that index"); }); } #[test] fn reject_non_existant_spend_proposal_fails() { with_externalities(&mut new_test_ext(), || { assert_noop!(Treasury::reject_proposal(Origin::ROOT, 0), "No proposal at that index"); }); } #[test] fn accept_non_existant_spend_proposal_fails() { with_externalities(&mut new_test_ext(), || { assert_noop!(Treasury::approve_proposal(Origin::ROOT, 0), "No proposal at that index"); }); } #[test] fn accept_already_rejected_spend_proposal_fails() { with_externalities(&mut new_test_ext(), || { Treasury::on_dilution(100, 100); assert_ok!(Treasury::propose_spend(Origin::signed(0), 100, 3)); assert_ok!(Treasury::reject_proposal(Origin::ROOT, 0)); assert_noop!(Treasury::approve_proposal(Origin::ROOT, 0), "No proposal at that index"); }); } #[test] fn accepted_spend_proposal_enacted_on_spend_period() { with_externalities(&mut new_test_ext(), || { Treasury::on_dilution(100, 100); assert_ok!(Treasury::propose_spend(Origin::signed(0), 100, 3)); assert_ok!(Treasury::approve_proposal(Origin::ROOT, 0)); >::on_finalize(2); assert_eq!(Balances::free_balance(&3), 100); assert_eq!(Treasury::pot(), 0); }); } #[test] fn pot_underflow_should_not_diminish() { with_externalities(&mut new_test_ext(), || { Treasury::on_dilution(100, 100); assert_ok!(Treasury::propose_spend(Origin::signed(0), 150, 3)); assert_ok!(Treasury::approve_proposal(Origin::ROOT, 0)); >::on_finalize(2); assert_eq!(Treasury::pot(), 100); Treasury::on_dilution(100, 100); >::on_finalize(4); assert_eq!(Balances::free_balance(&3), 150); assert_eq!(Treasury::pot(), 25); }); } }