// This file is part of Substrate.
// Copyright (C) 2021-2022 Parity Technologies (UK) Ltd.
// SPDX-License-Identifier: GPL-3.0-or-later WITH Classpath-exception-2.0
// This program is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
// This program is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
// You should have received a copy of the GNU General Public License
// along with this program. If not, see .
//! RPC API for BEEFY.
#![warn(missing_docs)]
use parking_lot::RwLock;
use std::sync::Arc;
use sp_runtime::traits::Block as BlockT;
use futures::{task::SpawnError, FutureExt, SinkExt, StreamExt, TryFutureExt};
use jsonrpc_derive::rpc;
use jsonrpc_pubsub::{manager::SubscriptionManager, typed::Subscriber, SubscriptionId};
use log::warn;
use beefy_gadget::notification::{BeefyBestBlockStream, BeefySignedCommitmentStream};
mod notification;
type FutureResult = jsonrpc_core::BoxFuture>;
#[derive(Debug, thiserror::Error)]
/// Top-level error type for the RPC handler
pub enum Error {
/// The BEEFY RPC endpoint is not ready.
#[error("BEEFY RPC endpoint not ready")]
EndpointNotReady,
/// The BEEFY RPC background task failed to spawn.
#[error("BEEFY RPC background task failed to spawn")]
RpcTaskFailure(#[from] SpawnError),
}
/// The error codes returned by jsonrpc.
pub enum ErrorCode {
/// Returned when BEEFY RPC endpoint is not ready.
NotReady = 1,
/// Returned on BEEFY RPC background task failure.
TaskFailure = 2,
}
impl From for ErrorCode {
fn from(error: Error) -> Self {
match error {
Error::EndpointNotReady => ErrorCode::NotReady,
Error::RpcTaskFailure(_) => ErrorCode::TaskFailure,
}
}
}
impl From for jsonrpc_core::Error {
fn from(error: Error) -> Self {
let message = format!("{}", error);
let code = ErrorCode::from(error);
jsonrpc_core::Error {
message,
code: jsonrpc_core::ErrorCode::ServerError(code as i64),
data: None,
}
}
}
/// Provides RPC methods for interacting with BEEFY.
#[rpc]
pub trait BeefyApi {
/// RPC Metadata
type Metadata;
/// Returns the block most recently finalized by BEEFY, alongside side its justification.
#[pubsub(
subscription = "beefy_justifications",
subscribe,
name = "beefy_subscribeJustifications"
)]
fn subscribe_justifications(
&self,
metadata: Self::Metadata,
subscriber: Subscriber,
);
/// Unsubscribe from receiving notifications about recently finalized blocks.
#[pubsub(
subscription = "beefy_justifications",
unsubscribe,
name = "beefy_unsubscribeJustifications"
)]
fn unsubscribe_justifications(
&self,
metadata: Option,
id: SubscriptionId,
) -> jsonrpc_core::Result;
/// Returns hash of the latest BEEFY finalized block as seen by this client.
///
/// The latest BEEFY block might not be available if the BEEFY gadget is not running
/// in the network or if the client is still initializing or syncing with the network.
/// In such case an error would be returned.
#[rpc(name = "beefy_getFinalizedHead")]
fn latest_finalized(&self) -> FutureResult;
}
/// Implements the BeefyApi RPC trait for interacting with BEEFY.
pub struct BeefyRpcHandler {
signed_commitment_stream: BeefySignedCommitmentStream,
beefy_best_block: Arc>>,
manager: SubscriptionManager,
}
impl BeefyRpcHandler {
/// Creates a new BeefyRpcHandler instance.
pub fn new(
signed_commitment_stream: BeefySignedCommitmentStream,
best_block_stream: BeefyBestBlockStream,
executor: E,
) -> Result
where
E: futures::task::Spawn + Send + Sync + 'static,
{
let beefy_best_block = Arc::new(RwLock::new(None));
let stream = best_block_stream.subscribe();
let closure_clone = beefy_best_block.clone();
let future = stream.for_each(move |best_beefy| {
let async_clone = closure_clone.clone();
async move {
*async_clone.write() = Some(best_beefy);
}
});
executor
.spawn_obj(futures::task::FutureObj::new(Box::pin(future)))
.map_err(|e| {
log::error!("Failed to spawn BEEFY RPC background task; err: {}", e);
e
})?;
let manager = SubscriptionManager::new(Arc::new(executor));
Ok(Self { signed_commitment_stream, beefy_best_block, manager })
}
}
impl BeefyApi for BeefyRpcHandler
where
Block: BlockT,
{
type Metadata = sc_rpc::Metadata;
fn subscribe_justifications(
&self,
_metadata: Self::Metadata,
subscriber: Subscriber,
) {
let stream = self
.signed_commitment_stream
.subscribe()
.map(|x| Ok::<_, ()>(Ok(notification::EncodedSignedCommitment::new::(x))));
self.manager.add(subscriber, |sink| {
stream
.forward(sink.sink_map_err(|e| warn!("Error sending notifications: {:?}", e)))
.map(|_| ())
});
}
fn unsubscribe_justifications(
&self,
_metadata: Option,
id: SubscriptionId,
) -> jsonrpc_core::Result {
Ok(self.manager.cancel(id))
}
fn latest_finalized(&self) -> FutureResult {
let result: Result = self
.beefy_best_block
.read()
.as_ref()
.cloned()
.ok_or(Error::EndpointNotReady.into());
let future = async move { result }.boxed();
future.map_err(jsonrpc_core::Error::from).boxed()
}
}
#[cfg(test)]
mod tests {
use super::*;
use jsonrpc_core::{types::Params, Notification, Output};
use beefy_gadget::notification::{BeefySignedCommitment, BeefySignedCommitmentSender};
use beefy_primitives::{known_payload_ids, Payload};
use codec::{Decode, Encode};
use sp_runtime::traits::{BlakeTwo256, Hash};
use substrate_test_runtime_client::runtime::Block;
fn setup_io_handler(
) -> (jsonrpc_core::MetaIoHandler, BeefySignedCommitmentSender) {
let (_, stream) = BeefyBestBlockStream::::channel();
setup_io_handler_with_best_block_stream(stream)
}
fn setup_io_handler_with_best_block_stream(
best_block_stream: BeefyBestBlockStream,
) -> (jsonrpc_core::MetaIoHandler, BeefySignedCommitmentSender) {
let (commitment_sender, commitment_stream) =
BeefySignedCommitmentStream::::channel();
let handler: BeefyRpcHandler = BeefyRpcHandler::new(
commitment_stream,
best_block_stream,
sc_rpc::testing::TaskExecutor,
)
.unwrap();
let mut io = jsonrpc_core::MetaIoHandler::default();
io.extend_with(BeefyApi::to_delegate(handler));
(io, commitment_sender)
}
fn setup_session() -> (sc_rpc::Metadata, futures::channel::mpsc::UnboundedReceiver) {
let (tx, rx) = futures::channel::mpsc::unbounded();
let meta = sc_rpc::Metadata::new(tx);
(meta, rx)
}
#[test]
fn uninitialized_rpc_handler() {
let (io, _) = setup_io_handler();
let request = r#"{"jsonrpc":"2.0","method":"beefy_getFinalizedHead","params":[],"id":1}"#;
let response = r#"{"jsonrpc":"2.0","error":{"code":1,"message":"BEEFY RPC endpoint not ready"},"id":1}"#;
let meta = sc_rpc::Metadata::default();
assert_eq!(Some(response.into()), io.handle_request_sync(request, meta));
}
#[test]
fn latest_finalized_rpc() {
let (sender, stream) = BeefyBestBlockStream::::channel();
let (io, _) = setup_io_handler_with_best_block_stream(stream);
let hash = BlakeTwo256::hash(b"42");
let r: Result<(), ()> = sender.notify(|| Ok(hash));
r.unwrap();
// Verify RPC `beefy_getFinalizedHead` returns expected hash.
let request = r#"{"jsonrpc":"2.0","method":"beefy_getFinalizedHead","params":[],"id":1}"#;
let expected = "{\
\"jsonrpc\":\"2.0\",\
\"result\":\"0x2f0039e93a27221fcf657fb877a1d4f60307106113e885096cb44a461cd0afbf\",\
\"id\":1\
}";
let not_ready = "{\
\"jsonrpc\":\"2.0\",\
\"error\":{\"code\":1,\"message\":\"BEEFY RPC endpoint not ready\"},\
\"id\":1\
}";
let deadline = std::time::Instant::now() + std::time::Duration::from_secs(2);
while std::time::Instant::now() < deadline {
let meta = sc_rpc::Metadata::default();
let response = io.handle_request_sync(request, meta);
// Retry "not ready" responses.
if response != Some(not_ready.into()) {
assert_eq!(response, Some(expected.into()));
// Success
return
}
std::thread::sleep(std::time::Duration::from_millis(50));
}
panic!(
"Deadline reached while waiting for best BEEFY block to update. Perhaps the background task is broken?"
);
}
#[test]
fn subscribe_and_unsubscribe_to_justifications() {
let (io, _) = setup_io_handler();
let (meta, _) = setup_session();
// Subscribe
let sub_request =
r#"{"jsonrpc":"2.0","method":"beefy_subscribeJustifications","params":[],"id":1}"#;
let resp = io.handle_request_sync(sub_request, meta.clone());
let resp: Output = serde_json::from_str(&resp.unwrap()).unwrap();
let sub_id = match resp {
Output::Success(success) => success.result,
_ => panic!(),
};
// Unsubscribe
let unsub_req = format!(
r#"{{"jsonrpc":"2.0","method":"beefy_unsubscribeJustifications","params":[{}],"id":1}}"#,
sub_id
);
assert_eq!(
io.handle_request_sync(&unsub_req, meta.clone()),
Some(r#"{"jsonrpc":"2.0","result":true,"id":1}"#.into()),
);
// Unsubscribe again and fail
assert_eq!(
io.handle_request_sync(&unsub_req, meta),
Some(r#"{"jsonrpc":"2.0","error":{"code":-32602,"message":"Invalid subscription id."},"id":1}"#.into()),
);
}
#[test]
fn subscribe_and_unsubscribe_with_wrong_id() {
let (io, _) = setup_io_handler();
let (meta, _) = setup_session();
// Subscribe
let sub_request =
r#"{"jsonrpc":"2.0","method":"beefy_subscribeJustifications","params":[],"id":1}"#;
let resp = io.handle_request_sync(sub_request, meta.clone());
let resp: Output = serde_json::from_str(&resp.unwrap()).unwrap();
assert!(matches!(resp, Output::Success(_)));
// Unsubscribe with wrong ID
assert_eq!(
io.handle_request_sync(
r#"{"jsonrpc":"2.0","method":"beefy_unsubscribeJustifications","params":["FOO"],"id":1}"#,
meta.clone()
),
Some(r#"{"jsonrpc":"2.0","error":{"code":-32602,"message":"Invalid subscription id."},"id":1}"#.into())
);
}
fn create_commitment() -> BeefySignedCommitment {
let payload = Payload::new(known_payload_ids::MMR_ROOT_ID, "Hello World!".encode());
BeefySignedCommitment:: {
commitment: beefy_primitives::Commitment {
payload,
block_number: 5,
validator_set_id: 0,
},
signatures: vec![],
}
}
#[test]
fn subscribe_and_listen_to_one_justification() {
let (io, commitment_sender) = setup_io_handler();
let (meta, receiver) = setup_session();
// Subscribe
let sub_request =
r#"{"jsonrpc":"2.0","method":"beefy_subscribeJustifications","params":[],"id":1}"#;
let resp = io.handle_request_sync(sub_request, meta.clone());
let mut resp: serde_json::Value = serde_json::from_str(&resp.unwrap()).unwrap();
let sub_id: String = serde_json::from_value(resp["result"].take()).unwrap();
// Notify with commitment
let commitment = create_commitment();
let r: Result<(), ()> = commitment_sender.notify(|| Ok(commitment.clone()));
r.unwrap();
// Inspect what we received
let recv = futures::executor::block_on(receiver.take(1).collect::>());
let recv: Notification = serde_json::from_str(&recv[0]).unwrap();
let mut json_map = match recv.params {
Params::Map(json_map) => json_map,
_ => panic!(),
};
let recv_sub_id: String = serde_json::from_value(json_map["subscription"].take()).unwrap();
let recv_commitment: sp_core::Bytes =
serde_json::from_value(json_map["result"].take()).unwrap();
let recv_commitment: BeefySignedCommitment =
Decode::decode(&mut &recv_commitment[..]).unwrap();
assert_eq!(recv.method, "beefy_justifications");
assert_eq!(recv_sub_id, sub_id);
assert_eq!(recv_commitment, commitment);
}
}