Files
pezkuwi-subxt/substrate/frame/support/test/tests/pallet_compatibility_instance.rs
T
Andrew Jones 49b6dfd2e5 Enrich metadata with type information (#8615)
* Cargo.lock after merge

* Restore scale-info feature

* Fully qualify TypeInfo derive

* Skip PendingSwap T

* Add missing skip_type_params attr

* metadata docs features

* Reduce pallet event attribute to struct

* Cargo.lock

* Update frame/balances/src/tests_composite.rs

Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>

* Line widths check

* Cargo.lock

* Add scale-info/std

* Update frame/system/src/lib.rs

Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>

* Use `skip_type_params` to remove `TypeInfo` requirements on checks

* Revert "Remove unused Call metadata stuff"

This reverts commit 41311f85

* Skip BalanceSwapAction type parameter

* Remove unused event metadata macro

* Update frame-metadata

* Update primitives/npos-elections/compact/src/codec.rs

Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>

* Manual TypeInfo for Header

* Remove TypeInfo requirement for consts in BoundedVec etc.

* Another TypeInfo bound removed

* review: fix indentation

* TypeInfo impls for Identity types

* Add some todos to add custom TypeInfo impls

* Update frame/support/procedural/src/pallet/expand/pallet_struct.rs

Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>

* Add some todos to add custom TypeInfo impls

* Add a test for manual Data TypeInfo impl

* Add custom TypeInfo impl for Vote

* Era custom TypeInfo crimes

* Revert finality-grandpa version to 0.14.z

* review: renamed module to pallet_constants_metadata

* New line at end of file

* Add missing scale-info/std

* Update frame/support/src/storage/types/mod.rs

Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>

* Remove StorageEntryType::Map unused flag

* Add missing scale-info dependency after merge

* SignedExtension::AdditionalSigned metadata

* Update frame-metadata, use abbreviated docs and args fields

* Update frame/example/Cargo.toml

Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>

* Add scale_info/std and remove unused scale-info dependency

* Remove scale-info dependency

* Remove treasury pallet::metadata

* Remove redundant Event test

* Add back scale-info as dev dependency

* fix error metadata when no error defined in decl_module

* Add Module3 to tests

* Fix metadata test

* Add docs feature to frame-support test

* WIP fixing pallet metadata test

* Remove redundant FunctionMetadata, FunctionArgumentMetadata as per https://github.com/paritytech/frame-metadata/pull/20

* Use main branch of frame-metadata

* Use patch of scale-info for latest changes

* Use latest patched scale-info

* Manual TypeInfo for DigestItem

* Manual TypeInfo for DigestItem

* Update scale-info

* Skip __Ignore variants for Error, depends on https://github.com/paritytech/scale-info/pull/117

* Named fields for FRAME v2 pallet Call variants

* Named fields for FRAME v1 pallet Call variants

* Add missing scale-info dependency

* WIP expand benchmark call variant

* fix benchmark with new function

create a new function for each variant of a pallet call.
This function is called by benchmarking macro in order not to break call
creation with unnamed argument

* fix tests

* more fix

* Fix staking tests

* Fix offchain workers calls

* Cherry pick rustfmt.toml from master

* cargo +nightly-2021-06-22 fmt --all

* Update to new call variant structs

* More call variant struct updates

* Remove unused import

* More call variant structs

* More call variant structs

* Even more call variant structs

* Mooar variant structs

* Evermore variant structs

* Call variant structs ad infinitum

* Fmt

* More call variants

* Last call variant

* Call variants all done?

* Fix SS58Prefix type

* Potential workaround for BitFlags<IdentityFields> TypeInfo

* Enable docs capturing for Call, Event, and Error types

* Fix IdentityFields TypeInfo

* Remove metadata-docs feature

* Add capture_docs = true for legacy Call, Event and Error types

* Fmt

* Fix metadata test type

* Update benchmarks with call struct variants

* Fmt

* More test fixes

* Fmt

* Fix benches

* Use latest capture_docs attr

* Latest scale_info

* Fmt

* review: change &Vec to &[]

* Remove pallet metadata attr

* review: remove commented out test code

* review: skip_type_params trailing comma suggestion

* Update to scale-info 0.10.0

* Update construct_runtime ui tests, different because of metadata TypeInfo impls

* Add some TypeInfo derives for UI tests

* Update storage ensure span ui stderrs

* Update call argument bound ui tests

Possibly changed because change from tuple to struct variants?

* Add scale-info dev dependency

* Update to latest finality-grandpa release

* review: missing newline

* review: missing scale-info/std

* review: remove duplicate scale-info/std

* review: remove fully qualified TypeInfo

* review: add missing scale-info/std

* review: remove unnecessary imports.

* Fmt

* Use crates.io RC version of frame-metadata

* Remove scale-info/std because it is a dev dependency

* Add missing scale_info dev-dependency for test

* Delete empty metadata folder

* Fix sp_std import

* review: improve manual UncheckedExtrinsic TypeInfo impl

* review: use full scale-info for dev-dependency

* Remove DefaultByteGetter impl

* review: derive TypeInfo for generic header

* Fmt

* Update primitives/runtime/src/generic/unchecked_extrinsic.rs

Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>

* Update primitives/runtime/src/generic/unchecked_extrinsic.rs

Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>

* Update bin/node/executor/Cargo.toml

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

* Update frame/identity/src/types.rs

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

* Update frame/support/src/dispatch.rs

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

* Remove redundant derive

* Simplify scale-info dependency

* Strip underscore prefix from call variant struct names

* Another underscore field

* More underscore fields

* Another underscore field

* Update to frame-metadata 14.0.0-rc.2 with combined StorageEntryType::Map

* Fmt

* Revert weights formatting

* Fix up some tests

* Fix up some tests for StorageEntryTypeMetadata

* scale-info dev dependency

* Fix test error

* Add missing TypeInfo derives

* Add back missing scale-info dependency

* Add back missing scale-info dependency

* Fix npos compact impls

* Cargo.lock

* Fmt

* Fix errors

* Fmt

* Fix renamed raw_solution field

* Fix error

* Fmt

* Fix some benchmarks

* Fmt

* Stray R

* Fix

* Add missing TypeInfos

* ui test fix

* Fix line widths

* Revert "ui test fix"

This reverts commit 2d15ec058a216e3f92d713f1174603a2bb1eac65.

* Upgrade to scale-info 0.11.0

* Revert "Upgrade to scale-info 0.11.0"

This reverts commit 047bb179085a0059c36cd20ab405f55cf0867e28.

* Add Runtime type

* Update to scale-info 0.12

* Update to scale-info 1.0

* Update frame-metadata to version 14.0.0

* Patch finality-grandpa until release available

* Fix metadata tests

* Fix metadata tests

* Fmt

* Remove patched finality-grandpa

* Fix tests, use scale_info imports

* Fix pallet tests

* Add BlockNumber TypeInfo bound

* ui test fix

* Cargo.lock

* Remove pallet metadata

* Cargo.lock

* Add missing scale-info dependency

* Remove pallet event metadata

* Fix error

* Fix collective errors

* Semicolol

* Fmt

* Remove another metadata attribute

* Add new variant to custom digest TypeInfo

* Fmt

* Cargo.lock from master

* Remove comma lol

* Fix example call error

* Fix example call error properly

Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
2021-09-15 11:40:41 +00:00

367 lines
10 KiB
Rust

// This file is part of Substrate.
// Copyright (C) 2020-2021 Parity Technologies (UK) Ltd.
// SPDX-License-Identifier: Apache-2.0
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
mod pallet_old {
use frame_support::{
decl_error, decl_event, decl_module, decl_storage, traits::Get, weights::Weight, Parameter,
};
use frame_system::ensure_root;
pub trait Config<I: Instance = DefaultInstance>: frame_system::Config {
type SomeConst: Get<Self::Balance>;
type Balance: Parameter + codec::HasCompact + From<u32> + Into<Weight> + Default;
type Event: From<Event<Self, I>> + Into<<Self as frame_system::Config>::Event>;
}
decl_storage! {
trait Store for Module<T: Config<I>, I: Instance = DefaultInstance> as Example {
/// Some documentation
Dummy get(fn dummy) config(): Option<T::Balance>;
Bar get(fn bar) config(): map hasher(blake2_128_concat) T::AccountId => T::Balance;
Foo get(fn foo) config(): T::Balance = 3.into();
Double get(fn double):
double_map hasher(blake2_128_concat) u32, hasher(twox_64_concat) u64 => u16;
}
}
decl_event!(
pub enum Event<T, I = DefaultInstance>
where
Balance = <T as Config<I>>::Balance,
{
/// Dummy event, just here so there's a generic type that's used.
Dummy(Balance),
}
);
decl_module! {
pub struct Module<T: Config<I>, I: Instance = DefaultInstance> for enum Call
where origin: T::Origin
{
type Error = Error<T, I>;
fn deposit_event() = default;
const SomeConst: T::Balance = T::SomeConst::get();
#[weight = <T::Balance as Into<Weight>>::into(new_value.clone())]
fn set_dummy(origin, #[compact] new_value: T::Balance) {
ensure_root(origin)?;
<Dummy<T, I>>::put(&new_value);
Self::deposit_event(RawEvent::Dummy(new_value));
}
fn on_initialize(_n: T::BlockNumber) -> Weight {
<Dummy<T, I>>::put(T::Balance::from(10));
10
}
fn on_finalize(_n: T::BlockNumber) {
<Dummy<T, I>>::put(T::Balance::from(11));
}
}
}
decl_error! {
pub enum Error for Module<T: Config<I>, I: Instance> {
/// Some wrong behavior
Wrong,
}
}
}
#[frame_support::pallet]
pub mod pallet {
use frame_support::{pallet_prelude::*, scale_info};
use frame_system::{ensure_root, pallet_prelude::*};
#[pallet::config]
pub trait Config<I: 'static = ()>: frame_system::Config {
type Balance: Parameter
+ codec::HasCompact
+ From<u32>
+ Into<Weight>
+ Default
+ MaybeSerializeDeserialize
+ scale_info::StaticTypeInfo;
#[pallet::constant]
type SomeConst: Get<Self::Balance>;
type Event: From<Event<Self, I>> + IsType<<Self as frame_system::Config>::Event>;
}
#[pallet::pallet]
pub struct Pallet<T, I = ()>(PhantomData<(T, I)>);
#[pallet::hooks]
impl<T: Config<I>, I: 'static> Hooks<T::BlockNumber> for Pallet<T, I> {
fn on_initialize(_n: T::BlockNumber) -> Weight {
<Dummy<T, I>>::put(T::Balance::from(10));
10
}
fn on_finalize(_n: T::BlockNumber) {
<Dummy<T, I>>::put(T::Balance::from(11));
}
}
#[pallet::call]
impl<T: Config<I>, I: 'static> Pallet<T, I> {
#[pallet::weight(<T::Balance as Into<Weight>>::into(new_value.clone()))]
pub fn set_dummy(
origin: OriginFor<T>,
#[pallet::compact] new_value: T::Balance,
) -> DispatchResultWithPostInfo {
ensure_root(origin)?;
<Dummy<T, I>>::put(&new_value);
Self::deposit_event(Event::Dummy(new_value));
Ok(().into())
}
}
#[pallet::error]
pub enum Error<T, I = ()> {
/// Some wrong behavior
Wrong,
}
#[pallet::event]
#[pallet::generate_deposit(fn deposit_event)]
pub enum Event<T: Config<I>, I: 'static = ()> {
/// Dummy event, just here so there's a generic type that's used.
Dummy(T::Balance),
}
#[pallet::storage]
/// Some documentation
type Dummy<T: Config<I>, I: 'static = ()> = StorageValue<_, T::Balance, OptionQuery>;
#[pallet::storage]
type Bar<T: Config<I>, I: 'static = ()> =
StorageMap<_, Blake2_128Concat, T::AccountId, T::Balance, ValueQuery>;
#[pallet::storage]
type Foo<T: Config<I>, I: 'static = ()> =
StorageValue<_, T::Balance, ValueQuery, OnFooEmpty<T, I>>;
#[pallet::type_value]
pub fn OnFooEmpty<T: Config<I>, I: 'static>() -> T::Balance {
3.into()
}
#[pallet::storage]
type Double<T, I = ()> =
StorageDoubleMap<_, Blake2_128Concat, u32, Twox64Concat, u64, u16, ValueQuery>;
#[pallet::genesis_config]
pub struct GenesisConfig<T: Config<I>, I: 'static = ()> {
dummy: Option<T::Balance>,
bar: Vec<(T::AccountId, T::Balance)>,
foo: T::Balance,
}
impl<T: Config<I>, I: 'static> Default for GenesisConfig<T, I> {
fn default() -> Self {
GenesisConfig {
dummy: Default::default(),
bar: Default::default(),
foo: OnFooEmpty::<T, I>::get(),
}
}
}
#[pallet::genesis_build]
impl<T: Config<I>, I: 'static> GenesisBuild<T, I> for GenesisConfig<T, I> {
fn build(&self) {
if let Some(dummy) = self.dummy.as_ref() {
<Dummy<T, I>>::put(dummy);
}
for (k, v) in &self.bar {
<Bar<T, I>>::insert(k, v);
}
<Foo<T, I>>::put(&self.foo);
}
}
}
frame_support::parameter_types!(
pub const SomeConst: u64 = 10;
pub const BlockHashCount: u32 = 250;
);
impl frame_system::Config for Runtime {
type BlockWeights = ();
type BlockLength = ();
type DbWeight = ();
type BaseCallFilter = frame_support::traits::Everything;
type Origin = Origin;
type Index = u64;
type BlockNumber = u32;
type Call = Call;
type Hash = sp_runtime::testing::H256;
type Hashing = sp_runtime::traits::BlakeTwo256;
type AccountId = u64;
type Lookup = sp_runtime::traits::IdentityLookup<Self::AccountId>;
type Header = Header;
type Event = Event;
type BlockHashCount = BlockHashCount;
type Version = ();
type PalletInfo = PalletInfo;
type AccountData = ();
type OnNewAccount = ();
type OnKilledAccount = ();
type SystemWeightInfo = ();
type SS58Prefix = ();
type OnSetCode = ();
}
impl pallet::Config for Runtime {
type Event = Event;
type SomeConst = SomeConst;
type Balance = u64;
}
impl pallet::Config<pallet::Instance2> for Runtime {
type Event = Event;
type SomeConst = SomeConst;
type Balance = u64;
}
impl pallet::Config<pallet::Instance3> for Runtime {
type Event = Event;
type SomeConst = SomeConst;
type Balance = u64;
}
impl pallet_old::Config for Runtime {
type Event = Event;
type SomeConst = SomeConst;
type Balance = u64;
}
impl pallet_old::Config<pallet_old::Instance2> for Runtime {
type Event = Event;
type SomeConst = SomeConst;
type Balance = u64;
}
impl pallet_old::Config<pallet_old::Instance3> for Runtime {
type Event = Event;
type SomeConst = SomeConst;
type Balance = u64;
}
pub type Header = sp_runtime::generic::Header<u32, sp_runtime::traits::BlakeTwo256>;
pub type Block = sp_runtime::generic::Block<Header, UncheckedExtrinsic>;
pub type UncheckedExtrinsic = sp_runtime::generic::UncheckedExtrinsic<u32, Call, (), ()>;
frame_support::construct_runtime!(
pub enum Runtime where
Block = Block,
NodeBlock = Block,
UncheckedExtrinsic = UncheckedExtrinsic
{
System: frame_system::{Pallet, Call, Event<T>},
Example: pallet::{Pallet, Call, Event<T>, Config<T>, Storage},
PalletOld: pallet_old::{Pallet, Call, Event<T>, Config<T>, Storage},
Instance2Example: pallet::<Instance2>::{Pallet, Call, Event<T>, Config<T>, Storage},
PalletOld2: pallet_old::<Instance2>::{Pallet, Call, Event<T>, Config<T>, Storage},
Instance3Example: pallet::<Instance3>::{Pallet, Call, Event<T>, Config<T>, Storage},
PalletOld3: pallet_old::<Instance3>::{Pallet, Call, Event<T>, Config<T>, Storage},
}
);
#[cfg(test)]
mod test {
use super::{pallet, pallet_old, Runtime};
use codec::{Decode, Encode};
use scale_info::{form::PortableForm, Variant};
#[test]
fn metadata() {
let metadata = Runtime::metadata();
let (pallets, types) = match metadata.1 {
frame_support::metadata::RuntimeMetadata::V14(metadata) =>
(metadata.pallets, metadata.types),
_ => unreachable!(),
};
let get_enum_variants = |ty_id| match types.resolve(ty_id).map(|ty| ty.type_def()) {
Some(ty) => match ty {
scale_info::TypeDef::Variant(var) => var.variants(),
_ => panic!("Expected variant type"),
},
_ => panic!("No type found"),
};
let assert_enum_variants = |vs1: &[Variant<PortableForm>],
vs2: &[Variant<PortableForm>]| {
assert_eq!(vs1.len(), vs2.len());
for i in 0..vs1.len() {
let v1 = &vs2[i];
let v2 = &vs2[i];
assert_eq!(v1.fields().len(), v2.fields().len());
for f in 0..v1.fields().len() {
let f1 = &v1.fields()[f];
let f2 = &v2.fields()[f];
pretty_assertions::assert_eq!(f1.name(), f2.name());
pretty_assertions::assert_eq!(f1.ty(), f2.ty());
}
}
};
for i in vec![1, 3, 5].into_iter() {
pretty_assertions::assert_eq!(pallets[i].storage, pallets[i + 1].storage);
let call1_variants = get_enum_variants(pallets[i].calls.as_ref().unwrap().ty.id());
let call2_variants = get_enum_variants(pallets[i + 1].calls.as_ref().unwrap().ty.id());
assert_enum_variants(call1_variants, call2_variants);
// event: check variants and fields but ignore the type name which will be different
let event1_variants = get_enum_variants(pallets[i].event.as_ref().unwrap().ty.id());
let event2_variants = get_enum_variants(pallets[i + 1].event.as_ref().unwrap().ty.id());
assert_enum_variants(event1_variants, event2_variants);
let err1 = get_enum_variants(pallets[i].error.as_ref().unwrap().ty.id())
.iter()
.filter(|v| v.name() == "__Ignore")
.cloned()
.collect::<Vec<_>>();
let err2 = get_enum_variants(pallets[i + 1].error.as_ref().unwrap().ty.id())
.iter()
.filter(|v| v.name() == "__Ignore")
.cloned()
.collect::<Vec<_>>();
assert_enum_variants(&err1, &err2);
pretty_assertions::assert_eq!(pallets[i].constants, pallets[i + 1].constants);
}
}
#[test]
fn types() {
assert_eq!(
pallet_old::Event::<Runtime>::decode(
&mut &pallet::Event::<Runtime>::Dummy(10).encode()[..]
)
.unwrap(),
pallet_old::Event::<Runtime>::Dummy(10),
);
assert_eq!(
pallet_old::Call::<Runtime>::decode(
&mut &pallet::Call::<Runtime>::set_dummy { new_value: 10 }.encode()[..]
)
.unwrap(),
pallet_old::Call::<Runtime>::set_dummy { new_value: 10 },
);
}
}