mirror of
https://github.com/pezkuwichain/pezkuwi-subxt.git
synced 2026-04-26 16:57:58 +00:00
fd5f9292f5
Closes #2160 First part of [Extrinsic Horizon](https://github.com/paritytech/polkadot-sdk/issues/2415) Introduces a new trait `TransactionExtension` to replace `SignedExtension`. Introduce the idea of transactions which obey the runtime's extensions and have according Extension data (né Extra data) yet do not have hard-coded signatures. Deprecate the terminology of "Unsigned" when used for transactions/extrinsics owing to there now being "proper" unsigned transactions which obey the extension framework and "old-style" unsigned which do not. Instead we have __*General*__ for the former and __*Bare*__ for the latter. (Ultimately, the latter will be phased out as a type of transaction, and Bare will only be used for Inherents.) Types of extrinsic are now therefore: - Bare (no hardcoded signature, no Extra data; used to be known as "Unsigned") - Bare transactions (deprecated): Gossiped, validated with `ValidateUnsigned` (deprecated) and the `_bare_compat` bits of `TransactionExtension` (deprecated). - Inherents: Not gossiped, validated with `ProvideInherent`. - Extended (Extra data): Gossiped, validated via `TransactionExtension`. - Signed transactions (with a hardcoded signature). - General transactions (without a hardcoded signature). `TransactionExtension` differs from `SignedExtension` because: - A signature on the underlying transaction may validly not be present. - It may alter the origin during validation. - `pre_dispatch` is renamed to `prepare` and need not contain the checks present in `validate`. - `validate` and `prepare` is passed an `Origin` rather than a `AccountId`. - `validate` may pass arbitrary information into `prepare` via a new user-specifiable type `Val`. - `AdditionalSigned`/`additional_signed` is renamed to `Implicit`/`implicit`. It is encoded *for the entire transaction* and passed in to each extension as a new argument to `validate`. This facilitates the ability of extensions to acts as underlying crypto. There is a new `DispatchTransaction` trait which contains only default function impls and is impl'ed for any `TransactionExtension` impler. It provides several utility functions which reduce some of the tedium from using `TransactionExtension` (indeed, none of its regular functions should now need to be called directly). Three transaction version discriminator ("versions") are now permissible: - 0b000000100: Bare (used to be called "Unsigned"): contains Signature or Extra (extension data). After bare transactions are no longer supported, this will strictly identify an Inherents only. - 0b100000100: Old-school "Signed" Transaction: contains Signature and Extra (extension data). - 0b010000100: New-school "General" Transaction: contains Extra (extension data), but no Signature. For the New-school General Transaction, it becomes trivial for authors to publish extensions to the mechanism for authorizing an Origin, e.g. through new kinds of key-signing schemes, ZK proofs, pallet state, mutations over pre-authenticated origins or any combination of the above. ## Code Migration ### NOW: Getting it to build Wrap your `SignedExtension`s in `AsTransactionExtension`. This should be accompanied by renaming your aggregate type in line with the new terminology. E.g. Before: ```rust /// The SignedExtension to the basic transaction logic. pub type SignedExtra = ( /* snip */ MySpecialSignedExtension, ); /// Unchecked extrinsic type as expected by this runtime. pub type UncheckedExtrinsic = generic::UncheckedExtrinsic<Address, RuntimeCall, Signature, SignedExtra>; ``` After: ```rust /// The extension to the basic transaction logic. pub type TxExtension = ( /* snip */ AsTransactionExtension<MySpecialSignedExtension>, ); /// Unchecked extrinsic type as expected by this runtime. pub type UncheckedExtrinsic = generic::UncheckedExtrinsic<Address, RuntimeCall, Signature, TxExtension>; ``` You'll also need to alter any transaction building logic to add a `.into()` to make the conversion happen. E.g. Before: ```rust fn construct_extrinsic( /* snip */ ) -> UncheckedExtrinsic { let extra: SignedExtra = ( /* snip */ MySpecialSignedExtension::new(/* snip */), ); let payload = SignedPayload::new(call.clone(), extra.clone()).unwrap(); let signature = payload.using_encoded(|e| sender.sign(e)); UncheckedExtrinsic::new_signed( /* snip */ Signature::Sr25519(signature), extra, ) } ``` After: ```rust fn construct_extrinsic( /* snip */ ) -> UncheckedExtrinsic { let tx_ext: TxExtension = ( /* snip */ MySpecialSignedExtension::new(/* snip */).into(), ); let payload = SignedPayload::new(call.clone(), tx_ext.clone()).unwrap(); let signature = payload.using_encoded(|e| sender.sign(e)); UncheckedExtrinsic::new_signed( /* snip */ Signature::Sr25519(signature), tx_ext, ) } ``` ### SOON: Migrating to `TransactionExtension` Most `SignedExtension`s can be trivially converted to become a `TransactionExtension`. There are a few things to know. - Instead of a single trait like `SignedExtension`, you should now implement two traits individually: `TransactionExtensionBase` and `TransactionExtension`. - Weights are now a thing and must be provided via the new function `fn weight`. #### `TransactionExtensionBase` This trait takes care of anything which is not dependent on types specific to your runtime, most notably `Call`. - `AdditionalSigned`/`additional_signed` is renamed to `Implicit`/`implicit`. - Weight must be returned by implementing the `weight` function. If your extension is associated with a pallet, you'll probably want to do this via the pallet's existing benchmarking infrastructure. #### `TransactionExtension` Generally: - `pre_dispatch` is now `prepare` and you *should not reexecute the `validate` functionality in there*! - You don't get an account ID any more; you get an origin instead. If you need to presume an account ID, then you can use the trait function `AsSystemOriginSigner::as_system_origin_signer`. - You get an additional ticket, similar to `Pre`, called `Val`. This defines data which is passed from `validate` into `prepare`. This is important since you should not be duplicating logic from `validate` to `prepare`, you need a way of passing your working from the former into the latter. This is it. - This trait takes two type parameters: `Call` and `Context`. `Call` is the runtime call type which used to be an associated type; you can just move it to become a type parameter for your trait impl. `Context` is not currently used and you can safely implement over it as an unbounded type. - There's no `AccountId` associated type any more. Just remove it. Regarding `validate`: - You get three new parameters in `validate`; all can be ignored when migrating from `SignedExtension`. - `validate` returns a tuple on success; the second item in the tuple is the new ticket type `Self::Val` which gets passed in to `prepare`. If you use any information extracted during `validate` (off-chain and on-chain, non-mutating) in `prepare` (on-chain, mutating) then you can pass it through with this. For the tuple's last item, just return the `origin` argument. Regarding `prepare`: - This is renamed from `pre_dispatch`, but there is one change: - FUNCTIONALITY TO VALIDATE THE TRANSACTION NEED NOT BE DUPLICATED FROM `validate`!! - (This is different to `SignedExtension` which was required to run the same checks in `pre_dispatch` as in `validate`.) Regarding `post_dispatch`: - Since there are no unsigned transactions handled by `TransactionExtension`, `Pre` is always defined, so the first parameter is `Self::Pre` rather than `Option<Self::Pre>`. If you make use of `SignedExtension::validate_unsigned` or `SignedExtension::pre_dispatch_unsigned`, then: - Just use the regular versions of these functions instead. - Have your logic execute in the case that the `origin` is `None`. - Ensure your transaction creation logic creates a General Transaction rather than a Bare Transaction; this means having to include all `TransactionExtension`s' data. - `ValidateUnsigned` can still be used (for now) if you need to be able to construct transactions which contain none of the extension data, however these will be phased out in stage 2 of the Transactions Horizon, so you should consider moving to an extension-centric design. ## TODO - [x] Introduce `CheckSignature` impl of `TransactionExtension` to ensure it's possible to have crypto be done wholly in a `TransactionExtension`. - [x] Deprecate `SignedExtension` and move all uses in codebase to `TransactionExtension`. - [x] `ChargeTransactionPayment` - [x] `DummyExtension` - [x] `ChargeAssetTxPayment` (asset-tx-payment) - [x] `ChargeAssetTxPayment` (asset-conversion-tx-payment) - [x] `CheckWeight` - [x] `CheckTxVersion` - [x] `CheckSpecVersion` - [x] `CheckNonce` - [x] `CheckNonZeroSender` - [x] `CheckMortality` - [x] `CheckGenesis` - [x] `CheckOnlySudoAccount` - [x] `WatchDummy` - [x] `PrevalidateAttests` - [x] `GenericSignedExtension` - [x] `SignedExtension` (chain-polkadot-bulletin) - [x] `RefundSignedExtensionAdapter` - [x] Implement `fn weight` across the board. - [ ] Go through all pre-existing extensions which assume an account signer and explicitly handle the possibility of another kind of origin. - [x] `CheckNonce` should probably succeed in the case of a non-account origin. - [x] `CheckNonZeroSender` should succeed in the case of a non-account origin. - [x] `ChargeTransactionPayment` and family should fail in the case of a non-account origin. - [ ] - [x] Fix any broken tests. --------- Signed-off-by: georgepisaltu <george.pisaltu@parity.io> Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io> Signed-off-by: Andrei Sandu <andrei-mihail@parity.io> Co-authored-by: Nikhil Gupta <17176722+gupnik@users.noreply.github.com> Co-authored-by: georgepisaltu <52418509+georgepisaltu@users.noreply.github.com> Co-authored-by: Chevdor <chevdor@users.noreply.github.com> Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: Maciej <maciej.zyszkiewicz@parity.io> Co-authored-by: Javier Viola <javier@parity.io> Co-authored-by: Marcin S. <marcin@realemail.net> Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io> Co-authored-by: Javier Bullrich <javier@bullrich.dev> Co-authored-by: Koute <koute@users.noreply.github.com> Co-authored-by: Adrian Catangiu <adrian@parity.io> Co-authored-by: Vladimir Istyufeev <vladimir@parity.io> Co-authored-by: Ross Bulat <ross@parity.io> Co-authored-by: Gonçalo Pestana <g6pestana@gmail.com> Co-authored-by: Liam Aharon <liam.aharon@hotmail.com> Co-authored-by: Svyatoslav Nikolsky <svyatonik@gmail.com> Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: s0me0ne-unkn0wn <48632512+s0me0ne-unkn0wn@users.noreply.github.com> Co-authored-by: ordian <write@reusable.software> Co-authored-by: Sebastian Kunert <skunert49@gmail.com> Co-authored-by: Aaro Altonen <48052676+altonen@users.noreply.github.com> Co-authored-by: Dmitry Markin <dmitry@markin.tech> Co-authored-by: Alexandru Vasile <60601340+lexnv@users.noreply.github.com> Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com> Co-authored-by: Julian Eager <eagr@tutanota.com> Co-authored-by: Michal Kucharczyk <1728078+michalkucharczyk@users.noreply.github.com> Co-authored-by: Davide Galassi <davxy@datawok.net> Co-authored-by: Dónal Murray <donal.murray@parity.io> Co-authored-by: yjh <yjh465402634@gmail.com> Co-authored-by: Tom Mi <tommi@niemi.lol> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Will | Paradox | ParaNodes.io <79228812+paradox-tt@users.noreply.github.com> Co-authored-by: Bastian Köcher <info@kchr.de> Co-authored-by: Joshy Orndorff <JoshOrndorff@users.noreply.github.com> Co-authored-by: Joshy Orndorff <git-user-email.h0ly5@simplelogin.com> Co-authored-by: PG Herveou <pgherveou@gmail.com> Co-authored-by: Alexander Theißen <alex.theissen@me.com> Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> Co-authored-by: Juan Girini <juangirini@gmail.com> Co-authored-by: bader y <ibnbassem@gmail.com> Co-authored-by: James Wilson <james@jsdw.me> Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com> Co-authored-by: asynchronous rob <rphmeier@gmail.com> Co-authored-by: Parth <desaiparth08@gmail.com> Co-authored-by: Andrew Jones <ascjones@gmail.com> Co-authored-by: Jonathan Udd <jonathan@dwellir.com> Co-authored-by: Serban Iorga <serban@parity.io> Co-authored-by: Egor_P <egor@parity.io> Co-authored-by: Branislav Kontur <bkontur@gmail.com> Co-authored-by: Evgeny Snitko <evgeny@parity.io> Co-authored-by: Just van Stam <vstam1@users.noreply.github.com> Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com> Co-authored-by: gupnik <nikhilgupta.iitk@gmail.com> Co-authored-by: dzmitry-lahoda <dzmitry@lahoda.pro> Co-authored-by: zhiqiangxu <652732310@qq.com> Co-authored-by: Nazar Mokrynskyi <nazar@mokrynskyi.com> Co-authored-by: Anwesh <anweshknayak@gmail.com> Co-authored-by: cheme <emericchevalier.pro@gmail.com> Co-authored-by: Sam Johnson <sam@durosoft.com> Co-authored-by: kianenigma <kian@parity.io> Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com> Co-authored-by: Muharem <ismailov.m.h@gmail.com> Co-authored-by: joepetrowski <joe@parity.io> Co-authored-by: Alexandru Gheorghe <49718502+alexggh@users.noreply.github.com> Co-authored-by: Gabriel Facco de Arruda <arrudagates@gmail.com> Co-authored-by: Squirrel <gilescope@gmail.com> Co-authored-by: Andrei Sandu <54316454+sandreim@users.noreply.github.com> Co-authored-by: georgepisaltu <george.pisaltu@parity.io> Co-authored-by: command-bot <>
480 lines
16 KiB
Rust
480 lines
16 KiB
Rust
// This file is part of Substrate.
|
|
|
|
// Copyright (C) Parity Technologies (UK) Ltd.
|
|
// SPDX-License-Identifier: Apache-2.0
|
|
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
//! Transaction validity interface.
|
|
|
|
use crate::{
|
|
codec::{Decode, Encode},
|
|
RuntimeDebug,
|
|
};
|
|
use scale_info::TypeInfo;
|
|
use sp_std::prelude::*;
|
|
|
|
/// Priority for a transaction. Additive. Higher is better.
|
|
pub type TransactionPriority = u64;
|
|
|
|
/// Minimum number of blocks a transaction will remain valid for.
|
|
/// `TransactionLongevity::max_value()` means "forever".
|
|
pub type TransactionLongevity = u64;
|
|
|
|
/// Tag for a transaction. No two transactions with the same tag should be placed on-chain.
|
|
pub type TransactionTag = Vec<u8>;
|
|
|
|
/// An invalid transaction validity.
|
|
#[derive(Clone, PartialEq, Eq, Encode, Decode, Copy, RuntimeDebug, TypeInfo)]
|
|
#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
|
|
pub enum InvalidTransaction {
|
|
/// The call of the transaction is not expected.
|
|
Call,
|
|
/// General error to do with the inability to pay some fees (e.g. account balance too low).
|
|
Payment,
|
|
/// General error to do with the transaction not yet being valid (e.g. nonce too high).
|
|
Future,
|
|
/// General error to do with the transaction being outdated (e.g. nonce too low).
|
|
Stale,
|
|
/// General error to do with the transaction's proofs (e.g. signature).
|
|
///
|
|
/// # Possible causes
|
|
///
|
|
/// When using a signed extension that provides additional data for signing, it is required
|
|
/// that the signing and the verifying side use the same additional data. Additional
|
|
/// data will only be used to generate the signature, but will not be part of the transaction
|
|
/// itself. As the verifying side does not know which additional data was used while signing
|
|
/// it will only be able to assume a bad signature and cannot express a more meaningful error.
|
|
BadProof,
|
|
/// The transaction birth block is ancient.
|
|
///
|
|
/// # Possible causes
|
|
///
|
|
/// For `FRAME`-based runtimes this would be caused by `current block number
|
|
/// - Era::birth block number > BlockHashCount`. (e.g. in Polkadot `BlockHashCount` = 2400, so
|
|
/// a
|
|
/// transaction with birth block number 1337 would be valid up until block number 1337 + 2400,
|
|
/// after which point the transaction would be considered to have an ancient birth block.)
|
|
AncientBirthBlock,
|
|
/// The transaction would exhaust the resources of current block.
|
|
///
|
|
/// The transaction might be valid, but there are not enough resources
|
|
/// left in the current block.
|
|
ExhaustsResources,
|
|
/// Any other custom invalid validity that is not covered by this enum.
|
|
Custom(u8),
|
|
/// An extrinsic with a Mandatory dispatch resulted in Error. This is indicative of either a
|
|
/// malicious validator or a buggy `provide_inherent`. In any case, it can result in
|
|
/// dangerously overweight blocks and therefore if found, invalidates the block.
|
|
BadMandatory,
|
|
/// An extrinsic with a mandatory dispatch tried to be validated.
|
|
/// This is invalid; only inherent extrinsics are allowed to have mandatory dispatches.
|
|
MandatoryValidation,
|
|
/// The sending address is disabled or known to be invalid.
|
|
BadSigner,
|
|
/// The implicit data was unable to be calculated.
|
|
IndeterminateImplicit,
|
|
}
|
|
|
|
impl InvalidTransaction {
|
|
/// Returns if the reason for the invalidity was block resource exhaustion.
|
|
pub fn exhausted_resources(&self) -> bool {
|
|
matches!(self, Self::ExhaustsResources)
|
|
}
|
|
|
|
/// Returns if the reason for the invalidity was a mandatory call failing.
|
|
pub fn was_mandatory(&self) -> bool {
|
|
matches!(self, Self::BadMandatory)
|
|
}
|
|
}
|
|
|
|
impl From<InvalidTransaction> for &'static str {
|
|
fn from(invalid: InvalidTransaction) -> &'static str {
|
|
match invalid {
|
|
InvalidTransaction::Call => "Transaction call is not expected",
|
|
InvalidTransaction::Future => "Transaction will be valid in the future",
|
|
InvalidTransaction::Stale => "Transaction is outdated",
|
|
InvalidTransaction::BadProof => "Transaction has a bad signature",
|
|
InvalidTransaction::AncientBirthBlock => "Transaction has an ancient birth block",
|
|
InvalidTransaction::ExhaustsResources => "Transaction would exhaust the block limits",
|
|
InvalidTransaction::Payment =>
|
|
"Inability to pay some fees (e.g. account balance too low)",
|
|
InvalidTransaction::BadMandatory =>
|
|
"A call was labelled as mandatory, but resulted in an Error.",
|
|
InvalidTransaction::MandatoryValidation =>
|
|
"Transaction dispatch is mandatory; transactions must not be validated.",
|
|
InvalidTransaction::Custom(_) => "InvalidTransaction custom error",
|
|
InvalidTransaction::BadSigner => "Invalid signing address",
|
|
InvalidTransaction::IndeterminateImplicit =>
|
|
"The implicit data was unable to be calculated",
|
|
}
|
|
}
|
|
}
|
|
|
|
/// An unknown transaction validity.
|
|
#[derive(Clone, PartialEq, Eq, Encode, Decode, Copy, RuntimeDebug, TypeInfo)]
|
|
#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
|
|
pub enum UnknownTransaction {
|
|
/// Could not lookup some information that is required to validate the transaction.
|
|
CannotLookup,
|
|
/// No validator found for the given unsigned transaction.
|
|
NoUnsignedValidator,
|
|
/// Any other custom unknown validity that is not covered by this enum.
|
|
Custom(u8),
|
|
}
|
|
|
|
impl From<UnknownTransaction> for &'static str {
|
|
fn from(unknown: UnknownTransaction) -> &'static str {
|
|
match unknown {
|
|
UnknownTransaction::CannotLookup =>
|
|
"Could not lookup information required to validate the transaction",
|
|
UnknownTransaction::NoUnsignedValidator =>
|
|
"Could not find an unsigned validator for the unsigned transaction",
|
|
UnknownTransaction::Custom(_) => "UnknownTransaction custom error",
|
|
}
|
|
}
|
|
}
|
|
|
|
/// Errors that can occur while checking the validity of a transaction.
|
|
#[derive(Clone, PartialEq, Eq, Encode, Decode, Copy, RuntimeDebug, TypeInfo)]
|
|
#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
|
|
pub enum TransactionValidityError {
|
|
/// The transaction is invalid.
|
|
Invalid(InvalidTransaction),
|
|
/// Transaction validity can't be determined.
|
|
Unknown(UnknownTransaction),
|
|
}
|
|
|
|
impl TransactionValidityError {
|
|
/// Returns `true` if the reason for the error was block resource exhaustion.
|
|
pub fn exhausted_resources(&self) -> bool {
|
|
match self {
|
|
Self::Invalid(e) => e.exhausted_resources(),
|
|
Self::Unknown(_) => false,
|
|
}
|
|
}
|
|
|
|
/// Returns `true` if the reason for the error was it being a mandatory dispatch that could not
|
|
/// be completed successfully.
|
|
pub fn was_mandatory(&self) -> bool {
|
|
match self {
|
|
Self::Invalid(e) => e.was_mandatory(),
|
|
Self::Unknown(_) => false,
|
|
}
|
|
}
|
|
}
|
|
|
|
impl From<TransactionValidityError> for &'static str {
|
|
fn from(err: TransactionValidityError) -> &'static str {
|
|
match err {
|
|
TransactionValidityError::Invalid(invalid) => invalid.into(),
|
|
TransactionValidityError::Unknown(unknown) => unknown.into(),
|
|
}
|
|
}
|
|
}
|
|
|
|
impl From<InvalidTransaction> for TransactionValidityError {
|
|
fn from(err: InvalidTransaction) -> Self {
|
|
TransactionValidityError::Invalid(err)
|
|
}
|
|
}
|
|
|
|
impl From<UnknownTransaction> for TransactionValidityError {
|
|
fn from(err: UnknownTransaction) -> Self {
|
|
TransactionValidityError::Unknown(err)
|
|
}
|
|
}
|
|
|
|
#[cfg(feature = "std")]
|
|
impl std::error::Error for TransactionValidityError {
|
|
fn source(&self) -> Option<&(dyn std::error::Error + 'static)> {
|
|
None
|
|
}
|
|
}
|
|
|
|
#[cfg(feature = "std")]
|
|
impl std::fmt::Display for TransactionValidityError {
|
|
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
|
|
let s: &'static str = (*self).into();
|
|
write!(f, "{}", s)
|
|
}
|
|
}
|
|
|
|
/// Information on a transaction's validity and, if valid, on how it relates to other transactions.
|
|
pub type TransactionValidity = Result<ValidTransaction, TransactionValidityError>;
|
|
|
|
impl From<InvalidTransaction> for TransactionValidity {
|
|
fn from(invalid_transaction: InvalidTransaction) -> Self {
|
|
Err(TransactionValidityError::Invalid(invalid_transaction))
|
|
}
|
|
}
|
|
|
|
impl From<UnknownTransaction> for TransactionValidity {
|
|
fn from(unknown_transaction: UnknownTransaction) -> Self {
|
|
Err(TransactionValidityError::Unknown(unknown_transaction))
|
|
}
|
|
}
|
|
|
|
/// The source of the transaction.
|
|
///
|
|
/// Depending on the source we might apply different validation schemes.
|
|
/// For instance we can disallow specific kinds of transactions if they were not produced
|
|
/// by our local node (for instance off-chain workers).
|
|
#[derive(Copy, Clone, PartialEq, Eq, Encode, Decode, RuntimeDebug, TypeInfo)]
|
|
pub enum TransactionSource {
|
|
/// Transaction is already included in block.
|
|
///
|
|
/// This means that we can't really tell where the transaction is coming from,
|
|
/// since it's already in the received block. Note that the custom validation logic
|
|
/// using either `Local` or `External` should most likely just allow `InBlock`
|
|
/// transactions as well.
|
|
InBlock,
|
|
|
|
/// Transaction is coming from a local source.
|
|
///
|
|
/// This means that the transaction was produced internally by the node
|
|
/// (for instance an Off-Chain Worker, or an Off-Chain Call), as opposed
|
|
/// to being received over the network.
|
|
Local,
|
|
|
|
/// Transaction has been received externally.
|
|
///
|
|
/// This means the transaction has been received from (usually) "untrusted" source,
|
|
/// for instance received over the network or RPC.
|
|
External,
|
|
}
|
|
|
|
/// Information concerning a valid transaction.
|
|
#[derive(Clone, PartialEq, Eq, Encode, Decode, RuntimeDebug, TypeInfo)]
|
|
pub struct ValidTransaction {
|
|
/// Priority of the transaction.
|
|
///
|
|
/// Priority determines the ordering of two transactions that have all
|
|
/// their dependencies (required tags) satisfied.
|
|
pub priority: TransactionPriority,
|
|
/// Transaction dependencies
|
|
///
|
|
/// A non-empty list signifies that some other transactions which provide
|
|
/// given tags are required to be included before that one.
|
|
pub requires: Vec<TransactionTag>,
|
|
/// Provided tags
|
|
///
|
|
/// A list of tags this transaction provides. Successfully importing the transaction
|
|
/// will enable other transactions that depend on (require) those tags to be included as well.
|
|
/// Provided and required tags allow Substrate to build a dependency graph of transactions
|
|
/// and import them in the right (linear) order.
|
|
pub provides: Vec<TransactionTag>,
|
|
/// Transaction longevity
|
|
///
|
|
/// Longevity describes minimum number of blocks the validity is correct.
|
|
/// After this period transaction should be removed from the pool or revalidated.
|
|
pub longevity: TransactionLongevity,
|
|
/// A flag indicating if the transaction should be propagated to other peers.
|
|
///
|
|
/// By setting `false` here the transaction will still be considered for
|
|
/// including in blocks that are authored on the current node, but will
|
|
/// never be sent to other peers.
|
|
pub propagate: bool,
|
|
}
|
|
|
|
impl Default for ValidTransaction {
|
|
fn default() -> Self {
|
|
Self {
|
|
priority: 0,
|
|
requires: vec![],
|
|
provides: vec![],
|
|
longevity: TransactionLongevity::max_value(),
|
|
propagate: true,
|
|
}
|
|
}
|
|
}
|
|
|
|
impl ValidTransaction {
|
|
/// Initiate `ValidTransaction` builder object with a particular prefix for tags.
|
|
///
|
|
/// To avoid conflicts between different parts in runtime it's recommended to build `requires`
|
|
/// and `provides` tags with a unique prefix.
|
|
pub fn with_tag_prefix(prefix: &'static str) -> ValidTransactionBuilder {
|
|
ValidTransactionBuilder { prefix: Some(prefix), validity: Default::default() }
|
|
}
|
|
|
|
/// Combine two instances into one, as a best effort. This will take the superset of each of the
|
|
/// `provides` and `requires` tags, it will sum the priorities, take the minimum longevity and
|
|
/// the logic *And* of the propagate flags.
|
|
pub fn combine_with(mut self, mut other: ValidTransaction) -> Self {
|
|
Self {
|
|
priority: self.priority.saturating_add(other.priority),
|
|
requires: {
|
|
self.requires.append(&mut other.requires);
|
|
self.requires
|
|
},
|
|
provides: {
|
|
self.provides.append(&mut other.provides);
|
|
self.provides
|
|
},
|
|
longevity: self.longevity.min(other.longevity),
|
|
propagate: self.propagate && other.propagate,
|
|
}
|
|
}
|
|
}
|
|
|
|
/// `ValidTransaction` builder.
|
|
///
|
|
///
|
|
/// Allows to easily construct `ValidTransaction` and most importantly takes care of
|
|
/// prefixing `requires` and `provides` tags to avoid conflicts.
|
|
#[derive(Default, Clone, RuntimeDebug)]
|
|
pub struct ValidTransactionBuilder {
|
|
prefix: Option<&'static str>,
|
|
validity: ValidTransaction,
|
|
}
|
|
|
|
impl ValidTransactionBuilder {
|
|
/// Set the priority of a transaction.
|
|
///
|
|
/// Note that the final priority for `FRAME` is combined from all `TransactionExtension`s.
|
|
/// Most likely for unsigned transactions you want the priority to be higher
|
|
/// than for regular transactions. We recommend exposing a base priority for unsigned
|
|
/// transactions as a runtime module parameter, so that the runtime can tune inter-module
|
|
/// priorities.
|
|
pub fn priority(mut self, priority: TransactionPriority) -> Self {
|
|
self.validity.priority = priority;
|
|
self
|
|
}
|
|
|
|
/// Set the longevity of a transaction.
|
|
///
|
|
/// By default the transaction will be considered valid forever and will not be revalidated
|
|
/// by the transaction pool. It's recommended though to set the longevity to a finite value
|
|
/// though. If unsure, it's also reasonable to expose this parameter via module configuration
|
|
/// and let the runtime decide.
|
|
pub fn longevity(mut self, longevity: TransactionLongevity) -> Self {
|
|
self.validity.longevity = longevity;
|
|
self
|
|
}
|
|
|
|
/// Set the propagate flag.
|
|
///
|
|
/// Set to `false` if the transaction is not meant to be gossiped to peers. Combined with
|
|
/// `TransactionSource::Local` validation it can be used to have special kind of
|
|
/// transactions that are only produced and included by the validator nodes.
|
|
pub fn propagate(mut self, propagate: bool) -> Self {
|
|
self.validity.propagate = propagate;
|
|
self
|
|
}
|
|
|
|
/// Add a `TransactionTag` to the set of required tags.
|
|
///
|
|
/// The tag will be encoded and prefixed with module prefix (if any).
|
|
/// If you'd rather add a raw `require` tag, consider using `#combine_with` method.
|
|
pub fn and_requires(mut self, tag: impl Encode) -> Self {
|
|
self.validity.requires.push(match self.prefix.as_ref() {
|
|
Some(prefix) => (prefix, tag).encode(),
|
|
None => tag.encode(),
|
|
});
|
|
self
|
|
}
|
|
|
|
/// Add a `TransactionTag` to the set of provided tags.
|
|
///
|
|
/// The tag will be encoded and prefixed with module prefix (if any).
|
|
/// If you'd rather add a raw `require` tag, consider using `#combine_with` method.
|
|
pub fn and_provides(mut self, tag: impl Encode) -> Self {
|
|
self.validity.provides.push(match self.prefix.as_ref() {
|
|
Some(prefix) => (prefix, tag).encode(),
|
|
None => tag.encode(),
|
|
});
|
|
self
|
|
}
|
|
|
|
/// Augment the builder with existing `ValidTransaction`.
|
|
///
|
|
/// This method does add the prefix to `require` or `provides` tags.
|
|
pub fn combine_with(mut self, validity: ValidTransaction) -> Self {
|
|
self.validity = core::mem::take(&mut self.validity).combine_with(validity);
|
|
self
|
|
}
|
|
|
|
/// Finalize the builder and produce `TransactionValidity`.
|
|
///
|
|
/// Note the result will always be `Ok`. Use `Into` to produce `ValidTransaction`.
|
|
pub fn build(self) -> TransactionValidity {
|
|
self.into()
|
|
}
|
|
}
|
|
|
|
impl From<ValidTransactionBuilder> for TransactionValidity {
|
|
fn from(builder: ValidTransactionBuilder) -> Self {
|
|
Ok(builder.into())
|
|
}
|
|
}
|
|
|
|
impl From<ValidTransactionBuilder> for ValidTransaction {
|
|
fn from(builder: ValidTransactionBuilder) -> Self {
|
|
builder.validity
|
|
}
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod tests {
|
|
use super::*;
|
|
|
|
#[test]
|
|
fn should_encode_and_decode() {
|
|
let v: TransactionValidity = Ok(ValidTransaction {
|
|
priority: 5,
|
|
requires: vec![vec![1, 2, 3, 4]],
|
|
provides: vec![vec![4, 5, 6]],
|
|
longevity: 42,
|
|
propagate: false,
|
|
});
|
|
|
|
let encoded = v.encode();
|
|
assert_eq!(
|
|
encoded,
|
|
vec![
|
|
0, 5, 0, 0, 0, 0, 0, 0, 0, 4, 16, 1, 2, 3, 4, 4, 12, 4, 5, 6, 42, 0, 0, 0, 0, 0, 0,
|
|
0, 0
|
|
]
|
|
);
|
|
|
|
// decode back
|
|
assert_eq!(TransactionValidity::decode(&mut &*encoded), Ok(v));
|
|
}
|
|
|
|
#[test]
|
|
fn builder_should_prefix_the_tags() {
|
|
const PREFIX: &str = "test";
|
|
let a: ValidTransaction = ValidTransaction::with_tag_prefix(PREFIX)
|
|
.and_requires(1)
|
|
.and_requires(2)
|
|
.and_provides(3)
|
|
.and_provides(4)
|
|
.propagate(false)
|
|
.longevity(5)
|
|
.priority(3)
|
|
.priority(6)
|
|
.into();
|
|
assert_eq!(
|
|
a,
|
|
ValidTransaction {
|
|
propagate: false,
|
|
longevity: 5,
|
|
priority: 6,
|
|
requires: vec![(PREFIX, 1).encode(), (PREFIX, 2).encode()],
|
|
provides: vec![(PREFIX, 3).encode(), (PREFIX, 4).encode()],
|
|
}
|
|
);
|
|
}
|
|
}
|